Squeak-dev December 2010

squeak-dev@lists.squeakfoundation.org

95 participants
379 discussions

Compiler complains in the Transcript for Undeclared variables in blocks
by Nicolas Cellier 29 Dec '10

29 Dec '10

This happens when running DecompilerTests. In some cases, when a block accesses an outer temp variable, there is a complaint in the Transcript. ChangeSorter>>messageList (thisClass is Undeclared) ClassChangeRecord>>forgetChangesIn: (cls is Undeclared) EtoysPresenter>>nascentPartsViewerFor: (aVocab is Undeclared) EtoysPresenter>>nascentPartsViewerFor: (aVocab is Undeclared) NewParagraph>>clickAt:for:controller: (target is Undeclared) NewParagraph>>clickAt:for:controller: (target is Undeclared) ParagraphEditor>>browseItHere (aSymbol is Undeclared) ParagraphEditor>>browseChangeSetsWithSelector (aSelector is Undeclared) ParagraphEditor>>implementorsOfIt (aSelector is Undeclared) ParagraphEditor>>sendersOfIt (aSelector is Undeclared) PianoRollScoreMorph>>insertTransposed (delta is Undeclared) Player>>updateAllViewers (aPresenter is Undeclared) Player>>updateAllViewersAndForceToShow: (aPresenter is Undeclared) Player>>createSlotForPatch: (aPresenter is Undeclared) PostscriptCanvas>>drawPostscriptContext: (contents is Undeclared) StackMorph>>templateMatches (keys is Undeclared) Nicolas

1 0

Re: [squeak-dev] The Trunk: Graphics-mtf.165.mcz
by Bert Freudenberg 29 Dec '10

29 Dec '10

On 29.12.2010, at 05:12, commits(a)source.squeak.org wrote: > Matthew Fulmer uploaded a new version of Graphics to project The Trunk: > http://source.squeak.org/trunk/Graphics-mtf.165.mcz > > ==================== Summary ==================== > > Name: Graphics-mtf.165 > Author: mtf > Time: 29 December 2010, 12:10:24.297 am > UUID: ad093cc3-3d69-7f42-969e-a103e2dca6a3 > Ancestors: Graphics-mtf.164 > > added u, v accessors to Point, for convenience when dealing with textures. cherrypicked from Cobalt: Hmm. Why can't these remain extension methods? - Bert -

1 0

The Trunk: Kernel-nice.536.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.536.mcz ==================== Summary ==================== Name: Kernel-nice.536 Author: nice Time: 29 December 2010, 1:46:35.807 pm UUID: 4a558059-d69d-48b6-a118-0930c12d98b9 Ancestors: Kernel-nice.535 redo last change after an update =============== Diff against Kernel-nice.535 =============== Item was changed: ----- Method: ClassDescription>>isClassSide (in category 'accessing parallel hierarchy') ----- isClassSide + ^self isMeta! - ^self == self classSide!

1 0

The Trunk: Kernel-nice.535.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.535.mcz ==================== Summary ==================== Name: Kernel-nice.535 Author: nice Time: 29 December 2010, 1:23:53.998 pm UUID: 779b35c6-c256-407f-96f0-17420be3d5e6 Ancestors: Kernel-nice.534 revert last change because MC load order will create an infinite loop. =============== Diff against Kernel-nice.534 =============== Item was changed: ----- Method: ClassDescription>>isClassSide (in category 'accessing parallel hierarchy') ----- isClassSide + ^self == self classSide! - ^self isMeta!

1 0

The Trunk: Traits-nice.286.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Nicolas Cellier uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-nice.286.mcz ==================== Summary ==================== Name: Traits-nice.286 Author: nice Time: 29 December 2010, 12:36:11.677 pm UUID: c2384ab9-a608-4300-96da-9c6639491314 Ancestors: Traits-nice.285 Remove redundant methods. =============== Diff against Traits-nice.285 =============== Item was removed: - ----- Method: ClassTrait>>classSide (in category 'accessing') ----- - classSide - ^self!

1 0

The Trunk: Kernel-nice.534.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.534.mcz ==================== Summary ==================== Name: Kernel-nice.534 Author: nice Time: 29 December 2010, 12:35:17.044 pm UUID: 21447744-bd08-42bd-a376-456564424dc5 Ancestors: Kernel-nice.532 Remove redundant methods. =============== Diff against Kernel-nice.532 =============== Item was changed: ----- Method: ClassDescription>>isClassSide (in category 'accessing parallel hierarchy') ----- isClassSide + ^self isMeta! - ^self == self classSide! Item was removed: - ----- Method: ClassDescription>>isMeta (in category 'accessing parallel hierarchy') ----- - isMeta - ^self isClassSide!

1 0

The Inbox: Kernel-nice.533.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-nice.533.mcz ==================== Summary ==================== Name: Kernel-nice.533 Author: nice Time: 29 December 2010, 12:23:26.17 pm UUID: 477d8325-a6e0-469f-a805-27e058d930fd Ancestors: Kernel-nice.532 1) Let Behavior>>deepCopy return self, senders of deepCopy generally have no reason to copy a Behavior. Moreover, the old code did a shallowCopy which is a non sense. 2) Make it explicit that veryDeepCopy does not copy any Behavior. This was explicit for Metaclass, but implicit for Class (see Object>>#veryDeepInner: ), and undefined for Traits (they are not used, but who knows...). =============== Diff against Kernel-nice.532 =============== Item was changed: ----- Method: Behavior>>deepCopy (in category 'copying') ----- deepCopy + "Behavior are shared rather than copied." - "Classes should only be shallowCopied or made anew." + ^ self! - ^ self shallowCopy! Item was added: + ----- Method: Behavior>>veryDeepCopyWith: (in category 'copying') ----- + veryDeepCopyWith: deepCopier + "Return self. Must be created, not copied. Do not record me."! Item was removed: - ----- Method: Metaclass>>veryDeepCopyWith: (in category 'copying') ----- - veryDeepCopyWith: deepCopier - "Return self. Must be created, not copied. Do not record me."!

1 0

Behavior deepCopy smells
by Nicolas Cellier 29 Dec '10

29 Dec '10

I think that Behavior>>deepCopy should either ^self or ^self copy but not ^self shallowCopy because the methodDictionary should be copied not shared (plus problems with shared subclasses, Metaclass soleInstance etc...). I suggest ^self. OK ? Nicolas

1 0

The Trunk: Kernel-nice.532.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.532.mcz ==================== Summary ==================== Name: Kernel-nice.532 Author: nice Time: 29 December 2010, 10:59:42.464 am UUID: 30e481ee-c2ee-4d10-8484-ec8da55ae54a Ancestors: Kernel-ar.531 A] Clean-up Behavior and Metaclass copy by using postCopy paradigm. Advantage 1: This cleans up the false comment of Behavior>>copy (no, it does not copy without a list of subclasses). This cleans up the false comment of Metaclass>>copy (no, it does share the reference to the sole instance). Advantage 2: The new code is shorter, simpler and avoids niling thisClass temporarily (this was dangerous). B] Fix Class>>copy : the sharedPool shall not be shared (if you #addSharedPool: to the copy and the original already has a sharedPool, then you #addSharedPool: to the original too...). Move the comments "Answer a copy of the receiver without a list of subclasses." where it belongs, in Class>>copy. =============== Diff against Kernel-ar.531 =============== Item was removed: - ----- Method: Behavior>>copy (in category 'copying') ----- - copy - "Answer a copy of the receiver without a list of subclasses." - - | myCopy | - myCopy := self shallowCopy. - ^myCopy methodDictionary: self copyOfMethodDictionary! Item was added: + ----- Method: Behavior>>postCopy (in category 'copying') ----- + postCopy + super postCopy. + self methodDict: self methodDict copy! Item was changed: ----- Method: Class>>copy (in category 'copying') ----- copy + "Answer a copy of the receiver without a list of subclasses." | newClass | newClass := self class copy new superclass: superclass methodDict: self methodDict copy format: format name: name organization: self organization copy instVarNames: instanceVariables copy classPool: classPool copy + sharedPools: sharedPools copy. - sharedPools: sharedPools. Class instSize+1 to: self class instSize do: [:offset | newClass instVarAt: offset put: (self instVarAt: offset)]. ^ newClass! Item was removed: - ----- Method: Metaclass>>copy (in category 'copying') ----- - copy - "Make a copy of the receiver without a list of subclasses. Share the - reference to the sole instance." - - | copy t | - t := thisClass. - thisClass := nil. - copy := super copy. - thisClass := t. - ^copy! Item was added: + ----- Method: Metaclass>>postCopy (in category 'copying') ----- + postCopy + "Don't share the reference to the sole instance." + + super postCopy. + thisClass := nil.!

1 0

The Trunk: Graphics-mtf.169.mcz
by commits＠source.squeak.org 29 Dec '10

29 Dec '10

Matthew Fulmer uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mtf.169.mcz ==================== Summary ==================== Name: Graphics-mtf.169 Author: mtf Time: 29 December 2010, 12:59:48.477 am UUID: 2066ddb9-5bc4-4548-bb7f-7e1442ac5cf0 Ancestors: Graphics-mtf.168 imported some DisplayTransform methods from Croquet. Cherrypicked from Croquet: Name: Graphics-ar.8 Author: ar Time: 7 March 2006, 5:56:20 pm UUID: 48cbe812-7767-3049-ba7a-1e8b3f532519 Ancestors: Graphics-ar.7 - Tweak-Homebase merge =============== Diff against Graphics-mtf.168 =============== Item was added: + ----- Method: DisplayTransform>>invertPoint: (in category 'transforming points') ----- + invertPoint: aPoint + ^self globalPointToLocal: aPoint! Item was added: + ----- Method: DisplayTransform>>invertRect: (in category 'transforming rects') ----- + invertRect: aRectangle + ^self globalBoundsToLocal: aRectangle! Item was added: + ----- Method: DisplayTransform>>transformRect: (in category 'transforming rects') ----- + transformRect: aRectangle + ^self localBoundsToGlobal: aRectangle! Item was added: + ----- Method: DisplayTransform>>transformedBy: (in category 'converting') ----- + transformedBy: aTransform + ^self composedWithGlobal: aTransform!

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
38
Older →

Jump to page: