Squeak-dev September 2012

squeak-dev@lists.squeakfoundation.org

36 participants
151 discussions

The Trunk: System-ul.498.mcz
by commits＠source.squeak.org 30 Sep '12

30 Sep '12

Levente Uzonyi uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ul.498.mcz ==================== Summary ==================== Name: System-ul.498 Author: ul Time: 28 September 2012, 11:04:36.54 am UUID: cee97707-7da6-c943-a664-3e8a6f185f37 Ancestors: System-ul.494 Another possible fix for ClassRemovalTest >> #testClassRemovalAndRecompilcationWontCreateDuplicateVariableBindings. This time when the class is removed: - replace the bindings in that class with a copy - search for other referrers in the system - if such referrer was found, then nil out the value of the original binding and move it to Undeclared =============== Diff against System-ul.494 =============== Item was changed: ----- Method: SystemDictionary>>forgetClass:logged: (in category 'classes and traits') ----- forgetClass: aClass logged: aBool "Delete the class, aClass, from the system. Note that this doesn't do everything required to dispose of a class - to do that use Class>>removeFromSystem." aBool ifTrue: [SystemChangeNotifier uniqueInstance classRemoved: aClass fromCategory: aClass category]. self organization removeElement: aClass name. Smalltalk removeFromStartUpList: aClass. Smalltalk removeFromShutDownList: aClass. + aClass isObsolete ifFalse: [ + (self associationAt: aClass name ifAbsent: [ nil ]) ifNotNil: [ :oldBinding | + | newBinding | + newBinding := oldBinding shallowCopy. + self replaceBinding: oldBinding in: aClass with: newBinding. + (self isThisBindingReferred: oldBinding) ifTrue: [ + oldBinding value: nil. + Undeclared add: oldBinding ] ] ]. self removeKey: aClass name ifAbsent: []. + self flushClassNameCache! - self flushClassNameCache.! Item was added: + ----- Method: SystemDictionary>>isThisBindingReferred: (in category 'classes and traits') ----- + isThisBindingReferred: binding + + self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | + (method instVarsInclude: binding) ifTrue: [ + method literalsDo: [ :literal | "Avoid possible false positives from the primitive." + literal == binding ifTrue: [ ^true ] ] ] ]. + ^false! Item was added: + ----- Method: SystemDictionary>>replaceBinding:in:with: (in category 'classes and traits') ----- + replaceBinding: oldBinding in: aClass with: newBinding + "Replace oldBinding with newBinding in aClass. This method is expected to be used during the removal of aClass." + + aClass methodsDo: [ :method | + 1 to: method numLiterals do: [ :index | + (method literalAt: index) == oldBinding ifTrue: [ + method literalAt: index put: newBinding ] ] ]! Item was added: + ----- Method: SystemDictionary>>replaceBinding:inAllMethodsWith: (in category 'classes and traits') ----- + replaceBinding: oldBinding inAllMethodsWith: newBinding + "Replace oldBinding to newBinding in all methods in the system except for those which are the methods of the class of oldBinding. Return true if such replacement were made, false otherwise." + + | foundReferringMethod | + foundReferringMethod := false. + self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | + (behavior ~~ oldBinding value and: [ + method instVarsInclude: oldBinding ]) ifTrue: [ "Use the fast primitive first." + "The penultimate literal holds the selector of the method, the last literal is the class." + 1 to: method numLiterals - 2 do: [ :index | + (method literalAt: index) == oldBinding ifTrue: [ + foundReferringMethod := true. + method + literalAt: index put: newBinding; + flushCache ] ] ] ]. + ^foundReferringMethod!

1 0

The Trunk: Traits-ul.290.mcz
by commits＠source.squeak.org 30 Sep '12

30 Sep '12

Levente Uzonyi uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-ul.290.mcz ==================== Summary ==================== Name: Traits-ul.290 Author: ul Time: 28 September 2012, 10:30:33.464 am UUID: 3e58b2db-945d-5e41-b9d8-5f5880d86ca8 Ancestors: Traits-ul.289 Speed up Trait class>>allTraitsDo: by using Smalltalk instead of #allInstances. =============== Diff against Traits-ul.289 =============== Item was changed: ----- Method: Trait class>>allTraitsDo: (in category 'public') ----- allTraitsDo: aBlock "Evaluate aBlock with all the instance and class traits present in the system" + + Smalltalk allTraitsDo: [ :aTrait | + aBlock + value: aTrait instanceSide; + value: aTrait classSide ]! - Trait allInstances do: [:aTrait| - aBlock value: aTrait instanceSide. - aBlock value: aTrait classSide. - ].!

1 0

The Inbox: Monticello-djm.526.mcz
by commits＠source.squeak.org 30 Sep '12

30 Sep '12

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-djm.526.mcz ==================== Summary ==================== Name: Monticello-djm.526 Author: djm Time: 29 September 2012, 6:32:11.647 pm UUID: f5af1d80-d6bb-4193-b287-85e06123c798 Ancestors: Monticello-bf.525 Adding missing subclass responsibility method MCWriteOnlyRepository>>versionNamesForPackageNamed: to fix bug in saving to an smtp repository. =============== Diff against Monticello-bf.525 =============== Item was added: + ----- Method: MCWriteOnlyRepository>>versionNamesForPackageNamed: (in category 'as yet unclassified') ----- + versionNamesForPackageNamed: aString + "Answer a collection of MCVersionNames whose Package is named aString." + ^{}!

1 0

Daily Commit Log
by commits＠source.squeak.org 30 Sep '12

30 Sep '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-September/005527.… Name: Tests-ul.171 Ancestors: Tests-dtl.170 Keep the timestamp of methods in PCCByCompilation>>privateDisableCallIn: and PCCByCompilation>>privateEnableCallIn:. =============================================

1 0

Altitude - Seaside JSON example
by Chris Cunnington 29 Sep '12

29 Sep '12

http://ss3.gemstone.com/ss/Oakville/AL-Examples-chc.13.mcz I've taken the Seaside JSON example from Seaside 3.0.6 and put it into Altitude. Load AL-Eamples-chc.13.mcz into a working Altitude image (load script at the bottom of this post). The example loads a bunch of pictures from Flickr's Seaside (as in pictures of the beach) account. Then: server := ALServer on: 8624 application: ALExampleApplication new. server start Go to http://localhost:8624 In Seaside it's mainly pure JavaScript. Not a lot of abstraction over the JavaScript there. It's an interesting question what the sweet spot of abstracting over JavaScript really is. Altitude has none. Seaside has lots. For this JSON example it sort of looks the same on both frameworks. Chris | oldPref oldAuth| oldPref := Scanner prefAllowUnderscoreSelectors. oldAuth := Utilities authorInitialsPerSe. Scanner prefAllowUnderscoreSelectors: true. Utilities setAuthorInitials: 'al-loader'. $_ tokenish ifFalse: [ Character compile: 'tokenish "Answer whether the receiver is a valid token-character--letter, digit, or colon." ^self == $_ or: [self == $: or: [self isLetter or: [self isDigit]]]' classified: 'testing'. String initialize ]. (Installer repository: 'http://source.squeak.org/FFI') install: 'FFI-Pools'; install: 'FFI-Kernel'; install: 'FFI-Tests'; install: 'FFI-Win32'; install: 'FFI-MacOS'; install: 'FFI-Unix'. (Installer wiresong project: 'al') addPackage: 'Xtreams-Support'; addPackage: 'Xtreams-CoreTests'; addPackage: 'Xtreams-Core'; addPackage: 'Xtreams-Substreams'; addPackage: 'Xtreams-Terminals'; addPackage: 'Xtreams-Parsing'; addPackage: 'Xtreams-Http'; addPackage: 'Xtreams-Xtras'; addPackage: 'Xtreams-ParsingTests'; addPackage: 'Xtreams-TerminalsTests'; addPackage: 'Xtreams-XtrasTests'; addPackage: 'Xtreams-SubstreamsTests'; addPackage: 'Xtreams-TransformsTests'; addPackage: 'Xtreams-Transforms'; addPackage: 'Xtreams-HttpTests'; install. Scanner prefAllowUnderscoreSelectors: oldPref. Utilities setAuthorInitials: oldAuth. (Installer wiresong project: 'mc') addPackage: 'FS-Core'; addPackage: 'FS-Disk'; addPackage: 'FS-Memory'; addPackage: 'FS-AnsiStreams'; addPackage: 'FS-Zip'; addPackage: 'FS-Xtreams'; addPackage: 'FS-FileStream'; addPackage: 'FS-Tests-Core'; addPackage: 'FS-Tests-AnsiStreams'; addPackage: 'FS-Tests-Xtreams'; addPackage: 'FS-Tests-Zip'; addPackage: 'FS-Tests-Disk'; addPackage: 'FS-Tests-FileStream'; install. (Installer wiresong project: 'al') addPackage: 'AL-Rendering'; addPackage: 'AL-Http'; addPackage: 'AL-Application'; addPackage: 'AL-Serialization'; addPackage: 'AL-Json'; addPackage: 'AL-Html5'; addPackage: 'AL-HtmlApp'; addPackage: 'AL-User'; addPackage: 'AL-Examples'; addPackage: 'AL-Tests-Json'; addPackage: 'AL-Tests-Html5'; addPackage: 'AL-Tests-User'; addPackage: 'AL-Tests-Serialization'; addPackage: 'AL-Tests-Http'; addPackage: 'AL-Tests-Application'; install.

3 9

Re: [squeak-dev] The Trunk: Tests-ul.171.mcz
by Frank Shearar 29 Sep '12

29 Sep '12

On 29 September 2012 09:11, <commits(a)source.squeak.org> wrote: > Levente Uzonyi uploaded a new version of Tests to project The Trunk: > http://source.squeak.org/trunk/Tests-ul.171.mcz > > ==================== Summary ==================== > > Name: Tests-ul.171 > Author: ul > Time: 29 September 2012, 9:48:51.438 am > UUID: 647a45be-83ba-5d49-8ad6-198909ed5b70 > Ancestors: Tests-dtl.170 > > Keep the timestamp of methods in PCCByCompilation>>privateDisableCallIn: and PCCByCompilation>>privateEnableCallIn:. > > =============== Diff against Tests-dtl.170 =============== Just for the record, Levente wrote as script that now means that commits to Trunk trigger builds of SqueakTrunk and UpdateFromLastRelease on the CI server. Thanks, Levente! frank

1 0

The Trunk: Tests-ul.171.mcz
by commits＠source.squeak.org 29 Sep '12

29 Sep '12

Levente Uzonyi uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ul.171.mcz ==================== Summary ==================== Name: Tests-ul.171 Author: ul Time: 29 September 2012, 9:48:51.438 am UUID: 647a45be-83ba-5d49-8ad6-198909ed5b70 Ancestors: Tests-dtl.170 Keep the timestamp of methods in PCCByCompilation>>privateDisableCallIn: and PCCByCompilation>>privateEnableCallIn:. =============== Diff against Tests-dtl.170 =============== Item was changed: ----- Method: PCCByCompilation>>privateDisableCallIn: (in category 'private user interface') ----- privateDisableCallIn: aMethodRef "Disables enabled or failed external prim call by recompiling method with prim call commented out, will be called by superclass." | src newMethodSource | "higher priority to avoid source file accessing errors" src := [aMethodRef sourceString] valueAt: self higherPriority. newMethodSource := self enabled2DisabledPrimMethodString: src. "higher priority to avoid source file accessing errors" [aMethodRef actualClass compile: newMethodSource classified: (aMethodRef actualClass whichCategoryIncludesSelector: aMethodRef methodSymbol) + withStamp: aMethodRef timeStamp notifying: nil] valueAt: self higherPriority! Item was changed: ----- Method: PCCByCompilation>>privateEnableCallIn: (in category 'private user interface') ----- privateEnableCallIn: aMethodRef "Enables disabled external prim call by recompiling method with prim call taken from disabling comment, will be called by superclass." | src newMethodSource | "higher priority to avoid source file accessing errors" src := [aMethodRef sourceString] valueAt: self higherPriority. newMethodSource := self disabled2EnabledPrimMethodString: src. "higher priority to avoid source file accessing errors" [aMethodRef actualClass compile: newMethodSource classified: (aMethodRef actualClass whichCategoryIncludesSelector: aMethodRef methodSymbol) + withStamp: aMethodRef timeStamp notifying: nil] valueAt: self higherPriority!

1 0

References to a removed and reloaded class
by Levente Uzonyi 28 Sep '12

28 Sep '12

Hi, I found a bug recently which has the following symptoms: - If you remove a class from the system, which is referenced from a method, then the method will keep a reference for the class, but the class will be obsolete. - If you create a class with the same name, then the old references will still point to the old, obsolete class instead of the new one. So there will be two bindings in the system using the same class name, but pointing to different classes. In order to fix this bug, I came up with two ideas: 1) Recompile all methods which point to the old class when the class is removed. This helps, because the class will be undeclared at that point, so a new binding will be stored in Undeclared and the same binding will be used when the class is added again. The drawback of this solution is that it only fixes references in methods and it's slow, since it has to scan all methods in the system. 2) Create a new object (a datastructure) which points to the binding weakly and provides fast lookup by class name. Store the binding in this object when the class is removed and when a class is added, then check this object for existing bindings (besides Undeclared). This solution is fast, but more complicated than the previous one. But the same kind of datastructure can be used to replace Undeclared, so it will not hold onto bindings unnecessarily and it won't have to be cleared manually. I uploaded a few days ago System-ul.497.mcz to the Inbox which provides solution #1. There are ways to improve the performance of SystemNavigation >> #allCallsOn: by ~20%, so it will take only 20-40ms more to remove a class from the system, which might be good enough for now. In 4.5 I'd like to implement solution #2 and replace Undeclared to work this way too, but I think for 4.4 we can live with solution #1. What do you think? Cheers, Levente

3 14

The Inbox: System-ul.498.mcz
by commits＠source.squeak.org 28 Sep '12

28 Sep '12

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ul.498.mcz ==================== Summary ==================== Name: System-ul.498 Author: ul Time: 28 September 2012, 11:04:36.54 am UUID: cee97707-7da6-c943-a664-3e8a6f185f37 Ancestors: System-ul.494 Another possible fix for ClassRemovalTest >> #testClassRemovalAndRecompilcationWontCreateDuplicateVariableBindings. This time when the class is removed: - replace the bindings in that class with a copy - search for other referrers in the system - if such referrer was found, then nil out the value of the original binding and move it to Undeclared =============== Diff against System-ul.494 =============== Item was changed: ----- Method: SystemDictionary>>forgetClass:logged: (in category 'classes and traits') ----- forgetClass: aClass logged: aBool "Delete the class, aClass, from the system. Note that this doesn't do everything required to dispose of a class - to do that use Class>>removeFromSystem." aBool ifTrue: [SystemChangeNotifier uniqueInstance classRemoved: aClass fromCategory: aClass category]. self organization removeElement: aClass name. Smalltalk removeFromStartUpList: aClass. Smalltalk removeFromShutDownList: aClass. + aClass isObsolete ifFalse: [ + (self associationAt: aClass name ifAbsent: [ nil ]) ifNotNil: [ :oldBinding | + | newBinding | + newBinding := oldBinding shallowCopy. + self replaceBinding: oldBinding in: aClass with: newBinding. + (self isThisBindingReferred: oldBinding) ifTrue: [ + oldBinding value: nil. + Undeclared add: oldBinding ] ] ]. self removeKey: aClass name ifAbsent: []. + self flushClassNameCache! - self flushClassNameCache.! Item was added: + ----- Method: SystemDictionary>>isThisBindingReferred: (in category 'classes and traits') ----- + isThisBindingReferred: binding + + self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | + (method instVarsInclude: binding) ifTrue: [ + method literalsDo: [ :literal | "Avoid possible false positives from the primitive." + literal == binding ifTrue: [ ^true ] ] ] ]. + ^false! Item was added: + ----- Method: SystemDictionary>>replaceBinding:in:with: (in category 'classes and traits') ----- + replaceBinding: oldBinding in: aClass with: newBinding + "Replace oldBinding with newBinding in aClass. This method is expected to be used during the removal of aClass." + + aClass methodsDo: [ :method | + 1 to: method numLiterals do: [ :index | + (method literalAt: index) == oldBinding ifTrue: [ + method literalAt: index put: newBinding ] ] ]! Item was added: + ----- Method: SystemDictionary>>replaceBinding:inAllMethodsWith: (in category 'classes and traits') ----- + replaceBinding: oldBinding inAllMethodsWith: newBinding + "Replace oldBinding to newBinding in all methods in the system except for those which are the methods of the class of oldBinding. Return true if such replacement were made, false otherwise." + + | foundReferringMethod | + foundReferringMethod := false. + self systemNavigation allSelectorsAndMethodsDo: [ :behavior :selector :method | + (behavior ~~ oldBinding value and: [ + method instVarsInclude: oldBinding ]) ifTrue: [ "Use the fast primitive first." + "The penultimate literal holds the selector of the method, the last literal is the class." + 1 to: method numLiterals - 2 do: [ :index | + (method literalAt: index) == oldBinding ifTrue: [ + foundReferringMethod := true. + method + literalAt: index put: newBinding; + flushCache ] ] ] ]. + ^foundReferringMethod!

1 0

The Inbox: Traits-ul.290.mcz
by commits＠source.squeak.org 28 Sep '12

28 Sep '12

A new version of Traits was added to project The Inbox: http://source.squeak.org/inbox/Traits-ul.290.mcz ==================== Summary ==================== Name: Traits-ul.290 Author: ul Time: 28 September 2012, 10:30:33.464 am UUID: 3e58b2db-945d-5e41-b9d8-5f5880d86ca8 Ancestors: Traits-ul.289 Speed up Trait class>>allTraitsDo: by using Smalltalk instead of #allInstances. =============== Diff against Traits-ul.289 =============== Item was changed: ----- Method: Trait class>>allTraitsDo: (in category 'public') ----- allTraitsDo: aBlock "Evaluate aBlock with all the instance and class traits present in the system" + + Smalltalk allTraitsDo: [ :aTrait | + aBlock + value: aTrait instanceSide; + value: aTrait classSide ]! - Trait allInstances do: [:aTrait| - aBlock value: aTrait instanceSide. - aBlock value: aTrait classSide. - ].!

1 0

Jump to page: