Squeak-dev January 2013

squeak-dev@lists.squeakfoundation.org

105 participants
332 discussions

The Trunk: ToolsTests-fbs.60.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-fbs.60.mcz ==================== Summary ==================== Name: ToolsTests-fbs.60 Author: fbs Time: 3 January 2013, 10:58:12.844 pm UUID: 02ef57f8-3585-42cf-9369-a2f4ead08e67 Ancestors: ToolsTests-fbs.59 Much better testing for Browser >> #annotationForClassCommentFor:. =============== Diff against ToolsTests-fbs.59 =============== Item was changed: ----- Method: BrowserTest>>testClassCommentAnnotation (in category 'as yet unclassified') ----- testClassCommentAnnotation + | annotation | browser selectSystemCategory: browser class category. browser selectClass: browser class. + annotation := browser annotationForClassCommentFor: browser class. + self assert: (annotation includesSubString: browser class organization commentStamp). + self assert: (annotation includesSubString: 'class comment for'). + self assert: (annotation includesSubString: browser className).! - self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class). - "And the method ignores the parameter:" - self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class superclass).! Item was added: + ----- Method: BrowserTest>>testClassCommentAnnotationIgnoresParameter (in category 'as yet unclassified') ----- + testClassCommentAnnotationIgnoresParameter + | annotation | + browser selectSystemCategory: browser class category. + browser selectClass: browser class. + "And the method ignores the parameter:" + annotation := browser annotationForClassCommentFor: browser class superclass. + self assert: (annotation includesSubString: browser className).!

1 0

Re: [squeak-dev] The Trunk: ToolsTests-fbs.59.mcz
by Frank Shearar 03 Jan '13

03 Jan '13

On 3 January 2013 22:51, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of ToolsTests to project The Trunk: > http://source.squeak.org/trunk/ToolsTests-fbs.59.mcz > > ==================== Summary ==================== > > Name: ToolsTests-fbs.59 > Author: fbs > Time: 3 January 2013, 10:50:59.624 pm > UUID: 32567995-41b6-47f6-ae87-100fe404b758 > Ancestors: ToolsTests-fbs.58 > > More characterisation tests. Note that #testClassCommentAnnotation is 'forward looking', in that it defines the soon-to-be behaviour of Browser >> #annotationForClassCommentFor:. > > =============== Diff against ToolsTests-fbs.58 =============== > > Item was added: > + ----- Method: BrowserTest>>testClassCommentAnnotation (in category 'as yet unclassified') ----- > + testClassCommentAnnotation > + browser selectSystemCategory: browser class category. > + browser selectClass: browser class. > + self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class). > + "And the method ignores the parameter:" > + self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class superclass).! Oh sigh. I had meant to make that test rather less obviously fragile. frank > Item was added: > + ----- Method: BrowserTest>>testClassDefinitionAnnotation (in category 'as yet unclassified') ----- > + testClassDefinitionAnnotation > + browser selectSystemCategory: browser class category. > + browser selectClass: browser class. > + self assert: browser class comment equals: (browser annotationForClassDefinitionFor: browser class). > + "And the method ignores the parameter:" > + self assert: browser class comment equals: (browser annotationForClassDefinitionFor: browser class superclass).! > >

1 0

The Trunk: Tools-fbs.436.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.436.mcz ==================== Summary ==================== Name: Tools-fbs.436 Author: fbs Time: 3 January 2013, 10:52:03.574 pm UUID: 59e6b080-bf82-4a6a-8c6b-f3a4e8952453 Ancestors: Tools-fbs.435 We already have the organization in classOrganizer. CodeHolder's version goes and looks it up. =============== Diff against Tools-fbs.435 =============== Item was added: + ----- Method: Browser>>annotationForClassCommentFor: (in category 'class comment pane') ----- + annotationForClassCommentFor: aClass + "Provide a line of content for an annotation pane, given that the receiver is pointing at the class comment of the given class." + | aStamp | + aStamp := classOrganizer commentStamp. + ^ aStamp + ifNil: + [self selectedClassName, ' has no class comment'] + ifNotNil: + ['class comment for ', self selectedClassName, + (aStamp = '<historical>' + ifFalse: + [' - ', aStamp] + ifTrue: + [''])]!

1 0

The Trunk: ToolsTests-fbs.59.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-fbs.59.mcz ==================== Summary ==================== Name: ToolsTests-fbs.59 Author: fbs Time: 3 January 2013, 10:50:59.624 pm UUID: 32567995-41b6-47f6-ae87-100fe404b758 Ancestors: ToolsTests-fbs.58 More characterisation tests. Note that #testClassCommentAnnotation is 'forward looking', in that it defines the soon-to-be behaviour of Browser >> #annotationForClassCommentFor:. =============== Diff against ToolsTests-fbs.58 =============== Item was added: + ----- Method: BrowserTest>>testClassCommentAnnotation (in category 'as yet unclassified') ----- + testClassCommentAnnotation + browser selectSystemCategory: browser class category. + browser selectClass: browser class. + self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class). + "And the method ignores the parameter:" + self assert: 'class comment for Browser - cwp 12/27/2012 11:09' equals: (browser annotationForClassCommentFor: browser class superclass).! Item was added: + ----- Method: BrowserTest>>testClassDefinitionAnnotation (in category 'as yet unclassified') ----- + testClassDefinitionAnnotation + browser selectSystemCategory: browser class category. + browser selectClass: browser class. + self assert: browser class comment equals: (browser annotationForClassDefinitionFor: browser class). + "And the method ignores the parameter:" + self assert: browser class comment equals: (browser annotationForClassDefinitionFor: browser class superclass).!

1 0

The Trunk: Tools-fbs.435.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.435.mcz ==================== Summary ==================== Name: Tools-fbs.435 Author: fbs Time: 3 January 2013, 9:48:29.766 pm UUID: 323152c9-c77b-46ff-9412-08d9bb04a8f7 Ancestors: Tools-fbs.434 Don't use Class objects when all you care about is a name. =============== Diff against Tools-fbs.434 =============== Item was changed: ----- Method: Browser>>labelString (in category 'initialize-release') ----- labelString | label | + label := self selectedClassName - label := self selectedClass ifNil: [ self defaultBrowserTitle ] + ifNotNil: [ self defaultBrowserTitle, ': ', self selectedClassName asString ]. - ifNotNil: [ self defaultBrowserTitle, ': ', self selectedClass printString ]. (multiWindowState notNil and: [multiWindowState models size > 1]) ifTrue: [label := (multiWindowState models indexOf: self) printString, '. ', label]. ^label! Item was changed: ----- Method: Browser>>newClassContents (in category 'accessing') ----- newClassContents + | theClassName | + ^ (theClassName := self selectedClassName) - | theClass | - ^ (theClass := self selectedClass) ifNil: [Class template: self selectedSystemCategory] ifNotNil: + [Class templateForSubclassOf: theClassName asString category: self selectedSystemCategory]! - [Class templateForSubclassOf: theClass category: self selectedSystemCategory]!

1 0

The Trunk: ToolsTests-fbs.58.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-fbs.58.mcz ==================== Summary ==================== Name: ToolsTests-fbs.58 Author: fbs Time: 3 January 2013, 9:47:29.806 pm UUID: a80c1ea7-ba9c-4ddd-afa4-daf45d51df34 Ancestors: ToolsTests-fbs.57 Basic labelString tests. These don't test the multiwindow labelStrings though. =============== Diff against ToolsTests-fbs.57 =============== Item was added: + ----- Method: BrowserTest>>testLabelStringAlwaysShowsBrowserType (in category 'as yet unclassified') ----- + testLabelStringAlwaysShowsBrowserType + browser selectSystemCategory: browser class category. + self assert: (browser labelString includesSubString: 'System Browser'). + browser selectClass: browser class. + self assert: (browser labelString includesSubString: 'System Browser'). + browser selectSystemCategory: DependencyBrowser category. + browser selectClass: DependencyBrowser. + self assert: (browser labelString includesSubString: 'System Browser').! Item was added: + ----- Method: BrowserTest>>testLabelStringOfNewBrowserShowsBrowserType (in category 'as yet unclassified') ----- + testLabelStringOfNewBrowserShowsBrowserType + self assert: 'System Browser' equals: browser labelString.! Item was added: + ----- Method: BrowserTest>>testLabelStringShowsBrowsedClassName (in category 'as yet unclassified') ----- + testLabelStringShowsBrowsedClassName + browser selectSystemCategory: DependencyBrowser category. + browser selectClass: DependencyBrowser. + self assert: (browser labelString includesSubString: DependencyBrowser name).!

1 0

The Trunk: Tools-fbs.434.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.434.mcz ==================== Summary ==================== Name: Tools-fbs.434 Author: fbs Time: 3 January 2013, 8:30:01.897 pm UUID: ca7203ee-5227-4b9e-afe9-4fc7b1a5a8cd Ancestors: Tools-cwp.433 Pulling these bits out makes new kinds of Browsers able to partially override behaviour. =============== Diff against Tools-cwp.433 =============== Item was changed: ----- Method: Browser>>contents (in category 'accessing') ----- contents "Depending on the current selection, different information is retrieved. Answer a string description of that information. This information is the method of the currently selected class and message." | comment theClass latestCompiledMethod | latestCompiledMethod := currentCompiledMethod. currentCompiledMethod := nil. editSelection == #newTrait ifTrue: [^ClassDescription newTraitTemplateIn: self selectedSystemCategory]. editSelection == #none ifTrue: [^ '']. editSelection == #editSystemCategories ifTrue: [^ systemOrganizer printString]. editSelection == #newClass + ifTrue: [^ self newClassContents]. - ifTrue: [^ (theClass := self selectedClass) - ifNil: - [Class template: self selectedSystemCategory] - ifNotNil: - [Class templateForSubclassOf: theClass category: self selectedSystemCategory]]. editSelection == #editClass ifTrue: [^self classDefinitionText]. editSelection == #editComment ifTrue: [(theClass := self selectedClass) ifNil: [^ '']. comment := theClass comment. currentCompiledMethod := theClass organization commentRemoteStr. ^ comment size = 0 ifTrue: ['This class has not yet been commented.'] ifFalse: [comment]]. editSelection == #hierarchy ifTrue: [^self selectedClassOrMetaClass printHierarchy]. editSelection == #editMessageCategories ifTrue: [^ self classOrMetaClassOrganizer printString]. editSelection == #newMessage ifTrue: [^ (theClass := self selectedClassOrMetaClass) ifNil: [''] ifNotNil: [theClass sourceCodeTemplate]]. editSelection == #editMessage ifTrue: [^ self editContentsWithDefault: [currentCompiledMethod := latestCompiledMethod. self selectedMessage]]. self error: 'Browser internal error: unknown edit selection.'! Item was added: + ----- Method: Browser>>newClassContents (in category 'accessing') ----- + newClassContents + | theClass | + ^ (theClass := self selectedClass) + ifNil: + [Class template: self selectedSystemCategory] + ifNotNil: + [Class templateForSubclassOf: theClass category: self selectedSystemCategory]!

1 0

The Trunk: ToolsTests-fbs.57.mcz
by commits＠source.squeak.org 03 Jan '13

03 Jan '13

Frank Shearar uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-fbs.57.mcz ==================== Summary ==================== Name: ToolsTests-fbs.57 Author: fbs Time: 3 January 2013, 8:28:38.687 pm UUID: 9f7111e8-1bca-46fa-92f0-2902a3e0c617 Ancestors: ToolsTests-fbs.56 Test that when you select a system category in a new Browser, you see what you expect to see: a template for creating a new class. =============== Diff against ToolsTests-fbs.56 =============== Item was added: + ----- Method: BrowserTest>>testContentsNewClass (in category 'as yet unclassified') ----- + testContentsNewClass + browser selectSystemCategory: browser class category. + + self assert: (Class template: browser selectedSystemCategory) equals: browser contents. + + self flag: #todo. "I don't know how to test the other half of this: see Browser >> #newClassContents".!

1 0

Re: [Pharo-project] About morph layout
by Chris Muller 03 Jan '13

03 Jan '13

Craig's NAIAD stands for "Name And Identity Are Distinct". Just thinking aloud -- because Morphic is so entrenched.. Could NAIAD or Colin's Environments allow Juan's Morphic (or, Morphic3) to co-exist with original Morphic, so that it would allow working on the port without depending on it for the tools? Once the port was complete, a sane migration could more easily occur.. On Wed, Jan 2, 2013 at 7:00 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: > On 2 January 2013 12:55, H. Hirzel <hannes.hirzel(a)gmail.com> wrote: >> Hello again Igor >> and Happy and Successful New "Pharo" Year 2013 >> > > Thanks Hannes :) > Wish best to you in New Year too :) > > >> --Hannes >> >> my notes are inserted below. >> >> >> On 12/24/12, Igor Stasenko <siguctua(a)gmail.com> wrote: >>> On 24 December 2012 09:43, H. Hirzel <hannes.hirzel(a)gmail.com> wrote: >>>> Hello Igor >>>> >>>> Thank you for this interesting mail. An issue over 11 years old, see >>>> below. >>>> >>>> On 12/24/12, Igor Stasenko <siguctua(a)gmail.com> wrote: >>>>> Hi, >>>>> >>>>> just wanna share some ideas about how we can cleanup morph a bit. >>>> >>>> A bit? >>>> It will be a lot of effort. >>>> >>> We can do it in small steps. >>> >>>> Squeak 4.4-12234 (current) >>>> >>>> Morph selectors size 1183 >>>> >>>> >>>> Pharo 2.0 (Beta) >>>> >>>> Morph selectors size 865 >>>> >>>> >>>> Cuis 4.1 (18th Dec 2012) >>>> >>>> Morph selectors size 343 >>>> >>>> >>>> This was an issue in 2001 >>>> >>>> http://lists.squeakfoundation.org/pipermail/squeak-dev/2001-June.txt >>>> >>>> see >>>> >>> I am not first day here, of course i am aware of this :) >> >> Did you start working with Squeak already in 2001? >> > no. But i know this is a long standing issue :) > >>>>> Layout.. bizarre. >>>> >>>> Yes, see humorous contribution from June 2001 >>>> http://lists.squeakfoundation.org/pipermail/squeak-dev/2001-June.txt >>>> >>>> search for >>>> >>>> the Morph class has 924 methods >>>> >>>> in that mails >>>> >>>> There was an effort >>>> Morphic Cleanup Project >>>> >>>> http://wiki.squeak.org/squeak/3005 >>>> >>>> lead by >>>> >>>> Diego Gomez Deck >>>> >>>> It produced some results. But they did not reach far enough. >>>> >>> yes yes.. i know. >>> >>>> However Juan Vuletic was successful in coming up with a simpler Morphic in >>>> Cuis. >>>> >>>> http://www.jvuletich.org/Cuis/Index.html >>>> >>> search this mailing list for Small Morphic. >>> It was an attempt to use Juan's work, which didn't fly. >> >> Of course I am aware of SmallMorphic. If a first attempt at >> integrating SimpleMorphic into Pharo was not successful it does not >> necessarily mean that a second one has to be a failure again. >> >> Time spent on an analysis why it didn't fly is surely not a waste. >> >> For example another approach could be instead of copying code from >> Cuis and implanting it into Pharo "blob style" you could follow Juan >> Vuletich's refactoring steps incrementally and copy smaller chunks of >> code. Cuis had many releases until it reached version 4.1. >> >> In terms of factoring out classes from the class Morph you seem to >> want to do that anyway. >> >> See for example >> >> http://www.jvuletich.org/Cuis/CuisReleaseNotes.html >> New in Cuis 2.7 (released September 3, 2010) >> >> * Morphic. New LayoutSpec mechanism. Simpler and nicer. >> * Morphic Simplification: Layout, Extensions, etc >> > > Well, one thing is that Juan doing quite radical changes to code. > He is not concerned about backwards compatibility (but unlike from Pharo, nobody > raising it as an issue over and over again ;) ). > Yes, i checked new Cuis code. > I see a lot of simplifications. But also i see reduced functionality. > For instance, i did not found things like 'fill style', and themes. > Also, i see some protocols is renamed, in preparation for something > bigger (morphic 3 i guess ;) > > So, i agree we should not copy/paste the code. Because it won't fly. > We should gradually analyze it and improve ours step by step. > > Layout code in Cuis is somewhat similar to what i proposing. > But my proposal is essentially about approach, which you can apply to > anything.. not just layouts in Morphics. > >>>>> There are so many methods dedicated to laying out morphs that it easy >>>>> to get lost. >>>> >>>> Cuis has a new layout system. >>>> >>>> Worth to check out. >>>> >>> Sure. >> >> Fine. >> >>> >>>>> For me the main mystery and source of confusion is that there actually >>>>> two different groups: >>>>> >>>>> - methods to control morph's own layout (in respect to its parent) >>>>> - methods to control morph's children layout (something called >>>>> layoutPolicy) >>>>> >>>>> the problem is that both APIs are found in single class, >>>> >>>> which one? >>>> >>> Morph >>> >>>> and most of >>>>> them contain 'layout' word in it, >>>>> so it is really hard to determine which one to use and when.. >>>>> >>>>> Over a years, i seen that people learned how to use existing >>>>> functionality, without delving deep into >>>>> implementation detail. >>>> >>>> Yes. >>>> >>>>> But if you try to extend/change behavior (in your subclass), you will >>>>> quite soon find out that it is really >>>>> hard to tell with 100% certainty that the methods you override is the >>>>> right place for your customization. >>>> >>>> Yes, this actually has made development very difficult. In such a way >>>> that most people have abandoned it. Very few GUIs are actually built >>>> with it. >>>> >>>> >>>>> Also, an important detail is extremely polluted protocol(s), making >>>>> Morph a GOD class, >> >> Morph is at the root of a large subclasses tree. The question is: what >> can be pushed down or factored out. An analysis in terms of number of >> method candidates to move out would surely be a good thing to know. >> > > > > -- > Best regards, > Igor Stasenko. >

2 1

Re: [squeak-dev] The Trunk: Environments-fbs.10.mcz
by Colin Putney 03 Jan '13

03 Jan '13

On Thu, Jan 3, 2013 at 9:18 AM, <commits(a)source.squeak.org> wrote: > Frank Shearar uploaded a new version of Environments to project The Trunk: > http://source.squeak.org/trunk/Environments-fbs.10.mcz > > ==================== Summary ==================== > > Name: Environments-fbs.10 > Author: fbs > Time: 3 January 2013, 2:16:59.903 pm > UUID: 260febde-ffc4-439e-bdf4-437505bd545b > Ancestors: Environments-fbs.9 > > Environment >> #at:ifPresent:ifAbsent:. > > =============== Diff against Environments-fbs.9 =============== > > Item was added: > + ----- Method: Environment>>at:ifPresent:ifAbsent: (in category > 'accessing') ----- > + at: aSymbol ifPresent: presentBlock ifAbsent: absentBlock > + ^ contents > + at: aSymbol > + ifPresent: presentBlock > + ifAbsent: absentBlock.! > Could you put these in the 'compatibility' category so they're easy to find? Thanks, Colin

2 1

← Newer
1
...
25
26
27
28
29
30
31
...
34
Older →

Jump to page: