Squeak-dev April 2013

squeak-dev@lists.squeakfoundation.org

66 participants
225 discussions

Monticello and PackageInfo
by Tobias Pape 04 Apr '13

04 Apr '13

Dear all [Squeak 4.4] I just found that Monticello injects #workingCopy into Class like this Class>>#workingCopy ^ self packageInfo workingCopy However, #workingCopy is defined neither on Class/Behavior etc nor on Object. What was the intended behavior? Best -Tobias

8 25

The Trunk: Environments-nice.22.mcz
by commits＠source.squeak.org 04 Apr '13

04 Apr '13

Nicolas Cellier uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-nice.22.mcz ==================== Summary ==================== Name: Environments-nice.22 Author: nice Time: 4 April 2013, 10:14:19.421 pm UUID: c915f44a-dc2d-4abf-9b0b-2500c96030b8 Ancestors: Environments-fbs.21 Rename a mis-guiding parameter =============== Diff against Environments-fbs.21 =============== Item was changed: ----- Method: Environment>>includes: (in category 'emulating') ----- + includes: value + ^ contents includes: value! - includes: key - ^ contents includes: key!

1 0

The Trunk: Tests-nice.197.mcz
by commits＠source.squeak.org 04 Apr '13

04 Apr '13

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.197.mcz ==================== Summary ==================== Name: Tests-nice.197 Author: nice Time: 4 April 2013, 10:11:51.767 pm UUID: 903102e1-7a0a-44dd-93a4-5a09a88e608f Ancestors: Tests-cwp.196 Set the category for a few Environment tests and avoid Obsolete superclass. =============== Diff against Tests-cwp.196 =============== Item was changed: + ----- Method: AddPrefixNamePolicyTest>>createPolicy (in category 'running') ----- - ----- Method: AddPrefixNamePolicyTest>>createPolicy (in category 'as yet unclassified') ----- createPolicy ^ AddPrefixNamePolicy prefix: 'XX'! Item was changed: + ----- Method: AddPrefixNamePolicyTest>>testAddsPrefix (in category 'tests') ----- - ----- Method: AddPrefixNamePolicyTest>>testAddsPrefix (in category 'as yet unclassified') ----- testAddsPrefix self assertIncludes: #Griffle as: #XXGriffle. ! Item was changed: + ----- Method: AddPrefixNamePolicyTest>>testDoesntDuplicatePrefix (in category 'tests') ----- - ----- Method: AddPrefixNamePolicyTest>>testDoesntDuplicatePrefix (in category 'as yet unclassified') ----- testDoesntDuplicatePrefix self denyIncludes: #XXGriffle! Item was changed: + ----- Method: BindingPolicyTest>>setUp (in category 'running') ----- - ----- Method: BindingPolicyTest>>setUp (in category 'as yet unclassified') ----- setUp namespace := IdentityDictionary new. value := Object new! Item was changed: + ClassTestCase subclass: #EventManagerTest - AnObsoleteClassTestCase subclass: #EventManagerTest instanceVariableNames: 'eventSource eventListener succeeded' classVariableNames: '' poolDictionaries: '' category: 'Tests-Object Events'! Item was changed: + ----- Method: ExportTest>>policyClass (in category 'running') ----- - ----- Method: ExportTest>>policyClass (in category 'as yet unclassified') ----- policyClass ^ Export! Item was changed: + ----- Method: ExportTest>>testExportAll (in category 'tests') ----- - ----- Method: ExportTest>>testExportAll (in category 'as yet unclassified') ----- testExportAll policy := Export namespace: namespace. policy bind: #Griffle to: value. self assert: (namespace at: #Griffle) == value! Item was changed: + ----- Method: ExportTest>>testExported (in category 'tests') ----- - ----- Method: ExportTest>>testExported (in category 'as yet unclassified') ----- testExported policy := Export namespace: namespace policy: (ExplicitNamePolicy spec: #(Griffle)). policy bind: #Griffle to: value. self assert: (namespace at: #Griffle) == value! Item was changed: + ----- Method: ExportTest>>testNotExported (in category 'tests') ----- - ----- Method: ExportTest>>testNotExported (in category 'as yet unclassified') ----- testNotExported policy := Export namespace: namespace policy: (ExplicitNamePolicy spec: #Nurp). policy bind: #Griffle to: value. self assert: namespace isEmpty! Item was changed: + ----- Method: ExportTest>>testStackedExports (in category 'tests') ----- - ----- Method: ExportTest>>testStackedExports (in category 'as yet unclassified') ----- testStackedExports | griffle plonk | griffle := Export namespace: namespace policy: (ExplicitNamePolicy spec: #Griffle). plonk := Export namespace: namespace policy: (ExplicitNamePolicy spec: #Plonk) next: griffle. plonk bind: #Griffle to: value. self assert: (namespace at: #Griffle) == value! Item was changed: + ClassTestCase subclass: #FileDirectoryTest - AnObsoleteClassTestCase subclass: #FileDirectoryTest instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Tests-Files'! Item was changed: + ClassTestCase subclass: #FileStreamTest - AnObsoleteClassTestCase subclass: #FileStreamTest instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Tests-Files'! Item was changed: + ----- Method: GlobalTest>>setUp (in category 'running') ----- - ----- Method: GlobalTest>>setUp (in category 'as yet unclassified') ----- setUp key := Object new. value := Object new. ! Item was changed: + ----- Method: GlobalTest>>testAsBindingRead (in category 'tests') ----- - ----- Method: GlobalTest>>testAsBindingRead (in category 'as yet unclassified') ----- testAsBindingRead | global imported | global := Global key: key value: value. imported := global asBinding: #Griffle. self assert: imported key = #Griffle. self assert: imported value == value. ! Item was changed: + ----- Method: GlobalTest>>testAsBindingWrite (in category 'tests') ----- - ----- Method: GlobalTest>>testAsBindingWrite (in category 'as yet unclassified') ----- testAsBindingWrite | global imported | global := Global key: key value: Object new. imported := global asBinding: #Griffle. imported value: value. self assert: imported value == value. ! Item was changed: + ----- Method: GlobalTest>>testCanAssign (in category 'tests') ----- - ----- Method: GlobalTest>>testCanAssign (in category 'as yet unclassified') ----- testCanAssign | global | global := Global key: key value: value. self assert: global canAssign! Item was changed: + ----- Method: GlobalTest>>testIsSpecialRead (in category 'tests') ----- - ----- Method: GlobalTest>>testIsSpecialRead (in category 'as yet unclassified') ----- testIsSpecialRead | global | global := Global key: key value: value. self deny: global isSpecialReadBinding! Item was changed: + ----- Method: GlobalTest>>testIsSpecialWrite (in category 'tests') ----- - ----- Method: GlobalTest>>testIsSpecialWrite (in category 'as yet unclassified') ----- testIsSpecialWrite | global | global := Global key: key value: value. self deny: global isSpecialWriteBinding! Item was changed: + ----- Method: GlobalTest>>testRead (in category 'tests') ----- - ----- Method: GlobalTest>>testRead (in category 'as yet unclassified') ----- testRead | global | global := Global key: key value: value. self assert: global key == key. self assert: global value == value.! Item was changed: + ----- Method: GlobalTest>>testWrite (in category 'tests') ----- - ----- Method: GlobalTest>>testWrite (in category 'as yet unclassified') ----- testWrite | global | global := Global key: key value: Object new. global value: value. self assert: global value == value! Item was changed: + ----- Method: ImportTest>>policyClass (in category 'running') ----- - ----- Method: ImportTest>>policyClass (in category 'as yet unclassified') ----- policyClass ^ Import! Item was changed: + ----- Method: ImportTest>>testImportAll (in category 'tests') ----- - ----- Method: ImportTest>>testImportAll (in category 'as yet unclassified') ----- testImportAll | binding | policy := Import namespace: namespace. namespace at: #Griffle put: value. binding := policy bindingOf: #Griffle. self assert: binding value == value! Item was changed: + ----- Method: ImportTest>>testImported (in category 'tests') ----- - ----- Method: ImportTest>>testImported (in category 'as yet unclassified') ----- testImported | binding | policy := Import namespace: namespace policy: (ExplicitNamePolicy spec: #Griffle). namespace at: #Griffle put: value. binding := policy bindingOf: #Griffle. self assert: binding value == value.! Item was changed: + ----- Method: ImportTest>>testNotImported (in category 'tests') ----- - ----- Method: ImportTest>>testNotImported (in category 'as yet unclassified') ----- testNotImported | binding | policy := Import namespace: namespace policy: (ExplicitNamePolicy spec: #Nurp). namespace at: #Griffle put: value. binding := policy bindingOf: #Griffle. self assert: binding value isNil! Item was changed: + ----- Method: ImportTest>>testStackedImports (in category 'tests') ----- - ----- Method: ImportTest>>testStackedImports (in category 'as yet unclassified') ----- testStackedImports | griffle plonk binding | griffle := Import namespace: namespace policy: (ExplicitNamePolicy spec: #Griffle). plonk := Import namespace: namespace policy: (ExplicitNamePolicy spec: #Plonk) next: griffle. namespace at: #Griffle put: value. binding := plonk bindingOf: #Griffle. self assert: binding value == value.! Item was changed: + ClassTestCase subclass: #PrimCallControllerAbstractTest - AnObsoleteClassTestCase subclass: #PrimCallControllerAbstractTest instanceVariableNames: 'pcc doNotMakeSlowTestsFlag' classVariableNames: '' poolDictionaries: '' category: 'Tests-PrimCallController'! !PrimCallControllerAbstractTest commentStamp: 'sr 6/15/2004 19:20' prior: 0! PrimCallController tests. Tests are here, but this class isAbstract and won't be tested. Tests are done in the subclasses, which inherit the tests here. If you want to perform some more very slow tests, change doNotMakeSlowTestsFlag in >>setUp.! Item was changed: + ----- Method: RemovePrefixNamePolicyTest>>createPolicy (in category 'running') ----- - ----- Method: RemovePrefixNamePolicyTest>>createPolicy (in category 'as yet unclassified') ----- createPolicy ^ RemovePrefixNamePolicy prefix: 'XX'! Item was changed: + ----- Method: RemovePrefixNamePolicyTest>>testOnlyRemovesPrefix (in category 'tests') ----- - ----- Method: RemovePrefixNamePolicyTest>>testOnlyRemovesPrefix (in category 'as yet unclassified') ----- testOnlyRemovesPrefix self denyIncludes: #XAGriffle! Item was changed: + ----- Method: RemovePrefixNamePolicyTest>>testRemovesPrefix (in category 'tests') ----- - ----- Method: RemovePrefixNamePolicyTest>>testRemovesPrefix (in category 'as yet unclassified') ----- testRemovesPrefix self assertIncludes: #XXGriffle as: #Griffle! Item was changed: + ClassTestCase subclass: #SecureHashAlgorithmTest - AnObsoleteClassTestCase subclass: #SecureHashAlgorithmTest instanceVariableNames: 'hash' classVariableNames: '' poolDictionaries: '' category: 'Tests-Digital Signatures'! !SecureHashAlgorithmTest commentStamp: '<historical>' prior: 0! This is the unit test for the class SecureHashAlgorithm. Unit tests are a good way to exercise the functionality of your system in a repeatable and automatic manner. They are therefore recommended if you plan to release anything. For more information, see: - http://www.c2.com/cgi/wiki?UnitTest - http://minnow.cc.gatech.edu/squeak/1547 - the sunit class category!

1 0

CI status
by Frank Shearar 04 Apr '13

04 Apr '13

I've currently *ahem* negatively affected the efficacy of the SqueakTrunk and ReleaseSqueakTrunk builds. I'm hoping some kind soul will quickly reply to my earlier mail about cleanup, telling me what very important step I've foolishly left out: that ought to fix the problem. (And I'll turn it into a SmalltalkImage method that we can repeatedly use.) Otherwise, on a more positive note, I've * reimplemented the entire build process in Ruby (a far more sane language than shell), * made SqueakTrunk builds off a 4.5 image, drastically reducing the build time, * broken SqueakTrunkPerformance out as a separate job, with the aim of making debugging the current problem easier, * will make ReleaseSqueakTrunk use Ruby (once we're done with the current issue), and will maintain the illusion that nothing has changed, while SqueakTrunk's artifact continues to shrink. Lastly, ExternalPackages builds a base image off a fully updated 4.5 image and runs, each in a clean image, the test suites (where present) of AndreasSystemProfiler, Control, FFI, Fuel, Nebraska, Nutcracker, OSProcess, Quaternion, Phexample, RoelTyper, SqueakCheck, Universes, WebClient, XML-Parser, Xtreams and Zippers. And other jobs do the same with 4.3 and 4.4. (I realise some of the packages will be unfamiliar: some are from Pharo, and some are libraries I've released and written about elsewhere, but talking about them here would be off-topic.) frank

1 1

Daily Commit Log
by commits＠source.squeak.org 04 Apr '13

04 Apr '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-April/005830.html Name: Tests-cwp.196 Ancestors: Tests-cwp.195 Add a test that ensures that assignments to globals evaluate to the value assigned, rather than the variable binding. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-April/005831.html Name: Compiler-eem.258 Ancestors: Compiler-eem.257 Fix store of special bindings. Exsting code dropped the value assigned from the stack, so v := binding := expr would leave v holding binding, not expr. New code generates push expr push binding duplicate expr (by pushTemp: of expr's stack index) send value: pop ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-April/005832.html Name: Compiler-eem.259 Ancestors: Compiler-eem.258 Fix literal duplication with special bindings for classes. LiteralNode>>reserve: needs to use sharableLitIndex: if it is a special binding. The decompiler is still broken by Compiler-eem.258 for v := SpecialBinding := expr. But at least methods containing globals are debuggable again. =============================================

1 0

Re: [squeak-dev] The Trunk: Tests-dtl.194.mcz
by David T. Lewis 04 Apr '13

04 Apr '13

I moved these two new tests from Inbox to Trunk. One test fails on recent trunk images. I do not know if this is a bug or a feature, but I cannot explain the regression so I don't want to assume it's a feature. Dave On Fri, Mar 29, 2013 at 02:14:02PM +0000, commits(a)source.squeak.org wrote: > David T. Lewis uploaded a new version of Tests to project The Trunk: > http://source.squeak.org/trunk/Tests-dtl.194.mcz > > ==================== Summary ==================== > > Name: Tests-dtl.194 > Author: dtl > Time: 29 March 2013, 10:13:41.368 am > UUID: ba96f5b8-f215-4045-a16f-473c8dde8760 > Ancestors: Tests-eem.193 > > Merge Tests-dtl.193 > > Background: http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-March/169911.ht… > > Two tests that illustrate the limit to number of literals in a compiled method. Both tests pass on Squeak 4.4. One of the tests fails in the most recent Squeak trunk. > > CompilerTest>>testMaxLiteralsWithClassReferenceInClosure passes in the image at > http://build.squeak.org/job/SqueakTrunk/212/ and fails in later updates to trunk. > > =============== Diff against Tests-eem.193 =============== > > Item was added: > + ----- Method: CompilerTest>>testMaxLiterals (in category 'limits') ----- > + testMaxLiterals > + "Document the maximum number of literals in a compiled method" > + > + | maxLiterals stringThatCanBeCompiled stringWithOneTooManyLiterals | > + maxLiterals := 249. > + stringThatCanBeCompiled := '{ ', (String streamContents: [:strm | > + 1 to: maxLiterals do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. > + stringWithOneTooManyLiterals := '{ ', (String streamContents: [:strm | > + 1 to: maxLiterals + 1 do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. > + self shouldnt: [Compiler evaluate: stringThatCanBeCompiled logged: false] raise: Error. > + self should: (Compiler evaluate: stringThatCanBeCompiled logged: false) size = maxLiterals. > + > + "If the following test fails, it means that the limit has been raised or eliminated, > + and this test should be updated to reflect the improvement." > + self should: [Compiler evaluate: stringWithOneTooManyLiterals logged: false] raise: Error. > + ! > > Item was added: > + ----- Method: CompilerTest>>testMaxLiteralsWithClassReferenceInClosure (in category 'limits') ----- > + testMaxLiteralsWithClassReferenceInClosure > + "Document the maximum number of literals in a compiled method. A class > + reference in a closure reduces the maximum literals." > + > + | maxLiterals stringThatCanBeCompiled stringWithOneTooManyLiterals | > + maxLiterals := 244. > + stringThatCanBeCompiled := '[ DateAndTime now. Date today. Time ]. { ', > + (String streamContents: [:strm | > + 1 to: maxLiterals do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. > + stringWithOneTooManyLiterals := '[ DateAndTime now. Date today. Time ]. { ', > + (String streamContents: [:strm | > + 1 to: maxLiterals + 1 do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. > + self shouldnt: [Compiler evaluate: stringThatCanBeCompiled logged: false] raise: Error. > + self should: (Compiler evaluate: stringThatCanBeCompiled logged: false) size = maxLiterals. > + > + "If the following test fails, it means that the limit has been raised or eliminated, > + and this test should be updated to reflect the improvement." > + self should: [Compiler evaluate: stringWithOneTooManyLiterals logged: false] raise: Error. > + ! >

3 6

The Trunk: Compiler-eem.259.mcz
by commits＠source.squeak.org 03 Apr '13

03 Apr '13

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.259.mcz ==================== Summary ==================== Name: Compiler-eem.259 Author: eem Time: 3 April 2013, 1:53:21.499 pm UUID: 5bca5ca6-0cbc-4c06-959f-219d601b27c0 Ancestors: Compiler-eem.258 Fix literal duplication with special bindings for classes. LiteralNode>>reserve: needs to use sharableLitIndex: if it is a special binding. The decompiler is still broken by Compiler-eem.258 for v := SpecialBinding := expr. But at least methods containing globals are debuggable again. =============== Diff against Compiler-eem.258 =============== Item was changed: ----- Method: Encoder>>litIndex: (in category 'encoding') ----- litIndex: literal | p | + (literal isVariableBinding and: [literalStream originalContents identityIncludes: literal]) ifTrue: + [self halt]. p := literalStream position. p = 256 ifTrue: [self notify: 'More than 256 literals referenced. You must split or otherwise simplify this method. The 257th literal is: ', literal printString. ^nil]. "Would like to show where it is in the source code, but that info is hard to get." literalStream nextPut: literal. ^ p! Item was added: + ----- Method: LiteralNode>>reserve: (in category 'code generation') ----- + reserve: encoder + "If this is a yet unused literal of type -code, reserve it." + + code < 0 ifTrue: + [index := key isVariableBinding "true if sending value[:] to a special binding" + ifTrue: [encoder sharableLitIndex: key] + ifFalse: [encoder litIndex: key]. + code := self code: index type: 0 - code]! Item was changed: ----- Method: LiteralVariableNode>>sizeCodeForStore: (in category 'code generation') ----- sizeCodeForStore: encoder self reserve: encoder. (key isVariableBinding and: [key isSpecialWriteBinding]) ifFalse: [^encoder sizeStoreLiteralVar: index]. - code < 0 ifTrue: - [self flag: #dubious. - self code: (self code: self index type: LdLitType)]. writeNode := encoder encodeSelector: #value:. "On entry the stack has only the expression. Push the binding, duplicate the expression, send #value: and pop." ^(encoder sizePushLiteral: index) + (encoder sizePushTempLong: 0) "we don't know yet, hence long, sigh..." + (writeNode sizeCode: encoder args: 1 super: false) + encoder sizePop!

1 0

The Trunk: Compiler-eem.258.mcz
by commits＠source.squeak.org 03 Apr '13

03 Apr '13

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.258.mcz ==================== Summary ==================== Name: Compiler-eem.258 Author: eem Time: 3 April 2013, 12:59:36.409 pm UUID: 7721a43f-63e6-4524-bb6d-48eddc955654 Ancestors: Compiler-eem.257 Fix store of special bindings. Exsting code dropped the value assigned from the stack, so v := binding := expr would leave v holding binding, not expr. New code generates push expr push binding duplicate expr (by pushTemp: of expr's stack index) send value: pop =============== Diff against Compiler-eem.257 =============== Item was changed: ----- Method: AssignmentNode>>emitCodeForEffect:encoder: (in category 'code generation') ----- emitCodeForEffect: stack encoder: encoder + variable emitCodeForLoad: stack forValue: false encoder: encoder. - variable emitCodeForLoad: stack encoder: encoder. value emitCodeForValue: stack encoder: encoder. pc := encoder methodStreamPosition + 1. "debug pc is first byte of the store, i.e. the next byte". variable emitCodeForStorePop: stack encoder: encoder! Item was changed: ----- Method: AssignmentNode>>emitCodeForValue:encoder: (in category 'code generation') ----- emitCodeForValue: stack encoder: encoder + variable emitCodeForLoad: stack forValue: true encoder: encoder. - variable emitCodeForLoad: stack encoder: encoder. value emitCodeForValue: stack encoder: encoder. pc := encoder methodStreamPosition + 1. "debug pc is first byte of the store, i.e. the next byte". variable emitCodeForStore: stack encoder: encoder! Item was changed: ----- Method: AssignmentNode>>sizeCodeForEffect: (in category 'code generation') ----- sizeCodeForEffect: encoder + ^(variable sizeCodeForLoad: encoder forValue: false) - ^(variable sizeCodeForLoad: encoder) + (value sizeCodeForValue: encoder) + (variable sizeCodeForStorePop: encoder)! Item was changed: ----- Method: AssignmentNode>>sizeCodeForValue: (in category 'code generation') ----- sizeCodeForValue: encoder + ^(variable sizeCodeForLoad: encoder forValue: true) - ^(variable sizeCodeForLoad: encoder) + (value sizeCodeForValue: encoder) + (variable sizeCodeForStore: encoder)! Item was added: + ----- Method: BytecodeEncoder>>sizePushTempLong: (in category 'opcode sizing') ----- + sizePushTempLong: tempIndex + ^self sizeOpcodeSelector: #genPushTempLong: withArguments: {tempIndex}! Item was added: + ----- Method: EncoderForV3>>genPushTempLong: (in category 'bytecode generation') ----- + genPushTempLong: tempIndex + "See BlueBook page 596" + (tempIndex >= 0 and: [tempIndex < 64]) ifTrue: + ["128 10000000 jjkkkkkk Push (Receiver Variable, Temporary Location, Literal Constant, Literal Variable) [jj] #kkkkkk" + stream + nextPut: 128; + nextPut: 64 + tempIndex. + ^self]. + ^self outOfRangeError: 'index' index: tempIndex range: 0 to: 63! Item was removed: - ----- Method: FieldNode>>emitCodeForLoad:encoder: (in category 'code generation') ----- - emitCodeForLoad: stack encoder: encoder - rcvrNode emitCodeForValue: stack encoder: encoder. - fieldDef accessKey ifNotNil:[ - super emitCodeForValue: stack encoder: encoder. - ].! Item was added: + ----- Method: FieldNode>>emitCodeForLoad:forValue:encoder: (in category 'code generation') ----- + emitCodeForLoad: stack forValue: forValue encoder: encoder + rcvrNode emitCodeForValue: stack encoder: encoder. + fieldDef accessKey ifNotNil: + [super emitCodeForValue: stack encoder: encoder]! Item was removed: - ----- Method: LeafNode>>emitCodeForLoad:encoder: (in category 'code generation') ----- - emitCodeForLoad: stack encoder: encoder - "Default is to do nothing. - Subclasses may need to override."! Item was added: + ----- Method: LeafNode>>emitCodeForLoad:forValue:encoder: (in category 'code generation') ----- + emitCodeForLoad: stack forValue: forValue encoder: encoder + "Default is to do nothing. + Subclasses may need to override."! Item was removed: - ----- Method: LeafNode>>sizeCodeForLoad: (in category 'code generation') ----- - sizeCodeForLoad: encoder - "Default is to do nothing. - Subclasses may need to override." - ^0! Item was added: + ----- Method: LeafNode>>sizeCodeForLoad:forValue: (in category 'code generation') ----- + sizeCodeForLoad: encoder forValue: forValue + "Default is to do nothing. + Subclasses may need to override." + ^0! Item was removed: - ----- Method: LiteralVariableNode>>emitCodeForLoad:encoder: (in category 'code generation') ----- - emitCodeForLoad: stack encoder: encoder - writeNode ifNotNil: - [encoder genPushLiteral: index. - stack push: 1]! Item was added: + ----- Method: LiteralVariableNode>>emitCodeForLoad:forValue:encoder: (in category 'code generation') ----- + emitCodeForLoad: stack forValue: forValue encoder: encoder + "If a normal literal variable (not sending value:), do nothing. + If for value (e.g. v := Binding := expr) do nothing; the work will be done in emitCodeForStore:encoder:. + If not for value then indeed load. The rest of the work will be done in emitCodeForStorePop:encoder:." + (writeNode isNil or: [forValue]) ifTrue: [^self]. + encoder genPushLiteral: index. + stack push: 1! Item was changed: ----- Method: LiteralVariableNode>>emitCodeForStore:encoder: (in category 'code generation') ----- emitCodeForStore: stack encoder: encoder + | exprOffset | writeNode ifNil: [^encoder genStoreLiteralVar: index]. + "On entry the stack has only the expression. Push the binding, + duplicate the expression, send #value: and pop." + exprOffset := stack position - 1. + encoder genPushLiteral: index. + stack push: 1. + encoder genPushTempLong: exprOffset. + stack push: 1. - "THIS IS WRONG!!!! THE VALUE IS LOST FROM THE STACK!!!! - The various value: methods on Association ReadOnlyVariableBinding - etc _do not_ return the value assigned; they return the receiver." - "Should generate something more like - push expr - push lit - push temp (index of expr) - send value: - pop - or use e.g. valueForStore:" - self flag: #bogus. writeNode emitCode: stack args: 1 encoder: encoder + super: false. + stack pop: 1. + encoder genPop! - super: false! Item was removed: - ----- Method: LiteralVariableNode>>sizeCodeForLoad: (in category 'code generation') ----- - sizeCodeForLoad: encoder - self reserve: encoder. - ^(key isVariableBinding and: [key isSpecialWriteBinding]) - ifTrue: [encoder sizePushLiteral: index] - ifFalse: [0]! Item was added: + ----- Method: LiteralVariableNode>>sizeCodeForLoad:forValue: (in category 'code generation') ----- + sizeCodeForLoad: encoder forValue: forValue + self reserve: encoder. + ^(key isVariableBinding and: [key isSpecialWriteBinding and: [forValue not]]) + ifTrue: [encoder sizePushLiteral: index] + ifFalse: [0]! Item was changed: ----- Method: LiteralVariableNode>>sizeCodeForStore: (in category 'code generation') ----- sizeCodeForStore: encoder self reserve: encoder. (key isVariableBinding and: [key isSpecialWriteBinding]) ifFalse: [^encoder sizeStoreLiteralVar: index]. code < 0 ifTrue: [self flag: #dubious. self code: (self code: self index type: LdLitType)]. - "THIS IS WRONG!!!! THE VALUE IS LOST FROM THE STACK!!!! - The various value: methods on Association ReadOnlyVariableBinding - etc _do not_ return the value assigned; they return the receiver." - "Should generate something more like - push expr - push lit - push temp (index of expr) - send value: - pop" - self flag: #bogus. writeNode := encoder encodeSelector: #value:. + "On entry the stack has only the expression. Push the binding, + duplicate the expression, send #value: and pop." + ^(encoder sizePushLiteral: index) + + (encoder sizePushTempLong: 0) "we don't know yet, hence long, sigh..." + + (writeNode sizeCode: encoder args: 1 super: false) + + encoder sizePop! - ^writeNode sizeCode: encoder args: 1 super: false! Item was removed: - ----- Method: TempVariableNode>>emitCodeForLoad:encoder: (in category 'code generation') ----- - emitCodeForLoad: stack encoder: encoder - remoteNode ~~ nil ifTrue: - [remoteNode emitCodeForLoadFor: self stack: stack encoder: encoder]! Item was added: + ----- Method: TempVariableNode>>emitCodeForLoad:forValue:encoder: (in category 'code generation') ----- + emitCodeForLoad: stack forValue: forValue encoder: encoder + remoteNode ~~ nil ifTrue: + [remoteNode emitCodeForLoadFor: self stack: stack encoder: encoder]! Item was removed: - ----- Method: TempVariableNode>>sizeCodeForLoad: (in category 'code generation') ----- - sizeCodeForLoad: encoder - ^remoteNode - ifNil: [0] - ifNotNil: [remoteNode sizeCodeForLoadFor: self encoder: encoder]! Item was added: + ----- Method: TempVariableNode>>sizeCodeForLoad:forValue: (in category 'code generation') ----- + sizeCodeForLoad: encoder forValue: forValue + ^remoteNode + ifNil: [0] + ifNotNil: [remoteNode sizeCodeForLoadFor: self encoder: encoder]! Item was removed: - ----- Method: VariableNode>>emitCodeForLoad:encoder: (in category 'code generation') ----- - emitCodeForLoad: stack encoder: encoder - "Do nothing"! Item was added: + ----- Method: VariableNode>>emitCodeForLoad:forValue:encoder: (in category 'code generation') ----- + emitCodeForLoad: stack forValue: forValue encoder: encoder + "Do nothing"!

1 0

The Trunk: Tests-cwp.196.mcz
by commits＠source.squeak.org 03 Apr '13

03 Apr '13

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.196.mcz ==================== Summary ==================== Name: Tests-cwp.196 Author: cwp Time: 3 April 2013, 9:50:31.378 am UUID: 21fbacb5-b2ee-45ab-b002-94a47b9ebf71 Ancestors: Tests-cwp.195 Add a test that ensures that assignments to globals evaluate to the value assigned, rather than the variable binding. =============== Diff against Tests-cwp.195 =============== Item was added: + ----- Method: EnvironmentTest>>storeValueMethod (in category 'running') ----- + storeValueMethod + ^ 'doStore + | expr result | + expr := Object new. + result := Plonk := expr. + ^ { expr. result } + '! Item was added: + ----- Method: EnvironmentTest>>testStoreDomesticValue (in category 'compiling tests') ----- + testStoreDomesticValue + | griffle values | + self createClass: #Griffle. + env at: #Plonk put: 'v1'. + + griffle := env at: #Griffle. + griffle compile: self storeValueMethod. + values := griffle new doStore. + + self assert: values isArray. + self assert: values size = 2. + self assert: values first == values last. + self assert: (env at: #Plonk) == values first! Item was added: + ----- Method: EnvironmentTest>>testStoreImportedValue (in category 'compiling tests') ----- + testStoreImportedValue + | griffle foreign values | + self createClass: #Griffle. + foreign := Environment withName: #Foreign. + foreign exportSelf. + foreign at: #Plonk put: 'v1'. + env from: foreign import: #Plonk. + + griffle := env at: #Griffle. + griffle compile: self storeValueMethod. + values := griffle new doStore. + + self assert: values isArray. + self assert: values size = 2. + self assert: values first == values last. + self assert: (foreign at: #Plonk) == values first!

1 0

Lost stdOut and stdErr handles?
by Chris Muller 03 Apr '13

03 Apr '13

I have an image that seems to no longer be able to write to stdout or stderr. It most definitely was doing that at one time, but now none of the redirection works, however I am seeing actual files called "stdout" and "stderr" in the image directory with output from all of my running images written on top of each other -- unreadable. Just to make sure it wasn't something in my OS, I tried another image and writing to stdout works fine. I'd like to stay in this image if I can, is there some way to "reset" things back to normal? I poked around in the related FileStream methods but didn't see anything quick and obvious..

2 5

Jump to page: