Squeak-dev November 2015

squeak-dev@lists.squeakfoundation.org

40 participants
251 discussions

The Inbox: Kernel-ul.965.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.965.mcz ==================== Summary ==================== Name: Kernel-ul.965 Author: ul Time: 2 November 2015, 4:57:55.804 am UUID: d1932681-6382-4a22-bbb8-f0dd6df8b029 Ancestors: Kernel-ul.964 To be able to compare PluggableSets and PluggableDictionaries, we have to provide BlockClosure >> #=. =============== Diff against Kernel-ul.964 =============== Item was added: + ----- Method: BlockClosure>>= (in category 'comparing') ----- + = anObject + + anObject == self ifTrue: [ ^true ]. + anObject class == self class ifFalse: [ ^false ]. + anObject outerContext method = outerContext method ifFalse: [ ^false ]. + anObject outerContext receiver = outerContext receiver ifFalse: [ ^false ]. + anObject startpc = startpc ifFalse: [ ^false ]. + ^anObject numArgs = numArgs! Item was added: + ----- Method: BlockClosure>>hash (in category 'comparing') ----- + hash + + ^((self class hash + bitXor: outerContext method hash) + bitXor: outerContext receiver hash) + bitXor: ((startpc bitShift: 8) + numArgs) hashMultiply!

1 0

The Trunk: Kernel-ul.964.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.964.mcz ==================== Summary ==================== Name: Kernel-ul.964 Author: ul Time: 2 November 2015, 4:56:32.76 am UUID: 5dbe95ce-96e3-4f4d-bdb1-520c50def26c Ancestors: Kernel-nice.963 Spur-compatible Object >> #inboundPointersExcluding:. =============== Diff against Kernel-nice.963 =============== Item was changed: ----- Method: Object>>inboundPointersExcluding: (in category 'tracing') ----- inboundPointersExcluding: objectsToExclude "Answer a list of all objects in the system that hold a reference to me, excluding those in the collection of objectsToExclude." | pointers object objectsToAlwaysExclude | Smalltalk garbageCollect. pointers := OrderedCollection new. + self systemNavigation allObjectsOrNil ifNotNil: [ :allObjects | + objectsToAlwaysExclude := { + allObjects. + thisContext. + thisContext sender. + thisContext sender sender. + objectsToExclude. + }. + 1 to: allObjects size do: [ :index | + object := allObjects at: index. + (object pointsTo: self) ifTrue: [ + ((objectsToAlwaysExclude identityIncludes: object) + or: [ objectsToExclude identityIncludes: object ]) + ifFalse: [ pointers add: object ] ] ]. + ^pointers ]. "SystemNavigation >> #allObjectsDo: is inlined here with a slight modification: the marker object is pointers. This gives better results, because the value of pointers, it's inner objects and transient method contexts will not be iterated over." object := self someObject. [ object == pointers ] whileFalse: [ (object isInMemory and: [ object pointsTo: self ]) ifTrue: [ pointers add: object ]. object := object nextObject ]. objectsToAlwaysExclude := { thisContext. thisContext sender. thisContext sender sender. objectsToExclude. }. ^pointers removeAllSuchThat: [ :ea | (objectsToAlwaysExclude identityIncludes: ea) or: [ objectsToExclude identityIncludes: ea ] ]!

1 0

The Trunk: Tests-ul.337.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ul.337.mcz ==================== Summary ==================== Name: Tests-ul.337 Author: ul Time: 2 November 2015, 4:54:37.744 am UUID: 125ed088-9fca-483e-b8e9-7bb02e1f58a0 Ancestors: Tests-dtl.336 Sets are not equal to IdentitySets anymore, so we have to create instances of the right classes to make some tests pass. =============== Diff against Tests-dtl.336 =============== Item was changed: ----- Method: SystemNavigationTest>>testAllImplementedMessagesWithout (in category 'as yet unclassified') ----- testAllImplementedMessagesWithout + + self assert: #(bar baz classFoo) asIdentitySet - self assert: #(bar baz classFoo) asSet equals: (sysNav allImplementedMessagesWithout: {{env at: #Griffle}. {#foo}}).! Item was changed: ----- Method: SystemNavigationTest>>testAllSentMessagesWithout (in category 'as yet unclassified') ----- testAllSentMessagesWithout + + self + assert: (#(foo bar) asIdentitySet + addAll: Smalltalk presumedSentMessages; + addAll: Smalltalk specialSelectors; + yourself) - self assert: #(foo bar) asSet , Smalltalk presumedSentMessages , Smalltalk specialSelectors equals: (sysNav allSentMessagesWithout: {{env at: #Griffle}. {#+}}).!

1 0

The Trunk: CollectionsTests-ul.257.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.257.mcz ==================== Summary ==================== Name: CollectionsTests-ul.257 Author: ul Time: 2 November 2015, 4:52:42.874 am UUID: d6f5337b-2240-4afd-974b-21358e2f00b0 Ancestors: CollectionsTests-ul.256 WeakSet is an exception. =============== Diff against CollectionsTests-ul.256 =============== Item was changed: ----- Method: SetWithNilTest>>runSetWithNilTestOf: (in category 'tests') ----- runSetWithNilTestOf: newSet "Run the common tests for the given set class" + + | class collectClass | + class := newSet value class. + collectClass := class == WeakSet + ifTrue: [ WeakSet ] + ifFalse: [ Set ]. self assert: (newSet value add: nil; yourself) size = 1. self assert: (newSet value addAll: #(nil nil nil); yourself) size = 1. self assert: ((newSet value add: nil; yourself) includes: nil). self assert: ((newSet value addAll: #(nil nil nil); yourself) includes: nil). self assert: (newSet value add: nil; yourself) anyOne = nil. self assert: ((newSet value add: nil; yourself) remove: nil) == nil. self assert: ((newSet value add: nil; yourself) remove: nil; yourself) isEmpty. self assert: (newSet value addAll: #(1 nil foo); yourself) size = 3. self assert: ((newSet value addAll: #(1 nil foo); yourself) remove: nil; yourself) size = 2. + self assert: ((newSet value add: nil; yourself) collect:[:x| x]) = (collectClass with: nil). - self assert: ((newSet value add: nil; yourself) collect:[:x| x]) = (Set with: nil). self assert: ((newSet value add: nil; yourself) collect:[:x| x] as: Array) = #(nil). self deny: ((newSet value) includes: nil). self deny: ((newSet value add: 3; yourself) includes: nil). self deny: ((newSet value add: 3; remove: 3; yourself) includes: nil). !

1 0

The Trunk: CollectionsTests-ul.256.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.256.mcz ==================== Summary ==================== Name: CollectionsTests-ul.256 Author: ul Time: 2 November 2015, 4:10:24.284 am UUID: 3605a07c-4484-44ae-ba91-f5be4d7da842 Ancestors: CollectionsTests-nice.255 Set >> #collect: returns a Set, so compare the result of it with a Set in SetWithNilTest >> #runSetWithNilTestOf:. =============== Diff against CollectionsTests-nice.255 =============== Item was changed: ----- Method: SetWithNilTest>>runSetWithNilTestOf: (in category 'tests') ----- runSetWithNilTestOf: newSet "Run the common tests for the given set class" self assert: (newSet value add: nil; yourself) size = 1. self assert: (newSet value addAll: #(nil nil nil); yourself) size = 1. self assert: ((newSet value add: nil; yourself) includes: nil). self assert: ((newSet value addAll: #(nil nil nil); yourself) includes: nil). self assert: (newSet value add: nil; yourself) anyOne = nil. self assert: ((newSet value add: nil; yourself) remove: nil) == nil. self assert: ((newSet value add: nil; yourself) remove: nil; yourself) isEmpty. self assert: (newSet value addAll: #(1 nil foo); yourself) size = 3. self assert: ((newSet value addAll: #(1 nil foo); yourself) remove: nil; yourself) size = 2. + self assert: ((newSet value add: nil; yourself) collect:[:x| x]) = (Set with: nil). - self assert: ((newSet value add: nil; yourself) collect:[:x| x]) = (newSet value add: nil; yourself). self assert: ((newSet value add: nil; yourself) collect:[:x| x] as: Array) = #(nil). self deny: ((newSet value) includes: nil). self deny: ((newSet value add: 3; yourself) includes: nil). self deny: ((newSet value add: 3; remove: 3; yourself) includes: nil). !

1 0

The Trunk: KernelTests-ul.299.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ul.299.mcz ==================== Summary ==================== Name: KernelTests-ul.299 Author: ul Time: 2 November 2015, 3:58:12.772 am UUID: 03be01bc-e815-42ed-be0b-dde3d1fc603a Ancestors: KernelTests-nice.298 - fixed typo =============== Diff against KernelTests-nice.298 =============== Item was changed: ----- Method: SmallIntegerTest>>testPrintString (in category 'testing - printing') ----- testPrintString self assert: 1 printString = '1'. self assert: -1 printString = '-1'. self assert: SmallInteger minVal printString = (Smalltalk wordSize = 8 ifTrue: [ '-1152921504606846976'] ifFalse: ['-1073741824']). + self assert: SmallInteger maxVal printString = (Smalltalk wordSize = 8 ifTrue: [ '1152921504606846975'] ifFalse: ['1073741823']). - self assert: SmallInteger maxVal printString = (Smalltalk wordSize = 8 ifTrue: [ '1152921504606846975'] ifFalse: ['-1073741823']). self assert: 12345 printString = '12345'. self assert: -54321 printString = '-54321'. self assert: 0 decimalDigitLength = 1. self assert: 4 decimalDigitLength = 1. self assert: 12 decimalDigitLength = 2. self assert: 123 decimalDigitLength = 3. self assert: 1234 decimalDigitLength = 4. self assert: 56789 decimalDigitLength = 5. self assert: 657483 decimalDigitLength = 6. self assert: 6571483 decimalDigitLength = 7. self assert: 65174383 decimalDigitLength = 8. self assert: 625744831 decimalDigitLength = 9. self assert: 1000001111 decimalDigitLength = 10. self assert: SmallInteger maxVal decimalDigitLength = (Smalltalk wordSize = 8 ifTrue: [19] ifFalse: [10]).!

1 0

The Trunk: Collections-ul.669.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.669.mcz ==================== Summary ==================== Name: Collections-ul.669 Author: ul Time: 2 November 2015, 2:00:09.732 am UUID: 01e30af9-3dd4-4b5e-ab40-89ce43884565 Ancestors: Collections-ul.668 Changed Set >> #= and Dictionary >> #= to check the species of the receiver and the argument. PluggableDictionary and PluggableSet also check hashBlock and equalBlock. WeakSet and friends will work once we start using ephemerons. =============== Diff against Collections-ul.668 =============== Item was changed: ----- Method: Dictionary>>= (in category 'comparing') ----- = anObject "Two dictionaries are equal if (a) they are the same 'kind' of thing. (b) they have the same set of keys. (c) for each (common) key, they have the same value" self == anObject ifTrue: [ ^true ]. + self species == anObject species ifFalse: [ ^false ]. - anObject isDictionary ifFalse: [ ^false ]. self size = anObject size ifFalse: [ ^false ]. self associationsDo: [ :association | (anObject at: association key ifAbsent: [ ^false ]) = association value ifFalse: [ ^false ] ]. - "The two dictionaries may have different ideas about equal keys, so check both ways to avoid any inconsistency." - anObject associationsDo: [ :association | - (self at: association key ifAbsent: [ ^false ]) = association value - ifFalse: [ ^false ] ]. ^true! Item was added: + ----- Method: PluggableDictionary>>= (in category 'comparing') ----- + = anObject + "Two dictionaries are equal if + (a) they are the same 'kind' of thing. + (b) they have the same set of keys. + (c) for each (common) key, they have the same value" + + self == anObject ifTrue: [ ^true ]. + self species == anObject species ifFalse: [ ^false ]. + hashBlock = anObject hashBlock ifFalse: [ ^false ]. + equalBlock = anObject equalBlock ifFalse: [ ^false ]. + self size = anObject size ifFalse: [ ^false ]. + self associationsDo: [ :association | + (anObject at: association key ifAbsent: [ ^false ]) = association value + ifFalse: [ ^false ] ]. + ^true! Item was added: + ----- Method: PluggableSet>>= (in category 'as yet unclassified') ----- + = anObject + "Two sets are equal if + (a) they are the same 'kind' of thing. + (b) they have the same set of keys. + (c) for each (common) key, they have the same value" + + self == anObject ifTrue: [ ^true ]. + self species == anObject species ifFalse: [ ^false ]. + hashBlock = anObject hashBlock ifFalse: [ ^false ]. + equalBlock = anObject equalBlock ifFalse: [ ^false ]. + self size = anObject size ifFalse: [ ^false ]. + ^self allSatisfy: [ :each | anObject includes: each ]! Item was changed: ----- Method: Set>>= (in category 'comparing') ----- + = anObject + "Two sets are equal if + (a) they are the same 'kind' of thing. + (b) they have the same set of keys. + (c) for each (common) key, they have the same value" + + self == anObject ifTrue: [ ^true ]. + self species == anObject species ifFalse: [ ^false ]. + self size = anObject size ifFalse: [ ^false ]. + ^self allSatisfy: [ :each | anObject includes: each ]! - = aSet - self == aSet ifTrue: [^ true]. "stop recursion" - (aSet isKindOf: Set) ifFalse: [^ false]. - self size = aSet size ifFalse: [^ false]. - self do: [:each | (aSet includes: each) ifFalse: [^ false]]. - ^ true!

1 0

The Trunk: Network-ul.167.mcz
by commits＠source.squeak.org 02 Nov '15

02 Nov '15

Levente Uzonyi uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-ul.167.mcz ==================== Summary ==================== Name: Network-ul.167 Author: ul Time: 2 November 2015, 2:02:21.822 am UUID: cc1e8b01-d960-40ff-b466-54e7bcb73cb7 Ancestors: Network-topa.166 Now that #primMakeUUID is not being used anymore, we can change its behaviour to return nil when the plugin is not available. Added accessors for UUID variant and version. =============== Diff against Network-topa.166 =============== Item was changed: ----- Method: UUID>>primMakeUUID (in category 'system primitives') ----- primMakeUUID + <primitive: 'primitiveMakeUUID' module: 'UUIDPlugin'> + ^nil! - self makeUUID! Item was added: + ----- Method: UUID>>variant (in category 'accessing') ----- + variant + + ^(self at: 9) bitShift: -6! Item was added: + ----- Method: UUID>>version (in category 'accessing') ----- + version + + ^(self at: 7) bitShift: -4!

1 0

Daily Commit Log
by commits＠source.squeak.org 01 Nov '15

01 Nov '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-November/009089.h… Name: Morphic-kfr.1023 Ancestors: Morphic-kfr.1022 Adding a code pane for reading/editing of the color ramp =============================================

1 0

The Trunk: Morphic-kfr.1023.mcz
by commits＠source.squeak.org 01 Nov '15

01 Nov '15

Karl Ramberg uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kfr.1023.mcz ==================== Summary ==================== Name: Morphic-kfr.1023 Author: kfr Time: 1 November 2015, 9:20:03.104 pm UUID: 3f59454c-b3fb-44ac-a78a-29c653670044 Ancestors: Morphic-kfr.1022 Adding a code pane for reading/editing of the color ramp =============== Diff against Morphic-kfr.1022 =============== Item was changed: ----- Method: GradientEditor>>addHandles (in category 'change reporting') ----- addHandles | handle colorRamp | rampMorphs := OrderedCollection new. + colorRamp := gradientDisplay colorRamp asOrderedCollection. - colorRamp := self gradientDisplay colorRamp asOrderedCollection. handle := self handle. colorRamp do: [:i | self addHandleForColor: i value position: i key ]. self changed.! Item was changed: ----- Method: GradientEditor>>colorRamp (in category 'accessing') ----- colorRamp + ^gradientDisplay fillStyle colorRamp asArray printString. + ! - | i string | - string := gradientDisplay fillStyle colorRamp asOrderedCollection printString. - i := string indexOf:$(. - ^string copyFrom: i to: string size! Item was changed: ----- Method: GradientEditor>>colorRamp: (in category 'accessing') ----- colorRamp: aColorRamp - - "rampMorphs do:[ :i | rampMorphs remove:i. row removeMorph: i . ]. - self changed." gradientDisplay colorRamp: aColorRamp. + self changed: #colorRamp. + self changed + - self addHandles. ! Item was added: + ----- Method: GradientEditor>>colorRampExpression: (in category 'accessing') ----- + colorRampExpression: aString + "Set my color by evaluating aString, a Smalltalk expression which results in a Color instance." + | col | + + {aString.} + detect: + [ : each | ([ col := Compiler evaluate: each ] + on: Error + do: + [ : err | nil ]) notNil ] + ifNone: [ nil ]. + col ifNotNil: [ self colorRamp: col. + rampMorphs do:[ :each| each delete]. + self addHandles; updateColorRamp. ]! Item was added: + ----- Method: GradientEditor>>colorRampExpressionMorph (in category 'initialization') ----- + colorRampExpressionMorph + | inputField builder | + builder := ToolBuilder default. + inputField := (builder build: (builder pluggableInputFieldSpec new + model: self; + getText: #colorRamp; + setText: #colorRampExpression:; + softLineWrap: true)). + inputField + hResizing: #spaceFill ; + vResizing: #spaceFill ; + + height: (Preferences standardDefaultTextFont height * 3/2). + ^ inputField! Item was changed: ----- Method: GradientEditor>>eventHandler:target: (in category 'event handling') ----- + eventHandler: anInstance target: aTarget + (anInstance isKindOf: SketchMorph) + ifTrue: [anInstance + on: #mouseUp - eventHandler: anInstance target: aTarget - (anInstance isKindOf: SketchMorph) - ifTrue:[anInstance on: #mouseUp send: #changeColor:event:target: + to: self + withValue: aTarget] + ifFalse: [anInstance + on: #mouseDown - to: self withValue: aTarget] - ifFalse:[anInstance on: #mouseDown send: #limitHandleMove:event:from: + to: self + withValue: aTarget. + anInstance + on: #mouseMove - to: self withValue: aTarget. - anInstance on: #mouseMove send: #limitHandleMove:event:from: + to: self + withValue: aTarget]! - to: self withValue: aTarget]! Item was removed: - ----- Method: GradientEditor>>gradientDisplay (in category 'accessing') ----- - gradientDisplay - ^gradientDisplay! Item was changed: ----- Method: GradientEditor>>handle (in category 'initialization') ----- handle + | handle | + handle := PolygonMorph - | handle | - handle := PolygonMorph vertices: (Array with: 0 @ 0 with: 16 @ 0 with: 8 @ 16) + color: Color white darker - color: (Color white darker) borderWidth: 1 borderColor: Color black. + ^ handle - ^handle addMorph: ((RectangleMorph newBounds: (8 @ 18 extent: 1 @ (gradientDisplay height - 2)) color: Color orange) + borderWidth: 0)! - borderWidth: 0).! Item was changed: ----- Method: GradientEditor>>initialize (in category 'initialization') ----- initialize - super initialize. self myLayout. + self extent: 500 @ 200. + row := RectangleMorph new extent: self width @ 100; + color: Color transparent; + borderColor: #inset. - self extent: 600 @ 150. - row := RectangleMorph new extent: self width @ 100; color: Color transparent; borderColor: #inset. - row addMorph: (gradientDisplay := GradientDisplayMorph new position: 20 @ 20; extent: self width - 40 @ 40). gradientDisplay fillStyle direction: gradientDisplay width @ 0. - self addMorph: row. self addButtonRow. + self addMorph: self colorRampExpressionMorph! - "text := PluggableTextMorph - on: self - text: #colorRamp - accept: nil - readSelection: nil - menu: nil. - text color: Color white; - width: self width; - height: 50. - self addMorph: text." - ! Item was changed: ----- Method: GradientEditor>>setTarget:selector:forMorph:colorRamp: (in category 'initialization') ----- setTarget: aTarget selector: aSelector forMorph:aMorph colorRamp: aColorRamp + self target: aTarget; selector: aSelector; morph: aMorph; colorRamp: aColorRamp; addHandles - self target: aTarget. - self selector: aSelector. - self morph: aMorph. - self colorRamp: aColorRamp. ! Item was changed: ----- Method: GradientEditor>>updateColorRamp (in category 'change reporting') ----- updateColorRamp | newAssociation newKey newColor sketch colorRamp | self updateRampMorphs. colorRamp := OrderedCollection new. rampMorphs do: [:i | newKey := ((i position x - gradientDisplay left / gradientDisplay width) asFloat roundUpTo: 0.01) min: 1.0 max: 0.0. sketch := i findA: SketchMorph. newColor := sketch rotatedForm colorAt: sketch rotatedForm center. newAssociation := newKey -> newColor. colorRamp addLast: newAssociation]. colorRamp := colorRamp sorted. gradientDisplay colorRamp: colorRamp. gradientDisplay fillStyle direction: gradientDisplay extent x @ 0. self changed. target ifNotNil:[ target perform: selector with: colorRamp with: morph]. + self changed: #colorRamp! - "text setText: self colorRamp"!

1 0

Jump to page: