Squeak-dev February 2015

squeak-dev@lists.squeakfoundation.org

45 participants
152 discussions

Re: [Pharo-dev] Determine if a method is Jitted or not
by Eliot Miranda 23 Feb '15

23 Feb '15

Hi Thierry, there's an unadvertised primitive called Context>>#xRay (or ContextPart>>#xRay) that answers these questions for tests. I'm away from the system right now but I'll get you the source soon. Also, the limit on jutting methods, 60 literals, is a default. There's a command line option -maxcoglits (IIRC) that you can change. Eliot (phone) On Feb 23, 2015, at 5:05 AM, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > Hi All, > > anybody knows how to check if a method is jitted or not? > > I remember (maybe wrongly) that the Jit in Cog has a configurable limit on the number of bytecodes for a method to be jitted or not; I'm looking into the performance of generated code where I can, more or less, control the length of methods (SmaCC) and I'd like to find the optimum point. > > Thanks, > > Thierry

1 0

The Trunk: Compiler.spur-bf.294.mcz
by commits＠source.squeak.org 23 Feb '15

23 Feb '15

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler.spur-bf.294.mcz ==================== Summary ==================== Name: Compiler.spur-bf.294 Author: eem Time: 22 February 2015, 5:24:35.514 pm UUID: b10f34e0-1de1-41f6-8e1c-9d160807637a Ancestors: Compiler-bf.294, Compiler.spur-bf.293 Compiler-bf.294 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.240 Accidentally changed method category. =============== Diff against Compiler-bf.294 =============== Item was changed: ----- Method: BytecodeEncoder>>computeMethodHeaderForNumArgs:numTemps:numLits:primitive: (in category 'method generation') ----- computeMethodHeaderForNumArgs: numArgs numTemps: numTemps numLits: numLits primitive: primitiveIndex + numArgs > 15 ifTrue: + [^self error: 'Cannot compile -- too many arguments']. + numTemps > 63 ifTrue: + [^self error: 'Cannot compile -- too many temporary variables']. + numLits > 65535 ifTrue: + [^self error: 'Cannot compile -- too many literals']. + ^(CompiledMethod headerFlagForEncoder: self) + + (numArgs bitShift: 24) + + (numTemps bitShift: 18) + "+ (largeBit bitShift: 17)" "largeBit gets filled in later" + + (primitiveIndex > 0 ifTrue: [1 bitShift: 16] ifFalse: [0]) + + numLits! - "Compute the compiled method header that encodes the arguments - in the receiver's header format (see CompiledMehtod's class comment)." - self subclassResponsibility! Item was removed: - ----- Method: EncoderForV3>>computeMethodHeaderForNumArgs:numTemps:numLits:primitive: (in category 'method generation') ----- - computeMethodHeaderForNumArgs: numArgs numTemps: numTemps numLits: numLits primitive: primitiveIndex - | primBits | - numTemps > 63 ifTrue: - [^self error: 'Cannot compile -- too many temporary variables']. - numLits > 255 ifTrue: - [^self error: 'Cannot compile -- too many literals']. - primBits := primitiveIndex <= 16r1FF - ifTrue: [primitiveIndex] - ifFalse: "For now the high bit of primitive no. is in the 29th bit of header" - [primitiveIndex > 16r3FF ifTrue: [self error: 'prim num too large']. - (primitiveIndex bitAnd: 16r1FF) + ((primitiveIndex bitAnd: 16r200) bitShift: 19)]. - ^(numArgs bitShift: 24) - + (numTemps bitShift: 18) - "+ (largeBit bitShift: 17)" "largeBit gets filled in later" - + (numLits bitShift: 9) - + primBits! Item was changed: ----- Method: EncoderForV3PlusClosures class>>bytecodeSize: (in category 'instruction stream support') ----- bytecodeSize: bytecode "Answer the number of bytes in the bytecode." bytecode <= 125 ifTrue: [^1]. bytecode >= 176 ifTrue: [^1]. bytecode >= 160 ifTrue: "long jumps" [^2]. bytecode >= 144 ifTrue: "short jumps" [^1]. "extensions" bytecode >= 128 ifTrue: + [^#(2 2 2 2 3 2 2 1 1 1 2 3 3 3 3 4) at: bytecode - 127]. - [^#(2 2 2 2 3 2 2 1 1 1 2 nil 3 3 3 4) at: bytecode - 127]. ^nil! Item was added: + ----- Method: EncoderForV3PlusClosures class>>callPrimitiveCode (in category 'bytecode decoding') ----- + callPrimitiveCode + "139 11101111 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" + ^139! Item was added: + ----- Method: EncoderForV3PlusClosures>>genCallPrimitive: (in category 'bytecode generation') ----- + genCallPrimitive: primitiveIndex + "139 11101111 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" + (primitiveIndex < 1 or: [primitiveIndex > 65535]) ifTrue: + [self outOfRangeError: 'primitive index' index: primitiveIndex range: 1 to: 65535]. + stream + nextPut: 139; + nextPut: (primitiveIndex bitAnd: 255); + nextPut: (primitiveIndex bitShift: -8)! Item was changed: ----- Method: MethodNode>>generate:using: (in category 'code generation') ----- generate: trailer using: aCompiledMethodClass "The receiver is the root of a parse tree. Answer an instance of aCompiledMethodClass. The argument, trailer, is arbitrary but is typically either the reference to the source code that is stored with every CompiledMethod, or an encoding of the method's temporary names." + | primErrNode blkSize nLits locals literals stack header method | - | primErrNode blkSize nLits literals stack method | self generate: trailer using: aCompiledMethodClass ifQuick: [:m | encoder noteBlockExtent: (0 to: 2) hasLocals: arguments. m literalAt: 2 put: encoder associationForClass; properties: properties. ^m]. primErrNode := self primitiveErrorVariableName ifNotNil: [encoder fixTemp: self primitiveErrorVariableName]. + self ensureClosureAnalysisDone. + encoder rootNode: self. "this is for BlockNode>>sizeCodeForClosureValue:" - encoder supportsClosureOpcodes ifTrue: - [self ensureClosureAnalysisDone. - encoder rootNode: self. "this is for BlockNode>>sizeCodeForClosureValue:"]. blkSize := (block sizeCodeForEvaluatedValue: encoder) + + (primitive > 0 + ifTrue: [encoder sizeCallPrimitive: primitive] + ifFalse: [0]) + (primErrNode ifNil: [0] ifNotNil: [primErrNode index: arguments size + temporaries size; sizeCodeForStore: encoder "The VM relies on storeIntoTemp: (129)"]). + locals := arguments, temporaries, (primErrNode ifNil: [#()] ifNotNil: [{primErrNode}]). + encoder noteBlockExtent: block blockExtent hasLocals: locals. + header := encoder computeMethodHeaderForNumArgs: arguments size + numTemps: locals size + numLits: (nLits := (literals := encoder allLiterals) size) + primitive: primitive. + method := trailer + createMethod: blkSize + class: aCompiledMethodClass + header: header. - method := aCompiledMethodClass - newBytes: blkSize - trailerBytes: trailer - nArgs: arguments size - nTemps: (encoder supportsClosureOpcodes - ifTrue: [| locals | - locals := arguments, - temporaries, - (primErrNode - ifNil: [#()] - ifNotNil: [{primErrNode}]). - encoder - noteBlockExtent: block blockExtent - hasLocals: locals. - locals size] - ifFalse: [encoder maxTemp]) - nStack: 0 - nLits: (nLits := (literals := encoder allLiterals) size) - primitive: primitive. - nLits > 255 ifTrue: - [^self error: 'Too many literals referenced']. 1 to: nLits do: [:lit | method literalAt: lit put: (literals at: lit)]. encoder streamToMethod: method. stack := ParseStack new init. + primitive > 0 ifTrue: + [encoder genCallPrimitive: primitive. + primErrNode ifNotNil: + [primErrNode emitCodeForStore: stack encoder: encoder]]. - primErrNode ifNotNil: [primErrNode emitCodeForStore: stack encoder: encoder]. stack position: method numTemps. [block emitCodeForEvaluatedValue: stack encoder: encoder] on: Error "If an attempt is made to write too much code the method will be asked" do: [:ex| "to grow, and the grow attempt will fail in CompiledMethod class>>#new:" ex signalerContext sender method = (CompiledMethod class>>#new:) ifTrue: [^self error: 'Compiler code size discrepancy'] ifFalse: [ex pass]]. stack position ~= (method numTemps + 1) ifTrue: [^self error: 'Compiler stack discrepancy']. encoder methodStreamPosition ~= (method size - trailer size) ifTrue: [^self error: 'Compiler code size discrepancy']. method needsFrameSize: stack size - method numTemps. method properties: properties. ^method!

1 0

The Trunk: Compiler.spur-bf.293.mcz
by commits＠source.squeak.org 23 Feb '15

23 Feb '15

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler.spur-bf.293.mcz ==================== Summary ==================== Name: Compiler.spur-bf.293 Author: eem Time: 22 February 2015, 5:24:34.483 pm UUID: 106ba5b5-093c-46bc-8f23-3c1a26aaaf41 Ancestors: Compiler-bf.293, Compiler.spur-topa.292 Compiler-bf.293 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.240 Fix deoptimization of ifNil: etc. =============== Diff against Compiler-bf.293 =============== Item was changed: ----- Method: BytecodeEncoder>>computeMethodHeaderForNumArgs:numTemps:numLits:primitive: (in category 'method generation') ----- computeMethodHeaderForNumArgs: numArgs numTemps: numTemps numLits: numLits primitive: primitiveIndex + numArgs > 15 ifTrue: + [^self error: 'Cannot compile -- too many arguments']. + numTemps > 63 ifTrue: + [^self error: 'Cannot compile -- too many temporary variables']. + numLits > 65535 ifTrue: + [^self error: 'Cannot compile -- too many literals']. + ^(CompiledMethod headerFlagForEncoder: self) + + (numArgs bitShift: 24) + + (numTemps bitShift: 18) + "+ (largeBit bitShift: 17)" "largeBit gets filled in later" + + (primitiveIndex > 0 ifTrue: [1 bitShift: 16] ifFalse: [0]) + + numLits! - "Compute the compiled method header that encodes the arguments - in the receiver's header format (see CompiledMehtod's class comment)." - self subclassResponsibility! Item was removed: - ----- Method: EncoderForV3>>computeMethodHeaderForNumArgs:numTemps:numLits:primitive: (in category 'method generation') ----- - computeMethodHeaderForNumArgs: numArgs numTemps: numTemps numLits: numLits primitive: primitiveIndex - | primBits | - numTemps > 63 ifTrue: - [^self error: 'Cannot compile -- too many temporary variables']. - numLits > 255 ifTrue: - [^self error: 'Cannot compile -- too many literals']. - primBits := primitiveIndex <= 16r1FF - ifTrue: [primitiveIndex] - ifFalse: "For now the high bit of primitive no. is in the 29th bit of header" - [primitiveIndex > 16r3FF ifTrue: [self error: 'prim num too large']. - (primitiveIndex bitAnd: 16r1FF) + ((primitiveIndex bitAnd: 16r200) bitShift: 19)]. - ^(numArgs bitShift: 24) - + (numTemps bitShift: 18) - "+ (largeBit bitShift: 17)" "largeBit gets filled in later" - + (numLits bitShift: 9) - + primBits! Item was changed: ----- Method: EncoderForV3PlusClosures class>>bytecodeSize: (in category 'instruction stream support') ----- bytecodeSize: bytecode "Answer the number of bytes in the bytecode." bytecode <= 125 ifTrue: [^1]. bytecode >= 176 ifTrue: [^1]. bytecode >= 160 ifTrue: "long jumps" [^2]. bytecode >= 144 ifTrue: "short jumps" [^1]. "extensions" bytecode >= 128 ifTrue: + [^#(2 2 2 2 3 2 2 1 1 1 2 3 3 3 3 4) at: bytecode - 127]. - [^#(2 2 2 2 3 2 2 1 1 1 2 nil 3 3 3 4) at: bytecode - 127]. ^nil! Item was added: + ----- Method: EncoderForV3PlusClosures class>>callPrimitiveCode (in category 'bytecode decoding') ----- + callPrimitiveCode + "139 11101111 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" + ^139! Item was added: + ----- Method: EncoderForV3PlusClosures>>genCallPrimitive: (in category 'bytecode generation') ----- + genCallPrimitive: primitiveIndex + "139 11101111 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" + (primitiveIndex < 1 or: [primitiveIndex > 65535]) ifTrue: + [self outOfRangeError: 'primitive index' index: primitiveIndex range: 1 to: 65535]. + stream + nextPut: 139; + nextPut: (primitiveIndex bitAnd: 255); + nextPut: (primitiveIndex bitShift: -8)! Item was changed: ----- Method: MethodNode>>generate:using: (in category 'code generation') ----- generate: trailer using: aCompiledMethodClass "The receiver is the root of a parse tree. Answer an instance of aCompiledMethodClass. The argument, trailer, is arbitrary but is typically either the reference to the source code that is stored with every CompiledMethod, or an encoding of the method's temporary names." + | primErrNode blkSize nLits locals literals stack header method | - | primErrNode blkSize nLits literals stack method | self generate: trailer using: aCompiledMethodClass ifQuick: [:m | encoder noteBlockExtent: (0 to: 2) hasLocals: arguments. m literalAt: 2 put: encoder associationForClass; properties: properties. ^m]. primErrNode := self primitiveErrorVariableName ifNotNil: [encoder fixTemp: self primitiveErrorVariableName]. + self ensureClosureAnalysisDone. + encoder rootNode: self. "this is for BlockNode>>sizeCodeForClosureValue:" - encoder supportsClosureOpcodes ifTrue: - [self ensureClosureAnalysisDone. - encoder rootNode: self. "this is for BlockNode>>sizeCodeForClosureValue:"]. blkSize := (block sizeCodeForEvaluatedValue: encoder) + + (primitive > 0 + ifTrue: [encoder sizeCallPrimitive: primitive] + ifFalse: [0]) + (primErrNode ifNil: [0] ifNotNil: [primErrNode index: arguments size + temporaries size; sizeCodeForStore: encoder "The VM relies on storeIntoTemp: (129)"]). + locals := arguments, temporaries, (primErrNode ifNil: [#()] ifNotNil: [{primErrNode}]). + encoder noteBlockExtent: block blockExtent hasLocals: locals. + header := encoder computeMethodHeaderForNumArgs: arguments size + numTemps: locals size + numLits: (nLits := (literals := encoder allLiterals) size) + primitive: primitive. + method := trailer + createMethod: blkSize + class: aCompiledMethodClass + header: header. - method := aCompiledMethodClass - newBytes: blkSize - trailerBytes: trailer - nArgs: arguments size - nTemps: (encoder supportsClosureOpcodes - ifTrue: [| locals | - locals := arguments, - temporaries, - (primErrNode - ifNil: [#()] - ifNotNil: [{primErrNode}]). - encoder - noteBlockExtent: block blockExtent - hasLocals: locals. - locals size] - ifFalse: [encoder maxTemp]) - nStack: 0 - nLits: (nLits := (literals := encoder allLiterals) size) - primitive: primitive. - nLits > 255 ifTrue: - [^self error: 'Too many literals referenced']. 1 to: nLits do: [:lit | method literalAt: lit put: (literals at: lit)]. encoder streamToMethod: method. stack := ParseStack new init. + primitive > 0 ifTrue: + [encoder genCallPrimitive: primitive. + primErrNode ifNotNil: + [primErrNode emitCodeForStore: stack encoder: encoder]]. - primErrNode ifNotNil: [primErrNode emitCodeForStore: stack encoder: encoder]. stack position: method numTemps. [block emitCodeForEvaluatedValue: stack encoder: encoder] on: Error "If an attempt is made to write too much code the method will be asked" do: [:ex| "to grow, and the grow attempt will fail in CompiledMethod class>>#new:" ex signalerContext sender method = (CompiledMethod class>>#new:) ifTrue: [^self error: 'Compiler code size discrepancy'] ifFalse: [ex pass]]. stack position ~= (method numTemps + 1) ifTrue: [^self error: 'Compiler stack discrepancy']. encoder methodStreamPosition ~= (method size - trailer size) ifTrue: [^self error: 'Compiler code size discrepancy']. method needsFrameSize: stack size - method numTemps. method properties: properties. ^method!

1 0

Ok Now Go vote!
by Ron Teitelbaum 21 Feb '15

21 Feb '15

Hi Everyone, If you voted on Tuesday Feb 17th 2015 when the voting server went down please go and vote again. Your vote may be recorded but if the system lets you vote then your vote was lost. Anyone that has not voted yet, what are you waiting for? The voting system is back up and running and waiting for you to go vote! I've considered extending the election but I'm not sure it needs to be done. If anyone objects we can extend the election for 3 days. Hearing no objections the vote will end on schedule on: Tuesday 24th of February 2015 6PM (23.00 UTC): Online election ends. Sorry for the issue but a big thank you to Andrew for the software and for getting it up and running again after the crash! Don't forget to vote! All the best, Ron Teitelbaum

3 2

Don't forget to Vote
by Ron Teitelbaum 21 Feb '15

21 Feb '15

Hi All, Just a reminder to everyone that received a ballot for the 2015 Squeak Oversight Board. Please look for an email from an andru(a)cs.cornell.edu Subject: Poll: Squeak Oversight Board 2015 Sent on Monday Feb 16, 2015. Follow the link and vote. Thanks! Ron Teitelbaum

4 6

Incomplete deoptimization of #ifNotNil: and #ifNotNil:ifNil:
by Levente Uzonyi 20 Feb '15

20 Feb '15

Hi All, There's a bug in the compiler which should be easy to fix for someone familiar with the code. The following expression returns #(nil nil true true) instead of #(nil nil nil nil): { nil ifNil: [ 1 ] ifNotNil: [ 2 ]; yourself. nil ifNil: [ 1 ]; yourself. nil ifNotNil: [ 2 ]; yourself. nil ifNotNil: [ 2 ] ifNil: [ 1 ]; yourself. } The cause of the problem is that in case of #ifNotNil: and #ifNotNil:ifNil: the deoptimization doesn't clear all previously generated optimized bytecodes. E.g. in case of #ifNotNil: instead of <73> pushConstant: nil <88> dup <8F 00 00 02> closureNumCopied: 0 numArgs: 0 bytes 33 to 34 <76> pushConstant: 1 <7D> blockReturn <E0> send: ifNotNil: <87> pop <D1> send: yourself we get <73> pushConstant: nil <73> pushConstant: nil <C6> send: == <88> dup <8F 00 00 02> closureNumCopied: 0 numArgs: 0 bytes 33 to 34 <76> pushConstant: 1 <7D> blockReturn <E0> send: ifNotNil: <87> pop <D1> send: yourself It would be great to write some tests which cover all such cases (including other methods), but I'm not sure what form is the best for this. Simple tests which just verify some values? Or something that checks the generated bytecodes? Levente

3 4

The Trunk: Compiler-bf.294.mcz
by commits＠source.squeak.org 20 Feb '15

20 Feb '15

Bert Freudenberg uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-bf.294.mcz ==================== Summary ==================== Name: Compiler-bf.294 Author: bf Time: 19 February 2015, 6:40:12.921 pm UUID: 729e0ce5-c7f6-4758-a553-22ba8004be57 Ancestors: Compiler-bf.293 Accidentally changed method category. =============== Diff against Compiler-bf.293 =============== Item was changed: + ----- Method: MessageNode>>receiver:arguments:precedence: (in category 'private') ----- - ----- Method: MessageNode>>receiver:arguments:precedence: (in category 'cascading') ----- receiver: rcvr arguments: args precedence: p receiver := rcvr. originalReceiver := rcvr copy. arguments := args. originalArguments := arguments copy. sizes := Array new: arguments size. precedence := p!

1 0

The Trunk: Compiler-bf.293.mcz
by commits＠source.squeak.org 20 Feb '15

20 Feb '15

Bert Freudenberg uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-bf.293.mcz ==================== Summary ==================== Name: Compiler-bf.293 Author: bf Time: 19 February 2015, 6:22:49.349 pm UUID: 737af1fb-e8f0-4653-851b-0c1b3ed0f65f Ancestors: Compiler-topa.292 Fix deoptimization of ifNil: etc. =============== Diff against Compiler-topa.292 =============== Item was changed: ParseNode subclass: #MessageNode + instanceVariableNames: 'receiver selector precedence special arguments sizes equalNode caseErrorNode originalReceiver originalSelector originalArguments' - instanceVariableNames: 'receiver selector precedence special arguments sizes equalNode caseErrorNode originalSelector originalArguments' classVariableNames: 'MacroEmitters MacroPrinters MacroSelectors MacroSizers MacroTransformers StdTypers ThenFlag' poolDictionaries: '' category: 'Compiler-ParseNodes'! !MessageNode commentStamp: '<historical>' prior: 0! I represent a receiver and its message. Precedence codes: 1 unary 2 binary 3 keyword 4 other If special>0, I compile special code in-line instead of sending messages with literal methods as remotely copied contexts.! Item was changed: + ----- Method: MessageNode>>ensureCanCascade: (in category 'cascading') ----- - ----- Method: MessageNode>>ensureCanCascade: (in category 'testing') ----- ensureCanCascade: encoder - special > 0 ifTrue: [special := 0. + receiver := originalReceiver. selector := encoder encodeSelector: originalSelector. arguments := originalArguments. receiver isBlockNode ifTrue: [receiver deoptimize]. arguments do: [:each| each isBlockNode ifTrue: [each deoptimize]]]! Item was changed: + ----- Method: MessageNode>>receiver:arguments:precedence: (in category 'cascading') ----- - ----- Method: MessageNode>>receiver:arguments:precedence: (in category 'private') ----- receiver: rcvr arguments: args precedence: p receiver := rcvr. + originalReceiver := rcvr copy. arguments := args. originalArguments := arguments copy. sizes := Array new: arguments size. precedence := p!

1 0

So who broke bitOr: ?
by tim Rowledge 20 Feb '15

20 Feb '15

On a fresh Pi vm (as in svn updated yesterday) 16rFFFF bitOr:(16rFFFF bitShift: 16) -> -1 On a slightly older Mac vm 16rFFFF bitOr:(16rFFFF bitShift: 16) -> 4294967295, aka 16rFFFFFFFF This breaks, amongst other things, Color>bitPatternForDepth:, whcih pretty much trashes an image since that gets used to makes cursor bitmaps as you move the pointer around. Nicely fills your window with notifiers… So come along; hands up the boy that did that! I’ll keep you all in late unless someone confesses. It’s only your own time you’re wasting! Was it *you* Molesworth? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: PBC: Print and Break Chain

4 9

Add Search To Message Archive
by Kirk Fraser 19 Feb '15

19 Feb '15

A search on the archive would help beginners find previous discussions, in some cases before asking again. Thanks. Kirk W. Fraser w <http://freetom.info/TrueChurch>ww.JesusGospelChurch.com <http://www.JesusGospelChurch.com> - Replace the fraud churches with the true church. http://freetom.info - Example of False Justice common in America

2 1

← Newer
1
...
5
6
7
8
9
10
11
...
16
Older →

Jump to page: