Squeak-dev April 2015

squeak-dev@lists.squeakfoundation.org

38 participants
642 discussions

The Trunk: ToolBuilder-Morphic-mt.111.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.111.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.111 Author: mt Time: 1 April 2015, 4:34:47.411 pm UUID: df7f741e-5af0-c14f-b019-03ed2d822fc9 Ancestors: ToolBuilder-Morphic-mt.110 Fixed should background-styling to update text morph runs only from within the morphic UI process. =============== Diff against ToolBuilder-Morphic-mt.110 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>stylerStyledInBackground: (in category 'styling') ----- stylerStyledInBackground: styledCopyOfText "Sent after the styler completed styling of the text" "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" + Project current addDeferredUIMessage: [ + textMorph contents string = styledCopyOfText string + ifTrue: [self stylerStyled: styledCopyOfText]].! - textMorph contents string = styledCopyOfText string - ifTrue: [self stylerStyled: styledCopyOfText]!

1 0

The Trunk: Kernel-topa.916.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Tobias Pape uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-topa.916.mcz ==================== Summary ==================== Name: Kernel-topa.916 Author: topa Time: 1 April 2015, 2:00:39.799 pm UUID: 8f05add4-c132-40ad-a4cc-a6131ec098f3 Ancestors: Kernel-topa.915 (same as before) Fix arguments access in WeakMessageSend =============== Diff against Kernel-topa.915 =============== Item was changed: ----- Method: WeakMessageSend>>withEnsuredReceiverAndArgumentsDo:otherwise: (in category 'private') ----- withEnsuredReceiverAndArgumentsDo: aBlock otherwise: altBlock "Grab real references to receiver and arguments. If they still exist, evaluate aBlock." "Return if my receiver has gone away" | r a | r := self receiver. r ifNil: [ ^altBlock value ]. "Make sure that my arguments haven't gone away" + a := Array withAll: self arguments. - a := Array withAll: arguments. a with: shouldBeNil do: [ :arg :flag | arg ifNil: [ flag ifFalse: [ ^altBlock value ]] ]. ^aBlock value: r value: a!

1 0

The Trunk: Morphic-mt.802.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.802.mcz ==================== Summary ==================== Name: Morphic-mt.802 Author: mt Time: 1 April 2015, 1:49:26.461 pm UUID: 86843cf8-a4d3-104e-baa1-d6004e8e3013 Ancestors: Morphic-mt.801 Fixed layouting bug of horizontal scrollbar if vertical scroll bar is on the left. =============== Diff against Morphic-mt.801 =============== Item was changed: ----- Method: ScrollPane>>hResizeScrollBar (in category 'geometry') ----- hResizeScrollBar + | topLeft h border offset | - | topLeft h border | "TEMPORARY: IF OLD SCROLLPANES LYING AROUND THAT DON'T HAVE A hScrollBar, INIT THEM" hScrollBar ifNil: [ self hInitScrollBarTEMPORARY]. (self valueOfProperty: #noHScrollBarPlease ifAbsent: [false]) ifTrue: [^self]. bounds ifNil: [ self fullBounds ]. h := self scrollBarThickness. border := borderWidth. + offset := scrollBarOnLeft ifTrue: [h] ifFalse: [0]. topLeft := retractableScrollBar + ifTrue: [bounds bottomLeft + (border + offset @ border negated)] + ifFalse: [bounds bottomLeft + (border + offset @ (h + border) negated)]. - ifTrue: [bounds bottomLeft + (border @ border negated)] - ifFalse: [bounds bottomLeft + (border @ (h + border) negated)]. hScrollBar bounds: (topLeft + (-1@1) extent: self hScrollBarWidth@ h) !

1 0

The Trunk: Morphic-mt.801.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.801.mcz ==================== Summary ==================== Name: Morphic-mt.801 Author: mt Time: 1 April 2015, 1:36:02.765 pm UUID: 755e5f34-e9d2-a84e-a23e-c33ad43e082e Ancestors: Morphic-mt.800 Scrollbars: Fixed button initialization code for rounded scrollbars. =============== Diff against Morphic-mt.800 =============== Item was changed: ----- Method: ScrollBar>>initializeMenuButton (in category 'initialize') ----- initializeMenuButton "initialize the receiver's menuButton" "Preferences disable: #scrollBarsWithoutMenuButton" "Preferences enable: #scrollBarsWithoutMenuButton" (Preferences valueOfFlag: #scrollBarsWithoutMenuButton) ifTrue: [menuButton := nil .^ self]. self bounds isWide ifTrue: [menuButton := nil .^ self]. + menuButton := RectangleMorph - menuButton := self class roundedScrollBarLook - ifTrue: [RectangleMorph - newBounds: ((bounds isWide - ifTrue: [upButton bounds topRight] - ifFalse: [upButton bounds bottomLeft]) - extent: self buttonExtent)] - ifFalse: [RectangleMorph newBounds: (self innerBounds topLeft extent: self buttonExtent) + color: self thumbColor. - color: self thumbColor]. menuButton on: #mouseEnter send: #menuButtonMouseEnter: to: self. menuButton on: #mouseDown send: #menuButtonMouseDown: to: self. menuButton on: #mouseLeave send: #menuButtonMouseLeave: to: self. "menuButton addMorphCentered: (RectangleMorph newBounds: (0 @ 0 extent: 4 @ 2) color: Color black)." self updateMenuButtonImage. self class roundedScrollBarLook ifTrue: [menuButton color: Color veryLightGray. menuButton borderStyle: (BorderStyle complexRaised width: 3)] ifFalse: [menuButton setBorderWidth: 1 borderColor: Color lightGray]. self addMorph: menuButton! Item was changed: ----- Method: ScrollBar>>initializeSlider (in category 'initialize') ----- initializeSlider + + self + initializeMenuButton; + initializeUpButton; + initializeDownButton; + initializePagingArea. + - "initialize the receiver's slider" - self class roundedScrollBarLook - ifTrue: [self initializeUpButton; initializeMenuButton; initializeDownButton; initializePagingArea] - ifFalse: [self initializeMenuButton; initializeUpButton; initializeDownButton; initializePagingArea]. super initializeSlider. self class roundedScrollBarLook ifTrue: [slider cornerStyle: #rounded. slider borderStyle: (BorderStyle complexRaised width: 3). sliderShadow cornerStyle: #rounded]. self sliderColor: self sliderColor! Item was changed: ----- Method: ScrollBar>>initializeUpButton (in category 'initialize') ----- initializeUpButton "initialize the receiver's upButton" + upButton := RectangleMorph + newBounds: ((menuButton + ifNil: [self innerBounds topLeft] + ifNotNil: [bounds isWide + ifTrue: [menuButton bounds topRight - (1@0)] + ifFalse: [menuButton bounds bottomLeft - (0@1)]]) + extent: self buttonExtent). - upButton := self class roundedScrollBarLook - ifTrue: [RectangleMorph - newBounds: (self innerBounds topLeft extent: self buttonExtent)] - ifFalse: [RectangleMorph - newBounds: ((menuButton - ifNil: [self innerBounds topLeft] - ifNotNil: [bounds isWide - ifTrue: [menuButton bounds topRight - (1@0)] - ifFalse: [menuButton bounds bottomLeft - (0@1)]]) - extent: self buttonExtent)]. upButton color: self thumbColor. upButton on: #mouseDown send: #scrollUpInit to: self. upButton on: #mouseUp send: #finishedScrolling to: self. self updateUpButtonImage. self class roundedScrollBarLook ifTrue: [upButton color: Color veryLightGray. upButton borderStyle: (BorderStyle complexRaised width: 3)] ifFalse: [upButton setBorderWidth: 1 borderColor: Color lightGray]. self class scrollBarsWithoutArrowButtons ifFalse: [self addMorph: upButton].!

1 0

The Trunk: Morphic-mt.800.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.800.mcz ==================== Summary ==================== Name: Morphic-mt.800 Author: mt Time: 1 April 2015, 1:18:34.183 pm UUID: 348486a9-bf29-0a42-b162-ddb7adaab048 Ancestors: Morphic-mt.799 Elevated #roundedScrollBarLook into a preference (was: just hardcoded to false) and updated affected methods. Added preference to hide even the arrow buttons of all scrollbars. This makes sense for mouse-wheel-driven usage. =============== Diff against Morphic-mt.799 =============== Item was changed: Slider subclass: #ScrollBar instanceVariableNames: 'menuButton upButton downButton pagingArea scrollDelta pageDelta interval menuSelector timeOfMouseDown timeOfLastScroll nextPageDirection currentScrollDelay' + classVariableNames: 'ArrowImagesCache BoxesImagesCache RoundedScrollBarLook ScrollBarsWithoutArrowButtons UpArrow UpArrow8Bit' - classVariableNames: 'ArrowImagesCache BoxesImagesCache UpArrow UpArrow8Bit' poolDictionaries: '' category: 'Morphic-Windows'! !ScrollBar commentStamp: '<historical>' prior: 0! Inspired by an oiginal design of Hans-Martin Mosner, this ScrollBar is intended to exercise the handling of input events in Morphic. With sufficient flexibility in this area, all particular behavior can be concentrated in this single class with no need to specialize any other morphs to achieve button, slider and menu-button behavior. Once we have this working, put in logic for horizontal operation as well. CachedImages was added to reduce the number of forms created and thrown away. This will be helpful for Nebraska and others as well.! Item was added: + ----- Method: ScrollBar class>>roundedScrollBarLook (in category 'preferences') ----- + roundedScrollBarLook + + <preference: 'roundedScrollBarLook' + category: #scrolling + description: 'If true, morphic scrollbars will look rounded.' + type: #Boolean> + ^ RoundedScrollBarLook ifNil: [false]! Item was added: + ----- Method: ScrollBar class>>roundedScrollBarLook: (in category 'preferences') ----- + roundedScrollBarLook: aBoolean + + RoundedScrollBarLook := aBoolean.! Item was added: + ----- Method: ScrollBar class>>scrollBarsWithoutArrowButtons (in category 'preferences') ----- + scrollBarsWithoutArrowButtons + + <preference: 'scrollBarsWithoutArrowButtons' + category: #scrolling + description: 'If true, morphic scrollbars will not include arrow buttons but only the slider.' + type: #Boolean> + ^ ScrollBarsWithoutArrowButtons ifNil: [false]! Item was added: + ----- Method: ScrollBar class>>scrollBarsWithoutArrowButtons: (in category 'preferences') ----- + scrollBarsWithoutArrowButtons: aBoolean + + ScrollBarsWithoutArrowButtons := aBoolean.! Item was changed: ----- Method: ScrollBar>>finishedScrolling (in category 'scrolling') ----- finishedScrolling self stopStepping. self scrollBarAction: nil. + self class roundedScrollBarLook ifTrue:[ - self roundedScrollbarLook ifTrue:[ upButton borderStyle: (BorderStyle complexRaised width: upButton borderWidth). downButton borderStyle: (BorderStyle complexRaised width: downButton borderWidth). ] ifFalse:[ downButton borderStyle: BorderStyle thinGray. upButton borderStyle: BorderStyle thinGray. ]. ! Item was added: + ----- Method: ScrollBar>>hasButtons (in category 'testing') ----- + hasButtons + + ^ (menuButton notNil or: [upButton owner notNil]) or: [downButton owner notNil]! Item was changed: ----- Method: ScrollBar>>initialize (in category 'initialize') ----- initialize + super initialize. + scrollDelta := 0.02. pageDelta := 0.2. + + self color: Color transparent. + + self class roundedScrollBarLook + ifFalse: [self borderWidth: 0] + ifTrue:[self borderStyle: ((BorderStyle complexFramed width: 2) "baseColor: Color gray")].! - self roundedScrollbarLook ifTrue:[ - self borderStyle: ((BorderStyle complexFramed width: 2) "baseColor: Color gray")].! Item was changed: ----- Method: ScrollBar>>initializeDownButton (in category 'initialize') ----- initializeDownButton "initialize the receiver's downButton" downButton := RectangleMorph newBounds: (self innerBounds bottomRight - self buttonExtent extent: self buttonExtent) color: self thumbColor. downButton on: #mouseDown send: #scrollDownInit to: self. downButton on: #mouseUp send: #finishedScrolling to: self. self updateDownButtonImage. + self class roundedScrollBarLook - self roundedScrollbarLook ifTrue: [downButton color: Color veryLightGray. downButton borderStyle: (BorderStyle complexRaised width: 3)] ifFalse: [downButton setBorderWidth: 1 borderColor: Color lightGray]. + + self class scrollBarsWithoutArrowButtons + ifFalse: [self addMorph: downButton].! - self addMorph: downButton! Item was changed: ----- Method: ScrollBar>>initializeEmbedded: (in category 'initialize') ----- initializeEmbedded: aBool "aBool == true => inboard scrollbar aBool == false => flop-out scrollbar" + self class roundedScrollBarLook ifFalse:[^self]. - self roundedScrollbarLook ifFalse:[^self]. aBool ifTrue:[ self borderStyle: (BorderStyle inset width: 2). self cornerStyle: #square. ] ifFalse:[ self borderStyle: (BorderStyle width: 1 color: Color black). self cornerStyle: #rounded. ]. self removeAllMorphs. self initializeSlider.! Item was changed: ----- Method: ScrollBar>>initializeMenuButton (in category 'initialize') ----- initializeMenuButton "initialize the receiver's menuButton" "Preferences disable: #scrollBarsWithoutMenuButton" "Preferences enable: #scrollBarsWithoutMenuButton" (Preferences valueOfFlag: #scrollBarsWithoutMenuButton) ifTrue: [menuButton := nil .^ self]. self bounds isWide ifTrue: [menuButton := nil .^ self]. + menuButton := self class roundedScrollBarLook - menuButton := self roundedScrollbarLook ifTrue: [RectangleMorph newBounds: ((bounds isWide ifTrue: [upButton bounds topRight] ifFalse: [upButton bounds bottomLeft]) extent: self buttonExtent)] ifFalse: [RectangleMorph newBounds: (self innerBounds topLeft extent: self buttonExtent) color: self thumbColor]. menuButton on: #mouseEnter send: #menuButtonMouseEnter: to: self. menuButton on: #mouseDown send: #menuButtonMouseDown: to: self. menuButton on: #mouseLeave send: #menuButtonMouseLeave: to: self. "menuButton addMorphCentered: (RectangleMorph newBounds: (0 @ 0 extent: 4 @ 2) color: Color black)." self updateMenuButtonImage. + self class roundedScrollBarLook - self roundedScrollbarLook ifTrue: [menuButton color: Color veryLightGray. menuButton borderStyle: (BorderStyle complexRaised width: 3)] ifFalse: [menuButton setBorderWidth: 1 borderColor: Color lightGray]. self addMorph: menuButton! Item was changed: ----- Method: ScrollBar>>initializePagingArea (in category 'initialize') ----- initializePagingArea + + "Appearance" - "initialize the receiver's pagingArea" pagingArea := RectangleMorph newBounds: self totalSliderArea + color: (self class roundedScrollBarLook + ifTrue: [Color gray: 0.9] + ifFalse: [Color r: 0.6 g: 0.6 b: 0.8]). + pagingArea setBorderWidth: 1 borderColor: (Color lightGray alpha: 0.5). + self addMorphBack: pagingArea. + + "Interactions" - color: (Color - r: 0.6 - g: 0.6 - b: 0.8). - pagingArea setBorderWidth: 1 borderColor: Color lightGray. pagingArea on: #mouseDown send: #scrollPageInit: to: self. pagingArea on: #mouseUp send: #finishedScrolling to: self. + + ! - self addMorphBack: pagingArea. - self roundedScrollbarLook - ifTrue: [pagingArea - color: (Color gray: 0.9)]! Item was changed: ----- Method: ScrollBar>>initializeSlider (in category 'initialize') ----- initializeSlider "initialize the receiver's slider" + self class roundedScrollBarLook - self roundedScrollbarLook ifTrue: [self initializeUpButton; initializeMenuButton; initializeDownButton; initializePagingArea] ifFalse: [self initializeMenuButton; initializeUpButton; initializeDownButton; initializePagingArea]. super initializeSlider. + self class roundedScrollBarLook - self roundedScrollbarLook ifTrue: [slider cornerStyle: #rounded. slider borderStyle: (BorderStyle complexRaised width: 3). sliderShadow cornerStyle: #rounded]. self sliderColor: self sliderColor! Item was changed: ----- Method: ScrollBar>>initializeUpButton (in category 'initialize') ----- initializeUpButton "initialize the receiver's upButton" + upButton := self class roundedScrollBarLook - upButton := self roundedScrollbarLook ifTrue: [RectangleMorph newBounds: (self innerBounds topLeft extent: self buttonExtent)] ifFalse: [RectangleMorph newBounds: ((menuButton ifNil: [self innerBounds topLeft] ifNotNil: [bounds isWide ifTrue: [menuButton bounds topRight - (1@0)] ifFalse: [menuButton bounds bottomLeft - (0@1)]]) extent: self buttonExtent)]. upButton color: self thumbColor. upButton on: #mouseDown send: #scrollUpInit to: self. upButton on: #mouseUp send: #finishedScrolling to: self. self updateUpButtonImage. + self class roundedScrollBarLook - self roundedScrollbarLook ifTrue: [upButton color: Color veryLightGray. upButton borderStyle: (BorderStyle complexRaised width: 3)] ifFalse: [upButton setBorderWidth: 1 borderColor: Color lightGray]. + + self class scrollBarsWithoutArrowButtons + ifFalse: [self addMorph: upButton].! - self addMorph: upButton! Item was removed: - ----- Method: ScrollBar>>roundedScrollbarLook (in category 'access') ----- - roundedScrollbarLook - "Rounded look currently only shows up in flop-out mode" - ^false and: [ - self class alwaysShowFlatScrollbarForAlternativeLook not] - ! Item was changed: ----- Method: ScrollBar>>sliderShadowColor (in category 'access') ----- sliderShadowColor + ^ self class roundedScrollBarLook - ^ self roundedScrollbarLook ifTrue: [self sliderColor darker] ifFalse: [super sliderShadowColor] ! Item was changed: ----- Method: ScrollBar>>totalSliderArea (in category 'geometry') ----- totalSliderArea + | upperReferenceBounds lowerReferenceBounds | + upperReferenceBounds := (upButton owner ifNil: [menuButton] ifNotNil: [upButton]) + ifNil: [self topLeft corner: (bounds isWide ifTrue: [self bottomLeft + (1@0)] ifFalse: [self topRight + (0@1)])] + ifNotNil: [:button | button bounds]. + lowerReferenceBounds := downButton owner + ifNil: [(bounds isWide ifTrue: [self topRight - (1@0)] ifFalse: [self bottomLeft - (0@1)]) corner: self bottomRight] + ifNotNil: [downButton bounds]. + ^ bounds isWide + ifTrue: [upperReferenceBounds topRight - (1@0) corner: lowerReferenceBounds bottomLeft + (1@0)] + ifFalse:[upperReferenceBounds bottomLeft - (0@1) corner: lowerReferenceBounds topRight + (0@1)]. - | upperBoundsButton | - upperBoundsButton := menuButton ifNil: [upButton]. - bounds isWide - ifTrue: [ - upButton right > upperBoundsButton right - ifTrue: [upperBoundsButton := upButton]. - ^upperBoundsButton bounds topRight - (1@0) corner: downButton bounds bottomLeft + (1@0)] - ifFalse:[ - upButton bottom > upperBoundsButton bottom - ifTrue: [upperBoundsButton := upButton]. - ^upperBoundsButton bounds bottomLeft - (0@1) corner: downButton bounds topRight + (0@1)]. ! Item was changed: ----- Method: ScrollBar>>updateSliderColor: (in category 'access') ----- updateSliderColor: aColor | gradient | - slider borderStyle: (BorderStyle width: 1 color: Color lightGray). self borderWidth: 0. Preferences gradientScrollBars ifFalse: [ + slider borderStyle: (BorderStyle width: 1 color: aColor muchDarker). slider color: aColor. + pagingArea color: (aColor darker alpha: 0.45). - pagingArea color: aColor darker darker. ^ self]. + slider borderStyle: (BorderStyle width: 1 color: Color lightGray). + "Fill the slider." gradient := GradientFillStyle ramp: { 0 -> (Color gray: 0.95). 0.49 -> (Color gray: 0.9). 0.5 -> (Color gray: 0.87). 1 -> (Color gray: 0.93). }. gradient origin: slider topLeft. gradient direction: (self bounds isWide ifTrue:[0@slider height] ifFalse:[slider width@0]). slider fillStyle: gradient. "Fill the paging area." gradient := GradientFillStyle ramp: { 0 -> (Color gray: 0.65). 0.6 -> (Color gray: 0.82). 1 -> (Color gray: 0.88). }. gradient origin: self topLeft. gradient direction: (self bounds isWide ifTrue:[0@self height] ifFalse:[self width@0]). pagingArea fillStyle: gradient.!

1 0

Re: The Trunk: Morphic-mt.800.mcz
by Marcel Taeumel 01 Apr '15

01 Apr '15

<http://forum.world.st/file/n4816614/small-scrollbars.png> In conjuction with narrow scrollbars and no menu button, you can save some space on screen with it. For the sake of comparison, you see the default setting on the right: gradient enabled, menu button visible, arrow buttons visible, normal width. I thought about making the background/paging area transparent but this would affect discoverability of its features. Do you yet try to click on the area besides the draggable thumb? ;-) Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-Morphic-mt-800-mcz-tp4816610p4816614.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

The Trunk: Morphic-mt.799.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.799.mcz ==================== Summary ==================== Name: Morphic-mt.799 Author: mt Time: 1 April 2015, 10:48:52.717 am UUID: 8402d670-ebfe-6a4b-9563-16fc41d80d37 Ancestors: Morphic-mt.798 Remove the balloon text when start typing because we assume that the user focuses on the input and not the help anymore. This is similar to balloon help for buttons where the bubble disappears if the user clicks the button. =============== Diff against Morphic-mt.798 =============== Item was changed: ----- Method: TextMorphForEditView>>keyStroke: (in category 'event handling') ----- keyStroke: evt | view | + editView deleteBalloon. (editView scrollByKeyboard: evt) ifTrue: [^self]. self editor model: editView model. "For evaluateSelection" view := editView. "Copy into temp for case of a self-mutating doit" (acceptOnCR and: [evt keyCharacter = Character cr]) ifTrue: [^ self editor accept]. super keyStroke: evt. view scrollSelectionIntoView!

1 0

The Trunk: Morphic-mt.798.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.798.mcz ==================== Summary ==================== Name: Morphic-mt.798 Author: mt Time: 1 April 2015, 10:34:38.43 am UUID: b8569c16-d9cb-a24e-b4d5-a6b7f6abd7ba Ancestors: Morphic-mt.797 Fixes error that may occur in empty lazy lists when mapping a point to a row index. =============== Diff against Morphic-mt.797 =============== Item was changed: ----- Method: LazyListMorph>>rowAtLocation: (in category 'list management') ----- rowAtLocation: aPoint "return the number of the row at aPoint" | y | y := aPoint y. + y < self top ifTrue: [ ^ 1 min: listItems size ]. - y < self top ifTrue: [ ^ 1 ]. ^((y - self top // (font height)) + 1) min: listItems size max: 0!

1 0

The Trunk: ToolBuilder-Morphic-mt.110.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.110.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.110 Author: mt Time: 1 April 2015, 10:25:52.197 am UUID: d7697fb6-b947-8e4a-a6b7-e8a087d2c81f Ancestors: ToolBuilder-Morphic-mt.109 Revert "code to indicate the actual selection" because I confused the view-based API with the model-based API. =============== Diff against ToolBuilder-Morphic-mt.109 =============== Item was changed: ----- Method: PluggableTreeMorph>>selectPath:in: (in category 'selection') ----- selectPath: path in: listItem + path isEmpty ifTrue: [^self setSelectedMorph: nil]. - path isEmpty ifTrue: [^self selection: nil]. - listItem withSiblingsDo: [:each | (each complexContents item = path first) ifTrue: [ each isExpanded ifFalse: [ each toggleExpandedState. self adjustSubmorphPositions. ]. each changed. path size = 1 ifTrue: [ + ^self setSelectedMorph: each - ^self selection: each complexContents ]. + each firstChild ifNil: [^self setSelectedMorph: nil]. - each firstChild ifNil: [^self selection: nil]. ^self selectPath: path allButFirst in: each firstChild ]. ]. + ^self setSelectedMorph: nil - ^self selection: nil !

1 0

The Trunk: Tools-mt.569.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.569.mcz ==================== Summary ==================== Name: Tools-mt.569 Author: mt Time: 1 April 2015, 9:16:07.657 am UUID: 571e1638-a483-0548-90e1-92a3cc15406a Ancestors: Tools-mt.568 Fixed selection in FileList tool. =============== Diff against Tools-mt.568 =============== Item was changed: ----- Method: FileList>>buildDirectoryTreeWith: (in category 'toolbuilder') ----- buildDirectoryTreeWith: builder | treeSpec | treeSpec := builder pluggableTreeSpec new. treeSpec model: self ; roots: #rootDirectoryList ; hasChildren: #hasMoreDirectories: ; getChildren: #subDirectoriesOf: ; getSelectedPath: #selectedPath ; setSelected: #setDirectoryTo: ; + getSelected: #directory; label: #directoryNameOf: ; menu: #volumeMenu: ; autoDeselect: false. SystemBrowser browseWithDragNDrop ifTrue: [ treeSpec dragItem: #dragFromDirectoryList: ; dropItem: #drop:ontoDirectory:shouldCopy: ]. ^ treeSpec! Item was changed: ----- Method: FileList>>directory: (in category 'initialization') ----- directory: aFileDirectory "Set the path of the volume to be displayed." self okToChange ifFalse: [ ^ self ]. self modelSleep. directory := aFileDirectory. self modelWakeUp. sortMode == nil ifTrue: [ sortMode := #date ]. volList := (Array with: '[]') , directory pathParts withIndexCollect: [ : each : i | (String new: i - 1 withAll: Character space) , each ]. volListIndex := volList size. self changed: #relabel. self changed: #volumeList. + self changed: #directory. self pattern: pattern!

1 0

Jump to page: