Squeak-dev May 2015

squeak-dev@lists.squeakfoundation.org

50 participants
615 discussions

Start a nNew thread

Slider trimValue: vs trimmedValue:
by Nicolas Cellier 03 May '15

03 May '15

They sound much too similar and it seems that the first is not sent... Cleanup welcomed... Nicolas

1 0

Daily Commit Log
by commits＠source.squeak.org 02 May '15

02 May '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-May/008216.html Name: Morphic-mt.957 Ancestors: Morphic-mt.956 Allow models to trigger accept/revert changes in pluggable text morphs. Why? Provides an additional, more general way besides context menus or keyboard shortcuts. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-May/008217.html Name: MorphicTests-mt.30 Ancestors: MorphicTests-mt.29 Tests added for pluggable text morphs. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-May/008218.html Name: ShoutCore-ul.48 Ancestors: ShoutCore-ul.47 SHMCClassDefinition changes: - Implemented the missing #withAllSuperclassesDo: - #withAllSuperclasses uses #withAllSuperclassesDo:, and returns an OrderedCollection with the classes in the same order as in Behavior's implementation. - Recategorized some methods. Use #withAllSuperclassesDo: instead of #withAllSuperclasses in all methods of SHParserST80. Updated TextAction >> #shoutShouldPreserve to reflect the original intention - preserve all TextAction attributes. Slightly faster SHTextStylerST80 >> #setAttributesIn:fromRanges:. Removed the now useless SHTextStylerST80 >> #shouldPreserveAttribute:. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-May/008219.html Name: Morphic-kfr.958 Ancestors: Morphic-mt.957 Couple of layout and color fixes to NewColorPickerMorph ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-May/008220.html Name: Morphic-kfr.959 Ancestors: Morphic-kfr.958 Added back drop shadow preference =============================================

1 0

Re: [squeak-dev] The Inbox: Kernel-mtf.924.mcz
by Nicolas Cellier 02 May '15

02 May '15

2015-05-02 18:27 GMT+02:00 <commits(a)source.squeak.org>: > A new version of Kernel was added to project The Inbox: > http://source.squeak.org/inbox/Kernel-mtf.924.mcz > > ==================== Summary ==================== > > Name: Kernel-mtf.924 > Author: mtf > Time: 2 May 2015, 12:26:05.675 pm > UUID: 7f688860-5202-4c0d-8ece-8723fe7317d6 > Ancestors: Kernel-nice.923 > > Copied Number >> #round: from Pharo. One of 3 methods needed to make the > Artefact pdf library work on squeak: > https://sites.google.com/site/artefactpdf/ > > =============== Diff against Kernel-nice.923 =============== > > Item was added: > + ----- Method: Float>>round: (in category 'truncation and round off') > ----- > + round: numberOfWishedDecimal > + "only leave a fixed amount of decimal" > + "10.12345 round: 2 => 10.12" > + > + | v | > + v := 10 raisedTo: numberOfWishedDecimal. > + ^ ((self * v) rounded / v) asFloat > + ! > > self assert: (Float fmax round: 2) = Float fmax. It's probably not very important for artefact, but if this method has a wider usage than artefact, then it should better be robust to overflow... > Item was added: > + ----- Method: Fraction>>round: (in category 'truncation and round off') > ----- > + round: numberOfWishedDecimal > + ^self asFloat round: numberOfWishedDecimal! > > Transforming exact arithmetic into inexact Float sounds like heresy to me ;) That's a questionable choice. Why this cult to Float would be necessary here? > Item was added: > + ----- Method: Integer>>round: (in category 'truncation and round off') > ----- > + round: numberOfWishedDecimal > + ^self! > > Item was added: > + ----- Method: Number>>round: (in category 'truncation and round off') > ----- > + round: numberOfWishedDecimal > + self subclassResponsibility! > > > If it's subclass responsibility, then it must be implemented in ScaledDecimal. This is not necessary in Pharo, because ScaledDecimal has been moved under Fraction, but it is in Squeak. I'd rather see Float implementation moved up (without the asFloat) and Float invoking super asFloat... I didn't check artefact, but I suspect that the usage is just to printShowingMaxDecimals: numberOfWishedDecimal, which would make the whole method moot. Nicolas

2 4

Unload 39Deprecated, 311Deprecated, and 45Deprecated in Trunk
by Marcel Taeumel 02 May '15

02 May '15

Hi --- We should unload all historic deprecations... and focus on what is needed for 46Deprecated (if it cannot be deleted). Best, Marcel -- View this message in context: http://forum.world.st/Unload-39Deprecated-311Deprecated-and-45Deprecated-in… Sent from the Squeak - Dev mailing list archive at Nabble.com.

5 9

The Trunk: Morphic-kfr.959.mcz
by commits＠source.squeak.org 02 May '15

02 May '15

Karl Ramberg uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kfr.959.mcz ==================== Summary ==================== Name: Morphic-kfr.959 Author: kfr Time: 2 May 2015, 10:05:29.163 pm UUID: c3010a30-ff64-574b-8497-227a9b1e75b5 Ancestors: Morphic-kfr.958 Added back drop shadow preference =============== Diff against Morphic-kfr.958 =============== Item was changed: ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') ----- setup self color: (Color white darker) ; cornerStyle: #rounded ; changeTableLayout ; hResizing: #shrinkWrap ; vResizing: #shrinkWrap ; extent: 240@240 ; addMorphBack: hsvaMorph ; addMorphBack: self newColorExpressionMorph ; addMorphBack: self newBottomRow ; layoutInset: 4 ; cellInset: 2. + Preferences menuAppearance3d + ifTrue: [self addDropShadow]. !

1 0

The Trunk: Morphic-kfr.958.mcz
by commits＠source.squeak.org 02 May '15

02 May '15

Karl Ramberg uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-kfr.958.mcz ==================== Summary ==================== Name: Morphic-kfr.958 Author: kfr Time: 2 May 2015, 7:18:54.572 pm UUID: 8235819e-0435-b142-aa1b-7676dd49a995 Ancestors: Morphic-mt.957 Couple of layout and color fixes to NewColorPickerMorph =============== Diff against Morphic-mt.957 =============== Item was changed: ----- Method: NewColorPickerMorph>>newCloseButton (in category 'initialize-release') ----- newCloseButton ^ (PluggableButtonMorph on: self getState: nil action: #delete label: #closeButtonLabel) vResizing: #spaceFill ; + hResizing: #spaceFill; yourself! Item was changed: ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') ----- setup self + color: (Color white darker) ; - color: (Color white slightlyDarker alpha: 0.88) ; cornerStyle: #rounded ; changeTableLayout ; + hResizing: #shrinkWrap ; + vResizing: #shrinkWrap ; - hResizing: #rigid ; - vResizing: #rigid ; extent: 240@240 ; addMorphBack: hsvaMorph ; addMorphBack: self newColorExpressionMorph ; addMorphBack: self newBottomRow ; layoutInset: 4 ; cellInset: 2. + ! - Preferences menuAppearance3d - ifTrue: [self addDropShadow].!

1 0

Re: [squeak-dev] The Trunk: Collections-tfel.623.mcz
by Chris Muller 02 May '15

02 May '15

I know you are making the Smalltalk code behave teh same as the primitive but did you consider making the primitive behave the same as the Smalltalk code and signal an error? I dunno, if an app is going to calculate a starting position to search a String and gets it wrong, this code will quietly produce erroneous results. Such is the type of bug that could go unnoticed for a long time. This seems like one of those things that is low-level enough that an error should be signaled.. On Fri, May 1, 2015 at 4:06 AM, <commits(a)source.squeak.org> wrote: > Tim Felgentreff uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-tfel.623.mcz > > ==================== Summary ==================== > > Name: Collections-tfel.623 > Author: tfel > Time: 1 May 2015, 11:06:35.625 am > UUID: baf2902d-52b9-2442-a513-8a5a6ff0ce30 > Ancestors: Collections-nice.622 > > fix fallback code for ByteString>>findSubstring:in:startingAt:matchTable: when passing a starting index <= 0 > > =============== Diff against Collections-nice.622 =============== > > Item was changed: > ----- Method: ByteString>>findSubstring:in:startingAt:matchTable: (in category 'comparing') ----- > findSubstring: key in: body startingAt: start matchTable: matchTable > "Answer the index in the string body at which the substring key first occurs, at or beyond start. The match is determined using matchTable, which can be used to effect, eg, case-insensitive matches. If no match is found, zero will be returned. > > The algorithm below is not optimum -- it is intended to be translated to C which will go so fast that it wont matter." > | index | > <primitive: 'primitiveFindSubstring' module: 'MiscPrimitivePlugin'> > <var: #key declareC: 'unsigned char *key'> > <var: #body declareC: 'unsigned char *body'> > <var: #matchTable declareC: 'unsigned char *matchTable'> > > key size = 0 ifTrue: [^ 0]. > + (start max: 1) to: body size - key size + 1 do: > - start to: body size - key size + 1 do: > [:startIndex | > index := 1. > [(matchTable at: (body at: startIndex+index-1) asciiValue + 1) > = (matchTable at: (key at: index) asciiValue + 1)] > whileTrue: > [index = key size ifTrue: [^ startIndex]. > index := index+1]]. > ^ 0 > " > ' ' findSubstring: 'abc' in: 'abcdefabcd' startingAt: 1 matchTable: CaseSensitiveOrder 1 > ' ' findSubstring: 'abc' in: 'abcdefabcd' startingAt: 2 matchTable: CaseSensitiveOrder 7 > ' ' findSubstring: 'abc' in: 'abcdefabcd' startingAt: 8 matchTable: CaseSensitiveOrder 0 > ' ' findSubstring: 'abc' in: 'abcdefABcd' startingAt: 2 matchTable: CaseSensitiveOrder 0 > ' ' findSubstring: 'abc' in: 'abcdefABcd' startingAt: 2 matchTable: CaseInsensitiveOrder 7 > "! > >

5 6

The Inbox: KernelTests-mtf.294.mcz
by commits＠source.squeak.org 02 May '15

02 May '15

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-mtf.294.mcz ==================== Summary ==================== Name: KernelTests-mtf.294 Author: mtf Time: 2 May 2015, 12:38:13.849 pm UUID: dab760b9-5993-4b22-8b98-855fe72d8117 Ancestors: KernelTests-nice.293 Copied Number >> #round: from Pharo. One of 3 methods needed to make the Artefact pdf library work on squeak: https://sites.google.com/site/artefactpdf/ =============== Diff against KernelTests-nice.293 =============== Item was added: + ----- Method: FloatTest>>testRounding (in category 'tests - rounding') ----- + testRounding + " + self debug: #testRounding + " + + self assert: (10.1234 round: 2) = 10.12. + self assert: (10.1234 round: 0) = 10! Item was added: + ----- Method: FractionTest>>testRounding (in category 'tests - rounding') ----- + testRounding + " + self debug: #testRounding + " + + self assert: ((6/90) round: 2) equals: 0.07! Item was added: + ----- Method: IntegerTest>>testRounding (in category 'test - rounding') ----- + testRounding + " + self debug: #testRounding + " + + self assert: (5 round: 2) equals: 5!

1 0

The Inbox: Kernel-mtf.924.mcz
by commits＠source.squeak.org 02 May '15

02 May '15

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-mtf.924.mcz ==================== Summary ==================== Name: Kernel-mtf.924 Author: mtf Time: 2 May 2015, 12:26:05.675 pm UUID: 7f688860-5202-4c0d-8ece-8723fe7317d6 Ancestors: Kernel-nice.923 Copied Number >> #round: from Pharo. One of 3 methods needed to make the Artefact pdf library work on squeak: https://sites.google.com/site/artefactpdf/ =============== Diff against Kernel-nice.923 =============== Item was added: + ----- Method: Float>>round: (in category 'truncation and round off') ----- + round: numberOfWishedDecimal + "only leave a fixed amount of decimal" + "10.12345 round: 2 => 10.12" + + | v | + v := 10 raisedTo: numberOfWishedDecimal. + ^ ((self * v) rounded / v) asFloat + ! Item was added: + ----- Method: Fraction>>round: (in category 'truncation and round off') ----- + round: numberOfWishedDecimal + ^self asFloat round: numberOfWishedDecimal! Item was added: + ----- Method: Integer>>round: (in category 'truncation and round off') ----- + round: numberOfWishedDecimal + ^self! Item was added: + ----- Method: Number>>round: (in category 'truncation and round off') ----- + round: numberOfWishedDecimal + self subclassResponsibility!

1 0

The Trunk: ShoutCore-ul.48.mcz
by commits＠source.squeak.org 02 May '15

02 May '15

Levente Uzonyi uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-ul.48.mcz ==================== Summary ==================== Name: ShoutCore-ul.48 Author: ul Time: 2 May 2015, 1:52:29.292 pm UUID: 5ad6f857-2c78-4d6d-8dce-ce8ff7d837c5 Ancestors: ShoutCore-ul.47 SHMCClassDefinition changes: - Implemented the missing #withAllSuperclassesDo: - #withAllSuperclasses uses #withAllSuperclassesDo:, and returns an OrderedCollection with the classes in the same order as in Behavior's implementation. - Recategorized some methods. Use #withAllSuperclassesDo: instead of #withAllSuperclasses in all methods of SHParserST80. Updated TextAction >> #shoutShouldPreserve to reflect the original intention - preserve all TextAction attributes. Slightly faster SHTextStylerST80 >> #setAttributesIn:fromRanges:. Removed the now useless SHTextStylerST80 >> #shouldPreserveAttribute:. =============== Diff against ShoutCore-ul.47 =============== Item was changed: + ----- Method: SHMCClassDefinition>>allInstVarNames (in category 'act like a class') ----- - ----- Method: SHMCClassDefinition>>allInstVarNames (in category 'accessing') ----- allInstVarNames | superclassOrDef answer classOrDef instVars| answer := meta ifTrue:[classDefinition classInstVarNames asArray] ifFalse:[ classDefinition instVarNames asArray]. classOrDef := classDefinition. [superclassOrDef := (classOrDef isKindOf: MCClassDefinition) ifTrue:[ |s| s := classOrDef superclassName. items detect: [:ea | ea isClassDefinition and: [ea className = s]] ifNone: [Smalltalk at: s asSymbol ifAbsent:[nil]]] ifFalse:[ | sc | sc := classOrDef superclass. sc ifNotNil:[ items detect: [:ea | ea isClassDefinition and: [ea className = sc name asString]] ifNone: [sc] ]]. superclassOrDef isNil ] whileFalse:[ instVars := (superclassOrDef isKindOf: MCClassDefinition) ifTrue:[ meta ifTrue:[superclassOrDef classInstVarNames] ifFalse:[superclassOrDef instVarNames]] ifFalse:["real" meta ifTrue:[superclassOrDef theNonMetaClass class instVarNames] ifFalse:[superclassOrDef theNonMetaClass instVarNames]]. answer := answer, instVars. classOrDef := superclassOrDef]. ^answer! Item was changed: + ----- Method: SHMCClassDefinition>>shoutParserClass (in category 'act like a class') ----- - ----- Method: SHMCClassDefinition>>shoutParserClass (in category 'accessing') ----- shoutParserClass "Answer the parser class" ^SHParserST80! Item was changed: + ----- Method: SHMCClassDefinition>>withAllSuperclasses (in category 'act like a class') ----- - ----- Method: SHMCClassDefinition>>withAllSuperclasses (in category 'accessing') ----- withAllSuperclasses + + | result | + result := OrderedCollection new. + self withAllSuperclassesDo: [ :each | result addFirst: each ]. + ^result! - | superclassOrDef answer classOrDef | - - answer := Array with: self. - classOrDef := classDefinition. - [superclassOrDef := (classOrDef isKindOf: MCClassDefinition) - ifTrue:[ |s| - s := classOrDef superclassName. - items - detect: [:ea | ea isClassDefinition and: [ea className = s]] - ifNone: [Smalltalk at: s asSymbol ifAbsent:[nil]]] - ifFalse:[ | sc | - sc := classOrDef superclass. - sc ifNotNil:[ - items - detect: [:ea | ea isClassDefinition and: [ea className = sc name asString]] - ifNone: [sc] ]]. - superclassOrDef isNil - ] whileFalse:[ - answer := answer, (Array with: superclassOrDef). - classOrDef := superclassOrDef]. - ^answer! Item was added: + ----- Method: SHMCClassDefinition>>withAllSuperclassesDo: (in category 'act like a class') ----- + withAllSuperclassesDo: aBlock + + | superclassOrDef classOrDef | + aBlock value: self. + classOrDef := classDefinition. + [ + superclassOrDef := (classOrDef isKindOf: MCClassDefinition) + ifTrue: [ + | superclassName | + superclassName := classOrDef superclassName. + items + detect: [ :each | + each isClassDefinition and: [ + each className = superclassName ] ] + ifNone: [ Smalltalk classNamed: superclassName ] ] + ifFalse: [ + classOrDef superclass ifNotNil: [ :superclass | + | superclassName | + superclassName := superclass name asString. + items + detect: [ :each | + each isClassDefinition and: [ + each className = superclassName ] ] + ifNone: [ superclass ] ] ]. + superclassOrDef isNil ] + whileFalse: [ + aBlock value: superclassOrDef. + classOrDef := superclassOrDef ]! Item was changed: ----- Method: SHParserST80>>resolvePartial: (in category 'identifier testing') ----- resolvePartial: aString "check if any identifier begins with aString" (#('self' 'super' 'true' 'false' 'nil' 'thisContext') anySatisfy: [:each | each beginsWith: aString]) ifTrue: [^#incompleteIdentifier]. (self isIncompleteBlockTempName: aString) ifTrue: [^#incompleteIdentifier]. (self isIncompleteBlockArgName: aString) ifTrue: [^#incompleteIdentifier]. (self isIncompleteMethodTempName: aString) ifTrue: [^#incompleteIdentifier]. (self isIncompleteMethodArgName: aString) ifTrue: [^#incompleteIdentifier]. (instanceVariables anySatisfy: [:each | each beginsWith: aString]) ifTrue: [^#incompleteIdentifier]. workspace ifNotNil: [(workspace hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]. classOrMetaClass ifNotNil: [ + classOrMetaClass theNonMetaClass withAllSuperclassesDo: [:c | - classOrMetaClass theNonMetaClass withAllSuperclasses do: [:c | (c classPool hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]. c sharedPools do: [:p | (p hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]. (c environment hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]] ifNil: [(environment hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]. ^#undefinedIdentifier! Item was changed: ----- Method: SHParserST80>>resolvePartialPragmaArgument: (in category 'identifier testing') ----- resolvePartialPragmaArgument: aString "check if any valid pragma argument begins with aString" (#('true' 'false' 'nil') anySatisfy: [:each | each beginsWith: aString]) ifTrue: [^#incompleteIdentifier]. "should really check that a matching binding is for a Class?" classOrMetaClass ifNotNil: [ + classOrMetaClass theNonMetaClass withAllSuperclassesDo: [:c | - classOrMetaClass theNonMetaClass withAllSuperclasses do: [:c | (c environment hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]] ifNil: [(environment hasBindingThatBeginsWith: aString) ifTrue: [^#incompleteIdentifier]]. ^#undefinedIdentifier! Item was changed: ----- Method: SHParserST80>>resolvePragmaArgument: (in category 'identifier testing') ----- resolvePragmaArgument: aString (#('true' 'false' 'nil') includes: aString) ifTrue: [^aString asSymbol]. "should really check that global is a class?" (Symbol lookup: aString) ifNotNil: [:sym | classOrMetaClass ifNotNil: [ + classOrMetaClass theNonMetaClass withAllSuperclassesDo: [:c | - classOrMetaClass theNonMetaClass withAllSuperclasses do: [:c | (c environment bindingOf: sym) ifNotNil: [^#globalVar]]] ifNil: [(environment bindingOf: sym) ifNotNil: [^#globalVar]]]. ^self resolvePartialPragmaArgument: aString! Item was changed: ----- Method: SHTextStylerST80>>setAttributesIn:fromRanges: (in category 'private') ----- setAttributesIn: aText fromRanges: ranges | charAttr defaultAttr attr newRuns newValues lastAttr oldRuns lastCount | oldRuns := aText runs. defaultAttr := self attributesFor: #default. + charAttr := Array new: aText size withAll: defaultAttr. + ranges do: [ :range | + (self attributesFor: range type) ifNotNil: [ :attribute | + charAttr from: range start to: range end put: attribute ] ]. + newRuns := OrderedCollection new: ranges size * 2 + 1. + newValues := OrderedCollection new: ranges size * 2 + 1. + lastAttr := nil. + lastCount := 0. + 1 to: charAttr size do: [ :i | + (attr := charAttr at: i) == lastAttr - charAttr := Array new: aText size. - 1 to: charAttr size do: [:i | charAttr at: i put: defaultAttr]. - ranges do: [:range | - (attr := self attributesFor: range type) == nil - ifFalse:[ range start to: range end do: [:i | charAttr at: i put: attr]]]. - newRuns := OrderedCollection new: charAttr size // 10. - newValues := OrderedCollection new: charAttr size // 10. - 1 to: charAttr size do: [:i | - attr := charAttr at: i. - i = 1 ifTrue: [ + lastCount := lastCount + 1. + newRuns at: newRuns size put: lastCount ] + ifFalse: [ + newRuns addLast: 1. - newRuns add: 1. lastCount := 1. + lastAttr := newValues addLast: attr ] ]. - lastAttr := newValues add: attr] - ifFalse:[ - attr == lastAttr - ifTrue: [ - lastCount := lastCount + 1. - newRuns at: newRuns size put: lastCount] - ifFalse: [ - newRuns add: 1. - lastCount := 1. - lastAttr := newValues add: attr]]]. aText runs: (RunArray runs: newRuns values: newValues). oldRuns withStartStopAndValueDo:[:start :stop :attribs| + (attribs anySatisfy: [ :each | each shoutShouldPreserve ]) ifTrue: [ + attribs do: [ :each | aText addAttribute: each from: start to: stop ] ] ]. - (attribs anySatisfy: [:each | self shouldPreserveAttribute: each]) - ifTrue: [ - attribs do: [:eachAttrib | aText addAttribute: eachAttrib from: start to: stop]]]. ! Item was removed: - ----- Method: SHTextStylerST80>>shouldPreserveAttribute: (in category 'private') ----- - shouldPreserveAttribute: aTextAttribute - "Answer true if Shout should preserve ALL the attributes in the same run as the argument, - false otherwise" - ^aTextAttribute shoutShouldPreserve! Item was changed: ----- Method: TextAction>>shoutShouldPreserve (in category '*ShoutCore') ----- shoutShouldPreserve + ^true! - ^self class == TextAction!

1 0

← Newer
1
...
55
56
57
58
59
60
61
62
Older →

Jump to page: