Squeak-dev February 2016

squeak-dev@lists.squeakfoundation.org

28 participants
207 discussions

DamageRecorder>recordInvalidRect: one truncate too far?
by tim Rowledge 04 Feb '16

04 Feb '16

I’m having *all sorts* of fun working on a TransformationMorph with optimised displaying of stuff scaled ½, 1 or 2X. One of the common irritations is occasional invalid rectangle misses so that gribblys are left on-screen. There are assorted places where i see an ‘expandBy: 1’ apparently thrown in to try to compensate for something. I think perhaps the issue is actually in DamageRecorder>recordInvalidRect: where we see several places with code like 'origin truncated corner: corner truncated’ and maybe, just maybe, it ought to be ‘origin truncated corner: corner ceiling’ ? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: DCBP: Detonate Chair on Bad Password

2 8

Daily Commit Log
by commits＠source.squeak.org 03 Feb '16

03 Feb '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-February/009374.h… Name: Protocols-mt.54 Ancestors: Protocols-mt.53 Adds menu callback for object explorer. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009375.h… Name: Tools-mt.669 Ancestors: Tools-mt.668 Fixes regression in pointer explorer. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009376.h… Name: Tools-mt.670 Ancestors: Tools-mt.669 Stop using the context menu of an inspector in the object explorer. Now the object explorer has its own working callbacks. This fixes a bug where it was difficult (if not impossible) to invoke menu (of keyboard shortcut) operations on objects in the tree if the enclosing parent was volatile. This also removes the annoying pop-up or debugger, which used to appear in those cases. =============================================

1 0

The Trunk: Tools-mt.670.mcz
by commits＠source.squeak.org 03 Feb '16

03 Feb '16

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.670.mcz ==================== Summary ==================== Name: Tools-mt.670 Author: mt Time: 3 February 2016, 9:06:55.449922 pm UUID: 4c92b664-5e2f-422e-a5a1-35241e64ad52 Ancestors: Tools-mt.669 Stop using the context menu of an inspector in the object explorer. Now the object explorer has its own working callbacks. This fixes a bug where it was difficult (if not impossible) to invoke menu (of keyboard shortcut) operations on objects in the tree if the enclosing parent was volatile. This also removes the annoying pop-up or debugger, which used to appear in those cases. =============== Diff against Tools-mt.669 =============== Item was added: + ----- Method: ObjectExplorer>>browseClassRefs (in category 'menus - actions') ----- + browseClassRefs + + (self selectedClass notNil and: [self selectedClass isTrait not]) + ifTrue: [self systemNavigation browseAllCallsOnClass: self selectedClass theNonMetaClass].! Item was added: + ----- Method: ObjectExplorer>>browseFull (in category 'menus - actions') ----- + browseFull + + ^ self selectedClass ifNotNil: [:cls | ToolSet browseClass: cls]! Item was added: + ----- Method: ObjectExplorer>>browseVariableAssignments (in category 'menus - actions') ----- + browseVariableAssignments + + (self selectedClass notNil and: [self selectedClass isTrait not]) + ifTrue: [self systemNavigation browseVariableAssignments: self selectedClass].! Item was added: + ----- Method: ObjectExplorer>>browseVariableReferences (in category 'menus - actions') ----- + browseVariableReferences + + (self selectedClass notNil and: [self selectedClass isTrait not]) + ifTrue: [self systemNavigation browseVariableReferences: self selectedClass].! Item was added: + ----- Method: ObjectExplorer>>chasePointersForSelection (in category 'menus - actions') ----- + chasePointersForSelection + + self flag: #tooMany. "mt: Note that we might want to ignore references caused by this tool." + self object chasePointers.! Item was added: + ----- Method: ObjectExplorer>>classHierarchy (in category 'menus - actions') ----- + classHierarchy + "Create and schedule a class list browser on the receiver's hierarchy." + + self systemNavigation + spawnHierarchyForClass: self selectedClass + selector: nil + ! Item was added: + ----- Method: ObjectExplorer>>copyName (in category 'menus - actions') ----- + copyName + "Copy the name of the current variable, so the user can paste it into the window below and work with is." + + Clipboard clipboardText: self currentSelection key. ! Item was added: + ----- Method: ObjectExplorer>>defsOfSelection (in category 'menus - actions') ----- + defsOfSelection + "Open a browser on all defining references to the selected instance variable, if that's what currently selected. " + + self selectedParentClass ifNil: [^ self changed: #flash]. + self selectedParentClass isVariable ifTrue: [^ self changed: #flash]. + self selectedInstVarName ifNil: [^ self changed: #flash]. + + self systemNavigation browseAllStoresInto: self selectedInstVarName from: self selectedParentClass.! Item was added: + ----- Method: ObjectExplorer>>explorePointersForSelection (in category 'menus - actions') ----- + explorePointersForSelection + + self flag: #tooMany. "mt: Note that we might want to ignore references caused by this tool." + self object explorePointers.! Item was added: + ----- Method: ObjectExplorer>>exploreSelection (in category 'menus - actions') ----- + exploreSelection + + self object explore.! Item was changed: ----- Method: ObjectExplorer>>explorerKey:from:event: (in category 'menus') ----- explorerKey: aChar from: view event: event event anyModifierKeyPressed ifFalse: [^ false]. + self object ifNotNil: [ + aChar == $i ifTrue: [self inspectSelection. ^ true]. + aChar == $I ifTrue: [self exploreSelection. ^ true]. - currentSelection ifNotNil: [ - self updateInspectorForSelection ifFalse: [^ true]. + aChar == $b ifTrue: [self browseFull. ^ true]. + aChar == $h ifTrue: [self classHierarchy. ^ true]. + aChar == $c ifTrue: [self copyName. ^ true]. + aChar == $p ifTrue: [self browseFullProtocol. ^ true]. + aChar == $N ifTrue: [self browseClassRefs. ^ true]. + aChar == $v ifTrue: [self viewerForValue. ^ true]]. - aChar == $i ifTrue: [self inspector inspectSelection. ^ true]. - aChar == $I ifTrue: [self inspector exploreSelection. ^ true]. - aChar == $b ifTrue: [self inspector browseMethodFull. ^ true]. - aChar == $h ifTrue: [self inspector classHierarchy. ^ true]. - aChar == $c ifTrue: [Clipboard clipboardText: self currentSelection key. ^ true]. - aChar == $p ifTrue: [self inspector browseFullProtocol. ^ true]. - aChar == $N ifTrue: [self inspector browseClassRefs. ^ true]. - aChar == $t ifTrue: [self inspector tearOffTile. ^ true]. - aChar == $v ifTrue: [self inspector viewerForValue. ^ true]]. - ^ false! Item was changed: ----- Method: ObjectExplorer>>genericMenu: (in category 'menus') ----- genericMenu: aMenu - "Borrow a menu from my inspector" + ^ self menu: aMenu for: #(treeListMenu treeListMenuShifted:)! - currentSelection - ifNil: [ - aMenu - add: '*nothing selected*' - target: self - selector: #yourself] - ifNotNil: [ - self updateInspectorForSelection ifFalse: [^ aMenu]. - aMenu defaultTarget: self inspector. - self inspector fieldListMenu: aMenu. - - aMenu addLine; - add: 'monitor changes' - target: self - selector: #monitor: - argument: currentSelection]. - monitorList isEmptyOrNil - ifFalse: [aMenu addLine; - add: 'stop monitoring all' - target: self - selector: #stopMonitoring]. - ^ aMenu! Item was added: + ----- Method: ObjectExplorer>>inspectBasic (in category 'menus - actions') ----- + inspectBasic + "Bring up a non-special inspector" + + self object basicInspect.! Item was added: + ----- Method: ObjectExplorer>>inspectSelection (in category 'menus - actions') ----- + inspectSelection + + self object inspect.! Item was added: + ----- Method: ObjectExplorer>>mainTreeListMenu: (in category 'menus') ----- + mainTreeListMenu: aMenu + <treeListMenu> + + aMenu addStayUpItemSpecial. + + aMenu addList: #( + ('inspect (i)' inspectSelection) + ('explore (I)' exploreSelection) + - + ('method refs to this inst var' referencesToSelection) + ('methods storing into this inst var' defsOfSelection) + ('objects pointing to this value' objectReferencesToSelection) + ('chase pointers' chasePointersForSelection) + ('explore pointers' explorePointersForSelection) + - + ('browse full (b)' browseFull) + ('browse class' browseClass) + ('browse hierarchy (h)' classHierarchy) + ('browse protocol (p)' browseFullProtocol) + - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) + ('class refs (N)' browseClassRefs) + - + ('copy name (c)' copyName) + ('basic inspect' inspectBasic)). + + Smalltalk isMorphic ifTrue: [ + aMenu addList: #( + - + ('viewer for this value (v)' viewerForValue))]. + + aMenu addList: #( + - + ('monitor changes' monitorSelection)). + + monitorList isEmptyOrNil ifFalse: [ + aMenu addList: #( + ('stop monitoring all' stopMonitoring))]. + + ^ aMenu! Item was added: + ----- Method: ObjectExplorer>>monitorSelection (in category 'menus - actions') ----- + monitorSelection + + self monitor: self currentSelection.! Item was added: + ----- Method: ObjectExplorer>>objectReferencesToSelection (in category 'menus - actions') ----- + objectReferencesToSelection + "Open a list inspector on all the objects that point to the value of the selected instance variable, if any. " + + self object ifNil: [^ self changed: #flash]. + + self systemNavigation + browseAllObjectReferencesTo: self object + except: {self currentSelection. self currentParent. self parentObject} + ifNone: [:obj | self changed: #flash].! Item was added: + ----- Method: ObjectExplorer>>referencesToSelection (in category 'menus - actions') ----- + referencesToSelection + "Open a browser on all references to the selected instance variable, if that's what currently selected." + + self selectedParentClass ifNil: [^ self changed: #flash]. + self selectedParentClass isVariable ifTrue: [^ self changed: #flash]. + self selectedInstVarName ifNil: [^ self changed: #flash]. + + self systemNavigation browseAllAccessesTo: self selectedInstVarName from: self selectedParentClass.! Item was added: + ----- Method: ObjectExplorer>>selectedInstVarName (in category 'accessing - other') ----- + selectedInstVarName + + self parentObject ifNil: [^ nil]. + (self parentObject class allInstVarNames includes: self currentSelection key) + ifTrue: [^ self currentSelection key asSymbol]. + ^ nil! Item was added: + ----- Method: ObjectExplorer>>selectedParentClass (in category 'accessing - other') ----- + selectedParentClass + + ^ self parentObject ifNotNil: [:o | o class]! Item was removed: - ----- Method: ObjectExplorer>>selector (in category 'accessing - other') ----- - selector - - self isThisEverCalled. - self flag: #deprecated. "mt: Who uses this? And why?" - self parentObject ifNil: [^ nil]. - (self parentObject class allInstVarNames includes: self currentSelection key) - ifTrue: [^ self currentSelection key asSymbol]. - ^ nil! Item was removed: - ----- Method: ObjectExplorer>>updateInspectorForSelection (in category 'accessing - other') ----- - updateInspectorForSelection - "Reuse the inspector for some callbacks." - - self inspector inspect: (self parentObject ifNil: [self object]). - - self parentObject - ifNil: [self inspector toggleIndex: 1. "self"] - ifNotNil: [ - self inspector toggleIndex: (self inspector fieldList indexOf: self currentSelection key)]. - - self inspector selection == self object - ifTrue: [ - ^ true] - ifFalse: [ - self inform: 'Object has changed. Please refresh\before invoking the context menu.' withCRs. - ^ false].! Item was added: + ----- Method: ObjectExplorer>>viewerForValue (in category 'menus - actions') ----- + viewerForValue + + self object beViewed.!

1 0

The Trunk: Tools-mt.669.mcz
by commits＠source.squeak.org 03 Feb '16

03 Feb '16

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.669.mcz ==================== Summary ==================== Name: Tools-mt.669 Author: mt Time: 3 February 2016, 9:03:12.626922 pm UUID: 17c9ee50-3551-4758-b80a-85670df52561 Ancestors: Tools-mt.668 Fixes regression in pointer explorer. =============== Diff against Tools-mt.668 =============== Item was changed: ----- Method: PointerExplorerWrapper>>contents (in category 'accessing') ----- contents "Return the wrappers with the objects holding references to item. Eldest objects come first, weak only referencers are at the end and have parentheses around their identity hash." | objects weakOnlyReferences | + objects := self object inboundPointersExcluding: { self. self item. model }. - objects := item inboundPointersExcluding: { self. model }. weakOnlyReferences := OrderedCollection new. objects removeAllSuchThat: [ :each | each class == self class or: [ each class == PointerExplorer or: [ (each class == MethodContext and: [ each receiver class == PointerExplorer ] ) + or: [ (each pointsOnlyWeaklyTo: self object) - or: [ (each pointsOnlyWeaklyTo: item) ifTrue: [ weakOnlyReferences add: each. true ] ifFalse: [ false ] ] ] ] ]. ^(objects replace: [ :each | + self class with: each name: each identityHash asString model: self object ]) - self class with: each name: each identityHash asString model: item ]) addAll: (weakOnlyReferences replace: [ :each | + (self class with: each name: '(', each identityHash asString, ')' model: self object) - (self class with: each name: '(', each identityHash asString, ')' model: item) weakOnly: true; yourself ]); yourself!

1 0

The Trunk: Protocols-mt.54.mcz
by commits＠source.squeak.org 03 Feb '16

03 Feb '16

Marcel Taeumel uploaded a new version of Protocols to project The Trunk: http://source.squeak.org/trunk/Protocols-mt.54.mcz ==================== Summary ==================== Name: Protocols-mt.54 Author: mt Time: 3 February 2016, 9:02:00.563922 pm UUID: d17a73e0-178a-45c8-a506-72fb28b86696 Ancestors: Protocols-mt.53 Adds menu callback for object explorer. =============== Diff against Protocols-mt.53 =============== Item was added: + ----- Method: ObjectExplorer>>browseFullProtocol (in category '*Protocols-Tools') ----- + browseFullProtocol + "Open up a protocol-category browser on the value of the receiver's current selection. If in mvc, an old-style protocol browser is opened instead." + + Smalltalk isMorphic + ifFalse: [ProtocolBrowser openSubProtocolForClass: self selectedClass] + ifTrue: [InstanceBrowser new openOnObject: self object showingSelector: nil].!

1 0

Re: [squeak-dev] The Trunk: System-eem.793.mcz
by David T. Lewis 03 Feb '16

03 Feb '16

Oops, this change locks up the image on a non-Cog VM. If we are going to rely on a numbered VM parameter for this, then we should either change vmParameterAt: to answer nil on failure, or use an exception handler to protect for the case of someone referring to a parameter at 42 when the size of the VM parameter array might be something less than that. I think that answering nil for vmParamterAt: on primitive failure would be a reasonable change. As an aside, I also think it might be better overall to use an an explicit named primitive for something like this, because that would avoid the need for VM implementors to coordinate their understanding of the size and meaning of the VM parameter array. Dave On Tue, Feb 02, 2016 at 07:48:39PM +0000, commits(a)source.squeak.org wrote: > Eliot Miranda uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-eem.793.mcz > > ==================== Summary ==================== > > Name: System-eem.793 > Author: eem > Time: 2 February 2016, 11:48:18.26222 am > UUID: 5d65cf5d-0564-4825-90d0-569661e6ae3e > Ancestors: System-dtl.792 > > Implement a reasonable lowSpaceLimit for the Stack and Cog VMs. David, this /should/ be back-ported to 4.6. > > =============== Diff against System-dtl.792 =============== > > Item was changed: > ----- Method: SmalltalkImage>>lowSpaceThreshold (in category 'memory space') ----- > lowSpaceThreshold > + "Answer the low space threshold. When the amount of free memory (after garbage collection) > + falls below this limit, the system is in serious danger of completely exhausting memory and > + crashing. This limit should be made high enough to allow the user open a debugger to diagnose > + a problem or to save the image. In a stack-based VM such as Cog contexts for activations in > + the stack zone will have to be created as the debugger opens, requiring additional headroom." > - "Return the low space threshold. When the amount of free memory (after garbage collection) falls below this limit, the system is in serious danger of completely exhausting memory and crashing. This limit should be made high enough to allow the user open a debugger to diagnose a problem or to save the image." > > + | slotsForDebugger slotsForContextsOnStackPages | > + slotsForDebugger := 65536. "Arbitrary guess" > + slotsForContextsOnStackPages := > + (self vmParameterAt: 42) > + ifNil: [0] > + ifNotNil: > + [:numStackPages| | headerSize numActivationsPerPage maxContextSize | > + numActivationsPerPage := 40. "Design goal of the Cog VM" > + headerSize := 2. "64-bytes for Spur" > + maxContextSize := MethodContext instSize + CompiledMethod fullFrameSize + headerSize. > + numStackPages * numActivationsPerPage * maxContextSize]. > + ^slotsForDebugger + slotsForContextsOnStackPages * self wordSize! > - thisContext isPseudoContext > - ifTrue: [^ 400000 "Enough for JIT compiler"] > - ifFalse: [^ 200000 "Enough for interpreter"]! >

1 0

Daily Commit Log
by commits＠source.squeak.org 02 Feb '16

02 Feb '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-February/009288.h… Name: Kernel-dtl.981 Ancestors: Kernel-eem.980 InputSensor removal step 1. Move instance methods to EventSensor, eliminate super calls, resolve primitive fallbacks, recategorize. Preserve original method stamps where possible. Class variables and system startup/shutdown to be addressed next. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009289.h… Name: Kernel-dtl.982 Ancestors: Kernel-dtl.981 Update preferences to use EventSensor rather than InputSensor. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009290.h… Name: Kernel-dtl.983 Ancestors: Kernel-dtl.982 InputSensor removal. Consolidate class methods. Remove InputSensor from that system startup list, and add EventSensor. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009291.h… Name: Kernel-dtl.984 Ancestors: Kernel-dtl.983 Remove InputSensor. EventSensor replaces InputSensor for both Morphic and MVC. Note: requires update to SmalltalkImage class initialization methods in package System. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009292.h… Name: Kernel-dtl.985 Ancestors: Kernel-dtl.984 EventSensor replaces InputSensor, update class and method comments. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009293.h… Name: System-dtl.792 Ancestors: System-dtl.791 Remove last references to InputSensor, which has bee replaced by EventSensor ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009294.h… Name: Kernel-eem.986 Ancestors: Kernel-dtl.985 Process preemption should not cause a yield. I'd forgotten to swet this in the Spur bootstrap. Do so in processorScheduler's startUp, and eliminate the unnecessary reinstallation of low-space and background processes if only snapshotting. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009295.h… Name: System-eem.793 Ancestors: System-dtl.792 Implement a reasonable lowSpaceLimit for the Stack and Cog VMs. David, this /should/ be back-ported to 4.6. =============================================

1 0

The Trunk: System-eem.793.mcz
by commits＠source.squeak.org 02 Feb '16

02 Feb '16

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.793.mcz ==================== Summary ==================== Name: System-eem.793 Author: eem Time: 2 February 2016, 11:48:18.26222 am UUID: 5d65cf5d-0564-4825-90d0-569661e6ae3e Ancestors: System-dtl.792 Implement a reasonable lowSpaceLimit for the Stack and Cog VMs. David, this /should/ be back-ported to 4.6. =============== Diff against System-dtl.792 =============== Item was changed: ----- Method: SmalltalkImage>>lowSpaceThreshold (in category 'memory space') ----- lowSpaceThreshold + "Answer the low space threshold. When the amount of free memory (after garbage collection) + falls below this limit, the system is in serious danger of completely exhausting memory and + crashing. This limit should be made high enough to allow the user open a debugger to diagnose + a problem or to save the image. In a stack-based VM such as Cog contexts for activations in + the stack zone will have to be created as the debugger opens, requiring additional headroom." - "Return the low space threshold. When the amount of free memory (after garbage collection) falls below this limit, the system is in serious danger of completely exhausting memory and crashing. This limit should be made high enough to allow the user open a debugger to diagnose a problem or to save the image." + | slotsForDebugger slotsForContextsOnStackPages | + slotsForDebugger := 65536. "Arbitrary guess" + slotsForContextsOnStackPages := + (self vmParameterAt: 42) + ifNil: [0] + ifNotNil: + [:numStackPages| | headerSize numActivationsPerPage maxContextSize | + numActivationsPerPage := 40. "Design goal of the Cog VM" + headerSize := 2. "64-bytes for Spur" + maxContextSize := MethodContext instSize + CompiledMethod fullFrameSize + headerSize. + numStackPages * numActivationsPerPage * maxContextSize]. + ^slotsForDebugger + slotsForContextsOnStackPages * self wordSize! - thisContext isPseudoContext - ifTrue: [^ 400000 "Enough for JIT compiler"] - ifFalse: [^ 200000 "Enough for interpreter"]!

1 0

The Trunk: Kernel-eem.986.mcz
by commits＠source.squeak.org 02 Feb '16

02 Feb '16

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.986.mcz ==================== Summary ==================== Name: Kernel-eem.986 Author: eem Time: 2 February 2016, 11:13:09.449248 am UUID: 3f530429-e326-41a8-b43b-8d18d32b01fc Ancestors: Kernel-dtl.985 Process preemption should not cause a yield. I'd forgotten to swet this in the Spur bootstrap. Do so in processorScheduler's startUp, and eliminate the unnecessary reinstallation of low-space and background processes if only snapshotting. =============== Diff against Kernel-dtl.985 =============== Item was removed: - ----- Method: ProcessorScheduler class>>startUp (in category 'background process') ----- - startUp - "Install a background process of the lowest possible priority that is always runnable." - "Details: The virtual machine requires that there is aways some runnable process that can be scheduled; this background process ensures that this is the case." - - Smalltalk installLowSpaceWatcher. - BackgroundProcess == nil ifFalse: [BackgroundProcess terminate]. - BackgroundProcess := [self idleProcess] newProcess. - BackgroundProcess priority: SystemRockBottomPriority. - BackgroundProcess resume. - ! Item was added: + ----- Method: ProcessorScheduler class>>startUp: (in category 'background process') ----- + startUp: resuming + "Install a background process of the lowest possible priority that is always runnable." + "Details: The virtual machine requires that there is aways some runnable process that + can be scheduled; this background process ensures that this is the case." + + Smalltalk processPreemptionYields ifTrue: + [Smalltalk processPreemptionYields: false]. + resuming ifTrue: + [Smalltalk installLowSpaceWatcher. + BackgroundProcess ifNotNil: + [BackgroundProcess terminate]. + (BackgroundProcess := [self idleProcess] newProcess) + priority: SystemRockBottomPriority; + resume]!

1 0

Time to Vote
by Ron Teitelbaum 02 Feb '16

02 Feb '16

Hi All, Thank you for your participation in the Squeak Oversight Board 2016 election. It is time to vote! Please check your email for a message from: Condorcet Internet Voting Service <civs(a)cs.cornell.edu> on behalf of; Ron Teitelbaum (CIVS poll supervisor) ron(a)usmedrec.com Voting is important! It is your way to show your community you support the efforts of the Board! Please find the email and vote. All the best, Ron Teitelbaum

2 2

Jump to page: