Squeak-dev June 2016

squeak-dev@lists.squeakfoundation.org

39 participants
202 discussions

The Trunk: MorphicTests-mt.33.mcz
by commits＠source.squeak.org 20 Jun '16

20 Jun '16

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.33.mcz ==================== Summary ==================== Name: MorphicTests-mt.33 Author: mt Time: 20 June 2016, 5:14:51.500796 pm UUID: 18fd6b33-66f2-d541-84a8-d8ede4a28134 Ancestors: MorphicTests-mt.32 More tests for Morphic event dispatchs. Use custom hand morph for these tests. =============== Diff against MorphicTests-mt.32 =============== Item was added: + HandMorph subclass: #HandMorphForEventTests + instanceVariableNames: 'eventsDuringCapture eventsDuringBubble eventsRejected eventsFiltered isHandling' + classVariableNames: '' + poolDictionaries: '' + category: 'MorphicTests-Events'! Item was added: + ----- Method: HandMorphForEventTests>>eventsDuringBubble (in category 'accessing') ----- + eventsDuringBubble + ^ eventsDuringBubble ifNil: [eventsDuringBubble := OrderedCollection new]! Item was added: + ----- Method: HandMorphForEventTests>>eventsDuringCapture (in category 'accessing') ----- + eventsDuringCapture + ^ eventsDuringCapture ifNil: [eventsDuringCapture := OrderedCollection new]! Item was added: + ----- Method: HandMorphForEventTests>>eventsFiltered (in category 'accessing') ----- + eventsFiltered + ^ eventsFiltered ifNil: [eventsFiltered := OrderedCollection new]! Item was added: + ----- Method: HandMorphForEventTests>>eventsRejected (in category 'accessing') ----- + eventsRejected + ^ eventsRejected ifNil: [eventsRejected := OrderedCollection new]! Item was added: + ----- Method: HandMorphForEventTests>>filterEvent:for: (in category 'event filtering') ----- + filterEvent: anEvent for: aMorphOrNil + + self eventsFiltered add: anEvent copy -> aMorphOrNil. + ^ anEvent! Item was added: + ----- Method: HandMorphForEventTests>>handleEvent: (in category 'events-processing') ----- + handleEvent: anEvent + + (isHandling == true and: [(#(mouseOver mouseMove) includes: anEvent type) not]) ifTrue: [Error signal: 'Recursive handling detected!!']. + isHandling := true. + self eventsDuringBubble add: anEvent copy. + [^ super handleEvent: anEvent] + ensure: [isHandling := false].! Item was added: + ----- Method: HandMorphForEventTests>>handleEventSilently: (in category 'events-processing') ----- + handleEventSilently: anEvent + + ^ super handleEvent: anEvent! Item was added: + ----- Method: HandMorphForEventTests>>processEvent:using: (in category 'events-processing') ----- + processEvent: anEvent using: dispatcher + + self eventsDuringCapture add: anEvent copy. + ^ super processEvent: anEvent using: dispatcher! Item was added: + ----- Method: HandMorphForEventTests>>rejectsEvent: (in category 'events-processing') ----- + rejectsEvent: anEvent + + ^ (super rejectsEvent: anEvent) + ifTrue: [self eventsRejected add: anEvent copy. true] + ifFalse: [false]! Item was added: + ----- Method: MorphicEventDispatcherTests>>test08FocusEventBubblingNoHand (in category 'tests') ----- + test08FocusEventBubblingNoHand + "If you drag something, do not bubble up to the hand." + + | m1 | + m1 := MorphForEventTests new noMouseDown. + hand grabMorph: m1. + + hand newKeyboardFocus: m1. + + self assert: (hand eventsDuringBubble noneSatisfy: [:ea | ea isKeystroke]). + self assert: (m1 eventsDuringBubble noneSatisfy: [:ea | ea isKeystroke]). + + self + shouldnt: [hand handleEventSilently: (self keystroke: $x at: 0@0)] + raise: Error. + + self assert: (hand eventsDuringBubble noneSatisfy: [:ea | ea isKeystroke]). + self assert: (m1 eventsDuringBubble anySatisfy: [:ea | ea isKeystroke]). + ! Item was added: + ----- Method: MorphicEventDispatcherTests>>test09FocusEventCapturingNoHand (in category 'tests') ----- + test09FocusEventCapturingNoHand + "Avoid duplication of capture step in hand for focus events." + + | m1 | + m1 := MorphForEventTests new noMouseDown. + hand grabMorph: m1. + + hand newKeyboardFocus: m1. + + self assert: (hand eventsDuringCapture noneSatisfy: [:ea | ea isKeystroke]). + self assert: (m1 eventsDuringCapture noneSatisfy: [:ea | ea isKeystroke]). + + hand handleEventSilently: (self keystroke: $x at: 0@0). + + self assert: (hand eventsDuringCapture noneSatisfy: [:ea | ea isKeystroke]). + self assert: (m1 eventsDuringCapture noneSatisfy: [:ea | ea isKeystroke]).! Item was changed: ----- Method: UserInputEventTests>>setUp (in category 'running') ----- setUp super setUp. + - world := (PasteUpMorph newWorldForProject: nil) extent: 300@200; viewBox: (0@0 extent: 300@200); yourself. (world instVarNamed: #worldState) instVarNamed: #canvas put: (Form extent: 300@200 depth: 32) getCanvas. + hand := HandMorphForEventTests new. + + world + removeHand: world firstHand; "the default hand" + addHand: hand.! - hand := world firstHand.! Item was added: + ----- Method: UserInputEventTests>>tearDown (in category 'running') ----- + tearDown + + hand showHardwareCursor: true. "Nasty side-effect" + super tearDown.!

1 0

The Trunk: Morphic-mt.1182.mcz
by commits＠source.squeak.org 20 Jun '16

20 Jun '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1182.mcz ==================== Summary ==================== Name: Morphic-mt.1182 Author: mt Time: 20 June 2016, 5:13:55.570796 pm UUID: 825d8e52-1878-af49-9f7a-437b23e68d8c Ancestors: Morphic-mt.1181 Moves implementation of focus event dispatching from various places into MorphicEventDispatcher. This will ensure consistency in the future because MorphicEventDispatcher encode the tree iteration with capturing and bubbling. Doing a focus event is just a shortcut into the tree. TextMorphs use that. Pop-up menus use that. Modal dialogs use that. Fixes missing coordinate transformations when capturing and bubbling for focus events. Simplify focus-related code in MenuMorph, UserDialogBoxMorph, and DockingBarMorph. At the time of writing, there seems to be no need anymore for Morph >> #handleFocusEvent:. Still, keep it for compatibility to other projects. =============== Diff against Morphic-mt.1181 =============== Item was removed: - ----- Method: DockingBarMorph>>handleFocusEvent: (in category 'events-processing') ----- - handleFocusEvent: evt - "Handle focus events. Valid menu transitions are determined based on the menu currently holding the focus after the mouse went down on one of its children." - - | result filteredEvent | - (evt isMouse and:[ evt isMouseUp ]) ifTrue:[^ evt]. - - result := self processEvent: evt. - filteredEvent := result == #rejected ifTrue: [evt] ifFalse: [result]. - - "Need to handle keyboard input if we have the focus." - filteredEvent isKeyboard ifTrue: [^ super handleFocusEvent: filteredEvent]. - - "We need to handle button clicks outside and transitions to local popUps so throw away everything else" - (filteredEvent isMouseOver or:[filteredEvent isMouse not]) ifTrue:[^filteredEvent]. - "What remains are mouse buttons and moves" - filteredEvent isMove ifFalse:[^super handleFocusEvent: filteredEvent]. "handle clicks outside by regular means" - "Now it's getting tricky. On #mouseMove we might transfer control to *either* the currently active submenu or the pop up owner, if any. Since the active sub menu is always displayed upfront check it first." - selectedItem ifNotNil:[(selectedItem activateSubmenu: filteredEvent) ifTrue:[^filteredEvent]]. - ! Item was added: + ----- Method: DockingBarMorph>>mouseMove: (in category 'events-processing') ----- + mouseMove: evt + "We might transfer control to *either* the currently active submenu or the pop up owner, if any. Since the active sub menu is always displayed upfront check it first." + + selectedItem ifNotNil:[selectedItem activateSubmenu: evt].! Item was added: + ----- Method: DockingBarMorph>>processFocusEvent:using: (in category 'events-processing') ----- + processFocusEvent: evt using: dispatcher + + ^ dispatcher dispatchFocusEventFully: evt with: self! Item was added: + ----- Method: DockingBarMorph>>wantsEveryMouseMove (in category 'events-processing') ----- + wantsEveryMouseMove + ^ true! Item was changed: ----- Method: HandMorph>>sendFocusEvent:to:clear: (in category 'private events') ----- sendFocusEvent: anEvent to: focusHolder clear: aBlock "Send the event to the morph currently holding the focus" + | result w | w := focusHolder world ifNil:[aBlock value. ^ anEvent]. w becomeActiveDuring:[ ActiveHand := self. ActiveEvent := anEvent. + result := focusHolder processFocusEvent: anEvent. - result := focusHolder handleFocusEvent: - (anEvent transformedBy: (focusHolder transformedFrom: self)). ]. + ^ result == #rejected ifTrue: [anEvent] ifFalse: [result "filtered event"]! - ^result == #rejected ifTrue: [anEvent] ifFalse: [result "filtered event"]! Item was removed: - ----- Method: MenuMorph>>handleFocusEvent: (in category 'events') ----- - handleFocusEvent: evt - "Handle focus events. Valid menu transitions are determined based on the menu currently holding the focus after the mouse went down on one of its children." - | result filteredEvent | - result := self processEvent: evt. - filteredEvent := result == #rejected ifTrue: [evt] ifFalse: [result]. - - "Need to handle keyboard input if we have the focus." - filteredEvent isKeyboard ifTrue: [^ super handleFocusEvent: filteredEvent]. - - "We need to handle button clicks outside and transitions to local popUps so throw away everything else" - (filteredEvent isMouseOver or:[filteredEvent isMouse not]) ifTrue:[^filteredEvent]. - "What remains are mouse buttons and moves" - filteredEvent isMove ifFalse:[^super handleFocusEvent: filteredEvent]. "handle clicks outside by regular means" - "Now it's getting tricky. On #mouseMove we might transfer control to *either* the currently active submenu or the pop up owner, if any. Since the active sub menu is always displayed upfront check it first." - selectedItem ifNotNil: [ - (selectedItem activateSubmenu: filteredEvent) - ifTrue: [ ^filteredEvent ] - ifFalse: [ - (self containsPoint: filteredEvent position) ifFalse: [ - self selectItem: nil event: filteredEvent ] ] ]. - "Note: The following does not traverse upwards but it's the best I can do for now" - popUpOwner ifNotNil:[(popUpOwner activateOwnerMenu: filteredEvent) ifTrue:[^filteredEvent]]. - ^ filteredEvent! Item was removed: - ----- Method: MenuMorph>>handleMouseMove: (in category 'events') ----- - handleMouseMove: evt - " If the mouse moves over an item not selected, we try to set it as selected. - If this happens depends on that the current selected item wants to release - its selection. " - - self selectedItem ifNil: [ ^super handleMouseMove: evt ]. - (self selectedItem containsPoint: evt position) ifTrue: [ ^super handleMouseMove: evt ]. - self - selectItem: ( - self items - detect: [ :each | each containsPoint: evt position ] - ifNone: [ nil ]) - event: evt. - super handleMouseMove: evt! Item was added: + ----- Method: MenuMorph>>mouseMove: (in category 'events') ----- + mouseMove: evt + " If the mouse moves over an item not selected, we try to set it as selected. + If this happens depends on that the current selected item wants to release + its selection. " + + self selectedItem ifNil: [ ^ self ]. + (self selectedItem containsPoint: evt position) ifTrue: [ ^ self ]. + self + selectItem: ( + self items + detect: [ :each | each containsPoint: evt position ] + ifNone: [ nil ]) + event: evt. + + "Transfer control to *either* the currently active submenu or the pop up owner, if any. Since the active sub menu is always displayed upfront check it first." + selectedItem ifNotNil: [ + (selectedItem activateSubmenu: evt) + ifTrue: [ ^self ] + ifFalse: [ + (self containsPoint: evt position) ifFalse: [ + self selectItem: nil event: evt ] ] ]. + + "Note: The following does not traverse upwards but it's the best I can do for now" + popUpOwner ifNotNil:[popUpOwner activateOwnerMenu: evt]! Item was added: + ----- Method: MenuMorph>>processFocusEvent:using: (in category 'events') ----- + processFocusEvent: evt using: dispatcher + + ^ dispatcher dispatchFocusEventFully: evt with: self! Item was added: + ----- Method: MenuMorph>>wantsEveryMouseMove (in category 'events') ----- + wantsEveryMouseMove + ^ true! Item was changed: ----- Method: Morph>>handleFocusEvent: (in category 'events-processing') ----- handleFocusEvent: anEvent + "Handle the given event. This message is sent if the receiver currently has the focus and is therefore receiving events directly from some hand. However, it might already have been handled due to overrides in #processFocusEvent:using:. We might want to get rid of this call-back in the future..." - "Handle the given event. This message is sent if the receiver currently has the focus and is therefore receiving events directly from some hand. + ^ anEvent wasHandled + ifTrue: [anEvent] + ifFalse: [self handleEvent: anEvent]! - 1) Event bubbling. Do event bubbling known from MorphicEventDispatcher by calling #handleEvent: also on all owners. - 2) Event capture filters. Walk along the owner chain in reverse order and apply capture filters as known from MorphicEventDispatcher. - - If you want to overwrite this in a subclass (for example to implement modal dialogs) ensure to call super instead if #handleEvent: directly." - - | filteredEvent | - filteredEvent := anEvent. - - "TODO: Add a check to ensure that our event dispatcher is actually of kind MorphicEventDispatcher?!! We do copy its behavior though... like self defaultEventDispatcher class == MorphicEventDispatcher? Or #isKindOf:? Anyway, the outermost morph determines the event dispatcher. See HandMorph >> #sendEvent:focus:clear: and PasteUpMorph >> #processEvent:." - - "Event capturing. Filters only because the capturing phase was bypassed by using the keyboard/mouse focus." - self withAllOwners reverseDo: [:morph | "reverse order to comply with default MorphEventDispatcher" - morph == anEvent hand ifFalse: [ "Fixes drag-and-drop bug." - filteredEvent := morph sendFilterEventCapture: filteredEvent for: morph. - filteredEvent wasIgnored ifTrue: [^ filteredEvent]]]. - - "Event bubbling. Filters are processed in #handleEvent:." - self withAllOwnersDo: [:morph | - morph == anEvent hand ifFalse: [ "Fixes drag-and-drop bug." - filteredEvent := morph handleEvent: filteredEvent. - filteredEvent wasIgnored ifTrue: [^ filteredEvent]]]. - - ^ filteredEvent! Item was added: + ----- Method: Morph>>processFocusEvent: (in category 'events-processing') ----- + processFocusEvent: anEvent + + ^self processFocusEvent: anEvent using: self defaultEventDispatcher! Item was added: + ----- Method: Morph>>processFocusEvent:using: (in category 'events-processing') ----- + processFocusEvent: anEvent using: defaultDispatcher + "Event dispatching shortcut." + + ^ defaultDispatcher dispatchFocusEvent: anEvent with: self! Item was changed: + ----- Method: MorphicEventDispatcher>>dispatchEvent:toSubmorphsOf: (in category 'support') ----- - ----- Method: MorphicEventDispatcher>>dispatchEvent:toSubmorphsOf: (in category 'private') ----- dispatchEvent: anEvent toSubmorphsOf: aMorph "Dispatch the given event to the submorphs of the given morph. For coordinate transformations, work only with copies. Either return the given event or a copy of any filtered event to employ immutability to some extent. --- PRIVATE!!" | localEvent filteredEvent | aMorph submorphsDo: [:child | localEvent := anEvent transformedBy: (child transformedFrom: aMorph). filteredEvent := child processEvent: localEvent using: self. "use same dispatcher" filteredEvent == #rejected ifFalse: [ "some event or #rejected symbol" self flag: #overlappingChildren. "mt: We cannot give two overlapping siblings the chance to handle the event!!" + ^ self nextFromOriginal: anEvent local: localEvent filtered: filteredEvent]]. - filteredEvent == localEvent - ifTrue: [ - localEvent wasHandled ifTrue: [anEvent copyHandlerState: localEvent]. - anEvent wasIgnored: localEvent wasIgnored. - ^ anEvent] - ifFalse: [ - filteredEvent := filteredEvent copy. - filteredEvent translateTo: anEvent position. "restore to untransformed coordinates" - filteredEvent wasHandled ifFalse: [filteredEvent copyHandlerState: anEvent]. "restore handler if needed" - ^ filteredEvent]]]. ^ #rejected! Item was changed: + ----- Method: MorphicEventDispatcher>>dispatchEvent:withHandler:withMorph: (in category 'support') ----- - ----- Method: MorphicEventDispatcher>>dispatchEvent:withHandler:withMorph: (in category 'private') ----- dispatchEvent: anEvent withHandler: aHandler withMorph: aMorph "Perform the actual event dispatch. Use the given object as handler. Ask submorphs first to handle the event. Then bubble up. Stop if ignored. Note that event rejection and event filters are two separete concepts. Filters come from the outside. Rejection is a morph's decision. * The top-most chain of visible, unlocked morphs containing the event position will get a chance to handle the event. * When travelling up, the prospective handler is always executed. The handler needs to check if the event was handled before as well as checking if somebody else's handler has been installed. * If another handler has been installed but the event was not handled it means that somebody up in the hierarchy wants to handle the event." | result filteredEvent | result := self dispatchEvent: anEvent toSubmorphsOf: aMorph. result == #rejected "Anybody?" ifFalse: [filteredEvent := result] ifTrue: [ "My submorphs did not want it. Do I want it anyway? It's about locked children..." (aMorph containsPoint: anEvent position event: anEvent) ifFalse: [^ #rejected]. filteredEvent := anEvent "there was no filtering, only basic rejects"]. "Receiver is in the top-most unlocked, visible chain." (aHandler notNil and: [filteredEvent wasIgnored not]) ifTrue: [filteredEvent := aHandler handleEvent: filteredEvent]. ^ filteredEvent! Item was added: + ----- Method: MorphicEventDispatcher>>dispatchFocusEvent:with: (in category 'focus events') ----- + dispatchFocusEvent: anEventWithGlobalPosition with: focusMorph + "Dispatch the given event to the given morph. Simulate capturing phase, handle the event, then do bubbling." + + | currentEvent | + "1) Capturing phase." + currentEvent := self doCapturingForFocusEvent: anEventWithGlobalPosition with: focusMorph. + currentEvent == #rejected ifTrue: [^ #rejected]. + currentEvent wasIgnored ifTrue: [^ currentEvent]. + + "2) No sub-tree processing here. Use #dispatchFocusEventFully:with: if you want that, too." + + "3) Let the focus morph handle the event." + currentEvent := self doHandlingForFocusEvent: currentEvent with: focusMorph. + currentEvent wasIgnored ifTrue: [^ currentEvent]. + + "4) Bubbling phase" + ^ self doBubblingForFocusEvent: currentEvent with: focusMorph! Item was added: + ----- Method: MorphicEventDispatcher>>dispatchFocusEventFully:with: (in category 'focus events') ----- + dispatchFocusEventFully: anEventWithGlobalPosition with: focusMorph + "Dispatch the given event to the given morph. Do capturing, processing in sub-tree, and bubbling." + + | currentEvent | + "1) Capturing phase." + currentEvent := self doCapturingForFocusEvent: anEventWithGlobalPosition with: focusMorph. + currentEvent == #rejected ifTrue: [^ #rejected]. + currentEvent wasIgnored ifTrue: [^ currentEvent]. + + "2) Sub-tree processing." + currentEvent := self doProcessingForFocusEvent: currentEvent with: focusMorph. + currentEvent wasIgnored ifTrue: [^ currentEvent]. + + "3) Let the focus morph handle the event. Usually no effect because previous sub-tree processing involved the focus morph already -- at least in the bubbling phase. Skip it?" + currentEvent := self doHandlingForFocusEvent: currentEvent with: focusMorph. + currentEvent wasIgnored ifTrue: [^ currentEvent]. + + "4) Bubbling phase." + ^ self doBubblingForFocusEvent: currentEvent with: focusMorph! Item was added: + ----- Method: MorphicEventDispatcher>>doBubblingForFocusEvent:with: (in category 'support') ----- + doBubblingForFocusEvent: anEvent with: focusMorph + "Simulate real event bubbling up to the focused morph's outermost owner. Applies event bubble filters via Morph >> #handleEvent:. Watch out for coordinate transformations and some globals (ActiveWorld, ...)." + + | currentEvent filteredEvent localEvent referenceMorph | + currentEvent := anEvent. + referenceMorph := anEvent hand. + + focusMorph allOwnersDo: [:ownerMorph | + ownerMorph == anEvent hand ifFalse: [ "Never bubble up to the hand morph but only up to the world." + localEvent := currentEvent transformedBy: (ownerMorph transformedFrom: referenceMorph). + filteredEvent := ownerMorph handleEvent: localEvent. + currentEvent := self nextFromOriginal: currentEvent local: localEvent filtered: filteredEvent. + currentEvent wasIgnored ifTrue: [^ currentEvent]]]. + + ^ currentEvent! Item was added: + ----- Method: MorphicEventDispatcher>>doCapturingForFocusEvent:with: (in category 'support') ----- + doCapturingForFocusEvent: anEvent with: focusMorph + "Simulate real event capturing down to the focused morph. Apply event capture filters. Watch out for coordinate transformations. Keep the filter-ignore-reject order like in Morph >> #processEvent:using:." + + | currentEvent filteredEvent localEvent referenceMorph | + currentEvent := anEvent. + referenceMorph := anEvent hand. + + "Event capturing. Filters only because the capturing phase was bypassed by using the keyboard/mouse focus." + focusMorph withAllOwners reverseDo: [:ownerMorph | "reverse order to comply with regular dispatching" + ownerMorph == anEvent hand ifFalse: [ "Never dispatch the hand morph. It already did so." + localEvent := currentEvent transformedBy: (ownerMorph transformedFrom: referenceMorph). + + filteredEvent := ownerMorph sendFilterEventCapture: localEvent for: ownerMorph. + + "Ignoring has higher priority but the reject-check must be with local event coodinates." + (filteredEvent wasIgnored not and: [ownerMorph rejectsEvent: filteredEvent]) + ifTrue: [^ #rejected]. + + currentEvent := self nextFromOriginal: currentEvent local: localEvent filtered: filteredEvent. + currentEvent wasIgnored ifTrue: [^ currentEvent]]]. + + ^ currentEvent! Item was added: + ----- Method: MorphicEventDispatcher>>doHandlingForFocusEvent:with: (in category 'support') ----- + doHandlingForFocusEvent: currentEvent with: focusMorph + + | localEvent filteredEvent | + localEvent := currentEvent transformedBy: (focusMorph transformedFrom: currentEvent hand). + filteredEvent := focusMorph handleFocusEvent: localEvent. + ^ self nextFromOriginal: currentEvent local: localEvent filtered: filteredEvent.! Item was added: + ----- Method: MorphicEventDispatcher>>doProcessingForFocusEvent:with: (in category 'support') ----- + doProcessingForFocusEvent: currentEvent with: focusMorph + "Sub-tree processing (including capturing from focus morph down to something and bubbling up back to focus morph). Never reject in the end." + + | localEvent filteredEvent | + localEvent := currentEvent transformedBy: (focusMorph transformedFrom: currentEvent hand). + filteredEvent := focusMorph processEvent: localEvent using: self. + ^ filteredEvent == #rejected + ifTrue: [currentEvent] "Can happen if you click, e.g., outside the bounds of the focus morph" + ifFalse: [self nextFromOriginal: currentEvent local: localEvent filtered: filteredEvent]! Item was added: + ----- Method: MorphicEventDispatcher>>nextFromOriginal:local:filtered: (in category 'support') ----- + nextFromOriginal: originalEvent local: localEvent filtered: filteredEvent + "Take the filtered event if different but always keep the original coordinates." + + filteredEvent == localEvent + ifTrue: [ "Use original event but keep track of ignored flag." + localEvent wasHandled ifTrue: [originalEvent copyHandlerState: localEvent]. + originalEvent wasIgnored: localEvent wasIgnored. + ^ originalEvent] + ifFalse: [ "There was an event transformation. Copy, revert coordinates, keep handler state." + | result | + result := filteredEvent copy. "Never mutate position without copying. MouseClickState etc. will break otherwise." + result translateTo: originalEvent position. "restore to untransformed coordinates" + result wasHandled ifFalse: [result copyHandlerState: originalEvent]. + ^ result]. + ! Item was removed: - ----- Method: UserDialogBoxMorph>>handleFocusEvent: (in category 'constructing') ----- - handleFocusEvent: evt - "Handle focus events. Valid menu transitions are determined based on the menu currently holding the focus after the mouse went down on one of its children. Need to handle keyboard input if we have the focus." - - | result filteredEvent | - result := self processEvent: evt. - filteredEvent := result == #rejected ifTrue: [evt] ifFalse: [result]. - - ^ super handleFocusEvent: filteredEvent! Item was added: + ----- Method: UserDialogBoxMorph>>processFocusEvent:using: (in category 'events') ----- + processFocusEvent: evt using: dispatcher + + ^ dispatcher dispatchFocusEventFully: evt with: self!

1 0

Re: Angry my self
by marcel.taeumel 20 Jun '16

20 Jun '16

Hi Sergio, did you try to download the all-in-one [1] and did not get it running on Windows (32-bit)? Was it Windows 7, 8, 8.1, 10? XP? Best, Marcel [1] http://files.squeak.org/5.0/Squeak-5.0-All-in-One.zip -- View this message in context: http://forum.world.st/Angry-my-self-tp4901835p4901915.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

64-bit bug(s)
by Eliot Miranda 18 Jun '16

18 Jun '16

Hi Timothy, Hi All, I know some people have seen UI bugs with the 64-bit VM and image. This is just to report that I see one very obvious bug. In a recent messages browser on 64-bits any attempt to select a method other than the first in the list works, but immediately the selection reverts to the first element in the list. I suspect something in the event chain. But it's nice to have an obvious bug to chase instead of the much harder visual bugs people have been reporting up until now. Hopefully the same root cause will account for both bugs. Fingers crossed. _,,,^..^,,,_ best, Eliot

3 5

Moving the Cog subversion repository to githup at 2016-6-16 7am UTC
by Eliot Miranda 18 Jun '16

18 Jun '16

Hi all, we are all finished importing the VM repository to Github, migrating the scripts, and setting up automatic builds and hosting of binaries. We want to switch over from SVN tomorrow morning at 7am UTC. At that point, Tim and Fabio will merge any remaining commits on the SVN repository between now and that time and any further development will take place on Github. If possible, you may refrain from committing to SVN, as this will mean less work for Tim and Fabio. The new repository is at https://github.com/OpenSmalltalk/vm. The Cog branch is the new default branch and is still called Cog, this is the main focus of development. The old trunk branch has been renamed to "oldTrunk". The master branch will track the Cog branch and will be the repository integrated into for releases. To get started, please refer to the updated README <https://github.com/OpenSmalltalk/vm/blob/Cog/README.md> that is shown on the Github page. _,,,^..^,,,_ best, Eliot, Tim & Fabio

8 13

Daily Commit Log
by commits＠source.squeak.org 17 Jun '16

17 Jun '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-June/068226.html Name: Kernel-eem.1029 Ancestors: Kernel-mt.1028 Supply missing simulation methods for the new Mutex primitives and hence render through on code like the following funcitonal again: Mutex new critical: [[Object new] on: Notification do: [:noti| ]] ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068227.html Name: Kernel-eem.1030 Ancestors: Kernel-eem.1029 Fix simulation of the withArgs:executeMethod: and tryPrimitive:withArgs: primitives, as well as providing support for receiver:tryPrimitive:withArgs: when it is implemented. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068228.html Name: WebClient-Core-topa.101 Ancestors: WebClient-Core-ul.100 Only close streams that are still connected. =============================================

1 0

Daily Commit Log
by commits＠source.squeak.org 17 Jun '16

17 Jun '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-June/068212.html Name: Graphics-topa.346 Ancestors: Graphics-topa.345 DejaVu rendering: Improve v-fuzz by ensuring integral virtual font heights. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068213.html Name: Graphics-topa.347 Ancestors: Graphics-topa.346 (Oops. Use 30% smaller PNGs) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-June/068214.html Name: Graphics-topa.348 Ancestors: Graphics-topa.347 Very Small fonts do no longer need descender adjustment =============================================

3 4

Re: [squeak-dev] The Trunk: Graphics-mt.351.mcz
by Levente Uzonyi 17 Jun '16

17 Jun '16

Hi Marcel, I suppose this change has broken all StrikeFonts other than Bitmap DejaVu Sans. Levente On Thu, 16 Jun 2016, commits(a)source.squeak.org wrote: > Marcel Taeumel uploaded a new version of Graphics to project The Trunk: > http://source.squeak.org/trunk/Graphics-mt.351.mcz > > ==================== Summary ==================== > > Name: Graphics-mt.351 > Author: mt > Time: 16 June 2016, 1:56:13.140696 pm > UUID: 40df15d7-0c28-2b4e-8be2-231d75e087f8 > Ancestors: Graphics-lpc.350 > > Removes manual kerning corrections for the 7-point DejaVu Sans, which are not necessary anymore. > > =============== Diff against Graphics-lpc.350 =============== > > Item was changed: > ----- Method: StrikeFont>>ascentKern (in category 'accessing') ----- > ascentKern > "Return the kern delta for ascenders." > + > + self depth > 1 ifTrue: [^ 0]. > + > + "Optimization for traditional 1-bit fonts." > + ^ (emphasis allMask: 2) > + ifFalse: [0] > + ifTrue: [(self ascent-5+4)//4 max: 0] "See makeItalicGlyphs" > - (emphasis noMask: 2) ifTrue: [^ 0]. > - ^ (self ascent-5+4)//4 max: 0 "See makeItalicGlyphs" > > ! > > Item was changed: > ----- Method: StrikeFont>>baseKern (in category 'accessing') ----- > baseKern > "Return the base kern value to be used for all characters." > > + self depth > 1 ifTrue: [^ 0]. > - | italic | > - italic := emphasis allMask: 2. > > + "Optimization for traditional 1-bit fonts." > + ^ (emphasis allMask: 2) > + ifFalse: [0] > + ifTrue: [((self height-1-self ascent+4)//4 max: 0) "See makeItalicGlyphs" > + + (((self ascent-5+4)//4 max: 0))]! > - glyphs depth > 1 ifTrue: [ > - ^(italic or: [ pointSize < 9 ]) > - ifTrue: [ 1 ] > - ifFalse: [ 0] ]. > - > - italic ifFalse: [^ 0]. > - ^ ((self height-1-self ascent+4)//4 max: 0) "See makeItalicGlyphs" > - + (((self ascent-5+4)//4 max: 0))! > > Item was changed: > ----- Method: StrikeFont>>descentKern (in category 'accessing') ----- > descentKern > "Return the kern delta for descenders." > - (emphasis noMask: 2) ifTrue: [^ 0]. > - ^ (self height-1-self ascent+4)//4 max: 0 "See makeItalicGlyphs" > > + self depth > 1 ifTrue: [^ 0]. > + > + "Optimization for traditional 1-bit fonts." > + ^ (emphasis allMask: 2) > + ifFalse: [0] > + ifTrue: [(self height-1-self ascent+4)//4 max: 0] "See makeItalicGlyphs" > + > ! > > >

2 2

Fetch zip file from web, unzip, save constituent parts?
by tim Rowledge 17 Jun '16

17 Jun '16

I’ve got dizzy trying to dig through all the remote file and server directory and URI and Url andHttp* classes. Do we really have three completely different ways of handling files out on the web? What I need to do is access a zip file on a server, download it and save a directory of the constituent parts. The contained files are assorted gifs, jpegs, wav etc media files. Ideally I’d like to decode those without even saving the separate files and then re-loading them but let’s see if I can just get the data and unzip it first. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Why do we want intelligent terminals when there are so many stupid users?

3 9

The Trunk: WebClient-Core-topa.101.mcz
by commits＠source.squeak.org 17 Jun '16

17 Jun '16

Tobias Pape uploaded a new version of WebClient-Core to project The Trunk: http://source.squeak.org/trunk/WebClient-Core-topa.101.mcz ==================== Summary ==================== Name: WebClient-Core-topa.101 Author: topa Time: 17 June 2016, 9:00:40.215483 pm UUID: 97088e21-0ce9-4029-be2c-4e82d0f0050a Ancestors: WebClient-Core-ul.100 Only close streams that are still connected. =============== Diff against WebClient-Core-ul.100 =============== Item was changed: ----- Method: WebClient>>close (in category 'initialize') ----- close "Close the client's stream" stream ifNotNil:[ + stream isConnected ifTrue: [stream close]. + stream := nil]. - stream close. - stream := nil. - ]. !

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
21
Older →

Jump to page: