Squeak-dev July 2016

squeak-dev@lists.squeakfoundation.org

38 participants
224 discussions

Text Style Code in TextMorph
by Rein, Patrick 20 Jul '16

20 Jul '16

Hi everyone, I have just started investigating a bug with the PluggableTextMorphPlus where a TextStyle affecting a complete Text remained valid after setting a String instead. During debugging I have encountered the following code in TextMorph>>#newContents: (text notNil and: [ (textSize := text size) > 0] and: [ (text runLengthFor: 1) = textSize ]) ifTrue: [ | attribs | attribs := text attributesAt: 1 forStyle: textStyle. Text string: stringOrText copy attributes: attribs.] ifFalse: [ Text fromString: stringOrText copy ] What it does is that if the previous style applied to all of the Text, then the new Text also gets this style applied. Why is that? That seems pretty weird to me to only handle this one special case. Does anyone know the rational behind that? Thanks and bests Patrick

2 1

The Trunk: Tests-pre.346.mcz
by commits＠source.squeak.org 20 Jul '16

20 Jul '16

Patrick Rein uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-pre.346.mcz ==================== Summary ==================== Name: Tests-pre.346 Author: pre Time: 20 July 2016, 5:57:17.403797 pm UUID: e81ba10f-54f7-ae4d-b971-8a80bebac7ba Ancestors: Tests-pre.345 Fixed the expected failures in the locales test to catch the current misconfiguration in the language extensions. =============== Diff against Tests-pre.345 =============== Item was changed: ----- Method: LocaleTest>>expectedFailures (in category 'testing') ----- expectedFailures ^ super expectedFailures, + ((NaturalLanguageTranslator translators isEmpty + or: [(NaturalLanguageTranslator translators values collect: [:t | t localeID ]) + asSet size = 1]) + ifTrue: [#(testLocaleChanged) "no locale available to switch to"] + ifFalse: [ #()]) - (NaturalLanguageTranslator translators - ifEmpty: [#(testLocaleChanged) "no locale available to switch to"] - ifNotEmpty: [#()]) ! Item was changed: ----- Method: LocaleTest>>testIsFontAvailable (in category 'testing') ----- testIsFontAvailable "self debug: #testIsFontAvailable" <timeout: 60> "takes quite a while" + self ensureInternetConnectionTo: 'http://metatoys.org/pub/'. + Preferences restoreFontsAfter: [ | currentDefaultTextStyle | currentDefaultTextStyle := TextStyle default. [ TextStyle setDefault: (TextStyle actualTextStyles at: #Accuny). (Locale isoLanguage: 'ja') languageEnvironment removeFonts. self assert: (Locale isoLanguage: 'en') languageEnvironment isFontAvailable. "Next test should fail after installing Japanese font" self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not. (Locale isoLanguage: 'ja') languageEnvironment installFont. self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable ] + ensure: [ TextStyle setDefault: currentDefaultTextStyle. + FileDirectory default deleteFileNamed: (Locale isoLanguage: 'ja') languageEnvironment fontFullName. ] ].! - ensure: [ TextStyle setDefault: currentDefaultTextStyle ] ].!

1 0

The Trunk: SUnit-pre.104.mcz
by commits＠source.squeak.org 20 Jul '16

20 Jul '16

Patrick Rein uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-pre.104.mcz ==================== Summary ==================== Name: SUnit-pre.104 Author: pre Time: 20 July 2016, 5:55:40.721797 pm UUID: 41cb7db6-db89-c448-b0bb-5d74217a8bd6 Ancestors: SUnit-ul.103 Adds a new SUnit extension for tests which require an internet connection. This call should come at the beginning of the test to assert an internet connection and document any implicit dependence on network resources. =============== Diff against SUnit-ul.103 =============== Item was added: + ----- Method: SUnitExtensionsTest>>testEnsureInternetFails (in category 'test') ----- + testEnsureInternetFails + + self should: [self ensureInternetConnectionTo: ''] raise: Error! Item was added: + ----- Method: TestCase>>ensureInternetConnection (in category 'extensions') ----- + ensureInternetConnection + + ^ self ensureInternetConnectionTo: 'http://www.google.com'! Item was added: + ----- Method: TestCase>>ensureInternetConnectionTo: (in category 'extensions') ----- + ensureInternetConnectionTo: url + + "(Smalltalk classNamed: 'WebClient') httpGet: 'http://www.google.com'" + ((Smalltalk classNamed: 'WebClient') httpGet: url) isSuccess + ifFalse: [Error signal: 'No internet connection available, but test requires one'] + ! Item was added: + ----- Method: TestCase>>ensureSecureInternetConnection (in category 'extensions') ----- + ensureSecureInternetConnection + + ^ self ensureConnectionTo: 'https://www.google.com'!

1 0

WarpBlt works better on the 64 bit VM!
by Yoshiki Ohshima 20 Jul '16

20 Jul '16

I was trying to create a grayscale image. There is of course Form>>asGrayScale, but it has two problems: 1. It makes a BitBlt call for each vertical 1 pxiel side slice in the image. 2. It only sees uses green channel, and pretend to be that it is the gray value. For the first issue, I thought of using WarpBlt to only make a one call for the image. Basically, you reshape the 32-bit depth picture into 1 pixel wide, (w*h) height bitmap, and then re-interpret that picture as 8-bit picture of 4 pixel * (w*h) picture. There, column 0 has the R component of all original pixels, column 1 has the G component of all original pixels, and so on. Then, by rotating that picture and copy the now row 1, which was column 1, onto the resultinf form, it becomes the gray scale: -------------------------- asGrayScale: aForm | form8 g h quad w c | h := aForm width * aForm height. form8 := Form extent: 4@h depth: 8 bits: aForm bits. g := Form extent: h@1 depth: 8. w := WarpBlt toForm: g. quad := {2@0. 3@0. 3@h. 2@h}. w sourceForm: form8. w colorMap: nil. w combinationRule: Form over. w copyQuad: quad toRect: g boundingBox. c := ColorForm extent: aForm extent depth: 8 bits: g bits. c colors: (ColorForm grayScalePalette). ^ c -------------------------- It works! but then it is not as fast as I hoped. That is because, the WarpBlt primitive fails and its fallback code gets run (but produces a correct result). And the reason is that p3y and p4y in the WarpBlt object go beyond the SmallInteger range. But then, it occured to me that the number, 15099494400, is a SmallInteger on the 64 bit platform. Sure enough, the above code just works and produces 4x performance. Okay, I might actualy like to do a bit better job of computing grayscale. Brightness in HSB is defined as "(R max: G) max: B", and I can use the combination rule 27 to compute it. The result is more involving: -------------------------- asGrayScale2: aForm | b b32 form8 g g32 h quad r r32 w c | h := aForm width * aForm height. form8 := Form extent: 4@h depth: 8 bits: aForm bits. r := Form extent: (h@1) depth: 8. w := WarpBlt toForm: r. quad := {1@0. 2@0. 2@h. 1@h}. w sourceForm: form8. w colorMap: nil. w combinationRule: Form over. w copyQuad: quad toRect: r boundingBox. g := Form extent: (h@1) depth: 8. w := WarpBlt toForm: g. quad := {2@0. 3@0. 3@h. 2@h}. w sourceForm: form8. w colorMap: nil. w combinationRule: Form over. w copyQuad: quad toRect: g boundingBox. b := Form extent: (h@1) depth: 8. w := WarpBlt toForm: b. quad := {3@0. 4@0. 4@h. 3@h}. w sourceForm: form8. w colorMap: nil. w combinationRule: Form over. w copyQuad: quad toRect: b boundingBox. g32 := Form extent: (h / 4)@1 depth: 32 bits: g bits. r32 := Form extent: (h / 4)@1 depth: 32 bits: r bits. b32 := Form extent: (h / 4)@1 depth: 32 bits: b bits. ((BitBlt destForm: r32 sourceForm: g32 fillColor: nil combinationRule: 27 destOrigin: 0@0 sourceOrigin: 0@0 extent: g32 extent clipRect: r32 boundingBox) colorMap: nil) copyBits. ((BitBlt destForm: r32 sourceForm: b32 fillColor: nil combinationRule: 27 destOrigin: 0@0 sourceOrigin: 0@0 extent: b32 extent clipRect: r32 boundingBox) colorMap: nil) copyBits. c := ColorForm extent: aForm extent depth: 8 bits: r32 bits. c colors: (ColorForm grayScalePalette). ^ c -------------------------- But this still runs faster than Form>>asGrayScale (but less than 2x) on 64 bit. I never had a convincing case for 64-bit VM for my small example, but this was pretty interesting result... Thank you everybody who made the 64-bit environment works! (And I confirmed that the new CameraPlugin works on 64-bit environment MacOS.) -- Yoshiki

1 0

lock up in screen drag
by Eliot Miranda 20 Jul '16

20 Jul '16

Hi ALl, I'm seeing a lock up that appears to be on window dragging. This is on Mac OS X with a new VM. The symptom is that the screen goes blank. I see this process when sending SIGUSR1 to the process: Process 0x4800ad0 priority 40 0xbffac304 M [] in Delay>wait 0x4802858: a(n) Delay 0xbffac324 M BlockClosure>ifCurtailed: 0x4a920e0: a(n) BlockClosure 0xbffac340 M Delay>wait 0x4802858: a(n) Delay 0xbffac36c M Rectangle>newRectFrom: 0x4803df0: a(n) Rectangle 0xbffac39c I PluggableSystemWindow(SystemWindow)>doFastFrameDrag: 0x4802740: a(n) PluggableSystemWindow 0xbffac3b8 M PluggableSystemWindow(SystemWindow)>startDragFromLabel: 0x4802740: a(n) PluggableSystemWindow 0xbffac3d8 M EventHandler>send:to:withEvent:fromMorph: 0x4803f30: a(n) EventHandler 0xbffac408 I EventHandler>startDrag:fromMorph: 0x4803f30: a(n) EventHandler 0xbffac428 M StringMorph(Morph)>startDrag: 0x4801458: a(n) StringMorph 0xbffac44c I MouseClickState>drag: 0x4803fc8: a(n) MouseClickState 0xbffac474 M MouseClickState>handleEvent:from: 0x4803fc8: a(n) MouseClickState 0xbffac498 M HandMorph>handleEvent: 0x5cef1a0: a(n) HandMorph 0xbffac4c4 M HandMorph>processEvents 0x5cef1a0: a(n) HandMorph 0xbffac4e0 M [] in WorldState>doOneCycleNowFor: 0x5d1ba70: a(n) WorldState 0xbffac504 M Array(SequenceableCollection)>do: 0x4e6fa10: a(n) Array 0xbffac520 M WorldState>handsDo: 0x5d1ba70: a(n) WorldState 0xbffac540 M WorldState>doOneCycleNowFor: 0x5d1ba70: a(n) WorldState 0xbffac55c M WorldState>doOneCycleFor: 0x5d1ba70: a(n) WorldState 0xbffac578 M PasteUpMorph>doOneCycle 0x52d8780: a(n) PasteUpMorph 0xbffac590 M [] in MorphicProject>spawnNewProcess 0x604fe08: a(n) MorphicProject 0xbffac5b0 I [] in BlockClosure>newProcess 0x48040b8: a(n) BlockClosure _,,,^..^,,,_ best, Eliot

3 6

The Trunk: Network-nice.179.mcz
by commits＠source.squeak.org 20 Jul '16

20 Jul '16

Nicolas Cellier uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-nice.179.mcz ==================== Summary ==================== Name: Network-nice.179 Author: nice Time: 20 July 2016, 12:19:36.925063 am UUID: d5a82bde-b7b7-47ab-8d39-94beab819cae Ancestors: Network-bp.178 Let VMMaker (.oscog branch) code generation work on windows. Detail: VMMaker uses something like: FileDirectory default pathFromURI: self sourceTree, '/spur64src' On windows, the URI encodes drive spec letter $: into '%3A'. This was never decoded, and then C%3A\Users\nicolas\opensmalltalk-vm\spur64src is not a good path specification and miserably fails :( Note that DosFileDirectory class privateFullPathForURI: seems to perform some similar task, so maybe the next step will be to CLEAN UP!!! =============== Diff against Network-bp.178 =============== Item was changed: ----- Method: DosFileDirectory>>uriPathToPlatformPath: (in category '*network-uri') ----- uriPathToPlatformPath: aString "Convert a URI path (w/ forward slashes) into a platform path if necessary. Also make sure we deal properly with shares vs. drives" + | parts path | + path := aString unescapePercents. + parts := path findTokens: '/'. - | parts | - parts := aString findTokens: '/'. (parts first endsWith: ':') ifTrue:[ "it's a drive - compose c:\foo\bar" + ^path allButFirst copyReplaceAll: '/' with: '\' - ^aString allButFirst copyReplaceAll: '/' with: '\' ] ifFalse:[ "it's a share - compose \\share\foo\bar" + ^'\', (path copyReplaceAll: '/' with: '\') - ^'\', (aString copyReplaceAll: '/' with: '\') ].!

1 0

Daily Commit Log
by commits＠source.squeak.org 19 Jul '16

19 Jul '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-July/068280.html Name: TraitsTests-pre.16 Ancestors: TraitsTests-pre.15 Fixes many of the TraitsTests failures by introducing a general timeout of 60 seconds for all of them. This is necessary to account for the long setup time for each test. Also refactors one test into several single test cases. =============================================

1 0

The Trunk: TraitsTests-pre.16.mcz
by commits＠source.squeak.org 19 Jul '16

19 Jul '16

Patrick Rein uploaded a new version of TraitsTests to project The Trunk: http://source.squeak.org/trunk/TraitsTests-pre.16.mcz ==================== Summary ==================== Name: TraitsTests-pre.16 Author: pre Time: 19 July 2016, 11:49:05.039751 pm UUID: 323a0c3d-53a3-9447-a721-4aa097ac0a07 Ancestors: TraitsTests-pre.15 Fixes many of the TraitsTests failures by introducing a general timeout of 60 seconds for all of them. This is necessary to account for the long setup time for each test. Also refactors one test into several single test cases. =============== Diff against TraitsTests-pre.15 =============== Item was removed: - ----- Method: TraitCompositionTest>>testAliasCompositions (in category 'testing-basic') ----- - testAliasCompositions - <timeout: 30> - - "unary" - self - shouldnt: [self t2 uses: self t1 @ { (#aliasM11 -> #m11) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#alias: -> #m11) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#alias:x:y: -> #m11) }] - raise: TraitCompositionException. - - "binary" - self t1 compile: '= anObject'. - self - shouldnt: [self t2 uses: self t1 @ { (#equals: -> #=) }] - raise: TraitCompositionException. - self shouldnt: [self t2 uses: self t1 @ { (#% -> #=) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#equals -> #=) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#equals:x: -> #=) }] - raise: TraitCompositionException. - - "keyword" - self t1 compile: 'x: a y: b z: c'. - self - should: [self t2 uses: self t1 @ { (#'==' -> #x:y:z:) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#x -> #x:y:z:) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#x: -> #x:y:z:) }] - raise: TraitCompositionException. - self - should: [self t2 uses: self t1 @ { (#x:y: -> #x:y:z:) }] - raise: TraitCompositionException. - self shouldnt: - [self t2 uses: self t1 @ { (#myX:y:z: -> #x:y:z:) }] - raise: TraitCompositionException. - - "alias same as selector" - self - should: [self t2 uses: self t1 @ { (#m11 -> #m11) }] - raise: TraitCompositionException. - - "same alias name used twice" - self should: - [self t2 - uses: self t1 @ { (#alias -> #m11). (#alias -> #m12) }] - raise: TraitCompositionException. - - "aliasing an alias" - self should: - [self t2 - uses: self t1 @ { (#alias -> #m11). (#alias2 -> #alias) }] - raise: TraitCompositionException! Item was added: + ----- Method: TraitCompositionTest>>testAliasCompositionsRaisesErrorBinary (in category 'testing-basic') ----- + testAliasCompositionsRaisesErrorBinary + + "binary" + self t1 compile: '= anObject'. + self + shouldnt: [self t2 uses: self t1 @ { (#equals: -> #=) }] + raise: TraitCompositionException. + self shouldnt: [self t2 uses: self t1 @ { (#% -> #=) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#equals -> #=) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#equals:x: -> #=) }] + raise: TraitCompositionException.! Item was added: + ----- Method: TraitCompositionTest>>testAliasCompositionsRaisesErrorKeyword (in category 'testing-basic') ----- + testAliasCompositionsRaisesErrorKeyword + + "keyword" + self t1 compile: 'x: a y: b z: c'. + self + should: [self t2 uses: self t1 @ { (#'==' -> #x:y:z:) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#x -> #x:y:z:) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#x: -> #x:y:z:) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#x:y: -> #x:y:z:) }] + raise: TraitCompositionException. + self shouldnt: + [self t2 uses: self t1 @ { (#myX:y:z: -> #x:y:z:) }] + raise: TraitCompositionException.! Item was added: + ----- Method: TraitCompositionTest>>testAliasCompositionsRaisesErrorSpecial (in category 'testing-basic') ----- + testAliasCompositionsRaisesErrorSpecial + + "alias same as selector" + self + should: [self t2 uses: self t1 @ { (#m11 -> #m11) }] + raise: TraitCompositionException. + + "same alias name used twice" + self should: + [self t2 + uses: self t1 @ { (#alias -> #m11). (#alias -> #m12) }] + raise: TraitCompositionException. + + "aliasing an alias" + self should: + [self t2 + uses: self t1 @ { (#alias -> #m11). (#alias2 -> #alias) }] + raise: TraitCompositionException! Item was added: + ----- Method: TraitCompositionTest>>testAliasCompositionsRaisesErrorUnary (in category 'testing-basic') ----- + testAliasCompositionsRaisesErrorUnary + + "unary" + self + shouldnt: [self t2 uses: self t1 @ { (#aliasM11 -> #m11) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#alias: -> #m11) }] + raise: TraitCompositionException. + self + should: [self t2 uses: self t1 @ { (#alias:x:y: -> #m11) }] + raise: TraitCompositionException.! Item was changed: ----- Method: TraitMethodDescriptionTest>>testConflictMethodCreation (in category 'running') ----- testConflictMethodCreation "Generate conflicting methods between t1 and t2 and check the resulting method in Trait t5 (or c2). Also test selectors like foo:x (without space) or selectors with CRs." + - <timeout: 30> - "unary" self t2 compile: 'm12 ^false'. self assert: ((self t5 sourceCodeAt: #m12) asString beginsWith: 'm12'). self should: [self c2 new m12] raise: Error. "binary" self t1 compile: '@ myArgument ^true'. self t2 compile: '@myArgument ^false'. self assert: ((self t5 sourceCodeAt: #@) asString beginsWith: '@ arg1'). self should: [self c2 new @ 17] raise: Error. "keyword" self t1 compile: 'zork: myArgument ^true'. self t2 compile: 'zork: myArgument ^false'. self assert: ((self t5 sourceCodeAt: #zork:) asString beginsWith: 'zork: arg1'). self should: [self c2 new zork: 17] raise: Error. self t1 compile: 'zork:myArgument ^true'. self t2 compile: 'zork:myArgument ^false'. self assert: ((self t5 sourceCodeAt: #zork:) asString beginsWith: 'zork: arg1'). self should: [self c2 new zork: 17] raise: Error. self t1 compile: 'zork1: myArgument zork2: mySecondArgument ^true'. self t2 compile: 'zork1: anObject zork2: anotherObject ^false'. self assert: ((self t5 sourceCodeAt: #zork1:zork2:) asString beginsWith: 'zork1: arg1 zork2: arg2'). self should: [self c2 new zork1: 1 zork2: 2] raise: Error! Item was added: + ----- Method: TraitsTestCase>>setUp (in category 'accessing') ----- + setUp + + super setUp. + self timeout: 90. "pre: This is necessary to account for the TraitsResrouce setup" + !

1 0

Squeak Meetup Group in the Chicago Area
by Joseph Alotta 19 Jul '16

19 Jul '16

Hi Everyone, I started a meetup group for Squeak programing in the Chicago Area. http://www.meetup.com/Learn-Programming-With-Squeak-Smalltalk-Club/ If you know anyone who is interested. Sincerely, Joe. PS. Be prepared for lots of beginner questions coming your way. :-)

1 0

MCSmalltalkhubRepository for Squeak?
by Eliot Miranda 19 Jul '16

19 Jul '16

Hi, any one have MCSmalltalkhubRepository? I want to load the ASN1 code to explore a performance regression in the VM, but I must first have access to smalltalkhub. _,,,^..^,,,_ best, Eliot

5 7

← Newer
1
...
12
13
14
15
16
17
18
...
23
Older →

Jump to page: