Squeak-dev October 2017

squeak-dev@lists.squeakfoundation.org

40 participants
132 discussions

The Trunk: MorphicExtras-pre.211.mcz
by commits＠source.squeak.org 02 Oct '17

02 Oct '17

Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.211.mcz ==================== Summary ==================== Name: MorphicExtras-pre.211 Author: pre Time: 2 October 2017, 2:23:27.336394 pm UUID: 453b45d7-fcb6-d041-aa89-1322b3adbb3b Ancestors: MorphicExtras-hjh.210 tiny refactoring of a bookmorph method =============== Diff against MorphicExtras-hjh.210 =============== Item was changed: ----- Method: BookMorph>>insertPageColored: (in category 'insert and delete') ----- insertPageColored: aColor "Insert a new page for the receiver, using the given color as its background color" + | pageExtent newPage borderWidth backgroundColor | + backgroundColor := currentPage isNil - | sz newPage bw bc | - bc := currentPage isNil ifTrue: + [pageExtent := pageSize. + borderWidth := 0. - [sz := pageSize. - bw := 0. Color blue muchLighter] ifFalse: + [pageExtent := currentPage extent. + borderWidth := currentPage borderWidth. - [sz := currentPage extent. - bw := currentPage borderWidth. currentPage borderColor]. newPagePrototype ifNil: [newPage := (PasteUpMorph new) + extent: pageExtent; - extent: sz; color: aColor. newPage + borderWidth: borderWidth; + borderColor: backgroundColor] - borderWidth: bw; - borderColor: bc] ifNotNil: [newPage := Cursor wait showWhile: [newPagePrototype veryDeepCopy]]. newPage setNameTo: self defaultNameStemForNewPages. newPage vResizeToFit: false. pages isEmpty ifTrue: [pages add: (currentPage := newPage)] ifFalse: [pages add: newPage after: currentPage]. self nextPage!

2 2

Re: [squeak-dev] Cannot rename class vars via Refactoring Tools menu
by Jakob Reschke 01 Oct '17

01 Oct '17

Hi, Just for the record, you can also get halos for the menu item directly, by meta-clicking/blue-clicking a second time on the menu item. It saves you the steps 3-6. In the debug halo menu for the menu item, you will also find an "implementors of" command that will browse the method that would be invoked by the menu item. It does not help in the particular case of the refactoring tools because the selector you are looking for is in the argument, not in the selector. Nevertheless, I think this is a very utile command and I sometimes observe that even experienced Squeak users do not know about it, hence I felt the urge to mention it. :-) Kind regards, Jakob 2017-09-25 18:35 GMT+02:00 sst <ssmith2112(a)outlook.com>: > Thank you very much Marcel for the quick reply and the fix. I had found the > offending method :-) (renameClassVarRefactoring) and was about to make the > fix and post it. > > For those interested in the steps to find the method that was incorrect: > 1. metaclick (to bring up the halos) on the popup menu where you select > 'refactor class var' in the system browser > 2. select the debug icon and select 'explore morph' > 3. expand the submorphs branch > 4. expand the 'refactor class var' branch > 5. expand subMenu > 6. expand submorphs and select the branch 'rename' (this is the menu item > exhibiting the problem) > 7. look at the 'selector' and 'arguments' values - 'arguments' contains the > method name that is exhibiting the problem > 8. use the method finder tool to navigate to renameClassVarRefactoring > 9. now you know where the problem is and can debug the code (but Marcel has > already done this :) > > Cheers, > Steve. > > > > -- > Sent from: http://forum.world.st/Squeak-Dev-f45488.html >

1 0

Jump to page: