Squeak-dev December 2017

squeak-dev@lists.squeakfoundation.org

34 participants
159 discussions

global World cooling
by Nicolas Cellier 07 Dec '17

07 Dec '17

David, Here is what happened last month when trying to do this: WorldWindow test2. Trying to restore image sanity thru emergency evaluator is not for faint hearted... I could not reproduce the problem this month (but the window is not much usable, especially once opened in full screen, the cursor position has an upsetting offset... be prepared to close the image without saving) I presume that not reproducing the emergency is one of the good side effect of reducing global World pressure.

2 1

The Trunk: Tests-nice.387.mcz
by commits＠source.squeak.org 07 Dec '17

07 Dec '17

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.387.mcz ==================== Summary ==================== Name: Tests-nice.387 Author: nice Time: 7 December 2017, 1:02:38.147384 am UUID: 6ba78d9d-9e75-4507-8095-3e6693a32c91 Ancestors: Tests-tpr.386 Fix MCMethodDefinitionTest which was not reentrant The tearDown unregister a working copy of (MCPackage named: 'FooBarBaz'), so the setUp somehow has to recreate it. Otherwise, the tests might start failing at second run. The bug has been identified by Torsten Bergmann and reported on pharo dev mailing list (see thread "Running tests in MCMethodDefinitionTest"). Cherry pick his fix from https://github.com/pharo-project/pharo/pull/583/files, along with a few other cosmetics: - Fix a missing super tearDown. - Classify the unclassified methods. - Comment some classes. - remove an unused ivar TODO: setUp should better call super setUp (even if no-op) =============== Diff against Tests-tpr.386 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! + SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! + SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! - SystemOrganization addCategory: #'Tests-System-Digital Signatures'! - SystemOrganization addCategory: #'Tests-System-Preferences'! Item was changed: + ----- Method: MCDictionaryRepositoryTest>>addVersion: (in category 'actions') ----- - ----- Method: MCDictionaryRepositoryTest>>addVersion: (in category 'as yet unclassified') ----- addVersion: aVersion dict at: aVersion info put: aVersion! Item was changed: + ----- Method: MCDictionaryRepositoryTest>>deleteNode: (in category 'actions') ----- - ----- Method: MCDictionaryRepositoryTest>>deleteNode: (in category 'as yet unclassified') ----- deleteNode: aNode dict removeKey: aNode! Item was changed: + ----- Method: MCDictionaryRepositoryTest>>dictionary (in category 'accessing') ----- - ----- Method: MCDictionaryRepositoryTest>>dictionary (in category 'as yet unclassified') ----- dictionary ^ dict ifNil: [dict := Dictionary new]! Item was changed: + ----- Method: MCDictionaryRepositoryTest>>setUp (in category 'running') ----- - ----- Method: MCDictionaryRepositoryTest>>setUp (in category 'as yet unclassified') ----- setUp repository := MCDictionaryRepository new dictionary: self dictionary! Item was changed: + ----- Method: MCDirectoryRepositoryTest>>addVersion: (in category 'actions') ----- - ----- Method: MCDirectoryRepositoryTest>>addVersion: (in category 'as yet unclassified') ----- addVersion: aVersion | file | file := FileStream newFileNamed: (directory fullNameFor: aVersion fileName). aVersion fileOutOn: file. file close.! Item was changed: + ----- Method: MCDirectoryRepositoryTest>>directory (in category 'accessing') ----- - ----- Method: MCDirectoryRepositoryTest>>directory (in category 'as yet unclassified') ----- directory directory ifNil: [directory := FileDirectory default directoryNamed: 'mctest'. directory assureExistence]. ^ directory! Item was changed: + ----- Method: MCDirectoryRepositoryTest>>setUp (in category 'running') ----- - ----- Method: MCDirectoryRepositoryTest>>setUp (in category 'as yet unclassified') ----- setUp repository := MCDirectoryRepository directory: self directory! Item was changed: + ----- Method: MCDirectoryRepositoryTest>>tearDown (in category 'running') ----- - ----- Method: MCDirectoryRepositoryTest>>tearDown (in category 'as yet unclassified') ----- tearDown super tearDown. self directory recursiveDelete! Item was changed: ----- Method: MCEnvironmentLoadTest>>tearDown (in category 'running') ----- tearDown (environment allClassesAndTraits sorted: [:a :b | (a allSuperclasses includes: b) or: [a name < b name]]) + do: [:each | each removeFromSystem]. + super tearDown! - do: [:each | each removeFromSystem]! Item was changed: + ----- Method: MCInitializationTest>>tearDown (in category 'running') ----- - ----- Method: MCInitializationTest>>tearDown (in category 'as yet unclassified') ----- tearDown super tearDown. (MCWorkingCopy forPackage: self mockPackage) unregister! Item was changed: + ----- Method: MCInitializationTest>>testWorkingCopy (in category 'tests') ----- - ----- Method: MCInitializationTest>>testWorkingCopy (in category 'as yet unclassified') ----- testWorkingCopy MczInstaller storeVersionInfo: self mockVersion. MCWorkingCopy initialize. MCWorkingCopy allManagers detect: [:man | man package name = self mockPackage name] ifNone: [self assert: false]! Item was changed: + ----- Method: MCMczInstallerTest>>assertDict:matchesInfo: (in category 'asserting') ----- - ----- Method: MCMczInstallerTest>>assertDict:matchesInfo: (in category 'as yet unclassified') ----- assertDict: dict matchesInfo: info #(name id message date time author) do: [:sel | (info perform: sel) ifNotNil: [:i | dict at: sel ifPresent: [:d | self assert: i = d]]]. info ancestors with: (dict at: #ancestors) do: [:i :d | self assertDict: d matchesInfo: i]! Item was changed: + ----- Method: MCMczInstallerTest>>assertNoChange (in category 'asserting') ----- - ----- Method: MCMczInstallerTest>>assertNoChange (in category 'as yet unclassified') ----- assertNoChange | actual | actual := MCSnapshotResource takeSnapshot. diff := actual patchRelativeToBase: expected snapshot. self assert: diff isEmpty! Item was changed: + ----- Method: MCMczInstallerTest>>assertVersionInfoPresent (in category 'asserting') ----- - ----- Method: MCMczInstallerTest>>assertVersionInfoPresent (in category 'as yet unclassified') ----- assertVersionInfoPresent | dict info | dict := MczInstaller versionInfo at: self mockPackage name. info := expected info. self assertDict: dict matchesInfo: info.! Item was changed: + ----- Method: MCMczInstallerTest>>defaultTimeout (in category 'accessing') ----- - ----- Method: MCMczInstallerTest>>defaultTimeout (in category 'as yet unclassified') ----- defaultTimeout ^ super defaultTimeout * 10 "seconds"! Item was changed: + ----- Method: MCMczInstallerTest>>deleteFile (in category 'actions') ----- - ----- Method: MCMczInstallerTest>>deleteFile (in category 'as yet unclassified') ----- deleteFile (FileDirectory default fileExists: self fileName) ifTrue: [FileDirectory default deleteFileNamed: self fileName]! Item was changed: + ----- Method: MCMczInstallerTest>>fileName (in category 'accessing') ----- - ----- Method: MCMczInstallerTest>>fileName (in category 'as yet unclassified') ----- fileName ^ 'InstallerTest.mcz' asMCVersionName! Item was changed: + ----- Method: MCMczInstallerTest>>fileStream (in category 'accessing') ----- - ----- Method: MCMczInstallerTest>>fileStream (in category 'as yet unclassified') ----- fileStream ^ FileStream forceNewFileNamed: self fileName.! Item was changed: + ----- Method: MCMczInstallerTest>>setUp (in category 'running') ----- - ----- Method: MCMczInstallerTest>>setUp (in category 'as yet unclassified') ----- setUp expected := self mockVersion. self change: #one toReturn: 2.! Item was changed: + ----- Method: MCMczInstallerTest>>tearDown (in category 'running') ----- - ----- Method: MCMczInstallerTest>>tearDown (in category 'as yet unclassified') ----- tearDown super tearDown. expected snapshot updatePackage: self mockPackage. self deleteFile.! Item was changed: + ----- Method: MCMczInstallerTest>>testInstallFromFile (in category 'testing') ----- - ----- Method: MCMczInstallerTest>>testInstallFromFile (in category 'as yet unclassified') ----- testInstallFromFile MCMczWriter fileOut: expected on: self fileStream. MczInstaller installFileNamed: self fileName. self assertNoChange.! Item was changed: + ----- Method: MCMczInstallerTest>>testInstallFromStream (in category 'testing') ----- - ----- Method: MCMczInstallerTest>>testInstallFromStream (in category 'as yet unclassified') ----- testInstallFromStream | stream | stream := RWBinaryOrTextStream on: String new. MCMczWriter fileOut: expected on: stream. MczInstaller installStream: stream reset. self assertNoChange. self assertVersionInfoPresent. ! Item was changed: MCTestCase subclass: #MCMethodDefinitionTest + instanceVariableNames: 'navigation isModified overrideTimestamp extensionPackage' - instanceVariableNames: 'navigation isModified overrideTimestamp' classVariableNames: '' poolDictionaries: '' category: 'Tests-Monticello'! Item was changed: ----- Method: MCMethodDefinitionTest>>setUp (in category 'running') ----- setUp + extensionPackage := (MCWorkingCopy forPackage: (MCPackage named: 'FooBarBaz')). - navigation := (Smalltalk hasClassNamed: #SystemNavigation) ifTrue: [(Smalltalk at: #SystemNavigation) new] ifFalse: [Smalltalk]. isModified := self ownPackage modified. overrideTimestamp := (self class >> #override) timeStamp! Item was changed: ----- Method: MCMethodDefinitionTest>>tearDown (in category 'running') ----- tearDown self restoreMocks. + extensionPackage unregister. + extensionPackage := nil. - (MCWorkingCopy forPackage: (MCPackage named: 'FooBarBaz')) unregister. MCMockPackageInfo new mcPackage workingCopy unregister. self class compile: 'override ^ 1' classified: 'mocks' withStamp: overrideTimestamp notifying: nil. SystemOrganizer default removeEmptyCategories. self ownPackage modified: isModified. super tearDown ! Item was changed: + ----- Method: MCOrganizationTest>>testReordering (in category 'testing') ----- - ----- Method: MCOrganizationTest>>testReordering (in category 'as yet unclassified') ----- testReordering |dec cats newCats | dec := MCOrganizationDefinition categories: #(A B C). cats := #(X Y B Z C A Q). newCats := dec reorderCategories: cats original: #(B C A). self assert: newCats asArray = #(X Y A B C Z Q).! Item was changed: + ----- Method: MCOrganizationTest>>testReorderingWithNoCategoriesInVersion (in category 'testing') ----- - ----- Method: MCOrganizationTest>>testReorderingWithNoCategoriesInVersion (in category 'as yet unclassified') ----- testReorderingWithNoCategoriesInVersion |dec cats newCats | dec := MCOrganizationDefinition categories: #(). cats := #(X Y B Z C A Q). newCats := dec reorderCategories: cats original: #(). self assert: newCats asArray = cats.! Item was changed: + ----- Method: MCOrganizationTest>>testReorderingWithRemovals (in category 'testing') ----- - ----- Method: MCOrganizationTest>>testReorderingWithRemovals (in category 'as yet unclassified') ----- testReorderingWithRemovals |dec cats newCats | dec := MCOrganizationDefinition categories: #(A B C). cats := #(X Y B Z C A Q). newCats := dec reorderCategories: cats original: #(Y B C A Q). self assert: newCats asArray = #(X A B C Z).! Item was changed: + ----- Method: MCPatchTest>>setUp (in category 'running') ----- - ----- Method: MCPatchTest>>setUp (in category 'as yet unclassified') ----- setUp |rev1 rev2| rev1 := MCSnapshotResource takeSnapshot. self change: #one toReturn: 2. rev2 := MCSnapshotResource takeSnapshot. patch := rev2 patchRelativeToBase: rev1. self change: #one toReturn: 1.! Item was changed: + ----- Method: MCPatchTest>>tearDown (in category 'running') ----- - ----- Method: MCPatchTest>>tearDown (in category 'as yet unclassified') ----- tearDown super tearDown. self restoreMocks! Item was changed: + ----- Method: MCPatchTest>>testPatchContents (in category 'testing') ----- - ----- Method: MCPatchTest>>testPatchContents (in category 'as yet unclassified') ----- testPatchContents self assert: patch operations size = 1. self assert: patch operations first isModification. self assert: patch operations first definition selector = #one. ! Item was changed: MCTestCase subclass: #MCRepositoryTest + instanceVariableNames: 'repository' - instanceVariableNames: 'repository ancestors' classVariableNames: '' poolDictionaries: '' category: 'Tests-Monticello'! + + !MCRepositoryTest commentStamp: 'nice 12/7/2017 00:08' prior: 0! + Abstract superclass for Monticello Repository tests + + Instance Variables + repository: <MCRepository> + + repository + - the instance of MCRepository subclass being tested + ! Item was changed: + ----- Method: MCSnapshotResource>>definitions (in category 'accessing') ----- - ----- Method: MCSnapshotResource>>definitions (in category 'as yet unclassified') ----- definitions ^ snapshot definitions! Item was changed: + ----- Method: MCSnapshotResource>>setUp (in category 'running') ----- - ----- Method: MCSnapshotResource>>setUp (in category 'as yet unclassified') ----- setUp snapshot := self class takeSnapshot.! Item was changed: + ----- Method: MCSnapshotResource>>snapshot (in category 'accessing') ----- - ----- Method: MCSnapshotResource>>snapshot (in category 'as yet unclassified') ----- snapshot ^ snapshot! Item was changed: + ----- Method: MCStReaderTest>>commentWithStyle (in category 'accessing') ----- - ----- Method: MCStReaderTest>>commentWithStyle (in category 'as yet unclassified') ----- commentWithStyle ^ '!!AEDesc commentStamp: ''<historical>'' prior: 0!! I represent an Apple Event Descriptor. I am a low-level representation of Apple Event (and hence Applescript) information. For further Information, see Apple''s Inside Macintosh: Interapplication Communications, at http://developer.apple.com/techpubs/mac/IAC/IAC-2.html. Essentially, I represent a record comprising a one-word "string" (treating the word as fourbyte characters) representing a data type, followed by a pointer to a pointer (a handle) to the data I represent. Care must be taken to assure that the Handle data is disposed after use, or memory leaks result. At this time, I make no effort to do this automatically through finalization.!! ]style[(218 54 384)f1,f1Rhttp://developer.apple.com/techpubs/mac/IAC/IAC-2.html;,f1!! '! Item was changed: + ----- Method: MCStReaderTest>>commentWithoutStyle (in category 'accessing') ----- - ----- Method: MCStReaderTest>>commentWithoutStyle (in category 'as yet unclassified') ----- commentWithoutStyle ^ ' CharacterScanner subclass: #CanvasCharacterScanner instanceVariableNames: ''canvas fillBlt foregroundColor runX lineY '' classVariableNames: '''' poolDictionaries: '''' category: ''Morphic-Support''!! !!CanvasCharacterScanner commentStamp: ''<historical>'' prior: 0!! A displaying scanner which draws its output to a Morphic canvas.!! !!CanvasCharacterScanner methodsFor: ''stop conditions'' stamp: ''ar 12/15/2001 23:27''!! setStopConditions "Set the font and the stop conditions for the current run." self setFont. stopConditions at: Space asciiValue + 1 put: (alignment = Justified ifTrue: [#paddedSpace])!! !!'! Item was changed: + ----- Method: MCStReaderTest>>methodWithStyle (in category 'accessing') ----- - ----- Method: MCStReaderTest>>methodWithStyle (in category 'as yet unclassified') ----- methodWithStyle ^ '!!EventHandler methodsFor: ''copying'' stamp: ''tk 1/22/2001 17:39''!! veryDeepInner: deepCopier "ALL fields are weakly copied. Can''t duplicate an object by duplicating a button that activates it. See DeepCopier." super veryDeepInner: deepCopier. "just keep old pointers to all fields" clickRecipient := clickRecipient.!! ]style[(25 108 10 111)f1b,f1,f1LDeepCopier Comment;,f1!! !! '! Item was changed: + ----- Method: MCStReaderTest>>testCommentWithStyle (in category 'tests') ----- - ----- Method: MCStReaderTest>>testCommentWithStyle (in category 'as yet unclassified') ----- testCommentWithStyle | reader | reader := MCStReader on: self commentWithStyle readStream. reader definitions! Item was changed: + ----- Method: MCStReaderTest>>testCommentWithoutStyle (in category 'tests') ----- - ----- Method: MCStReaderTest>>testCommentWithoutStyle (in category 'as yet unclassified') ----- testCommentWithoutStyle | reader | reader := MCStReader on: self commentWithoutStyle readStream. self assert: (reader definitions anySatisfy: [:ea | ea isMethodDefinition]).! Item was changed: + ----- Method: MCStReaderTest>>testMethodWithStyle (in category 'tests') ----- - ----- Method: MCStReaderTest>>testMethodWithStyle (in category 'as yet unclassified') ----- testMethodWithStyle | reader | reader := MCStReader on: self methodWithStyle readStream. self assert: reader definitions first isMethodDefinition.! Item was changed: TestCase subclass: #MCTestCase instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Tests-Monticello'! + + !MCTestCase commentStamp: 'nice 12/7/2017 00:11' prior: 0! + Abstract superclass for Monticello tests + Monticello is the distributed source code management system.! Item was changed: + ----- Method: MCVersionNameTest>>allValidFixtures (in category 'accessing') ----- - ----- Method: MCVersionNameTest>>allValidFixtures (in category 'as yet unclassified') ----- allValidFixtures ^ self standardFixtures , (self diffyFixtures pairsCollect: [:diffy :base | diffy])! Item was changed: + ----- Method: MCVersionNameTest>>diffyBranchFixtures (in category 'accessing') ----- - ----- Method: MCVersionNameTest>>diffyBranchFixtures (in category 'as yet unclassified') ----- diffyBranchFixtures ^ #( 'Package.branch-author.123(origAuthor.122)' 'Package.branch-origAuthor.122' 'Package.branch-author.123(origAuthor.122).mcd' 'Package.branch-origAuthor.122.mcd' 'Package.branch-author.123(122)' 'Package.branch-author.122' 'Package.branch-author.123((a)origPackage-origAuthor.122)' 'origPackage-origAuthor.122' 'Package-author.123((a)origPackage.branch-origAuthor.122)' 'origPackage.branch-origAuthor.122' ) collect: [ : each | each asMCVersionName ]! Item was changed: + ----- Method: MCVersionNameTest>>diffyFixtures (in category 'accessing') ----- - ----- Method: MCVersionNameTest>>diffyFixtures (in category 'as yet unclassified') ----- diffyFixtures ^ #( 'Package-author.123(origAuthor.122)' 'Package-origAuthor.122' 'Package-author.123(origAuthor.122).mcd' 'Package-origAuthor.122.mcd' 'Package-author.123(122)' 'Package-author.122' 'Package-author.123((a)origPackage-origAuthor.122)' 'origPackage-origAuthor.122' ) collect: [ : each | each asMCVersionName ]! Item was changed: + ----- Method: MCVersionNameTest>>invalidFixtures (in category 'accessing') ----- - ----- Method: MCVersionNameTest>>invalidFixtures (in category 'as yet unclassified') ----- invalidFixtures ^ {String empty. 'abc'. '123' } collect: [ : each | each asMCVersionName ]! Item was changed: + ----- Method: MCVersionNameTest>>standardFixtures (in category 'accessing') ----- - ----- Method: MCVersionNameTest>>standardFixtures (in category 'as yet unclassified') ----- standardFixtures ^ #('Package-author.123' 'Package-author.123.mcz' ) collect: [ : each | each asMCVersionName ]! Item was changed: + ----- Method: MCVersionNameTest>>verifyDiffy:base: (in category 'tests') ----- - ----- Method: MCVersionNameTest>>verifyDiffy:base: (in category 'as yet unclassified') ----- verifyDiffy: diffyMCVersionName base: expectedBaseMCVersionName self assert: diffyMCVersionName baseVersionName = expectedBaseMCVersionName! Item was changed: + ----- Method: MCVersionNameTest>>verifyPackageAuthorVersion: (in category 'tests') ----- - ----- Method: MCVersionNameTest>>verifyPackageAuthorVersion: (in category 'as yet unclassified') ----- verifyPackageAuthorVersion: aMCFileName self assert: aMCFileName versionName = 'Package-author.123'; assert: aMCFileName packageName = 'Package' ; assert: aMCFileName versionNumber = 123 ; assert: aMCFileName author = 'author' ; assert: aMCFileName isValid!

1 0

The Trunk: Files-nice.175.mcz
by commits＠source.squeak.org 06 Dec '17

06 Dec '17

Nicolas Cellier uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-nice.175.mcz ==================== Summary ==================== Name: Files-nice.175 Author: nice Time: 6 December 2017, 11:06:36.405817 pm UUID: f8c4858f-bd11-425d-86e7-32e4f353f43d Ancestors: Files-tpr.174 Workaround for truncated readOnlyCopy of .changes log file on linux. On linux, the latest bytes written to the change log are not allways taken into account when we create a readOnlyCopy. The readOnlyCopy then appear as truncated. This can cause an infinite loop in MCMockPackageInfo(PackageInfo)>>changeRecordForOverriddenMethod: See https://github.com/hpi-swa/smalltalkCI/issues/350 =============== Diff against Files-tpr.174 =============== Item was changed: ----- Method: StandardFileStream>>readOnlyCopy (in category 'read, write, position') ----- readOnlyCopy + self flush. "Some linux open a truncated readOnlyCopy. Force it to take latest bytes written into account." - ^ self class readOnlyFileNamed: self name. !

1 0

Etoys inbox
by David T. Lewis 06 Dec '17

06 Dec '17

There is a set of nine updates in the inbox for Etoys, provided by Jens Lincke last year, that appear to all be related updates and fixes for Kedama. Is there any reason not to move these to trunk and merge into Etoys? Dave

3 5

Publishing Fix for SVGMorph
by Beckmann, Tom 06 Dec '17

06 Dec '17

Hello everyone, is there currently a way for me to publish a small fix for the SVGMorph [1]? I already tried signing up on map.squeak.org to figure out the way from there, but the confirmation mail never arrived. Thanks in advance! Tom [1]: http://map.squeak.org/sm/packagebyname/svgmorph

2 1

source.squeak.org timeouts
by David T. Lewis 05 Dec '17

05 Dec '17

After confirming that they have been merged to Etoys trunk, I was in the process of mov EToys-jl.210, EToys-jl.222, EToys-jl.223, EToys-jl.224, EToys-jl.225, EToys-jl.226, EToys-jl.230, EToys-jl.231, and EToys-jl.235 from the inbox to the treated inbox, using the web interface to source.squeak.org. I was able to move several of these, but response times and timeouts on squeak.source.com seemed to get progressively worse as I proceeded. Right now, the web interface is timing out for me on most operations, and I cannot do anything further with respect to moving the files. Most likely the server will come back to normal in its own good time, but if not, this note is to explain what was happening that led up the the problem. Dave

1 0

The Trunk: Graphics-mt.388.mcz
by commits＠source.squeak.org 05 Dec '17

05 Dec '17

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.388.mcz ==================== Summary ==================== Name: Graphics-mt.388 Author: mt Time: 5 December 2017, 7:44:18.464667 am UUID: c4dbc715-98d3-ea4d-9837-df2ebd8f6b18 Ancestors: Graphics-mt.387 Addition to last commit. Due to the "self depth" call the previous change did not reach into #scaledIntoFormOfSize:smoothing:. *sigh* =============== Diff against Graphics-mt.387 =============== Item was added: + ----- Method: ColorForm>>scaledIntoFormOfSize:smoothing: (in category 'scaling, rotation') ----- + scaledIntoFormOfSize: aNumberOrPoint smoothing: factor + + ^ (self asFormOfDepth: 32) scaledIntoFormOfSize: aNumberOrPoint smoothing: factor!

1 0

The Trunk: Graphics-mt.387.mcz
by commits＠source.squeak.org 05 Dec '17

05 Dec '17

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.387.mcz ==================== Summary ==================== Name: Graphics-mt.387 Author: mt Time: 5 December 2017, 7:39:11.735052 am UUID: d672e9af-b20d-284b-9e54-799643bcd0ee Ancestors: Graphics-pre.386 Updates workaround to fix broken colors after scaling color(-palette) forms. =============== Diff against Graphics-pre.386 =============== Item was removed: - ----- Method: ColorForm>>scaledToSize: (in category 'scaling, rotation') ----- - scaledToSize: newExtent - - "super method did not seem to work so well on ColorForms" - - ^(self asFormOfDepth: 16) scaledToSize: newExtent! Item was added: + ----- Method: ColorForm>>scaledToSize:smoothing: (in category 'scaling, rotation') ----- + scaledToSize: newExtent smoothing: factor + "super method did not seem to work so well on ColorForms" + + ^(self asFormOfDepth: 32) scaledToSize: newExtent smoothing: factor!

1 0

The Trunk: Network-nice.212.mcz
by commits＠source.squeak.org 02 Dec '17

02 Dec '17

Nicolas Cellier uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-nice.212.mcz ==================== Summary ==================== Name: Network-nice.212 Author: nice Time: 2 December 2017, 10:29:23.48884 pm UUID: be2cd95d-5a11-437a-9014-2de33fdbe2bc Ancestors: Network-pre.211 Remove remnant methods from MailComposition now that it has been refactored (Tool-builder-ized and using a MailMessage instance) =============== Diff against Network-pre.211 =============== Item was removed: - ----- Method: MailComposition>>menuGet:shifted: (in category 'interface') ----- - menuGet: aMenu shifted: shifted - - aMenu addList: { - {'find...(f)' translated. #find}. - {'find selection again (g)' translated. #findAgain}. - #-. - {'accept (s)' translated. #accept}. - {'send message' translated. #submit}}. - - ^aMenu.! Item was removed: - ----- Method: MailComposition>>submit (in category 'access') ----- - submit - | message | - "submit the message" - textEditor - ifNotNil: [self hasUnacceptedEdits ifTrue: [textEditor accept]]. - message := MailMessage from: messageText asString. - self breakLinesInMessage: message. - SMTPClient deliverMailFrom: message from to: (Array with: message to) text: message text usingServer: self smtpServer. - - morphicWindow ifNotNil: [morphicWindow delete]. - mvcWindow ifNotNil: [mvcWindow controller close]!

1 0

The Trunk: Network-pre.207.mcz
by commits＠source.squeak.org 02 Dec '17

02 Dec '17

Patrick Rein uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-pre.207.mcz ==================== Summary ==================== Name: Network-pre.207 Author: pre Time: 10 November 2017, 4:40:14.388812 pm UUID: 85f492c1-3470-bb43-afe5-bea036995824 Ancestors: Network-pre.206 A new MailComposition window allowing a more structured access to the underlying mail message. =============== Diff against Network-pre.206 =============== Item was changed: Model subclass: #MailComposition + instanceVariableNames: 'mailMessage' - instanceVariableNames: 'messageText textEditor morphicWindow mvcWindow' classVariableNames: '' poolDictionaries: '' category: 'Network-MailSending'! + !MailComposition commentStamp: 'pre 5/16/2017 20:00' prior: 0! + a message being composed in a fancy way. The mail is send via the registered MailSender by default. Fields do not have to be saved, they are saved automatically on send. ! - !MailComposition commentStamp: '<historical>' prior: 0! - a message being composed. When finished, it will be submitted via a Celeste.! Item was changed: + ----- Method: MailComposition class>>initialize (in category 'class initialization') ----- - ----- Method: MailComposition class>>initialize (in category 'instance creation') ----- initialize + + MailSender register: self ! - super initialize. - MailSender register: self.! Item was added: + ----- Method: MailComposition class>>open (in category 'opening') ----- + open + + ^ ToolBuilder default open: self! Item was added: + ----- Method: MailComposition class>>openOn: (in category 'opening') ----- + openOn: aMessage + + ^ ToolBuilder default open: (self new on: aMessage; yourself)! Item was changed: + ----- Method: MailComposition class>>sendMailMessage: (in category 'MailSender interface') ----- + sendMailMessage: aMessage + + self openOn: aMessage! - ----- Method: MailComposition class>>sendMailMessage: (in category 'instance creation') ----- - sendMailMessage: aMailMessage - | newComposition | - newComposition := self new. - newComposition messageText: aMailMessage text; open! Item was changed: + ----- Method: MailComposition class>>unload (in category 'initialize-release') ----- - ----- Method: MailComposition class>>unload (in category 'instance creation') ----- unload MailSender unregister: self ! Item was added: + ----- Method: MailComposition>>addAttachment (in category 'actions') ----- + addAttachment + | file fileResult fileName | + + self saveFields. + + (fileResult := StandardFileMenu oldFile) + ifNotNil: + [fileName := fileResult directory fullNameFor: fileResult name. + file := FileStream readOnlyFileNamed: fileName. + file ifNotNil: + [file binary. + mailMessage addAttachmentFrom: file withName: fileResult name. + file close. + self changed: #messageText]] ! Item was added: + ----- Method: MailComposition>>addAttachmentButtonLabel (in category 'ui constants') ----- + addAttachmentButtonLabel + + ^ 'add attachment' translated! Item was added: + ----- Method: MailComposition>>bccLabel (in category 'ui constants') ----- + bccLabel + + ^ 'BCC' translated! Item was added: + ----- Method: MailComposition>>buildButtonBarSpecWith: (in category 'toolbuilder') ----- + buildButtonBarSpecWith: aBuilder + + | buttonBarSpec | + buttonBarSpec := aBuilder pluggablePanelSpec new + children: OrderedCollection new; + layout: #horizontal; + frame: (LayoutFrame new + leftFraction: 0 offset: 0; + topFraction: 0 offset: 0; + rightFraction: 1 offset: 0; + bottomFraction: 0 offset: self buttonBarHeight); + yourself. + + buttonBarSpec children add: (aBuilder pluggableButtonSpec new + model: self; + action: #sendMail; + label: #sendMailButtonLabel; + yourself). + + buttonBarSpec children add: (aBuilder pluggableButtonSpec new + model: self; + action: #addAttachment; + label: #addAttachmentButtonLabel; + yourself). + + buttonBarSpec children add: (aBuilder pluggableButtonSpec new + model: self; + action: #removeAttachment; + label: #removeAttachmentButtonLabel; + yourself). + + ^ buttonBarSpec! Item was added: + ----- Method: MailComposition>>buildWith: (in category 'toolbuilder') ----- + buildWith: aBuilder + + | windowSpec detailsPanelSpec textSpec | + + windowSpec := aBuilder pluggableWindowSpec new + model: self; + label: self dialogTitle; + children: OrderedCollection new. + + windowSpec children add: (self buildButtonBarSpecWith: aBuilder). + + detailsPanelSpec := aBuilder pluggablePanelSpec new + children: OrderedCollection new; + layout: #vertical; + yourself. + windowSpec children add: detailsPanelSpec. + + self createDetailsFieldsIn: detailsPanelSpec by: aBuilder. + + detailsPanelSpec children: detailsPanelSpec children reversed. + detailsPanelSpec frame: (LayoutFrame new + leftFraction: 0 offset: 0; + topFraction: 0 offset: self buttonBarHeight; + rightFraction: 1 offset: 0; + bottomFraction: 0 offset: self buttonBarHeight + (detailsPanelSpec children size * self lineHeight)). + + textSpec := aBuilder pluggableTextSpec new + model: self; + indicateUnacceptedChanges: true; + getText: #messageText; + setText: #messageText:; + frame: (LayoutFrame new + leftFraction: 0 offset: 0; + topFraction: 0 offset: self buttonBarHeight + (detailsPanelSpec children size * self lineHeight); + rightFraction: 1 offset: 0; + bottomFraction: 1 offset: 0); + yourself. + windowSpec children add: textSpec. + + ^ aBuilder build: windowSpec! Item was added: + ----- Method: MailComposition>>buttonBarHeight (in category 'ui constants') ----- + buttonBarHeight + + ^ 25 "pixel"! Item was added: + ----- Method: MailComposition>>ccLabel (in category 'ui constants') ----- + ccLabel + + ^ 'CC' translated! Item was added: + ----- Method: MailComposition>>createDetailsFieldsIn:by: (in category 'toolbuilder') ----- + createDetailsFieldsIn: detailsPanelSpec by: aBuilder + + #((senderLabel messageSender messageSender:) + (recipientLabel messageRecipient messageRecipient:) + (ccLabel messageCC messageCC:) + (bccLabel messageBCC messageBCC:) + (subjectLabel messageSubject messageSubject:)) + do: [:config | detailsPanelSpec children add: + (self createFieldInputNamed: config first + getter: config second + setter: config third + with: aBuilder)] + ! Item was added: + ----- Method: MailComposition>>createFieldInputNamed:getter:setter:with: (in category 'toolbuilder') ----- + createFieldInputNamed: fieldLabelGetter getter: fieldGetter setter: fieldSetter with: aBuilder + + ^ aBuilder pluggableInputFieldSpec new + model: self; + indicateUnacceptedChanges: false; + getText: fieldGetter; + setText: fieldSetter; + frame: (LayoutFrame new + leftFraction: 0 offset: 0; + topFraction: 0 offset: 0; + rightFraction: 1 offset: 0; + bottomFraction: 0 offset: self lineHeight); + help: fieldLabelGetter; + yourself! Item was added: + ----- Method: MailComposition>>dialogTitle (in category 'toolbuilder') ----- + dialogTitle + + ^ 'mail editor' translated! Item was added: + ----- Method: MailComposition>>doSendMail (in category 'private') ----- + doSendMail + + (SMTPClient openOnHostNamed: self smtpServer port: self smtpServerPort) + user: self smtpUser; + password: self smtpPassword; + login; + mailFrom: mailMessage from to: (mailMessage to findTokens: ',') text: mailMessage asSendableText.! Item was added: + ----- Method: MailComposition>>initialize (in category 'initialize-release') ----- + initialize + + mailMessage := MailMessage empty! Item was added: + ----- Method: MailComposition>>lineHeight (in category 'ui constants') ----- + lineHeight + + ^ 25 "pixel"! Item was added: + ----- Method: MailComposition>>messageBCC (in category 'access to mail object') ----- + messageBCC + + ^ mailMessage bcc! Item was added: + ----- Method: MailComposition>>messageBCC: (in category 'access to mail object') ----- + messageBCC: emailAddresses + + self flag: #TODO. "add validation" + mailMessage bcc: emailAddresses asString. + ^ true! Item was added: + ----- Method: MailComposition>>messageCC (in category 'access to mail object') ----- + messageCC + + ^ mailMessage cc! Item was added: + ----- Method: MailComposition>>messageCC: (in category 'access to mail object') ----- + messageCC: emailAddresses + + self flag: #TODO. "add validation" + mailMessage cc: emailAddresses asString. + ^ true! Item was added: + ----- Method: MailComposition>>messageRecipient (in category 'access to mail object') ----- + messageRecipient + + ^ mailMessage to! Item was added: + ----- Method: MailComposition>>messageRecipient: (in category 'access to mail object') ----- + messageRecipient: emailAddresses + + self flag: #TODO. "add validation" + mailMessage to: emailAddresses asString. + ^ true! Item was added: + ----- Method: MailComposition>>messageSender (in category 'access to mail object') ----- + messageSender + + ^ mailMessage from! Item was added: + ----- Method: MailComposition>>messageSender: (in category 'access to mail object') ----- + messageSender: emailAddress + + self flag: #TODO. "add validation" + mailMessage from: emailAddress asString. + ^ true! Item was added: + ----- Method: MailComposition>>messageSubject (in category 'access to mail object') ----- + messageSubject + + ^ mailMessage subject! Item was added: + ----- Method: MailComposition>>messageSubject: (in category 'access to mail object') ----- + messageSubject: aSubject + + self flag: #TODO. "add validation" + mailMessage subject: aSubject asString. + ^ true! Item was changed: + ----- Method: MailComposition>>messageText (in category 'access to mail object') ----- - ----- Method: MailComposition>>messageText (in category 'access') ----- messageText + + ^ mailMessage bodyTextFormatted! - "return the current text" - ^messageText. - ! Item was changed: + ----- Method: MailComposition>>messageText: (in category 'access to mail object') ----- - ----- Method: MailComposition>>messageText: (in category 'access') ----- messageText: aText + + mailMessage body: ((MIMEDocument + contentType: MIMEDocument contentTypePlainText + content: aText asString) + charset: 'UTF-8'; + yourself). + ^ true! - "change the current text" - messageText := aText. - self changed: #messageText. - ^true! Item was added: + ----- Method: MailComposition>>on: (in category 'initialize-release') ----- + on: aMessage + + mailMessage := aMessage! Item was added: + ----- Method: MailComposition>>recipientLabel (in category 'ui constants') ----- + recipientLabel + + ^ 'Recipients' translated! Item was added: + ----- Method: MailComposition>>removeAttachment (in category 'actions') ----- + removeAttachment + + | attachmentToBeRemoved | + + self saveFields. + attachmentToBeRemoved := UIManager default + chooseFrom: (mailMessage attachments collect: [:m | m attachmentFileName ]) + values: mailMessage attachments + title: 'Choose attachment to be removed' translated. + mailMessage removeAttachment: attachmentToBeRemoved. + self changed: #messageText.! Item was added: + ----- Method: MailComposition>>removeAttachmentButtonLabel (in category 'ui constants') ----- + removeAttachmentButtonLabel + + ^ 'remove attachment' translated! Item was added: + ----- Method: MailComposition>>saveFields (in category 'private') ----- + saveFields + + (self dependents select: [:d | d hasUnacceptedEdits]) do: [:d | d accept].! Item was added: + ----- Method: MailComposition>>sendMail (in category 'actions') ----- + sendMail + + self saveFields. + + [self doSendMail. + Project current addDeferredUIMessage: [self changed: #close]] + forkAt: 30! Item was added: + ----- Method: MailComposition>>sendMailButtonLabel (in category 'ui constants') ----- + sendMailButtonLabel + + ^ 'send mail' translated! Item was added: + ----- Method: MailComposition>>senderLabel (in category 'ui constants') ----- + senderLabel + + ^ 'Sender' translated! Item was added: + ----- Method: MailComposition>>smtpPassword (in category 'MailSender interface') ----- + smtpPassword + + ^ MailSender userPassword! Item was changed: + ----- Method: MailComposition>>smtpServer (in category 'MailSender interface') ----- - ----- Method: MailComposition>>smtpServer (in category 'access') ----- smtpServer + + ^ MailSender smtpServer! - ^MailSender smtpServer! Item was added: + ----- Method: MailComposition>>smtpServerPort (in category 'MailSender interface') ----- + smtpServerPort + + ^ MailSender smtpServerPort! Item was added: + ----- Method: MailComposition>>smtpUser (in category 'MailSender interface') ----- + smtpUser + + ^ MailSender userName! Item was added: + ----- Method: MailComposition>>subjectLabel (in category 'ui constants') ----- + subjectLabel + + ^ 'Subject' translated!

2 2

Jump to page: