Squeak-dev April 2017

squeak-dev@lists.squeakfoundation.org

48 participants
221 discussions

The Trunk: Squeak-Version-nice.4730.mcz
by commits＠source.squeak.org 08 Apr '17

08 Apr '17

Nicolas Cellier uploaded a new version of Squeak-Version to project The Trunk: http://source.squeak.org/trunk/Squeak-Version-nice.4730.mcz ==================== Summary ==================== Name: Squeak-Version-nice.4730 Author: nice Time: 8 April 2017, 8:17:12.852754 pm UUID: 315565ef-844e-45b0-8397-057caca5875a Ancestors: Squeak-Version-nice.4729 Make the MethodContext -> Context transition hack more robust post removal of ContextPart. =============== Diff against Squeak-Version-nice.4729 =============== Item was changed: (PackageInfo named: 'Squeak-Version') preamble: '"This is a hack to finalize #MethodContext -> Context renaming. The #bootstrapContext left two problems: 1) there is a binding #MethodContext => Context. 2) ContextPart still think it has Context as subclass, though this one changed its superclass. We must make sure that the removal of these class won''t destroy Context." Smalltalk globals unbind: #MethodContext. [Undeclared at: #MethodContext put: Context copy] on: AttemptToWriteReadOnlyGlobal do: [:exc | exc resume: true]. + ContextPart ifNil: [^self]. + ContextPart isBehavior ifFalse: [^self]. ContextPart instVarAt: 6 put: (ContextPart subclasses select: [:e | e superclass = ContextPart]) '!

1 0

The Trunk: Squeak-Version-nice.4729.mcz
by commits＠source.squeak.org 08 Apr '17

08 Apr '17

Nicolas Cellier uploaded a new version of Squeak-Version to project The Trunk: http://source.squeak.org/trunk/Squeak-Version-nice.4729.mcz ==================== Summary ==================== Name: Squeak-Version-nice.4729 Author: nice Time: 8 April 2017, 5:51:06.804061 pm UUID: 9bfa711b-9085-4017-bf05-9472a75394a9 Ancestors: Squeak-Version-nice.4728 Renew the hack for restoring updateStream again (see preamble script). This time move #MethodContext binding in Undeclared. =============== Diff against Squeak-Version-nice.4728 =============== Item was changed: (PackageInfo named: 'Squeak-Version') preamble: '"This is a hack to finalize #MethodContext -> Context renaming. The #bootstrapContext left two problems: 1) there is a binding #MethodContext => Context. 2) ContextPart still think it has Context as subclass, though this one changed its superclass. We must make sure that the removal of these class won''t destroy Context." + Smalltalk globals unbind: #MethodContext. + [Undeclared at: #MethodContext put: Context copy] on: AttemptToWriteReadOnlyGlobal do: [:exc | exc resume: true]. - [Smalltalk globals at: #MethodContext put: Context copy] on: AttemptToWriteReadOnlyGlobal do: [:exc | exc resume: true]. ContextPart instVarAt: 6 put: (ContextPart subclasses select: [:e | e superclass = ContextPart]) '!

2 1

The Trunk: Squeak-Version-nice.4728.mcz
by commits＠source.squeak.org 08 Apr '17

08 Apr '17

Nicolas Cellier uploaded a new version of Squeak-Version to project The Trunk: http://source.squeak.org/trunk/Squeak-Version-nice.4728.mcz ==================== Summary ==================== Name: Squeak-Version-nice.4728 Author: nice Time: 8 April 2017, 4:45:37.353368 pm UUID: 4a448a44-03bd-43c3-9a5e-752ab51ae8f9 Ancestors: Squeak-Version-nice.4727 Renew the hack for restoring the update process. =============== Diff against Squeak-Version-nice.4727 =============== Item was changed: + (PackageInfo named: 'Squeak-Version') preamble: '"This is a hack to finalize #MethodContext -> Context renaming. + The #bootstrapContext left two problems: + 1) there is a binding #MethodContext => Context. + 2) ContextPart still think it has Context as subclass, though this one changed its superclass. + We must make sure that the removal of these class won''t destroy Context." - (PackageInfo named: 'Squeak-Version') preamble: '"This is a hack to make sure that #MethodContext keys vanished from Undeclared before loading Kernel-eem.1078. - Otherwise, the Undeclared binding points to Context after the rename that occured in bootstrapContext, and Context will be removed when attempting to remove MethodContext." + [Smalltalk globals at: #MethodContext put: Context copy] on: AttemptToWriteReadOnlyGlobal do: [:exc | exc resume: true]. + + ContextPart instVarAt: 6 put: (ContextPart subclasses select: [:e | e superclass = ContextPart]) - Smalltalk garbageCollect. - Smalltalk garbageCollect. '!

1 0

The Trunk: MonticelloConfigurations-nice.151.mcz
by commits＠source.squeak.org 08 Apr '17

08 Apr '17

Nicolas Cellier uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-nice.151.mcz ==================== Summary ==================== Name: MonticelloConfigurations-nice.151 Author: nice Time: 8 April 2017, 1:53:22.973832 pm UUID: ef900bfc-3db9-4ffa-80b6-85e05ae320bd Ancestors: MonticelloConfigurations-ul.150 Duplicate a few methods with an additional (upTo: versionNumber) parameter, so as to be able to write convenient things like: MCMcmUpdater default doUpdateUpTo: 406. This would require better refactoring rather than duplication, but I want to experiment fast for restoring the update process fast. =============== Diff against MonticelloConfigurations-ul.150 =============== Item was added: + ----- Method: MCMcmUpdater>>doUpdate:upTo: (in category 'updating') ----- + doUpdate: interactive upTo: versionNumber + "Update the image by loading all pending updates from the server. If this is + the default updater for the system, update the system version when complete. + If interteractive use a modal notifier, otherwise only update the transcript. + Flush all caches. If a previous download failed this is often helpful" + + | config previousUpdateLevel | + previousUpdateLevel := SystemVersion current highestUpdate. + MCFileBasedRepository flushAllCaches. + config := self updateFromRepositories: { self repository } upTo: versionNumber. + config ifNil: [ + interactive ifTrue: [ ^self inform: 'Unable to retrieve updates from remote repository.' translated ]. + Transcript cr; show: '========== Unable to retrieve updates from remote repository. ==========' translated; cr. + ^ self ]. + MCMcmUpdater default == self + ifTrue: [ + config setSystemVersion. + interactive ifTrue: [ + self inform: ('Update completed.\\Version: {1}\Update: {3}{2}\\Url: {4}\Map: ''{5}''{6}' translated withCRs format: { + SystemVersion current version. + SystemVersion current highestUpdate. + previousUpdateLevel = SystemVersion current highestUpdate + ifTrue: [''] + ifFalse: [previousUpdateLevel asString, ' -> ']. + self repository. + MCMcmUpdater updateMapName. + SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | String cr, String cr, d]})]. + Transcript cr; + show: '========== Update completed: ' translated; + show: previousUpdateLevel; + show: ' -> ' ; + show: SystemVersion current highestUpdate; + show: ' =========='; cr ] + ifFalse: [ + interactive + ifTrue: [ self inform: 'Update completed.' ]. + Transcript cr; show: '========== Update completed. ==========' translated; cr ] + ! Item was added: + ----- Method: MCMcmUpdater>>doUpdateUpTo: (in category 'updating') ----- + doUpdateUpTo: versionNumber + "Update the image by loading all pending updates from the server. If this is + the default updater for the system, update the system version when complete. + Flush all caches. If a previous download failed this is often helpful" + + ^self doUpdate: true upTo: versionNumber + ! Item was added: + ----- Method: MCMcmUpdater>>updateFromRepositories:upTo: (in category 'updating') ----- + updateFromRepositories: repositoryUrls upTo: versionNumber + "MCMcmUpdater updateFromRepositories: #( + 'http://squeaksource.com/MCUpdateTest' + )" + + | repos config | + MCConfiguration upgradeIsMerge: true. + "The list of repositories to consult in order" + repos := repositoryUrls collect:[:url| + MCRepositoryGroup default repositories + detect:[:r| r description = url] + ifNone:[ | r | + r := MCHttpRepository location: url user: '' password: ''. + MCRepositoryGroup default addRepository: r. + r]]. + + "The list of updates-author.version.mcm sorted by version" + repos do:[ :r | config := self updateFromRepository: r upTo: versionNumber]. + ^config! Item was added: + ----- Method: MCMcmUpdater>>updateFromRepository:upTo: (in category 'updating') ----- + updateFromRepository: repository upTo: versionNumber + + | config | + repository cacheAllFileNamesDuring: [ | updateList | + updateList := self updateListFor: repository. + "Proceed only if there are updates available at all." + updateList ifNotEmpty: [ + updateList := self refreshUpdateMapFor: repository with: updateList. + "Now process each update file. Check if we have all dependencies and if not, + load the entire configuration (this is mostly to skip older updates quickly)" + updateList do:[:assoc| + assoc key > versionNumber ifTrue: [^config]. + ProgressNotification signal: '' extra: 'Processing ', assoc value. + config := repository versionNamed: assoc value. + self updateFromConfig: config. + self lastUpdateMap at: repository description put: assoc key. + ] displayingProgress: 'Processing configurations'. + ]]. + ^config + !

1 0

Rotating Morphs; how to rotate about a point other than the centre of bounds?
by tim Rowledge 08 Apr '17

08 Apr '17

As part of the never ending Weather station project I’m making a rotary dial morph that can be used to display things such as barometers, speedometers, vu meters, clocks, compasses etc - pretty much anything where a needle thing rotates about a pivot in order to point to a value on a scale. Clearly one can be ultra simplistic and use a LineMorph over a CircleMorph but that isn't terribly pretty. Right now I have things set up to simply add submorphs to build whatever background and borders and tick marks are wanted, plus the needle. With an ImageMorph (or should it be a SketchMorph?) providing a picture of the dial/scale/frame it can look quite nice. However, the needle is a problem. A simple Line or PolygonMorph can be used and then it is possible to set the rotationCenter such that subsequent #rotationDegrees: make it turn about that centre. So far, so good. I’d prefer to allow arbitrary morphs for the needle - again, an image would be good in a lot of cases - but I cannot for the life of me find how to make general morphs rotate about a set point. I can use #rotationCenter: and the value is stuck in the extension as expected. If I use the halo rotate after doing that the new center point is clearly shown in the right place BUT it still rotates about the center of the bounds. I can’t find any illuminating usages of #rotationCenter to show how the new center point is used and certainly nothing that makes it look like it is ever treated as the pivot. I’ve dug into using asFlexShell and friends with no improvement. I’ve searched through the swiki. I’ve compared a 5.0 image with the 6alpha image. To cause further concern pretty much all the rotate related code I can find seems to be in the EToys package, which may mean it would go away when we make a more typical release image. Isn’t rotating morphs a relatively basic part of using them? What have I missed, or looked at without actually seeing? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: LTT: Lose Timing Track

4 11

The Inbox: Morphic-mva.1334.mcz
by commits＠source.squeak.org 07 Apr '17

07 Apr '17

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-mva.1334.mcz ==================== Summary ==================== Name: Morphic-mva.1334 Author: mva Time: 7 April 2017, 6:05:52.930071 pm UUID: cf00184d-16fc-470f-bda7-3464f82b28f0 Ancestors: Morphic-cmm.1333 A quick hack - proof of concept - as a reaction to "I'd like to see system windows collapse when dropped in the menu bar". http://lists.squeakfoundation.org/pipermail/squeak-dev/2017-April/194079.ht… Drag a system window to the menu bar - it will collapse. Drag it out to the world - it will expand. Caveats. When you drag a window in world - it will expand when you drop it. When you collapse a window in world - it will will stay up. You can send it back with the 'send to back' menu option in the triangle menu on the right. The windows you have put into the menu bar have an unnerving tendency to jump to the left of the menu bar putting themselves before the menu. =============== Diff against Morphic-cmm.1333 =============== Item was changed: ----- Method: SystemWindow>>collapseOrExpand (in category 'resize/collapse') ----- collapseOrExpand "Collapse or expand the window, depending on existing state" | cf | isCollapsed ifTrue: ["Expand -- restore panes to morphics structure" isCollapsed := false. self beKeyWindow. "Bring to frint first" Preferences collapseWindowsInPlace ifTrue: [fullFrame := fullFrame align: fullFrame topLeft with: self getBoundsWithFlex topLeft] ifFalse: [collapsedFrame := self getBoundsWithFlex]. collapseBox ifNotNil: [collapseBox setBalloonText: 'collapse this window' translated]. self setBoundsWithFlex: fullFrame. paneMorphs reverseDo: [:m | self addMorph: m unlock. self world startSteppingSubmorphsOf: m]. self addPaneSplitters. (self hasProperty: #applyTheme) ifTrue: [ self removeProperty: #applyTheme. self userInterfaceTheme applyTo: self allMorphs]] ifFalse: ["Collapse -- remove panes from morphics structure" isCollapsed := true. fullFrame := self getBoundsWithFlex. "First save latest fullFrame" paneMorphs do: [:m | m delete; releaseCachedState]. self removePaneSplitters. self removeCornerGrips. model modelSleep. cf := self getCollapsedFrame. (collapsedFrame isNil and: [Preferences collapseWindowsInPlace not]) ifTrue: [collapsedFrame := cf]. self setBoundsWithFlex: cf. collapseBox ifNotNil: [collapseBox setBalloonText: 'expand this window' translated ]. expandBox ifNotNil: [expandBox setBalloonText: 'expand this window' translated ]. + ]. - self sendToBack]. self layoutChanged! Item was changed: ----- Method: SystemWindow>>justDroppedInto:event: (in category 'geometry') ----- justDroppedInto: aMorph event: anEvent + (aMorph isKindOf: DockingBarMorph) ifTrue: [ self collapse ]. + (aMorph isWorldMorph) ifTrue: [ self expand ]. isCollapsed ifTrue: [self position: ((self position max: 0@0) grid: 8@8). collapsedFrame := self bounds] ifFalse: [fullFrame := self bounds]. self beKeyWindow. self hasDropShadow: Preferences menuAppearance3d. "See #startDragFromLabel:." aMorph == self world ifTrue: [self assureLabelAreaVisible]. (Project uiManager openToolsAttachedToMouseCursor and: (self hasProperty: #initialDrop)) ifTrue: [ self removeProperty: #initialDrop. (self submorphs detect: [:m | m isKindOf: BottomRightGripMorph] ifNone: []) ifNotNil: [:grip | grip referencePoint: anEvent position; setProperty: #targetHadDropShadow toValue: true "See MorphicToolBuilder >> #open:". self hasDropShadow: false. anEvent hand newMouseFocus: grip]]. ^super justDroppedInto: aMorph event: anEvent!

2 1

Anyone out there who can...
by Eliot Miranda 07 Apr '17

07 Apr '17

Hi All, anyone out there who can give me admin privileges to source.squeak.org (or explain how to login as admin, cuz my normal login doesn't convey admin privileges). _,,,^..^,,,_ best, Eliot

2 3

Morphs can be dropped on main docking bar
by Bernhard Pieber 07 Apr '17

07 Apr '17

I just found out that I can drop morphs on the main docking bar. When I show the docking bar’s context menu, the „accept drops“ checkbox is not clicked, though. Is this a bug or a feature? Bernhard

10 21

The Trunk: Tests-eem.376.mcz
by commits＠source.squeak.org 07 Apr '17

07 Apr '17

Eliot Miranda uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-eem.376.mcz ==================== Summary ==================== Name: Tests-eem.376 Author: eem Time: 6 April 2017, 4:06:35.872493 pm UUID: cf795993-c2d9-4443-b1ae-ac421928a96a Ancestors: Tests-eem.375 Make the decompilation tests use the same bytecode set for recompilation as the original method. Make the testMaxLiterals test use the preferred bytecode set's literal limit. =============== Diff against Tests-eem.375 =============== Item was changed: ----- Method: CompilerTest>>testMaxLiterals (in category 'limits') ----- testMaxLiterals "Document the maximum number of literals in a compiled method" | maxLiterals stringThatCanBeCompiled stringWithOneTooManyLiterals | "Why 6? It's rather implementation dependent. But the {... construct is compiled as (Array braceStream: size) nextPut: expr; ...; braceArray where nextPut: is a special selector. So one each for Array binding, #braceStream, #braceArray and the size, one for the selector and one for the methodClass makes 6." + maxLiterals := CompiledCode preferredBytecodeSetEncoderClass new maxNumLiterals - 6. - maxLiterals := thisContext method encoderClass new maxNumLiterals - 6. stringThatCanBeCompiled := '{ ', (String streamContents: [:strm | 1 to: maxLiterals do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. stringWithOneTooManyLiterals := '{ ', (String streamContents: [:strm | 1 to: maxLiterals + 1 do: [:e | strm nextPutAll: '''', e asString, '''', ' . ']]), '}'. self assert: ((1 to: maxLiterals) collect: #printString) equals: (Compiler evaluate: stringThatCanBeCompiled). "If the following test fails, it means that the limit has been raised or eliminated, and this test should be updated to reflect the improvement." self should: [Compiler evaluate: stringWithOneTooManyLiterals] raise: Error. ! Item was changed: ----- Method: DecompilerTests>>checkDecompileMethod: (in category 'utilities') ----- checkDecompileMethod: oldMethod | cls selector oldMethodNode methodNode newMethod oldCodeString newCodeString | cls := oldMethod methodClass. selector := oldMethod selector. oldMethodNode := (cls decompilerClass new withTempNames: oldMethod methodNode schematicTempNamesString) decompile: selector in: cls method: oldMethod methodForDecompile. [oldMethodNode properties includesKey: #warning] whileTrue: [oldMethodNode properties removeKey: #warning]. oldCodeString := oldMethodNode decompileString. + methodNode := [| compiler | + compiler := cls newCompiler. + compiler parser encoderClass: oldMethod encoderClass. + compiler - methodNode := [cls newCompiler compile: oldCodeString in: cls notifying: nil ifFail: []] on: SyntaxErrorNotification do: [:ex| ex errorMessage = 'Cannot store into' ifTrue: [ex return: #badStore]. ex pass]. "Ignore cannot store into block arg errors; they're not our issue." methodNode ~~ #badStore ifTrue: [newMethod := methodNode generate. newCodeString := ((cls decompilerClass new withTempNames: methodNode schematicTempNamesString) decompile: selector in: cls method: newMethod methodForDecompile) decompileString. "(StringHolder new textContents: (TextDiffBuilder buildDisplayPatchFrom: oldCodeString to: newCodeString)) openLabel: 'Decompilation Differences for ', cls name,'>>',selector" "(StringHolder new textContents: (TextDiffBuilder buildDisplayPatchFrom: oldMethod abstractSymbolic to: newMethod abstractSymbolic)) openLabel: 'Bytecode Differences for ', cls name,'>>',selector" self assert: (oldCodeString = newCodeString or: [(Scanner new scanTokens: oldCodeString) = (Scanner new scanTokens: newCodeString)]) description: cls name asString, ' ', selector asString resumable: true]!

1 0

The Trunk: Kernel-eem.1091.mcz
by commits＠source.squeak.org 07 Apr '17

07 Apr '17

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1091.mcz ==================== Summary ==================== Name: Kernel-eem.1091 Author: eem Time: 6 April 2017, 3:39:24.442535 pm UUID: 8d871428-a98b-4d09-a8f6-ee199bb7c4e6 Ancestors: Kernel-eem.1090 Fix decode errors in the SistaV1 bytecode decoders. pushThisContext and doDup were off by one bytecode. pop and store remote temp were interchanged. ext push temp var was off by one and push integer was not signed. =============== Diff against Kernel-eem.1090 =============== Item was changed: ----- Method: InstructionStream>>interpretNext2ByteSistaV1Instruction:for:extA:extB:startPC: (in category 'decoding - private - sista v1') ----- interpretNext2ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the two-byte codes. For a table of the bytecode set, see EncoderForV1's class comment." | byte method | method := self method. byte := self method at: pc. pc := pc + 1. "We do an inline quasi-binary search on bytecode" bytecode < 234 ifTrue: "pushes" [bytecode < 231 ifTrue: [bytecode < 229 ifTrue: [| literal | bytecode = 226 ifTrue: [^client pushReceiverVariable: (extA bitShift: 8) + byte]. literal := method literalAt: (extA bitShift: 8) + byte + 1. bytecode = 227 ifTrue: [^client pushLiteralVariable: literal]. ^client pushConstant: literal]. bytecode = 229 ifTrue: + [^client pushTemporaryVariable: byte]. + ^self unusedBytecode: client at: startPC]. - [^client pushClosureTemps: byte]. - ^client pushTemporaryVariable: byte]. bytecode = 231 ifTrue: [^byte < 128 ifTrue: [client pushNewArrayOfSize: byte] ifFalse: [client pushConsArrayWithElements: byte - 128]]. bytecode = 232 ifTrue: + [^client pushConstant: ((extB < 128 ifTrue: [extB] ifFalse: [extB - 256]) bitShift: 8) + byte]. - [^client pushConstant: (extB bitShift: 8) + byte]. ^client pushConstant: (Character value: (extB bitShift: 8) + byte)]. bytecode < 240 ifTrue: "sends, trap and jump" [bytecode < 236 ifTrue: "sends" [^client send: (method literalAt: (extA bitShift: 5) + (byte // 8) + 1) super: bytecode = 235 numArgs: (extB bitShift: 3) + (byte \\ 8)]. bytecode = 236 ifTrue: [^client trapIfNotInstanceOf: (method literalAt: (extA bitShift: 8) + byte + 1)]. bytecode = 237 ifTrue: [^client jump: (extB bitShift: 8) + byte]. ^client jump: (extB bitShift: 8) + byte if: bytecode = 238]. bytecode < 243 ifTrue: [bytecode = 240 ifTrue: [^client popIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 241 ifTrue: [^client popIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. ^client popIntoTemporaryVariable: byte]. bytecode = 243 ifTrue: [^client storeIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 244 ifTrue: [^client storeIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. bytecode = 245 ifTrue: [^client storeIntoTemporaryVariable: byte]. "246-247 1111011 i xxxxxxxx UNASSIGNED" ^self unusedBytecode: client at: startPC! Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category 'decoding - private - sista v1') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: [^client callPrimitive: byte2 + (byte3 bitShift: 8)]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: - [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. - bytecode = 253 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. + bytecode = 253 ifTrue: + [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "249 11111001 xxxxxxxx syyyyyyy Reserved for Push Float" "254-255 1111111 i xxxxxxxx yyyyyyyy UNASSIGNED" ^self unusedBytecode: client at: startPC! Item was changed: ----- Method: InstructionStream>>interpretNextSistaV1InstructionFor: (in category 'decoding - private - sista v1') ----- interpretNextSistaV1InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForSistaV1's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 16rE0 and: [byte <= 16rE1]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 16rE0 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 11 ifTrue: [div16 < 6 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset = 12 ifTrue: [^client pushReceiver]. offset = 13 ifTrue: [^client pushConstant: true]. offset = 14 ifTrue: [^client pushConstant: false]. offset = 15 ifTrue: [^client pushConstant: nil]]. "div16 = 5" offset < 2 ifTrue: [^client pushConstant: offset]. + offset = 2 ifTrue: - offset = 3 ifTrue: [^self interpretSistaV1ExtendedPush: extB for: client]. + offset = 3 ifTrue: - offset = 4 ifTrue: [^client doDup]. offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: [^client methodReturnConstant: true]. offset = 10 ifTrue: [^client methodReturnConstant: false]. offset = 11 ifTrue: [^client methodReturnConstant: nil]. offset = 12 ifTrue: [^client methodReturnTop]. offset = 13 ifTrue: [^client blockReturnConstant: nil]. offset = 14 ifTrue: [^client blockReturnTop]. offset = 15 ifTrue: [^client doNop]. ^self unusedBytecode: client at: savedPC]. "short sends" div16 = 6 ifTrue: [^client send: (Smalltalk specialSelectorAt: offset + 1) super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. div16 = 7 ifTrue: [^client send: (Smalltalk specialSelectorAt: offset + 17) super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. ^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 8]. "div16 >= 11; bytecode >= 176" div16 < 14 ifTrue: [div16 = 11 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1 if: false]. ^client popIntoReceiverVariable: offset - 8]. "div16 = 13" offset < 8 ifTrue: [^client popIntoTemporaryVariable: offset]. offset = 8 ifTrue: [^client doPop]. offset = 9 ifTrue: [^client doDup]. ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 248 ifTrue: [^self interpretNext2ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC!

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
23
Older →

Jump to page: