Squeak-dev July 2017

squeak-dev@lists.squeakfoundation.org

28 participants
70 discussions

Re: [squeak-dev] Vm-dev Digest, Vol 133, Issue 13
by Max Leske 10 Jul '17

10 Jul '17

Hi Luke, > On 10 Jul 2017, at 09:38, vm-dev-request(a)lists.squeakfoundation.org wrote: > > Hi Max, > > On 18 May 2017 at 13:32, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: > >> >> We managed to figure out that OSProcess works when we use gcc <= 4.8 on >> Debian. We are happy to use 4.8 for now, so we're good. It would of course >> be super cool if we could use the series 6 gcc as that will soon ship with >> Debian 9 (stretch) but it's probably not trivial to just move to a new >> compiler version (as seems evident from the fact that a minor version >> change can mess up compilation). >> > > Thanks for tracking this problem down and sharing the details. I came upon > exactly the same problem with the Nix package and was able to work-around > that by also downgrading to gcc 4.8. I am sure it would have taken a long > time to work this out without the benefit of your experience. Sweet! Nice to know that others benefit from my work (or woes) :) > > Relatedly: Is there a suitable automated test that we can use to check that > our VMs are basically okay? I am pushing the switch to gcc 4.8 to resolve > this problem but I don't know whether this is causing other regressions or > what other obvious problems I have missed. I'd love a bit of test coverage > for the builds. There are tests that are being run for every commit to https://github.com/opensmalltalk/opensmalltalk-vm <https://github.com/opensmalltalk/opensmalltalk-vm>. Unfortunately, they don't explicitly include VM plugin related things. Also, the build is pretty much fixed to a specific GCC version by the build setup (depends on what Travis CI offers, for instance). I fully agree, that it would be very helpful to have a more elaborate test suite that would take into account things like architecture and available libraries. I think, that could be a nice project for an intern, or a bachelor's thesis (cc'ing pharo-dev and squeak-dev). As long as we don't have that, I'd use the GCC version from the build. You can get to that by browsing the latest build on travis and searching the log for "gcc" (currently version 4.6.3 on Ubuntu Precise). Cheers, Max

1 0

The Trunk: System-eem.959.mcz
by commits＠source.squeak.org 09 Jul '17

09 Jul '17

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.959.mcz ==================== Summary ==================== Name: System-eem.959 Author: eem Time: 8 July 2017, 9:10:09.661059 pm UUID: a508cce3-7fe1-4a59-8b1c-18c18bd1e91c Ancestors: System-bf.958 Adapt the NativeImageSegment loading code to the new loadSegmentFrom:outPointers: API. =============== Diff against System-bf.958 =============== Item was changed: ----- Method: NativeImageSegment>>loadSegmentFrom:outPointers: (in category 'read/write segment primitives') ----- loadSegmentFrom: segmentWordArray outPointers: outPointerArray + "Load segmentWordArray into the memory. Adapt the primitive to the new API, which is to answer the array of loaded objects, the first of which should be the array of roots. The primitive will install a binary image segment and return as its value the array - "This primitive will install a binary image segment and return as its value the array of roots of the tree of objects represented. Upon successful completion, the + wordArray will have been becomed into anArray of the loaded objects. So simply answer the segmentWordArray which will have becommed ." - wordArray will have been becomed into anArray of the loaded objects. If this - primitive should fail, it will have destroyed the contents of the segment wordArray." + ^(self primitiveLoadSegmentFrom: segmentWordArray outPointers: outPointerArray) + ifNil: [self error: 'segment load failed'] + ifNotNil: [segmentWordArray]! - <primitive: 99 error: ec> "successful completion returns the array of roots" - ^nil "failure returns nil"! Item was added: + ----- Method: NativeImageSegment>>primitiveLoadSegmentFrom:outPointers: (in category 'read/write segment primitives') ----- + primitiveLoadSegmentFrom: segmentWordArray outPointers: outPointerArray + "This primitive will install a binary image segment and return as its value the array + of roots of the tree of objects represented. Upon successful completion, the + wordArray will have been becomed into anArray of the loaded objects. If this + primitive should fail, it will have destroyed the contents of the segment wordArray." + + <primitive: 99 error: ec> "successful completion returns the array of roots" + ^nil "failure returns nil"!

1 0

The Trunk: WebClient-Core-topa.109.mcz
by commits＠source.squeak.org 08 Jul '17

08 Jul '17

Tobias Pape uploaded a new version of WebClient-Core to project The Trunk: http://source.squeak.org/trunk/WebClient-Core-topa.109.mcz ==================== Summary ==================== Name: WebClient-Core-topa.109 Author: topa Time: 6 July 2017, 3:27:22.152308 pm UUID: b795898b-9723-44ab-a429-bceb056f4b90 Ancestors: WebClient-Core-topa.108 As with content-type-charset, cope for content-encoding variability =============== Diff against WebClient-Core-topa.108 =============== Item was added: + ----- Method: WebClient>>contentDecoders (in category 'initialize') ----- + contentDecoders + + | result | + result := nil. + (self class environment hasBindingOf: #GZipReadStream) + ifTrue: [result := 'gzip']. + (self class environment hasBindingOf: #BrotliReadStream) + ifTrue: [ result := result ifNil: ['br'] ifNotNil: [:r | r, ', br']]. + ^ result! Item was changed: ----- Method: WebClient>>httpGet:do: (in category 'methods') ----- httpGet: urlString do: aBlock "GET the response from the given url" "(WebClient httpGet: 'http://www.squeak.org') content" | request | self initializeFromUrl: urlString. request := self requestWithUrl: urlString. request method: 'GET'. + userAgent ifNotNil:[:ua | request headerAt: 'User-Agent' put: ua]. + self contentDecoders ifNotNil: [:decoders | request headerAt: 'Accept-Encoding' put: decoders]. - userAgent ifNotNil:[request headerAt: 'User-Agent' put: userAgent]. - request headerAt: 'Accept-Encoding' put: 'gzip'. aBlock value: request. ^self sendRequest: request ! Item was added: + ----- Method: WebMessage>>decoderForContentEncoding (in category 'private') ----- + decoderForContentEncoding + + (self headerAt: 'content-encoding') = 'gzip' + ifTrue: [^ self class environment + at: #GZipReadStream ifAbsent: [self error: 'GZip encoded responses not supported']]. + (self headerAt: 'content-encoding') = 'br' + ifTrue: [^ self class environment + at: #BrotliReadStream ifAbsent: [self error: 'Brotli encoded responses not supported']]. + ^ nil! Item was changed: ----- Method: WebMessage>>getContentWithProgress: (in category 'private') ----- getContentWithProgress: progressBlockOrNil "Reads available content and returns it." | length result | length := self contentLength. result := (stream isBinary ifTrue:[ ByteArray ] ifFalse: [ ByteString ]) new: (length ifNil: [ 1000 ]) streamContents: [ :outputStream | self streamFrom: stream to: outputStream size: length progress: progressBlockOrNil ]. + self decoderForContentEncoding ifNotNil: [:decoder | + result := (decoder on: result) upToEnd]. - (self headerAt: 'content-encoding') = 'gzip' ifTrue: [ - result := (GZipReadStream on: result) upToEnd]. self textConverterForContentType ifNotNil: [:converter | result := result convertFromWithConverter: converter]. ^ result !

3 2

The Trunk: WebClient-Tests-topa.52.mcz
by commits＠source.squeak.org 06 Jul '17

06 Jul '17

Tobias Pape uploaded a new version of WebClient-Tests to project The Trunk: http://source.squeak.org/trunk/WebClient-Tests-topa.52.mcz ==================== Summary ==================== Name: WebClient-Tests-topa.52 Author: topa Time: 6 July 2017, 3:24:10.565021 pm UUID: b84fa4c2-2761-4616-b545-68d816ae3f28 Ancestors: WebClient-Tests-topa.51 rename charset test, add gzip test =============== Diff against WebClient-Tests-topa.51 =============== Item was removed: - ----- Method: WebClientServerTest>>testContentEncoding (in category 'tests - misc') ----- - testContentEncoding - "Test encoding detection" - | resp expected | - expected := '«garçon Léon»'. - #( - 'latin-1' #[171 103 97 114 231 111 110 32 76 233 111 110 187] - 'macroman' #[199 103 97 114 141 111 110 32 76 142 111 110 200] - 'utf-8' #[194 171 103 97 114 195 167 111 110 32 76 195 169 111 110 194 187] - ) pairsDo: [:name :bytes | - server addService: '/testcontent', name action:[:req|req send200Response: bytes asString contentType: 'text/plain; charset=', name]. - resp := WebClient httpGet: self localHostUrl, '/testcontent', name. - self assert: 200 equals: resp code. - self assert: expected equals: resp content]. - ! Item was added: + ----- Method: WebClientServerTest>>testContentEncodingGZip (in category 'tests - misc') ----- + testContentEncodingGZip + "Test content encoding" + | payload resp | + payload := 'hello' zipped. + server addService: '/testencoding' action: [:req| + req send200Response: payload contentType: 'text/plain' do: [:response | + response headerAt: 'Content-Encoding' put: 'gzip']]. + resp := WebClient httpGet: self localHostUrl, '/testencoding'. + self assert: 200 equals: resp code. + self assert: 'hello' equals: resp content. + ! Item was added: + ----- Method: WebClientServerTest>>testContentTypeCharsetEncoding (in category 'tests - misc') ----- + testContentTypeCharsetEncoding + "Test encoding detection" + | resp expected | + expected := '«garçon Léon»'. + #( + 'latin-1' #[171 103 97 114 231 111 110 32 76 233 111 110 187] + 'macroman' #[199 103 97 114 141 111 110 32 76 142 111 110 200] + 'utf-8' #[194 171 103 97 114 195 167 111 110 32 76 195 169 111 110 194 187] + ) pairsDo: [:name :bytes | + server addService: '/testcontent', name action:[:req|req send200Response: bytes asString contentType: 'text/plain; charset=', name]. + resp := WebClient httpGet: self localHostUrl, '/testcontent', name. + self assert: 200 equals: resp code. + self assert: expected equals: resp content]. + !

1 0

Re: [squeak-dev] Change to WebMessage breaks configuration loading (smalltalkCI)
by Max Leske 06 Jul '17

06 Jul '17

> On 6 Jul 2017, at 14:00, squeak-dev-request(a)lists.squeakfoundation.org wrote: > > Hi Max, > >> On 06.07.2017, at 09:08, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: >> >> Hi, >> >> The change by Tobias (03-07-2017) to WebMessage>>getContentWithProgress: breaks loading of configurations. They are gzip encoded but that is never being considered if a converter is set. The binary stream will then be decoded as string which fails. > > > Arhg, and ordering problem :( > Thanks for noticing. > > Does WebClient-Core-topa.108 fix that? Yes, that fixes it, thanks! > > Best regards > -Tobias

1 0

Change to WebMessage breaks configuration loading (smalltalkCI)
by Max Leske 06 Jul '17

06 Jul '17

Hi, The change by Tobias (03-07-2017) to WebMessage>>getContentWithProgress: breaks loading of configurations. They are gzip encoded but that is never being considered if a converter is set. The binary stream will then be decoded as string which fails. Cheers, Max

2 1

The Trunk: WebClient-Core-topa.108.mcz
by commits＠source.squeak.org 06 Jul '17

06 Jul '17

Tobias Pape uploaded a new version of WebClient-Core to project The Trunk: http://source.squeak.org/trunk/WebClient-Core-topa.108.mcz ==================== Summary ==================== Name: WebClient-Core-topa.108 Author: topa Time: 6 July 2017, 12:07:14.128141 pm UUID: a3d7bd67-cc07-43e5-b05a-2f0c3e9d1fa5 Ancestors: WebClient-Core-topa.107 fix encoding/converter ordering. Thanks Max Leske =============== Diff against WebClient-Core-topa.107 =============== Item was changed: ----- Method: WebMessage>>getContentWithProgress: (in category 'private') ----- getContentWithProgress: progressBlockOrNil "Reads available content and returns it." | length result | length := self contentLength. result := (stream isBinary ifTrue:[ ByteArray ] ifFalse: [ ByteString ]) new: (length ifNil: [ 1000 ]) streamContents: [ :outputStream | self streamFrom: stream to: outputStream size: length progress: progressBlockOrNil ]. + (self headerAt: 'content-encoding') = 'gzip' ifTrue: [ + result := (GZipReadStream on: result) upToEnd]. self textConverterForContentType ifNotNil: [:converter | result := result convertFromWithConverter: converter]. + ^ result - (self headerAt: 'content-encoding') = 'gzip' ifFalse: [ ^result ]. - ^(GZipReadStream on: result) upToEnd !

1 0

Nuking VM ImageSegment support (was Re: [squeak-dev] Daily Commit Log; System-bf.916)
by Eliot Miranda 05 Jul '17

05 Jul '17

Hi Bert, Hi All, On Thu, Sep 15, 2016 at 2:55 PM, <commits(a)source.squeak.org> wrote: [snip] > http://lists.squeakfoundation.org/pipermail/packages/2016- > September/068930.html > > Name: System-bf.916 > Ancestors: System-bf.915 > > Replace VM-level ImageSegment loading with a Smalltalk implementation for > old (interpreter-era) projects. > > Also removes support for writing segments. > > This overrides the Spur support introduced in System-eem.758. > So one question is should we delete VM support for ImageSegment from the Spur VM? There's at least 1.5k of generated source for the Spur ImageSegment load and save support, some 2% of the interpreter/primitives source code. That's a lot, and the code is complex and ugly. If it never really worked before IMO we should nuke it asap. If it worked in some fashion perhaps we can schedule its demise for the 6.0 release's VM. What do others think? _,,,^..^,,,_ best, Eliot

9 17

The Trunk: System-bf.958.mcz
by commits＠source.squeak.org 04 Jul '17

04 Jul '17

Bert Freudenberg uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-bf.958.mcz ==================== Summary ==================== Name: System-bf.958 Author: bf Time: 4 July 2017, 1:27:35.955538 pm UUID: 911e66d0-5ed2-4710-ac0f-f2a43082b625 Ancestors: System-eem.957 ImageSegmentLoader: ignore old contexts =============== Diff against System-eem.957 =============== Item was changed: ----- Method: ImageSegmentLoader>>allocateBlockContext: (in category 'allocating') ----- allocateBlockContext: nWords + "not supported in Spur - nil is fine for Etoys projects" + ^nil + "| homeOop methodOop method | - | homeOop methodOop method | homeOop := self uint32At: position + 24. methodOop := self uint32At: homeOop + 16. method := self readObjectAt: methodOop. + ^BlockContext newForMethod: method"! - ^self shouldBeImplemented! Item was changed: ----- Method: ImageSegmentLoader>>allocateMethodContext: (in category 'allocating') ----- allocateMethodContext: nWords + "not supported in Spur - nil is fine for Etoys projects" + ^nil + "| methodOop method | - | methodOop method | methodOop := self uint32At: position + 16. method := self readObjectAt: methodOop. + ^Context newForMethod: method"! - ^Context newForMethod: method!

1 0

The Trunk: 46Deprecated-eem.6.mcz
by commits＠source.squeak.org 03 Jul '17

03 Jul '17

Eliot Miranda uploaded a new version of 46Deprecated to project The Trunk: http://source.squeak.org/trunk/46Deprecated-eem.6.mcz ==================== Summary ==================== Name: 46Deprecated-eem.6 Author: eem Time: 3 July 2017, 4:18:34.838848 pm UUID: 026768f4-9d02-4f20-b6f3-fc112cd2c4b0 Ancestors: 46Deprecated-topa.5 Use the abstract class-side interface for image segment use now that we have both LegacyImageSegment and NativeImageSegment. =============== Diff against 46Deprecated-topa.5 =============== Item was changed: ----- Method: MorphicProject>>exportSegmentWithCatagories:classes:fileName:directory: (in category '*46Deprecated') ----- exportSegmentWithCatagories: catList classes: classList fileName: aFileName directory: aDirectory "Store my project out on the disk as an *exported* ImageSegment. All outPointers will be in a form that can be resolved in the target image. Name it <project name>.extSeg. What do we do about subProjects, especially if they are out as local image segments? Force them to come in? Player classes are included automatically." | is str ans revertSeg roots holder | self flag: #toRemove. self halt. "unused" "world == World ifTrue: [^ false]." "self inform: 'Can''t send the current world out'." world ifNil: [^ false]. world presenter ifNil: [^ false]. ScrapBook default emptyScrapBook. world currentHand pasteBuffer: nil. "don't write the paste buffer." world currentHand mouseOverHandler initialize. "forget about any references here" "Display checkCurrentHandForObjectToPaste." Command initialize. world clearCommandHistory. world fullReleaseCachedState; releaseViewers. world cleanseStepList. world localFlapTabs size = world flapTabs size ifFalse: [ self error: 'Still holding onto Global flaps']. world releaseSqueakPages. holder := Project allProjects. "force them in to outPointers, where DiskProxys are made" "Just export me, not my previous version" revertSeg := self parameterAt: #revertToMe. self projectParameters removeKey: #revertToMe ifAbsent: []. roots := OrderedCollection new. roots add: self; add: world; add: transcript; add: changeSet; add: thumbnail. roots add: world activeHand; addAll: classList; addAll: (classList collect: [:cls | cls class]). roots := roots reject: [ :x | x isNil]. "early saves may not have active hand or thumbnail" catList do: [:sysCat | (SystemOrganization listAtCategoryNamed: sysCat asSymbol) do: [:symb | roots add: (Smalltalk at: symb); add: (Smalltalk at: symb) class]]. + is := ImageSegment copySmartRootsExport: roots asArray. - is := ImageSegment new copySmartRootsExport: roots asArray. "old way was (is := ImageSegment new copyFromRootsForExport: roots asArray)" is state = #tooBig ifTrue: [^ false]. str := ''. "considered legal to save a project that has never been entered" (is outPointers includes: world) ifTrue: [ str := str, '\Project''s own world is not in the segment.' withCRs]. str isEmpty ifFalse: [ ans := (UIManager default chooseFrom: #('Do not write file' 'Write file anyway' 'Debug') title: str). ans = 1 ifTrue: [ revertSeg ifNotNil: [self projectParameterAt: #revertToMe put: revertSeg]. ^ false]. ans = 3 ifTrue: [self halt: 'Segment not written']]. is writeForExportWithSources: aFileName inDirectory: aDirectory. revertSeg ifNotNil: [self projectParameterAt: #revertToMe put: revertSeg]. holder. world flapTabs do: [:ft | (ft respondsTo: #unhibernate) ifTrue: [ft unhibernate]]. is arrayOfRoots do: [:obj | obj isScriptEditorMorph ifTrue: [obj unhibernate]]. ^ true !

1 0