Squeak-dev January 2018

squeak-dev@lists.squeakfoundation.org

50 participants
171 discussions

The Trunk: Compiler-eem.367.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.367.mcz ==================== Summary ==================== Name: Compiler-eem.367 Author: eem Time: 5 January 2018, 9:27:53.33704 pm UUID: 27d11be7-248b-4525-958e-20cfc05779b3 Ancestors: Compiler-eem.366 Uh, no. reindexingLiteralsDo: does have to deal with the selectorSet specially. =============== Diff against Compiler-eem.366 =============== Item was changed: ----- Method: BytecodeEncoder>>reindexingLiteralsDo: (in category 'code generation') ----- reindexingLiteralsDo: aBlock | savedNodes saveBlock | savedNodes := IdentityDictionary new. saveBlock := [:node| savedNodes at: node put: node shallowCopy]. litSet do: saveBlock. litIndSet do: saveBlock. selectorSet do: saveBlock. ^aBlock ensure: [| restoreBlock | restoreBlock := [:node| node resetFromCopy: (savedNodes at: node)]. litSet do: restoreBlock. litIndSet do: restoreBlock. + selectorSet do: [:node| node resetFromCopy: (savedNodes at: node ifAbsent: [node])]]! - selectorSet do: restoreBlock]!

1 0

The Trunk: Compiler-eem.366.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.366.mcz ==================== Summary ==================== Name: Compiler-eem.366 Author: eem Time: 5 January 2018, 9:08:19.867232 pm UUID: d8b9de6b-6688-4293-b66e-e5e1ec50e4fb Ancestors: Compiler-eem.365 reindexingLiteralsDo: doesn't need to key by the same keys used in the literal sets; they can simply use the nodes themselves. This fixes the ambiguity between symbols used as selectors and symbols used as literal symbols, and fixes the missing literal problem addressed by Compiler-eem.365. =============== Diff against Compiler-eem.365 =============== Item was changed: ----- Method: BytecodeEncoder>>reindexingLiteralsDo: (in category 'code generation') ----- reindexingLiteralsDo: aBlock + | savedNodes saveBlock | + savedNodes := IdentityDictionary new. + saveBlock := [:node| savedNodes at: node put: node shallowCopy]. + litSet do: saveBlock. + litIndSet do: saveBlock. + selectorSet do: saveBlock. - | savedLiterals saveBlock | - savedLiterals := PluggableDictionary new equalBlock: litSet equalBlock. - saveBlock := [:assoc| savedLiterals at: assoc key put: assoc value shallowCopy]. - litSet associationsDo: saveBlock. - litIndSet associationsDo: saveBlock. - selectorSet associationsDo: saveBlock. ^aBlock ensure: [| restoreBlock | + restoreBlock := [:node| node resetFromCopy: (savedNodes at: node)]. + litSet do: restoreBlock. + litIndSet do: restoreBlock. + selectorSet do: restoreBlock]! - restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key ifAbsent: [assoc value])]. - litSet associationsDo: restoreBlock. - litIndSet associationsDo: restoreBlock. - selectorSet associationsDo: restoreBlock]!

1 0

The Trunk: Compiler-eem.365.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.365.mcz ==================== Summary ==================== Name: Compiler-eem.365 Author: eem Time: 5 January 2018, 8:21:15.192014 pm UUID: e3702a86-124d-46ca-bd7d-0707ab249ab4 Ancestors: Compiler-eem.364 Make reindexingLiteralsDo: more robust when literals get added during blocks and hence weren't saved before the block was generated. =============== Diff against Compiler-eem.364 =============== Item was changed: ----- Method: BytecodeEncoder>>reindexingLiteralsDo: (in category 'code generation') ----- reindexingLiteralsDo: aBlock | savedLiterals saveBlock | savedLiterals := PluggableDictionary new equalBlock: litSet equalBlock. saveBlock := [:assoc| savedLiterals at: assoc key put: assoc value shallowCopy]. litSet associationsDo: saveBlock. litIndSet associationsDo: saveBlock. selectorSet associationsDo: saveBlock. ^aBlock ensure: [| restoreBlock | + restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key ifAbsent: [assoc value])]. - restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key)]. litSet associationsDo: restoreBlock. litIndSet associationsDo: restoreBlock. selectorSet associationsDo: restoreBlock]!

2 2

The Trunk: ReleaseBuilder-eem.173.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-eem.173.mcz ==================== Summary ==================== Name: ReleaseBuilder-eem.173 Author: eem Time: 5 January 2018, 8:32:47.664882 pm UUID: 285b720e-b53c-41a4-b8a6-d46d379b9acc Ancestors: ReleaseBuilder-eem.172 Split selecting the bytecode set from installing it, to allow asking promptly and deferring installing until the recmpile step. =============== Diff against ReleaseBuilder-eem.172 =============== Item was changed: Object subclass: #ReleaseBuilder instanceVariableNames: '' classVariableNames: 'DeferredTask NextMajorVersion NextMinorVersion NextTask' poolDictionaries: '' category: 'ReleaseBuilder'! + ReleaseBuilder class + instanceVariableNames: 'useNewBytecodeSet'! !ReleaseBuilder commentStamp: 'mt 6/22/2016 18:08' prior: 0! I'm the script that prepares a trunk image for release. Just do "ReleaseBuilder doNextStep" repeatedly until the next release is done. For the final release step: - If you want to try it locally, change #localBuild to return true. - Most of the code operates (read-only) on the build repository, which is usually the trunk. For releases, there is a release repository, to which some package versions will be copied from trunk.! + ReleaseBuilder class + instanceVariableNames: 'useNewBytecodeSet'! Item was changed: ----- Method: ReleaseBuilder class>>recompileAll (in category 'scripts - support') ----- recompileAll + useNewBytecodeSet ifTrue: + [(Smalltalk classNamed: #EncoderForSistaV1) ifNotNil: + [:sistaBytecodeSet| + CompiledCode + installSecondaryBytecodeSet: sistaBytecodeSet; + preferredBytecodeSetEncoderClass: sistaBytecodeSet]]. - (Smalltalk classNamed: #EncoderForSistaV1) ifNotNil: - [:sistaBytecodeSet| - CompiledCode preferredBytecodeSetEncoderClass ~~ sistaBytecodeSet ifTrue: - [(Project uiManager - confirm: 'Do you want to make it the default in this release?' - orCancel: [false] - title: 'The SistaV1 Bytecode Set Is Available') ifTrue: - [CompiledCode - installSecondaryBytecodeSet: sistaBytecodeSet; - preferredBytecodeSetEncoderClass: sistaBytecodeSet]]]. Compiler recompileAll! Item was added: + ----- Method: ReleaseBuilder class>>setBytecodeSet (in category 'scripts') ----- + setBytecodeSet + "If possible and desired. install the SistaV1 byetcode set as the default. + Note that we use a variable to ask to use the compiler early so as not + to keep the release manager waiting, while deferring installing the + bytecode set until the recompileAll phase." + useNewBytecodeSet := false. + (Smalltalk classNamed: #EncoderForSistaV1) ifNotNil: + [:sistaBytecodeSet| + CompiledCode preferredBytecodeSetEncoderClass ~~ sistaBytecodeSet ifTrue: + [(Project uiManager + confirm: 'Do you want to make it the default in this release?' + orCancel: [^ Error signal: 'Release building canceled.'] + title: 'The SistaV1 Bytecode Set Is Available') ifTrue: + [useNewBytecodeSet := true]]]! Item was changed: ----- Method: ReleaseBuilder class>>setPreferences (in category 'scripts') ----- setPreferences "Preferences class defaultValueTableForCurrentRelease" " Preferences outOfTheBox." "<-- uncomment after #defaultValueTableForCurrentRelease is fixed up." "General User interaction" Preferences enable: #generalizedYellowButtonMenu ; enable: #swapMouseButtons; disable: #mouseOverForKeyboardFocus. Morph indicateKeyboardFocus: true. Project uiManager openToolsAttachedToMouseCursor: false. SearchBar useScratchPad: false. HandMorph sendMouseWheelToKeyboardFocus: false. HandMorph synthesizeMouseWheelEvents: true. "Text input." TextEditor autoEnclose: true ; autoIndent: true ; encloseSelection: false ; destructiveBackWord: false ; blinkingCursor: true ; dumbbellCursor: false. PluggableTextMorph simpleFrameAdornments: false. TextMorphForEditView draggableTextSelection: true. "Windows" SystemWindow reuseWindows: false. SystemWindow windowsRaiseOnClick: true. SystemWindow windowTitleActiveOnFirstClick: true. Model windowActiveOnFirstClick: false. "Not good for little screen real estate." Model useColorfulWindows: false. Preferences disable: #showSplitterHandles; disable: #fastDragWindowForMorphic. CornerGripMorph drawCornerResizeHandles: false; passiveColor: (Color gray: 0.85); activeColor: (Color r: 1 g: 0.599 b: 0.0). ProportionalSplitterMorph smartHorizontalSplitters: false ; smartVerticalSplitters: false. "Scroll bars." Preferences enable: #scrollBarsNarrow; enable: #scrollBarsOnRight; enable: #alwaysHideHScrollbar; disable: #alwaysShowHScrollbar; disable: #alwaysShowVScrollbar. ScrollBar scrollBarsWithoutArrowButtons: true; scrollBarsWithoutMenuButton: true. ScrollPane useRetractableScrollBars: false. "Rounded corners." Morph preferredCornerRadius: 8. SystemWindow roundedWindowCorners: false. DialogWindow roundedDialogCorners: false. MenuMorph roundedMenuCorners: false. PluggableButtonMorph roundedButtonCorners: false. ScrollBar roundedScrollBarLook: false. "Gradients." SystemWindow gradientWindow: false. DialogWindow gradientDialog: false. MenuMorph gradientMenu: false. PluggableButtonMorph gradientButton: false. ScrollBar gradientScrollBar: false. "Shadows" Preferences enable: #menuAppearance3d. Morph useSoftDropShadow: true. "Lists and Trees" PluggableListMorph filterableLists: true; clearFilterAutomatically: false; highlightHoveredRow: true; menuRequestUpdatesSelection: true. PluggableTreeMorph filterByLabelsOnly: false; maximumSearchDepth: 1. "Standard Tools" TheWorldMainDockingBar showWorldMainDockingBar: true; showSecondsInClock: true; twentyFourHourClock: true. SearchBar useSmartSearch: true. Workspace shouldStyle: false. Browser listClassesHierarchically: true; showClassIcons: true; showMessageIcons: true; sortMessageCategoriesAlphabetically: true. Preferences enable: #annotationPanes; enable: #optionalButtons; disable: #diffsWithPrettyPrint; enable: #traceMessages; enable: #alternativeBrowseIt; enable: #menuWithIcons; enable: #visualExplorer. SystemNavigation thoroughSenders: true. Preferences disable: #debugLogTimestamp. "Halo" Preferences enable: #showBoundsInHalo ; disable: #alternateHandlesLook; disable: #showDirectionHandles. "System" NetNameResolver enableIPv6: false. Scanner allowUnderscoreAsAssignment: true; prefAllowUnderscoreSelectors: true. + Deprecation showDeprecationWarnings: true. - Deprecation showDeprecationWarnings: true + self setBytecodeSet. + "that's all, folks"!

1 0

The Trunk: Tools-eem.787.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.787.mcz ==================== Summary ==================== Name: Tools-eem.787 Author: eem Time: 5 January 2018, 7:15:16.67055 pm UUID: 04897966-9248-4397-b05b-8adb49bf2420 Ancestors: Tools-eem.786 My favourite Group C car ever. Fix browseLocalSenders for the class-side. =============== Diff against Tools-eem.786 =============== Item was changed: ----- Method: StringHolder>>browseLocalSenders (in category '*Tools') ----- browseLocalSenders + self selectedClassOrMetaClass ifNotNil: - self selectedClass ifNotNil: [:cls| | token | token := UIManager default request: 'browse for selector or literal'. token isEmpty ifTrue: [^self]. Scanner new typedScan: token do: [:scannedToken :tokenType| token := tokenType = #word ifTrue: [(Symbol findInterned: token) ifNil: [^UIManager default inform: 'no such selector: ', token] ifNotNil: [:symbol| symbol]] ifFalse: [scannedToken]. self systemNavigation browseAllCallsOn: token localTo: cls]]!

1 0

The Trunk: Compiler-eem.364.mcz
by commits＠source.squeak.org 06 Jan '18

06 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.364.mcz ==================== Summary ==================== Name: Compiler-eem.364 Author: eem Time: 5 January 2018, 7:03:50.183797 pm UUID: 745c56d9-c3bf-4d7a-89bd-f5751947949e Ancestors: Compiler-eem.363 Fix reindexingLiteralsDo: to also reset the nodes in the selectorSet. And simplify. =============== Diff against Compiler-eem.363 =============== Item was changed: ----- Method: BytecodeEncoder>>reindexingLiteralsDo: (in category 'code generation') ----- reindexingLiteralsDo: aBlock + | savedLiterals saveBlock | - | savedLiterals | savedLiterals := PluggableDictionary new equalBlock: litSet equalBlock. + saveBlock := [:assoc| savedLiterals at: assoc key put: assoc value shallowCopy]. + litSet associationsDo: saveBlock. + litIndSet associationsDo: saveBlock. + selectorSet associationsDo: saveBlock. + ^aBlock ensure: + [| restoreBlock | + restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key)]. + litSet associationsDo: restoreBlock. + litIndSet associationsDo: restoreBlock. + selectorSet associationsDo: restoreBlock]! - litSet associationsDo: - [:assoc| - savedLiterals at: assoc key put: assoc value shallowCopy]. - litIndSet associationsDo: - [:assoc| - savedLiterals at: assoc key put: assoc value shallowCopy]. - ^[aBlock value] - ensure: - [litSet associationsDo: - [:assoc| - assoc value resetFromCopy: (savedLiterals at: assoc key)]. - litIndSet associationsDo: - [:assoc| - assoc value resetFromCopy: (savedLiterals at: assoc key)]]!

1 0

MP3 decoding/encoding in the image?
by Phil B 05 Jan '18

05 Jan '18

I know there was a plugn long ago for MP3 but was curious if anyone ever did a decoder/encoder image side? Since the MP3 patent has now expired, I thought I'd ask since it's a fairly ubiquitous format and now unencumbered. Thanks, Phil

3 3

The Trunk: Compiler-eem.363.mcz
by commits＠source.squeak.org 05 Jan '18

05 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.363.mcz ==================== Summary ==================== Name: Compiler-eem.363 Author: eem Time: 5 January 2018, 12:23:47.49447 pm UUID: e6e0f44c-156f-4ba2-a96b-044cc09da7e2 Ancestors: Compiler-eem.362 Use the blockReturnNilToCaller bytecode in full blocks. Add a postscript to remove empty categories in ParseNode and subclasses (to get rid of the obsolte and empty code generation (closures) protocols). =============== Diff against Compiler-eem.362 =============== Item was changed: + ----- Method: BlockNode>>createBlockLiteral: (in category 'code generation') ----- - ----- Method: BlockNode>>createBlockLiteral: (in category 'code generation (closures)') ----- createBlockLiteral: encoder ^self reindexingLocalsDo: [encoder reindexingLiteralsDo: [encoder copyWithNewLiterals generateBlockMethodOfClass: CompiledBlock trailer: CompiledMethodTrailer empty from: self]] encoder: encoder! Item was changed: ----- Method: BlockNode>>emitCodeForEvaluatedFullClosureValue:encoder: (in category 'code generation') ----- emitCodeForEvaluatedFullClosureValue: stack encoder: encoder | position | position := stack position. self emitCodeExceptLast: stack encoder: encoder. + (statements last == NodeNil + and: [self returns not]) + ifTrue: + [stack push: 1. + encoder genReturnNilToCaller. + pc := encoder methodStreamPosition] + ifFalse: + [statements last emitCodeForBlockValue: stack encoder: encoder. + self returns ifFalse: + [encoder genReturnTopToCaller. + pc := encoder methodStreamPosition]]. - statements last emitCodeForBlockValue: stack encoder: encoder. - self returns ifFalse: - [encoder genReturnTopToCaller. - pc := encoder methodStreamPosition]. self assert: stack position - 1 = position! Item was changed: + ----- Method: BlockNode>>emitCodeForFullBlockValue:encoder: (in category 'code generation') ----- - ----- Method: BlockNode>>emitCodeForFullBlockValue:encoder: (in category 'code generation (closures)') ----- emitCodeForFullBlockValue: stack encoder: encoder copiedValues do: [:copiedValue| copiedValue emitCodeForValue: stack encoder: encoder]. encoder genPushFullClosure: closureCreationNode index numCopied: copiedValues size. stack pop: copiedValues size; push: 1! Item was changed: ----- Method: BlockNode>>sizeCodeForEvaluatedFullClosureValue: (in category 'code generation') ----- sizeCodeForEvaluatedFullClosureValue: encoder "The closure value primitives push the arguments and the copied values. The compiler guarantees that any copied values come before all local temps. So on full closure activation we need do nothing." + (statements last == NodeNil + and: [self returns not]) ifTrue: + [^encoder sizeReturnNilToCaller]. ^(self sizeCodeForEvaluatedValue: encoder) + (self returns ifTrue: [0] ifFalse: [encoder sizeReturnTopToCaller])! Item was added: + ----- Method: BytecodeEncoder>>sizeReturnNilToCaller (in category 'opcode sizing') ----- + sizeReturnNilToCaller + ^self sizeOpcodeSelector: #genReturnNilToCaller withArguments: #()! Item was added: + ----- Method: EncoderForSistaV1>>genReturnNilToCaller (in category 'bytecode generation') ----- + genReturnNilToCaller + "93 01011101 BlockReturn nil [* return from enclosing block N, ExtA]" + "If extended, the least significant bit of the extension determines if we return to the caller or not + and the most significant bits determine how many levels of the static chain to return from. + ExtA = iiiiiiij + iiiiiii=0,j=0 => return to caller + iiiiiii=0,j=1 => illegal + iiiiiii=1,j=0 => return to outerContext + iiiiiii=1,j=1 => return to outerContext sender/return from outerContext + iiiiiii=2,j=0 => return to outerContext outerContext + iiiiiii=2,j=1 => return to outerContext outerContext sender/return from outerContext outerContext + etc" + + stream nextPut: 93! Item was changed: (PackageInfo named: 'Compiler') postscript: '"below, add code to be run after the loading of this package" + "Make sure that all those ``code generation (closures)'''' categoies disappear" + ParseNode withAllSubclasses do: + [:pnc| pnc organization removeEmptyCategories]'! - "Make sure all methods using to:do: and to:by:do: are recompiled" - UIManager default - informUser: ''Recompiling methods sending to:do: and to:by:do:'' - during: - [(self systemNavigation allMethodsSelect: - [:m| - #(to:do: to:by:do:) anySatisfy: [:l| m refersToLiteral: l]]) do: - [:mr| mr actualClass recompile: mr selector]]'!

1 0

extract method refactoring with assignment
by Eliot Miranda 05 Jan '18

05 Jan '18

Hi All, I tried an extract to method refactoring yesterday that failed. The method looked like | ... v1 v2 v3 | .... v1 := self m1. v2 := self m2. v3 := v3 collect: [:e| ...]. .... such that v1 and v2 were only used in the block, and the block was complex enough and did something useful e Pugh that I wanted to refactor as | ... v1 v2 v3 | .... v3 := self complexCollect: v3. .... complexCollect: a | v1 v2 | v1 := self m1. v2 := self m2. ^a collect: [:e| ...] So I was forced by the fact that assignment is written with the variable on the LHS to include "v3 := " in the selection to extract to method, even though my intent was for it not to be included. And of course the refactoring attempt fails precisely because the assignment /is/ included :-) Shouldn't this case be specially handled do that and trailing assignment is left behind in the refactored original method? Ifso, how would one go about it? Note that part of the prerequisite checks should also check that the variables v1 & v2 are not used elsewhere in the origins nail method and whether the refactoring is smart enough to remove them from the refactored origins nap is optional but definitely preferred. _,,,^..^,,,_ (phone)

2 1

The Trunk: Compiler-eem.362.mcz
by commits＠source.squeak.org 05 Jan '18

05 Jan '18

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.362.mcz ==================== Summary ==================== Name: Compiler-eem.362 Author: eem Time: 5 January 2018, 10:30:42.489732 am UUID: 6024b2f1-3e38-4625-a934-dd3f7cb29484 Ancestors: Compiler-eem.361 Implement super sends in full blocks. Since CompiledBlock uses the last literal to refer to the outer CompiledCode, it can't hold the class association used in conventional super sends. Hence within a block a super send must use the directed super send form. =============== Diff against Compiler-eem.361 =============== Item was added: + ----- Method: BytecodeEncoder>>generatingFullBlock (in category 'testing') ----- + generatingFullBlock + "Answer if the encoder is currently generating a FullBlock, embedded in some method." + + "When generating a FullBlock a copy of the encoder for the home emthod (rootNode) + is used, and hence the following is true." + ^rootNode encoder ~~ self! Item was added: + ----- Method: Decompiler>>directedSuperSend:numArgs: (in category 'instruction decoding') ----- + directedSuperSend: selector numArgs: numArgs + stack removeLast. "Discard the pushed class." + ^self send: selector super: true numArgs: numArgs! Item was changed: ----- Method: SelectorNode>>emitCode:args:encoder:super: (in category 'code generation') ----- emitCode: stack args: nArgs encoder: encoder super: supered stack pop: nArgs. ^supered ifTrue: + [(encoder supportsFullBlocks + and: [encoder generatingFullBlock]) + ifTrue: + [encoder genPushLiteral: (encoder sharableLitIndex: encoder classEncoding). + encoder genSendDirectedSuper: index numArgs: nArgs] + ifFalse: [encoder genSendSuper: index numArgs: nArgs]] - [encoder genSendSuper: index numArgs: nArgs] ifFalse: [encoder genSend: (code < Send ifTrue: [code negated] ifFalse: [index]) numArgs: nArgs]! Item was changed: ----- Method: SelectorNode>>sizeCode:args:super: (in category 'code generation') ----- sizeCode: encoder args: nArgs super: supered self reserve: encoder. ^supered ifTrue: [code < Send "i.e. its a special selector" ifTrue: [code := self code: (index := encoder sharableLitIndex: key) type: 5]. + (encoder supportsFullBlocks + and: [encoder generatingFullBlock]) + ifTrue: [(encoder sizePushLiteral: (encoder sharableLitIndex: encoder classEncoding)) + + (encoder sizeSendDirectedSuper: index numArgs: nArgs)] + ifFalse: [encoder sizeSendSuper: index numArgs: nArgs]] - encoder sizeSendSuper: index numArgs: nArgs] ifFalse: [self flag: #yuck. "special selector sends cause this problem" encoder sizeSend: (code < Send ifTrue: [code negated] ifFalse: [index]) numArgs: nArgs]!

1 0

Jump to page: