Squeak-dev April 2018

squeak-dev@lists.squeakfoundation.org

47 participants
159 discussions

The Trunk: ToolBuilder-Morphic-cmm.213.mcz
by commits＠source.squeak.org 10 Apr '18

10 Apr '18

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.213.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.213 Author: cmm Time: 9 April 2018, 7:24:08.252469 pm UUID: e26c8ea8-2621-4752-86be-c67aeb44c4fb Ancestors: ToolBuilder-Morphic-cmm.212 Fix. =============== Diff against ToolBuilder-Morphic-cmm.212 =============== Item was changed: ----- Method: FileSaverDialog>>selectFilename: (in category 'filename') ----- selectFilename: aText "The user has entered a potential filename in the text field. Check it against the current pattern; if it is ok we can accept it and then if it is a file in the current list, highlight it. If it would not match the pattern, alert the user." fileName := aText asString. ^ self selectExistingFilename ifTrue: [ self changed: #fileListIndex. true ] ifFalse: [ suffixList size = 1 ifTrue: [ | suffix | ((suffix := '.' , suffixList anyOne) + compare: (fileName last: (suffix size min: fileName size)) - compare: (fileName last: suffix size) caseSensitive: FileDirectory default isCaseSensitive) = 2 ifFalse: [ fileName := fileName , suffix ]. true ] ifFalse: [ suffixList at: (UIManager default chooseFrom: suffixList title: 'Please choose the type of file to save.') ifPresent: [ : choice | fileName := fileName , '.' , choice. true ] ifAbsent: [ suffixList isEmpty or: [ UIManager default inform: 'WARNING: File not saved!! A filename matching one of ' , patternList asArray asString , ' patterns is required.'. false ] ] ] ]!

1 0

Trunk update broken for smalltalkCI: MNU SystemProgressMorph>>currentWorld
by Jakob Reschke 09 Apr '18

09 Apr '18

Hello, My Travis builds fail and it looks like the trunk update is broken again: Preparing Squeak-trunk image for CI... .MessageNotUnderstood: SystemProgressMorph>>currentWorld > Time to run: 5.550s Build was unable to report intermediate build status. Same when I run smalltalkCI locally with Cygwin. The last things that I see in my local TravisCI.changes file are indeed Object removeSelector: #currentWorld, Object removeSelector: #currentHand, and Object removeSelector: #currentEvent. Was something similar not fixed in December already? http://forum.world.st/Squeak-trunk-updates-fail-td5059208.html Kind regards, Jakob

3 5

The Inbox: EToys-tcj.324.mcz
by commits＠source.squeak.org 09 Apr '18

09 Apr '18

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-tcj.324.mcz ==================== Summary ==================== Name: EToys-tcj.324 Author: tcj Time: 9 April 2018, 12:33:26.80885 pm UUID: 4cdd717b-002f-4dc1-96e4-b32bb0452038 Ancestors: EToys-nice.323 Replace deprecated (and removed) 3.8-era message sends with contemporary equivalents. Note: now that this works again, it exposes two sends of #isThisEverCalled. =============== Diff against EToys-nice.323 =============== Item was changed: ----- Method: PDA>>openMonthView (in category 'initialization') ----- openMonthView | row month col paneExtent window paneColor nRows | month := date notNil ifTrue: [date month] ifFalse: ["But... it's here somewhere..." ((self dependents detect: [:m | m isKindOf: PDAMorph]) findA: MonthMorph) month]. window := SystemWindow labelled: month printString. paneColor := Color transparent. window color: (Color r: 0.968 g: 1.0 b: 0.355). + nRows := 0. month weeksDo: [:w | nRows := nRows + 1]. - nRows := 0. month eachWeekDo: [:w | nRows := nRows + 1]. paneExtent := ((1.0/7) @ (1.0/nRows)). row := 0. + month weeksDo: - month eachWeekDo: [:week | col := 0. + week datesDo: - week do: [:day | day month = month ifTrue: [window addMorph: ((PluggableListMorph on: self list: nil selected: nil changeSelected: nil menu: nil keystroke: nil) list: {(day dayOfMonth printString , ' ' , day weekday) asText allBold} , (self scheduleListForDay: day)) frame: (paneExtent * (col@row) extent: paneExtent)]. col := col + 1]. row := row + 1]. window firstSubmorph color: paneColor. window updatePaneColors. window openInWorld!

2 2

The Trunk: ReleaseBuilder-mt.179.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.179.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.179 Author: mt Time: 8 April 2018, 12:17:48.92439 pm UUID: 11ddcc30-d7fe-9346-864b-f2850bcf3bb5 Ancestors: ReleaseBuilder-mt.178 Configure AppRegistry in ReleaseBuilder. See #prepareEnvironment and then #configureTools. =============== Diff against ReleaseBuilder-mt.178 =============== Item was changed: ----- Method: ReleaseBuilder class>>configureTools (in category 'scripts') ----- configureTools "Initialize well-known tools and other resources." FileList initialize. "register file reader services" RealEstateAgent standardSize: 600 @ 400. SMLoaderPlus setDefaultFilters: #(filterSafelyAvailable). + + "Default applications and tools." + SystemBrowser default: Browser. + MailSender default: nil. + SoundService default: BaseSoundSystem. + ToolSet default: StandardToolSet. + WebBrowser default: nil. !

1 0

The Trunk: Tests-mt.393.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.393.mcz ==================== Summary ==================== Name: Tests-mt.393 Author: mt Time: 8 April 2018, 12:12:58.97439 pm UUID: 008632aa-2ece-4049-b758-2e115e880217 Ancestors: Tests-eem.392 Adds test to ensure integrity of AppRegistries. =============== Diff against Tests-eem.392 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! + SystemOrganization addCategory: #'Tests-System-Applications'! Item was added: + TestCase subclass: #AppRegistryTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-System-Applications'! Item was added: + ----- Method: AppRegistryTest>>test01AppsAreBehaviors (in category 'tests') ----- + test01AppsAreBehaviors + "This test ensures the integrity of the given image state with respect to AppRegistry. After the ReleaseBuilder scripts ran, this test must pass." + + AppRegistry withAllSubclasses do: [:app | + self assert: (app registeredClasses reject: [:ea | ea isBehavior]) isEmpty].!

1 0

The Trunk: System-mt.1016.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1016.mcz ==================== Summary ==================== Name: System-mt.1016 Author: mt Time: 8 April 2018, 12:04:43.52839 pm UUID: c790b5f0-2bf7-eb47-ab42-0e1762236535 Ancestors: System-mt.1015 Now that we have cleaned-up the state of SoundService, we can simplify #defaultOrNil again. =============== Diff against System-mt.1015 =============== Item was changed: ----- Method: SoundService class>>defaultOrNil (in category 'accessing') ----- defaultOrNil + "This app registry returns instances instead of classes." + + ^ super defaultOrNil ifNotNil: [:default | default new]! - - ^ super defaultOrNil ifNotNil: [:default | - default isBehavior ifTrue: [default new] ifFalse: [default]] - !

1 0

The Trunk: System-mt.1015.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1015.mcz ==================== Summary ==================== Name: System-mt.1015 Author: mt Time: 8 April 2018, 12:01:31.43839 pm UUID: 42c64965-b457-4c45-962c-85944be8e436 Ancestors: System-mt.1014 Etoys tests could have messed with your SoundService app registry. This commit and script cleans that up. =============== Diff against System-mt.1014 =============== Item was changed: ----- Method: SoundService class>>default (in category 'accessing') ----- default + "This app registry returns instances instead of classes." + - | cls | cls := super default. ^ cls new! Item was added: + ----- Method: SoundService class>>default: (in category 'accessing') ----- + default: aClassOrNil + "See #default. This app registry returns instances instead of classes. Yet, make sure to only store classes so that always fresh instances will be returned." + + ^ super default: (aClassOrNil ifNotNil: [:obj | + obj isBehavior + ifTrue: [obj] + ifFalse: [obj class]])! Item was changed: + (PackageInfo named: 'System') postscript: '"Ensure that only classes are stored in the SoundService app registry." + SoundService default: SoundService defaultOrNil.'! - (PackageInfo named: 'System') postscript: '(Smalltalk specialSelectorNames includes: #~~) ifFalse: - ["Re-create the specialObjectsArray to let the jit optimize #~~. Also add the new primitive error codes if they are not there yet." - | senders | - senders := #(#~~ #blockCopy:) gather: [ :selector | - "Recompile senders blockCopy: too, just in case." - SystemNavigation default allCallsOn: selector ]. - Smalltalk recreateSpecialObjectsArray. - VariableNode initialize. - Decompiler initialize. - senders - do: [ :methodReference | - | class | - class := methodReference actualClass. - class recompile: methodReference selector from: class ] - displayingProgress: ''Recompiling...'']. - "If PrimitiveError is not in the primitiveErrorTable, or if an instance - of a different class is there, then add it." - (Smalltalk primitiveErrorTable size < 21 - or: [(Smalltalk primitiveErrorTable at: 21) class ~~ PrimitiveError]) ifTrue: - [Smalltalk recreateSpecialObjectsArray]'!

1 0

The Trunk: ToolBuilder-Morphic-cmm.212.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.212.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.212 Author: cmm Time: 7 April 2018, 7:19:41.653494 pm UUID: 66f83f51-b978-4030-be9c-fce2ca2491f0 Ancestors: ToolBuilder-Morphic-cmm.211 Fix minor code inelegance. =============== Diff against ToolBuilder-Morphic-cmm.211 =============== Item was changed: ----- Method: FileSaverDialog>>selectFilename: (in category 'filename') ----- selectFilename: aText "The user has entered a potential filename in the text field. Check it against the current pattern; if it is ok we can accept it and then if it is a file in the current list, highlight it. If it would not match the pattern, alert the user." fileName := aText asString. ^ self selectExistingFilename ifTrue: [ self changed: #fileListIndex. true ] ifFalse: [ suffixList size = 1 ifTrue: [ | suffix | ((suffix := '.' , suffixList anyOne) compare: (fileName last: suffix size) + caseSensitive: FileDirectory default isCaseSensitive) = 2 ifFalse: [ fileName := fileName , suffix ]. - caseSensitive: FileDirectory default isCaseSensitive) = 2 ifFalse: [ fileName := fileName , '.' , suffixList first ]. true ] ifFalse: [ suffixList at: (UIManager default chooseFrom: suffixList title: 'Please choose the type of file to save.') ifPresent: [ : choice | fileName := fileName , '.' , choice. true ] ifAbsent: [ suffixList isEmpty or: [ UIManager default inform: 'WARNING: File not saved!! A filename matching one of ' , patternList asArray asString , ' patterns is required.'. false ] ] ] ]!

1 0

The Trunk: ToolBuilder-Morphic-cmm.210.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.210.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.210 Author: cmm Time: 7 April 2018, 3:54:49.043193 pm UUID: 72fd894c-8465-4889-b0af-604220f410c8 Ancestors: ToolBuilder-Morphic-cmm.209 FileSaverDialog support default names with no extension. Allows saving files without an extension. =============== Diff against ToolBuilder-Morphic-cmm.209 =============== Item was changed: ----- Method: FileSaverDialog>>selectFilename: (in category 'filename') ----- selectFilename: aText "The user has entered a potential filename in the text field. Check it against the current pattern; if it is ok we can accept it and then if it is a file in the current list, highlight it. If it would not match the pattern, alert the user." fileName := aText asString. ^ self selectExistingFilename ifTrue: [ self changed: #fileListIndex. true ] ifFalse: [ suffixList size = 1 ifTrue: [ fileName := fileName , '.' , suffixList first. true ] ifFalse: [ suffixList at: (UIManager default chooseFrom: suffixList title: 'Please choose the type of file to save.') ifPresent: [ : choice | fileName := fileName , '.' , choice. true ] ifAbsent: + [ suffixList isEmpty or: + [ UIManager default inform: 'WARNING: File not saved!! A filename matching one of ' , patternList asArray asString , ' patterns is required.'. + false ] ] ] ]! - [ fileName := nil. - UIManager default inform: 'WARNING: File not saved!! A filename matching one of ' , patternList asArray asString , ' patterns is required.'. - false ] ] ]!

3 3

The Trunk: ToolBuilder-Morphic-cmm.211.mcz
by commits＠source.squeak.org 08 Apr '18

08 Apr '18

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.211.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.211 Author: cmm Time: 7 April 2018, 7:16:02.444544 pm UUID: e0ee1d62-8009-4ece-9e9a-8a781b7a8407 Ancestors: ToolBuilder-Morphic-cmm.210 Fix the FileSaverDialog case where the file is named .extension.extension and the user wishes to remove the double-extension. #selectExistingFilename was not enough to filter that case. =============== Diff against ToolBuilder-Morphic-cmm.210 =============== Item was changed: ----- Method: FileSaverDialog>>selectFilename: (in category 'filename') ----- selectFilename: aText "The user has entered a potential filename in the text field. Check it against the current pattern; if it is ok we can accept it and then if it is a file in the current list, highlight it. If it would not match the pattern, alert the user." fileName := aText asString. ^ self selectExistingFilename ifTrue: [ self changed: #fileListIndex. true ] ifFalse: [ suffixList size = 1 ifTrue: + [ | suffix | + ((suffix := '.' , suffixList anyOne) + compare: (fileName last: suffix size) + caseSensitive: FileDirectory default isCaseSensitive) = 2 ifFalse: [ fileName := fileName , '.' , suffixList first ]. - [ fileName := fileName , '.' , suffixList first. true ] ifFalse: [ suffixList at: (UIManager default chooseFrom: suffixList title: 'Please choose the type of file to save.') ifPresent: [ : choice | fileName := fileName , '.' , choice. true ] ifAbsent: [ suffixList isEmpty or: [ UIManager default inform: 'WARNING: File not saved!! A filename matching one of ' , patternList asArray asString , ' patterns is required.'. false ] ] ] ]!

1 0

Jump to page: