Squeak-dev January 2019

squeak-dev@lists.squeakfoundation.org

41 participants
152 discussions

The Trunk: Monticello-tpr.692.mcz
by commits＠source.squeak.org 09 Jan '19

09 Jan '19

tim Rowledge uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-tpr.692.mcz ==================== Summary ==================== Name: Monticello-tpr.692 Author: tpr Time: 8 January 2019, 4:23:59.248778 pm UUID: a862f6b9-68d9-485a-846d-5982128901aa Ancestors: Monticello-pre.691 Use FileServices as the registry instead of FileList =============== Diff against Monticello-pre.691 =============== Item was changed: ----- Method: MCVersionReader class>>initialize (in category 'file services') ----- initialize "MCVersionReader initialize" Smalltalk at: #MczInstaller + ifPresent: [:installer | FileServices unregisterFileReader: installer]. + self concreteSubclassesDo: [:aClass | FileServices registerFileReader: aClass]. - ifPresent: [:installer | FileList unregisterFileReader: installer]. - self concreteSubclassesDo: [:aClass | FileList registerFileReader: aClass]. "get rid of AnObsoleteMCMcReader and AnObsoleteMCMcvReader" + (FileServices registeredFileReaderClasses select: [ :ea | ea isObsolete ]) do: + [ :ea | FileServices unregisterFileReader: ea ] - (FileList registeredFileReaderClasses select: [ :ea | ea isObsolete ]) do: - [ :ea | FileList unregisterFileReader: ea ] ! Item was changed: ----- Method: MCVersionReader class>>unload (in category 'file services') ----- unload + FileServices unregisterFileReader: self ! - FileList unregisterFileReader: self !

1 0

The Trunk: CommandLine-tpr.12.mcz
by commits＠source.squeak.org 09 Jan '19

09 Jan '19

tim Rowledge uploaded a new version of CommandLine to project The Trunk: http://source.squeak.org/trunk/CommandLine-tpr.12.mcz ==================== Summary ==================== Name: CommandLine-tpr.12 Author: tpr Time: 8 January 2019, 4:22:55.163983 pm UUID: 4c15326f-0f4c-41e8-a0c8-b750307c2253 Ancestors: CommandLine-pre.11 Move a couple of previously deprecated methods to the actual deprecated package =============== Diff against CommandLine-pre.11 =============== Item was removed: - ----- Method: DummyUIManager>>openPluggableFileList:label:in: (in category 'ui project indirecting') ----- - openPluggableFileList: aPluggableFileList label: aString in: aWorld - "PluggableFileList is being deprecated and this can go away soon" - ^nil!

1 0

The Trunk: 60Deprecated-tpr.31.mcz
by commits＠source.squeak.org 09 Jan '19

09 Jan '19

tim Rowledge uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-tpr.31.mcz ==================== Summary ==================== Name: 60Deprecated-tpr.31 Author: tpr Time: 8 January 2019, 4:21:59.062127 pm UUID: 6c5cf795-7e93-4440-999c-a02f0b467d61 Ancestors: 60Deprecated-tpr.30 Move a couple of previously deprecated methods to the actual deprecated package. =============== Diff against 60Deprecated-tpr.30 =============== Item was added: + ----- Method: DummyUIManager>>openPluggableFileList:label:in: (in category '*60Deprecated') ----- + openPluggableFileList: aPluggableFileList label: aString in: aWorld + "PluggableFileList is being deprecated and this can go away soon" + ^nil! Item was changed: ----- Method: DummyUIManager>>openPluggableFileListLabel:in: (in category '*60Deprecated') ----- openPluggableFileListLabel: aString in: aWorld "PluggableFileList is being deprecated and this can go away soon" - "This method is not used anymore in 5.2 by any system classes and seems to have been - renamed to openPluggableFileList:label:in:" ^nil!

1 0

Collection>sum fails on empty collection
by tim Rowledge 08 Jan '19

08 Jan '19

#() sum -> errorEmptyCollection. #sum uses #reduce: and I can see why #reduce might consider an empty collection an error - but I also see that #sum of an empty collection probably ought to be 0, at least in a lot of cases. And I'd note that using a simple #inject:into: - in the case of a million item Array, at least - took about 60% of the time of the current #sum. Why did this come up? In an MVC Project I tested PluggableFileList getFolderDialog openLabel: 'foo' whilst seeing if PluggableFileList had any uses. It turns out that building a PluggableFileList in MVC doesn't work. Somewhere we end up trying to build a pluggablepanel with no children, which makes the logic in MVCToolBuilder>>setLayout:in: get upset. I don't care enough about making MVC stuff work to be willing to spend time on that. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Fractured Idiom:- RIGOR MORRIS - The cat is dead

4 6

The Trunk: Tools-tpr.841.mcz
by commits＠source.squeak.org 08 Jan '19

08 Jan '19

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.841.mcz ==================== Summary ==================== Name: Tools-tpr.841 Author: tpr Time: 8 January 2019, 1:39:36.243579 pm UUID: 65dee67e-8e49-4f90-94e3-6f21705c74d2 Ancestors: Tools-pre.840 Deprecate the StandardFileMenu system. We have the concrete subclasses of FileAbstractSelectionDialog now. Assuming this has been done in the correct order you should now find StandardFileMenu in 60Deprecate-Tools-Menus =============== Diff against Tools-pre.840 =============== Item was removed: - SelectionMenu subclass: #StandardFileMenu - instanceVariableNames: 'canTypeFileName pattern' - classVariableNames: '' - poolDictionaries: '' - category: 'Tools-Menus'! - - !StandardFileMenu commentStamp: 'mp 8/15/2005 18:44' prior: 0! - I represent a SelectionMenu which operates like a modal dialog for selecting files, somewhat similar to the StandardFile dialogs in MacOS and Java Swing. - - Try for example, the following: - - StandardFileMenu oldFile inspect - - StandardFileMenu oldFileStream inspect - - StandardFileMenu newFile inspect - - StandardFileMenu newFileStream inspect - - (StandardFileMenu oldFileMenu: FileDirectory default withPattern: '*') startUpWithCaption: 'Select a file:' - - (StandardFileMenu oldFileMenu: (FileDirectory default) withPatternList: {'*.txt'. '*.changes'}) startUpWithCaption: 'Select a file:' - ! Item was removed: - ----- Method: StandardFileMenu class>>newFile (in category 'standard file operations') ----- - newFile - - ^self newFileFrom: (FileDirectory default)! Item was removed: - ----- Method: StandardFileMenu class>>newFileFrom: (in category 'standard file operations') ----- - newFileFrom: aDirectory - - ^(self newFileMenu: aDirectory) - startUpWithCaption: 'Select a File:' translated! Item was removed: - ----- Method: StandardFileMenu class>>newFileMenu: (in category 'instance creation') ----- - newFileMenu: aDirectory - Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. - ^ super new newFileFrom: aDirectory! Item was removed: - ----- Method: StandardFileMenu class>>newFileMenu:withPattern: (in category 'instance creation') ----- - newFileMenu: aDirectory withPattern: aPattern - Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. - ^ super new newFileFrom: aDirectory withPattern: aPattern! Item was removed: - ----- Method: StandardFileMenu class>>newFileMenu:withPatternList: (in category 'instance creation') ----- - newFileMenu: aDirectory withPatternList: aPatternList - Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. - ^ super new newFileFrom: aDirectory withPatternList: aPatternList! Item was removed: - ----- Method: StandardFileMenu class>>newFileStream (in category 'standard file operations') ----- - newFileStream - - ^self newFileStreamFrom: (FileDirectory default)! Item was removed: - ----- Method: StandardFileMenu class>>newFileStreamFrom: (in category 'standard file operations') ----- - newFileStreamFrom: aDirectory - - | sfmResult fileStream | - sfmResult := self newFileFrom: aDirectory. - sfmResult ifNil: [^nil]. - fileStream := sfmResult directory newFileNamed: sfmResult name. - [fileStream isNil] whileTrue: - [sfmResult := self newFileFrom: aDirectory. - sfmResult ifNil: [^nil]. - fileStream := sfmResult directory newFileNamed: sfmResult name]. - ^fileStream - ! Item was removed: - ----- Method: StandardFileMenu class>>oldFile (in category 'standard file operations') ----- - oldFile - - ^self oldFileFrom: (FileDirectory default)! Item was removed: - ----- Method: StandardFileMenu class>>oldFileFrom: (in category 'standard file operations') ----- - oldFileFrom: aDirectory - - ^(self oldFileMenu: aDirectory) - startUpWithCaption: 'Select a File:' translated! Item was removed: - ----- Method: StandardFileMenu class>>oldFileFrom:withPattern: (in category 'standard file operations') ----- - oldFileFrom: aDirectory withPattern: aPattern - " - Select an existing file from a selection conforming to aPattern. - " - ^(self oldFileMenu: aDirectory withPattern: aPattern) - startUpWithCaption: 'Select a File:' translated! Item was removed: - ----- Method: StandardFileMenu class>>oldFileMenu: (in category 'instance creation') ----- - oldFileMenu: aDirectory - Smalltalk isMorphic ifFalse: [^ PluggableFileList oldFileMenu: aDirectory]. - ^ super new oldFileFrom: aDirectory! Item was removed: - ----- Method: StandardFileMenu class>>oldFileMenu:withPattern: (in category 'instance creation') ----- - oldFileMenu: aDirectory withPattern: aPattern - - Smalltalk isMorphic ifFalse: [^PluggableFileList oldFileMenu: aDirectory]. - ^super new oldFileFrom: aDirectory withPattern: aPattern! Item was removed: - ----- Method: StandardFileMenu class>>oldFileMenu:withPatternList: (in category 'instance creation') ----- - oldFileMenu: aDirectory withPatternList: aPatternList - - Smalltalk isMorphic ifFalse: [^PluggableFileList oldFileMenu: aDirectory]. - ^super new oldFileFrom: aDirectory withPatternList: aPatternList! Item was removed: - ----- Method: StandardFileMenu class>>oldFileStream (in category 'standard file operations') ----- - oldFileStream - - ^self oldFileStreamFrom: (FileDirectory default) - ! Item was removed: - ----- Method: StandardFileMenu class>>oldFileStreamFrom: (in category 'standard file operations') ----- - oldFileStreamFrom: aDirectory - - | sfmResult fileStream | - sfmResult := self oldFileFrom: aDirectory. - sfmResult ifNil: [^nil]. - fileStream := sfmResult directory oldFileNamed: sfmResult name. - [fileStream isNil] whileTrue: - [sfmResult := self oldFileFrom: aDirectory. - sfmResult ifNil: [^nil]. - fileStream := sfmResult directory oldFileNamed: sfmResult name]. - ^fileStream - ! Item was removed: - ----- Method: StandardFileMenu>>advance:containingDirectoriesFrom: (in category 'private') ----- - advance: anInteger containingDirectoriesFrom: aDirectory - - | theDirectory | - theDirectory := aDirectory. - 1 to: anInteger do: [:i | theDirectory := theDirectory containingDirectory]. - ^theDirectory! Item was removed: - ----- Method: StandardFileMenu>>confirmExistingFiles: (in category 'basic control sequences') ----- - confirmExistingFiles: aResult - - |choice| - (aResult directory fileExists: aResult name) ifFalse: [^aResult]. - - choice := (UIManager default chooseFrom: #('overwrite that file' 'choose another name' - 'cancel') - title: aResult name, ' - already exists.'). - - choice = 1 ifTrue: [ - aResult directory - deleteFileNamed: aResult name - ifAbsent: - [^self startUpWithCaption: - 'Can''t delete ', aResult name, ' - Select another file']. - ^aResult]. - choice = 2 ifTrue: [^self startUpWithCaption: 'Select Another File']. - ^nil - ! Item was removed: - ----- Method: StandardFileMenu>>directoryNamesString: (in category 'menu building') ----- - directoryNamesString: aDirectory - "Answer a string concatenating the directory name strings in aDirectory, each string followed by a '[...]' indicator, and followed by a cr." - - ^ String streamContents: - [:s | aDirectory directoryNames do: - [:dn | s nextPutAll: dn withBlanksTrimmed , ' [...]'; cr]] - - ! Item was removed: - ----- Method: StandardFileMenu>>fileNamesString: (in category 'menu building') ----- - fileNamesString: aDirectory - "Answer a string concatenating the file name strings in aDirectory, each string followed by a cr." - - ^String streamContents: - [:s | - aDirectory fileNames do: - [:fn | - pattern do:[:each | (each match: fn) ifTrue: [ - s nextPutAll: fn withBlanksTrimmed; cr]]]] - ! Item was removed: - ----- Method: StandardFileMenu>>getTypedFileName: (in category 'basic control sequences') ----- - getTypedFileName: aResult - - | name | - name := UIManager default - request: 'Enter a new file name' - initialAnswer: ''. - name = '' ifTrue: [^self startUpWithCaption: 'Select a File:' translated]. - name := aResult directory fullNameFor: name. - ^ StandardFileMenuResult - directory: (FileDirectory forFileName: name) - name: (FileDirectory localNameFor: name) - ! Item was removed: - ----- Method: StandardFileMenu>>makeFileMenuFor: (in category 'menu building') ----- - makeFileMenuFor: aDirectory - "Initialize an instance of me to operate on aDirectory" - - | theMenu | - pattern ifNil: [pattern := {'*'}]. - Cursor wait showWhile: - [self - labels: (self menuLabelsString: aDirectory) - font: (MenuStyle fontAt: 1) - lines: (self menuLinesArray: aDirectory). - theMenu := self selections: (self menuSelectionsArray: aDirectory)]. - ^theMenu! Item was removed: - ----- Method: StandardFileMenu>>menuLabelsString: (in category 'menu building') ----- - menuLabelsString: aDirectory - "Answer a menu labels object corresponding to aDirectory" - - ^ String streamContents: - [:s | - canTypeFileName ifTrue: - [s nextPutAll: 'Enter File Name...'; cr]. - s nextPutAll: (self pathPartsString: aDirectory). - s nextPutAll: (self directoryNamesString: aDirectory). - s nextPutAll: (self fileNamesString: aDirectory). - s skip: -1]! Item was removed: - ----- Method: StandardFileMenu>>menuLinesArray: (in category 'menu building') ----- - menuLinesArray: aDirectory - "Answer a menu lines object corresponding to aDirectory" - - | typeCount nameCnt dirDepth| - typeCount := canTypeFileName - ifTrue: [1] - ifFalse: [0]. - nameCnt := aDirectory directoryNames size. - dirDepth := aDirectory pathParts size. - ^Array streamContents: [:s | - canTypeFileName ifTrue: [s nextPut: 1]. - s nextPut: dirDepth + typeCount + 1. - s nextPut: dirDepth + nameCnt + typeCount + 1]! Item was removed: - ----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') ----- - menuSelectionsArray: aDirectory - "Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a selector to operate on and the second element of which contains the parameters for that selector." - - |dirSize| - dirSize := aDirectory pathParts size. - ^Array streamContents: [:s | - canTypeFileName ifTrue: - [s nextPut: (StandardFileMenuResult - directory: aDirectory - name: nil)]. - s nextPut: (StandardFileMenuResult - directory: (FileDirectory root) - name: ''). - aDirectory pathParts doWithIndex: - [:d :i | s nextPut: (StandardFileMenuResult - directory: (self - advance: dirSize - i - containingDirectoriesFrom: aDirectory) - name: '')]. - aDirectory directoryNames do: - [:dn | s nextPut: (StandardFileMenuResult - directory: (FileDirectory on: (aDirectory fullNameFor: dn)) - name: '')]. - aDirectory fileNames do: - [:fn | pattern do: [:pat | (pat match: fn) ifTrue: [ - s nextPut: (StandardFileMenuResult - directory: aDirectory - name: fn)]]]]! Item was removed: - ----- Method: StandardFileMenu>>newFileFrom: (in category 'private') ----- - newFileFrom: aDirectory - - canTypeFileName := true. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>newFileFrom:withPattern: (in category 'private') ----- - newFileFrom: aDirectory withPattern: aPattern - - canTypeFileName := true. - pattern := {aPattern}. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>newFileFrom:withPatternList: (in category 'private') ----- - newFileFrom: aDirectory withPatternList: aPatternList - - canTypeFileName := true. - pattern := aPatternList. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>oldFileFrom: (in category 'private') ----- - oldFileFrom: aDirectory - - canTypeFileName := false. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>oldFileFrom:withPattern: (in category 'private') ----- - oldFileFrom: aDirectory withPattern: aPattern - - canTypeFileName := false. - pattern := {aPattern}. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>oldFileFrom:withPatternList: (in category 'private') ----- - oldFileFrom: aDirectory withPatternList: aPatternList - - canTypeFileName := false. - pattern := aPatternList. - ^self makeFileMenuFor: aDirectory! Item was removed: - ----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') ----- - pathPartsString: aDirectory - "Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr." - - ^String streamContents: - [:s | - s nextPutAll: '[]'; cr. - aDirectory pathParts asArray doWithIndex: - [:part :i | - s next: i put: $ . - s nextPutAll: part withBlanksTrimmed; cr]]! Item was removed: - ----- Method: StandardFileMenu>>pattern: (in category 'private') ----- - pattern: aPattern - " * for all files, or '*.cs' for changeSets, etc. Just like fileLists" - - pattern := {aPattern}! Item was removed: - ----- Method: StandardFileMenu>>patternList: (in category 'private') ----- - patternList: aPatternList - - pattern := aPatternList! Item was removed: - ----- Method: StandardFileMenu>>startUpWithCaption:at: (in category 'basic control sequences') ----- - startUpWithCaption: aString at: location - - |result| - result := super startUpWithCaption: aString at: location. - result ifNil: [^nil]. - result isDirectory ifTrue: - [self makeFileMenuFor: result directory. - self computeForm. - ^self startUpWithCaption: aString at: location]. - result isCommand ifTrue: - [result := self getTypedFileName: result. - result ifNil: [^nil]]. - canTypeFileName ifTrue: [^self confirmExistingFiles: result]. - ^result - ! Item was removed: - Object subclass: #StandardFileMenuResult - instanceVariableNames: 'directory name' - classVariableNames: '' - poolDictionaries: '' - category: 'Tools-Menus'! Item was removed: - ----- Method: StandardFileMenuResult class>>directory:name: (in category 'instance creation') ----- - directory: aDirectory name: aString - - ^super new directory: aDirectory name: aString! Item was removed: - ----- Method: StandardFileMenuResult>>directory (in category 'accessing') ----- - directory - - ^directory! Item was removed: - ----- Method: StandardFileMenuResult>>directory: (in category 'accessing') ----- - directory: aDirectory - - ^directory := aDirectory! Item was removed: - ----- Method: StandardFileMenuResult>>directory:name: (in category 'private') ----- - directory: aDirectory name: aString - - directory := aDirectory. - name := aString. - ^self! Item was removed: - ----- Method: StandardFileMenuResult>>isCommand (in category 'testing') ----- - isCommand - - ^name isNil! Item was removed: - ----- Method: StandardFileMenuResult>>isDirectory (in category 'testing') ----- - isDirectory - - ^name = ''! Item was removed: - ----- Method: StandardFileMenuResult>>name (in category 'accessing') ----- - name - - ^name! Item was removed: - ----- Method: StandardFileMenuResult>>name: (in category 'accessing') ----- - name: aString - - ^name := aString! Item was removed: - ----- Method: StandardFileMenuResult>>printOn: (in category 'accessing') ----- - printOn: aStream - super printOn: aStream. - aStream nextPutAll: ' with directory: '. - directory printOn: aStream. - aStream nextPutAll: ' name: '. - name printOn: aStream - - "StandardFileMenu oldFile"!

1 0

The Trunk: 60Deprecated-tpr.30.mcz
by commits＠source.squeak.org 08 Jan '19

08 Jan '19

tim Rowledge uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-tpr.30.mcz ==================== Summary ==================== Name: 60Deprecated-tpr.30 Author: tpr Time: 8 January 2019, 1:37:16.779475 pm UUID: ff5f1121-074a-4488-ac7d-21381ca96cbf Ancestors: 60Deprecated-pre.29 Deprecate the StandardFileMenu system. We have the concrete subclasses of FileAbstractSelectionDialog now. =============== Diff against 60Deprecated-pre.29 =============== Item was changed: SystemOrganization addCategory: #'60Deprecated-Collections-Streams'! SystemOrganization addCategory: #'60Deprecated-Kernel-Methods'! SystemOrganization addCategory: #'60Deprecated-System-Support'! SystemOrganization addCategory: #'60Deprecated-Tools-Inspector'! + SystemOrganization addCategory: #'60Deprecated-Tools-Menus'! Item was added: + SelectionMenu subclass: #StandardFileMenu + instanceVariableNames: 'canTypeFileName pattern' + classVariableNames: '' + poolDictionaries: '' + category: '60Deprecated-Tools-Menus'! + + !StandardFileMenu commentStamp: 'tpr 1/8/2019 13:33' prior: 0! + Deprecated: please don't use this class. It provides a really unpleasant UI (after all it was based on java 'swing') that can be better done by using one of the concrete subclasses of FileAbstractSelectionDialog. + + Obsoloete comment: + I represent a SelectionMenu which operates like a modal dialog for selecting files, somewhat similar to the StandardFile dialogs in MacOS and Java Swing. + + Try for example, the following: + + StandardFileMenu oldFile inspect + + StandardFileMenu oldFileStream inspect + + StandardFileMenu newFile inspect + + StandardFileMenu newFileStream inspect + + (StandardFileMenu oldFileMenu: FileDirectory default withPattern: '*') startUpWithCaption: 'Select a file:' + + (StandardFileMenu oldFileMenu: (FileDirectory default) withPatternList: {'*.txt'. '*.changes'}) startUpWithCaption: 'Select a file:' + ! Item was added: + ----- Method: StandardFileMenu class>>newFile (in category 'standard file operations') ----- + newFile + + ^self newFileFrom: (FileDirectory default)! Item was added: + ----- Method: StandardFileMenu class>>newFileFrom: (in category 'standard file operations') ----- + newFileFrom: aDirectory + + ^(self newFileMenu: aDirectory) + startUpWithCaption: 'Select a File:' translated! Item was added: + ----- Method: StandardFileMenu class>>newFileMenu: (in category 'instance creation') ----- + newFileMenu: aDirectory + Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. + ^ super new newFileFrom: aDirectory! Item was added: + ----- Method: StandardFileMenu class>>newFileMenu:withPattern: (in category 'instance creation') ----- + newFileMenu: aDirectory withPattern: aPattern + Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. + ^ super new newFileFrom: aDirectory withPattern: aPattern! Item was added: + ----- Method: StandardFileMenu class>>newFileMenu:withPatternList: (in category 'instance creation') ----- + newFileMenu: aDirectory withPatternList: aPatternList + Smalltalk isMorphic ifFalse: [^ PluggableFileList newFileMenu: aDirectory]. + ^ super new newFileFrom: aDirectory withPatternList: aPatternList! Item was added: + ----- Method: StandardFileMenu class>>newFileStream (in category 'standard file operations') ----- + newFileStream + + ^self newFileStreamFrom: (FileDirectory default)! Item was added: + ----- Method: StandardFileMenu class>>newFileStreamFrom: (in category 'standard file operations') ----- + newFileStreamFrom: aDirectory + + | sfmResult fileStream | + sfmResult := self newFileFrom: aDirectory. + sfmResult ifNil: [^nil]. + fileStream := sfmResult directory newFileNamed: sfmResult name. + [fileStream isNil] whileTrue: + [sfmResult := self newFileFrom: aDirectory. + sfmResult ifNil: [^nil]. + fileStream := sfmResult directory newFileNamed: sfmResult name]. + ^fileStream + ! Item was added: + ----- Method: StandardFileMenu class>>oldFile (in category 'standard file operations') ----- + oldFile + + ^self oldFileFrom: (FileDirectory default)! Item was added: + ----- Method: StandardFileMenu class>>oldFileFrom: (in category 'standard file operations') ----- + oldFileFrom: aDirectory + + ^(self oldFileMenu: aDirectory) + startUpWithCaption: 'Select a File:' translated! Item was added: + ----- Method: StandardFileMenu class>>oldFileFrom:withPattern: (in category 'standard file operations') ----- + oldFileFrom: aDirectory withPattern: aPattern + " + Select an existing file from a selection conforming to aPattern. + " + ^(self oldFileMenu: aDirectory withPattern: aPattern) + startUpWithCaption: 'Select a File:' translated! Item was added: + ----- Method: StandardFileMenu class>>oldFileMenu: (in category 'instance creation') ----- + oldFileMenu: aDirectory + Smalltalk isMorphic ifFalse: [^ PluggableFileList oldFileMenu: aDirectory]. + ^ super new oldFileFrom: aDirectory! Item was added: + ----- Method: StandardFileMenu class>>oldFileMenu:withPattern: (in category 'instance creation') ----- + oldFileMenu: aDirectory withPattern: aPattern + + Smalltalk isMorphic ifFalse: [^PluggableFileList oldFileMenu: aDirectory]. + ^super new oldFileFrom: aDirectory withPattern: aPattern! Item was added: + ----- Method: StandardFileMenu class>>oldFileMenu:withPatternList: (in category 'instance creation') ----- + oldFileMenu: aDirectory withPatternList: aPatternList + + Smalltalk isMorphic ifFalse: [^PluggableFileList oldFileMenu: aDirectory]. + ^super new oldFileFrom: aDirectory withPatternList: aPatternList! Item was added: + ----- Method: StandardFileMenu class>>oldFileStream (in category 'standard file operations') ----- + oldFileStream + + ^self oldFileStreamFrom: (FileDirectory default) + ! Item was added: + ----- Method: StandardFileMenu class>>oldFileStreamFrom: (in category 'standard file operations') ----- + oldFileStreamFrom: aDirectory + + | sfmResult fileStream | + sfmResult := self oldFileFrom: aDirectory. + sfmResult ifNil: [^nil]. + fileStream := sfmResult directory oldFileNamed: sfmResult name. + [fileStream isNil] whileTrue: + [sfmResult := self oldFileFrom: aDirectory. + sfmResult ifNil: [^nil]. + fileStream := sfmResult directory oldFileNamed: sfmResult name]. + ^fileStream + ! Item was added: + ----- Method: StandardFileMenu>>advance:containingDirectoriesFrom: (in category 'private') ----- + advance: anInteger containingDirectoriesFrom: aDirectory + + | theDirectory | + theDirectory := aDirectory. + 1 to: anInteger do: [:i | theDirectory := theDirectory containingDirectory]. + ^theDirectory! Item was added: + ----- Method: StandardFileMenu>>confirmExistingFiles: (in category 'basic control sequences') ----- + confirmExistingFiles: aResult + + |choice| + (aResult directory fileExists: aResult name) ifFalse: [^aResult]. + + choice := (UIManager default chooseFrom: #('overwrite that file' 'choose another name' + 'cancel') + title: aResult name, ' + already exists.'). + + choice = 1 ifTrue: [ + aResult directory + deleteFileNamed: aResult name + ifAbsent: + [^self startUpWithCaption: + 'Can''t delete ', aResult name, ' + Select another file']. + ^aResult]. + choice = 2 ifTrue: [^self startUpWithCaption: 'Select Another File']. + ^nil + ! Item was added: + ----- Method: StandardFileMenu>>directoryNamesString: (in category 'menu building') ----- + directoryNamesString: aDirectory + "Answer a string concatenating the directory name strings in aDirectory, each string followed by a '[...]' indicator, and followed by a cr." + + ^ String streamContents: + [:s | aDirectory directoryNames do: + [:dn | s nextPutAll: dn withBlanksTrimmed , ' [...]'; cr]] + + ! Item was added: + ----- Method: StandardFileMenu>>fileNamesString: (in category 'menu building') ----- + fileNamesString: aDirectory + "Answer a string concatenating the file name strings in aDirectory, each string followed by a cr." + + ^String streamContents: + [:s | + aDirectory fileNames do: + [:fn | + pattern do:[:each | (each match: fn) ifTrue: [ + s nextPutAll: fn withBlanksTrimmed; cr]]]] + ! Item was added: + ----- Method: StandardFileMenu>>getTypedFileName: (in category 'basic control sequences') ----- + getTypedFileName: aResult + + | name | + name := UIManager default + request: 'Enter a new file name' + initialAnswer: ''. + name = '' ifTrue: [^self startUpWithCaption: 'Select a File:' translated]. + name := aResult directory fullNameFor: name. + ^ StandardFileMenuResult + directory: (FileDirectory forFileName: name) + name: (FileDirectory localNameFor: name) + ! Item was added: + ----- Method: StandardFileMenu>>makeFileMenuFor: (in category 'menu building') ----- + makeFileMenuFor: aDirectory + "Initialize an instance of me to operate on aDirectory" + + | theMenu | + pattern ifNil: [pattern := {'*'}]. + Cursor wait showWhile: + [self + labels: (self menuLabelsString: aDirectory) + font: (MenuStyle fontAt: 1) + lines: (self menuLinesArray: aDirectory). + theMenu := self selections: (self menuSelectionsArray: aDirectory)]. + ^theMenu! Item was added: + ----- Method: StandardFileMenu>>menuLabelsString: (in category 'menu building') ----- + menuLabelsString: aDirectory + "Answer a menu labels object corresponding to aDirectory" + + ^ String streamContents: + [:s | + canTypeFileName ifTrue: + [s nextPutAll: 'Enter File Name...'; cr]. + s nextPutAll: (self pathPartsString: aDirectory). + s nextPutAll: (self directoryNamesString: aDirectory). + s nextPutAll: (self fileNamesString: aDirectory). + s skip: -1]! Item was added: + ----- Method: StandardFileMenu>>menuLinesArray: (in category 'menu building') ----- + menuLinesArray: aDirectory + "Answer a menu lines object corresponding to aDirectory" + + | typeCount nameCnt dirDepth| + typeCount := canTypeFileName + ifTrue: [1] + ifFalse: [0]. + nameCnt := aDirectory directoryNames size. + dirDepth := aDirectory pathParts size. + ^Array streamContents: [:s | + canTypeFileName ifTrue: [s nextPut: 1]. + s nextPut: dirDepth + typeCount + 1. + s nextPut: dirDepth + nameCnt + typeCount + 1]! Item was added: + ----- Method: StandardFileMenu>>menuSelectionsArray: (in category 'menu building') ----- + menuSelectionsArray: aDirectory + "Answer a menu selections object corresponding to aDirectory. The object is an array corresponding to each item, each element itself constituting a two-element array, the first element of which contains a selector to operate on and the second element of which contains the parameters for that selector." + + |dirSize| + dirSize := aDirectory pathParts size. + ^Array streamContents: [:s | + canTypeFileName ifTrue: + [s nextPut: (StandardFileMenuResult + directory: aDirectory + name: nil)]. + s nextPut: (StandardFileMenuResult + directory: (FileDirectory root) + name: ''). + aDirectory pathParts doWithIndex: + [:d :i | s nextPut: (StandardFileMenuResult + directory: (self + advance: dirSize - i + containingDirectoriesFrom: aDirectory) + name: '')]. + aDirectory directoryNames do: + [:dn | s nextPut: (StandardFileMenuResult + directory: (FileDirectory on: (aDirectory fullNameFor: dn)) + name: '')]. + aDirectory fileNames do: + [:fn | pattern do: [:pat | (pat match: fn) ifTrue: [ + s nextPut: (StandardFileMenuResult + directory: aDirectory + name: fn)]]]]! Item was added: + ----- Method: StandardFileMenu>>newFileFrom: (in category 'private') ----- + newFileFrom: aDirectory + + canTypeFileName := true. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>newFileFrom:withPattern: (in category 'private') ----- + newFileFrom: aDirectory withPattern: aPattern + + canTypeFileName := true. + pattern := {aPattern}. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>newFileFrom:withPatternList: (in category 'private') ----- + newFileFrom: aDirectory withPatternList: aPatternList + + canTypeFileName := true. + pattern := aPatternList. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>oldFileFrom: (in category 'private') ----- + oldFileFrom: aDirectory + + canTypeFileName := false. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>oldFileFrom:withPattern: (in category 'private') ----- + oldFileFrom: aDirectory withPattern: aPattern + + canTypeFileName := false. + pattern := {aPattern}. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>oldFileFrom:withPatternList: (in category 'private') ----- + oldFileFrom: aDirectory withPatternList: aPatternList + + canTypeFileName := false. + pattern := aPatternList. + ^self makeFileMenuFor: aDirectory! Item was added: + ----- Method: StandardFileMenu>>pathPartsString: (in category 'menu building') ----- + pathPartsString: aDirectory + "Answer a string concatenating the path parts strings in aDirectory, each string followed by a cr." + + ^String streamContents: + [:s | + s nextPutAll: '[]'; cr. + aDirectory pathParts asArray doWithIndex: + [:part :i | + s next: i put: $ . + s nextPutAll: part withBlanksTrimmed; cr]]! Item was added: + ----- Method: StandardFileMenu>>pattern: (in category 'private') ----- + pattern: aPattern + " * for all files, or '*.cs' for changeSets, etc. Just like fileLists" + + pattern := {aPattern}! Item was added: + ----- Method: StandardFileMenu>>patternList: (in category 'private') ----- + patternList: aPatternList + + pattern := aPatternList! Item was added: + ----- Method: StandardFileMenu>>startUpWithCaption:at: (in category 'basic control sequences') ----- + startUpWithCaption: aString at: location + + |result| + result := super startUpWithCaption: aString at: location. + result ifNil: [^nil]. + result isDirectory ifTrue: + [self makeFileMenuFor: result directory. + self computeForm. + ^self startUpWithCaption: aString at: location]. + result isCommand ifTrue: + [result := self getTypedFileName: result. + result ifNil: [^nil]]. + canTypeFileName ifTrue: [^self confirmExistingFiles: result]. + ^result + ! Item was added: + Object subclass: #StandardFileMenuResult + instanceVariableNames: 'directory name' + classVariableNames: '' + poolDictionaries: '' + category: '60Deprecated-Tools-Menus'! + + !StandardFileMenuResult commentStamp: 'tpr 1/8/2019 13:34' prior: 0! + Deprecated: please don't use this class any more. It is part of the deprecated StandardFileMenu system. + + A StandardFileMenuResult is xxxxxxxxx. + + Instance Variables + directory: <Object> + name: <Object> + + directory + - xxxxx + + name + - xxxxx + ! Item was added: + ----- Method: StandardFileMenuResult class>>directory:name: (in category 'instance creation') ----- + directory: aDirectory name: aString + + ^super new directory: aDirectory name: aString! Item was added: + ----- Method: StandardFileMenuResult>>directory (in category 'accessing') ----- + directory + + ^directory! Item was added: + ----- Method: StandardFileMenuResult>>directory: (in category 'accessing') ----- + directory: aDirectory + + ^directory := aDirectory! Item was added: + ----- Method: StandardFileMenuResult>>directory:name: (in category 'private') ----- + directory: aDirectory name: aString + + directory := aDirectory. + name := aString. + ^self! Item was added: + ----- Method: StandardFileMenuResult>>isCommand (in category 'testing') ----- + isCommand + + ^name isNil! Item was added: + ----- Method: StandardFileMenuResult>>isDirectory (in category 'testing') ----- + isDirectory + + ^name = ''! Item was added: + ----- Method: StandardFileMenuResult>>name (in category 'accessing') ----- + name + + ^name! Item was added: + ----- Method: StandardFileMenuResult>>name: (in category 'accessing') ----- + name: aString + + ^name := aString! Item was added: + ----- Method: StandardFileMenuResult>>printOn: (in category 'accessing') ----- + printOn: aStream + super printOn: aStream. + aStream nextPutAll: ' with directory: '. + directory printOn: aStream. + aStream nextPutAll: ' name: '. + name printOn: aStream + + "StandardFileMenu oldFile"!

1 0

DateAndTime hashing
by David T. Lewis 08 Jan '19

08 Jan '19

Following the recent UTC updates to Chronology-Core, the hash for DateAndTime is: DateAndTime>>hash ^utcMicroseconds hash This implies the need for a couple of follow up actions. I should have done "HashedCollection rehashAll" somewhere in the latest updates. This would be necessary for any hashed collections keyed by DateAndTime. I also need to update two unit tests that document the hashing, and that now fail. Before I do anything about these, does anyone have any comments or concerns regarding how equality testing and hashing are being done for DateAndTime? Thanks, Dave

3 8

The Trunk: System-tpr.1048.mcz
by commits＠source.squeak.org 08 Jan '19

08 Jan '19

tim Rowledge uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tpr.1048.mcz ==================== Summary ==================== Name: System-tpr.1048 Author: tpr Time: 6 January 2019, 5:40:30.923283 pm UUID: bac3c975-3c4b-441c-a8b2-3bb950f50631 Ancestors: System-pre.1047 Start to clean up theFileServices list of registered classes; CornerGripMorph really shouldn't be there. By initialising the registry and rebuilding it we solve that small issue. I'll assume that the initialize method will get run when loading this patch. =============== Diff against System-pre.1047 =============== Item was changed: ----- Method: FileServices class>>initialize (in category 'accessing') ----- initialize "FileServices initialize" + FileReaderRegistry := nil. Smalltalk allClassesDo:[:aClass| (aClass class includesSelector: #fileReaderServicesForFile:suffix:) ifTrue:[self registerFileReader: aClass]].!

3 3

[Please Review] Some updates for resize grips
by Marcel Taeumel 07 Jan '19

07 Jan '19

Hi, there. Please find attached a change set that basically changes AbstractResizerMorph and its subclasses. I pursued the following two goals: 1. Fix a bug with occlusion culling in windows that occured due to misplaced corner grips. (See SystemWindowTests). 2. Make all resize grips compatible with UserInterfaceTheme. Please try it out, review the code, and tell me any issues about that update. I plan to put it into trunk in a few days. Best, Marcel

5 8

The Trunk: System-tpr.1049.mcz
by commits＠source.squeak.org 07 Jan '19

07 Jan '19

tim Rowledge uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tpr.1049.mcz ==================== Summary ==================== Name: System-tpr.1049 Author: tpr Time: 6 January 2019, 6:01:46.155189 pm UUID: 8680d7e1-ee3a-47a3-95fb-eff9ce4505a3 Ancestors: System-tpr.1048 Actually comment FileServices. Goodness me, whatever next? =============== Diff against System-tpr.1048 =============== Item was changed: Object subclass: #FileServices instanceVariableNames: '' classVariableNames: 'FileReaderRegistry' poolDictionaries: '' category: 'System-FileRegistry'! + + !FileServices commentStamp: 'tpr 1/6/2019 17:58' prior: 0! + FileServices is a registry of classes that provide file reading services - defined in the current implementation as classes implementing (directly, not inheriting) #fileReaderServicesForFile:suffix: on their class side. + Registered classes can provide services to read a file (specified by file name and suffix) or directory (specified by path name). + Mostly these services are used in file browser scenarios but see also ExternalDropHandler class>>#lookupServiceBasedHandler: for a different pattern! Item was changed: ----- Method: FileServices class>>isReaderNamedRegistered: (in category 'accessing') ----- isReaderNamedRegistered: aSymbol + "return if a given reader class has been registered. Note that this is on purpose that the argument is a symbol and not a class" - "return if a given reader class has been registered. Note that this is on purpose that the argument is - a symbol and not a class" ^ (self registeredFileReaderClasses collect: [:each | each name]) includes: aSymbol ! Item was changed: ----- Method: FileServices class>>suffixOf: (in category 'accessing') ----- suffixOf: aName + "Answer the file extension of the given file, or an empty string should the file name be nil" - "Answer the file extension of the given file" ^ aName ifNil: [''] ifNotNil: [(FileDirectory extensionFor: aName) asLowercase]!

1 0

← Newer
1
...
9
10
11
12
13
14
15
16
Older →

Jump to page: