Squeak-dev November 2019

squeak-dev@lists.squeakfoundation.org

23 participants
232 discussions

The Trunk: Tools-mt.914.mcz
by commits＠source.squeak.org 15 Nov '19

15 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.914.mcz ==================== Summary ==================== Name: Tools-mt.914 Author: mt Time: 15 November 2019, 2:36:45.66233 pm UUID: 0df495c8-ef25-1742-aa44-82ee0c5cae5a Ancestors: Tools-mt.913, Tools-ct.872, Tools-ct.873, Tools-ct.874, Tools-ct.879, Tools-ct.884, Tools-ct.893, Tools-ct.894 Merge, merge, merge: - some UI fixes and refactorings for browser buttons - adds #browse to CompiledMethod, PackageInfo, MethodReference - adds support for #removeMessage to Debugger, which is already working in other CodeHolder tools - some fixes in ProcessBrowser - improved error messages I decided to put the convenient #browseMethod: in ToolSet instead of StandardToolSet. In ToolSet, I decided to use the term "category" without a class context to mean "system category", which is also the case in Browser's class-side messages. I think that those #ifNil-checks in ProcessBrowser are ugly and need to be re-designed in the future. :-) But they are more consistent now. =============== Diff against Tools-mt.913 =============== Item was removed: - ----- Method: CodeHolder>>addCodeProvenanceButtonTo:using: (in category 'toolbuilder') ----- - addCodeProvenanceButtonTo: panelSpec using: builder - panelSpec children add: (self buildCodeProvenanceButtonWith: builder)! Item was changed: ----- Method: CodeHolder>>buildOptionalButtonsWith: (in category 'toolbuilder') ----- buildOptionalButtonsWith: builder | panelSpec | panelSpec := builder pluggablePanelSpec new. panelSpec children: OrderedCollection new. self optionalButtonPairs do:[:spec| | buttonSpec | buttonSpec := builder pluggableActionButtonSpec new. buttonSpec model: self. buttonSpec label: spec first. buttonSpec action: spec second. spec second == #methodHierarchy ifTrue:[buttonSpec enabled: #inheritanceButtonEnabled; color: #inheritanceButtonColor]. spec second == #browseVersions ifTrue:[buttonSpec enabled: #versionsButtonEnabled]. spec size > 2 ifTrue:[buttonSpec help: spec third]. panelSpec children add: buttonSpec]. "What to show" + self wantsCodeProvenanceButton ifTrue: [ + panelSpec children + add: builder pluggableSpacerSpec new; + add: (self buildCodeProvenanceButtonWith: builder)]. - panelSpec children add: builder pluggableSpacerSpec new. - self addCodeProvenanceButtonTo: panelSpec using: builder. panelSpec layout: #horizontal. "buttons" ^panelSpec! Item was added: + ----- Method: CodeHolder>>wantsCodeProvenanceButton (in category 'what to show') ----- + wantsCodeProvenanceButton + + ^ true! Item was added: + ----- Method: CompiledMethod>>browse (in category '*Tools-Browsing') ----- + browse + + ^ ToolSet browseMethod: self! Item was removed: - ----- Method: Debugger>>addCodeProvenanceButtonTo:using: (in category 'toolbuilder') ----- - addCodeProvenanceButtonTo: panelSpec using: builder - "No thanks!!"! Item was added: + ----- Method: Debugger>>findCleanHomeBelow: (in category 'context stack (message list)') ----- + findCleanHomeBelow: method + + | dirtyIndex | + dirtyIndex := contextStack size + 1. + contextStack reverse detect: [:context | + dirtyIndex := dirtyIndex - 1. + context method = method]. + ^ dirtyIndex + 1! Item was changed: ----- Method: Debugger>>mainContextStackMenu: (in category 'context stack menu') ----- mainContextStackMenu: aMenu "Set up the menu appropriately for the context-stack-list, unshifted" <contextStackMenuShifted: false> ^ aMenu addList: #( ('fullStack (f)' fullStack) ('restart (r)' restart) ('proceed (p)' proceed) ('step (t)' doStep) ('step through (T)' stepIntoBlock) ('send (e)' send) ('where (w)' where) ('peel to first like this' peelToFirst) - ('return entered value' returnValue) - ('toggle break on entry' toggleBreakOnEntry) ('senders of (n)' browseSendersOfMessages) ('implementors of (m)' browseMessages) ('inheritance (i)' methodHierarchy) - ('versions (v)' browseVersions) - ('references (r)' browseVariableReferences) ('assignments (a)' browseVariableAssignments) - ('class refs (N)' browseClassRefs) ('browse full (b)' browseMethodFull) ('file out ' fileOutMessage) + ('remove method (x) ' removeMessage) - ('copy bug report to clipboard' copyBugReportToClipboard)); yourself ! Item was added: + ----- Method: Debugger>>removeMessage (in category 'context stack menu') ----- + removeMessage + + | oldContext method cleanIndex confirmation | + self okToChange ifFalse: [^ false]. + contextStackIndex isZero ifTrue: [^ false]. + + oldContext := self selectedContext. + method := oldContext method. + cleanIndex := self findCleanHomeBelow: method. + contextStack at: cleanIndex ifAbsent: [ + self inform: 'Sender of method not found on stack, can''t remove message'. + ^ false]. + (self confirm: 'I will have to revert to the sender of this message. Is that OK?') + ifFalse: [^ false]. + + confirmation := self systemNavigation + confirmRemovalOf: method selector + on: method methodClass. + confirmation = 3 ifTrue: [^ self]. + self selectedClassOrMetaClass removeSelector: method selector. + + self + contextStackIndex: cleanIndex oldContextWas: oldContext; + tryRestartFrom: self selectedContext. + confirmation = 2 + ifTrue: [self systemNavigation browseAllCallsOn: method selector].! Item was changed: ----- Method: Debugger>>restart (in category 'context stack menu') ----- restart "Proceed from the initial state of the currently selected context. The argument is a controller on a view of the receiver. That view is closed." "Closing now depends on a preference #restartAlsoProceeds - hmm 9/7/2001 16:46" + | unwindError | - | ctxt noUnwindError | self okToChange ifFalse: [^ self]. self checkContextSelection. + unwindError := self tryRestartFrom: self selectedContext. - ctxt := interruptedProcess popTo: self selectedContext. - noUnwindError := false. - ctxt == self selectedContext ifTrue: [ - noUnwindError := true. - interruptedProcess restartTop; stepToSendOrReturn]. - self resetContext: ctxt. ((Preferences restartAlsoProceeds + and: [unwindError not]) + and: [self interruptedProcessShouldResume]) + ifTrue: [self proceed].! - and: [noUnwindError]) - and: [self interruptedProcessShouldResume]) ifTrue: [self proceed]. - ! Item was added: + ----- Method: Debugger>>tryRestartFrom: (in category 'context stack menu') ----- + tryRestartFrom: context + "Try to restart from the initial state of the context. + Return whether an unwind error occurred." + + | actualContext unwindError | + actualContext := interruptedProcess popTo: context. + unwindError := actualContext ~= context. + unwindError ifFalse: [ + interruptedProcess restartTop; stepToSendOrReturn]. + self resetContext: actualContext. + ^ unwindError! Item was added: + ----- Method: Debugger>>wantsCodeProvenanceButton (in category 'toolbuilder') ----- + wantsCodeProvenanceButton + + ^ false! Item was added: + ----- Method: MethodReference>>browse (in category '*Tools-Browsing') ----- + browse + + ^ ToolSet browse: self actualClass selector: self selector! Item was changed: ----- Method: PackageInfo>>browse (in category '*Tools-Browsing') ----- browse + ^ ToolSet browsePackage: self! - ^ StandardToolSet browseSystemCategory: self packageName! Item was changed: ----- Method: PluggableFileList>>open (in category 'initialize-release') ----- open + self deprecated: 'PluggableFileList is being deprecated'. "This can go away soon" + - "PluggableFileList is being deprecated and this can go away soon" - self deprecated: 'PluggableFileList must die'. - ^ Project uiManager openPluggableFileList: self label: prompt in: self currentWorld! Item was changed: ----- Method: ProcessBrowser>>changePriority (in category 'process actions') ----- changePriority | str newPriority nameAndRules | + selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules third ifFalse: [self inform: 'Nope, won''t change priority of ' , nameAndRules first. ^ self]. str := UIManager default request: 'New priority' initialAnswer: selectedProcess priority asString. newPriority := str asNumber asInteger. newPriority ifNil: [^ self]. (newPriority < 1 or: [newPriority > Processor highestPriority]) ifTrue: [self inform: 'Bad priority'. ^ self]. self class setProcess: selectedProcess toPriority: newPriority. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>chasePointers (in category 'process actions') ----- chasePointers | saved | + selectedProcess ifNil: [^ self]. - selectedProcess - ifNil: [^ self]. saved := selectedProcess. [selectedProcess := nil. (Smalltalk includesKey: #PointerFinder) ifTrue: [PointerFinder on: saved] ifFalse: [self inspectPointers]] ensure: [selectedProcess := saved]! Item was changed: ----- Method: ProcessBrowser>>debugProcess (in category 'process actions') ----- debugProcess | nameAndRules | + selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules third ifFalse: [self inform: 'Nope, won''t debug ' , nameAndRules first. ^ self]. self class debugProcess: selectedProcess.! Item was changed: ----- Method: ProcessBrowser>>exploreContext (in category 'stack list') ----- exploreContext + selectedContext ifNotNil: #explore! - selectedContext explore! Item was changed: ----- Method: ProcessBrowser>>exploreProcess (in category 'process list') ----- exploreProcess + selectedProcess ifNotNil: #explore! - selectedProcess explore! Item was changed: ----- Method: ProcessBrowser>>exploreReceiver (in category 'stack list') ----- exploreReceiver + selectedContext ifNotNil: [ + selectedContext receiver explore]! - selectedContext ifNotNil: [ selectedContext receiver explore ]! Item was changed: ----- Method: ProcessBrowser>>inspectContext (in category 'stack list') ----- inspectContext + selectedContext ifNotNil: #inspect! - selectedContext inspect! Item was changed: ----- Method: ProcessBrowser>>inspectPointers (in category 'process actions') ----- inspectPointers | tc pointers | + selectedProcess ifNil: [^ self]. - selectedProcess ifNil: [^self]. tc := thisContext. + pointers := PointerFinder + pointersTo: selectedProcess + except: { + self processList. + tc. + self}. + pointers isEmpty ifTrue: [^ self]. - pointers := PointerFinder pointersTo: selectedProcess - except: { - self processList. - tc. - self}. - pointers isEmpty ifTrue: [^self]. OrderedCollectionInspector openOn: pointers withEvalPane: false withLabel: 'Objects pointing to ' , selectedProcess browserPrintString! Item was changed: ----- Method: ProcessBrowser>>inspectProcess (in category 'process list') ----- inspectProcess + selectedProcess ifNotNil: #inspect! - selectedProcess inspect! Item was changed: ----- Method: ProcessBrowser>>inspectReceiver (in category 'stack list') ----- inspectReceiver + selectedContext ifNotNil: [ + selectedContext receiver inspect]! - selectedContext - ifNotNil: [selectedContext receiver inspect]! Item was changed: ----- Method: ProcessBrowser>>messageTally (in category 'stack list') ----- messageTally | secString secs | + selectedProcess ifNil: [^ self]. secString := UIManager default request: 'Profile for how many seconds?' initialAnswer: '4'. + secString isEmptyOrNil ifTrue: [^ self]. secs := secString asNumber asInteger. + (secs isNil or: [secs isZero]) - (secs isNil - or: [secs isZero]) ifTrue: [^ self]. [ TimeProfileBrowser spyOnProcess: selectedProcess forMilliseconds: secs * 1000 ] forkAt: selectedProcess priority + 1.! Item was changed: ----- Method: ProcessBrowser>>resumeProcess (in category 'process actions') ----- resumeProcess + selectedProcess ifNil: [^ self]. - selectedProcess - ifNil: [^ self]. self class resumeProcess: selectedProcess. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>signalSemaphore (in category 'process actions') ----- signalSemaphore + selectedProcess ifNil: [^ self]. (selectedProcess suspendingList isKindOf: Semaphore) ifFalse: [^ self]. [selectedProcess suspendingList signal] fork. (Delay forMilliseconds: 300) wait. "Hate to make the UI wait, but it's convenient..." self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>suspendProcess (in category 'process actions') ----- suspendProcess | nameAndRules | + selectedProcess ifNil: [^ self]. selectedProcess isSuspended ifTrue: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules second ifFalse: [self inform: 'Nope, won''t suspend ' , nameAndRules first. ^ self]. self class suspendProcess: selectedProcess. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>terminateProcess (in category 'process actions') ----- terminateProcess | nameAndRules | + selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules second ifFalse: [self inform: 'Nope, won''t kill ' , nameAndRules first. ^ self]. self class terminateProcess: selectedProcess. self updateProcessList! Item was added: + ----- Method: StandardToolSet class>>browseCategory: (in category 'browsing') ----- + browseCategory: aCategory + + ^ SystemBrowser default fullOnCategory: aCategory! Item was added: + ----- Method: StandardToolSet class>>browseMethodVersion: (in category 'browsing') ----- + browseMethodVersion: aCompiledMethod + + ^ VersionsBrowser browseMethod: aCompiledMethod! Item was added: + ----- Method: StandardToolSet class>>browsePackage: (in category 'browsing') ----- + browsePackage: aPackageInfo + + self flag: #discuss. "mt: Maybe use the package-pane browser?" + "PackagePaneBrowser fullOnCategory: aPackageInfo name" + + ^ self browseCategory: aPackageInfo systemCategories first + + ! Item was removed: - ----- Method: StandardToolSet class>>browseSystemCategory: (in category 'browsing') ----- - browseSystemCategory: aCategory - - ^ SystemBrowser default - fullOnCategory: aCategory! Item was added: + ----- Method: VersionsBrowser class>>browseMethod: (in category 'instance creation') ----- + browseMethod: aCompiledMethod + + ^ (self browseVersionsForClass: aCompiledMethod methodClass selector: aCompiledMethod selector) + selectMethod: aCompiledMethod; + yourself! Item was changed: ----- Method: VersionsBrowser class>>browseVersionsForClass:selector: (in category 'instance creation') ----- browseVersionsForClass: aClass selector: aSelector + + ^ self - self browseVersionsOf: (aClass compiledMethodAt: aSelector) class: aClass meta: aClass isMeta category: (aClass organization categoryOfElement: aSelector) selector: aSelector! Item was added: + ----- Method: VersionsBrowser>>selectMethod: (in category 'menu') ----- + selectMethod: aCompiledMethod + + self toggleListIndex: (self changeList indexOf: ( + self changeList detect: [:change | change stamp = aCompiledMethod timeStamp]))!

1 0

The Trunk: System-ct.1097.mcz
by commits＠source.squeak.org 15 Nov '19

15 Nov '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1097.mcz ==================== Summary ==================== Name: System-ct.1097 Author: ct Time: 21 September 2019, 7:27:38.166935 pm UUID: 6e3dd9ab-c367-2b4d-8007-fd354a878276 Ancestors: System-mt.1093 Implement #browseMethod: on ToolSet (complements Tools-ct.894) =============== Diff against System-mt.1093 =============== Item was added: + ----- Method: ToolSet class>>browseMethod: (in category 'browsing') ----- + browseMethod: aCompiledMethod + + self default ifNil:[^self inform: 'Cannot open Browser']. + ^self default browseMethod: aCompiledMethod!

1 0

The Trunk: System-mt.1119.mcz
by commits＠source.squeak.org 15 Nov '19

15 Nov '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1119.mcz ==================== Summary ==================== Name: System-mt.1119 Author: mt Time: 15 November 2019, 2:31:30.94533 pm UUID: bd66f2d9-be6a-9744-840d-9654e2d5565d Ancestors: System-dtl.1118, System-ct.1097 Merges System-ct.1097, which adds means to open tools for class (or system categories), method versions, and packages. =============== Diff against System-dtl.1118 =============== Item was added: + ----- Method: ToolSet class>>browseCategory: (in category 'browsing') ----- + browseCategory: aCategory + + self default ifNil: [^ self inform: 'Cannot open Browser']. + ^ self default browseCategory: aCategory! Item was added: + ----- Method: ToolSet class>>browseMethod: (in category 'browsing') ----- + browseMethod: aCompiledMethod + "For convenience: Either open a code browser or a version browser for the given method." + + ^ aCompiledMethod isInstalled + ifTrue: [self browse: aCompiledMethod methodClass selector: aCompiledMethod selector] + ifFalse: [self browseMethodVersion: aCompiledMethod]! Item was added: + ----- Method: ToolSet class>>browseMethodVersion: (in category 'browsing') ----- + browseMethodVersion: aCompiledMethod + + self default ifNil:[^self inform: 'Cannot open Browser']. + ^self default browseMethodVersion: aCompiledMethod! Item was added: + ----- Method: ToolSet class>>browsePackage: (in category 'browsing') ----- + browsePackage: aPackageInfo + + self default ifNil: [^ self inform: 'Cannot open Browser']. + ^ self default browsePackage: aPackageInfo!

1 0

The Inbox: Morphic-ct.1589.mcz
by commits＠source.squeak.org 15 Nov '19

15 Nov '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1589.mcz ==================== Summary ==================== Name: Morphic-ct.1589 Author: ct Time: 15 November 2019, 2:23:59.326144 pm UUID: 3d155fd4-4bef-6140-802c-2be39c9e40ff Ancestors: Morphic-mt.1587 Make TransformMorph more robust against empty submorphs Steps to reproduce a concrete related issue: 1. PluggableTreeMorph new openInWorld 2. Focus it 3. Press Escape =============== Diff against Morphic-mt.1587 =============== Item was changed: ----- Method: TransformMorph>>numberOfItemsPotentiallyInView (in category 'geometry') ----- numberOfItemsPotentiallyInView "Answer the number of items that could potentially be viewed in full, computed as my visible height divided by the average height of my submorphs. Ignore visibility of submorphs." + | localSubmorphBounds | + localSubmorphBounds := self localSubmorphBounds. + localSubmorphBounds ifNil: [^ 0]. + submorphs ifEmpty: [^ 0]. + ^ self innerBounds height // (localSubmorphBounds height / submorphs size)! - ^ self localSubmorphBounds - ifNil: [0] - ifNotNil: [:lsBounds | - self innerBounds height // (lsBounds height / submorphs size)]!

1 0

workspace issue
by David Duke 15 Nov '19

15 Nov '19

Hello, I'm having an unusual problem with my workspaces. I'musing Squeak 5.2 on a windows machine. If I enter an expression in a workspace and then 'print it' all works fine However if I try to preform an action, e.g. Transcript show: 'hello' or 'x:= 1' in the workspace and then 'do it' either by Alt -d or by menu action. I get an exception Message not Understood Undefinedbject >># selectionInterval The rot seems to be Parser>>variable My hunch is that one of the methods was getting an ill-defied interval i.e (lo to: hi) with lo >=hi, but I have not been able to confirm this in all cases. I haven't seen any similar reports, so I suspect its not a system issue. Any thoughts on what I might be doing wrong? thanks, David

5 10

The Trunk: System-dtl.1118.mcz
by commits＠source.squeak.org 14 Nov '19

14 Nov '19

David T. Lewis uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-dtl.1118.mcz ==================== Summary ==================== Name: System-dtl.1118 Author: dtl Time: 14 November 2019, 11:44:09.783497 am UUID: e1e88bc2-8860-4665-9ac4-af0e01dc258c Ancestors: System-mt.1117 When reporting VM parameters, enable formatting in the case of a parameter value that is represented as a Float rather than an Integer. This may happen if a VM parameter is defined in units of milliseconds but internally measured to microsecond precision by the VM, in which case the value may be returned as a Float in order to retain full precision. SmalltalkImage>>formatVMParameter: handles the formatting for integer and non-integer values. Includes recommendations from Marcel and Chris, original System-dtl.1118 submission is moved to treated inbox. =============== Diff against System-mt.1117 =============== Item was added: + ----- Method: SmalltalkImage>>formatVMParameter: (in category 'vm statistics') ----- + formatVMParameter: aNumber + "Format a VM parameter that may have been reported either as a Float or + an Integer. If a VM parameter is defined in units of milliseconds but internally + measured to microsecond precision by the VM, the VM may choose to return + the value as a Float in order to retain full precision. Otther representations + such as Fraction may seem more natural but are difficult to instantiate in + the VM, hence the presumption of Float for representation of higher precision + millisecond values." + + ^ aNumber isFloat + ifTrue: [ aNumber < 1000 + ifTrue: [ aNumber printShowingMaxDecimalPlaces: 5 ] + ifFalse: [ aNumber rounded asStringWithCommas ] ] + ifFalse: [ aNumber asInteger asStringWithCommas ].! Item was changed: ----- Method: SmalltalkImage>>vmStatisticsReportOn: (in category 'vm statistics') ----- (excessive size, no diff calculated)

1 0

Squeak's AssertionFailure vs. SUnit's TestFailure
by Marcel Taeumel 14 Nov '19

14 Nov '19

Hi, there. The Kernel package provides "AssertionFailure" through "self assert: ...". The SUnit package provides "TestFailure" through "self assert: ..." in test cases. AssertionFailure is a subclass of Halt. TestFailure is a subclass of Exception. Now, the test runner catches all errors (red) and all test failures (yellow). However, the rest runner stops working if an AssertionFailure is raised. The Decompiler can do that, for example. In that case, the user cannot easily get an overview of all non-passing tests. Here are my questions: - Should AssertionFailure be an Error instead of a Halt? - Should SUnit treat "real" AssertionFailures also as errors (red)? Find attached two changesets with two different strategies. See TestResult >> #runCase: to see which exceptions are caught during test execution. Best, Marcel

3 6

The Trunk: Graphics-pre.424.mcz
by commits＠source.squeak.org 14 Nov '19

14 Nov '19

Patrick Rein uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-pre.424.mcz ==================== Summary ==================== Name: Graphics-pre.424 Author: pre Time: 14 November 2019, 4:32:50.472053 pm UUID: bbaa1a3d-78d0-0c42-ba47-0c1949e20cca Ancestors: Graphics-pre.423 Refactors the embedded object callback to allow for handling cases in which several TextAnchors are attached to the same character. Also allows TextAnchors to change the style of the text by letting TextAnchors work on the scanner (as other TextAttributes are allowed to do). =============== Diff against Graphics-pre.423 =============== Item was changed: ----- Method: CharacterScanner>>embeddedObject (in category 'stop conditions') ----- embeddedObject pendingKernX := 0. ((text attributesAt: lastIndex) reject: [:each | each anchoredMorph isNil]) + ifNotEmpty: [:attributes | self placeEmbeddedObjectsFrom: attributes]. + self setFont. - ifNotEmpty: [:attributes | attributes do: [:attr | - "Try to placeEmbeddedObject: - if it answers false, then there's no place left" - (self placeEmbeddedObjectFrom: attr) ifFalse: [^ self crossedX]]]. "Note: if ever several objects are embedded on same character, only indent lastIndex once" lastIndex := lastIndex + 1. ^false! Item was changed: + ----- Method: CharacterScanner>>placeEmbeddedObjectFrom: (in category 'private-text-anchor') ----- - ----- Method: CharacterScanner>>placeEmbeddedObjectFrom: (in category 'private') ----- placeEmbeddedObjectFrom: aTextAttribute "Place the anchoredMorph or return false if it cannot be placed" ^ true! Item was added: + ----- Method: CharacterScanner>>placeEmbeddedObjectsFrom: (in category 'private-text-anchor') ----- + placeEmbeddedObjectsFrom: textAttributes + textAttributes do: [:attr | + "Try to placeEmbeddedObject: - if it answers false, then there's no place left" + (self placeEmbeddedObjectFrom: attr) ifFalse: [^ self crossedX]]!

1 0

The Trunk: Graphics-pre.423.mcz
by commits＠source.squeak.org 14 Nov '19

14 Nov '19

Patrick Rein uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-pre.423.mcz ==================== Summary ==================== Name: Graphics-pre.423 Author: pre Time: 14 November 2019, 4:20:44.164053 pm UUID: a9abea50-6c2d-1645-83da-5204166dda73 Ancestors: Graphics-mt.422 Fixes a bug causing lines with several morphs to become to high. =============== Diff against Graphics-mt.422 =============== Item was changed: ----- Method: CompositionScanner>>lineHeightForMorphOfHeight:aligned:to:paddedWith:andOptionalMorphBaseline: (in category 'private') ----- lineHeightForMorphOfHeight: aMorphHeight aligned: morphPosition to: linePosition paddedWith: verticalPadding andOptionalMorphBaseline: morphBaseline "The idea here is to first compute the total height and then subtract the overlapping area." | adjustedLineHeight morphHeight total | morphHeight := aMorphHeight + verticalPadding. total := font height + morphHeight. adjustedLineHeight := 0. morphPosition = #top ifTrue: [ linePosition = #top ifTrue: [adjustedLineHeight := total - font height]. linePosition = #center ifTrue: [adjustedLineHeight := total - (font descent + (font ascent / 2))]. linePosition = #baseline ifTrue: [adjustedLineHeight := total - font descent]. linePosition = #bottom ifTrue: [adjustedLineHeight := total].]. morphPosition = #center ifTrue: [ | upperMorphHalf lowerMorphHalf | "The overlapping area of a morph aligned at the center position can be determined by splitting the morph into a top half which is aligned at the bottom and a lower half aligned at the top." upperMorphHalf := self + lineHeightForMorphOfHeight: aMorphHeight // 2 - lineHeightForMorphOfHeight: aMorphHeight / 2 aligned: #bottom to: linePosition. lowerMorphHalf := self + lineHeightForMorphOfHeight: aMorphHeight // 2 - lineHeightForMorphOfHeight: aMorphHeight / 2 aligned: #top to: linePosition. adjustedLineHeight := upperMorphHalf + lowerMorphHalf - font height]. morphPosition = #baseline ifTrue: [ | upperMorphHalf lowerMorphHalf | "We use the same trick as we used with the center position but with different proportions of the morph." upperMorphHalf := self lineHeightForMorphOfHeight: morphBaseline aligned: #bottom to: linePosition. lowerMorphHalf := self lineHeightForMorphOfHeight: aMorphHeight - morphBaseline aligned: #top to: linePosition. adjustedLineHeight := upperMorphHalf + lowerMorphHalf - font height]. morphPosition = #bottom ifTrue: [ linePosition = #top ifTrue: [adjustedLineHeight := total]. linePosition = #center ifTrue: [adjustedLineHeight := total - (font ascent / 2)]. linePosition = #baseline ifTrue: [adjustedLineHeight := total - font ascent]. linePosition = #bottom ifTrue: [adjustedLineHeight := total - font height].]. + ^ adjustedLineHeight! - ^ lineHeight max: adjustedLineHeight ! Item was changed: ----- Method: CompositionScanner>>placeEmbeddedObjectFrom: (in category 'private') ----- placeEmbeddedObjectFrom: aTextAttribute | width anchoredMorphOrForm textAnchorProperties | anchoredMorphOrForm := aTextAttribute anchoredMorph. textAnchorProperties := self textAnchorPropertiesFor: anchoredMorphOrForm. textAnchorProperties anchorLayout == #document ifTrue: [^ true]. "If it is not anchored at the document, we assume that it is inline." width := anchoredMorphOrForm width + textAnchorProperties horizontalPadding. (textAnchorProperties consumesHorizontalSpace and: [destX + width > rightMargin and: [(leftMargin + width) <= rightMargin or: [lastIndex > line first]]]) ifTrue: ["Won't fit, but would on next line" ^ false]. "The width had to be set beforehand to determine line wrapping. We can now re-use and reset it as it might not be necessary anymore. --pre" width := textAnchorProperties consumesHorizontalSpace ifTrue: [anchoredMorphOrForm width + textAnchorProperties horizontalPadding] ifFalse: [0]. destX := destX + width + kern. baseline := baseline max: (self alignmentMorphOffsetFor: textAnchorProperties of: anchoredMorphOrForm) + (self baselineAdjustmentFor: textAnchorProperties). + lineHeight := lineHeight max: (self - lineHeight := self lineHeightForMorphOfHeight: anchoredMorphOrForm height aligned: textAnchorProperties verticalAlignmentMorph to: textAnchorProperties verticalAlignmentLine paddedWith: textAnchorProperties verticalPadding andOptionalMorphBaseline: (textAnchorProperties morphBaselineGetter + ifNotNil: [:getter | anchoredMorphOrForm perform: getter] ifNil: [0])). - ifNotNil: [:getter | anchoredMorphOrForm perform: getter] ifNil: [0]). ^ true! Item was changed: ----- Method: DisplayScanner>>placeEmbeddedObjectFrom: (in category 'private') ----- placeEmbeddedObjectFrom: aTextAttribute | width anchoredMorphOrForm textAnchorProperties | anchoredMorphOrForm := aTextAttribute anchoredMorph. textAnchorProperties := self textAnchorPropertiesFor: anchoredMorphOrForm. (self embeddedObject: anchoredMorphOrForm shouldBePlacedInDocumentGiven: textAnchorProperties) ifTrue: [^ self placeEmbeddedObjectInDocument: anchoredMorphOrForm]. + self placeEmbeddedObject: anchoredMorphOrForm inlineGiven: textAnchorProperties. - .self placeEmbeddedObject: anchoredMorphOrForm inlineGiven: textAnchorProperties. width := textAnchorProperties consumesHorizontalSpace ifTrue: [anchoredMorphOrForm width + textAnchorProperties horizontalPadding] ifFalse: [0]. destX := destX + width + kern. ^ true!

1 0

MoreVMs 2020 : Workshop on Modern Language Runtimes, Ecosystems, and VMs
by Fabio Niephaus 13 Nov '19

13 Nov '19

============================================================================ Call for Extended Abstracts and Talks: MoreVMs’20 4th Workshop on Modern Language Runtimes, Ecosystems, and VMs Co-located with ‹Programming›’20 March 23rd or 24th, 2020, Porto, Portugal https://2020.programming-conference.org/home/MoreVMs-2020 ============================================================================ Following three previous successful editions, the MoreVMs’20 workshop aims to bring together industrial and academic programmers to discuss the design, implementation, and usage of modern languages and runtimes. This includes aspects such as reuse of language runtimes, modular implementation, language design, and compilation strategies. By bringing together both researchers and practitioners, the workshop aims to enable a diverse discussion on how languages and runtimes are currently being utilized, and where they need to improve further. In addition to conventional workshop-style submissions, MoreVMs also accepts (and encourages) submissions that present early-stage work and emerging ideas. Relevant topics include, but are definitely not limited to, the following: - Extensible VM design (compiler- or interpreter-based VMs) - Reusable components (e.g. interpreters, garbage collectors, ...) - Static and dynamic compilation techniques - Techniques for targeting high-level languages such as JavaScript - Interoperability between languages - Tooling support (e.g. debugging, profiling, etc.) - Programming language development environments - Case studies of existing language implementation approaches - Language implementation challenges and trade-offs - Surveys and usage reports to understand usage in the wild - Ideas for more predictable performance - Ideas for how VMs could take advantage of new hardware features - Ideas for how we should build languages in the future Workshop Format and Submissions ------------------------------- We welcome presentation proposals in the form of extended abstracts (2 to 4 pages long) and talk proposals (title and 400 words abstract) discussing new techniques, insights, experiences, works-in-progress, as well as future visions, from either an academic or industrial perspective. The extended abstracts and talk proposals, and if the speakers wish, their slides, will be published on the workshop's website. Alternatively, extended abstracts can be published as part of the companion of ‹Programming›’20 in the ACM DL. Publication in the ACM DL is conditional on the acceptance by the program committee. Please note that MoreVMs’20 is organized as an academic workshop, and as such, speakers will be required to register for the workshop. We regret that we are unable to cover registration, travel, or accommodation costs for authors. Author Instructions ------------------- Submissions should use the ACM `acmart` format: https://www.acm.org/publications/proceedings-template If you are using LaTeX, submissions should use the 'acmart' document class with the 'sigconf' option, and with a font size of 9 point. Please use the Libertine/Biolinum font family. Please include page numbers in your submission using the LaTeX command `\settopmatter{printfolios=true}`. All submissions should be in PDF format. Please also ensure that your submission is legible when printed on a black and white printer. In particular, please check that colors remain distinct and font sizes are legible. Submission Site: https://easychair.org/conferences/?conf=morevms20 Important Dates --------------- Extended abstract and talk submissions: 2020-01-10 Author notification: 2020-02-10 Camera Ready: 2020-02-21 Workshop: 2020-03-23 or 2020-03-24 All deadlines are Anywhere on Earth (AoE), i.e. GMT/UTC-12:00 hour. Invited Speakers ----------------- Roman Kennke, Shenandoah GC Project Lead, Red Hat Leszek Swirski, Software Engineer, V8 Team, Google Program Committee ----------------- Nicolas B. Pierron, Mozilla, France Clément Béra, Google, Denmark Elisa Gonzalez Boix, Vrije Universiteit Brussel, Belgium Stephen Kell, University of Kent, United Kingdom Christoph Kirsch, University of Salzburg, Austria Hidehiko Masuhara, Tokyo Institute of Technology, Japan Gabriela Alexandra Moldovan, Cloudflare, United Kingdom David Pearce, Victoria University of Wellington, New Zealand Manuel Rigger, ETH Zurich, Switzerland Jennifer B. Sartor, Ghent University and Vrije Universiteit Brussel, Belgium Tomoharu Ugawa, Kochi University of Technology, Japan Michael Van De Vanter, Cal Poly, San Luis Obispo, United States Andy Wingo, Igalia, S.L., United States Organizers ---------- Edd Barrett, King's College London, United Kingdom Fabio Niephaus, Hasso Plattner Institute, University of Potsdam, Germany

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
24
Older →

Jump to page: