Squeak-dev April 2019

squeak-dev@lists.squeakfoundation.org

36 participants
122 discussions

The Inbox: Monticello-cmm.696.mcz
by commits＠source.squeak.org 22 Apr '19

22 Apr '19

Chris Muller uploaded a new version of Monticello to project The Inbox: http://source.squeak.org/inbox/Monticello-cmm.696.mcz ==================== Summary ==================== Name: Monticello-cmm.696 Author: cmm Time: 15 April 2019, 10:44:48.657361 pm UUID: c018093f-821d-4211-b569-6643216b2d57 Ancestors: Monticello-nice.695 - Fix revisions of class definitions when there's another PackageInfo defined whose full name is only a prefix of the working copy the selected class belongs to. - Check the local package-cache before hitting the server for operations where the ancestral UUID is known, such as diffing from the History list. Keep its allFileNamesCache up to date. =============== Diff against Monticello-nice.695 =============== Item was changed: ----- Method: Class>>packageInfo (in category '*monticello') ----- packageInfo + ^ ((PackageInfo allPackages select: [ : each | each includesClass: self ]) + ifEmpty: [ nil ] + ifNotEmpty: + [ : myPackages | "Select the most-qualified match." + myPackages sort: + [ : each | each packageName size ] descending ]) first! - ^ PackageInfo allPackages - detect: [ : each | each includesClass: self ] - ifNone: [ nil ]! Item was removed: - ----- Method: MCRepository>>isTrunkBackup (in category 'testing') ----- - isTrunkBackup - ^ false! Item was changed: ----- Method: MCRepository>>prepareVersionForStorage: (in category 'accessing') ----- prepareVersionForStorage: aVersion ^ self alwaysStoreDiffs ifTrue: [aVersion asDiffAgainst: + (self withCache closestAncestorVersionFor: aVersion info ifNone: [^ aVersion])] - (self closestAncestorVersionFor: aVersion info ifNone: [^ aVersion])] ifFalse: [aVersion]! Item was added: + ----- Method: MCRepository>>withCache (in category 'accessing') ----- + withCache + "Answer the receiver with package-cache in front of it." + ^ MCRepositoryGroup with: self! Item was added: + ----- Method: MCRepositoryGroup class>>with: (in category 'instance creation') ----- + with: aMCRepository + ^ self new + addRepository: aMCRepository ; + yourself! Item was added: + ----- Method: MCRepositoryGroup>>closestAncestorVersionFor:ifNone: (in category 'accessing') ----- + closestAncestorVersionFor: anAncestry ifNone: errorBlock + anAncestry breadthFirstAncestorsDo: + [:ancestorInfo | + (self versionWithInfo: ancestorInfo) ifNotNil: [:v | ^ v]]. + ^ errorBlock value! Item was changed: ----- Method: MCRepositoryGroup>>flushAllFilenames (in category 'private') ----- flushAllFilenames + self repositories do: [ : each | each flushAllFilenames ]! - repositories do: [ : each | each flushAllFilenames ]! Item was changed: ----- Method: MCRepositoryGroup>>versionWithInfo:ifAbsent: (in category 'repository-api') ----- versionWithInfo: aVersionInfo ifAbsent: aBlock + self repositories do: - repositories do: [ : each | ([each versionWithInfo: aVersionInfo ifAbsent: [ nil ]] on: NetworkError do: [ : err | nil ]) ifNotNil: [ : ver | ^ ver ] ]. ^ aBlock value! Item was added: + ----- Method: MCRepositoryGroup>>withCache (in category 'accessing') ----- + withCache + ^ self! Item was changed: ----- Method: MCVersionNotification>>initializeWithVersion:repository: (in category 'private') ----- initializeWithVersion: aVersion repository: aRepository version := aVersion. repository := aRepository. + ancestor := repository withCache closestAncestorVersionFor: version info ifNone: []. - ancestor := repository closestAncestorVersionFor: version info ifNone: []. changes := ancestor ifNil: [#()] ifNotNil: [(version snapshot patchRelativeToBase: ancestor snapshot) operations sorted]! Item was changed: ----- Method: MCWorkingCopy>>changesRelativeToRepository: (in category 'operations') ----- + changesRelativeToRepository: aRepository - changesRelativeToRepository: aRepository | ancestorVersion ancestorSnapshot | + ancestorVersion := aRepository withCache + closestAncestorVersionFor: ancestry + ifNone: [ nil ]. + ancestorSnapshot := ancestorVersion + ifNil: [ MCSnapshot empty ] + ifNotNil: [ ancestorVersion snapshot ]. - ancestorVersion := aRepository closestAncestorVersionFor: ancestry ifNone: []. - ancestorSnapshot := ancestorVersion ifNil: [MCSnapshot empty] ifNotNil: [ancestorVersion snapshot]. ^ package snapshot patchRelativeToBase: ancestorSnapshot! Item was changed: ----- Method: MCWorkingCopyBrowser>>viewChanges (in category 'actions') ----- viewChanges | patch | self canSave ifTrue: + [patch := workingCopy changesRelativeToRepository: self repository withCache. + patch isNil ifTrue: [ ^self ]. - [patch := workingCopy changesRelativeToRepository: self repository. - patch isNil ifTrue: [^ self]. patch isEmpty ifTrue: [ workingCopy modified: false. self inform: 'No changes' ] ifFalse: [ workingCopy modified: true. (MCPatchBrowser forPatch: patch) label: 'Patch Browser: ', workingCopy description; environmentInDisplayingImage: workingCopy environment; + show ] ]! - show]]!

3 2

The Inbox: Environments-cmm.75.mcz
by commits＠source.squeak.org 22 Apr '19

22 Apr '19

Chris Muller uploaded a new version of Environments to project The Inbox: http://source.squeak.org/inbox/Environments-cmm.75.mcz ==================== Summary ==================== Name: Environments-cmm.75 Author: cmm Time: 17 February 2019, 8:54:02.934673 pm UUID: 13aceb53-d0e1-4823-a86c-a2abacb6c2d9 Ancestors: Environments-pre.73 Keep and access Classes and Traits by their #name's logical value instead of the physical identity of the String object. =============== Diff against Environments-pre.73 =============== Item was removed: - (PackageInfo named: 'Environments') preamble: '"Fix ''Instances'' entry for Smalltalk Environment." - | dict | - dict := (Environment classPool at: ''Instances''). - dict keys - do: [ : eachName | (eachName isSymbol not ) ifTrue: [ dict at: eachName asSymbol put: (dict removeKey: eachName) ] ]. - - "Let Environment names be, consistently, Symbols." - Environment allInstances do: - [ : each | - each info - instVarNamed: ''name'' - put: (each name asSymbol) ]'! Item was changed: ----- Method: Environment>>allClassesAndTraitsDo: (in category 'classes and traits') ----- allClassesAndTraitsDo: aBlock declarations keysAndValuesDo: [:key :value | + ((value isBehavior) and: [key = value name]) ifTrue: - ((value isBehavior) and: [key == value name]) ifTrue: [aBlock value: value]]! Item was changed: ----- Method: Environment>>classOrTraitNamed: (in category 'classes and traits') ----- classOrTraitNamed: aString "aString is either a class or trait name or a class or trait name followed by ' class' or 'classTrait' respectively. Answer the class or metaclass it names." | meta baseName | (aString endsWith: ' class') ifTrue: [meta := true. baseName := aString copyFrom: 1 to: aString size - 6] ifFalse: [ (aString endsWith: ' classTrait') ifTrue: [ meta := true. baseName := aString copyFrom: 1 to: aString size - 11] ifFalse: [ meta := false. baseName := aString]]. + ^declarations at: baseName ifPresent: - ^declarations at: baseName asSymbol ifPresent: [ :global | global isBehavior ifTrue: [ meta ifFalse: [ global ] ifTrue: [ global classSide ]]]! Item was changed: ----- Method: Environment>>hasClassNamed: (in category 'classes and traits') ----- + hasClassNamed: aString + ^ declarations + at: aString + ifPresent: [ : global | global isKindOf: Class ] + ifAbsent: [ false ]! - hasClassNamed: aString - Symbol hasInterned: aString ifTrue: - [:symbol | - ^ (declarations at: symbol ifAbsent: [nil]) - isKindOf: Class]. - ^ false.! Item was changed: ----- Method: Environment>>initialize (in category 'initialize-release') ----- initialize + declarations := Dictionary new. + bindings := Dictionary new. - declarations := IdentityDictionary new. - bindings := IdentityDictionary new. undeclared := WeakIdentityDictionary new. policies := Array new. observers := IdentitySet new.! Item was changed: ----- Method: Environment>>removeClassNamed: (in category 'classes and traits') ----- removeClassNamed: aString declarations + at: aString - at: aString asSymbol ifPresent: [:class | class removeFromSystem] ifAbsent: [Transcript cr; show: 'Removal of class named ', aString, ' ignored because ', aString, ' does not exist.']! Item was added: + (PackageInfo named: 'Environments') postscript: '"Fix ''Instances'' entry for Smalltalk Environment." + | dict | + dict := (Environment classPool at: ''Instances''). + Environment classPool at: ''Instances'' put: (dict := dict as: Dictionary). + + "Fix ''delcarations'' and ''bindings'' of existing Environments." + Environment allInstances do: + [ : each | + #(''declarations'' ''bindings'') do: [ : eachIdDictVar | (each instVarNamed: eachIdDictVar put: ((each instVarNamed: eachIdDictVar) as: Dictionary)) ] ]'!

3 2

The Trunk: SMLoader-cmm.93.mcz
by commits＠source.squeak.org 22 Apr '19

22 Apr '19

Chris Muller uploaded a new version of SMLoader to project The Trunk: http://source.squeak.org/trunk/SMLoader-cmm.93.mcz ==================== Summary ==================== Name: SMLoader-cmm.93 Author: cmm Time: 12 November 2018, 9:32:37.990598 pm UUID: f8100409-b6fa-45f5-ad2a-acc81a6f614a Ancestors: SMLoader-cmm.91 - Allow releases which are not necessarily published to be selected when the UI selection was at the package level. - Fix the problem of Release scripts seemingly not updating, due to not refreshing the local cache after uploading the script to the server. =============== Diff against SMLoader-cmm.91 =============== Item was changed: ----- Method: SMLoader>>installPackageRelease (in category 'actions') ----- installPackageRelease "Install selected package or release. The cache is used." | item release | item := self selectedPackageOrRelease ifNil: [^ nil]. item isPackageRelease ifTrue: [^ self installPackageRelease: item] + ifFalse: [release := item lastReleaseForCurrentSystemVersion. - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion. release ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?') ifTrue: [release := item lastPublishedRelease. release ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?') ifTrue: [release := item lastRelease]]]]. release ifNotNil: [^ self installPackageRelease: release]]! Item was changed: ----- Method: SMLoaderPlus>>installPackageRelease (in category 'actions') ----- installPackageRelease "Install selected package or release. The cache is used." | item release | item := self selectedPackageOrRelease ifNil: [^ nil]. item isPackageRelease ifTrue: [^ self installPackageRelease: item] + ifFalse: [release := item lastReleaseForCurrentSystemVersion. - ifFalse: [release := item lastPublishedReleaseForCurrentSystemVersion. release ifNil: [(self confirm: 'The package has no published release for your Squeak version, try releases for any Squeak version?') ifTrue: [release := item lastPublishedRelease. release ifNil: [(self confirm: 'The package has no published release at all, take the latest of the unpublished releases?') ifTrue: [release := item lastRelease]]]]. release ifNotNil: [^ self installPackageRelease: release]]! Item was changed: ----- Method: SMReleaseBrowser>>save (in category 'initialize-release') ----- save "Save the release to SqueakMap." Cursor wait showWhile: [ self dependents do: [ : eachWidget | #(#username #password #note #version #content ) do: [ : eachName | eachWidget knownName = eachName ifTrue: [ eachWidget hasUnacceptedEdits ifTrue: [ eachWidget accept ] ] ] ]. self validateCanSave. [ self writeInstallFile ; login. "Save without a downloadUrl so that SM will update its cache and we can also verify success before uploading the file." self savePackageRelease: nil. self loadScript isEmptyOrNil ifFalse: [ self uploadInstallFile. release package addRelease: release. "Now save with the correct downloadUrl." self savePackageRelease: self downloadUrl ; + deleteInstallFile ] ] ensure: [ self logout ]. + release refreshInCache ]. - deleteInstallFile ] ] ensure: [ self logout ] ]. self closeWindow!

2 1

review of my inbox items
by Chris Muller 22 Apr '19

22 Apr '19

Hi all, This is just a courtesy note to let you know I'd like to push these items into trunk sometime soon, perhaps this week. A couple of these items received no feedback, which may be a good sign since they were all well tested. Here's a summary: _________________ Monticello-cmm.696 We have a couple of places where we're able to check the package-cache. The intention is to improve offline access with a side benefit of reducing network and server load even when on-line. There is no intent to subvert any benefits of the proxy server, it still helps us when it's not in the cache. ___________________ ___________________ Installer-Core-cmm.431 Jakob, the last question we had about this was about restoring the underscore assignment preference. At first I struggled to type the code to subvert other code in the system, going on/off just to avoid it while leaving underscores in the image. But I can see that at least we could ensure _new code_ doesn't get further written with underscore assignment. This 431 restores the prior setting. ___________________ ___________________ Collections-cmm.819 Message: Let Strings have the same #name as the object they name, sans Smalltalk syntax. Allows the #name of either to be used as a lookup key. I submitted this in January but, Levente, you recently made a comment about not liking Object>>#name -- which I can *totally* understand, but fear it may be too late to go back. I don't know, so, I didn't want to advance the system further into dependence on all objects having a #name before getting your thoughts. We probably should discuss in a separate thread. ___________________ ___________________ Environments-cmm.75 Keep and access Classes and Traits by their #name's logical value instead of the physical identity of the String object. I probably won't push this one this week but was curious whether anyone has loaded this. There should be no noticeable impact, please let me know if that was the case. ___________________ Best, Chris

1 0

Any experts on using path in app bundles willing to help me?
by Eliot Miranda 20 Apr '19

20 Apr '19

Hi All, I have a plugin dependent on several support libraries that may be shared with other plugins. So I want the support libraries in a common place (TheVm.app/Contents/Frameworks) while the plugins themselves are bundles in TheVM.app/Contents/Resources. In allowing one to install plugin support libraries in TheVM.app/Contents/Frameworks I have to use the linker's -rpath feature to specify where dlopen may find the search libraries. The question i don't see an answer to in Apple's documentation is whether one uses -rpath when linking the plugin, or when linking the VM into which the plugin will be loaded, or both. Anybody ever done this and know definitively what to do? _,,,^..^,,,_ best, Eliot

3 5

Error creating SqueakMap account
by Tim Johnson 20 Apr '19

20 Apr '19

Hi, I was hoping to create a SqueakMap account to see what's involved in publishing a package. I found the instructions at https://wiki.squeak.org/squeak/779 and began to follow them. At http://map.squeak.org/newaccount I tried to setup an account but received the message "Something went wrong when creating the account". I tried again, but it told me (in red) "Those initials are already taken!" If there is anyone who can help me, please contact me (off list?). Thanks! Tim J

5 8

[ANN] ScriptBook 0.1
by Chris Cunnington 19 Apr '19

19 Apr '19

I’ve created a quick and dirty start to a tool called ScriptBook. So far, it can install NuScratch, OSProcess, RefactoringBrowser and Tonel. Update: Funny thing. Turns out this doesn’t work. Looks cool, though. I assumed if a person could see the script in a UI, they could highlight and DoIt. In this UI you can’t even copy and paste it. I’ll fix that. You get the idea. Happy Easter. (Installer ss3) project: 'ScriptBook'; install: 'ScriptBook'. ScriptBook new Chris Motley Crue - The Dirt https://www.youtube.com/watch?v=QfenIwtoQzk

1 0

Cursor and halo handles over editable text
by Stéphane Rollandin 19 Apr '19

19 Apr '19

Hello, There is currently a glitch in the handling of the cursor look (its shape): From a brand new recent image, click in the 'Welcome to Squeak' text so that it gets keyboard focus, then create a morph and invoke its halo, and drag it over the text. The cursor shape will not change into an arrow when over one of the morph handles, if that handle is above the text. Stef

1 0

object explorer - sorting keys in dictionaries
by Chris Cunningham 18 Apr '19

18 Apr '19

Hi. I have objects that I want to explore with Dates as keys. ObjectExplorer seems to want to sort these by the string representation of the dates instead of the natural sorting of the dates [image: image.png] Could someone point me to where the building of this list is going on? Once I have a pointer, I can try various other options to find something I like. Thanks, cbc

2 3

Weird close button hover animation
by Fabio Niephaus 17 Apr '19

17 Apr '19

Hi all, I just downloaded the latest trunk build (Squeak5.3alpha-18491-64bit, see [1]) and noticed this weird hover animation: [image: button.gif] It seems that only the close buttons (in all system windows) are effected and I have no idea why and since when. Other buttons behave as usual. Does anyone have an idea what this could be and how to fix it? Fabio [1] http://files.squeak.org/5.3alpha/Squeak5.3alpha-18491-64bit/

1 0

← Newer
1
...
6
7
8
9
10
11
12
13
Older →