Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

The Trunk: ShoutCore-ct.72.mcz
by commits＠source.squeak.org 05 Sep '19

05 Sep '19

Marcel Taeumel uploaded a new version of ShoutCore to project The Trunk: http://source.squeak.org/trunk/ShoutCore-ct.72.mcz ==================== Summary ==================== Name: ShoutCore-ct.72 Author: ct Time: 4 September 2019, 10:08:56.059698 pm UUID: f93fd19c-7a5e-c945-821d-9ff30737d01c Ancestors: ShoutCore-ct.71 Use Time>>#utcMicrosecondClock instead of #primUTCMicrosecondClock or TimeStamps Thanks tim :) =============== Diff against ShoutCore-ul.68 =============== Item was changed: ----- Method: SHParserST80 class>>benchmark (in category 'benchmarking') ----- benchmark | methods methodCount totalTime averageTime min median percentile80 percentile95 percentile99 max | Smalltalk garbageCollect. methods := OrderedCollection new: 100000. CurrentReadOnlySourceFiles cacheDuring: [ | parser | parser := SHParserST80 new. SystemNavigation default allSelectorsAndMethodsDo: [ :class :selector :method | | source start ranges | source := method getSource asString. + start := Time utcMicrosecondClock. - start := Time primUTCMicrosecondClock. ranges := parser rangesIn: source classOrMetaClass: class workspace: nil environment: nil. + methods addLast: { Time utcMicrosecondClock - start. method. ranges size } ] ]. - methods addLast: { Time primUTCMicrosecondClock - start. method. ranges size } ] ]. methods sort: #first asSortFunction. methodCount := methods size. totalTime := methods detectSum: #first. averageTime := (totalTime / methodCount) rounded. min := methods first. median := methods at: methodCount // 2. percentile80 := methods at: (methodCount * 0.8) floor. percentile95 := methods at: (methodCount * 0.95) floor. percentile99 := methods at: (methodCount * 0.99) floor. max := methods last. ^' Methods {1} Total {2}ms Average {3}ms Min {4}ms {5} range(s) ({6}) Median {7}ms {8} ranges ({9}) 80th percentile {10}ms {11} ranges ({12}) 95th percentile {13}ms {14} ranges ({15}) 99th percentile {16}ms {17} ranges ({18}) Max {19}ms {20} ranges ({21})' format: ({ methodCount asString. totalTime. averageTime. min first. min third asString. min second reference. median first. median third asString. median second reference. percentile80 first. percentile80 third asString. percentile80 second reference. percentile95 first. percentile95 third asString. percentile95 second reference. percentile99 first. percentile99 third asString. percentile99 second reference. max first. max third asString. max second reference } replace: [ :each | each isNumber ifTrue: [ (each / 1000) printShowingDecimalPlaces: 3 ] ifFalse: [ each ] ])!

1 0

The Trunk: Tools-mt.885.mcz
by commits＠source.squeak.org 05 Sep '19

05 Sep '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.885.mcz ==================== Summary ==================== Name: Tools-mt.885 Author: mt Time: 5 September 2019, 10:30:32.353472 am UUID: 629ef430-add9-7140-94ae-d961f7288ab8 Ancestors: Tools-pre.884 Complements Kernel-mt.1264. =============== Diff against Tools-pre.884 =============== Item was changed: ----- Method: Browser>>renameClass (in category 'class functions') ----- renameClass | oldName newName obs oldBinding | self hasClassSelected ifFalse: [^ self]. self okToChange ifFalse: [^ self]. oldName := self selectedClass name. newName := self request: 'Please type new class name' initialAnswer: oldName. newName = '' ifTrue: [^ self]. "Cancel returns ''" newName := newName asSymbol. newName = oldName ifTrue: [^ self]. (self selectedClass environment includesKey: newName) ifTrue: [^ self error: newName , ' already exists']. oldBinding := self selectedClass environment declarationOf: oldName. + [self selectedClass rename: newName] + on: Notification + do: [:ex | self inform: ex messageText]. - self selectedClass rename: newName. selectedClassName := newName. self changed: #classList. obs := self systemNavigation allCallsOn: oldBinding. obs isEmpty ifFalse: [self systemNavigation browseMessageList: obs name: 'Obsolete References to ' , oldName autoSelect: oldName]. self selectClassNamed: newName.!

1 0

The Trunk: Kernel-mt.1264.mcz
by commits＠source.squeak.org 05 Sep '19

05 Sep '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1264.mcz ==================== Summary ==================== Name: Kernel-mt.1264 Author: mt Time: 5 September 2019, 10:28:08.130081 am UUID: 212cd650-56f2-db43-b4ef-0a38d80dfbd7 Ancestors: Kernel-ul.1263 On class rename, use notification instead of dialog. Tools can then turn that notification into a dialog if needed. =============== Diff against Kernel-ul.1263 =============== Item was changed: ----- Method: Class>>rename: (in category 'class name') ----- rename: aString "The new name of the receiver is the argument, aString." | oldName newName | (newName := aString asSymbol) = (oldName := self name) ifTrue: [^ self]. (self environment includesKey: newName) ifTrue: [^ self error: newName , ' already exists']. ((self environment undeclared includesKey: newName) and: [(self environment undeclared unreferencedKeys includes: newName) not]) + ifTrue: [Notification signal: 'There are references to ' , aString printString , ' - ifTrue: [self inform: 'There are references to ' , aString printString , ' from Undeclared. Check them after this change.']. name := newName. self environment renameClass: self from: oldName!

1 0

The Trunk: Tools-pre.884.mcz
by commits＠source.squeak.org 05 Sep '19

05 Sep '19

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.884.mcz ==================== Summary ==================== Name: Tools-pre.884 Author: pre Time: 5 September 2019, 10:26:18.328476 am UUID: 24fb9919-2314-e04e-bbe9-56ac6134b493 Ancestors: Tools-pre.883 Fixes some calls to now deprecated methods in ChangeSorter and FileList (previously missed as they were self class sends). =============== Diff against Tools-pre.883 =============== Item was changed: ----- Method: ChangeSorter>>fileIntoNewChangeSet (in category 'changeSet menu') ----- fileIntoNewChangeSet "Obtain a file designation from the user, and file its contents into a new change set whose name is a function of the filename. Show the new set and leave the current changeSet unaltered." self okToChange ifFalse: [^ self]. ChangeSet promptForDefaultChangeSetDirectoryIfNecessary. (FileChooserDialog openOn: ChangeSet defaultChangeSetDirectory) ifNotNil: [:fileName | FileStream oldFileNamed: fileName do: [:stream | | localName | localName := FileDirectory localNameFor: fileName. + (ChangeSet newChangesFromStream: stream named: localName) - (self class newChangesFromStream: stream named: localName) ifNotNil: [:aNewChangeSet | self showChangeSet: aNewChangeSet]]].! Item was changed: ----- Method: ChangeSorter>>fileOutClass (in category 'class list') ----- fileOutClass "this is a hack!!!! makes a new change set, called the class name, adds author initials to try to make a unique change set name, files it out and removes it. kfr 16 june 2000" | aSet | "File out the selected class set." + aSet := ChangeSet newChangeSet: (self withoutItemAnnotation: currentClassName). - aSet := self class newChangeSet: (self withoutItemAnnotation: currentClassName). aSet absorbClass: self selectedClassOrMetaClass name from: myChangeSet. aSet fileOut. + ChangeSet removeChangeSet: aSet. - self class removeChangeSet: aSet. parent modelWakeUp. "notice object conversion methods created" ! Item was changed: ----- Method: ChangeSorter>>newSet (in category 'changeSet menu') ----- newSet "Create a new changeSet and show it., making it the current one. Reject name if already in use." | aSet | self okToChange ifFalse: [^ self]. + aSet := ChangeSet newChangeSet. - aSet := self class newChangeSet. aSet ifNotNil:[ self update. self showChangeSet: aSet. self changed: #relabel]! Item was changed: ----- Method: ChangeSorter>>promoteToTopChangeSet (in category 'changeSet menu') ----- promoteToTopChangeSet "Move the selected change-set to the top of the list" + ChangeSet promoteToTop: myChangeSet. - self class promoteToTop: myChangeSet. (parent ifNil: [self]) modelWakeUp! Item was changed: ----- Method: ChangeSorter>>setRecentUpdatesMarker (in category 'changeSet menu') ----- setRecentUpdatesMarker "Allow the user to change the recent-updates marker" | result | result := UIManager default request: ('Enter the lowest change-set number that you wish to consider "recent"? (note: highest change-set number + in this image at this time is ', ChangeSet highestNumberedChangeSet asString, ')') initialAnswer: ChangesOrganizer recentUpdateMarker recentUpdateMarker asString. - in this image at this time is ', ChangeSet highestNumberedChangeSet asString, ')') initialAnswer: self class recentUpdateMarker asString. (result notNil and: [result startsWithDigit]) ifTrue: + [ChangesOrganizer recentUpdateMarker: result asInteger. - [self class recentUpdateMarker: result asInteger. Smalltalk isMorphic ifTrue: [SystemWindow wakeUpTopWindowUponStartup]]! Item was changed: ----- Method: FileList class>>removeObsolete (in category 'class initialization') ----- removeObsolete "FileList removeObsolete" + FileServices removeObsolete + ! - self registeredFileReaderClasses copy - do:[:cls| cls isObsolete ifTrue:[self unregisterFileReader: cls]]! Item was changed: ----- Method: FileList>>itemsForDirectory: (in category 'file list menu') ----- itemsForDirectory: dir | services | services := OrderedCollection new. dir ifNotNil: [ services + addAll: (FileServices itemsForDirectory: dir). - addAll: (self class itemsForDirectory: dir). services last useLineAfter: true. ]. services add: self serviceAddNewFile. services add: self serviceAddNewDirectory. ^ services! Item was changed: ----- Method: FileList>>itemsForFile: (in category 'file list menu') ----- itemsForFile: fullName "Answer a list of services appropriate for a file of the given full name" + ^ (FileServices itemsForFile: fullName) , (self myServicesForFile: fullName suffix: (FileServices suffixOf: fullName))! - | suffix | - suffix := self class suffixOf: fullName. - ^ (self class itemsForFile: fullName) , (self myServicesForFile: fullName suffix: suffix)! Item was changed: ----- Method: FileList>>registeredFileReaderClasses (in category 'private') ----- registeredFileReaderClasses "return the list of classes that provide file reader services" + ^ FileServices registeredFileReaderClasses! - ^ self class registeredFileReaderClasses! Item was changed: ----- Method: FileList>>servicesFromSelectorSpecs: (in category 'own services') ----- servicesFromSelectorSpecs: symbolArray "Answer an array of services represented by the incoming symbols, eliminating any that do not have a currently-registered service. Pass the symbol #- along unchanged to serve as a separator between services" "FileList new servicesFromSelectorSpecs: #(fileIn: fileIntoNewChangeSet: browseChangesFile:)" | services col | col := OrderedCollection new. + services := FileServices allRegisteredServices, (self myServicesForFile: #dummy suffix: '*'). - services := self class allRegisteredServices, (self myServicesForFile: #dummy suffix: '*'). symbolArray do: [:sel | | res | sel == #- ifTrue: [col add: sel] ifFalse: [res := services detect: [:each | each selector = sel] ifNone: [nil]. res notNil ifTrue: [col add: res]]]. ^ col! Item was changed: ----- Method: FileList>>suffixOfSelectedFile (in category 'file list menu') ----- suffixOfSelectedFile "Answer the file extension of the receiver's selected file" + ^ FileServices suffixOf: self fullName.! - ^ self class suffixOf: self fullName.!

1 0

[Tools] Possible deprecations in Inspector
by Thiede, Christoph 05 Sep '19

05 Sep '19

Hi all, while working at some refactoring on the Inspector, I found some selectors that might be obsolete: * Debugger>>#receiverInspectorObject:context: -- no senders in my image * Inspector>>#context: and the corresponding instvar -- no senders to possible instances of Inspector in my image - but Debugger>>#receiverInspectorObject:context: Also, the comment mentions a class named ClosureEnvInspector, which is also not present in my image. Was that a predecessor of ContextInspector? Or would it be interesting in Debugger, to tell the receiverInspector about the selectedContext in #resetContext:changeContents:, and in Inspector, to expose context as doItContext? This would allow you to evaluate context-dependent expressions in both Inspector windows. Pro: You would not have to "move around" with your code to the second value pane when evaluating such expressions. Con: You would not be able to access shadowed variables programmatically any longer while debugging. Opinions? * #defaultIntegerBaseInDebugger Is sent by (ContextVariable)Inspector>>#defaultIntegerBase, but nowhere implemented (at least in my image). Also, the current implementation is quite ugly + overheady by catching each possible DNU instead of checking #respondsTo:. Are you aware of any implementation of this selector? * Inspector>>#classOfSelection Also no senders in my image, and it is 100% identical to #selectedClass. So, which of these selectors do you think we can delete or deprecate? I will be happy to do that. :) Best, Christoph

1 0

The Inbox: ShoutCore-ct.71.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.71.mcz ==================== Summary ==================== Name: ShoutCore-ct.71 Author: ct Time: 3 September 2019, 2:20:09.991948 pm UUID: 2635dce1-6bda-3a4d-a726-3f66bb7c6431 Ancestors: ShoutCore-ul.68 Use TimeStamps instead of deprecated #primUTCMicrosecondClock. =============== Diff against ShoutCore-ul.68 =============== Item was changed: ----- Method: SHParserST80 class>>benchmark (in category 'benchmarking') ----- benchmark | methods methodCount totalTime averageTime min median percentile80 percentile95 percentile99 max | Smalltalk garbageCollect. methods := OrderedCollection new: 100000. CurrentReadOnlySourceFiles cacheDuring: [ | parser | parser := SHParserST80 new. SystemNavigation default allSelectorsAndMethodsDo: [ :class :selector :method | | source start ranges | source := method getSource asString. + start := TimeStamp now. - start := Time primUTCMicrosecondClock. ranges := parser rangesIn: source classOrMetaClass: class workspace: nil environment: nil. + methods addLast: { (TimeStamp now - start) asMicroSeconds. method. ranges size } ] ]. - methods addLast: { Time primUTCMicrosecondClock - start. method. ranges size } ] ]. methods sort: #first asSortFunction. methodCount := methods size. totalTime := methods detectSum: #first. averageTime := (totalTime / methodCount) rounded. min := methods first. median := methods at: methodCount // 2. percentile80 := methods at: (methodCount * 0.8) floor. percentile95 := methods at: (methodCount * 0.95) floor. percentile99 := methods at: (methodCount * 0.99) floor. max := methods last. ^' Methods {1} Total {2}ms Average {3}ms Min {4}ms {5} range(s) ({6}) Median {7}ms {8} ranges ({9}) 80th percentile {10}ms {11} ranges ({12}) 95th percentile {13}ms {14} ranges ({15}) 99th percentile {16}ms {17} ranges ({18}) Max {19}ms {20} ranges ({21})' format: ({ methodCount asString. totalTime. averageTime. min first. min third asString. min second reference. median first. median third asString. median second reference. percentile80 first. percentile80 third asString. percentile80 second reference. percentile95 first. percentile95 third asString. percentile95 second reference. percentile99 first. percentile99 third asString. percentile99 second reference. max first. max third asString. max second reference } replace: [ :each | each isNumber ifTrue: [ (each / 1000) printShowingDecimalPlaces: 3 ] ifFalse: [ each ] ])!

4 4

The Inbox: ShoutCore-ct.72.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.72.mcz ==================== Summary ==================== Name: ShoutCore-ct.72 Author: ct Time: 4 September 2019, 10:08:56.059698 pm UUID: f93fd19c-7a5e-c945-821d-9ff30737d01c Ancestors: ShoutCore-ct.71 Use Time>>#utcMicrosecondClock instead of #primUTCMicrosecondClock or TimeStamps Thanks tim :) =============== Diff against ShoutCore-ct.71 =============== Item was changed: ----- Method: SHParserST80 class>>benchmark (in category 'benchmarking') ----- benchmark | methods methodCount totalTime averageTime min median percentile80 percentile95 percentile99 max | Smalltalk garbageCollect. methods := OrderedCollection new: 100000. CurrentReadOnlySourceFiles cacheDuring: [ | parser | parser := SHParserST80 new. SystemNavigation default allSelectorsAndMethodsDo: [ :class :selector :method | | source start ranges | source := method getSource asString. + start := Time utcMicrosecondClock. - start := TimeStamp now. ranges := parser rangesIn: source classOrMetaClass: class workspace: nil environment: nil. + methods addLast: { Time utcMicrosecondClock - start. method. ranges size } ] ]. - methods addLast: { (TimeStamp now - start) asMicroSeconds. method. ranges size } ] ]. methods sort: #first asSortFunction. methodCount := methods size. totalTime := methods detectSum: #first. averageTime := (totalTime / methodCount) rounded. min := methods first. median := methods at: methodCount // 2. percentile80 := methods at: (methodCount * 0.8) floor. percentile95 := methods at: (methodCount * 0.95) floor. percentile99 := methods at: (methodCount * 0.99) floor. max := methods last. ^' Methods {1} Total {2}ms Average {3}ms Min {4}ms {5} range(s) ({6}) Median {7}ms {8} ranges ({9}) 80th percentile {10}ms {11} ranges ({12}) 95th percentile {13}ms {14} ranges ({15}) 99th percentile {16}ms {17} ranges ({18}) Max {19}ms {20} ranges ({21})' format: ({ methodCount asString. totalTime. averageTime. min first. min third asString. min second reference. median first. median third asString. median second reference. percentile80 first. percentile80 third asString. percentile80 second reference. percentile95 first. percentile95 third asString. percentile95 second reference. percentile99 first. percentile99 third asString. percentile99 second reference. max first. max third asString. max second reference } replace: [ :each | each isNumber ifTrue: [ (each / 1000) printShowingDecimalPlaces: 3 ] ifFalse: [ each ] ])!

1 0

The Inbox: Morphic-ct.1514.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1514.mcz ==================== Summary ==================== Name: Morphic-ct.1514 Author: ct Time: 4 September 2019, 9:41:42.959698 pm UUID: 275cb484-90ce-9549-8c1c-52ef3fe319b2 Ancestors: Morphic-mt.1513 Simplify DialogWindow>>#exploreInvocation Thanks to Eliot for the hint! =============== Diff against Morphic-mt.1513 =============== Item was changed: ----- Method: DialogWindow>>exploreInvocation (in category 'running') ----- exploreInvocation + self exclusive: false. + (self findInvocationContext stack collect: #method) + explore! - | result context | - self exclusive: false. "We want to explore." - - result := OrderedCollection new. - context := self findInvocationContext. - - [context sender] whileNotNil: [ - result add: context method. - context := context sender]. - result add: context method. - - result explore.!

1 0

The Inbox: Tools-ct.884.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.884.mcz ==================== Summary ==================== Name: Tools-ct.884 Author: ct Time: 4 September 2019, 9:33:08.606698 pm UUID: 519d813a-bfd0-e74c-bb55-b30d096a2bd1 Ancestors: Tools-pre.883 Raise language in deprecation messages to a less brutal standard =============== Diff against Tools-pre.883 =============== Item was changed: ----- Method: PluggableFileList>>open (in category 'initialize-release') ----- open + self deprecated: 'PluggableFileList is being deprecated'. "This can go away soon" + - "PluggableFileList is being deprecated and this can go away soon" - self deprecated: 'PluggableFileList must die'. - ^ Project uiManager openPluggableFileList: self label: prompt in: self currentWorld!

1 0

The Inbox: 60Deprecated-ct.45.mcz
by commits＠source.squeak.org 04 Sep '19

04 Sep '19

A new version of 60Deprecated was added to project The Inbox: http://source.squeak.org/inbox/60Deprecated-ct.45.mcz ==================== Summary ==================== Name: 60Deprecated-ct.45 Author: ct Time: 4 September 2019, 9:30:05.319698 pm UUID: 03df1813-9670-b041-b0d6-abb6df1eb33d Ancestors: 60Deprecated-ct.44 Raise language in deprecation messages to a less brutal standard ... =============== Diff against 60Deprecated-ct.44 =============== Item was changed: ----- Method: DummyUIManager>>openPluggableFileList:label:in: (in category '*60Deprecated') ----- openPluggableFileList: aPluggableFileList label: aString in: aWorld + self deprecated: 'PluggableFileList is being deprecated'. - self deprecated: 'PluggableFileList must die'. ^nil! Item was changed: ----- Method: DummyUIManager>>openPluggableFileListLabel:in: (in category '*60Deprecated') ----- openPluggableFileListLabel: aString in: aWorld + self deprecated: 'PluggableFileList is being deprecated'. - self deprecated: 'PluggableFileList must die'. ^nil!

1 0

← Newer
1
...
29
30
31
32
33
34
35
36
Older →

Jump to page: