Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

The Trunk: Morphic-mt.1544.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1544.mcz ==================== Summary ==================== Name: Morphic-mt.1544 Author: mt Time: 26 September 2019, 11:26:14.016433 am UUID: c3372aee-2104-9049-a6ef-4faa1f0eb079 Ancestors: Morphic-mt.1543 If you happen to end up with a TransformationMorph that has no children, you can now: - open a halo on it to move/resize/delete it - drag-and-drop it around in the world without a debugger nagging you =============== Diff against Morphic-mt.1543 =============== Item was changed: ----- Method: HaloMorph>>addScaleHandle: (in category 'handles') ----- addScaleHandle: haloSpec + + (target isFlexMorph and: [target renderedMorph ~~ target]) + ifTrue: [(self addHandle: haloSpec + on: #mouseDown send: #startScale:with: to: self) + on: #mouseMove send: #doScale:with: to: self] + ifFalse: [(self addHandle: haloSpec + on: #mouseDown send: #startGrow:with: to: self) + on: #mouseMove send: #doGrow:with: to: self]. - target isFlexMorph ifTrue: - [(self addHandle: haloSpec - on: #mouseDown send: #startScale:with: to: self) - on: #mouseMove send: #doScale:with: to: self]. - "This or addGrowHandle:, but not both, will prevail at any one time" ! Item was changed: ----- Method: HaloMorph>>addSimpleHandlesTo:box: (in category 'halos and balloon help') ----- addSimpleHandlesTo: aHaloMorph box: aBox | aHandle | simpleMode := true. target isWorldMorph ifTrue: [^ self addSimpleHandlesForWorldHalos]. self removeAllMorphs. "remove old handles, if any" self bounds: target renderedMorph worldBoundsForHalo. "update my size" self addHandleAt: (((aBox topLeft + aBox leftCenter) // 2) + self simpleFudgeOffset) color: Color paleBuff icon: 'Halo-MoreHandles' on: #mouseDown send: #addFullHandles to: self. aHandle := self addGraphicalHandle: #Rotate at: aBox bottomLeft on: #mouseDown send: #startRot:with: to: self. aHandle on: #mouseMove send: #doRot:with: to: self. + (target isFlexMorph and: [target renderedMorph ~~ target]) - target isFlexMorph ifTrue: [(self addGraphicalHandle: #Scale at: aBox bottomRight on: #mouseDown send: #startScale:with: to: self) on: #mouseMove send: #doScale:with: to: self] ifFalse: [(self addGraphicalHandle: #Scale at: aBox bottomRight on: #mouseDown send: #startGrow:with: to: self) on: #mouseMove send: #doGrow:with: to: self]. innerTarget wantsSimpleSketchMorphHandles ifTrue: [self addSimpleSketchMorphHandlesInBox: aBox]. growingOrRotating := false. self layoutChanged. self changed. ! Item was changed: ----- Method: TransformationMorph>>extent: (in category 'geometry') ----- extent: newExtent + + self renderedMorph == self + ifTrue: [super extent: newExtent] + ifFalse: [ + self adjustAfter: [ + | scaleFactor | + scaleFactor := (self scale * newExtent r / self fullBounds extent r) max: 0.1. + self scale: (scaleFactor detentBy: 0.1 atMultiplesOf: 1.0 snap: false)]].! - - self adjustAfter: - [ | scaleFactor | - scaleFactor := (self scale * newExtent r / self fullBounds extent r) max: 0.1. - self scale: (scaleFactor detentBy: 0.1 atMultiplesOf: 1.0 snap: false)]! Item was added: + ----- Method: TransformationMorph>>initialize (in category 'initialization') ----- + initialize + + super initialize. + + self + color: ((Color gray: 0.7) alpha: 0.5); + borderStyle: (DashedBorder color: (Color gray: 0.4) width: 1).! Item was changed: ----- Method: TransformationMorph>>shouldDropOnMouseUp (in category 'dropping/grabbing') ----- shouldDropOnMouseUp + + ^ self renderedMorph in: [:target | + target == self + ifTrue: [super shouldDropOnMouseUp] + ifFalse: [target shouldDropOnMouseUp]]! - "check if my submorph should drop " - ^self firstSubmorph shouldDropOnMouseUp! Item was added: + ----- Method: TransformationMorph>>wantsHaloFromClick (in category 'halos and balloon help') ----- + wantsHaloFromClick + + ^ self renderedMorph == self!

2 1

The Trunk: EToys-mt.355.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.355.mcz ==================== Summary ==================== Name: EToys-mt.355 Author: mt Time: 26 September 2019, 1:55:25.650102 pm UUID: cd723c86-44d5-b240-8728-e4e8f508708d Ancestors: EToys-mt.354 Complements MorphicExtras-mt.265. =============== Diff against EToys-mt.354 =============== Item was removed: - ----- Method: PaintBoxMorph>>beSupersized (in category '*Etoys-Squeakland-initialization') ----- - beSupersized - | scaleFactor | - scaleFactor := 1.5. - self isFlexed - ifFalse: [self scaleFactor: scaleFactor. - self position: self position / scaleFactor. - self changed]!

1 0

The Trunk: MorphicExtras-mt.265.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-mt.265.mcz ==================== Summary ==================== Name: MorphicExtras-mt.265 Author: mt Time: 26 September 2019, 1:54:11.371102 pm UUID: cdf603c6-b37f-4141-802b-98bc37b28605 Ancestors: MorphicExtras-kfr.264 Use system scale for paint-box morph instead of new preference. Note that this code still as etoys dependencies that need to be resolved. =============== Diff against MorphicExtras-kfr.264 =============== Item was added: + ----- Method: PaintBoxMorph>>beSupersized (in category 'initialization') ----- + beSupersized + | scaleFactor | + scaleFactor := RealEstateAgent scaleFactor. + self isFlexed + ifFalse: [self scaleFactor: scaleFactor. + self position: self position / scaleFactor. + self changed]! Item was changed: ----- Method: SketchEditorMorph>>initializeFor:inBounds:pasteUpMorph:paintBoxPosition: (in category 'initialization') ----- initializeFor: aSketchMorph inBounds: boundsToUse pasteUpMorph: aPasteUpMorph paintBoxPosition: aPosition "NB: if aPosition is nil, then it's assumed that the paintbox is obtained from a flap or some such, so do nothing special regarding a palette in this case. The palette needs already to be in the world for this to work." | w | (w := aPasteUpMorph world) addMorphInLayer: self. "in back of palette" enclosingPasteUpMorph := aPasteUpMorph. hostView := aSketchMorph. "may be ownerless" self bounds: boundsToUse. palette := w paintBox focusMorph: self. palette beStatic. "give Nebraska whatever help we can" palette addWeakDependent: self. aPosition ifNotNil: [w addMorphFront: palette. "bring to front" palette position: aPosition. + palette beSupersized]. - Preferences useBiggerPaintingBox ifTrue: [palette beSupersized]]. paintingForm := Form extent: bounds extent depth: w assuredCanvas depth. self dimTheWindow. self addRotationScaleHandles. aSketchMorph ifNotNil: [ aSketchMorph form displayOn: paintingForm at: (hostView boundsInWorld origin - bounds origin - hostView form offset) clippingBox: (0@0 extent: paintingForm extent) rule: Form over fillColor: nil. "assume they are the same depth". undoBuffer := paintingForm deepCopy. rotationCenter := aSketchMorph rotationCenter]!

1 0

The Trunk: MorphicExtras-kfr.264.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-kfr.264.mcz ==================== Summary ==================== Name: MorphicExtras-kfr.264 Author: kfr Time: 23 September 2019, 8:11:15.349115 pm UUID: 8d0cb732-a340-be45-b4a7-73e70163ce63 Ancestors: MorphicExtras-mt.263 Honor preference useBiggerPaintingBox =============== Diff against MorphicExtras-mt.263 =============== Item was changed: ----- Method: SketchEditorMorph>>initializeFor:inBounds:pasteUpMorph:paintBoxPosition: (in category 'initialization') ----- initializeFor: aSketchMorph inBounds: boundsToUse pasteUpMorph: aPasteUpMorph paintBoxPosition: aPosition "NB: if aPosition is nil, then it's assumed that the paintbox is obtained from a flap or some such, so do nothing special regarding a palette in this case. The palette needs already to be in the world for this to work." | w | (w := aPasteUpMorph world) addMorphInLayer: self. "in back of palette" enclosingPasteUpMorph := aPasteUpMorph. hostView := aSketchMorph. "may be ownerless" self bounds: boundsToUse. palette := w paintBox focusMorph: self. palette beStatic. "give Nebraska whatever help we can" palette addWeakDependent: self. aPosition ifNotNil: [w addMorphFront: palette. "bring to front" + palette position: aPosition. + Preferences useBiggerPaintingBox ifTrue: [palette beSupersized]]. - palette position: aPosition]. paintingForm := Form extent: bounds extent depth: w assuredCanvas depth. self dimTheWindow. self addRotationScaleHandles. aSketchMorph ifNotNil: [ aSketchMorph form displayOn: paintingForm at: (hostView boundsInWorld origin - bounds origin - hostView form offset) clippingBox: (0@0 extent: paintingForm extent) rule: Form over fillColor: nil. "assume they are the same depth". undoBuffer := paintingForm deepCopy. rotationCenter := aSketchMorph rotationCenter]!

1 0

#compareSafely: and complex numbers
by Thiede, Christoph 26 Sep '19

26 Sep '19

Hi all, I just found out that the following throws a DNU: 1 compareSafely: 1 i. It is mathematically correct that Complex does not implement #<. However, why does Complex override #isNumber to return true? Where is this used? Should we maybe check in Number>>#compareSafely: whether aNumber respondsTo: #<? Or introduce something like #isMagnitude? Number>>compareSafely: aNumber ^ (aNumber isNumber and: [aNumber isMagnitude]) ifTrue: [ self < aNumber ] ifFalse: [ super compareSafely: aNumber ] Best, Christoph

1 0

The Trunk: Tools-mt.893.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.893.mcz ==================== Summary ==================== Name: Tools-mt.893 Author: mt Time: 24 September 2019, 5:16:51.52786 pm UUID: 40c3d300-00ba-854f-b33f-042b711bc73c Ancestors: Tools-mt.892 More fixes and code clean-up in debugger: - make stack sizes a preference(s) - move code to specific (Morphic/MVC) subclasses =============== Diff against Tools-mt.892 =============== Item was changed: CodeHolder subclass: #Debugger instanceVariableNames: 'interruptedProcess contextStack contextStackIndex contextStackList receiverInspector contextVariablesInspector externalInterrupt proceedValue selectingPC savedCursor isolationHead failedProject labelString message untilExpression' + classVariableNames: 'ContextStackKeystrokes ErrorRecursion ErrorRecursionGuard ErrorReportServer FullStackSize InterruptUIProcessIfBlockedOnErrorInBackgroundProcess NotifierStackSize SavedExtent StackSizeLimit WantsAnnotationPane' - classVariableNames: 'ContextStackKeystrokes ErrorRecursion ErrorRecursionGuard ErrorReportServer InterruptUIProcessIfBlockedOnErrorInBackgroundProcess SavedExtent WantsAnnotationPane' poolDictionaries: '' category: 'Tools-Debugger'! !Debugger commentStamp: '<historical>' prior: 0! I represent the machine state at the time of an interrupted process. I also represent a query path into the state of the process. The debugger is typically viewed through a window that views the stack of suspended contexts, the code for, and execution point in, the currently selected message, and inspectors on both the receiver of the currently selected message, and the variables in the current context. Special note on recursive errors: Some errors affect Squeak's ability to present a debugger. This is normally an unrecoverable situation. However, if such an error occurs in an isolation layer, Squeak will attempt to exit from the isolation layer and then present a debugger. Here is the chain of events in such a recovery. * A recursive error is detected. * The current project is queried for an isolationHead * Changes in the isolationHead are revoked * The parent project of isolated project is returned to * The debugger is opened there and execution resumes. If the user closes that debugger, execution continues in the outer project and layer. If, after repairing some damage, the user proceeds from the debugger, then the isolationHead is re-invoked, the failed project is re-entered, and execution resumes in that world. ! Item was added: + ----- Method: Debugger class>>fullStackSize (in category 'preferences') ----- + fullStackSize + + <preference: 'Stack Size in Full Debugger' + categoryList: #(debug tools) + description: 'The number of stack frames to be shown in the full debugger. You can always expand the full stack there.' + type: #Number> + + ^ FullStackSize ifNil: [20]! Item was added: + ----- Method: Debugger class>>fullStackSize: (in category 'preferences') ----- + fullStackSize: aNumber + + FullStackSize := aNumber max: self notifierStackSize.! Item was added: + ----- Method: Debugger class>>lowSpaceChoices (in category 'private') ----- + lowSpaceChoices + "Return a notifier message string to be presented when space is running low." + + ^ 'Warning!! Squeak is almost out of memory!! + + Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. + + Here are some suggestions: + + If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. + + If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... + > Close any windows that are not needed. + > Get rid of some large objects (e.g., images). + > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. + + If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). + + ' + ! Item was added: + ----- Method: Debugger class>>notifierStackSize (in category 'preferences') ----- + notifierStackSize + + <preference: 'Stack Size in Notifier Debugger' + categoryList: #(debug tools) + description: 'If there is no message to be displayed in the notifier, how many stack frames should be visible?' + type: #Number> + + ^ NotifierStackSize ifNil: [10]! Item was added: + ----- Method: Debugger class>>notifierStackSize: (in category 'preferences') ----- + notifierStackSize: anInteger + + NotifierStackSize := anInteger.! Item was added: + ----- Method: Debugger class>>stackSizeLimit (in category 'preferences') ----- + stackSizeLimit + + <preference: 'Stack Size Limit' + categoryList: #(debug tools) + description: 'Even when expanding the entire stack, there should be a limit to avoid low-space errors.' + type: #Number> + + ^ StackSizeLimit ifNil: [100000]! Item was added: + ----- Method: Debugger class>>stackSizeLimit: (in category 'preferences') ----- + stackSizeLimit: aNumber + + StackSizeLimit := aNumber max: self fullStackSize.! Item was changed: ----- Method: Debugger>>abandon: (in category 'context stack menu') ----- abandon: aTopView "abandon the notifier represented by aTopView" + + self subclassResponsibility.! - ToolBuilder default close: aTopView! Item was removed: - ----- Method: Debugger>>close: (in category 'context stack menu') ----- - close: aScheduledController - "The argument is a controller on a view of the receiver. - That view is closed." - - aScheduledController close - ! Item was changed: ----- Method: Debugger>>debug (in category 'notifier menu') ----- debug + "Open a full debugger." + + self openFullFromNotifier: self topView. - "Open a full DebuggerView." - | topView | - topView := self topView. - topView model: nil. "so close won't release me." - self breakDependents. - self openFullNoSuspendFrom: topView. ! Item was changed: ----- Method: Debugger>>debugAt: (in category 'initialize') ----- debugAt: anInteger + "Opens a full debugger with the given index selected. See #initializeFull to understand why contextStackIndex is set directly." + + contextStackIndex := anInteger. + ^ self debug! - self toggleContextStackIndex: anInteger. - ^ self debug.! Item was added: + ----- Method: Debugger>>expandNotifierStack (in category 'context stack (message list)') ----- + expandNotifierStack + "Show a small amount of stack in the context pane. Useful for notifiers." + + self okToChange ifFalse: [^ self]. + self newStack: (self contextStackTop stackOfSize: self class notifierStackSize). + self changed: #contextStackList. + ! Item was changed: ----- Method: Debugger>>expandStack (in category 'context stack (message list)') ----- expandStack + "Show a substantial amount of stack in the context pane." - "A Notifier is being turned into a full debugger. Show a substantial amount of stack in the context pane." + self okToChange ifFalse: [^ self]. + self newStack: (self contextStackTop stackOfSize: self class fullStackSize). + self changed: #contextStackList. + ! - self newStack: (self contextStackTop stackOfSize: 20). - contextStackIndex := 0. - receiverInspector := Inspector inspect: nil. - contextVariablesInspector := ContextVariablesInspector inspect: nil. - proceedValue := nil! Item was changed: ----- Method: Debugger>>fullyExpandStack (in category 'context stack (message list)') ----- fullyExpandStack + "Expand the stack to include all of it. Well, almost all of it, we better maintain sane limits too." - "Expand the stack to include all of it, rather than the first four or five contexts. - Well, almost all of it, we better maintain sane limits too." self okToChange ifFalse: [^ self]. + self newStack: (self contextStackTop stackOfSize: self class stackSizeLimit - contextStack size). + self changed: #contextStackList.! - self newStack: (self contextStackTop stackOfSize: contextStack size + 100000). - self changed: #contextStackList! Item was changed: ----- Method: Debugger>>initialize (in category 'initialize') ----- initialize super initialize. Smalltalk at: #MessageTally ifPresentAndInMemory: [ :tally | tally terminateTimerProcess]. externalInterrupt := false. + selectingPC := true. + + contextStackIndex := 0.! - selectingPC := true.! Item was added: + ----- Method: Debugger>>initializeFull (in category 'initialize') ----- + initializeFull + "Expand the stack for the full debugger. Create inspectors." + + | oldIndex | + oldIndex := contextStackIndex. + contextStackIndex := 0. + + self expandStack. + + receiverInspector := Inspector inspect: nil. + contextVariablesInspector := ContextVariablesInspector inspect: nil. + + self toggleContextStackIndex: oldIndex.! Item was removed: - ----- Method: Debugger>>lowSpaceChoices (in category 'private') ----- - lowSpaceChoices - "Return a notifier message string to be presented when space is running low." - - ^ 'Warning!! Squeak is almost out of memory!! - - Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. - - Here are some suggestions: - - If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. - - If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... - > Close any windows that are not needed. - > Get rid of some large objects (e.g., images). - > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. - - If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). - - ' - ! Item was added: + ----- Method: Debugger>>openFullFromNotifier: (in category 'initialize') ----- + openFullFromNotifier: topView + "Create a full debugger with the given label. Subclasses should complete this procedure." + + self initializeFull. + + topView model: nil. "so close won't release me." + self breakDependents.! Item was removed: - ----- Method: Debugger>>openFullNoSuspendFrom: (in category 'initialize') ----- - openFullNoSuspendFrom: topView - "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." - - | oldContextStackIndex | - oldContextStackIndex := contextStackIndex. - self expandStack. "Sets contextStackIndex to zero." - ^[ToolBuilder default openDebugger: self label: topView label closing: topView] ensure: - [self toggleContextStackIndex: oldContextStackIndex]! Item was changed: ----- Method: Debugger>>openFullNoSuspendLabel: (in category 'initialize') ----- openFullNoSuspendLabel: aString + "Create, schedule and answer a full debugger with the given label. Subclasses should complete this procedure." - "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." + self initializeFull.! - | oldContextStackIndex | - oldContextStackIndex := contextStackIndex. - self expandStack. "Sets contextStackIndex to zero." - ^[ToolBuilder default openDebugger: self label: aString] ensure: - [self toggleContextStackIndex: oldContextStackIndex]! Item was removed: - ----- Method: Debugger>>openNotifierContents:label: (in category 'initialize') ----- - openNotifierContents: msgString label: label - "Create, schedule and answer a notifier view with the given label and message. A notifier view shows just the message or the first several lines of the stack, with a menu that allows the user to open a full debugger if so desired." - "NOTE: When this method returns, a new process has been scheduled to run the windows, and thus this notifier, but the previous active process has not been suspended. The sender will do this." - | msg builder spec | - - Sensor flushKeyboard. - savedCursor := Cursor currentCursor. - Cursor currentCursor: Cursor normal. - msg := (label beginsWith: 'Space is low') - ifTrue: [self lowSpaceChoices, (msgString ifNil: [String empty])] - ifFalse: [msgString]. - builder := ToolBuilder default. - spec := self buildNotifierWith: builder label: label message: msg. - self expandStack. - ^ builder openDebugger: spec! Item was added: + ----- Method: Debugger>>openNotifierNoSuspendContents:label: (in category 'initialize') ----- + openNotifierNoSuspendContents: msgString label: label + "Create, schedule and answer a notifier view with the given label and message. A notifier view shows just the message or the first several lines of the stack, with a menu that allows the user to open a full debugger if so desired." + "NOTE: When this method returns, a new process has been scheduled to run the windows, and thus this notifier, but the previous active process has not been suspended. The sender will do this." + + Sensor flushKeyboard. + savedCursor := Cursor currentCursor. + Cursor currentCursor: Cursor normal. + + self expandNotifierStack.! Item was removed: - ----- Method: Debugger>>release (in category 'initialize') ----- - release - - self windowIsClosing. - super release. - !

3 3

The Trunk: Tools-mt.894.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.894.mcz ==================== Summary ==================== Name: Tools-mt.894 Author: mt Time: 26 September 2019, 11:51:47.732232 am UUID: 49cc71d2-c009-b546-a310-b7bc31cd2eb0 Ancestors: Tools-mt.893 Fixes recent regression with "create" button in debugger notifier. Cleans up message categories to make the notifier functionality more clear. =============== Diff against Tools-mt.893 =============== Item was changed: + ----- Method: Debugger>>askForCategoryIn:default: (in category 'notifier support') ----- - ----- Method: Debugger>>askForCategoryIn:default: (in category 'context stack menu') ----- askForCategoryIn: aClass default: aString | categories index category | categories := OrderedCollection with: 'new ...'. categories addAll: (aClass allMethodCategoriesIntegratedThrough: Object). index := UIManager default chooseFrom: categories title: 'Please provide a good category for the new method!!' translated. index = 0 ifTrue: [^ aString]. category := index = 1 ifTrue: [UIManager default request: 'Enter category name:'] ifFalse: [categories at: index]. ^ category isEmpty ifTrue: [^ aString] ifFalse: [category]! Item was changed: + ----- Method: Debugger>>askForSuperclassOf:toImplement:ifCancel: (in category 'notifier support') ----- - ----- Method: Debugger>>askForSuperclassOf:toImplement:ifCancel: (in category 'private') ----- askForSuperclassOf: aClass toImplement: aSelector ifCancel: cancelBlock | classes chosenClassIndex | classes := aClass withAllSuperclasses. chosenClassIndex := UIManager default chooseFrom: (classes collect: [:c | c name]) title: 'Define #', aSelector, ' in which class?'. chosenClassIndex = 0 ifTrue: [^ cancelBlock value]. ^ classes at: chosenClassIndex! Item was changed: + ----- Method: Debugger>>askForSuperclassOf:upTo:toImplement:ifCancel: (in category 'notifier support') ----- - ----- Method: Debugger>>askForSuperclassOf:upTo:toImplement:ifCancel: (in category 'private') ----- askForSuperclassOf: aClass upTo: superclass toImplement: aSelector ifCancel: cancelBlock | classes chosenClassIndex | classes := aClass withAllSuperclasses reject: [:cls | aClass isKindOf: cls]. chosenClassIndex := UIManager default chooseFrom: (classes collect: [:c | c name]) title: 'Define #', aSelector, ' in which class?'. chosenClassIndex = 0 ifTrue: [^ cancelBlock value]. ^ classes at: chosenClassIndex! Item was changed: + ----- Method: Debugger>>contextStackIndex (in category 'context stack - message list') ----- - ----- Method: Debugger>>contextStackIndex (in category 'context stack (message list)') ----- contextStackIndex "Answer the index of the selected context." ^contextStackIndex! Item was changed: + ----- Method: Debugger>>contextStackList (in category 'context stack - message list') ----- - ----- Method: Debugger>>contextStackList (in category 'context stack (message list)') ----- contextStackList "Answer the array of contexts." ^contextStackList! Item was changed: + ----- Method: Debugger>>createImplementingMethod (in category 'notifier buttons') ----- - ----- Method: Debugger>>createImplementingMethod (in category 'private') ----- createImplementingMethod "Should only be called when this Debugger was created in response to a NotYetImplemented exception. All we need to do is pop the signalling context off the stack and open the #notYetImplemented method." | signallingContext | + self initializeFull. signallingContext := self selectedContext sender. "Pop the signalling context off the stack" self resetContext: signallingContext. self debug.! Item was changed: + ----- Method: Debugger>>createMethod (in category 'notifier buttons') ----- - ----- Method: Debugger>>createMethod (in category 'private') ----- createMethod "Should only be called when this Debugger was created in response to a MessageNotUnderstood exception. Create a stub for the method that was missing and proceed into it." | msg chosenClass | + self initializeFull. msg := self contextStackTop exceptionMessage. chosenClass := self askForSuperclassOf: self contextStackTop receiver class toImplement: msg selector ifCancel: [^self]. self implementMissingMethod: msg inClass: chosenClass.! Item was changed: + ----- Method: Debugger>>createOverridingMethod (in category 'notifier buttons') ----- - ----- Method: Debugger>>createOverridingMethod (in category 'private') ----- createOverridingMethod "Should only be called when this Debugger was created in response to a SubclassResponsibility exception. Create a stub for the method that needs overriding and proceed into it. Let the user only select a class in the inheritance chain between the actual class and the class declaring the subclassResponsibility." | chosenClass msg category | + self initializeFull. msg := self contextStackTop exceptionMessage. chosenClass := self askForSuperclassOf: self contextStackTop receiver class upTo: self contextStackTop sender method methodClass toImplement: msg selector ifCancel: [^self]. "Use the same category as the marker method." category := self contextStackTop sender selectorCategory. self implementOverridingMethod: msg inClass: chosenClass inCategory: category.! Item was changed: + ----- Method: Debugger>>debugAt: (in category 'notifier buttons') ----- - ----- Method: Debugger>>debugAt: (in category 'initialize') ----- debugAt: anInteger "Opens a full debugger with the given index selected. See #initializeFull to understand why contextStackIndex is set directly." contextStackIndex := anInteger. ^ self debug! Item was changed: + ----- Method: Debugger>>expandNotifierStack (in category 'context stack - message list') ----- - ----- Method: Debugger>>expandNotifierStack (in category 'context stack (message list)') ----- expandNotifierStack "Show a small amount of stack in the context pane. Useful for notifiers." self okToChange ifFalse: [^ self]. self newStack: (self contextStackTop stackOfSize: self class notifierStackSize). self changed: #contextStackList. ! Item was changed: + ----- Method: Debugger>>expandStack (in category 'context stack - message list') ----- - ----- Method: Debugger>>expandStack (in category 'context stack (message list)') ----- expandStack "Show a substantial amount of stack in the context pane." self okToChange ifFalse: [^ self]. self newStack: (self contextStackTop stackOfSize: self class fullStackSize). self changed: #contextStackList. ! Item was changed: + ----- Method: Debugger>>fullyExpandStack (in category 'context stack - message list') ----- - ----- Method: Debugger>>fullyExpandStack (in category 'context stack (message list)') ----- fullyExpandStack "Expand the stack to include all of it. Well, almost all of it, we better maintain sane limits too." self okToChange ifFalse: [^ self]. self newStack: (self contextStackTop stackOfSize: self class stackSizeLimit - contextStack size). self changed: #contextStackList.! Item was changed: + ----- Method: Debugger>>implementMissingMethod:inClass: (in category 'notifier support') ----- - ----- Method: Debugger>>implementMissingMethod:inClass: (in category 'context stack menu') ----- implementMissingMethod: aMessage inClass: aClass ^ self implementMissingMethod: aMessage inClass: aClass inCategory: (self askForCategoryIn: aClass default: 'as yet unclassified').! Item was changed: + ----- Method: Debugger>>implementMissingMethod:inClass:inCategory: (in category 'notifier support') ----- - ----- Method: Debugger>>implementMissingMethod:inClass:inCategory: (in category 'context stack menu') ----- implementMissingMethod: aMessage inClass: aClass inCategory: aSymbol "Create a stub implementation of the missing message and sew it onto the top of the stack, ensuring the context's arguments are set correctly. Debug the new context." self pushStubMethodOnStack: aMessage inClass: aClass inCategory: aSymbol. "Cut out the sender context. This is the context that signalled the MessageNotUnderstood." self selectedContext privSender: self selectedContext sender. self resetContext: self selectedContext. self debug.! Item was changed: + ----- Method: Debugger>>implementOverridingMethod:inClass:inCategory: (in category 'notifier support') ----- - ----- Method: Debugger>>implementOverridingMethod:inClass:inCategory: (in category 'context stack menu') ----- implementOverridingMethod: aMessage inClass: aClass inCategory: aSymbol "Create a stub implementation of the overriding message and sew it onto the top of the stack, ensuring the context's arguments are set correctly. Debug the new context." self pushStubMethodOnStack: aMessage inClass: aClass inCategory: aSymbol. "Cut out the sender context. This is the context that signalled the SubclassResponsibility." self selectedContext privSender: self selectedContext sender sender. self resetContext: self selectedContext. self debug.! Item was changed: + ----- Method: Debugger>>messageHelpAt: (in category 'context stack - message list') ----- - ----- Method: Debugger>>messageHelpAt: (in category 'context stack (message list)') ----- messageHelpAt: anIndex "Show the first n lines of the sources code of the selected message." | method | Preferences balloonHelpInMessageLists ifFalse: [^ nil]. contextStack size < anIndex ifTrue: [^ nil]. method := (contextStack at: anIndex) method. ^ self messageHelpForMethod: method.! Item was changed: + ----- Method: Debugger>>messageIconAt: (in category 'context stack - message list') ----- - ----- Method: Debugger>>messageIconAt: (in category 'context stack (message list)') ----- messageIconAt: anIndex Browser showMessageIcons ifFalse: [^ nil]. ^ ToolIcons iconNamed: (ToolIcons iconForClass: (contextStack at: anIndex) method methodClass selector: (contextStack at: anIndex) method selector)! Item was changed: + ----- Method: Debugger>>messageListIndex (in category 'context stack - message list') ----- - ----- Method: Debugger>>messageListIndex (in category 'context stack (message list)') ----- messageListIndex "Answer the index of the currently selected context." ^contextStackIndex! Item was removed: - ----- Method: Debugger>>populateImplementInMenu: (in category 'context stack menu') ----- - populateImplementInMenu: aMenu - - | msg | - msg := self selectedContext at: 1. - self selectedContext receiver class withAllSuperclasses do: - [:each | - aMenu add: each name target: self selector: #implementMissingMethod:inClass: argumentList: (Array with: msg with: each)]. - ^ aMenu - - ! Item was changed: + ----- Method: Debugger>>selectedMessage (in category 'context stack - message list') ----- - ----- Method: Debugger>>selectedMessage (in category 'context stack (message list)') ----- selectedMessage "Answer the source code of the currently selected context." | aContext | ^contents := (aContext := self selectedContext) debuggerMap sourceText asText makeSelectorBoldIn: aContext home receiver class! Item was changed: + ----- Method: Debugger>>selectedMessageName (in category 'context stack - message list') ----- - ----- Method: Debugger>>selectedMessageName (in category 'context stack (message list)') ----- selectedMessageName "Answer the message selector of the currently selected context. If the method is unbound we can still usefully answer its old selector." | selector | selector := self selectedContext selector. ^(selector ~~ self selectedContext method selector and: [selector beginsWith: 'DoIt']) ifTrue: [self selectedContext method selector] ifFalse: [selector]! Item was changed: + ----- Method: Debugger>>toggleContextStackIndex: (in category 'context stack - message list') ----- - ----- Method: Debugger>>toggleContextStackIndex: (in category 'context stack (message list)') ----- toggleContextStackIndex: anInteger "If anInteger is the same as the index of the selected context, deselect it. Otherwise, the context whose index is anInteger becomes the selected context." self contextStackIndex: (contextStackIndex = anInteger ifTrue: [0] ifFalse: [anInteger]) oldContextWas: (contextStackIndex = 0 ifTrue: [nil] ifFalse: [contextStack at: contextStackIndex])!

1 0

The Trunk: Morphic-mt.1543.mcz
by commits＠source.squeak.org 26 Sep '19

26 Sep '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1543.mcz ==================== Summary ==================== Name: Morphic-mt.1543 Author: mt Time: 26 September 2019, 11:24:13.678433 am UUID: f9c6bf1e-dc48-304e-ac71-cc10caf41ef9 Ancestors: Morphic-mt.1542 Adds a convenient way to have dashed borders for morphs. Note that this does not work for rounded corners. See Canvas. Morph new borderStyle: (DashedBorder width: 1); openInWorld. =============== Diff against Morphic-mt.1542 =============== Item was changed: ----- Method: BorderStyle class>>width:color: (in category 'instance creation') ----- width: aNumber color: aColor + "Since I am abstact, use SimpleBorder instead." + + ^ (self == BorderStyle ifTrue: [SimpleBorder] ifFalse: [self]) new + color: aColor; + width: aNumber; + yourself! - ^SimpleBorder new color: aColor; width: aNumber; yourself! Item was added: + SimpleBorder subclass: #DashedBorder + instanceVariableNames: 'dashLength gapLength gapColor offset' + classVariableNames: '' + poolDictionaries: '' + category: 'Morphic-Borders'! Item was added: + ----- Method: DashedBorder>>dashLength (in category 'accessing') ----- + dashLength + + ^ dashLength! Item was added: + ----- Method: DashedBorder>>dashLength: (in category 'accessing') ----- + dashLength: anObject + + dashLength := anObject.! Item was added: + ----- Method: DashedBorder>>frameRectangle:on: (in category 'drawing') ----- + frameRectangle: aRectangle on: aCanvas + + { + aRectangle topLeft. aRectangle topRight - (1@0). + aRectangle topRight - (1@0). aRectangle bottomRight - (1@1). + aRectangle bottomRight - (1@1). aRectangle bottomLeft - (0@1). + aRectangle bottomLeft - (0@1). aRectangle topLeft. + } pairsDo: [:startPoint :endPoint | + aCanvas + line: startPoint to: endPoint + width: self width + color: self color + dashLength: self dashLength + secondColor: self gapColor + secondDashLength: self gapLength + startingOffset: self offset]! Item was added: + ----- Method: DashedBorder>>gapColor (in category 'accessing') ----- + gapColor + + ^ gapColor! Item was added: + ----- Method: DashedBorder>>gapColor: (in category 'accessing') ----- + gapColor: anObject + + gapColor := anObject.! Item was added: + ----- Method: DashedBorder>>gapLength (in category 'accessing') ----- + gapLength + + ^ gapLength! Item was added: + ----- Method: DashedBorder>>gapLength: (in category 'accessing') ----- + gapLength: anObject + + gapLength := anObject.! Item was added: + ----- Method: DashedBorder>>initialize (in category 'initialize-release') ----- + initialize + + super initialize. + + dashLength := 10. + + gapLength := 4. + gapColor := Color transparent. + + offset := 0.! Item was added: + ----- Method: DashedBorder>>offset (in category 'accessing') ----- + offset + + ^ offset! Item was added: + ----- Method: DashedBorder>>offset: (in category 'accessing') ----- + offset: anObject + + offset := anObject.! Item was changed: ----- Method: SimpleBorder>>initialize (in category 'initialize-release') ----- initialize + + super initialize. width := 0. baseColor := color := Color transparent!

1 0

TinyWiki headings related bug and oddness.
by tim Rowledge 26 Sep '19

26 Sep '19

After all the recent fun of getting a version of squeaksource running locally, fixing some bugs and slightly improving the security, I noticed that on the swiki pages the headings were just plain wrong. This problem is easily observable on the main squeaksource.com site too. The parsing rules say that !heading should produce an html <h1>heading</h1> tag - but in fact we were getting some weird junk looking like <heading></heading><level>1</level><with>heading</with>. Which doesn't seem quite right. It renders as 1heading - definitely not what we wanted. I tracked it down to a fairly silly and very old bug in TWViewer>visitHeading: that took a bit of head-scratching to solve, for reasons largely to do with the fact that there are NO DAMN COMMENTS anywhere. Whoever wrote that - please accept this virtual nose-poke. I found two other places where the same problem was occurring due to a different aspect of the same bug, but I can't see what on Earth the html is actually doing. For example, in TWWiki>renderWikiReferencesOn: the produced html is basically that shown above plus one or more internal wiki links. What we actually see on the page is References: Home otherLink where, a bit oddly, the References gets a colon added and bolded. There is one possibly significant difference in the html though, in that the <level> tags are actually <level1>. But I am no expert in current html and quick googling doesn't provide any immediately inspiring answers. If I change the references listing to a more sensible looking (to me) use of #heading: and #list:do: then we get the list of references but in a vertical list instead of a horizontal row, and weirdly the heading is simply not displayed. It *is* in the html though. Gronk? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim All new: The software is not compatible with previous versions.

1 1

The Trunk: CollectionsTests-jr.320.mcz
by commits＠source.squeak.org 25 Sep '19

25 Sep '19

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-jr.320.mcz ==================== Summary ==================== Name: CollectionsTests-jr.320 Author: jr Time: 25 September 2019, 3:41:23.707261 pm UUID: 54df98c0-c984-3b45-b189-dc267b743422 Ancestors: CollectionsTests-dtl.318 Add test for change in Collections-jr.855 =============== Diff against CollectionsTests-dtl.318 =============== Item was added: + ClassTestCase subclass: #WeakKeyDictionaryTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Weak'! Item was added: + ----- Method: WeakKeyDictionaryTest>>testNilDoesNotInheritValueOfGarbageCollectedObject (in category 'tests') ----- + testNilDoesNotInheritValueOfGarbageCollectedObject + "When the keys are garbage collected, they become nil in the associations. + This must not mislead the dictionary to answer that nil had one of the values of these + associations!!" + | dictionary hashTable | + dictionary := self targetClass new. + "Craft a hash table where all keys were freed." + hashTable := dictionary array. + self assert: hashTable size > 0. + hashTable replace: [:each | WeakKeyAssociation key: nil value: 1]. + self assert: (dictionary at: nil ifAbsent: []) isNil. "and not 1"!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
36
Older →

Jump to page: