Squeak-dev January 2020

squeak-dev@lists.squeakfoundation.org

43 participants
228 discussions

The Trunk: Collections-nice.870.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.870.mcz ==================== Summary ==================== Name: Collections-nice.870 Author: nice Time: 6 January 2020, 5:12:04.309788 pm UUID: 1dd850f8-5ca9-4444-833f-fd10805c0e43 Ancestors: Collections-fn.869 Fix sendersOfIt for searching senders of an expression including a literal (byte) array If you select following text preference: 'Send Mouse Wheel Events to Keyboard Focus' categoryList: #(Morphic keyboard mouse) description: 'If enabled, follow the behavior known from Microsoft Windows, where the mouse wheel works for the widget that has the keyboard focus. If disabled, follow the Mac OS style, where the mouse wheel is send to the widget under the mouse position' type: #Boolean and browse senders, then if search for senders of #preference: instead of the whole keyword This is because '#(Morphic keyboard mouse)' was replaced with '#aSymbol keyboard mouse)' Also handle the nasty character literals like $: or those that create imbalanced enclosing $( $[ ${ =============== Diff against Collections-fn.869 =============== Item was changed: ----- Method: String>>findSelector (in category 'converting') ----- findSelector "Dan's code for hunting down selectors with keyword parts; while this doesn't give a true parse, in most cases it does what we want, in where it doesn't, we're none the worse for it." | sel possibleParens | sel := self withBlanksTrimmed. (sel includes: $:) ifTrue: [sel := sel copyWithRegex: '''[^'']*''' matchesReplacedWith: '''a string'''. + sel := sel copyWithRegex: '#[^\[\(\s\.$]*' matchesReplacedWith: '#aSymbol'. + sel := sel copyWithRegex: '\$.' matchesReplacedWith: '$x'. "handle $( $[ and $:" - sel := sel copyWithRegex: '#[^\s\.$]*' matchesReplacedWith: '#aSymbol'. sel := sel copyReplaceAll: ':' with: ': '. "for the style (aa max:bb) with no space" sel := sel copyReplaceAll: '[:' with: '[ :'. "for the style ([:a) with no space" possibleParens := sel substrings. sel := self class streamContents: [:s | | level | level := 0. possibleParens do: [:token | (level = 0 and: [token endsWith: ':']) ifTrue: [s nextPutAll: token] ifFalse: [level := level + (token occurrencesOf: $() - (token occurrencesOf: $)) + (token occurrencesOf: $[) - (token occurrencesOf: $]) + (token occurrencesOf: ${) - (token occurrencesOf: $})]]]] ifFalse: [sel := self substrings ifNotEmpty: [:tokens | tokens last]]. sel ifEmpty: [^ nil]. sel first = $# ifTrue: [sel := sel allButFirst. sel ifEmpty: [^ nil]]. sel isOctetString ifTrue: [sel := sel asOctetString]. ^ Symbol lookup: sel!

1 0

The Trunk: CollectionsTests-nice.331.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.331.mcz ==================== Summary ==================== Name: CollectionsTests-nice.331 Author: nice Time: 6 January 2020, 4:59:24.650788 pm UUID: c70bd67a-8408-084d-97f1-df44c0d372ae Ancestors: CollectionsTests-mt.330 More testFindSelector cases This covers some case of literal arguments (literal array and Character) =============== Diff against CollectionsTests-mt.330 =============== Item was changed: ----- Method: StringTest>>testFindSelector (in category 'tests - finding') ----- testFindSelector #( #negated 'negated' "Simplest case." #negated '#negated' "Ignore leading #" #negated ' negated' "Ignore leading whitespace" nil 'shouldnotexist42' "Do not intern new symbols." nil '' "No empty symbols." #copy 'self copy' "Ignore leading receiver." #copyWithout: 'self copyWithout: 42' "Ignore leading receiver." #negated 'self copy negated' "Choose last selector if several." #drawOn: 'drawOn:' nil 'drawOn' "Do not add colons." #drawOn: 'drawOn: aCanvas' "Ignore argument" #at:put: 'at: 42 put: nil' "Ignore arguments" #at:put: 'at: #drawOn: put: 42' "Ignore colons in arguments." #at:put: 'at:42 put:43' "Scarce whitepsace" + #at:put: 'at: ''key:'' put: nil' "Ignore : inside String literal" + #at:put: 'at: #(foo bar baz:) put:43' "handle literal array" + #at:put: 'at: $( put:$: asInteger' "Ignore : in Character literal" #ifTrue: 'ifTrue: [self open]' #ifTrue:ifFalse: 'ifTrue: [] ifFalse: [self close]' #ifNotEmpty: 'ifNotEmpty: [:all | all sum]' #+ '+' #+ '1 +' nil '+ 2' nil '1 + 2' ) pairsDo: [:selector :string | self assert: selector equals: string findSelector].!

1 0

Wiki pages for screenshots & details about Squeak projects
by tim Rowledge 06 Jan '20

06 Jan '20

Whilst quickly updating the VMMaker swiki page I got lead to the exobox page, and thence the 'Screenshots of Applications created with Squeak' page and the 'Production Squeak' page. Oh my, very out of date and many missing images. If you have or had entries on such pages, please see if you can recover the missing screenshots. If there is news about the products/projects, please add it; if you know of something not listed, please add it ! tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim "Yummy" said Pooh, as he rotated Piglet slowly on the spit.

2 1

[Q][Squeak5.3a][ExternalPackage] FileList class>>#registerFileReader: has been deprecated --> How do I fix this?
by H. Hirzel 06 Jan '20

06 Jan '20

Hello When loading an external package I get the following feedback FileList class>>#registerFileReader: has been deprecated. FileList is not responsible for file reader registration anymore. Use FileServices instead. When I click on 'debug' I get registeredFileReaderClasses self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. FileReaderRegistry := nil. "wipe it out" ^FileServices registeredFileReaderClasses How do I deal with this? Old code? New code? Regards Hannes

2 1

SystemProgressMorph applyUserInterfaceTheme
by Thiede, Christoph 06 Jan '20

06 Jan '20

Hi all, hi Marcel :-) What is the purpose of the class-side #applyUserInterfaceTheme implementation in SystemProgressMorph? SystemProgressMorph class >> applyUserInterfaceTheme self reset. Given the following snippet: Project current uiManager informUser: 'Foo' during: [ Preferences changeFontSize: 0. self halt] Currently, the SystemProgressMorph has abandoned when a debugger appears. If I remove the class-side method from above, everything works as expected. What are the considerations to hide all progress if the UI theme is changed? Best, Christoph

2 2

The Inbox: PreferenceBrowser-ct.99.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Christoph Thiede uploaded a new version of PreferenceBrowser to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.99.mcz ==================== Summary ==================== Name: PreferenceBrowser-ct.99 Author: ct Time: 31 December 2019, 2:53:14.748022 am UUID: dd537552-5f25-8648-9f2c-0d83840c16a8 Ancestors: PreferenceBrowser-mt.97 Add a button to open the preference wizard from the preference browser. It's just too cool to not being reused after initial setup! =============== Diff against PreferenceBrowser-mt.97 =============== Item was added: + ----- Method: PreferenceBrowser>>wizardSelected (in category 'preferences search') ----- + wizardSelected + + PreferenceWizardMorph openPlayfield! Item was changed: ----- Method: PreferenceBrowserMorph>>newButtonRow (in category 'submorphs - buttons') ----- newButtonRow ^BorderedMorph new color: Color transparent; borderWidth: 0; cellGap: 2; layoutInset: 2; layoutPolicy: TableLayout new; listDirection: #leftToRight; listCentering: #topLeft; cellPositioning: #topLeft; on: #mouseEnter send: #paneTransition: to: self; on: #mouseLeave send: #paneTransition: to: self; addMorphBack: self defaultButton; addMorphBack: self newSeparator; addMorphBack: self saveButton; addMorphBack: self loadButton; addMorphBack: self newSeparator; addMorphBack: self saveToDiskButton; addMorphBack: self loadFromDiskButton; addMorphBack: self newSeparator; addMorphBack: self themeButton; + addMorphBack: self newSeparator; + addMorphBack: self wizardButton; addMorphBack: self newTransparentFiller; addMorphBack: self helpButton; yourself.! Item was added: + ----- Method: PreferenceBrowserMorph>>wizardButton (in category 'submorphs - buttons') ----- + wizardButton + + ^ wizardButton ifNil: [wizardButton := + self basicButton + label: 'wizard' translated; + setBalloonText: 'The preferences wizard guides you through the most important preferences for your Squeak image.' translated; + action: #wizardSelected]! Item was changed: Morph subclass: #PreferenceWizardMorph + instanceVariableNames: 'previewWorld titleMorph buttonRowMorph controlMorph startButton previousButton nextButton pages currentPageIndex pagesLabel skipButton isFullScreen lowPerformanceMorph checkmark wantsInstallPage' - instanceVariableNames: 'previewWorld titleMorph buttonRowMorph controlMorph startButton previousButton nextButton pages currentPageIndex pagesLabel skipButton isFullScreen lowPerformanceMorph checkmark' classVariableNames: '' poolDictionaries: '' category: 'PreferenceBrowser'! Item was changed: ----- Method: PreferenceWizardMorph class>>open (in category 'instance creation') ----- open + "PreferenceWizardMorph open" ^ PreferenceWizardMorph new openInWorld! Item was added: + ----- Method: PreferenceWizardMorph class>>openPlayfield (in category 'instance creation') ----- + openPlayfield + "PreferenceWizardMorph openPlayfield" + + ^ PreferenceWizardMorph new openPlayfield! Item was changed: ----- Method: PreferenceWizardMorph>>accept (in category 'actions') ----- accept + wantsInstallPage + ifTrue: [ self showInstallPage] + ifFalse: [self delete]! - self showInstallPage.! Item was changed: ----- Method: PreferenceWizardMorph>>initialize (in category 'initialization') ----- initialize super initialize. + wantsInstallPage := true. isFullScreen := false. self hasLowPerformance ifTrue: [self color: self defaultColor] ifFalse: [self color: (self defaultColor alpha: 0.75)]. self setProperty: #indicateKeyboardFocus toValue: #never. Preferences enable: #systemWindowEmbedOK. titleMorph := ('Welcome to Squeak' translated asText addAttribute: (TextColor color: self defaultTextColor); addAttribute: (TextFontReference toFont: (StrikeFont familyName: 'Darkmap DejaVu Sans' pointSize: 20)); yourself) asMorph lock. titleMorph margins: (10@0 corner: 10@10). titleMorph layoutFrame: (LayoutFrame fractions: (0 @ 0 corner: 1 @ 0) offsets: (0@ 0 corner: 0 @ titleMorph height)). self initializePages; initializeButtons; initializeControlMorph; initializePreviewWorld; initializeForLowPerformance. self changeProportionalLayout; layoutInset: 20; cellGap: 10; cellPositioning: #center; addAllMorphs: {titleMorph. buttonRowMorph. controlMorph. previewWorld. startButton. skipButton. lowPerformanceMorph}. self addKeyboardCaptureFilter: self.! Item was added: + ----- Method: PreferenceWizardMorph>>openPlayfield (in category 'initialization') ----- + openPlayfield + + wantsInstallPage := false. + super openInWorld. + self showPlayfield.!

3 3

The Trunk: EToys-nice.375.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-nice.375.mcz ==================== Summary ==================== Name: EToys-nice.375 Author: nice Time: 29 December 2019, 10:54:09.519527 am UUID: 8b148b65-ad89-4ce1-8059-c051f7227b7e Ancestors: EToys-nice.374 Forgot to commit Etoys along with removal of keyValueIndex in Multilingual-nice.250 =============== Diff against EToys-nice.374 =============== Item was removed: - ----- Method: MacUnicodeInputInterpreter>>keyValueIndex (in category '*Etoys-Squeakland-accessing') ----- - keyValueIndex - ^ keyValueIndex!

1 0

The Trunk: Multilingual-nice.252.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-nice.252.mcz ==================== Summary ==================== Name: Multilingual-nice.252 Author: nice Time: 26 December 2019, 12:00:37.667883 pm UUID: 2a8a7c11-2a55-4a2e-8970-dc9d996e295e Ancestors: Multilingual-nice.251 Expunge macToSqueak from Input Interpreter. There is no more macRoman encoding of (event at: 3) - aka charCode as of https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460 =============== Diff against Multilingual-nice.251 =============== Item was changed: ----- Method: CP1250InputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf "Input from the Czech keyboard under Windows doesn't correspond to cp-1250 or iso-8859-2 encoding!!" | keyValue | keyValue := evtBuf third. + ^ converter toSqueak: keyValue asCharacter. - ^ converter toSqueak: keyValue asCharacter macToSqueak. ! Item was changed: ----- Method: MacRomanInputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf third. + ^ keyValue asCharacter. - ^ keyValue asCharacter macToSqueak. ! Item was changed: ----- Method: SymbolInputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf third. + evtBuf fifth > 1 ifTrue: [^ keyValue asCharacter]. - evtBuf fifth > 1 ifTrue: [^ keyValue asCharacter macToSqueak]. ^ (self symbolKeyValueToUnicode: keyValue) asCharacter. ! Item was changed: ----- Method: UTF32InputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf "Fall back to internal char-code if char is 0" ^(evtBuf at: 6) > 0 ifTrue: [(evtBuf at: 6) asCharacter] ifFalse: + [(evtBuf at: 3) asCharacter]. - [#fixme. - "The windows VM does not require macToSqueak for the fallback char-code - since https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/403 - But unix VM still uses sqTextEncoding which still defaults to MacRoman... - We should fix the Unix VM too, or create two different KeyboardInterpreter. - Hardcoding macToSqueak is a bad idea anyway, because Unix behavior is a - parameter that can be changed thru either --encoding VM option - or SQUEAK_ENCODING environment variable" - (evtBuf at: 3) asCharacter macToSqueak]. ! Item was changed: ----- Method: WinGB2312InputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | firstCharacter secondCharacter peekEvent char1Value keyValue pressType type stream multiCharacter | keyValue := evtBuf third. pressType := evtBuf fourth. pressType = EventKeyDown ifTrue: [type := #keyDown]. pressType = EventKeyUp ifTrue: [type := #keyUp]. pressType = EventKeyChar ifTrue: [type := #keystroke]. + char1Value := (Character value: keyValue) asciiValue. - char1Value := (Character value: keyValue) macToSqueak asciiValue. ((char1Value > 127 and: [char1Value < 160]) or: [char1Value > 223 and: [char1Value < 253]]) ifFalse: [ ^ keyValue asCharacter. ]. peekEvent := sensor peekEvent. "peekEvent printString displayAt: 0@0." (peekEvent notNil and: [(peekEvent at: 4) = EventKeyDown]) ifTrue: [sensor nextEvent. peekEvent := sensor peekEvent]. (type = #keystroke and: [peekEvent notNil and: [(peekEvent at: 1) = EventTypeKeyboard and: [(peekEvent at: 4) = EventKeyChar]]]) ifTrue: [ firstCharacter := char1Value asCharacter. + secondCharacter := (peekEvent at: 3) asCharacter. - secondCharacter := (peekEvent at: 3) asCharacter macToSqueak. stream := ReadStream on: (String with: firstCharacter with: secondCharacter). multiCharacter := converter nextFromStream: stream. multiCharacter isOctetCharacter ifFalse: [ sensor nextEvent. ]. ^ multiCharacter. ]. ^ keyValue asCharacter. ! Item was changed: ----- Method: WinKSX1001InputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | firstCharacter secondCharacter peekEvent char1Value keyValue pressType type stream multiCharacter | keyValue := evtBuf third. pressType := evtBuf fourth. pressType = EventKeyDown ifTrue: [type := #keyDown]. pressType = EventKeyUp ifTrue: [type := #keyUp]. pressType = EventKeyChar ifTrue: [type := #keystroke]. + char1Value := (Character value: keyValue) asciiValue. - char1Value := (Character value: keyValue) macToSqueak asciiValue. ((char1Value > 127 and: [char1Value < 160]) or: [char1Value > 223 and: [char1Value < 253]]) ifFalse: [ ^ keyValue asCharacter. ]. peekEvent := sensor peekEvent. "peekEvent printString displayAt: 0@0." (peekEvent notNil and: [(peekEvent at: 4) = EventKeyDown]) ifTrue: [sensor nextEvent. peekEvent := sensor peekEvent]. (type = #keystroke and: [peekEvent notNil and: [(peekEvent at: 1) = EventTypeKeyboard and: [(peekEvent at: 4) = EventKeyChar]]]) ifTrue: [ firstCharacter := char1Value asCharacter. + secondCharacter := (peekEvent at: 3) asCharacter. - secondCharacter := (peekEvent at: 3) asCharacter macToSqueak. stream := ReadStream on: (String with: firstCharacter with: secondCharacter). multiCharacter := converter nextFromStream: stream. multiCharacter isOctetCharacter ifFalse: [ sensor nextEvent. ]. ^ multiCharacter. ]. ^ keyValue asCharacter. ! Item was changed: ----- Method: WinShiftJISInputInterpreter>>nextCharFrom:firstEvt: (in category 'keyboard') ----- nextCharFrom: sensor firstEvt: evtBuf | firstCharacter secondCharacter peekEvent char1Value keyValue pressType type stream multiCharacter | keyValue := evtBuf third. pressType := evtBuf fourth. pressType = EventKeyDown ifTrue: [type := #keyDown]. pressType = EventKeyUp ifTrue: [type := #keyUp]. pressType = EventKeyChar ifTrue: [type := #keystroke]. + char1Value := (Character value: keyValue) asciiValue. - char1Value := (Character value: keyValue) macToSqueak asciiValue. (char1Value < 16r81) ifTrue: [^ keyValue asCharacter]. (char1Value > 16rA0 and: [char1Value < 16rE0]) ifTrue: [^ ShiftJISTextConverter basicNew katakanaValue: char1Value]. peekEvent := sensor peekEvent. "peekEvent printString displayAt: 0@0." (peekEvent notNil and: [(peekEvent at: 4) = EventKeyDown]) ifTrue: [sensor nextEvent. peekEvent := sensor peekEvent]. (type = #keystroke and: [peekEvent notNil and: [(peekEvent at: 1) = EventTypeKeyboard and: [(peekEvent at: 4) = EventKeyChar]]]) ifTrue: [ firstCharacter := char1Value asCharacter. + secondCharacter := (peekEvent at: 3) asCharacter. - secondCharacter := (peekEvent at: 3) asCharacter macToSqueak. stream := ReadStream on: (String with: firstCharacter with: secondCharacter). multiCharacter := converter nextFromStream: stream. multiCharacter isOctetCharacter ifFalse: [ sensor nextEvent. ]. ^ multiCharacter. ]. ^ keyValue asCharacter. !

1 0

The Trunk: Kernel-nice.1292.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1292.mcz ==================== Summary ==================== Name: Kernel-nice.1292 Author: nice Time: 28 December 2019, 10:15:37.810563 pm UUID: 8cce1ea4-5e21-46f5-858f-0732cf2e33d5 Ancestors: Kernel-nice.1291 Assuming that patched VM will produce ASCII control characters (code 1 to 26) again when pressing ctrl+letter, revert some of the recent keyboard event mapping changes (See https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460). Those recent changes have unexpected consequences and implications that we might better postpone post release. We should never have to say that, but it's easier to fix the VM than the image in this case ;) One example of consequences is that cmd+7 is captured by DockingBarMorph as menu #7 rather than passed to theTextEditor if Preferences duplicateAllControlAndAltKeys. I guess that we have this preference enabled to make windows user experience not to werid wrt native feel (ctrl+key is the shortcut of choice)... =============== Diff against Kernel-nice.1291 =============== Item was removed: - ----- Method: EventSensor class>>installControlKeyEntryFor: (in category 'key decode table') ----- - installControlKeyEntryFor: aPrintableCharacter - - | upper lower | - self assert: (aPrintableCharacter asInteger between: 64 and: 95). - - upper := aPrintableCharacter asInteger. - lower := aPrintableCharacter asInteger bitOr: 16r20. - - "For Unix/Linux VMs as of version 201911282316, no control characters will be sent from the VM. Avoid check for #platformName because the extra mapping will not affect others anyway." - self flag: #unixOnly. - KeyDecodeTable at: { lower . 2 "ctrl" } put: { lower bitAnd: 16r9F . 2 "ctrl" }. - KeyDecodeTable at: { upper . 2 bitOr: 1 "ctrl+shift" } put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }.! Item was changed: ----- Method: EventSensor class>>installDuplicateKeyEntryFor: (in category 'key decode table') ----- installDuplicateKeyEntryFor: aPrintableCharacter + "Updates the key-decode table, which maps between pairs of {character code . modifier code}. + See the class comment for more information. + The purpose of this change is to let ctrl+key act like cmd+key (Mac) or alt+key (linux/windows). + It is especially usefull on windows VM where default feel is to use ctrl as shortcut (ctrl+C = copy, etc...). + Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert control characters to printable characters in this mapping table." - "Updates the key-decode table, which maps between pairs of {character code . modifier code}. See the class comment for more information. - Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert printable characters to control characters in this mapping table." | upper lower | upper := aPrintableCharacter asUppercase asInteger. lower := aPrintableCharacter asLowercase asInteger. + KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. + KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl + shift" } put: { upper . 8 bitOr: 1 "cmd/alt + shift" }.! - KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 2 bitOr: 8 "ctrl + cmd/alt" }. - KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl + shift" } put: { upper . (2 bitOr: 8) bitOr: 1 "ctrl + cmd/alt + shift" }. - KeyDecodeTable at: { lower . 8 "cmd/alt" } put: { lower . 8 bitOr: 2 "cmd/alt + ctrl" }. - KeyDecodeTable at: { upper . 8 bitOr: 1 "cmd/alt + shift" } put: { upper . (8 bitOr: 2) bitOr: 1 "cmd/alt + ctrl + shift" }. - - "For Unix/Linux VMs as of version 201911282316, no control characters will be sent from the VM. Avoid check for #platformName because the extra mapping will not affect others anyway." - self flag: #unixOnly. - KeyDecodeTable at: { lower . 2 "ctrl" } put: { lower . 2 bitOr: 8 "ctrl + cmd/alt" }. - KeyDecodeTable at: { upper . 2 bitOr: 1 "ctrl + shift" } put: { upper . (2 bitOr: 8) bitOr: 1 "ctrl + cmd/alt + shift" }.! Item was changed: ----- Method: EventSensor class>>installKeyDecodeTable (in category 'class initialization') ----- installKeyDecodeTable "Create a decode table that swaps or duplicates some keys if the respective preference is set." KeyDecodeTable := Dictionary new. - "In any case, ensure that control keys are mapped correctly." - self flag: #toRemove. "mt: If all VMs send the correct control keys on all platforms, we will remove this mapping." - 64 "$@" to: 95 "$_"do: [:keyCode | self installControlKeyEntryFor: keyCode asCharacter]. - Preferences swapControlAndAltKeys ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: [ :c | self installSwappedKeyEntryFor: c ] ]. Preferences duplicateAllControlAndAltKeys ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: [ :c | self installDuplicateKeyEntryFor: c ] ]. self flag: #toDeprecate. "mt: This mapping should be deprecated in the future." Preferences duplicateControlAndAltKeys ifTrue: [ self defaultCrossPlatformKeys do: [ :c | self installDuplicateKeyEntryFor: c ] ]. ! Item was changed: ----- Method: EventSensor class>>installSwappedKeyEntryFor: (in category 'key decode table') ----- installSwappedKeyEntryFor: aPrintableCharacter "Updates the key-decode table, which maps between pairs of {character code . modifier code}. See the class comment for more information. Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert printable characters to control characters in this mapping table." | upper lower | upper := aPrintableCharacter asUppercase asInteger. lower := aPrintableCharacter asLowercase asInteger. KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. KeyDecodeTable at: { lower . 8 "cmd/alt" } put: { lower bitAnd: 16r9F . 2 "ctrl" }. KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" } put: { upper . 8 bitOr: 1 "cmd/alt+shift" }. + KeyDecodeTable at: { upper . 8 bitOr: 1 "cmd/alt+shift" } put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }.! - KeyDecodeTable at: { upper . 8 bitOr: 1 "cmd/alt+shift" } put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }. - - "For Unix/Linux VMs as of version 201911282316, no control characters will be sent from the VM. Avoid check for #platformName because the extra mapping will not affect others anyway." - self flag: #unixOnly. - KeyDecodeTable at: { lower . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. - KeyDecodeTable at: { upper . 2 bitOr: 1 "ctrl+shift" } put: { upper . 8 bitOr: 1 "cmd/alt+shift" }.!

1 0

The Trunk: EToys-nice.374.mcz
by commits＠source.squeak.org 06 Jan '20

06 Jan '20

Nicolas Cellier uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-nice.374.mcz ==================== Summary ==================== Name: EToys-nice.374 Author: nice Time: 26 December 2019, 2:12:57.250336 pm UUID: f68f6c42-8a72-4123-9423-62a06eb832f5 Ancestors: EToys-nice.373 Expunge macToSqueak from Input Interpreter. There is no more macRoman encoding of (event at: 3) - aka charCode as of https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460 =============== Diff against EToys-nice.373 =============== Item was changed: ----- Method: CP1253InputInterpreter>>nextCharFrom:firstEvt: (in category 'as yet unclassified') ----- nextCharFrom: sensor firstEvt: evtBuf | keyValue | keyValue := evtBuf third. + ^ converter toSqueak: keyValue asCharacter. - ^ converter toSqueak: keyValue asCharacter macToSqueak. !

1 0

← Newer
1
...
16
17
18
19
20
21
22
23
Older →

Jump to page: