Squeak-dev December 2020

squeak-dev@lists.squeakfoundation.org

32 participants
173 discussions

The Trunk: System-mt.1203.mcz
by commits＠source.squeak.org 18 Dec '20

18 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1203.mcz ==================== Summary ==================== Name: System-mt.1203 Author: mt Time: 18 December 2020, 1:00:34.958366 pm UUID: 1aa9ec9e-b39a-934f-9f81-1503c06477e5 Ancestors: System-mt.1202 SpaceTally again. Don't forget to count the space that is reachable from pools. But only do that after analysing class instances. And don't count things via pools that have already been counted via instance variables. =============== Diff against System-mt.1202 =============== Item was changed: ----- Method: SpaceTally>>computeSpaceUsage (in category 'class analysis') ----- computeSpaceUsage results do: [ :entry | + | class instanceSpaceAndCount seenObjects poolSpace | - | class instanceSpaceAndCount | class := self class environment at: entry analyzedClassName. Smalltalk garbageCollectMost. + seenObjects := self depth > 0 ifTrue: [IdentitySet new]. + instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth seen: seenObjects. + poolSpace := self spaceForPoolsOf: class depth: self depth seen: seenObjects. - instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth. entry codeSize: class spaceUsed; instanceCount: instanceSpaceAndCount second; spaceForInstances: instanceSpaceAndCount first; + spaceForPools: poolSpace first; depthOfSpace: self depth ] displayingProgress: 'Taking statistics...'! Item was added: + ----- Method: SpaceTally>>spaceForPoolsOf: (in category 'class analysis') ----- + spaceForPoolsOf: aClass + + ^ self spaceForPoolsOf: aClass depth: self depth! Item was added: + ----- Method: SpaceTally>>spaceForPoolsOf:depth: (in category 'class analysis') ----- + spaceForPoolsOf: aClass depth: anInteger + + ^ self spaceForPoolsOf: aClass depth: anInteger seen: (anInteger > 0 ifTrue: [IdentitySet new])! Item was added: + ----- Method: SpaceTally>>spaceForPoolsOf:depth:seen: (in category 'class analysis') ----- + spaceForPoolsOf: aClass depth: anInteger seen: seenObjects + + | pools objects total | + pools := {aClass classPool}, aClass sharedPools. + objects := pools gather: [:pool | pool values]. + objects isEmpty ifTrue: [^#(0 0)]. + total := 0. + objects do: [:each | total := total + (self spaceForInstance: each depth: anInteger seen: seenObjects)]. + ^{ total. objects size }! Item was changed: Object subclass: #SpaceTallyItem + instanceVariableNames: 'analyzedClassName codeSize instanceCount spaceForInstances spaceForPools depthOfSpace' - instanceVariableNames: 'analyzedClassName codeSize instanceCount spaceForInstances depthOfSpace' classVariableNames: '' poolDictionaries: '' category: 'System-Tools'! !SpaceTallyItem commentStamp: 'sd 6/20/2003 22:02' prior: 0! I'm represent an entry in the spaceTally.! Item was changed: ----- Method: SpaceTallyItem>>printOn: (in category 'printing') ----- printOn: aStream analyzedClassName ifNotNil: [ aStream nextPutAll: analyzedClassName asString]. aStream nextPutAll: ' ('. codeSize ifNotNil: [ aStream nextPutAll: 'code size: ' ; nextPutAll: codeSize asString]. instanceCount ifNotNil: [ aStream nextPutAll: ' instance count: ' ; nextPutAll: instanceCount asString]. spaceForInstances ifNotNil: [ aStream nextPutAll: ' space for instances: ' ; nextPutAll: spaceForInstances asBytesDescription]. + spaceForPools + ifNotNil: [ aStream nextPutAll: ' extra for pools: ' ; nextPutAll: spaceForPools asBytesDescription]. depthOfSpace ifNotNil: [ aStream nextPutAll: ' depth of space: ' ; nextPutAll: depthOfSpace asString]. aStream nextPut: $). ! Item was added: + ----- Method: SpaceTallyItem>>spaceForPools (in category 'accessing') ----- + spaceForPools + + ^ spaceForPools! Item was added: + ----- Method: SpaceTallyItem>>spaceForPools: (in category 'accessing') ----- + spaceForPools: aNumber + + spaceForPools := aNumber!

1 0

The Trunk: System-mt.1202.mcz
by commits＠source.squeak.org 18 Dec '20

18 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1202.mcz ==================== Summary ==================== Name: System-mt.1202 Author: mt Time: 18 December 2020, 10:11:47.76906 am UUID: 29ceed8f-1bbf-fa4f-89ee-8e8aaabe25ba Ancestors: System-dtl.1201 Fixes logging output of DoItFirst for cases where stdio streams are unavailable such as on Windows via Squeak.exe (instead of SqueakConsole.exe). =============== Diff against System-dtl.1201 =============== Item was removed: - ----- Method: DoItFirst>>print:to: (in category 'private') ----- - print: aString to: stream - [ stream nextPutAll: aString; lf; flush ] - on: Error - do: [ Transcript cr; show: self class name , ' output: ', aString; flush. - ^false ]. - ^true. - ! Item was changed: ----- Method: DoItFirst>>printError: (in category 'private') ----- printError: aString "Print to stdout if available, otherwise to the transcript. Answer true if the stdio stream was used, false if output was redirected to transcript." + [ FileStream stderr nextPutAll: aString; lf; flush ] + on: Error + do: [ TranscriptStream forceUpdate: false. "Graphics not yet fully initialized." + Transcript cr; show: self class name , ' error: ', aString; flush. + ^false ]. + ^true. - ^self print: aString to: FileStream stderr. ! Item was changed: ----- Method: DoItFirst>>printOut: (in category 'private') ----- printOut: aString "Print to stdout if available, otherwise to the transcript. Answer true if the stdio stream was used, false if output was redirected to transcript." + [ FileStream stdout nextPutAll: aString; lf; flush ] + on: Error + do: [ TranscriptStream forceUpdate: false. "Graphics not yet fully initialized." + Transcript cr; show: self class name , ' output: ', aString; flush. + ^false ]. + ^true. - ^self print: aString to: FileStream stdout. !

1 0

The Inbox: System-dtl.1197.mcz
by commits＠source.squeak.org 18 Dec '20

18 Dec '20

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-dtl.1197.mcz ==================== Summary ==================== Name: System-dtl.1197 Author: dtl Time: 12 December 2020, 11:39:02.946469 pm UUID: 98a9eb0b-d360-473f-a718-f1f7ae883ac7 Ancestors: System-mt.1196 Enable removal of preference for 'Read document at startup'. Simplify code such that #readDocumentAtStartup is assumed always true and document specifiers begining with '-' are not treated as start documents. The actual preference setting is no longer referenced. Assumptions: if the start document resource name starts with '-' then it is unlikely to be a document. For the case of the first argument appearing to be a document but the user wishing to use it otherwise, the '--' token (or any other argument beginning with '-') may be used in the command line to protect the argument from evaluation. This allows the traditional start document processing to work normally in the general case, and allows start document processing to be bypassed from the command line if desired. No preference setting is required. The #readDocumentAtStartup may be removed in a future update. =============== Diff against System-mt.1196 =============== Item was changed: ----- Method: ProjectLauncher>>startUpAfterLogin (in category 'running') ----- startUpAfterLogin | scriptName loader isUrl | self setupFlaps. + Smalltalk firstArgMightBeDocument + ifTrue: [scriptName := Smalltalk documentPath. - Preferences readDocumentAtStartup - ifTrue: [scriptName := Smalltalk documentPath - ifNil: ['']. scriptName := scriptName convertFromSystemString. scriptName isEmpty ifFalse: ["figure out if script name is a URL by itself" isUrl := (scriptName asLowercase beginsWith: 'http://') or: [(scriptName asLowercase beginsWith: 'file://') or: [scriptName asLowercase beginsWith: 'ftp://']]. isUrl ifFalse: [| encodedPath pathTokens | "Allow for ../dir/scriptName arguments" pathTokens := scriptName splitBy: FileDirectory slash. pathTokens := pathTokens collect: [:s | s encodeForHTTP]. encodedPath := pathTokens reduce: [:acc :each | acc , FileDirectory slash , each]. scriptName := (FileDirectory default uri resolveRelativeURI: encodedPath) asString]]] ifFalse: [scriptName := '']. scriptName isEmptyOrNil ifTrue: [^ Preferences eToyFriendly ifTrue: [self currentWorld addGlobalFlaps]]. loader := CodeLoader new. loader loadSourceFiles: (Array with: scriptName). (scriptName asLowercase endsWith: '.pr') ifTrue: [self installProjectFrom: loader] ifFalse: [loader installSourceFiles]! Item was changed: ----- Method: SmalltalkImage>>arguments (in category 'command line') ----- arguments "Answer an array with all the command line arguments. + This does not include imagePath, documentPath nor any option. + The '--' token on the command line indicates that remaining arguments should + be passed to the image without interpretation, and should not be treated as e.g. + specification of a start script." + - This does not include imagePath, documentPath nor any option." - "Smalltalk commandLine arguments" + | args | - | args strm | args := self rawArguments. + (args includes: '--' ) + ifTrue: [ ^ args copyAfter: '--' ] + ifFalse: [ | rs | rs := args readStream. + rs next. "skip image name" + self firstArgMightBeDocument + ifTrue: [rs next "skip startup document name"]. + ^ rs upToEnd ]. - (args includes: '--') - ifTrue: [ ^args copyAfter: self imageArgumentsMarker ]. - strm := args readStream. - strm atEnd ifFalse: [ strm next. "skip image name" - (Preferences readDocumentAtStartup and: [ strm atEnd not ]) - ifTrue: [ strm next "skip startup document name" ]]. - ^ strm upToEnd. ! Item was changed: ----- Method: SmalltalkImage>>documentPath (in category 'command line') ----- documentPath "Answer the absolute path of the document passed to the VM or nil if none." "Smalltalk commandLine documentPath" + ^ (self getSystemAttribute: 2) ifNil: [ '' ] - ^ (self getSystemAttribute: 2) - ifNotNil: [ :arg | arg = self imageArgumentsMarker - ifTrue: [nil] ifFalse: [arg]]. - ! Item was added: + ----- Method: SmalltalkImage>>firstArgMightBeDocument (in category 'private') ----- + firstArgMightBeDocument + "If the first argument begins with '-' then it is unlikely to be a document specification" + ^ (self documentPath beginsWith: '-') not + ! Item was removed: - ----- Method: SmalltalkImage>>imageArgumentsMarker (in category 'command line') ----- - imageArgumentsMarker - "The '--' token on the command line indicates that remaining arguments should - be passed to the image without interpretation, and should not be treated as e.g. - specification of a start script." - - ^ '--'!

3 3

"Move to" is somehow broken in SqueakSource's Web Interface
by Marcel Taeumel 17 Dec '20

17 Dec '20

Hi all! Inbox commits keep on reappearing even after moved to Trunk: http://forum.world.st/The-Inbox-Kernel-ct-1300-mcz-tp5111778.html [http://forum.world.st/The-Inbox-Kernel-ct-1300-mcz-tp5111778.html] http://forum.world.st/The-Trunk-Kernel-ct-1300-mcz-tp5112828.html [http://forum.world.st/The-Trunk-Kernel-ct-1300-mcz-tp5112828.html] http://forum.world.st/The-Trunk-Kernel-ct-1300-mcz-tp5124375.html [http://forum.world.st/The-Trunk-Kernel-ct-1300-mcz-tp5124375.html] First moved on March 03, then again on November 04, it is now back in the Inbox again. -.-" Who has access to SqueakSource and can take a look at it? Best, Marcel

3 4

The Trunk: System-mt.1200.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1200.mcz ==================== Summary ==================== Name: System-mt.1200 Author: mt Time: 17 December 2020, 6:27:01.501895 pm UUID: 0ff20c8c-9b07-c546-a2fe-c8310bc4c019 Ancestors: System-mt.1199 One more tweak for SpaceTally: It does not make sense to reuse the set of seen objects when enumerating the classes. Only reuse a set when enumerating each class' instances. Now the order of classes provided for #spaceTally: does not matter anymore. =============== Diff against System-mt.1199 =============== Item was changed: ----- Method: SpaceTally>>computeSpaceUsage (in category 'class analysis') ----- computeSpaceUsage - | seenObjects | - seenObjects := self depth > 0 ifTrue: [IdentitySet new]. results do: [ :entry | | class instanceSpaceAndCount | class := self class environment at: entry analyzedClassName. Smalltalk garbageCollectMost. + instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth. - instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth seen: seenObjects. entry codeSize: class spaceUsed; instanceCount: instanceSpaceAndCount second; spaceForInstances: instanceSpaceAndCount first; depthOfSpace: self depth ] displayingProgress: 'Taking statistics...'!

1 0

The Trunk: System-mt.1199.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1199.mcz ==================== Summary ==================== Name: System-mt.1199 Author: mt Time: 17 December 2020, 6:15:09.310895 pm UUID: 00f96e57-9bc5-d044-bcb7-2dd90b55507b Ancestors: System-mt.1198 Fixes SpaceTally. Only enumerate objects in variable classes, not bytes or words. Thus, avoid to create LargePositiveIntegers while counting. =============== Diff against System-mt.1198 =============== Item was changed: Object subclass: #SpaceTally instanceVariableNames: 'results depth' classVariableNames: '' poolDictionaries: '' category: 'System-Tools'! !SpaceTally commentStamp: '<historical>' prior: 0! I'm responsible to help getting information about system space usage. The information I compute is represented by a spaceTallyItem. Here are some examples to inspect: SpaceTally new spaceTally: (Array with: TextMorph with: Point). SpaceTally new systemWideSpaceTally. SpaceTally new depth: 2; spaceTally: (PackageInfo named: #Morphic) classes. SpaceTally new depth: 1; spaceTally: (PackageInfo named: #Monticello) classes. "Includes cached source code" + SpaceTally new spaceForInstancesOf: Form depth: 1. "Includes footprint for bitmaps"! - SpaceTally new spaceForInstancesOf: Form depth: 2. "Includes bitmaps and large integers"! Item was changed: ----- Method: SpaceTally>>spaceForInstance:depth:seen: (in category 'instance size') ----- spaceForInstance: anObject depth: anInteger seen: seenObjectsOrNil | ctxt class basicSize depth total | seenObjectsOrNil ifNotNil: [ (seenObjectsOrNil ifAbsentAdd: anObject) ifFalse: [^ 0]]. ctxt := thisContext. class := ctxt objectClass: anObject. basicSize := 0. total := class isVariable ifTrue: [class byteSizeOfInstanceOfSize: (basicSize := ctxt objectSize: anObject)] ifFalse: [class isImmediateClass ifTrue: [0] ifFalse: [class byteSizeOfInstance]]. (depth := anInteger - 1) >= 0 ifTrue: [ anObject isCompiledCode ifTrue: [ anObject literalsDo: [:literal | total := total + (self spaceForInstance: literal depth: depth seen: seenObjectsOrNil)]] ifFalse: [ + (class instSpec between: 2 and: 4) ifTrue: [ "only indexable objects, no bytes etc." + 1 to: basicSize do: [:index | + total := total + (self spaceForInstance: (ctxt object: anObject basicAt: index) depth: depth seen: seenObjectsOrNil)]]. - 1 to: basicSize do: [:index | - total := total + (self spaceForInstance: (ctxt object: anObject basicAt: index) depth: depth seen: seenObjectsOrNil)]. 1 to: class instSize do: [:index | total := total + (self spaceForInstance: (ctxt object: anObject instVarAt: index) depth: depth seen: seenObjectsOrNil)]]]. ^ total! Item was changed: ----- Method: SpaceTally>>spaceForInstancesOf:depth:seen: (in category 'instance size') ----- spaceForInstancesOf: aClass depth: anInteger seen: seenObjects "Answer a pair of the number of bytes consumed by all instances of the given class, including their object headers, and the number of instances. Follow each instance's fields up to the given depth. Beware of cycles to shared objects, which will tamper the resulting numbers. SpaceTally new spaceForInstancesOf: Form depth: 0. --- Same as #spaceForInstancesOf: SpaceTally new spaceForInstancesOf: Form depth: 1. --- Includes memory footprint for bits etc. - SpaceTally new spaceForInstancesOf: Form depth: 2. --- Also includes LargePositiveIntegers in bitmaps ;-) " | instances total | instances := aClass allInstances. instances isEmpty ifTrue: [^#(0 0)]. total := 0. instances do: [:each | total := total + (self spaceForInstance: each depth: anInteger seen: seenObjects)]. ^{ total. instances size }!

1 0

The Trunk: System-mt.1198.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1198.mcz ==================== Summary ==================== Name: System-mt.1198 Author: mt Time: 17 December 2020, 5:04:11.447084 pm UUID: 0e532d14-69bc-3e4f-9e1b-67f880aa3001 Ancestors: System-pre.1197, System-mt.1175 Refines System-mt.1175, which adds a way to compute a space tally for objects up to a certain depth. Updates class comment to provide more examples. (See http://forum.world.st/The-Inbox-System-mt-1175-mcz-tp5122678.html) =============== Diff against System-pre.1197 =============== Item was changed: Object subclass: #SpaceTally + instanceVariableNames: 'results depth' - instanceVariableNames: 'results' classVariableNames: '' poolDictionaries: '' category: 'System-Tools'! + !SpaceTally commentStamp: '<historical>' prior: 0! + I'm responsible to help getting information about system space usage. The information I compute is represented by a spaceTallyItem. - !SpaceTally commentStamp: 'sd 6/20/2003 22:31' prior: 0! - I'm responsible to help getting information about system space usage. The information I compute is represented by a spaceTallyItem + Here are some examples to inspect: + SpaceTally new spaceTally: (Array with: TextMorph with: Point). + SpaceTally new systemWideSpaceTally. + SpaceTally new depth: 2; spaceTally: (PackageInfo named: #Morphic) classes. + SpaceTally new depth: 1; spaceTally: (PackageInfo named: #Monticello) classes. "Includes cached source code" + SpaceTally new spaceForInstancesOf: Form depth: 2. "Includes bitmaps and large integers"! - try something like: - - ((SpaceTally new spaceTally: (Array with: TextMorph with: Point)) - asSortedCollection: [:a :b | a spaceForInstances > b spaceForInstances]) - - SpaceTally new systemWideSpaceTally - - - This class has been created from a part of SystemDictionary. It still deserves a nice - clean, such as using object instead of array having 4 slots. - - sd-20 June 2003! Item was changed: ----- Method: SpaceTally>>computeSpaceUsage (in category 'class analysis') ----- computeSpaceUsage + | seenObjects | + seenObjects := self depth > 0 ifTrue: [IdentitySet new]. results do: [ :entry | | class instanceSpaceAndCount | class := self class environment at: entry analyzedClassName. Smalltalk garbageCollectMost. + instanceSpaceAndCount := self spaceForInstancesOf: class depth: self depth seen: seenObjects. - instanceSpaceAndCount := self spaceForInstancesOf: class. entry codeSize: class spaceUsed; instanceCount: instanceSpaceAndCount second; + spaceForInstances: instanceSpaceAndCount first; + depthOfSpace: self depth ] - spaceForInstances: instanceSpaceAndCount first ] displayingProgress: 'Taking statistics...'! Item was added: + ----- Method: SpaceTally>>depth (in category 'accessing') ----- + depth + + ^ depth ifNil: [0]! Item was added: + ----- Method: SpaceTally>>depth: (in category 'accessing') ----- + depth: anInteger + + depth := anInteger.! Item was added: + ----- Method: SpaceTally>>spaceForInstance: (in category 'instance size') ----- + spaceForInstance: anObject + + ^ self spaceForInstance: anObject depth: self depth! Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger + + ^ self spaceForInstance: anObject depth: anInteger seen: (anInteger > 0 ifTrue: [IdentitySet new])! Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth:seen: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger seen: seenObjectsOrNil + + | ctxt class basicSize depth total | + seenObjectsOrNil ifNotNil: [ + (seenObjectsOrNil ifAbsentAdd: anObject) ifFalse: [^ 0]]. + ctxt := thisContext. + class := ctxt objectClass: anObject. + basicSize := 0. + total := class isVariable + ifTrue: [class byteSizeOfInstanceOfSize: (basicSize := ctxt objectSize: anObject)] + ifFalse: [class isImmediateClass ifTrue: [0] ifFalse: [class byteSizeOfInstance]]. + (depth := anInteger - 1) >= 0 ifTrue: [ + anObject isCompiledCode + ifTrue: [ + anObject literalsDo: [:literal | + total := total + (self spaceForInstance: literal depth: depth seen: seenObjectsOrNil)]] + ifFalse: [ + 1 to: basicSize do: [:index | + total := total + (self spaceForInstance: (ctxt object: anObject basicAt: index) depth: depth seen: seenObjectsOrNil)]. + 1 to: class instSize do: [:index | + total := total + (self spaceForInstance: (ctxt object: anObject instVarAt: index) depth: depth seen: seenObjectsOrNil)]]]. + ^ total! Item was changed: ----- Method: SpaceTally>>spaceForInstancesOf: (in category 'instance size') ----- spaceForInstancesOf: aClass - "Answer a pair of the number of bytes consumed by all instances of the - given class, including their object headers, and the number of instances." + ^ self spaceForInstancesOf: aClass depth: self depth! - | instances total | - instances := aClass allInstances. - instances isEmpty ifTrue: [^#(0 0)]. - total := 0. - aClass isVariable - ifTrue: - [instances do: - [:i| total := total + (aClass byteSizeOfInstanceOfSize: i basicSize)]] - ifFalse: - [total := instances size * aClass byteSizeOfInstance]. - ^{ total. instances size }! Item was added: + ----- Method: SpaceTally>>spaceForInstancesOf:depth: (in category 'instance size') ----- + spaceForInstancesOf: aClass depth: anInteger + + ^ self spaceForInstancesOf: aClass depth: anInteger seen: (anInteger > 0 ifTrue: [IdentitySet new])! Item was added: + ----- Method: SpaceTally>>spaceForInstancesOf:depth:seen: (in category 'instance size') ----- + spaceForInstancesOf: aClass depth: anInteger seen: seenObjects + "Answer a pair of the number of bytes consumed by all instances of the given class, including their object headers, and the number of instances. Follow each instance's fields up to the given depth. Beware of cycles to shared objects, which will tamper the resulting numbers. + + SpaceTally new spaceForInstancesOf: Form depth: 0. --- Same as #spaceForInstancesOf: + SpaceTally new spaceForInstancesOf: Form depth: 1. --- Includes memory footprint for bits etc. + SpaceTally new spaceForInstancesOf: Form depth: 2. --- Also includes LargePositiveIntegers in bitmaps ;-) + " + + | instances total | + instances := aClass allInstances. + instances isEmpty ifTrue: [^#(0 0)]. + total := 0. + instances do: [:each | total := total + (self spaceForInstance: each depth: anInteger seen: seenObjects)]. + ^{ total. instances size }! Item was changed: Object subclass: #SpaceTallyItem + instanceVariableNames: 'analyzedClassName codeSize instanceCount spaceForInstances depthOfSpace' - instanceVariableNames: 'analyzedClassName codeSize instanceCount spaceForInstances' classVariableNames: '' poolDictionaries: '' category: 'System-Tools'! !SpaceTallyItem commentStamp: 'sd 6/20/2003 22:02' prior: 0! I'm represent an entry in the spaceTally.! Item was added: + ----- Method: SpaceTallyItem>>depthOfSpace (in category 'accessing') ----- + depthOfSpace + + ^ depthOfSpace! Item was added: + ----- Method: SpaceTallyItem>>depthOfSpace: (in category 'accessing') ----- + depthOfSpace: aNumber + + depthOfSpace := aNumber! Item was changed: ----- Method: SpaceTallyItem>>printOn: (in category 'printing') ----- printOn: aStream analyzedClassName ifNotNil: [ aStream nextPutAll: analyzedClassName asString]. aStream nextPutAll: ' ('. codeSize ifNotNil: [ aStream nextPutAll: 'code size: ' ; nextPutAll: codeSize asString]. instanceCount ifNotNil: [ aStream nextPutAll: ' instance count: ' ; nextPutAll: instanceCount asString]. spaceForInstances ifNotNil: [ aStream nextPutAll: ' space for instances: ' ; nextPutAll: spaceForInstances asBytesDescription]. + depthOfSpace + ifNotNil: [ aStream nextPutAll: ' depth of space: ' ; nextPutAll: depthOfSpace asString]. aStream nextPut: $). !

2 2

The Inbox: System-mt.1175.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-mt.1175.mcz ==================== Summary ==================== Name: System-mt.1175 Author: mt Time: 29 September 2020, 1:16:45.233157 pm UUID: f0acc060-a48b-2c4f-8b56-aaf2f55601b4 Ancestors: System-topa.1174 Adds a way to compute a space tally for objects up to a certain depth. Questions: - Is the interface (i.e. "depth" and "seen") OK? - Is the use of IdentitySet OK? - Can we speed this up somehow? - Do we need depth-messages for the "class analysis" protocol, too? =============== Diff against System-topa.1174 =============== Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger + + ^ self spaceForInstance: anObject depth: anInteger seen: IdentitySet new! Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth:seen: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger seen: someObjects + + | class depth total | + (someObjects includes: anObject) ifTrue: [^ 0]. + someObjects add: anObject. + class := anObject class. + depth := anInteger - 1. + total := class isVariable + ifTrue: [class byteSizeOfInstanceOfSize: anObject basicSize] + ifFalse: [class isImmediateClass ifTrue: [0] ifFalse: [class byteSizeOfInstance]]. + depth >= 0 ifTrue: [ + anObject isCompiledCode + ifTrue: [ + anObject literalsDo: [:literal | + total := total + (self spaceForInstance: literal depth: depth seen: someObjects)]] + ifFalse: [ + 1 to: anObject basicSize do: [:index | + total := total + (self spaceForInstance: (anObject basicAt: index) depth: depth seen: someObjects)]. + 1 to: class instSize do: [:index | + total := total + (self spaceForInstance: (anObject instVarAt: index) depth: depth seen: someObjects)]]]. + ^ total! Item was added: + ----- Method: SpaceTally>>spaceForInstancesOf:depth: (in category 'instance size') ----- + spaceForInstancesOf: aClass depth: aNumber + "Answer a pair of the number of bytes consumed by all instances of the given class, including their object headers, and the number of instances. Follow each instance's fields up to the given depth. Beware of cycles to shared objects, which will tamper the resulting numbers. + + SpaceTally new spaceForInstancesOf: Form depth: 0. --- Same as #spaceForInstanecsOf: + SpaceTally new spaceForInstancesOf: Form depth: 1. --- Includes memory footprint for bits etc. + SpaceTally new spaceForInstancesOf: Form depth: 2. --- Also includes LargePositiveIntegers in bitmaps ;-) + " + + | instances total sub depth | + instances := aClass allInstances. + instances isEmpty ifTrue: [^#(0 0)]. + total := 0. + instances do: [:each | total := total + (self spaceForInstance: each depth: aNumber)]. + ^{ total. instances size }!

5 4

The Trunk: System-mt.1175.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1175.mcz ==================== Summary ==================== Name: System-mt.1175 Author: mt Time: 29 September 2020, 1:16:45.233157 pm UUID: f0acc060-a48b-2c4f-8b56-aaf2f55601b4 Ancestors: System-topa.1174 Adds a way to compute a space tally for objects up to a certain depth. Questions: - Is the interface (i.e. "depth" and "seen") OK? - Is the use of IdentitySet OK? - Can we speed this up somehow? - Do we need depth-messages for the "class analysis" protocol, too? =============== Diff against System-topa.1174 =============== Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger + + ^ self spaceForInstance: anObject depth: anInteger seen: IdentitySet new! Item was added: + ----- Method: SpaceTally>>spaceForInstance:depth:seen: (in category 'instance size') ----- + spaceForInstance: anObject depth: anInteger seen: someObjects + + | class depth total | + (someObjects includes: anObject) ifTrue: [^ 0]. + someObjects add: anObject. + class := anObject class. + depth := anInteger - 1. + total := class isVariable + ifTrue: [class byteSizeOfInstanceOfSize: anObject basicSize] + ifFalse: [class isImmediateClass ifTrue: [0] ifFalse: [class byteSizeOfInstance]]. + depth >= 0 ifTrue: [ + anObject isCompiledCode + ifTrue: [ + anObject literalsDo: [:literal | + total := total + (self spaceForInstance: literal depth: depth seen: someObjects)]] + ifFalse: [ + 1 to: anObject basicSize do: [:index | + total := total + (self spaceForInstance: (anObject basicAt: index) depth: depth seen: someObjects)]. + 1 to: class instSize do: [:index | + total := total + (self spaceForInstance: (anObject instVarAt: index) depth: depth seen: someObjects)]]]. + ^ total! Item was added: + ----- Method: SpaceTally>>spaceForInstancesOf:depth: (in category 'instance size') ----- + spaceForInstancesOf: aClass depth: aNumber + "Answer a pair of the number of bytes consumed by all instances of the given class, including their object headers, and the number of instances. Follow each instance's fields up to the given depth. Beware of cycles to shared objects, which will tamper the resulting numbers. + + SpaceTally new spaceForInstancesOf: Form depth: 0. --- Same as #spaceForInstanecsOf: + SpaceTally new spaceForInstancesOf: Form depth: 1. --- Includes memory footprint for bits etc. + SpaceTally new spaceForInstancesOf: Form depth: 2. --- Also includes LargePositiveIntegers in bitmaps ;-) + " + + | instances total sub depth | + instances := aClass allInstances. + instances isEmpty ifTrue: [^#(0 0)]. + total := 0. + instances do: [:each | total := total + (self spaceForInstance: each depth: aNumber)]. + ^{ total. instances size }!

1 0

The Inbox: Collections-nice.869.mcz
by commits＠source.squeak.org 17 Dec '20

17 Dec '20

Nicolas Cellier uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-nice.869.mcz ==================== Summary ==================== Name: Collections-nice.869 Author: nice Time: 31 December 2019, 11:14:43.388306 pm UUID: e5a9bef5-16d3-4d8a-bf08-040d30e4e907 Ancestors: Collections-nice.868 Remaster Collections-nice.464: opimize RunArray This should not be noticeable for Text, but as a general library, it's important for any other potential use. Among those optimizations, notice one important change: some of the enumerating methods like #collect: won't iterate on each element, but only once per run. Be aware that providing blocks with side effects like (i := i + 1) might lead to different behavior than ordinary ArrayedCollection. Move RunArray off ArrayedCollection which serves nothing to such subclass. Add the ability to remove: since it already has the hability to addFirst: and addLast: Fix a few missing lastIndex cache flush, and advertise about the necessity to do it in class comment. Deprecate mapValues: to the profit of replace:. =============== Diff against Collections-nice.868 =============== Item was changed: + SequenceableCollection subclass: #RunArray - ArrayedCollection subclass: #RunArray instanceVariableNames: 'runs values lastIndex lastRun lastOffset' classVariableNames: '' poolDictionaries: '' category: 'Collections-Arrayed'! + !RunArray commentStamp: 'nice 12/30/2019 00:57' prior: 0! - !RunArray commentStamp: '<historical>' prior: 0! My instances provide space-efficient storage of data which tends to be constant over long runs of the possible indices. Essentially repeated values are stored singly and then associated with a "run" length that denotes the number of consecutive occurrences of the value. My two important variables are runs An array of how many elements are in each run values An array of what the value is over those elements The variables lastIndex, lastRun and lastOffset cache the last access so that streaming through RunArrays is not an N-squared process. + Beware: methods modifying the RunArray contents should reset the lastIndex cache to nil. Many complexities of access can be bypassed by using the method RunArray withStartStopAndValueDo:! Item was changed: ----- Method: RunArray class>>newFrom: (in category 'instance creation') ----- newFrom: aCollection "Answer an instance of me containing the same elements as aCollection." | newCollection | newCollection := self new. + newCollection fillFrom: aCollection with: [:each | each]. - aCollection do: [:x | newCollection addLast: x]. ^newCollection " RunArray newFrom: {1. 2. 2. 3} {1. $a. $a. 3} as: RunArray ({1. $a. $a. 3} as: RunArray) values "! Item was added: + ----- Method: RunArray>>allSatisfy: (in category 'enumerating') ----- + allSatisfy: aBlock + "Only evaluate once per run" + + ^values allSatisfy: aBlock! Item was added: + ----- Method: RunArray>>anySatisfy: (in category 'enumerating') ----- + anySatisfy: aBlock + "Only evaluate once per run" + + ^values anySatisfy: aBlock! Item was added: + ----- Method: RunArray>>asBag (in category 'converting') ----- + asBag + | aBag | + aBag := Bag new: values size. + self runsAndValuesDo: [:run :value | + aBag add: value withOccurrences: run]. + ^aBag! Item was added: + ----- Method: RunArray>>asSet (in category 'converting') ----- + asSet + ^values asSet! Item was changed: + ----- Method: RunArray>>coalesce (in category 'private') ----- - ----- Method: RunArray>>coalesce (in category 'adding') ----- coalesce + "Coalesce theRuns and theValues if ever the values have adjacent equal objects" + + | lastLength lastValue mustCoalesce coalescedRuns coalescedValued runIndex | + mustCoalesce := false. + runIndex := 0. + lastLength := 0. + lastValue := Object new. + runs with: values do: [:run :value | + (lastValue = value or: [run = 0]) + ifTrue: + [mustCoalesce + ifFalse: + [coalescedRuns := (Array new: runs size) writeStream. + coalescedValued := (Array new: values size) writeStream. + coalescedRuns next: runIndex putAll: runs startingAt: 1. + coalescedValued next: runIndex putAll: values startingAt: 1. + mustCoalesce := true]. + lastLength := lastLength + run] + ifFalse: + [lastLength > 0 + ifTrue: + [mustCoalesce + ifTrue: + [coalescedRuns nextPut: lastLength. + coalescedValued nextPut: lastValue]. + runIndex := runIndex + 1]. + lastLength := run. + lastValue := value]]. + mustCoalesce + ifTrue: + [lastLength > 0 + ifTrue: + [coalescedRuns nextPut: lastLength. + coalescedValued nextPut: lastValue]. + self setRuns: coalescedRuns contents setValues: coalescedValued contents]! - "Try to combine adjacent runs" - | ind | - ind := 2. - [ind > values size] whileFalse: [ - (values at: ind-1) = (values at: ind) - ifFalse: [ind := ind + 1] - ifTrue: ["two are the same, combine them" - values := values copyReplaceFrom: ind to: ind with: #(). - runs at: ind-1 put: (runs at: ind-1) + (runs at: ind). - runs := runs copyReplaceFrom: ind to: ind with: #(). - "self error: 'needed to combine runs' "]]. - ! Item was added: + ----- Method: RunArray>>collect: (in category 'enumerating') ----- + collect: aBlock + "Beware, the block will be evaluated only once per group of values." + ^(self class runs: runs copy values: (values collect: aBlock)) coalesce! Item was added: + ----- Method: RunArray>>copyUpThrough: (in category 'copying') ----- + copyUpThrough: value + "Optimized" + + | newSize newValues newRuns | + newSize := values indexOf: value startingAt: 1. + newSize = 0 ifTrue: [^self copy]. + newRuns := runs copyFrom: 1 to: newSize. + newRuns at: newSize put: 1. + newValues := values copyFrom: 1 to: newSize. + ^ self class + runs: newRuns + values: newValues! Item was added: + ----- Method: RunArray>>copyUpTo: (in category 'copying') ----- + copyUpTo: anElement + "Optimized" + + | newValues | + newValues := values copyUpTo: anElement. + ^ self class + runs: (runs copyFrom: 1 to: newValues size) + values: newValues! Item was added: + ----- Method: RunArray>>copyUpToLast: (in category 'copying') ----- + copyUpToLast: value + "Optimized" + + | newSize run newRuns newValues | + newSize := values lastIndexOf: value startingAt: values size. + newSize = 0 ifTrue: [^self copy]. + run := runs at: newSize. + run > 1 + ifTrue: + [newRuns := runs copyFrom: 1 to: newSize. + newRuns at: newSize put: run - 1] + ifFalse: + [newSize := newSize - 1. + newRuns := runs copyFrom: 1 to: newSize]. + newValues := values copyFrom: 1 to: newSize. + ^ self class + runs: newRuns + values: newValues! Item was added: + ----- Method: RunArray>>count: (in category 'enumerating') ----- + count: aBlock + "Beware, the block will be evaluated only once per group of values." + | count | + count := 0. + self runsAndValuesDo: [:run :value | + (aBlock value: value) + ifTrue: + [count := count + run]]. + ^count! Item was added: + ----- Method: RunArray>>detect:ifNone: (in category 'enumerating') ----- + detect: aBlock ifNone: exceptionBlock + "Only evaluate once per run" + + ^values detect: aBlock ifNone: exceptionBlock ! Item was added: + ----- Method: RunArray>>detectMax: (in category 'enumerating') ----- + detectMax: aBlock + "Only evaluate once per run" + + ^values detectMax: aBlock! Item was added: + ----- Method: RunArray>>detectMin: (in category 'enumerating') ----- + detectMin: aBlock + "Only evaluate once per run" + + ^values detectMin: aBlock! Item was added: + ----- Method: RunArray>>detectSum: (in category 'enumerating') ----- + detectSum: aBlock + "Only loop on runs" + | sum | + sum := 0. + self runsAndValuesDo: [:run :value | + sum := (aBlock value: value) * run + sum]. + ^ sum! Item was added: + ----- Method: RunArray>>do: (in category 'enumerating') ----- + do: aBlock + "This is refined for speed" + + 1 to: runs size do: [:i | + | r v | + v := values at: i. + r := runs at: i. + [( r := r - 1) >= 0] + whileTrue: [aBlock value: v]].! Item was added: + ----- Method: RunArray>>fillFrom:with: (in category 'private') ----- + fillFrom: aCollection with: aBlock + "Evaluate aBlock with each of aCollections's elements as the argument. + Collect the resulting values into self. Answer self." + + | newRuns newValues lastLength lastValue | + newRuns := (Array new: aCollection size) writeStream. + newValues := (Array new: aCollection size) writeStream. + lastLength := 0. + lastValue := Object new. + lastIndex := nil. "flush access cache" + aCollection do: [:each | + | value | + value := aBlock value: each. + lastValue = value + ifTrue: [lastLength := lastLength + 1] + ifFalse: + [lastLength > 0 + ifTrue: + [newRuns nextPut: lastLength. + newValues nextPut: lastValue]. + lastLength := 1. + lastValue := value]]. + lastLength > 0 + ifTrue: + [newRuns nextPut: lastLength. + newValues nextPut: lastValue]. + self setRuns: newRuns contents setValues: newValues contents! Item was added: + ----- Method: RunArray>>findFirst: (in category 'enumerating') ----- + findFirst: aBlock + | index | + index := 1. + self runsAndValuesDo: [ :run :value | + (aBlock value: value) ifTrue: [^index]. + index := index + run]. + ^0! Item was added: + ----- Method: RunArray>>findLast: (in category 'enumerating') ----- + findLast: aBlock + | index | + index := values size + 1. + [(index := index - 1) >= 1] whileTrue: + [(aBlock value: (values at: index)) ifTrue: [^(1 to: index) detectSum: [:i | runs at: i]]]. + ^0! Item was added: + ----- Method: RunArray>>includes: (in category 'testing') ----- + includes: anObject + "Answer whether anObject is one of the receiver's elements." + + ^values includes: anObject! Item was added: + ----- Method: RunArray>>indexOf:startingAt: (in category 'accessing') ----- + indexOf: anElement startingAt: start + "Answer the index of the first occurence of anElement after start + within the receiver. If the receiver does not contain anElement, + answer 0." + + | index | + index := 1. + self runsAndValuesDo: [ :run :value | + (index >= start and: [value = anElement]) ifTrue: [^index]. + index := index + run]. + ^0! Item was added: + ----- Method: RunArray>>indexOfAnyOf:startingAt: (in category 'accessing') ----- + indexOfAnyOf: aCollection startingAt: start + "Answer the index of the first occurence of any element included in aCollection after start within the receiver. + If the receiver does not contain anElement, answer zero, which is an invalid index." + + | index | + index := 1. + self runsAndValuesDo: [ :run :value | + (index >= start and: [aCollection includes: value]) ifTrue: [^index]. + index := index + run]. + ^0! Item was added: + ----- Method: RunArray>>isSorted (in category 'testing') ----- + isSorted + ^values isSorted! Item was added: + ----- Method: RunArray>>isSortedBy: (in category 'testing') ----- + isSortedBy: aBlock + ^values isSortedBy: aBlock! Item was added: + ----- Method: RunArray>>lastIndexOf:startingAt: (in category 'accessing') ----- + lastIndexOf: anElement startingAt: lastIndex + "Answer the index of the last occurence of anElement within the + receiver. If the receiver does not contain anElement, answer 0." + + | lastValueIndex | + lastValueIndex := values lastIndexOf: anElement startingAt: values size. + [lastValueIndex > 0] whileTrue: + [| i index | + i := index := 0. + [index <= lastIndex and: [(i := i + 1) <= lastValueIndex]] + whileTrue: [index := index + (runs at: i)]. + index <= lastIndex ifTrue: [^index]. + index - (runs at: lastValueIndex) < lastIndex ifTrue: [^lastIndex]. + lastValueIndex := values lastIndexOf: anElement startingAt: lastValueIndex - 1]. + ^0! Item was added: + ----- Method: RunArray>>lastIndexOfAnyOf:startingAt: (in category 'accessing') ----- + lastIndexOfAnyOf: aCollection startingAt: lastIndex + "Answer the index of the last occurence of any element of aCollection + within the receiver. If the receiver does not contain any of those + elements, answer 0" + + | lastValueIndex | + lastValueIndex := values lastIndexOfAnyOf: aCollection startingAt: values size. + [lastValueIndex > 0] whileTrue: + [| i index | + i := index := 0. + [index <= lastIndex and: [(i := i + 1) <= lastValueIndex]] + whileTrue: [index := index + (runs at: i)]. + index <= lastIndex ifTrue: [^index]. + index - (runs at: lastValueIndex) < lastIndex ifTrue: [^lastIndex]. + lastValueIndex := values lastIndexOfAnyOf: aCollection startingAt: lastValueIndex - 1]. + ^0! Item was removed: - ----- Method: RunArray>>mapValues: (in category 'private') ----- - mapValues: mapBlock - "NOTE: only meaningful to an entire set of runs" - - values := values collect: mapBlock! Item was added: + ----- Method: RunArray>>noneSatisfy: (in category 'enumerating') ----- + noneSatisfy: aBlock + "Only evaluate once per run" + + ^values noneSatisfy: aBlock! Item was changed: + ----- Method: RunArray>>rangeOf:startingAt: (in category 'accessing') ----- - ----- Method: RunArray>>rangeOf:startingAt: (in category 'adding') ----- rangeOf: attr startingAt: startPos "Answer an interval that gives the range of attr at index position startPos. An empty interval with start value startPos is returned when the attribute attr is not present at position startPos. self size > 0 is assumed, it is the responsibility of the caller to test for emptiness of self. Note that an attribute may span several adjancent runs. " self at: startPos setRunOffsetAndValue: [:run :offset :value | ^(value includes: attr) ifFalse: [startPos to: startPos - 1] ifTrue: [ | firstRelevantPosition lastRelevantPosition idxOfCandidateRun | lastRelevantPosition := startPos - offset + (runs at: run) - 1. firstRelevantPosition := startPos - offset. idxOfCandidateRun := run + 1. [idxOfCandidateRun <= runs size and: [(values at: idxOfCandidateRun) includes: attr]] whileTrue: [lastRelevantPosition := lastRelevantPosition + (runs at: idxOfCandidateRun). idxOfCandidateRun := idxOfCandidateRun + 1]. idxOfCandidateRun := run - 1. [idxOfCandidateRun >= 1 and: [(values at: idxOfCandidateRun) includes: attr]] whileTrue: [firstRelevantPosition := firstRelevantPosition - (runs at: idxOfCandidateRun). idxOfCandidateRun := idxOfCandidateRun - 1]. firstRelevantPosition to: lastRelevantPosition] ]! Item was added: + ----- Method: RunArray>>remove:ifAbsent: (in category 'removing') ----- + remove: anObject ifAbsent: exceptionBlock + | index mustCoalesce run | + lastIndex := nil. "flush access cache" + index := values indexOf: anObject ifAbsent: [^exceptionBlock value]. + (run := runs at: index) > 1 + ifTrue: [runs at: index put: run - 1] + ifFalse: + [mustCoalesce := index > 1 and: [index < values size and: [(values at: index - 1) = (values at: index + 1)]]. + runs := runs copyWithoutIndex: index. + values := values copyWithoutIndex: index. + mustCoalesce + ifTrue: + [runs at: index - 1 put: (runs at: index - 1) + (runs at: index). + runs := runs copyWithoutIndex: index. + values := values copyWithoutIndex: index]]. + ^anObject! Item was added: + ----- Method: RunArray>>removeAll (in category 'removing') ----- + removeAll + lastIndex := nil. "flush access cache" + runs := Array new. + values := Array new! Item was added: + ----- Method: RunArray>>replace: (in category 'enumerating') ----- + replace: aBlock + "destructively replace the values in this RunArray with the ones transformed by aBlock." + lastIndex := nil. "flush access cache" + values := values replace: aBlock. + self coalesce! Item was added: + ----- Method: RunArray>>reverseDo: (in category 'enumerating') ----- + reverseDo: aBlock + "This is refined for speed" + + | i | + i := runs size. + [i > 0] + whileTrue: + [ | r v | + v := values at: i. + r := runs at: i. + i := i - 1. + [( r := r - 1) >= 0] + whileTrue: [aBlock value: v]].! Item was added: + ----- Method: RunArray>>select: (in category 'enumerating') ----- + select: aBlock + "Beware, the block will be evaluated only once per group of values." + | newRuns newValues | + newRuns := (Array new: runs size) writeStream. + newValues := (Array new: values size) writeStream. + self runsAndValuesDo: [:run :value | + (aBlock value: value) + ifTrue: + [newRuns nextPut: run. + newValues nextPut: value]]. + ^(self class runs: newRuns contents values: newValues contents) coalesce! Item was changed: ----- Method: SequenceableCollection>>lastIndexOf:startingAt: (in category 'accessing') ----- lastIndexOf: anElement startingAt: lastIndex "Answer the index of the last occurence of anElement within the + receiver. If the receiver does not contain anElement, answer 0." - receiver. If the receiver does not contain anElement, answer the - result of evaluating the argument, exceptionBlock." lastIndex to: 1 by: -1 do: [ :index | (self at: index) = anElement ifTrue: [ ^index ] ]. ^0! Item was changed: ----- Method: Text>>addAttribute:from:to: (in category 'emphasis') ----- addAttribute: att from: start to: stop "Set the attribute for characters in the interval start to stop." runs := runs copyReplaceFrom: start to: stop with: ((runs copyFrom: start to: stop) + replace: - mapValues: [:attributes | Text addAttribute: att toArray: attributes]) ! Item was changed: ----- Method: Text>>removeAttribute:from:to: (in category 'emphasis') ----- removeAttribute: att from: start to: stop "Remove the attribute over the interval start to stop." runs := runs copyReplaceFrom: start to: stop with: ((runs copyFrom: start to: stop) + replace: - mapValues: [:attributes | attributes copyWithout: att]) !

6 14

← Newer
1
...
10
11
12
13
14
15
16
17
18
Older →

Jump to page: