Squeak-dev February 2020

squeak-dev@lists.squeakfoundation.org

32 participants
306 discussions

The Inbox: Morphic-ct.1634.mcz
by commits＠source.squeak.org 03 Mar '20

03 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1634.mcz ==================== Summary ==================== Name: Morphic-ct.1634 Author: ct Time: 29 February 2020, 11:46:44.317896 am UUID: 71271fa2-4ed1-6d4f-8f58-30ed8165c367 Ancestors: Morphic-mt.1631 Proposal: Add pick button to NewColorPickerMorph that allows to pick a color from the Display. With this enhancement, NCPM is finally superior to the old ColorPickerMorph and could now replace the latter by the default preferences. =============== Diff against Morphic-mt.1631 =============== Item was changed: Morph subclass: #NewColorPickerMorph + instanceVariableNames: 'target setColorSelector hsvaMorph colorPresenter isPicking' - instanceVariableNames: 'target setColorSelector hsvaMorph colorPresenter' classVariableNames: 'UseIt' poolDictionaries: '' category: 'Morphic-Widgets'! !NewColorPickerMorph commentStamp: 'cmm 12/3/2010 13:36' prior: 0! A NewColorPickerMorph is a new widget for choosing colors in Morphic. Instantiate a NewColorPickerMorph: (NewColorPickerMorph on: objectToHaveItsColorSet getColorSelector: itsColorGetterSymbol setColorSelector: itsColorSetterSymbol) openInWorld ! Item was changed: ----- Method: NewColorPickerMorph>>colorSelected: (in category 'model') ----- colorSelected: aColor + self isPicking ifFalse: [ + self targetColor: aColor]. - self targetColor: aColor. self changed: #colorExpression! Item was changed: ----- Method: NewColorPickerMorph>>initialize (in category 'initialize-release') ----- initialize + super initialize. + isPicking := false. + self initializeHsvaMorph.! - self initializeHsvaMorph! Item was added: + ----- Method: NewColorPickerMorph>>isPicking (in category 'accessing') ----- + isPicking + + ^ isPicking! Item was added: + ----- Method: NewColorPickerMorph>>isPicking: (in category 'picking') ----- + isPicking: aBoolean + + isPicking := aBoolean. + self changed: #isPicking. + aBoolean ifTrue: [self pickColor].! Item was changed: ----- Method: NewColorPickerMorph>>newBottomRow (in category 'initialize-release') ----- newBottomRow ^ Morph new + color: Color transparent; + changeTableLayout; + listDirection: #leftToRight; + hResizing: #spaceFill; vResizing: #shrinkWrap; + height: 20; + cellGap: 4; + addMorphBack: self newPickButton; + addMorphBack: (StringMorph contents: 'Current selection:' translated); + addMorphBack: self newColorPresenterMorph; + addMorphBack: self newCloseButton; + yourself! - color: Color transparent ; - changeTableLayout ; - listDirection: #leftToRight ; - hResizing: #spaceFill; vResizing: #shrinkWrap ; - height: 20 ; - cellGap: 4 ; - addMorph: (StringMorph contents: 'Current selection:' translated) ; - addMorphBack: self newColorPresenterMorph ; - addMorphBack: self newCloseButton! Item was changed: ----- Method: NewColorPickerMorph>>newCloseButton (in category 'initialize-release') ----- newCloseButton ^ (PluggableButtonMorph on: self getState: nil action: #delete label: #closeButtonLabel) + vResizing: #spaceFill; - vResizing: #spaceFill ; hResizing: #spaceFill; + balloonText: self closeButtonLabel; + yourself! - yourself! Item was added: + ----- Method: NewColorPickerMorph>>newPickButton (in category 'initialize-release') ----- + newPickButton + ^ (PluggableButtonMorph + on: self + getState: #isPicking + action: #togglePicking + label: #pickingButtonLabel) + vResizing: #spaceFill; + hResizing: #spaceFill; + balloonText: self pickingButtonLabel; + yourself! Item was added: + ----- Method: NewColorPickerMorph>>pickColor (in category 'picking') ----- + pickColor + + | selectedColor | + [ + | previousColor | + previousColor := self selectedColor. + selectedColor := self pickColorFromDisplay. + selectedColor ifNil: [^ self selectedColor: previousColor]. + ] ensure: [ + self isPicking: false]. + self selectedColor: selectedColor.! Item was added: + ----- Method: NewColorPickerMorph>>pickColorFromDisplay (in category 'picking') ----- + pickColorFromDisplay + + [Sensor anyButtonPressed] + whileTrue; + whileFalse: [ + Sensor peekKeyboard = Character escape ifTrue: [ + Sensor flushKeyboard. + ^ nil]. + ((ActiveHand world morphsAt: Sensor cursorPoint) includes: self) ifFalse: [ + self selectedColor: (Display colorAt: Sensor cursorPoint)]. + self world displayWorldSafely; runStepMethods]. + Sensor yellowButtonPressed + ifTrue: [^ nil]. + ((ActiveHand world morphsAt: Sensor cursorPoint) includes: self) + ifTrue: [^ nil]. + ^ self selectedColor! Item was added: + ----- Method: NewColorPickerMorph>>pickingButtonLabel (in category 'initialize-release') ----- + pickingButtonLabel + ^ 'Picking' translated! Item was changed: ----- Method: NewColorPickerMorph>>setup (in category 'initialize-release') ----- setup + self + color: Color white darker; + cornerStyle: #rounded; + changeTableLayout; + hResizing: #shrinkWrap; + vResizing: #shrinkWrap; + extent: 240@240; + addMorphBack: hsvaMorph; + addMorphBack: self newColorExpressionMorph; + addMorphBack: self newBottomRow; + layoutInset: 4; + cellGap: 2. + + Preferences menuAppearance3d + ifTrue: [self addDropShadow].! - color: (Color white darker) ; - cornerStyle: #rounded ; - changeTableLayout ; - hResizing: #shrinkWrap ; - vResizing: #shrinkWrap ; - extent: 240@240 ; - addMorphBack: hsvaMorph ; - addMorphBack: self newColorExpressionMorph ; - addMorphBack: self newBottomRow ; - layoutInset: 4 ; - cellGap: 2. - - Preferences menuAppearance3d - ifTrue: [self addDropShadow]. - ! Item was changed: ----- Method: NewColorPickerMorph>>setupForProperties (in category 'initialize-release') ----- setupForProperties + self + color: Color white darker; + changeTableLayout; + hResizing: #shrinkWrap; + vResizing: #shrinkWrap; + extent: 240@240; + addMorphBack: hsvaMorph; + layoutInset: 4; + cellGap: 2.! - color: (Color white darker) ; - changeTableLayout ; - hResizing: #shrinkWrap ; - vResizing: #shrinkWrap ; - extent: 240@240 ; - addMorphBack: hsvaMorph ; - layoutInset: 4 ; - cellGap: 2.! Item was added: + ----- Method: NewColorPickerMorph>>togglePicking (in category 'picking') ----- + togglePicking + self isPicking: self isPicking not!

6 17

5.3rc3 errors when calling MultiByteFileStream>>#primSize:
by Robert 02 Mar '20

02 Mar '20

Hello everyone! It has been a bit since last time, I post in hopes that everyone is blessed and can only remember the good times! I installed Squeak5.3rc2-19422-64bit and ran the shared image, selected Solarized (Dark) then selected save. I added a local repo and Cryptography repo and loaded Cryptography-rww.115.mcz and ran the tests. Some failures with DateAndTime I fixed (nanos disappeared) so some method call in Cryptography, ASN1UTCType was changed. Then I ran into a problem with MultiByteFileStream>>#primSize: which failed some more Cryptography tests but also prevents me from seeing the Cryptography changes I have just mentioned. I can't determine the cause of primSize: failure, so I thought to report to you the issue. I appreciate any advice in helping validate & pass Cryptography tests. Could these tests be run by the CI server? That would be most helpful, to catch early issues. Kindly, Rabbit

2 2

swiki page(s) for Croquet
by tim Rowledge 02 Mar '20

02 Mar '20

Whilst looking to improve those screenshot pages on the swiki I found the croquet page (http://wiki.squeak.org/squeak/2901); not a single one of the external links still works. opencobalt.org and opencroquet.org are gone. I think the swiki page for 'Croquet on Linux' (http://wiki.squeak.org/squeak/2904) is redundant too. Is there anything at all still valid for croquet? Has anyone kept it running in current Squeak? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Oxymorons: Soft rock

4 5

The Inbox: Morphic-ct.1632.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1632.mcz ==================== Summary ==================== Name: Morphic-ct.1632 Author: ct Time: 29 February 2020, 11:29:22.475896 am UUID: 2d941b38-6604-cb43-bfbb-b7751aa2d55c Ancestors: Morphic-mt.1631 Proposal: In Morph>>#balloonText, also try to invoke balloonSelector on model. =============== Diff against Morphic-mt.1631 =============== Item was changed: ----- Method: Morph>>balloonText (in category 'accessing') ----- balloonText + "Answer balloon help text or nil, if no help is available." + "NB: subclasses may override such that they programatically construct the text, for economy's sake, such as model phrases in a Viewer." - "Answer balloon help text or nil, if no help is available. - NB: subclasses may override such that they programatically - construct the text, for economy's sake, such as model phrases in - a Viewer" + | balloonSelector | + extension ifNil: [^ nil]. - | result | - extension ifNil: [^nil]. extension balloonText + ifNotNil: [:balloonText | ^ balloonText]. + balloonSelector := extension balloonTextSelector + ifNil: [^ nil]. + (ScriptingSystem helpStringOrNilFor: balloonSelector) + ifNotNil: [:result | ^ result]. + balloonSelector == #methodComment + ifTrue: [^ self methodCommentAsBalloonHelp]. + balloonSelector isUnary + ifTrue: [ + (self respondsTo: balloonSelector) + ifTrue: [^ self perform: balloonSelector]. + (self model respondsTo: balloonSelector) + ifTrue: [^ self model perform: balloonSelector]]. + ^ nil! - ifNotNil: [:balloonText | result := balloonText] - ifNil: [extension balloonTextSelector - ifNotNil: [:balloonSelector | - result := ScriptingSystem helpStringOrNilFor: balloonSelector. - (result isNil and: [balloonSelector == #methodComment]) - ifTrue: [result := self methodCommentAsBalloonHelp]. - ((result isNil and: [balloonSelector numArgs = 0]) - and: [self respondsTo: balloonSelector]) - ifTrue: [result := self perform: balloonSelector]]]. - ^ result!

3 2

The Inbox: Morphic-ct.1635.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz ==================== Summary ==================== Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631 Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object? =============== Diff against Morphic-mt.1631 =============== Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.! Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!

3 4

The Inbox: Morphic-ct.1633.mcz
by commits＠source.squeak.org 02 Mar '20

02 Mar '20

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1633.mcz ==================== Summary ==================== Name: Morphic-ct.1633 Author: ct Time: 29 February 2020, 11:33:45.993896 am UUID: f258f893-f17e-f245-af98-b875a4701f7e Ancestors: Morphic-mt.1631 Fixes MorphicHierarchy, which was broken because #world is nil before opening the list in the world. =============== Diff against Morphic-mt.1631 =============== Item was changed: ----- Method: MorphHierarchyListMorph>>createContainer (in category 'private') ----- createContainer "Private - Create a container" | container | container := BorderedMorph new. + container extent: (self currentWorld extent * (1 / 4 @ (2 / 3))) rounded. - container extent: (self world extent * (1 / 4 @ (2 / 3))) rounded. container layoutPolicy: TableLayout new. container hResizing: #rigid. container vResizing: #rigid. container color: (Color gray: 0.9); borderWidth: 1; borderColor: Color gray. container layoutInset: 0. "container useRoundedCorners." "" container setProperty: #morphHierarchy toValue: true. container setNameTo: 'Objects Hierarchy' translated. "" ^ container!

2 1

Separation of domain from UI in Squeak (was: 5.3 cannot rename subclasses of Error)
by Chris Muller 02 Mar '20

02 Mar '20

Hi Marcel, > especially for this one tiny little thing of a modal alert when renaming > classes? > > It is a more general issue. There should be no UI invocation code in a > non-UI part of the system. So, "Transcript showln:." is fine but "self > inform:" is not. Why? Because those cannot be trapped in scripts, which is > - for example - unfortunate in automated pipelines such as our CI. > Actually, they can. "example 1" [ self inform: 'stop everything and pay attention to me!' ] on: ProvideAnswerNotification do: [ : noti | noti resume ] "nil" "example 2" [UIManager default request: 'what is the answer?' initialAnswer: 'tell me now!' ] on: ProvideAnswerNotification do: [ : noti | noti resume: 42 ] "42 " I assumed this is what the CI jobs were doing.. they're not? I totally share your sentiments about no UI invocation code in the domain, and is how I do my own designs, of course, but Squeak chose default to being an <<interactive system>>, and requires handlers of ProvideAnswerNotification to make it non-interactive, rather than the other way around. If you want to flip the above in 5.4 to the normal way -- signaling a kind of ProvideAnswerNotification whose defaultAction issues the modal popup -- then let's flip them, but it doesn't seem like we need a new layer of notification classes just yet. ProvideAnswerNotification may be sufficient. Best, Chris > > > What happened to simply opening up a MessageSet on the references > afterward? > > Still there. Unrelated to this issue. See the end of Browser >> > #renameClass. > > > Say, why do we need a modal alert at all? > > I agree, that extra check in Class >> #rename: might not be necessary and > maybe moved to our refactoring tools. > > Best, > Marcel > > Am 26.02.2020 00:21:48 schrieb Chris Muller <asqueaker(a)gmail.com>: > -1. "Notice" is such a generic, common word to steal from all > applications that might want to create their own, especially for this one > tiny little thing of a modal alert when renaming classes? Say, why do we > need a modal alert at all? What happened to simply opening up a MessageSet > on the references afterward? > > - Chris > > > > > > On Tue, Feb 25, 2020 at 8:17 AM Marcel Taeumel <marcel.taeumel(a)hpi.de> > wrote: > >> Just "Notice"? >> >> Am 25.02.2020 12:11:33 schrieb Eliot Miranda <eliot.miranda(a)gmail.com>: >> >> >> On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <marcel.taeumel(a)hpi.de> >> wrote: >> >> >> Fixed. BUT: Please take a look at >> >> Kernel-mt.1305 >> Tools-mt.941 >> >> We need a name! :-) >> >> >> On second thoughts Notice might be a better name. >> >> >> Best, >> Marcel >> >> Am 25.02.2020 10:11:22 schrieb Marcel Taeumel <marcel.taeumel(a)hpi.de>: >> > Maybe it is a sporadic issue? >> >> It is! Related to the ProgressNotification which I accidentially catch in >> Browser >> #renameClass. I wanted to get the UI call out of Class >> >> #rename:. >> >> That progress notification does not appear every time. Only above a >> certain threshold. That's why it appears to be sporadic. >> >> Best, >> Marcel >> >> Am 25.02.2020 09:37:13 schrieb Thiede, Christoph < >> christoph.thiede(a)student.hpi.uni-potsdam.de>: >> >> I could reproduce it one single time ... Maybe it is a sporadic issue? >> >> >> Best, >> >> Christoph >> <http://www.hpi.de/> >> ------------------------------ >> *Von:* Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im >> Auftrag von Taeumel, Marcel >> *Gesendet:* Dienstag, 25. Februar 2020 09:34:03 >> *An:* John Pfersich via Squeak-dev; Chris Muller >> *Betreff:* Re: [squeak-dev] 5.3 cannot rename subclasses of Error >> >> Hmm... I can reproduce the bug. Yet, calling "Error2 rename: #Error1" >> from a workspace works fine. Strange. >> >> Best, >> Marcel >> >> Am 25.02.2020 09:16:13 schrieb Thiede, Christoph < >> christoph.thiede(a)student.hpi.uni-potsdam.de>: >> >> Hi Chris, >> >> >> in a fresh image, I cannot reproduce this. Are you sure the class has not >> been renamed or is it possible that the class list was not updated properly? >> >> >> Best, >> >> Christoph >> <http://www.hpi.de/> >> ------------------------------ >> *Von:* Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im >> Auftrag von Chris Muller <asqueaker(a)gmail.com> >> *Gesendet:* Dienstag, 25. Februar 2020 06:29:00 >> *An:* squeak dev >> *Betreff:* [squeak-dev] 5.3 cannot rename subclasses of Error >> >> In trunk / 5.3 RC. >> >> - Make a subclass of Error called MyError1 >> - Make a subclass of Error called MyError2 >> - Delete MyError1 >> - Try to rename MyError2 to MyError1 >> >> The last step fails. No errors or debuggers, but the class is not >> renamed. >> >> Works in 5.2. >> >> >> >> >

5 7

[ANN] Squeak 5.3 RC3
by Marcel Taeumel 29 Feb '20

29 Feb '20

Hi all! Here you go :-) http://files.squeak.org/5.3rc3/Squeak5.3rc3-19428-64bit/ [http://files.squeak.org/5.3rc3/Squeak5.3rc3-19428-64bit/] http://files.squeak.org/5.3rc3/Squeak5.3rc3-19428-32bit/ [http://files.squeak.org/5.3rc3/Squeak5.3rc3-19428-32bit/] Note that the bundled VMs for macOS include a fix for the fullscreen mode. Please try it out. :-) Thanks to Fabio for addressing this issue on short notice! Best, Marcel

5 6

The Inbox: Collections-kfr.878.mcz
by commits＠source.squeak.org 29 Feb '20

29 Feb '20

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-kfr.878.mcz ==================== Summary ==================== Name: Collections-kfr.878 Author: kfr Time: 29 February 2020, 12:18:54.1853 pm UUID: ce016281-22ee-4948-b534-944fb3913521 Ancestors: Collections-ul.877 Add 'clear' to Transcript window menu. =============== Diff against Collections-ul.877 =============== Item was added: + ----- Method: TranscriptStream>>addModelItemsToWindowMenu: (in category 'menu') ----- + addModelItemsToWindowMenu: aMenu + + aMenu addLine. + aMenu + add: 'clear' + target: self + action: #clear.!

3 2

Re: [squeak-dev] bug in a ToolBuilder, Squeak5.3rc2
by Christoph Thiede 29 Feb '20

29 Feb '20

Hi Vaidotas, thanks for the report, you're right here! :-) IMHO, this not a real bug, though clearly a behavior that could be improved. The reason is that every single mouse move your image receives while dragging something will trigger your list morph to check whether it can accept the dragged morph, so it will call #dropAccept: and open a debugger. This will happen again for every single of all the many MouseMoveEvents. You might want to use #haltOnce to spawn one debugger only. However, for the feature after 5.3, I would be happy to make the debugger even more robust against this kind of debugger chains (which are not related to a known issue with process-faithful debugging). For example, we could simply count the number of debuggers that were opened in the last few seconds and show a prompt (#request:) if a certain threshold has been reached before opening further debuggers thereafter. This is just a vague idea and may need further discussion ... Best,Christoph Von: Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im Auftrag von Vaidotas Didžbalis <vaidasd(a)gmail.com> Gesendet: Donnerstag, 27. Februar 2020, 21:04 An: Squeak-Dev Betreff: [squeak-dev] bug in a ToolBuilder, Squeak5.3rc2 Hello, It seems there is a bug in the Morphic ToolBuilder lists, sorry if this is not right place reporting it. Say, we have:listSpec := builder pluggableListSpec new.listSpec model: self; list: #fields; ... dropAccept: #acceptThis:; dropItem: #dropOn:at: .Image stalls if I put #halt in #acceptThis regards,Vaidotas

3 2

← Newer
1
2
3
4
5
6
7
8
9
...
31
Older →

Jump to page: