Squeak-dev April 2020

squeak-dev@lists.squeakfoundation.org

39 participants
235 discussions

Morphic equivalent of 'display: none'?
by Thiede, Christoph 07 Apr '20

07 Apr '20

Hi all, does Morphic has an equivalent of JavaScript's 'display: none'? #show/#hide/#visible: reserve space for the hidden morph. However, there are other scenarios where you do not want to reserve space. (A simple example would be a list that should only appear iff it has items.) In JS, you can use 'display: none' instead of 'visibility: hidden' to give the space back to the element's remaining siblings. But in Morphic, is there currently any better option than #delete (and #addMorph:) later? (IMO, delete'n'add is not always the best pattern to do this. You need to remember the index and owner of the relevant morph for adding it later.) Provided that I did not overlook any existing features, would you consider this a useful extension for Morphic? I was thinking of a property (#skipLayout, if you do not have any better idea) and a convenience method (#nonSkippedSubmorphs) that rejects suppressed submorphs. TableLayout would need to use this selector instead of regular #submorphs. Or would this break too many existing things that rely on #submorphs? Another approach would be a selector in the TableLayoutProperties to have all submorphs skipped that are hidden via classical #visible. But this would be less powerful as you couldn't combine both kinds of hiding in the same morph. But maybe this would be even better in terms of avoiding complexity? I'm looking forward to your opinions. Best, Christoph

3 6

Help: Etoys package changes vs trunk
by K K Subbu 07 Apr '20

07 Apr '20

Hi, On a fresh copy of 6.0alpha-19537-64bit, I see the following changes between Etoys package and the trunk: --- D TextMorphEditor>>select D TextMorphEditor>>selectionInterval: ---- Because of these changes, I am unable to save a fix to MonthMorph (see attached) to Inbox. How can I sync up with the trunk for these changes? Regards .. Subbu

2 3

The Inbox: Network-dtl.240.mcz
by commits＠source.squeak.org 07 Apr '20

07 Apr '20

David T. Lewis uploaded a new version of Network to project The Inbox: http://source.squeak.org/inbox/Network-dtl.240.mcz ==================== Summary ==================== Name: Network-dtl.240 Author: dtl Time: 6 April 2020, 10:33:07.751386 pm UUID: a8f00e08-7398-4d4a-8cd2-09cedcada729 Ancestors: Network-eem.239 This update enables the Squeak new networking and IPv6 support by default. The update is in the package postscript. IPv6 network support for the VM (SocketPlugin) and image were implemented by Ian Piumarta circa 2007. This included IPv6 support and a more general image-side representation of network addressing. In 2012, this work was merged into Squeak trunk, with a preference to switch between the old networking support or the new networking support with IPv6. At that time, there were concerns with performance of NetNameResolver on some Windows platforms, and for this reason the "Enable IPv6 and new network support" preference was left disabled for official Squeak distributions. It now 2020, and operating systems have improved over the years, so it is time to enable the new networking preference by default. =============== Diff against Network-eem.239 =============== Item was changed: + (PackageInfo named: 'Network') postscript: '"Enable IPv6 and new network support by default" + NetNameResolver enableIPv6: true + '! - (PackageInfo named: 'Network') postscript: '"Rebuild CSNonAtom." - MailAddressTokenizer cleanUp: false'!

3 2

The Trunk: EToys-kks.389.mcz
by commits＠source.squeak.org 06 Apr '20

06 Apr '20

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-kks.389.mcz ==================== Summary ==================== Name: EToys-kks.389 Author: kks Time: 6 April 2020, 9:59:20.704434 am UUID: 52884b18-40df-44d6-a2b0-5a02a0ef7724 Ancestors: EToys-eem.388 Fixes error popups while using MonthMorph menu. =============== Diff against EToys-eem.388 =============== Item was changed: ----- Method: MonthMorph>>startMondayOrSundayString (in category 'controls') ----- startMondayOrSundayString + ^((Week startDay = #Monday) ifTrue: ['start Sunday'] ifFalse: ['start Monday']) - ^(Week startDay ifTrue: ['start Sunday'] ifFalse: ['start Monday']) translated! Item was changed: ----- Method: WeekMorph>>selectedDates (in category 'all') ----- selectedDates | answer | answer :=OrderedCollection new. self submorphsDo: [:each | ((each respondsTo: #onColor) and: [each color = each onColor]) ifTrue: [answer add: (Date newDay: each label asNumber + month: week start monthName + year: week start year)]]. - month: week firstDate monthName - year: week firstDate year)]]. ^ answer sort!

1 0

The Trunk: EToys-ct.389.mcz
by commits＠source.squeak.org 06 Apr '20

06 Apr '20

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-ct.389.mcz ==================== Summary ==================== Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388 Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report! =============== Diff against EToys-eem.388 =============== Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."! Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!

1 0

The Trunk: EToys-mt.390.mcz
by commits＠source.squeak.org 06 Apr '20

06 Apr '20

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.390.mcz ==================== Summary ==================== Name: EToys-mt.390 Author: mt Time: 6 April 2020, 8:20:52.721118 am UUID: d3cd1e02-f1a6-bf44-9ad9-dadb30fc96a3 Ancestors: EToys-ct.389, EToys-kks.389 Merges fix in MonthMorph and WeekMorph as well as that slip with deprecated extensions in the no-longer-available TextMorphEditor in 6.0alpha. Thanks Subbu (kks) and Christoph (ct)! =============== Diff against EToys-eem.388 =============== Item was changed: ----- Method: MonthMorph>>startMondayOrSundayString (in category 'controls') ----- startMondayOrSundayString + ^((Week startDay = #Monday) ifTrue: ['start Sunday'] ifFalse: ['start Monday']) - ^(Week startDay ifTrue: ['start Sunday'] ifFalse: ['start Monday']) translated! Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."! Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)! Item was changed: ----- Method: WeekMorph>>selectedDates (in category 'all') ----- selectedDates | answer | answer :=OrderedCollection new. self submorphsDo: [:each | ((each respondsTo: #onColor) and: [each color = each onColor]) ifTrue: [answer add: (Date newDay: each label asNumber + month: week start monthName + year: week start year)]]. - month: week firstDate monthName - year: week firstDate year)]]. ^ answer sort!

1 0

The Trunk: Morphic-mt.1643.mcz
by commits＠source.squeak.org 06 Apr '20

06 Apr '20

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1643.mcz ==================== Summary ==================== Name: Morphic-mt.1643 Author: mt Time: 4 April 2020, 11:06:42.760864 am UUID: 81efe0e9-ec69-1b45-ba8e-b81bbb649355 Ancestors: Morphic-mt.1642 Fixes the recently discovered layout bug. Thanks to Christoph (ct)! =============== Diff against Morphic-mt.1642 =============== Item was changed: ----- Method: TableLayout>>computeExtraSpacing:in:horizontal:target: (in category 'layout') ----- computeExtraSpacing: arrangement in: newBounds horizontal: aBool target: aMorph "Compute the required extra spacing for laying out the cells" "match newBounds extent with arrangement's orientation" | extent extra centering n extraPerCell cell last hFill vFill max amount allow | extent := newBounds extent. aBool ifFalse: [extent := extent transposed]. "figure out if we have any horizontal or vertical space fillers" hFill := vFill := false. max := 0 @ 0. arrangement do: [:c | max := (max x max: c cellSize x) @ (max y + c cellSize y). max := max max: c cellSize. hFill := hFill or: [c hSpaceFill]. vFill := vFill or: [c vSpaceFill]]. "Take client's shrink wrap constraints into account. Note: these are only honored when there are no #spaceFill children, or when #rubberBandCells is set." allow := properties rubberBandCells not. aMorph hResizing == #shrinkWrap ifTrue: [aBool ifTrue: [allow & hFill ifFalse: [extent := max x @ (max y max: extent y)]] ifFalse: [allow & vFill ifFalse: [extent := (max x max: extent x) @ max y]]]. aMorph vResizing == #shrinkWrap ifTrue: [aBool ifFalse: [allow & hFill ifFalse: [extent := max x @ (max y max: extent y)]] ifTrue: [allow & vFill ifFalse: [extent := (max x max: extent x) @ max y]]]. "Now compute the extra v space" extra := extent y - (arrangement inject: 0 into: [:sum :c | sum + c cellSize y]). extra > 0 ifTrue: ["Check if we have any #spaceFillers" vFill ifTrue: ["use only #spaceFillers" n := arrangement inject: 0 into: [:sum :c | c vSpaceFill ifTrue: [sum + 1] ifFalse: [sum]]. n isZero ifFalse: [extraPerCell := extra asFloat / n asFloat]. extra := last := 0. arrangement do: [:c | c vSpaceFill ifTrue: [extra := (last := extra) + extraPerCell. amount := 0 @ (extra truncated - last truncated). c do: [:cc | cc cellSize: cc cellSize + amount]]]] ifFalse: ["no #spaceFillers; distribute regularly" centering := properties wrapCentering. "centering == #topLeft ifTrue:[]." "add all extra space to the last cell; e.g., do nothing" centering == #bottomRight ifTrue: ["add all extra space to the first cell" + arrangement ifNotEmpty: [:cells | cells first addExtraSpace: 0 @ extra]]. - arrangement first addExtraSpace: 0 @ extra]. centering == #center ifTrue: ["add 1/2 extra space to the first and last cell" + arrangement ifNotEmpty: [:cells | cells first addExtraSpace: 0 @ (extra // 2)]]. - arrangement first addExtraSpace: 0 @ (extra // 2)]. centering == #justified ifTrue: ["add extra space equally distributed to each cell" n := arrangement size - 1 max: 1. extraPerCell := extra asFloat / n asFloat. extra := last := 0. arrangement do: [:c | c addExtraSpace: 0 @ (extra truncated - last truncated). extra := (last := extra) + extraPerCell]]]]. "Now compute the extra space for the primary direction" centering := properties listCentering. 1 to: arrangement size do: [:i | cell := arrangement at: i. extra := extent x - cell cellSize x. extra > 0 ifTrue: ["Check if we have any #spaceFillers" cell := cell nextCell. cell hSpaceFill ifTrue: ["use only #spaceFillers" n := cell inject: 0 into: [:sum :c | c hSpaceFill ifTrue: [sum + c target spaceFillWeight] ifFalse: [sum]]. n isZero ifFalse: [extraPerCell := extra asFloat / n asFloat]. extra := last := 0. cell do: [:c | c hSpaceFill ifTrue: [extra := (last := extra) + (extraPerCell * c target spaceFillWeight). amount := extra truncated - last truncated. c cellSize: c cellSize + (amount @ 0)]]] ifFalse: ["no #spaceFiller; distribute regularly" "centering == #topLeft ifTrue:[]" "add all extra space to the last cell; e.g., do nothing" centering == #bottomRight ifTrue: ["add all extra space to the first cell" cell addExtraSpace: extra @ 0]. centering == #center ifTrue: ["add 1/2 extra space to the first and last cell" cell addExtraSpace: (extra // 2) @ 0]. centering == #justified ifTrue: ["add extra space equally distributed to each cell" n := cell size - 1 max: 1. extraPerCell := extra asFloat / n asFloat. extra := last := 0. cell do: [:c | c addExtraSpace: (extra truncated - last truncated) @ 0. extra := (last := extra) + extraPerCell]]]]]!

4 4

The Inbox: EToys-kks.389.mcz
by commits＠source.squeak.org 06 Apr '20

06 Apr '20

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-kks.389.mcz ==================== Summary ==================== Name: EToys-kks.389 Author: kks Time: 6 April 2020, 9:59:20.704434 am UUID: 52884b18-40df-44d6-a2b0-5a02a0ef7724 Ancestors: EToys-eem.388 Fixes error popups while using MonthMorph menu. =============== Diff against EToys-eem.388 =============== Item was changed: ----- Method: MonthMorph>>startMondayOrSundayString (in category 'controls') ----- startMondayOrSundayString + ^((Week startDay = #Monday) ifTrue: ['start Sunday'] ifFalse: ['start Monday']) - ^(Week startDay ifTrue: ['start Sunday'] ifFalse: ['start Monday']) translated! Item was changed: ----- Method: WeekMorph>>selectedDates (in category 'all') ----- selectedDates | answer | answer :=OrderedCollection new. self submorphsDo: [:each | ((each respondsTo: #onColor) and: [each color = each onColor]) ifTrue: [answer add: (Date newDay: each label asNumber + month: week start monthName + year: week start year)]]. - month: week firstDate monthName - year: week firstDate year)]]. ^ answer sort!

1 0

Modifying a method's bytecodes ... is it supported?
by Marcel Taeumel 05 Apr '20

05 Apr '20

Hi, all! Are a method's bytecodes virtually read-only? There is no ModificationForbidden at the moment ... Best, Marcel

3 3

[BUG] TableLayout & #disableLayout
by Thiede, Christoph 05 Apr '20

05 Apr '20

Hi all, I think I found a bug in the TableLayout when used in connection with #disableLayout. Example to reproduce: m := Morph new. m changeTableLayout; listDirection: #rightToLeft; wrapCentering: #center. n := Morph new color: Color red. n visible: false; disableLayout: true. m addMorph: n. m fullBounds. Expected output: Same as [n fullBounds]. Actual output: Error: subscript is out of bounds: 1 in TableLayout >> #computeExtraSpacing:in:horizontal:target: Problem: arrangement is nil. In #layout:in:, cells is 0@0->#(). This is an invalid state, isn't it? The bug could have occurred because the initial #hasSubmorphs check in #layout:in: does not work if the only submorphs have #disableLayout set. Would it be an appropriate solution to exit the method after step 1, if cells value isEmpty? I never have worked with LayoutPolicies in detail, thus I likely only see a small part of the problem. I also don't see why listDirection #leftToRight is handled fundamentally differently than #rightToLeft. Any help is appreciated! :-) Best, Christoph

2 2

Jump to page: