Squeak-dev June 2020

squeak-dev@lists.squeakfoundation.org

43 participants
346 discussions

The Inbox: Tools-ct.980.mcz
by commits＠source.squeak.org 27 Jun '20

27 Jun '20

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.980.mcz ==================== Summary ==================== Name: Tools-ct.980 Author: ct Time: 27 June 2020, 9:46:13.766705 pm UUID: ad6a8c37-fddf-fa4f-96ca-6b3c64d4b594 Ancestors: Tools-mt.979 Fixes opening a TextLink pointing to a class from within a MessageSet. In addition, only select the new item for a consistent experience. Steps to reproduce the original bug: 1. Insert a TextLink pointing to a class comment into any method comment and save the method with style. 2. Browse the method in a message trace. 3. Click the link. Before this fix, the message trace raised a draw error because an internal conversion step was forgotten. See also Model >> #addItem: which already respected that conversion. =============== Diff against Tools-mt.979 =============== Item was changed: ----- Method: MessageSet>>addItem: (in category 'message list') ----- addItem: classAndMethod "Append a classAndMethod string to the list. Select the new item." + "Do some checks on the input" + classAndMethod isMethodReference ifFalse: [ + ^ self class parse: classAndMethod toClassAndSelector: [:class :sel | + class ifNotNil: [ + self addItem: (MethodReference class: class selector: sel)]]]. + - "Do some checks on the input?" self okToChange ifFalse: [^ self]. + self deselectAll. + self basicAddItem: classAndMethod. - messageList add: classAndMethod. self changed: #messageList. self messageListIndex: messageList size.! Item was added: + ----- Method: MessageSet>>basicAddItem: (in category 'private') ----- + basicAddItem: classAndMethod + + messageList add: classAndMethod.! Item was added: + ----- Method: MessageTrace>>basicAddItem: (in category 'message list') ----- + basicAddItem: classAndMethod + + super basicAddItem: classAndMethod. + + autoSelectStrings add: nil. + messageSelections add: true.!

1 0

[ANN] The Heart of the Snake King
by Stéphane Rollandin 27 Jun '20

27 Jun '20

The Heart of the Snake King, a pompous name I gave to a fine generative visual art piece (also a pompous way of refering to a pretty animation), can be found at: www.zogotounga.net/comp/squeak/HeartOfSnakeKing.zip Stef

8 21

The Trunk: Monticello-jr.720.mcz
by commits＠source.squeak.org 27 Jun '20

27 Jun '20

Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-jr.720.mcz ==================== Summary ==================== Name: Monticello-jr.720 Author: jr Time: 8 June 2020, 10:04:25.843513 pm UUID: 3f24029f-dae5-e345-9060-d078beba7fcd Ancestors: Monticello-mt.719 Load class traits only after the corresponding instance traits were loaded. The Scanner expression comes from MCTraitDefinition>>requirements. =============== Diff against Monticello-mt.719 =============== Item was changed: ----- Method: MCClassDefinition>>requirements (in category 'comparing') ----- requirements ^superclassName == #nil ifTrue: [self poolDictionaries] + ifFalse: [{ superclassName }, self poolDictionaries, + (self hasTraitComposition + ifTrue: [(Scanner new scanTokens: self traitComposition) flattened select: [:each | each first isUppercase]] + ifFalse: [#()])].! - ifFalse: [{ superclassName }, self poolDictionaries]!

2 1

squeaksource.com is down, looking at it now
by David T. Lewis 26 Jun '20

26 Jun '20

<EOM>

2 3

FFI | How to declare pointer to external structure in #fields?
by Marcel Taeumel 26 Jun '20

26 Jun '20

Hi, there! In the #fields method of a new ExternalStructure, how can I express a pointer to another external structure? First, non-pointer works as expected: ^ #( (other MyStruct) ) Second, this just treats it as a void*, which returns a generic ExternalData: ^ #( (other 'MyStruct*') ) Third, this gives me a debugger: ^ #( (other MyStruct *) ) :-) Best, Marcel

11 22

World main docking bar doesn't resize
by K K Subbu 25 Jun '20

25 Jun '20

Hi, The main docking bar doesn't resize itself when the (host) window is resized in 64bit alpha image. * start the image * resize the window (say widen/shrink the right edge) * the world docking bar remains unchanged/clipped * do any of: * alt-r (redraw screen) * bring up the world menu * click in the main welcome window now the world docking bar fills the entire width. Anyone else see this problem? I bisected all releases of 6.0alpha and narrowed the problem between 19694 (good, 3rd June) and 19722 (bad, 9th june). I could also reproduce the problem in latest 32bit release. BTW, the unzipped 32bit image is 43.0 MB and the 64bit is 46.8 MB. The difference is only 3.8MB. Is this on expected lines? Regards .. Subbu

2 2

todo flag in SmalltalkImage initializeStartupList
by K K Subbu 25 Jun '20

25 Jun '20

Hi, I came across a flag and comment in initializeStartupList: ----- self flag: #'revisit in Squeak 5.3'. ... CrLfFileStream "Remove this in Squeak 5.3" ----- These lines were introduced around 2015. CrLfFileStream doesn't exist anymore in 6.0. Should this line be removed? Regards .. Subbu

2 2

The Trunk: Kernel-nice.1332.mcz
by commits＠source.squeak.org 25 Jun '20

25 Jun '20

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1332.mcz ==================== Summary ==================== Name: Kernel-nice.1332 Author: nice Time: 25 June 2020, 1:40:53.258508 am UUID: 1a712e0e-296b-394e-ad45-7374959e1d30 Ancestors: Kernel-tonyg.1331 Fix the bug found in Cuis by Luciano Notarfrancesco and resolved by Juan Vuletich i:=0. [a := (1 << 60) atRandom. b := (a bitReverse: 64) bitReverse: 64. a = b] whileTrue:[i:=i+1]. ^i Above loop should not stop. But unnormalized Integer were sometimes returned, =============== Diff against Kernel-tonyg.1331 =============== Item was changed: ----- Method: LargePositiveInteger>>bitReverse: (in category 'bit manipulation') ----- bitReverse: highBit "This implementation is faster than super" | digitSize reversed | highBit < self highBit ifTrue: [ self error: 'Not enough bits.' ]. digitSize := highBit + 7 // 8. reversed := self class new: digitSize. 1 to: self digitLength do: [:i | reversed digitAt: digitSize + 1 - i put: (self digitAt: i) byteReversed]. + ^reversed normalize bitShift: highBit - (digitSize * 8)! - ^reversed bitShift: highBit - (digitSize * 8)!

1 0

The Trunk: Collections-ul.896.mcz
by commits＠source.squeak.org 23 Jun '20

23 Jun '20

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.896.mcz ==================== Summary ==================== Name: Collections-ul.896 Author: ul Time: 26 May 2020, 5:06:35.966934 am UUID: 1eb414fc-31f2-4890-8a0e-2cfe892ef798 Ancestors: Collections-nice.895 - prepare to introduce primitive 158 for string comparison =============== Diff against Collections-nice.895 =============== Item was changed: ----- Method: String>>< (in category 'comparing') ----- < aString "Answer whether the receiver sorts before aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) < 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 1! Item was changed: ----- Method: String>><= (in category 'comparing') ----- <= aString "Answer whether the receiver sorts before or equal to aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) <= 0! - ^ (self compare: self with: aString collated: AsciiOrder) <= 2! Item was changed: ----- Method: String>>= (in category 'comparing') ----- = aString "Answer whether the receiver sorts equally as aString. The collation order is simple ascii (with case differences)." self == aString ifTrue: [ ^true ]. aString isString ifFalse: [ ^false ]. self size = aString size ifFalse: [ ^false ]. + ^ (self compareWith: aString) = 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 2! Item was changed: ----- Method: String>>> (in category 'comparing') ----- > aString "Answer whether the receiver sorts after aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) > 0! - ^ (self compare: self with: aString collated: AsciiOrder) = 3! Item was changed: ----- Method: String>>>= (in category 'comparing') ----- >= aString "Answer whether the receiver sorts after or equal to aString. The collation order is simple ascii (with case differences)." + ^(self compareWith: aString) >= 0! - ^ (self compare: self with: aString collated: AsciiOrder) >= 2! Item was changed: ----- Method: String>>compare:caseSensitive: (in category 'comparing') ----- compare: aString caseSensitive: aBool "Answer a comparison code telling how the receiver sorts relative to aString: 1 - before 2 - equal 3 - after. " | map | map := aBool ifTrue:[CaseSensitiveOrder] ifFalse:[CaseInsensitiveOrder]. + ^(self compareWith: aString collated: map) + 2! - ^self compare: self with: aString collated: map! Item was added: + ----- Method: String>>compareWith: (in category 'comparing') ----- + compareWith: aString + + "<primitive: 158>" + ^(self compare: self with: aString collated: AsciiOrder) - 2! Item was added: + ----- Method: String>>compareWith:collated: (in category 'comparing') ----- + compareWith: aString collated: collation + + "<primitive: 158>" + ^(self compare: self with: aString collated: collation) - 2!

1 0

The Trunk: WebClient-Tests-ul.61.mcz
by commits＠source.squeak.org 23 Jun '20

23 Jun '20

Levente Uzonyi uploaded a new version of WebClient-Tests to project The Trunk: http://source.squeak.org/trunk/WebClient-Tests-ul.61.mcz ==================== Summary ==================== Name: WebClient-Tests-ul.61 Author: ul Time: 23 June 2020, 3:49:29.157901 pm UUID: 08abe30a-82a9-40c6-a03e-5c37cbd5d0d4 Ancestors: WebClient-Tests-ul.60 - fixed initials =============== Diff against WebClient-Tests-ul.60 =============== Item was changed: ----- Method: WebMessageTest>>testStreamDirectlyFromToSizeProgressWhenSizeIsNotSpecified (in category 'tests') ----- testStreamDirectlyFromToSizeProgressWhenSizeIsNotSpecified | message | message := WebMessage new. { ByteArray. #yourself. ByteString. #asString } groupsDo: [ :bufferClass :byteArrayToBufferClassConverterSelector | | maxSize source destination progressData totalRead | maxSize := 10000. "Should be greater than the buffer size used by #streamDirectlyFrom:to:size:progress:" source := ((ByteArray new: maxSize streamContents: [ :stream | 1 to: maxSize do: [ :i | stream nextPut: (i bitAnd: 16rFF) ] ]) perform: byteArrayToBufferClassConverterSelector) readStream. destination := (bufferClass new: maxSize) writeStream. progressData := OrderedCollection new. 0 to: maxSize do: [ :bytesToStream | totalRead := 0. source position: maxSize - bytesToStream. destination originalContents from: 1 to: destination position put: (bufferClass == ByteArray ifTrue: [ 0 ] ifFalse: [ Character value: 0 ]). destination resetToStart. progressData reset. message streamDirectlyFrom: source to: destination size: nil progress: [ :size :bytesRead | self assert: nil equals: size description: 'Progress block''s first argument should be the requested size - in this case nil'. progressData add: bytesRead ]. bytesToStream > 0 ifTrue: [ self assert: progressData notEmpty description: 'Missing progress data.'. self assert: 0 equals: progressData first description: 'First progress data should report 0 size.'. self assert: bytesToStream equals: progressData last description: 'Last progress data should be the number of bytes streamed'. self assert: progressData isSorted description: 'Progress data should be monotonic' ] ifFalse: [ self assert: (progressData isEmpty or: [ progressData size = 1 and: [ progressData first = 0 ] ]) description: 'Unexpected progress data' ]. self assert: bytesToStream equals: destination position description: 'All bytes should be streamed'. 1 to: bytesToStream do: [ :i | (destination originalContents at: i) = (source originalContents at: maxSize - bytesToStream + i) ifFalse: [ "This comparison is the same as the next assertion but it's significantly cheaper." self assert: (source originalContents at: maxSize - bytesToStream + i) equals: (destination originalContents at: i) description: 'Copied data doesn''t match source.' ] ] ] ]! Item was changed: ----- Method: WebMessageTest>>testStreamDirectlyFromToSizeProgressWhenSizeIsSpecified (in category 'tests') ----- testStreamDirectlyFromToSizeProgressWhenSizeIsSpecified <timeout: 20> | message | message := WebMessage new. { ByteArray. #yourself. ByteString. #asString } groupsDo: [ :bufferClass :byteArrayToBufferClassConverterSelector | | maxSize source destination progressData totalRead | maxSize := 10000. "Should be greater than the buffer size used by #streamDirectlyFrom:to:size:progress:" source := ((ByteArray new: maxSize streamContents: [ :stream | 1 to: maxSize do: [ :i | stream nextPut: (i bitAnd: 16rFF) ] ]) perform: byteArrayToBufferClassConverterSelector) readStream. destination := (bufferClass new: maxSize) writeStream. progressData := OrderedCollection new. 0 to: maxSize + 1 do: [ :bytesToStream | totalRead := 0. source reset. destination resetToStart. destination originalContents from: 1 to: destination position put: (bufferClass == ByteArray ifTrue: [ 0 ] ifFalse: [ Character value: 0 ]). progressData reset. message streamDirectlyFrom: source to: destination size: bytesToStream progress: [ :size :bytesRead | self assert: bytesToStream equals: size description: 'Progress block''s first argument should be the requested size'. progressData add: bytesRead ]. bytesToStream > 0 ifTrue: [ self assert: 0 equals: progressData first description: 'First progress data should report 0 size.'. self assert: (bytesToStream min: maxSize) equals: progressData last description: 'Last progress data should be the minimum of the number of bytes available and the number of bytes requested'. self assert: progressData isSorted description: 'Progress data should be monotonic' ] ifFalse: [ self assert: (progressData isEmpty or: [ progressData size = 1 and: [ progressData first = 0 ] ]) ]. self assert: (bytesToStream min: maxSize) equals: destination position description: 'Last progress data should be the number of bytes read'. 1 to: destination position do: [ :i | (destination originalContents at: i) = (source originalContents at: i) ifFalse: [ "This comparison is the same as the next assertion but it's significantly cheaper." self assert: (source originalContents at: maxSize - bytesToStream + i) equals: (destination originalContents at: i) description: 'Copied data doesn''t match source.' ] ] ] ]!

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page: