Squeak-dev June 2020

squeak-dev@lists.squeakfoundation.org

43 participants
346 discussions

The Inbox: KernelTests-tonyg.381.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-tonyg.381.mcz ==================== Summary ==================== Name: KernelTests-tonyg.381 Author: tonyg Time: 4 June 2020, 4:43:38.797857 pm UUID: 6d8f1efa-1e6e-470c-aa66-290bcb621a9f Ancestors: KernelTests-mt.380 Tests for a discrepancy between current Promise implementation and the Promises/A+ spec. (Bug reported by Jakob Reschke on squeak-dev, 5 April 2020) =============== Diff against KernelTests-mt.380 =============== Item was added: + ----- Method: PromiseTest>>testAnErrorInOnRejectedRejectsPromise (in category 'tests - monad') ----- + testAnErrorInOnRejectedRejectsPromise + "https://promisesaplus.com section 2.2.7.2" + | p q error | + p := Promise new. + q := p ifRejected: [:e | (error := KeyNotFound new) signal]. + p rejectWith: 1. + self assert: p isRejected description: 'Original Promise not rejected'. + self assert: q isRejected description: 'Broken Promise not rejected'. + self assert: p error = 1. + self assert: q error == error.! Item was changed: ----- Method: PromiseTest>>testAnErrorInThenRejectsPromise (in category 'tests - monad') ----- testAnErrorInThenRejectsPromise + "https://promisesaplus.com section 2.2.7.2" + | p q error | - | p q | p := Promise new. + q := p then: [:v | (error := KeyNotFound new) signal]. - q := p then: [:v | KeyNotFound signal]. p resolveWith: 1. self deny: p isRejected description: 'Original Promise rejected'. + self assert: q isRejected description: 'Broken Promise not rejected'. + self assert: p value = 1. + self assert: q error == error.! - self assert: q isRejected description: 'Broken Promise not rejected'.! Item was changed: ----- Method: PromiseTest>>testifRejectedRunsBlockIfPromiseFails (in category 'tests - monad') ----- testifRejectedRunsBlockIfPromiseFails + "https://promisesaplus.com section 2.2.7.1" | p q error | error := nil. p := Promise new. + q := p ifRejected: [:e | error := e "N.B. returns a value, does not signal an Exception"]. - q := p ifRejected: [:e | error := e]. p rejectWith: KeyNotFound new. + self assert: q isResolved. + self assert: KeyNotFound equals: error class. + self assert: q value == error.! - self assert: q isRejected. - self assert: KeyNotFound equals: error class.!

1 0

[CRON] Errored: squeak-smalltalk/squeak-app#1715 (squeak-trunk - 25ebaf1)
by Travis CI 04 Jun '20

04 Jun '20

Build Update for squeak-smalltalk/squeak-app ------------------------------------- Build: #1715 Status: Errored Duration: 15 mins and 52 secs Commit: 25ebaf1 (squeak-trunk) Author: Marcel Taeumel Message: Hi all! The project "squeak-app" is part of the continuous build infrastructure (short: CI) for Squeak's bundles, which you can download at https://files.squeak.org/, followed by the version tag you are looking for. All bundles are updated on a regular basis, which is daily for Trunk (i.e. the current alpha version) and monthly for release versions. Note that there won't be new bundles if Squeak's build number, which reflects in-image code updates, did not change between CI jobs. -- The Squeak Oversight Board [ci skip] View the changeset: https://github.com/squeak-smalltalk/squeak-app/compare/fb55517f583fe544f922… View the full build log and details: https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/694651060?u… -- You can unsubscribe from build emails from the squeak-smalltalk/squeak-app repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8901856&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

FFI: FFI-Tools-mt.9.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of FFI-Tools to project FFI: http://source.squeak.org/FFI/FFI-Tools-mt.9.mcz ==================== Summary ==================== Name: FFI-Tools-mt.9 Author: mt Time: 4 June 2020, 4:01:29.862669 pm UUID: 2991b8a1-7c1c-3b4c-9dc3-ca1d084df5b2 Ancestors: FFI-Tools-mt.8 Complements FFI-Kernel-mt.90. =============== Diff against FFI-Tools-mt.8 =============== Item was removed: - ----- Method: ExternalStructure class>>isTypeAlias (in category '*FFI-Tools') ----- - isTypeAlias - "Answer whether this structure is an alias for another C type, enum, etc." - "Example: #( nil 'long' )" - - | fields | - ^ (fields := self fields) size = 2 - and: [fields first isNil]!

1 0

FFI: FFI-Kernel-mt.90.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of FFI-Kernel to project FFI: http://source.squeak.org/FFI/FFI-Kernel-mt.90.mcz ==================== Summary ==================== Name: FFI-Kernel-mt.90 Author: mt Time: 4 June 2020, 4:01:13.887669 pm UUID: 39f2d09d-7b47-1f44-ac03-6ef7515f1a3a Ancestors: FFI-Kernel-mt.89 Makes print strings for type aliases more clear. =============== Diff against FFI-Kernel-mt.89 =============== Item was added: + ----- Method: ExternalStructure class>>isTypeAlias (in category 'testing') ----- + isTypeAlias + "Answer whether this structure is an alias for another C type, enum, etc." + "Example: #( nil 'long' )" + + | fields | + ^ (fields := self fields) size = 2 + and: [fields first isNil]! Item was added: + ----- Method: ExternalType>>isTypeAlias (in category 'testing') ----- + isTypeAlias + + | typeAlias | + referentClass ifNil: [^ false]. + typeAlias := self asNonPointerType. + + AtomicTypes valuesDo: [:atomicType | + atomicType compiledSpec == typeAlias compiledSpec ifTrue: [^ true]]. + (StructTypes keys + collect: [:typeName | self class structTypeNamed: typeName]) + select: [:structType | structType notNil and: [structType ~~ typeAlias] and: [ + structType referentClass notNil and: [structType referentClass isTypeAlias not]]] + thenDo: [:structType | structType compiledSpec == typeAlias compiledSpec ifTrue: [^ true]]. + + ^ false! Item was added: + ----- Method: ExternalType>>originalType (in category 'accessing') ----- + originalType + "Resolve type alias." + + | typeAlias | + referentClass ifNil: [^ nil]. + typeAlias := self asNonPointerType. + + AtomicTypes valuesDo: [:atomicType | + (atomicType compiledSpec == typeAlias compiledSpec "and: [atomicType ~~ typeAlias]") + ifTrue: [^ self isPointerType ifTrue: [atomicType asPointerType] ifFalse: [atomicType]]]. + (StructTypes keys + collect: [:typeName | self class structTypeNamed: typeName]) + select: [:structType | structType notNil and: [structType ~~ typeAlias] and: [ + structType referentClass notNil and: [structType referentClass isTypeAlias not]]] + thenDo: [:structType | structType compiledSpec == typeAlias compiledSpec + ifTrue: [ ^ self isPointerType ifTrue: [structType asPointerType] ifFalse: [structType]]]. + + ^ nil! Item was changed: ----- Method: ExternalType>>printOn: (in category 'printing') ----- printOn: aStream + self isTypeAlias ifTrue: [ + aStream + nextPutAll: referentClass name; + nextPut: $<; + print: self originalType; + nextPut: $>. + ^ self]. + self isAtomic ifTrue: [aStream nextPutAll: (AtomicTypeNames at: self atomicType)] ifFalse: [ referentClass == nil ifTrue:[aStream nextPutAll: '<unknown struct type>'] ifFalse:[aStream nextPutAll: referentClass name]]. self isPointerType ifTrue:[aStream nextPut: $*].!

1 0

The Trunk: Compiler-mt.434.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-mt.434.mcz ==================== Summary ==================== Name: Compiler-mt.434 Author: mt Time: 4 June 2020, 4:00:20.252669 pm UUID: cc6bcfeb-0feb-5f41-9617-b3296bf78283 Ancestors: Compiler-eem.433 Complements FFI-Kernel-mt.89. =============== Diff against Compiler-eem.433 =============== Item was changed: ----- Method: Parser>>externalType: (in category 'primitives') ----- externalType: descriptorClass + "Parse and return an external type" + | xType typeName | + typeName := here. "Note that pointer token is not yet parsed!!" + (xType := descriptorClass typeNamed: typeName) + ifNil: [ + "Raise an error if user is there" + self interactive ifTrue: [^nil]. + "otherwise go over it silently -- use an unknown struct type" + xType := descriptorClass newTypeNamed: here]. - "Parse an return an external type" - | xType | - xType := descriptorClass atomicTypeNamed: here. - xType == nil ifTrue:["Look up from class scope" - Symbol hasInterned: here ifTrue:[:sym| - xType := descriptorClass structTypeNamed: sym]]. - xType == nil ifTrue:[ - "Raise an error if user is there" - self interactive ifTrue:[^nil]. - "otherwise go over it silently" - xType := descriptorClass forceTypeNamed: here]. self advance. (self matchToken:#*) ifTrue:[^xType asPointerType] ifFalse:[^xType]!

1 0

FFI: FFI-Kernel-mt.89.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of FFI-Kernel to project FFI: http://source.squeak.org/FFI/FFI-Kernel-mt.89.mcz ==================== Summary ==================== Name: FFI-Kernel-mt.89 Author: mt Time: 4 June 2020, 3:58:25.336669 pm UUID: 40d6dc34-2829-e141-ac5e-405a9753b67b Ancestors: FFI-Kernel-mt.88 Serveral fixes concerning the creation for external struct types during field compilation in external structs. It is now possible to have a pointer to the same struct you are currently defining in the very first try. typedef struct Link { struct Link* next; } Link; Note that I think there is no need for #initializeStructureTypes anymore. I may drop that in the near future in favor of the #platformChangedFrom:to: mechanism. :-) =============== Diff against FFI-Kernel-mt.88 =============== Item was removed: - ----- Method: ExternalFunction class>>forceTypeNamed: (in category 'compiler support') ----- - forceTypeNamed: aString - ^ExternalType forceTypeNamed: aString! Item was removed: - ----- Method: ExternalFunction class>>isValidType: (in category 'compiler support') ----- - isValidType: anObject - ^anObject isBehavior and:[anObject includesBehavior: ExternalStructure]! Item was added: + ----- Method: ExternalFunction class>>newTypeNamed: (in category 'compiler support') ----- + newTypeNamed: typeName + ^ExternalType newTypeNamed: typeName! Item was added: + ----- Method: ExternalFunction class>>typeNamed: (in category 'compiler support') ----- + typeNamed: aString + ^ExternalType typeNamed: aString! Item was changed: ----- Method: ExternalStructure class>>byteAlignment (in category 'field definition') ----- byteAlignment - byteAlignment ifNil: [self compileFields]. - self assert: byteAlignment ~~ nil. ^ byteAlignment! Item was changed: ----- Method: ExternalStructure class>>compileAlias:withAccessors: (in category 'field definition') ----- compileAlias: spec withAccessors: aSymbol "Define all the fields in the receiver. Return the newly compiled spec." + | fieldName fieldTypeName isPointerField externalType newCompiledSpec | - | fieldName fieldType isPointerField externalType newCompiledSpec | fieldName := spec first. + fieldTypeName := spec second. + isPointerField := fieldTypeName last = $*. + fieldTypeName := fieldTypeName copyWithout: $*. + externalType := (ExternalType typeNamed: fieldTypeName) + ifNil: [self errorTypeNotFound: spec second]. - fieldType := spec second. - isPointerField := fieldType last = $*. - fieldType := fieldType copyWithout: $*. - externalType := ExternalType atomicTypeNamed: fieldType. - externalType == nil ifTrue:["non-atomic" - Symbol hasInterned: fieldType ifTrue:[:sym| - externalType := ExternalType structTypeNamed: sym]]. - externalType == nil ifTrue:[ - Transcript show:'(', fieldType,' is void)'. - externalType := ExternalType void]. isPointerField ifTrue:[externalType := externalType asPointerType]. (fieldName notNil and:[self shouldGenerate: fieldName policy: aSymbol]) ifTrue:[ self defineAliasAccessorsFor: fieldName type: externalType]. newCompiledSpec := isPointerField ifTrue:[WordArray with: (ExternalType structureSpec bitOr: ExternalType pointerSpec)] ifFalse:[externalType compiledSpec]. byteAlignment := isPointerField ifTrue: [ExternalType pointerAlignment] ifFalse: [externalType byteAlignment]. ^newCompiledSpec! Item was changed: ----- Method: ExternalStructure class>>compileFields:withAccessors: (in category 'field definition') ----- compileFields: specArray withAccessors: aSymbol "Compile a type specification for the FFI machinery. Return the newly compiled spec. Eventually generate the field accessors according to following rules: - aSymbol = #always always generate the accessors - aSymbol = #never never generate the accessors - aSymbol = #generated only generate the auto-generated accessors - aSymbol = #absent only generate the absent accessors" | newByteAlignment byteOffset typeSpec newCompiledSpec | (specArray size > 0 and: [specArray first class ~~ Array]) ifTrue: [^ self compileAlias: specArray withAccessors: aSymbol]. byteOffset := 0. newByteAlignment := self minStructureAlignment. typeSpec := WriteStream on: (WordArray new: 10). typeSpec nextPut: FFIFlagStructure. + specArray do: [:spec | + | fieldName fieldTypeName isPointerField externalType typeSize fieldAlignment | - "dummy for size" - specArray do: - [:spec | | fieldName fieldType isPointerField externalType typeSize fieldAlignment selfRefering | fieldName := spec first. + fieldTypeName := spec second. + isPointerField := fieldTypeName last = $*. + fieldTypeName := (fieldTypeName findTokens: '*') first withBlanksTrimmed. + externalType := (ExternalType typeNamed: fieldTypeName) + ifNil: [self errorTypeNotFound: spec second]. + isPointerField ifTrue: [externalType := externalType asPointerType]. + typeSize := externalType byteSize. + fieldAlignment := (externalType byteAlignment + max: self minFieldAlignment) + min: self maxFieldAlignment. + byteOffset := byteOffset alignedTo: fieldAlignment. + newByteAlignment := newByteAlignment max: fieldAlignment. + spec size > 2 ifTrue: ["extra size" + spec third < typeSize + ifTrue: [^ self error: 'Explicit type size is less than expected']. + typeSize := spec third. - fieldType := spec second. - isPointerField := fieldType last = $*. - fieldType := (fieldType findTokens: '*') first withBlanksTrimmed. - externalType := ExternalType atomicTypeNamed: fieldType. - selfRefering := isPointerField and: [externalType isNil and: [fieldType = self asString]]. - selfRefering ifTrue: [ - externalType := ExternalType void asPointerType - ] ifFalse:[ - externalType ifNil: ["non-atomic" - (Symbol lookup: fieldType) ifNotNil: [:sym | - externalType := ExternalType structTypeNamed: sym]. - ]. - externalType ifNil: [ - Transcript show: '(' , fieldType , ' is void)'. - externalType := ExternalType void. - ]. - isPointerField ifTrue: [externalType := externalType asPointerType]]. - typeSize := externalType byteSize. - fieldAlignment := (externalType byteAlignment max: self minFieldAlignment) - min: self maxFieldAlignment. - byteOffset := byteOffset alignedTo: fieldAlignment. - newByteAlignment := newByteAlignment max: fieldAlignment. - spec size > 2 ifTrue: ["extra size" - spec third < typeSize - ifTrue: [^ self error: 'Explicit type size is less than expected']. - typeSize := spec third. - ]. - (fieldName notNil and: [self shouldGenerate: fieldName policy: aSymbol]) ifTrue: [ - self defineFieldAccessorsFor: fieldName startingAt: byteOffset + 1 type: externalType. - ]. - typeSpec nextPutAll: (externalType embeddedSpecWithSize: typeSize). - byteOffset := byteOffset + typeSize. ]. + (fieldName notNil and: [self shouldGenerate: fieldName policy: aSymbol]) ifTrue: [ + self defineFieldAccessorsFor: fieldName startingAt: byteOffset + 1 type: externalType. + ]. + typeSpec nextPutAll: (externalType embeddedSpecWithSize: typeSize). + byteOffset := byteOffset + typeSize. + ]. newByteAlignment := newByteAlignment min: self maxStructureAlignment. byteOffset := byteOffset alignedTo: newByteAlignment. newCompiledSpec := typeSpec contents. newCompiledSpec at: 1 put: (byteOffset bitOr: FFIFlagStructure). byteAlignment := newByteAlignment. ^ newCompiledSpec! Item was added: + ----- Method: ExternalStructure class>>compileFieldsSilently (in category 'field definition') ----- + compileFieldsSilently + + compiledSpec := self compileFields: self fields withAccessors: #generated. + ^compiledSpec! Item was changed: ----- Method: ExternalStructure class>>compiledSpec (in category 'field definition') ----- compiledSpec + ^compiledSpec! - "Return the compiled spec of the receiver" - ^compiledSpec ifNil:[self compileFields].! Item was added: + ----- Method: ExternalStructure class>>errorTypeNotFound: (in category 'field definition') ----- + errorTypeNotFound: typeName + + self error: ('Unknown external type ''{1}''. If it is a structure type, create a class for that structure first.' format: {typeName}).! Item was changed: + ----- Method: ExternalType class>>atomicTypeNamed: (in category 'instance lookup') ----- - ----- Method: ExternalType class>>atomicTypeNamed: (in category 'private') ----- atomicTypeNamed: aString ^AtomicTypes at: aString ifAbsent:[nil]! Item was removed: - ----- Method: ExternalType class>>forceTypeNamed: (in category 'private') ----- - forceTypeNamed: aString - ^self newTypeNamed: aString force: true! Item was changed: ----- Method: ExternalType class>>initializeStructureTypes (in category 'class initialization') ----- initializeStructureTypes "ExternalType initialize" + + | referentClassOrNil | - | referentClass pointerType | self cleanupUnusedTypes. + + StructTypes keysAndValuesDo:[:referentName :type | + referentClassOrNil := (self environment classNamed: referentName) + ifNotNil: [:cls | (cls includesBehavior: ExternalStructure) ifTrue: [cls]]. + + self flag: #remove. "mt: Recompilation happens already via ExternalObject." + referentClassOrNil ifNotNil: [referentClassOrNil compileFieldsSilently]. + + type asNonPointerType + newReferentClass: referentClassOrNil. + type asPointerType + newReferentClass: referentClassOrNil. + - StructTypes keysAndValuesDo:[:referentName :type| - referentClass := (Smalltalk at: referentName ifAbsent:[nil]). - (referentClass isBehavior and:[ - referentClass includesBehavior: ExternalStructure]) - ifFalse:[referentClass := nil]. - type compiledSpec: - (WordArray with: self structureSpec). - type newReferentClass: referentClass. - pointerType := type asPointerType. - pointerType compiledSpec: - (WordArray with: self pointerSpec); - byteAlignment: self pointerAlignment. - pointerType newReferentClass: referentClass. ].! Item was added: + ----- Method: ExternalType class>>newTypeForStructureClass: (in category 'instance creation') ----- + newTypeForStructureClass: anExternalStructureClass + + | type referentClass | + referentClass := anExternalStructureClass. + self assert: [referentClass includesBehavior: ExternalStructure]. + + type := self newTypeForUnknownNamed: referentClass name. + + referentClass compiledSpec + ifNil: [ "First time. The referent class' fields are probably just compiled for the first time." + type asNonPointerType setReferentClass: referentClass. + type asPointerType setReferentClass: referentClass] + ifNotNil: [ + type asNonPointerType newReferentClass: referentClass. + type asPointerType newReferentClass: referentClass]. + + ^ type! Item was added: + ----- Method: ExternalType class>>newTypeForUnknownNamed: (in category 'instance creation') ----- + newTypeForUnknownNamed: typeName + + | type pointerType | + self assert: [(StructTypes includesKey: typeName) not]. + + type := self basicNew + compiledSpec: (WordArray with: self structureSpec); + yourself. + + pointerType := self basicNew + compiledSpec: (WordArray with: self pointerSpec); + yourself. + + "Connect non-pointer type with pointer type." + type setReferencedType: pointerType. + pointerType setReferencedType: type. + + "Remember this new struct type." + self flag: #discuss. "mt: Field definitions in external structures will usually have strings of the struct type, not symbols. At least, if it is a pointer to that struct type. Maybe we should always use strings instead of symbols?" + StructTypes at: typeName asSymbol put: type. + + ^ type! Item was added: + ----- Method: ExternalType class>>newTypeNamed: (in category 'instance creation') ----- + newTypeNamed: aTypeName + + | structClass | + structClass := (self environment classNamed: aTypeName) + ifNotNil: [:class | (class includesBehavior: ExternalStructure) ifTrue: [class]]. + + ^ structClass + ifNil: [self newTypeForUnknownNamed: aTypeName] + ifNotNil: [self newTypeForStructureClass: structClass]! Item was removed: - ----- Method: ExternalType class>>newTypeNamed:force: (in category 'private') ----- - newTypeNamed: aString force: aBool - | sym type referentClass pointerType | - sym := aString asSymbol. - type := StructTypes at: aString ifAbsent:[nil]. - type == nil ifFalse:[^type]. - referentClass := Smalltalk at: sym ifAbsent:[nil]. - (referentClass isBehavior and:[referentClass includesBehavior: ExternalStructure]) - ifFalse:[referentClass := nil]. - "If we don't have a referent class and are not forced to create a type get out" - (referentClass == nil and:[aBool not]) ifTrue:[^nil]. - type := self basicNew compiledSpec: - (WordArray with: self structureSpec). - pointerType := self basicNew compiledSpec: - (WordArray with: self pointerSpec). - type setReferencedType: pointerType. - pointerType setReferencedType: type. - type newReferentClass: referentClass. - pointerType newReferentClass: referentClass. - pointerType byteAlignment: self pointerAlignment. - StructTypes at: sym put: type. - ^type! Item was changed: + ----- Method: ExternalType class>>structTypeNamed: (in category 'instance lookup') ----- + structTypeNamed: typeName + "Answers the external type for the struct named typeName. If there is no type yet, create a new one but only if typeName can be matched to an existing class in the system already. If you still need a type even if there is no such class present, use #newTypeNamed: to create a type with an unknown referent class." + + ^ (StructTypes at: typeName ifAbsent: [nil]) + ifNil: [ + (self environment classNamed: typeName) + ifNotNil: [:cls | (cls includesBehavior: ExternalStructure) ifTrue: [ + StructTypes removeKey: typeName ifAbsent: []. + self newTypeNamed: typeName]]] + ! - ----- Method: ExternalType class>>structTypeNamed: (in category 'private') ----- - structTypeNamed: aSymbol - aSymbol == nil ifTrue:[^nil]. - ^self newTypeNamed: aSymbol force: false! Item was added: + ----- Method: ExternalType class>>typeNamed: (in category 'instance lookup') ----- + typeNamed: typeName + + (self atomicTypeNamed: typeName) + ifNotNil: [:type | ^ type]. + (self structTypeNamed: typeName) + ifNotNil: [:type | ^ type]. + + ^ nil! Item was changed: ----- Method: ExternalType>>newReferentClass: (in category 'private') ----- newReferentClass: aClass "The class I'm referencing has changed. Update my spec." referentClass := aClass. self isPointerType ifTrue:[^self]. "for pointers only the referentClass changed" referentClass == nil ifTrue:[ "my class has been removed - make me 'struct { void }'" + compiledSpec := WordArray with: self class structureSpec. - compiledSpec := WordArray with: (FFIFlagStructure). byteAlignment := 1. ] ifFalse:[ "my class has been changed - update my compiledSpec" compiledSpec := referentClass compiledSpec. byteAlignment := referentClass byteAlignment. ].! Item was changed: ----- Method: ExternalType>>printOn: (in category 'printing') ----- printOn: aStream + + self isAtomic + ifTrue: [aStream nextPutAll: (AtomicTypeNames at: self atomicType)] + ifFalse: [ + referentClass == nil + ifTrue:[aStream nextPutAll: '<unknown struct type>'] + ifFalse:[aStream nextPutAll: referentClass name]]. - referentClass == nil - ifTrue:[aStream nextPutAll: (AtomicTypeNames at: self atomicType)] - ifFalse:[aStream nextPutAll: referentClass name]. self isPointerType ifTrue:[aStream nextPut: $*].! Item was added: + ----- Method: ExternalType>>setReferentClass: (in category 'private') ----- + setReferentClass: aClass + referentClass := aClass.! Item was changed: ----- Method: ExternalType>>storeOn: (in category 'printing') ----- storeOn: aStream + + self isAtomic - referentClass == nil ifTrue:[aStream nextPutAll: ExternalType name; space; nextPutAll: (AtomicTypeNames at: self atomicType)] + ifFalse:[ + referentClass == nil + ifTrue: [aStream nextPutAll: 'nil'] + ifFalse: [aStream nextPut: $(; nextPutAll: ExternalType name; space; nextPutAll: #structTypeNamed:; space; store: referentClass name; nextPut: $)]]. - ifFalse:[aStream nextPut: $(; nextPutAll: ExternalType name; space; nextPutAll: #structTypeNamed:; space; store: referentClass name; nextPut: $)]. self isPointerType ifTrue: [aStream space; nextPutAll: #asPointerType].! Item was changed: ----- Method: ExternalUnion class>>compileFields:withAccessors: (in category 'field definition') ----- compileFields: specArray withAccessors: aSymbol "Compile a type specification for the FFI machinery. Return the newly compiled spec. Eventually generate the field accessors according to the policy defined in aSymbol." | byteOffset maxByteSize typeSpec newCompiledSpec newByteAlignment | (specArray size > 0 and: [specArray first class ~~ Array]) ifTrue: + [^ self error: 'Use ExternalStructure to define a type alias, not ExternalUnion']. - [^ self error: 'unions must have fields defined by sub-Array']. byteOffset := 1. newByteAlignment := 1. maxByteSize := 0. typeSpec := WriteStream on: (WordArray new: specArray size + 1). typeSpec nextPut: FFIFlagStructure. + specArray do: [:spec | + | fieldName fieldTypeName isPointerField externalType typeSize typeAlignment | - "dummy for size" - specArray do: - [:spec | - | fieldName fieldType isPointerField externalType typeSize typeAlignment selfRefering | fieldName := spec first. + fieldTypeName := spec second. + isPointerField := fieldTypeName last = $*. + fieldTypeName := (fieldTypeName findTokens: '*') first withBlanksTrimmed. + externalType := (ExternalType typeNamed: fieldTypeName) + ifNil: [self errorTypeNotFound: spec second]. + isPointerField ifTrue: [externalType := externalType asPointerType]. + typeSize := externalType byteSize. + typeAlignment := externalType byteAlignment. + spec size > 2 ifTrue: ["extra size" + spec third < typeSize + ifTrue: [^ self error: 'Explicit type size is less than expected']. + typeSize := spec third. - fieldType := spec second. - isPointerField := fieldType last = $*. - fieldType := (fieldType findTokens: '*') first withBlanksTrimmed. - externalType := ExternalType atomicTypeNamed: fieldType. - selfRefering := isPointerField and: [externalType isNil and: [fieldType = self asString]]. - selfRefering ifTrue: [ - externalType := ExternalType void asPointerType - ] ifFalse:[ - externalType ifNil: ["non-atomic" - (Symbol lookup: fieldType) ifNotNil: [:sym | - externalType := ExternalType structTypeNamed: sym]. - ]. - externalType ifNil: [ - Transcript show: '(' , fieldType , ' is void)'. - externalType := ExternalType void. - ]. - isPointerField ifTrue: [externalType := externalType asPointerType]]. - typeSize := externalType byteSize. - typeAlignment := externalType byteAlignment. - spec size > 2 ifTrue: ["extra size" - spec third < typeSize - ifTrue: [^ self error: 'Explicit type size is less than expected']. - typeSize := spec third. - ]. - (fieldName notNil and: [self shouldGenerate: fieldName policy: aSymbol]) ifTrue: [ - self defineFieldAccessorsFor: fieldName startingAt: byteOffset type: externalType. - ]. - typeSpec nextPutAll: (externalType embeddedSpecWithSize: typeSize). - maxByteSize := maxByteSize max: typeSize. - newByteAlignment := newByteAlignment max: typeAlignment ]. + (fieldName notNil and: [self shouldGenerate: fieldName policy: aSymbol]) ifTrue: [ + self defineFieldAccessorsFor: fieldName startingAt: byteOffset type: externalType. + ]. + typeSpec nextPutAll: (externalType embeddedSpecWithSize: typeSize). + maxByteSize := maxByteSize max: typeSize. + newByteAlignment := newByteAlignment max: typeAlignment + ]. maxByteSize := maxByteSize alignedTo: newByteAlignment. newCompiledSpec := typeSpec contents. newCompiledSpec at: 1 put: (maxByteSize bitOr: FFIFlagStructure). byteAlignment := newByteAlignment. ^ newCompiledSpec!

1 0

[ANN] Chess960
by Stéphane Rollandin 04 Jun '20

04 Jun '20

Hello, I have fixed a few bugs and somewhat improved the chess game. Bugs: - castling was not possible when a rook was menaced - a test for king attack in black king-side castling was missing - the cached number of pawns is sometimes off, which could lead to a DivideByZero error in some endgames (this is fixed, but not the discrepancy which still effects the material evaluation) - a pawn taken en-passant was not removed from display One notable bug left is that undoing a castling move makes it impossible to castle again. Improvements: - nicer display, scalable (with assets from wikimedia common) - the board is now sticky and cannot be accidentally grabbed - hints (from the 'help' button) now appear in the status line - support for Fischer randomized chess, aka Chess960 Changes: - to castle, one now has to move the king over the rook To try it: Chess960Morph new openInWorld Stef

2 5

NOTICE | Duplicate Monticello version names
by Marcel Taeumel 04 Jun '20

04 Jun '20

Hi, there! I notice several false duplicate version names between trunk and inbox. This can happen when you work on packages that only have one or the other configured in their repository group. Monticello checks uniqueness of names for all repositories in a group when saving a new version. Am now quite sure how this can happen. Maybe because of a manual override of such names. Please don't do that. :-) A typical repository group with trunk, inbox, and package-cache can figure out, which new name to choose next: We might want to change all repository groups to include the inbox repository by default. Let me add that to the release builder. Best, Marcel

1 1

The Trunk: ReleaseBuilder-mt.210.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.210.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.210 Author: mt Time: 4 June 2020, 10:46:53.758143 am UUID: d7c7b7de-b518-9a4b-816e-d52b09d2ff86 Ancestors: ReleaseBuilder-mt.209 When creating a new base image for squeak-app CI, add also inbox and treated repositories to packages to make the duplicate-mc-name detection work properly later on. For all dev images out there, use the postscript to add those repos to the core packages. =============== Diff against ReleaseBuilder-mt.209 =============== Item was changed: ----- Method: ReleaseBuilder class>>switchToNewRepository: (in category 'scripts - support') ----- switchToNewRepository: anMCRepository MCMcmUpdater defaultUpdateURL: anMCRepository description. MCRepositoryGroup reset. MCRepositoryGroup default addRepository: anMCRepository. MCWorkingCopy allManagers do: [ : each | each repositoryGroup: (MCRepositoryGroup new addRepository: anMCRepository ; + addRepository: MCRepository inbox ; + addRepository: MCRepository treated ; yourself) ]! Item was added: + (PackageInfo named: 'ReleaseBuilder') postscript: '"See forum.world.st/NOTICE-Duplicate-Monticello-version-names-td5117695.html" + MCMcmUpdater default dependentPackages do: [:package | + package workingCopy repositoryGroup + addRepository: MCRepository inbox; + addRepository: MCRepository treated]. + '!

1 0

The Trunk: MonticelloConfigurations-mt.162.mcz
by commits＠source.squeak.org 04 Jun '20

04 Jun '20

Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-mt.162.mcz ==================== Summary ==================== Name: MonticelloConfigurations-mt.162 Author: mt Time: 4 June 2020, 10:45:11.536143 am UUID: befbc166-bc90-5d44-84df-7eaf4c0ee203 Ancestors: MonticelloConfigurations-dtl.161 Adds a convenient way to get all packages that are dependent in the updates current update map. MCMcmUpdater default dependentPackages. =============== Diff against MonticelloConfigurations-dtl.161 =============== Item was added: + ----- Method: MCMcmUpdater>>dependentPackages (in category 'private') ----- + dependentPackages + "Answers all packages that are referenced in the update map." + + | repo updateList | + repo := self getRepositoryFromRepositoryGroup. + updateList := self refreshUpdateMapFor: repo with: (self updateListFor: repo). + ^ updateList gather: [:assoc | + (repo versionNamed: assoc value) dependencies + collect: [:dep | dep package]] + !

1 0

← Newer
1
...
28
29
30
31
32
33
34
35
Older →

Jump to page: