Squeak-dev September 2020

squeak-dev@lists.squeakfoundation.org

37 participants
270 discussions

Why is ModificationForbidden not an Error?
by Thiede, Christoph 03 Oct '20

03 Oct '20

Hi all, please take a short look at this behavior: TestRunner openForSuite: MorphicUIManagerTest suite. "Run Selected" <http://www.hpi.de/> At the moment (#19541), a bug in FileList2 class >> #endingSpecs (which I'm going to fix ASAP) breaks the test #testShowAllBinParts. But because ModificationForbidden is not an Error, it is not caught by the TestRunner so the whole suite run blows up, too. I could make another example by triggering a ModificationForbidden in a #drawOn: method to destroy the whole image, too. (Morph newSubclass compile: 'drawOn: x #(1) at: 1 put: 2'; new) openInHand) So my question is: Why doesn't ModificationForbidden derive from Error? Isn't it actually an error? Similar illegal operations such as "#() at: 0" or "{} at: 1 put: #foo" raise some kind of Error, too. Everything I learned so far about Squeak's exception framework tells me that you should have a very good reason if you design an exception neither to derive from Error, nor from Notification. At the moment, we only do have 9 exceptions (bad pun ...) to this rule (and I'm not even sure whether MCNoChangesException couldn't be a notification, and Abort does not even have senders in the Trunk). I'd be happy if you could give me some pointers on why ModificationForbidden does not follow this rule. How can we deal with this in order to fix the bugs/unexpected behaviors mentioned above? Possibly related stuff: * http://forum.world.st/Squeak-s-AssertionFailure-vs-SUnit-s-TestFailure-td51… * http://forum.world.st/The-Trunk-Kernel-eem-1294-mcz-td5112196.html * http://forum.world.st/The-Trunk-Kernel-eem-1317-mcz-tp5113273p5113433.html Best, Christoph

12 53

The Inbox: Tools-ct.986.mcz
by commits＠source.squeak.org 03 Oct '20

03 Oct '20

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.986.mcz ==================== Summary ==================== Name: Tools-ct.986 Author: ct Time: 2 September 2020, 4:55:38.538083 pm UUID: b4cdf611-f04b-0b40-8f61-34429f414cca Ancestors: Tools-ct.985 Fixes MNU when adding senders of a non-string literal to a message trace (at the end, FindText was set to a number or something similar). Improves multilingual support. =============== Diff against Tools-ct.985 =============== Item was changed: ----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') ----- addParentMethodsSending: selectorSymbol + ^ self systemNavigation + headingAndAutoselectForLiteral: selectorSymbol + do: [:label :autoSelect | + | methodsList | + methodsList := self systemNavigation allCallsOn: selectorSymbol. + methodsList ifEmpty: [ + ^ self inform: ('There are no {1}' translated format: {label})]. + self - | methodsList | - (methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty - ifTrue: - [ ^(PopUpMenu labels: ' OK ') - startUpWithCaption: 'There are no methods that send ', selectorSymbol ] - ifFalse: - [ self addParentMessages: methodsList + autoSelectString: autoSelect] - autoSelectString: selectorSymbol ] !

6 10

The Inbox: Tools-ct.991.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.991.mcz ==================== Summary ==================== Name: Tools-ct.991 Author: ct Time: 30 September 2020, 7:46:39.949807 pm UUID: 4d2f75ef-336d-cc4c-aa0d-dd4f7ff99fc7 Ancestors: Tools-mt.990 Fixes a bug in DebuggerMethodMap's rangeForPC lookup Steps to reproduce: c := Object newSubclass. c compile: 'foo: foo foo = #foo ifTrue: [^ true]. ^ (foo ifNil: [^ false]) = #bar'. c new foo: #bar. "Debug it. Step into #foo:, step over #=. Before this commit, the selection was '^ true'" The error was that #findNearbyBinaryIndex: uses to return the lower possible index if there is no exact match. For debugging, we cannot need this behavior, because we want to select the next operation to be executed. Furthermore, this commit refactors some duplication with DebuggerMethodMapForFullBlockCompiledMethod. Please review! Uploaded again due to totally broken ancestry. Replaces Tools-ct.956, which can be moved into the treated inbox. =============== Diff against Tools-mt.990 =============== Item was changed: ----- Method: DebuggerMethodMap>>rangeForPC:in:contextIsActiveContext: (in category 'source mapping') ----- rangeForPC: contextsConcretePC in: method contextIsActiveContext: contextIsActiveContext + "Answer the indices in the source code for the supplied pc. If the context is the active context (is at the hot end of the stack) then its pc is the current pc. But if the context isn't, because it is suspended sending a message, then its current pc is the previous pc." - "Answer the indices in the source code for the supplied pc. - If the context is the actve context (is at the hot end of the stack) - then its pc is the current pc. But if the context isn't, because it is - suspended sending a message, then its current pc is the previous pc." + | pc i end sortedMap | - | pc i end | pc := method abstractPCForConcretePC: (contextIsActiveContext + ifTrue: [contextsConcretePC] + ifFalse: [(method pcPreviousTo: contextsConcretePC) + ifNil: [contextsConcretePC]]). + (self abstractSourceMapForMethod: method) + at: pc + ifPresent: [:range | ^ range]. + sortedMap := self sortedSourceMapForMethod: method. + sortedMap ifEmpty: [^ 1 to: 0]. + i := sortedMap + findBinaryIndex: [:assoc | pc - assoc key] + ifNone: [:lower :upper | upper]. + i < 1 ifTrue: [^ 1 to: 0]. + i > sortedMap size ifTrue: [ + end := sortedMap inject: 0 into: [:prev :this | + prev max: this value last]. + ^ end + 1 to: end]. + ^ (sortedMap at: i) value! - ifTrue: [contextsConcretePC] - ifFalse: [(method pcPreviousTo: contextsConcretePC) - ifNotNil: [:prevpc| prevpc] - ifNil: [contextsConcretePC]]). - (self abstractSourceMap includesKey: pc) ifTrue: - [^self abstractSourceMap at: pc]. - sortedSourceMap ifNil: - [sortedSourceMap := self abstractSourceMap associations - replace: [ :each | each copy ]; - sort]. - sortedSourceMap isEmpty ifTrue: [^1 to: 0]. - i := sortedSourceMap findNearbyBinaryIndex: [:assoc| pc - assoc key]. - i < 1 ifTrue: [^1 to: 0]. - i > sortedSourceMap size ifTrue: - [end := sortedSourceMap inject: 0 into: - [:prev :this | prev max: this value last]. - ^end+1 to: end]. - ^(sortedSourceMap at: i) value - - "| method source scanner map | - method := DebuggerMethodMap compiledMethodAt: #rangeForPC:in:contextIsActiveContext:. - source := method getSourceFromFile asString. - scanner := InstructionStream on: method. - map := method debuggerMap. - Array streamContents: - [:ranges| - [scanner atEnd] whileFalse: - [| range | - range := map rangeForPC: scanner pc in: method contextIsActiveContext: true. - ((map abstractSourceMap includesKey: scanner abstractPC) - and: [range first ~= 0]) ifTrue: - [ranges nextPut: (source copyFrom: range first to: range last)]. - scanner interpretNextInstructionFor: InstructionClient new]]"! Item was added: + ----- Method: DebuggerMethodMap>>sortedSourceMap (in category 'private') ----- + sortedSourceMap + + ^ sortedSourceMap ifNil: [ + sortedSourceMap := self abstractSourceMap associations + replace: [:each | each copy]; + sort]! Item was added: + ----- Method: DebuggerMethodMap>>sortedSourceMapForMethod: (in category 'source mapping') ----- + sortedSourceMapForMethod: aCompiledMethod + + ^ self sortedSourceMap! Item was changed: ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>abstractSourceMap (in category 'source mapping') ----- abstractSourceMap + + ^ self shouldNotImplement! - self shouldNotImplement! Item was removed: - ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>rangeForPC:in:contextIsActiveContext: (in category 'source mapping') ----- - rangeForPC: contextsConcretePC in: method contextIsActiveContext: contextIsActiveContext - "Answer the indices in the source code for the supplied pc. - If the context is the actve context (is at the hot end of the stack) - then its pc is the current pc. But if the context isn't, because it is - suspended sending a message, then its current pc is the previous pc." - - | pc i end mapForMethod sortedMap | - pc := method abstractPCForConcretePC: (contextIsActiveContext - ifTrue: [contextsConcretePC] - ifFalse: [(method pcPreviousTo: contextsConcretePC) - ifNotNil: [:prevpc| prevpc] - ifNil: [contextsConcretePC]]). - ((mapForMethod := self abstractSourceMapForMethod: method) includesKey: pc) ifTrue: - [^mapForMethod at: pc]. - sortedSourceMap ifNil: - [sortedSourceMap := IdentityDictionary new]. - sortedMap := sortedSourceMap - at: method - ifAbsentPut: [mapForMethod associations - replace: [ :each | each copy ]; - sort]. - sortedMap isEmpty ifTrue: [^1 to: 0]. - i := sortedMap findNearbyBinaryIndex: [:assoc| pc - assoc key]. - i < 1 ifTrue: [^1 to: 0]. - i > sortedMap size ifTrue: - [end := sortedMap inject: 0 into: - [:prev :this | prev max: this value last]. - ^end+1 to: end]. - ^(sortedMap at: i) value - - "| method source scanner map | - method := DebuggerMethodMapForFullBlockCompiledMethods compiledMethodAt: #rangeForPC:in:contextIsActiveContext:. - source := method getSourceFromFile asString. - scanner := InstructionStream on: method. - map := method debuggerMap. - Array streamContents: - [:ranges| - [scanner atEnd] whileFalse: - [| range | - range := map rangeForPC: scanner pc in: method contextIsActiveContext: true. - ((map abstractSourceMap includesKey: scanner abstractPC) - and: [range first ~= 0]) ifTrue: - [ranges nextPut: (source copyFrom: range first to: range last)]. - scanner interpretNextInstructionFor: InstructionClient new]]"! Item was added: + ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>sortedSourceMap (in category 'source mapping') ----- + sortedSourceMap + + ^ self shouldNotImplement! Item was added: + ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>sortedSourceMapForMethod: (in category 'source mapping') ----- + sortedSourceMapForMethod: method + + sortedSourceMap ifNil: [ + sortedSourceMap := IdentityDictionary new]. + ^ sortedSourceMap + at: method + ifAbsentPut: [(self abstractSourceMapForMethod: method) associations + replace: [ :each | each copy ]; + sort]!

4 6

The Inbox: ToolBuilder-Kernel-ct.135.mcz
by commits＠source.squeak.org 01 Oct '20

01 Oct '20

Christoph Thiede uploaded a new version of ToolBuilder-Kernel to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-ct.135.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-ct.135 Author: ct Time: 24 January 2020, 6:34:43.604574 pm UUID: 3ec2613e-56d3-2d41-b5c3-799a66a986e9 Ancestors: ToolBuilder-Kernel-mt.134 Provides fallback implementations for some UIManager messages =============== Diff against ToolBuilder-Kernel-mt.134 =============== Item was changed: ----- Method: UIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString + "Choose an item from the given list. Answer the corresponding value." + | result | + result := self chooseFrom: labelList lines: linesArray title: aString. + (result isNil or: [result isZero]) ifTrue: [^ nil]. + ^ valueList at: result! - "Choose an item from the given list. Answer the selected item." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock + "Put up a yes/no/cancel menu with caption aString. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString. Answer true if - the response is yes, false if no. If cancel is chosen, evaluate - cancelBlock. This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel:title: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock title: titleString + "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString title: titleString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. - Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. - This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>request:initialAnswer:centerAt: (in category 'ui requests - text') ----- request: queryString initialAnswer: defaultAnswer centerAt: aPoint + "Create an instance of me whose question is queryString with the given initial answer. Invoke it centered at the given point, and answer the string the user accepts. Answer the empty string if the user cancels." - "Create an instance of me whose question is queryString with the given - initial answer. Invoke it centered at the given point, and answer the - string the user accepts. Answer the empty string if the user cancels." + ^ self request: queryString initialAnswer: defaultAnswer! - ^self subclassResponsibility!

3 3

Looking to build a WeatherStation for my sailboat
by Robert Withers 30 Sep '20

30 Sep '20

I finally got my sailboat! A long-term dream of mine, a bucket list item! I bought her last week and I leave Thursday with my mate Speedy, to sail her down from CT to NC. I will rename her SV Slosh outta Oriental, NC. WOOT! WOOT! WOOT! Here are the rest of the pics: https://www.dropbox.com/sh/3p9xc4q4ltydhjg/AABes9TP5uIXgs0Frto9d67Oa?dl=0. In thinking about her capabilities, on the water, I will always be curious about the weather. Tim, your WeatherStation sprung immediately to mind. I found several websites, I am perusing, but I am a little lost on which hardware to get and bringing her up. [1][2][3]. Am I supposed to buy the OurWeather device? The plot and rotary dial displays are AWESOME! I'd love to have a rotary dial for both the barometer, as you have shown, as well as the anemometer. Perhaps on a waterproof display at the helm...that would be good. This would be perfect for my Yawl, especially the anemometer and barometer measurements. I have 12v DC power. TIm, would you guide me to getting it setup? I would greatly appreciate your mentoring me a little. For this trip I have until Thursday, to make it happen, so it is a bit of a rush to accomplish this. [1] WeatherStation - https://wiki.squeak.org/squeak/6573 [2] Weather Station at SqueakSource - http://www.squeaksource.com/WeatherStation.html [3] OurWeather - https://shop.switchdoc.com/products/ourweather-complete-weather-kit -- K, r

3 7

The Inbox: Morphic-ct.1689.mcz
by commits＠source.squeak.org 30 Sep '20

30 Sep '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1689.mcz ==================== Summary ==================== Name: Morphic-ct.1689 Author: ct Time: 30 September 2020, 8:23:24.908605 pm UUID: d37597bc-aeb8-354c-8500-bb8e4b5f5373 Ancestors: Morphic-eem.1686 If the label in a button is truncated, use it as fallback balloon text. Also speeds up drawing logic a little bit (but I did not measure the impact). Snippets to quickly try out: (PluggableButtonMorphPlus on: PluggableTextMorphPlus new getState: #isNil action: #halt label: #yourself) openInHand (PluggableButtonMorphPlus on: 'foo\bar' withCRs getState: #isNil action: #halt label: #yourself) openInHand Resize and hover them. Originally inspired by this problem: http://forum.world.st/The-Inbox-Morphic-ct-1634-mcz-td5112623.html#a5112644… =============== Diff against Morphic-eem.1686 =============== Item was changed: Morph subclass: #PluggableButtonMorph + instanceVariableNames: 'model label font getStateSelector actionSelector getLabelSelector getMenuSelector shortcutCharacter askBeforeChanging triggerOnMouseDown offColor onColor feedbackColor showSelectionFeedback allButtons arguments argumentsProvider argumentsSelector style hoverColor borderColor textColor labelOffset wantsGradient truncateLabel' - instanceVariableNames: 'model label font getStateSelector actionSelector getLabelSelector getMenuSelector shortcutCharacter askBeforeChanging triggerOnMouseDown offColor onColor feedbackColor showSelectionFeedback allButtons arguments argumentsProvider argumentsSelector style hoverColor borderColor textColor labelOffset wantsGradient' classVariableNames: 'GradientButton RoundedButtonCorners' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'! !PluggableButtonMorph commentStamp: '<historical>' prior: 0! A PluggableButtonMorph is a combination of an indicator for a boolean value stored in its model and an action button. The action of a button is often, but not always, to toggle the boolean value that it shows. Its pluggable selectors are: getStateSelector fetch a boolean value from the model actionSelector invoke this button's action on the model getLabelSelector fetch this button's lable from the model getMenuSelector fetch a pop-up menu for this button from the model Any of the above selectors can be nil, meaning that the model does not supply behavior for the given action, and the default behavior should be used. For example, if getStateSelector is nil, then this button shows the state of a read-only boolean that is always false. The model informs its view(s) of changes by sending #changed: to itself with getStateSelector as a parameter. The view tells the model when the button is pressed by sending actionSelector. If the actionSelector takes one or more arguments, then the following are relevant: arguments A list of arguments to provide when the actionSelector is called. argumentsProvider The object that is sent the argumentSelector to obtain arguments, if dynamic argumentsSelector The message sent to the argumentProvider to obtain the arguments. Options: askBeforeChanging have model ask user before allowing a change that could lose edits triggerOnMouseDown do this button's action on mouse down (vs. up) transition shortcutCharacter a place to record an optional shortcut key ! Item was added: + ----- Method: PluggableButtonMorph>>balloonText (in category 'accessing') ----- + balloonText + + | labelToUse | + super balloonText ifNotNil: [:text | ^ text]. + (truncateLabel ifNil: [false]) ifFalse: [^ nil]. + + labelToUse := self label. + ^ labelToUse isMorph + ifTrue: [Character startOfHeader asText + addAttribute: labelToUse asTextAnchor; + yourself] + ifFalse: [labelToUse asString]! Item was changed: ----- Method: PluggableButtonMorph>>drawLabelOn: (in category 'drawing') ----- drawLabelOn: aCanvas | fontToUse labelToUse colorToUse labelWidth layoutBounds drawBlock | self label ifNil: [^ self]. + - layoutBounds := self layoutBounds. labelToUse := self label asString. fontToUse := self font. colorToUse := self textColorToUse. + labelWidth := fontToUse widthOfString: labelToUse. + truncateLabel := labelWidth > layoutBounds width. + "Support very narrow buttons. Shrink text to monogram then." ((layoutBounds width < self labelShrinkThreshold and: [self hResizing ~~ #shrinkWrap]) and: [labelToUse size > 3]) ifTrue: [ labelToUse := labelToUse first asString. "Show first character only." + fontToUse := fontToUse emphasized: (TextEmphasis bold) emphasisCode. + labelWidth := fontToUse widthOfString: labelToUse]. - fontToUse := fontToUse emphasized: (TextEmphasis bold) emphasisCode]. - labelWidth := fontToUse widthOfString: labelToUse. - drawBlock := [:c | c drawString: labelToUse at: (layoutBounds center x - (labelWidth // 2) max: (layoutBounds left)) @ (layoutBounds center y - (fontToUse height // 2)) font: fontToUse color: colorToUse]. + - self clipSubmorphs ifTrue: [aCanvas clipBy: layoutBounds during: drawBlock] + ifFalse: [drawBlock value: aCanvas].! - ifFalse: [drawBlock value: aCanvas]! Item was changed: ----- Method: PluggableButtonMorph>>drawMorphLabelOn: (in category 'drawing') ----- drawMorphLabelOn: aCanvas + | layoutBounds labelToUse | - | layoutBounds | layoutBounds := self layoutBounds. + labelToUse := self label. - - self label privateFullMoveBy: (layoutBounds center - self label center). + truncateLabel := (labelToUse extent <= layoutBounds extent) not. + labelToUse privateFullMoveBy: layoutBounds center - labelToUse center. + self clipSubmorphs ifTrue: [aCanvas clipBy: layoutBounds + during: [:c | c fullDrawMorph: labelToUse]] + ifFalse: [aCanvas fullDrawMorph: labelToUse].! - during: [:c | c fullDrawMorph: self label]] - ifFalse: [aCanvas fullDrawMorph: self label].! Item was changed: ----- Method: PluggableButtonMorph>>veryDeepInner: (in category 'copying') ----- veryDeepInner: deepCopier "Copy all of my instance variables. Some need to be not copied at all, but shared. Warning!!!! Every instance variable defined in this class must be handled. We must also implement veryDeepFixupWith:. See DeepCopier class comment." super veryDeepInner: deepCopier. "model := model. Weakly copied" label := label veryDeepCopyWith: deepCopier. "getStateSelector := getStateSelector. a Symbol" "actionSelector := actionSelector. a Symbol" "getLabelSelector := getLabelSelector. a Symbol" "getMenuSelector := getMenuSelector. a Symbol" shortcutCharacter := shortcutCharacter veryDeepCopyWith: deepCopier. askBeforeChanging := askBeforeChanging veryDeepCopyWith: deepCopier. triggerOnMouseDown := triggerOnMouseDown veryDeepCopyWith: deepCopier. offColor := offColor veryDeepCopyWith: deepCopier. onColor := onColor veryDeepCopyWith: deepCopier. feedbackColor := feedbackColor veryDeepCopyWith: deepCopier. hoverColor := hoverColor veryDeepCopyWith: deepCopier. borderColor := borderColor veryDeepCopyWith: deepCopier. textColor := textColor veryDeepCopyWith: deepCopier. labelOffset := labelOffset veryDeepCopyWith: deepCopier. allButtons := nil. "a cache" arguments := arguments veryDeepCopyWith: deepCopier. argumentsProvider := argumentsProvider veryDeepCopyWith: deepCopier. "argumentsSelector := argumentsSelector. a Symbol" + style := style. "a Symbol" + "truncateLabel := truncateLabel."! - style := style. "a Symbol"!

1 0

Question about RemoteTask
by Chris Muller 29 Sep '20

29 Sep '20

Hi Dave, I saw your RemoteTask the other day and had a quick question about it. Do you see any pitfalls doing operations that require or provide sensitive security key information as input, or output. As an analogy, I've been using my own convenience method on OSProcess to give me a way get Linux command output into the image, but it does so by simply redirecting the command's output to a file, reading that file into an in-image String, then deleting the file. But that's not something I would want to use if it involved passing a password, for example. My hope is RemoteTask operates all in memory and does not utilize the hard drive to accomplish that. Thanks, Chris On Sat, Sep 26, 2020 at 7:06 PM David T. Lewis <lewis(a)mail.msen.com> wrote: > > On Sat, Sep 26, 2020 at 03:20:10PM -0700, tim Rowledge wrote: > > > > And multi-core? Well yes I suppose. Except that one can very easily > spawn multiple running images using Dave Lewis' OSProcess package, > including in ways that do some work and return the results.The spawning > takes very little time; for example on said Pi4 it takes 39mS to do > > UnixProcess forkHeadlessSqueakAndDoThenQuit: [UnixProcess helloWorld] > > <OT> > Or the somewhat more interesting example: > > RemoteTask do: [3 + 4] ==> 7 > > which completes in on the order of 10ms on my PC, and hopefully not too > much worse on Pi4. The [3 + 4] block is evaluated in a spawned image with > results returned to the parent image. > </OT> > > Dave > > >

2 2

The Inbox: Morphic-ct.1683.mcz
by commits＠source.squeak.org 29 Sep '20

29 Sep '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1683.mcz ==================== Summary ==================== Name: Morphic-ct.1683 Author: ct Time: 29 September 2020, 3:45:11.774971 pm UUID: fb544fe9-159d-8443-8946-e2651331750f Ancestors: Morphic-dtl.1680 Fixes an abandoning bug in menu items. When clicking on a menu item that has a submenu, the menu should not disappear! In addition, do not deselect a menu item once it is clicked, which is not important for regular menus but looks confusing when the menu is configured to #stayUp. =============== Diff against Morphic-dtl.1680 =============== Item was changed: ----- Method: MenuItemMorph>>invokeWithEvent: (in category 'events') ----- invokeWithEvent: evt "Perform the action associated with the given menu item." self isEnabled ifFalse: [^ self]. + (owner notNil and: [self isStayUpItem not] and: [self hasSubMenu not]) ifTrue: [ - (owner notNil and: [self isStayUpItem not]) ifTrue: [ self flag: #workAround. "The tile system invokes menus straightforwardly so the menu might not be in the world." self world ifNotNil: [:world | owner deleteIfPopUp: evt. "Repair damage before invoking the action for better feedback" world displayWorldSafely]]. selector ifNil: [^ self]. Cursor normal showWhile: [ "show cursor in case item opens a new MVC window" selector numArgs isZero ifTrue: [target perform: selector] ifFalse: [target perform: selector withArguments: ( selector numArgs = arguments size ifTrue: [arguments] ifFalse: [arguments copyWith: evt] )] ].! Item was changed: ----- Method: MenuItemMorph>>mouseUp: (in category 'events') ----- mouseUp: evt "Handle a mouse up event. Menu items get activated when the mouse is over them. Do nothing if we're not in a 'valid menu transition', meaning that the current hand focus must be aimed at the owning menu." + - evt hand mouseFocus == owner ifFalse: [ ^self ]. self contentString ifNotNil: [ self contents: self contentString withMarkers: true inverse: true. self refreshWorld. (Delay forMilliseconds: 200) wait ]. + "self deselect: evt." + self invokeWithEvent: evt. ! - self deselect: evt. - self invokeWithEvent: evt. - !

1 0

The Inbox: Collections-ct.914.mcz
by commits＠source.squeak.org 29 Sep '20

29 Sep '20

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.914.mcz ==================== Summary ==================== Name: Collections-ct.914 Author: ct Time: 29 September 2020, 3:15:58.543807 pm UUID: 6bb73b4a-58ae-be43-a0f4-fb265b32b30f Ancestors: Collections-eem.912 Proposal: Supply start and stop of attributes in Text >> #[removeAttributesThat:][replaceAttributesThat:][by:]. For example, this can be useful for retrieving the part of a text that belongs to an attribute before doing filtering the attribute in some way. =============== Diff against Collections-eem.912 =============== Item was changed: ----- Method: Text>>removeAttributesThat:replaceAttributesThat:by: (in category 'converting') ----- removeAttributesThat: removalBlock replaceAttributesThat: replaceBlock by: convertBlock "Enumerate all attributes in the receiver. Remove those passing removalBlock and replace those passing replaceBlock after converting it through convertBlock" | added removed | "Deliberately optimized for the no-op default." added := removed := nil. runs withStartStopAndValueDo: [ :start :stop :attribs | attribs do: [ :attrib | | new | + (removalBlock cull: attrib cull: start cull: stop) ifTrue:[ - (removalBlock value: attrib) ifTrue:[ removed ifNil:[removed := WriteStream on: #()]. removed nextPut: {start. stop. attrib}. ] ifFalse:[ + (replaceBlock cull: attrib cull: start cull: stop) ifTrue:[ - (replaceBlock value: attrib) ifTrue:[ removed ifNil:[removed := WriteStream on: #()]. removed nextPut: {start. stop. attrib}. + new := convertBlock cull: attrib cull: start cull: stop. - new := convertBlock value: attrib. added ifNil:[added := WriteStream on: #()]. added nextPut: {start. stop. new}. ]. ]. ]. ]. (added == nil and:[removed == nil]) ifTrue:[^self]. "otherwise do the real work" removed ifNotNil:[removed contents do:[:spec| self removeAttribute: spec last from: spec first to: spec second]]. added ifNotNil:[added contents do:[:spec| self addAttribute: spec last from: spec first to: spec second]].!

1 0

The Inbox: Collections-ct.913.mcz
by commits＠source.squeak.org 29 Sep '20

29 Sep '20

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.913.mcz ==================== Summary ==================== Name: Collections-ct.913 Author: ct Time: 29 September 2020, 3:05:50.763807 pm UUID: a7262c7e-0824-c543-bb32-2905e45eb317 Ancestors: Collections-eem.912 Adds convenience method for converting text to HTML, #printHtmlOn:breakLines:. =============== Diff against Collections-eem.912 =============== Item was changed: ----- Method: Text>>printHtmlOn: (in category 'html') ----- + printHtmlOn: aStream + + ^ self + printHtmlOn: aStream + breakLines: true! - printHtmlOn: aStream - - (HtmlReadWriter on: aStream) - nextPutText: self.! Item was added: + ----- Method: Text>>printHtmlOn:breakLines: (in category 'html') ----- + printHtmlOn: aStream breakLines: aBoolean + + (HtmlReadWriter on: aStream) + breakLines: aBoolean; + nextPutText: self.!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
27
Older →

Jump to page: