Squeak-dev January 2021

squeak-dev@lists.squeakfoundation.org

38 participants
171 discussions

The Trunk: Tools-tpr.1008.mcz
by commits＠source.squeak.org 22 Jun '22

22 Jun '22

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.1008.mcz ==================== Summary ==================== Name: Tools-tpr.1008 Author: tpr Time: 25 October 2020, 5:52:09.007789 pm UUID: 2ebe15ce-0c25-4b8d-b993-f1c51203dee5 Ancestors: Tools-tpr.1003, Tools-mt.1007 Rework the window label handing of MessageSet/Trace to be a bit more accurate, and to work within the normal style of labels. Instead of assuming the size of the list passed to the MessageSet/Trace is correct, derive it from the post-processing list. We process the list to remove duplicates, which e.g. the #allUnimplementedCalls method produces. This required adding an instvar to M-Set, removing one from M-Trace, setting the new one properly, dumping some dodgy code that used to half-assedly derive the old one, use the proper #changed: #windowTitle to, y'know, change the title, and some faffing with the messageList. As a result we are better placed to make further improvements if/when we develop a way to correctly hightlight multi-part keywords (or indeed, multiple messages) within a single method, which would greatly improve many browsers. This benefits from being accompanied by the single-method change in the System-tpr.1181 package =============== Diff against Tools-mt.1007 =============== Item was changed: CodeHolder subclass: #MessageSet + instanceVariableNames: 'growable messageList messageListFormatted autoSelectString messageListIndex editSelection windowLabel' - instanceVariableNames: 'growable messageList messageListFormatted autoSelectString messageListIndex editSelection' classVariableNames: 'UseUnifiedMessageLabels' poolDictionaries: '' category: 'Tools-Browser'! !MessageSet commentStamp: '<historical>' prior: 0! I represent a query path of the retrieval result of making a query about methods in the system. The result is a set of methods, denoted by a message selector and the class in which the method was found. As a StringHolder, the string I represent is the source code of the currently selected method. I am typically viewed in a Message Set Browser consisting of a MessageListView and a BrowserCodeView.! Item was changed: ----- Method: MessageSet class>>openMessageList:name:autoSelect: (in category 'instance creation') ----- openMessageList: messageList name: labelString autoSelect: autoSelectString "Open a system view for a MessageSet on messageList. + The labelString is passed to the model to use as a base label, depending on the selection state" - 1/24/96 sw: the there-are-no msg now supplied by my sender" | messageSet | messageSet := self messageList: messageList. + messageSet + autoSelectString: autoSelectString; + setInitialLabel: labelString. + ^ToolBuilder open: messageSet! - messageSet autoSelectString: autoSelectString. - ^ToolBuilder open: messageSet label: labelString! Item was changed: ----- Method: MessageSet>>adjustWindowTitleAfterFiltering (in category 'private') ----- adjustWindowTitleAfterFiltering + "Set the title of the receiver's window, if any, to reflect the just-completed filtering. Avoid re-doing it if fitering is re-done" - "Set the title of the receiver's window, if any, to reflect the just-completed filtering" + (windowLabel endsWith: 'Filtered') + ifFalse: [windowLabel := windowLabel , ' Filtered'. + self changed: #windowTitle]! - | aWindow existingLabel newLabel | - - (aWindow := self containingWindow) ifNil: [^ self]. - (existingLabel := aWindow label) isEmptyOrNil ifTrue: [^ self]. - (((existingLabel size < 3) or: [existingLabel last ~~ $]]) or: [(existingLabel at: (existingLabel size - 1)) isDigit not]) ifTrue: [^ self]. - existingLabel size to: 1 by: -1 do: - [:anIndex | ((existingLabel at: anIndex) == $[) ifTrue: - [newLabel := (existingLabel copyFrom: 1 to: anIndex), - 'Filtered: ', - messageList size printString, - ']'. - ^ aWindow setLabel: newLabel]] - - - ! Item was changed: ----- Method: MessageSet>>initializeMessageList: (in category 'private') ----- initializeMessageList: anArray "Initialize my messageList from the given list of MethodReference or string objects. NB: special handling for uniclasses. Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code." + messageList := Set new. - messageList := OrderedCollection new. anArray do: [:each | each isMethodReference + ifTrue: [messageList add: each] - ifTrue: [messageList addLast: each] ifFalse: [ MessageSet parse: each toClassAndSelector: + [ : class : sel | class ifNotNil: [ messageList add: (MethodReference class: class selector: sel) ] ] ] ]. + messageList := messageList asOrderedCollection sort. - [ : class : sel | class ifNotNil: [ messageList addLast: (MethodReference class: class selector: sel) ] ] ] ]. "Unify labels if wanted." self class useUnifiedMessageLabels ifTrue: [ messageList withIndexDo: [ : each : index | | cls | cls := each actualClass. each stringVersion: (self indentionPrefixOfSize: (self indentionsIn: each stringVersion)) , (cls ifNil: [each asString] ifNotNil: [cls isUniClass ifTrue: [cls typicalInstanceName, ' ', each selector] ifFalse: [ cls name , ' ' , each selector , ' {' , ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' , ' {', cls category, '}' ] ]) ] ]. messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1]. contents := String empty! Item was changed: ----- Method: MessageSet>>messageListIndex: (in category 'message list') ----- messageListIndex: anInteger + "Set the index of the selected item to be anInteger. + Update the message list morph, the text edit morph and the assorted buttons" - "Set the index of the selected item to be anInteger." messageListIndex := anInteger. contents := messageListIndex ~= 0 ifTrue: [self selectedMessage] ifFalse: ['']. self changed: #messageListIndex. "update my selection" self editSelection: #editMessage. self contentsChanged. (messageListIndex ~= 0 and: [ autoSelectString notNil and: [ self contents notEmpty ] ]) ifTrue: [ self changed: #autoSelect ]. self decorateButtons ! Item was added: + ----- Method: MessageSet>>setInitialLabel: (in category 'accessing') ----- + setInitialLabel: aString + "set the base label for the window, as returned by #windowTitle" + + windowLabel := aString! Item was added: + ----- Method: MessageSet>>windowTitle (in category 'user interface') ----- + windowTitle + "just return the basic label for now" + + ^windowLabel! Item was changed: MessageSet subclass: #MessageTrace + instanceVariableNames: 'autoSelectStrings messageSelections anchorIndex' - instanceVariableNames: 'autoSelectStrings messageSelections anchorIndex defaultSelectString' classVariableNames: '' poolDictionaries: '' category: 'Tools-Browser'! !MessageTrace commentStamp: 'cmm 3/2/2010 20:26' prior: 0! A MessageTrace is a MessageSet allowing efficient sender/implementor message following. With implementors indented below, and senders outdended above, message flow is succinctly expressed, hierarchically. My autoSelectStrings and messageSelections are Arrays of Booleans, parallel to my messageList. Each boolean indicates whether that message is selected. Each autoSelectStrings indicates which string should be highlighted in the code for each method in my messageList.! Item was changed: ----- Method: MessageTrace>>browseAllImplementorsOf: (in category 'actions') ----- browseAllImplementorsOf: selectorSymbol | selectorToBrowse | selectorToBrowse := self selection ifNil: [ selectorSymbol ] + ifNotNil: [ self getImplementorNamed: selectorSymbol asSymbol "since we can get passed literals"]. - ifNotNil: [ self getImplementorNamed: selectorSymbol ]. (self hasUnacceptedEdits or: [ Preferences traceMessages not ]) ifTrue: [ super browseAllImplementorsOf: selectorToBrowse ] ifFalse: [ self addChildMethodsNamed: selectorToBrowse ] ! Item was changed: ----- Method: MessageTrace>>initializeMessageList: (in category 'private initializing') ----- initializeMessageList: anArray - messageSelections := (Array new: anArray size withAll: false) asOrderedCollection. super initializeMessageList: anArray. + messageSelections := (Array new: messageList size withAll: false) asOrderedCollection. self messageAt: messageListIndex beSelected: true. "autoSelectStrings is initialized right after this method, in autoSelectString:" ! Item was changed: ----- Method: MessageTrace>>messageListIndex: (in category 'actions') ----- messageListIndex: anInteger + "Set the index of the selected item to be anInteger. + Find the relevant auto select string to use, do my superclass' work and update the window title" + autoSelectStrings ifNotEmpty: [ autoSelectString := anInteger = 0 + ifTrue: [ "clear the autoSelectString" + String empty ] + ifFalse: [autoSelectStrings at: anInteger] + ]. + + anInteger > 0 ifTrue: [ self + messageAt: anInteger + beSelected: true + ]. + super messageListIndex: anInteger. + self changed: #windowTitle - ifTrue: - [ defaultSelectString ifNotNil: [:default| self containingWindow setLabel: default]. - "clear the autoSelectString" - '' ] - ifFalse: - [ messageListIndex := anInteger. - "setting the window label, below, can't wait for this.." - self containingWindow setLabel: (self windowLabelAt: anInteger). - "work out the string to ask the text view to pre-select. We should do better than this; after all the debugger does" - (autoSelectStrings at: anInteger)] ]. - anInteger > 0 ifTrue: - [ self - messageAt: anInteger - beSelected: true ]. - super messageListIndex: anInteger ! Item was changed: ----- Method: MessageTrace>>windowLabelAt: (in category 'private accessing') ----- windowLabelAt: anInteger + "return a suitable window label when there is an actual list item selected; work out what it should be based upon the array of autoSelectStrings or the current selection" + ^(autoSelectStrings at: anInteger) + ifNil: [ 'Implementors of ', - | str | - defaultSelectString ifNil: - [defaultSelectString := self containingWindow label]. - ^(str := autoSelectStrings at: anInteger) - ifNil: - [ 'Implementors of ', (self class parse: self selection + toClassAndSelector: [ :class :selector | selector ]) + ] + ifNotNil: [:str| 'Senders of ', str ] - toClassAndSelector: [ :class :selector | selector ]) ] - ifNotNil: - [ 'Senders of ', str ] ! Item was added: + ----- Method: MessageTrace>>windowTitle (in category 'building') ----- + windowTitle + "set the window label to suit the selection state; + if no selection, use saved widow label and add the number of items in the messageList + if something is selected, use the relevant string provided by windowLabelAt: which considers the index" + + ^messageListIndex = 0 + ifTrue:[String streamContents: [:str| str nextPutAll: windowLabel; + space; + nextPut: $[; + nextPutAll: messageList size asString; + nextPut: $] + ] + ] + ifFalse: [self windowLabelAt: messageListIndex]!

3 5

Unicode
by Thiede, Christoph 15 Jun '22

15 Jun '22

Hi all! :-) After some recent fun with the Unicode class, I found out that its data is quite out of date (for example, the comments do not even "know" that code points can be longer than 4 bytes. Younger characters such as 😺❤🤓 are not categorized correctly, etc. ...). Luckily, there is already some logic to fetch the latest data from www.unicode.org<http://www.unicode.org>. I'm currently reworking this logic because it's not completely automated yet and has some slips, but so long, I have one general question for you: At the moment, we have 30 class variables each for one Unicode category number. These class vars map in alphabetical order to the integers from 0 to: 29. Is this tedious structure really necessary? For different purposes, I would like to get the category name of a specific code point from a client. The current design makes this impossible without writing additional mappings. Tl;dr: I would like to propose to drop these class variables and use Symbols instead. They are comparable like integers, and as they are flyweights, this should not be a performance issue either. Of course, #generalCategoryOf: will have to keep returning numbers, but we could deprecate it and use a new #generalTagOf: in the future. Furthermore, this would also allow us to deal with later added category names (though I don't know whether this will ever happen). Examples: Unicode generalTagOf: $a asUnicode. "#Ll" Unicode class >> isLetterCode: charCode ^ (self generalTagOf: charCode) first = $L Unicode class >> isAlphaNumericCode: charCode | tag| ^ (tag := self generalCategoryOf: charCode) first = $L or: [tag = #Nd] How do you think about this proposal? Please let me know and I will go ahead! :D Best, Christoph

9 26

The Inbox: Compiler-ct.452.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-ct.452.mcz ==================== Summary ==================== Name: Compiler-ct.452 Author: ct Time: 13 November 2020, 7:07:30.464415 pm UUID: a40e8327-95c2-f448-8edd-0aa087a5c930 Ancestors: Compiler-eem.451 Reworks public Compiler interface and documentation: - Parser: Do not use #fail in the event of an internal error unless compilation is interactive. This was a single precedent case. - Correct description of compilation error handling: failBlock is *not* evaluated any longer if the requestor is nil since I eliminated the above precedent (I validated that twice). Mention SyntaxErrorNotification explicitly instead of referring to the ToolSet-specific SyntaxError tool. - Provide new convenience selectors #compileNoPattern: and #compileNoPattern:in: on Compiler instance side. - Unify method comment format and phrases. - Ban ST80-specific term "controller" from the argument names. =============== Diff against Compiler-eem.451 =============== Item was changed: ----- Method: Compiler class>>evaluate: (in category 'evaluating') ----- evaluate: textOrString + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. + Compilation is carried out with respect to nil, i.e., no object, and the invocation is not logged." - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. - Compilation is carried out with respect to nil, i.e., no object, and the - invocation is not logged." ^self evaluate: textOrString for: nil! Item was changed: ----- Method: Compiler class>>evaluate:for: (in category 'evaluating') ----- evaluate: textOrString for: anObject + "See Compiler|evaluate:for:notifying:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See Compiler|evaluate:for:notifying:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil! Item was changed: ----- Method: Compiler class>>evaluate:for:logged: (in category 'evaluating logged') ----- evaluate: textOrString for: anObject logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil logged: logFlag! Item was changed: ----- Method: Compiler class>>evaluate:for:notifying: (in category 'evaluating') ----- + evaluate: textOrString for: anObject notifying: requestor + "Compile and execute the argument, textOrString with respect to the class of anObject. If a compilation error occurs, use requestor for interactive error correction." - evaluate: textOrString for: anObject notifying: aController - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController." ^ self new evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil]! Item was changed: ----- Method: Compiler class>>evaluate:for:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString for: anObject notifying: requestor logged: logFlag + "Compile and execute the argument, textOrString with respect to the class of anObject. + If a compilation error occurs, use requestor for interactive error correction. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - evaluate: textOrString for: anObject notifying: aController logged: logFlag - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self new evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag.! Item was changed: ----- Method: Compiler class>>evaluate:in:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString in: anEnvironment notifying: requestor logged: logFlag - evaluate: textOrString in: anEnvironment notifying: aController logged: logFlag "Compile and execute the argument, textOrString in anEnvironment. + If a compilation error occurs, use requestor for interactive error correction. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self new evaluate: textOrString in: anEnvironment + notifying: requestor - notifying: aController logged: logFlag.! Item was changed: ----- Method: Compiler class>>evaluate:logged: (in category 'evaluating logged') ----- evaluate: textOrString logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is raised rather than notifying any requestor. - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. Compilation is carried out with respect to nil, i.e., no object." ^self evaluate: textOrString for: nil logged: logFlag! Item was changed: ----- Method: Compiler class>>evaluate:notifying: (in category 'evaluating') ----- + evaluate: textOrString notifying: requestor + "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController - "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor! - ^self evaluate: textOrString for: nil notifying: aController! Item was changed: ----- Method: Compiler class>>evaluate:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString notifying: requestor logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController logged: logFlag - "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor logged: logFlag! - ^self evaluate: textOrString for: nil notifying: aController logged: logFlag! Item was changed: ----- Method: Compiler class>>format:in:notifying: (in category 'evaluating') ----- + format: textOrStream in: aClass notifying: requestor + ^self new format: textOrStream in: aClass notifying: requestor! - format: textOrStream in: aClass notifying: aRequestor - ^self new format: textOrStream in: aClass notifying: aRequestor! Item was changed: ----- Method: Compiler class>>format:in:notifying:decorated: (in category 'evaluating') ----- + format: textOrStream in: aClass notifying: requestor decorated: aBoolean + ^self new format: textOrStream in: aClass notifying: requestor decorated: aBoolean! - format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean - ^self new format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean! Item was changed: ----- Method: Compiler>>compile:ifFail: (in category 'public access') ----- compile: aCue ifFail: failBlock + "Answer a MethodNode. + If the cue requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the class specified by the context." - "Answer a MethodNode. If the MethodNode can not be created, notify - the requestor in the contxt. If the requestor is nil, evaluate failBlock - instead. The MethodNode is the root of a parse tree. It can be told - to generate a CompiledMethod to be installed in the method dictionary - of the class specified by the context." ^self compileCue: aCue noPattern: false + ifFail: failBlock! - ifFail: failBlock ! Item was changed: ----- Method: Compiler>>compile:in:environment:notifying:ifFail: (in category 'public access') ----- + compile: textOrStream in: aClass environment: anEnvironment notifying: requestor ifFail: failBlock + "Answer a MethodNode for the argument, textOrStream. + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the argument, aClass." - compile: textOrStream in: aClass environment: anEnvironment notifying: aRequestor ifFail: failBlock - "Answer a MethodNode for the argument, textOrStream. If the - MethodNode can not be created, notify the argument, aRequestor; if - aRequestor is nil, evaluate failBlock instead. The MethodNode is the root - of a parse tree. It can be told to generate a CompiledMethod to be - installed in the method dictionary of the argument, aClass." ^self compileCue: (CompilationCue source: textOrStream class: aClass environment: anEnvironment + requestor: requestor) - requestor: aRequestor) noPattern: false + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compile:in:notifying:ifFail: (in category 'public access') ----- + compile: textOrStream in: aClass notifying: requestor ifFail: failBlock + "Answer a MethodNode for the argument, textOrStream. + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the argument, aClass." - compile: textOrStream in: aClass notifying: aRequestor ifFail: failBlock - "Answer a MethodNode for the argument, textOrStream. If the - MethodNode can not be created, notify the argument, aRequestor; if - aRequestor is nil, evaluate failBlock instead. The MethodNode is the root - of a parse tree. It can be told to generate a CompiledMethod to be - installed in the method dictionary of the argument, aClass." ^self compileCue: (CompilationCue source: textOrStream class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: false + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileCue:noPattern:ifFail: (in category 'private') ----- compileCue: aCue noPattern: aBoolean ifFail: failBlock "Answer a MethodNode corresponding to cue source. + If the cue requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod: - If the MethodNode can not be created, notify the cue requestor. - If the cue requestor is nil, evaluate failBlock instead. - The MethodNode is the root of a parse tree. - It can be told to generate a CompiledMethod - either to be evaluated in cue context if aBoolean is true, with cue receiver as method receiver, - or to be installed in the method dictionary of the target class specified by the cue if aBoolean is false." + - self setCue: aCue. ^self translateNoPattern: aBoolean ifFail: failBlock! Item was added: + ----- Method: Compiler>>compileNoPattern: (in category 'public access') ----- + compileNoPattern: textOrStream + + ^ self + compileNoPattern: textOrStream + in: nil class! Item was added: + ----- Method: Compiler>>compileNoPattern:in: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass + + ^ self + compileNoPattern: textOrStream + in: aClass + notifying: nil + ifFail: [^ nil]! Item was changed: ----- Method: Compiler>>compileNoPattern:in:context:environment:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass context: aContext environment: anEnvironment notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass context: aContext environment: anEnvironment notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern, and it will be in an explicit environment." ^self compileCue: (CompilationCue source: textOrStream context: aContext class: aClass environment: anEnvironment + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileNoPattern:in:context:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass context: aContext notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass context: aContext notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern." ^self compileCue: (CompilationCue source: textOrStream context: aContext class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileNoPattern:in:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern." ^self compileCue: (CompilationCue source: textOrStream class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compiledMethodFor:in:to:notifying:ifFail: (in category 'public access') ----- + compiledMethodFor: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock + "Compiles the sourceStream into a parse tree, then generates code into a method, and answers it. + If receiver is not nil, then the text can refer to instance variables of that receiver (the Inspector uses this). + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted." - compiledMethodFor: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock - "Compiles the sourceStream into a parse tree, then generates code - into a method, and answers it. If receiver is not nil, then the text can - refer to instance variables of that receiver (the Inspector uses this). - If aContext is not nil, the text can refer to temporaries in that context - (the Debugger uses this). If aRequestor is not nil, then it will receive a - notify:at: message before the attempt to evaluate is aborted." | methodNode method | methodNode := self compileNoPattern: textOrStream in: (self classForReceiver: receiver context: aContext) context: aContext + notifying: requestor - notifying: aRequestor ifFail: [^failBlock value]. method := self interactive ifTrue: [ methodNode generateWithTempNames ] ifFalse: [ methodNode generate ]. ^method! Item was changed: ----- Method: Compiler>>compiledMethodFor:in:to:notifying:ifFail:logged: (in category 'public access logging') ----- + compiledMethodFor: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method, and answers it. + If receiver is not nil, then the text can refer to instance variables of that receiver (the Inspector uses this). + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock after the compilation has been aborted." - compiledMethodFor: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code - into a method, and answers it. If receiver is not nil, then the text can - refer to instance variables of that receiver (the Inspector uses this). - If aContext is not nil, the text can refer to temporaries in that context - (the Debugger uses this). If aRequestor is not nil, then it will receive a - notify:at: message before the attempt to evaluate is aborted." | method | method := self compiledMethodFor: textOrStream in: aContext to: receiver + notifying: requestor - notifying: aRequestor ifFail: [^failBlock value]. logFlag ifTrue: [SystemChangeNotifier uniqueInstance evaluated: cue stringToLog context: aContext]. ^method! Item was changed: ----- Method: Compiler>>evaluate: (in category 'public access') ----- evaluate: textOrString + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. + Compilation is carried out with respect to nil, i.e., no object, and the invocation is not logged." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. - Compilation is carried out with respect to nil, i.e., no object, and the - invocation is not logged." ^self evaluate: textOrString for: nil! Item was changed: ----- Method: Compiler>>evaluate:for: (in category 'public access') ----- evaluate: textOrString for: anObject + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil! Item was changed: ----- Method: Compiler>>evaluate:for:logged: (in category 'public access logging') ----- evaluate: textOrString for: anObject logged: logFlag + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxError is signaled rather than notifying any requestor." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:for:notifying: (in category 'public access') ----- + evaluate: textOrString for: anObject notifying: requestor + "Compile and execute the argument, textOrString with respect to the class of anObject. If a compilation error occurs, use requestor for interactive compilation." - evaluate: textOrString for: anObject notifying: aController - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController." ^ self evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil]! Item was changed: ----- Method: Compiler>>evaluate:for:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString for: anObject notifying: requestor logged: logFlag + "Compile and execute the argument, textOrString with respect to the class of anObject. + If a compilation error occurs, use requestor for interactive compilation. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - evaluate: textOrString for: anObject notifying: aController logged: logFlag - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag.! Item was changed: ----- Method: Compiler>>evaluate:in:environment:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext environment: anEnvironment notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock after the compilation has been aborted. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." - evaluate: textOrStream in: aContext environment: anEnvironment notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: nil class: UndefinedObject environment: anEnvironment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString in: anEnvironment notifying: requestor logged: logFlag - evaluate: textOrString in: anEnvironment notifying: aController logged: logFlag "Compile and execute the argument, textOrString in anEnvironment. + If a compilation error occurs, use requestor for interactive compilation. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^self evaluate: textOrString in: nil environment: anEnvironment + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:to:environment:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext to: receiver environment: anEnvironment notifying: requestor ifFail: failBlock logged: logFlag - evaluate: textOrStream in: aContext to: receiver environment: anEnvironment notifying: aRequestor ifFail: failBlock logged: logFlag "Same as #evaluate:in:to:notifying:ifFail:logged: but with an explicit environment" ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: (self classForReceiver: receiver context: aContext) environment: anEnvironment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:to:notifying:ifFail: (in category 'public access') ----- + evaluate: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive error correction, and evaluate failBlock if the compilation fails. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." + - evaluate: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." - | theClass | theClass := self classForReceiver: receiver context: aContext. ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: theClass environment: theClass environment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock! Item was changed: ----- Method: Compiler>>evaluate:in:to:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock if the compilation fails. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." + - evaluate: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." | theClass | theClass := self classForReceiver: receiver context: aContext. ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: theClass environment: theClass environment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:logged: (in category 'public access logging') ----- evaluate: textOrString logged: logFlag + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. Compilation is carried out with respect to nil, i.e., no object." ^self evaluate: textOrString for: nil logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:notifying: (in category 'public access') ----- + evaluate: textOrString notifying: requestor + "See evaluate:for:notifying:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController - "See evaluate:for:notifying:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor! - ^self evaluate: textOrString for: nil notifying: aController! Item was changed: ----- Method: Compiler>>evaluate:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString notifying: requestor logged: logFlag + "See evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController logged: logFlag - "See evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor logged: logFlag! - ^self evaluate: textOrString for: nil notifying: aController logged: logFlag! Item was changed: ----- Method: Compiler>>format:in:notifying: (in category 'public access') ----- + format: textOrStream in: aClass notifying: requestor + "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions." - format: textOrStream in: aClass notifying: aRequestor - "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions" | aNode | self from: textOrStream class: aClass + notifying: requestor. - notifying: aRequestor. aNode := self formatNoPattern: false ifFail: [^ nil]. - - "aSymbol == #colorPrint ifTrue: - [^aNode asColorizedSmalltalk80Text]." "deprecating #colorPrint in favor of Shout --Ron Spengler" - ^aNode decompileString! Item was changed: ----- Method: Compiler>>format:in:notifying:decorated: (in category 'public access') ----- + format: textOrStream in: aClass notifying: requestor decorated: aBoolean + "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions." + - format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean - "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions" | aNode | self from: textOrStream class: aClass + notifying: requestor. - notifying: aRequestor. aNode := self formatNoPattern: false ifFail: [^ nil]. ^ aBoolean ifTrue: [aNode decompileText] ifFalse: [aNode decompileString]! Item was changed: ----- Method: Compiler>>parse:in:notifying: (in category 'public access') ----- parse: textOrStream in: aClass notifying: req + "Compile the argument, textOrStream, with respect to the class, aClass, and answer the MethodNode that is the root of the resulting parse tree. If an error occurs, use requestor for interactive error handling." - "Compile the argument, textOrStream, with respect to the class, aClass, and - answer the MethodNode that is the root of the resulting parse tree. Notify the - argument, req, if an error occurs. The failBlock is defaulted to an empty block." self from: textOrStream class: aClass notifying: req. ^self parser parseCue: cue noPattern: false ifFail: []! Item was changed: ----- Method: Parser>>notify:at: (in category 'error handling') ----- notify: string at: location | messageText | messageText := '"' , string , ' ->"'. cue requestor isNil ifTrue: [ | notification | (encoder == self or: [encoder isNil]) + ifTrue: [^ self interactive + ifTrue: [self fail] + ifFalse: [self error: 'failure setting up syntax error']]. - ifTrue: [^ self fail "failure setting up syntax error"]. (notification := SyntaxErrorNotification cue: (cue copy source: (source contents asText copyReplaceFrom: location to: location - 1 with: messageText); yourself) doitFlag: doitFlag errorMessage: string location: location) signal. notification tryNewSourceIfAvailable] ifFalse: [cue requestor notify: messageText at: location in: source]. ^ self fail!

4 3

The Inbox: Collections-ct.877.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Christoph Thiede uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ct.877.mcz ==================== Summary ==================== Name: Collections-ct.877 Author: ct Time: 17 February 2020, 8:57:49.278239 pm UUID: bf652ba0-43cc-734d-ac03-7a226cc80463 Ancestors: Collections-ul.875 Extends and realigns version of #findFirst: and #findLast:. Second, optimized version after many helpful comments by Levente (ul). Thank you! Replaces Collections-ct.875. --- Performance analysis: #findFirst: - '238 per second. 4.2 milliseconds per run. 0.73956 % GC time.' #findFirst:startingAt: - '1,510 per second. 660 microseconds per run. 1.56 % GC time.' #findFirst:startingAt:ifNone: - '1,210 per second. 828 microseconds per run. 2.06 % GC time.' #findFirst:ifNone: - '214 per second. 4.68 milliseconds per run. 0.65987 % GC time.' #findLast: - '210 per second. 4.76 milliseconds per run. 0.66 % GC time.' #findLast:startingAt: - '1,380 per second. 724 microseconds per run. 1.72 % GC time.' #findLast:startingAt:ifNone: - '1,130 per second. 887 microseconds per run. 2 % GC time.' #findLast:ifNone: - '206 per second. 4.86 milliseconds per run. 0.81967 % GC time.' Comparing to previous version: #findFirst: - '193 per second. 5.19 milliseconds per run. 0.5994 % GC time.' (NOW 23.3% faster) #findLast: - '213 per second. 4.69 milliseconds per run. 0.71986 % GC time.' (NOW 1.4% slower) #findLast:startingAt: - '1,360 per second. 736 microseconds per run. 1.72 % GC time.' (NOW 1.4% faster) Measurements code: random := Random new. range := 1 to: 256. array := (1 to: 128) collect: [:i | range atRandom: random]. values := (1 to: 4096) collect: [:i | range atRandom: random]. ({ #findFirst: -> [ values do: [:x | array findFirst: [:y | x = y]]]. #findFirst:startingAt: -> [ values pairsDo: [:x :s | array findFirst: [:y | x = y] startingAt: s]]. #findFirst:ifNone: -> [ values do: [:x | array findFirst: [:y | x = y] ifNone: [123456789 sqrt]]]. #findFirst:startingAt:ifNone: -> [ values pairsDo: [:x :s | array findFirst: [:y | x = y] startingAt: s ifNone: [123456789 sqrt]]]. #findLast: -> [ values do: [:x | array findLast: [:y | x = y]]]. #findLast:startingAt: -> [ values pairsDo: [:x :s | array findLast: [:y | x = y] startingAt: s]]. #findLast:ifNone: -> [ values do: [:x | array findLast: [:y | x = y] ifNone: [123456789 sqrt]]]. #findLast:startingAt:ifNone: -> [ values pairsDo: [:x :s | array findLast: [:y | x = y] startingAt: s ifNone: [123456789 sqrt]]]. } select: [:assoc | array respondsTo: assoc key]) collect: [:assoc | assoc key -> assoc value bench] as: Dictionary =============== Diff against Collections-ul.875 =============== Item was changed: ----- Method: SequenceableCollection>>findFirst: (in category 'enumerating') ----- findFirst: aBlock "Return the index of my first element for which aBlock evaluates as true." + ^ self findFirst: aBlock startingAt: 1! - | index | - index := 0. - [(index := index + 1) <= self size] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:ifNone: (in category 'enumerating') ----- + findFirst: aBlock ifNone: anotherBlock + "Return the index of my first element for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findFirst: aBlock) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true." + + minIndex to: self size do: [:index | + (aBlock value: (self at: index)) ifTrue: [^index]]. + ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt:ifNone: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findFirst: aBlock startingAt: minIndex) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was changed: ----- Method: SequenceableCollection>>findLast: (in category 'enumerating') ----- findLast: aBlock "Return the index of my last element for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: 1! - | index | - index := self size + 1. - [(index := index - 1) >= 1] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:ifNone: (in category 'enumerating') ----- + findLast: aBlock ifNone: anotherBlock + "Return the index of my last element for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findLast: aBlock) = 0 + ifTrue: [^ anotherBlock value]. + ^ index! Item was changed: ----- Method: SequenceableCollection>>findLast:startingAt: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true." - findLast: aBlock startingAt: i - "Return the index of my last element with index >= i for which aBlock evaluates as true." + self size to: minIndex by: -1 do: [:index | + (aBlock value: (self at: index)) ifTrue: [^index]]. - | index | - index := self size + 1. - [(index := index - 1) >= i] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:startingAt:ifNone: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + (index := self findLast: aBlock startingAt: minIndex) = 0 + ifTrue: [^ anotherBlock value]. + ^ index!

3 2

PositionableStream >> #peekBack behavior
by Eric Gade 04 May '22

04 May '22

Hello, What is the expected behavior for a stream that is at position 1 when you send #peekBack? Intuitively I'd expect to get the first element of the underlying collection as a response. But instead I am getting nil. Here is an example that is failing: ``` elem := #(1 2 3 4). stream := ReadStream on: elem. first := stream next. first = 1. back := stream peekBack. back = first. ``` The last message is currently responding false. In Pharo this returns true, so there are differences. The currently implementation of PositionableStream >> #peekBack is: ``` peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." | element | self position = 0 ifTrue: [self errorCantGoBack]. self position = 1 ifTrue: [self position: 0. ^ nil]. self skip: -2. element := self next. self skip: 1. ^ element ``` I can see the nil being returned there explicitly, so that's "where it's happening." Should this be the case though? Thanks -- Eric

5 7

The Inbox: Collections-ct.860.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.860.mcz ==================== Summary ==================== Name: Collections-ct.860 Author: ct Time: 15 November 2019, 1:58:56.418005 pm UUID: f6364e7f-08c8-694a-9060-21bc0a0c28d4 Ancestors: Collections-pre.857 Add convenience constructor for Dictionary Dictionary fromKeys: 'wasd' values: '8426' =============== Diff against Collections-pre.857 =============== Item was added: + ----- Method: Dictionary class>>fromKeys:values: (in category 'instance creation') ----- + fromKeys: keys values: values + + | dictionary | + self assert: [keys size = values size]. + dictionary := self new: keys size. + keys with: values do: [:key :value | + dictionary add: key -> value]. + ^ dictionary!

7 7

The Inbox: Collections-ct.920.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.920.mcz ==================== Summary ==================== Name: Collections-ct.920 Author: ct Time: 4 November 2020, 8:02:08.093134 pm UUID: f516a6ba-d9ee-0944-be9b-ad4093133c08 Ancestors: Collections-ct.920 Proposal: Honor scaleFactor for default spacings in text constants. With this change, tabs in every text editor are finally displayed hi-dpi-sensitive. Note that I found this method rather by incident than by expertise! I strongly advise against merging this into the Trunk without prior review by someone who has a bit more knowledge of this domain than me. ;-) Is this the right place for such a change, or should we patch the senders of every constant instead? Requires System-ct.1188. =============== Diff against Collections-ct.920 ===============

2 1

The Inbox: Collections-ct.875.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.875.mcz ==================== Summary ==================== Name: Collections-ct.875 Author: ct Time: 16 February 2020, 3:32:23.116 pm UUID: 61ea773b-1408-c040-a712-09238ee6fe2f Ancestors: Collections-topa.873 Extends and realigns version of #findFirst: and #findLast:. =============== Diff against Collections-topa.873 =============== Item was changed: ----- Method: SequenceableCollection>>findFirst: (in category 'enumerating') ----- findFirst: aBlock - "Return the index of my first element for which aBlock evaluates as true." + ^ self findFirst: aBlock startingAt: 1! - | index | - index := 0. - [(index := index + 1) <= self size] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:ifNone: (in category 'enumerating') ----- + findFirst: aBlock ifNone: anotherBlock + + ^ self findFirst: aBlock startingAt: 1 ifNone: anotherBlock! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex + + ^ self findFirst: aBlock startingAt: minIndex ifNone: [0]! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt:ifNone: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := minIndex - 1. + [(index := index + 1) <= self size] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value! Item was changed: ----- Method: SequenceableCollection>>findLast: (in category 'enumerating') ----- findLast: aBlock - "Return the index of my last element for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: 1! - | index | - index := self size + 1. - [(index := index - 1) >= 1] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:ifNone: (in category 'enumerating') ----- + findLast: aBlock ifNone: anotherBlock + + ^ self findLast: aBlock startingAt: 1 ifNone: anotherBlock! Item was changed: ----- Method: SequenceableCollection>>findLast:startingAt: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex - findLast: aBlock startingAt: i - "Return the index of my last element with index >= i for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: minIndex ifNone: [0]! - | index | - index := self size + 1. - [(index := index - 1) >= i] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:startingAt:ifNone: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := self size + 1. + [(index := index - 1) >= minIndex] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value!

6 12

The Inbox: Collections-ct.871.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.871.mcz ==================== Summary ==================== Name: Collections-ct.871 Author: ct Time: 30 December 2019, 3:06:02.364602 pm UUID: 235b9546-6ad3-b547-8661-38c5f2a98374 Ancestors: Collections-nice.868 Refactor CharacterClass >> #constantNames: Use reflection instead of hardcoding all names. With this change, further characters such as Character arrowLeft are printed legibly. =============== Diff against Collections-nice.868 =============== Item was changed: ----- Method: Character class>>constantNames (in category 'private') ----- constantNames + ^ self class methodsInCategory: #'accessing untypeable characters'! - ^ #( backspace cr delete escape lf null newPage space tab ).!

2 1

The Trunk: System-mt.1018.mcz
by commits＠source.squeak.org 19 Jan '22

19 Jan '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1018.mcz ==================== Summary ==================== Name: System-mt.1018 Author: mt Time: 16 April 2018, 10:31:28.239614 am UUID: e0350560-a5a5-5a40-b31b-d13f55162021 Ancestors: System-mt.1017 #setAuthorInitials: -> #authorInitials: =============== Diff against System-mt.1017 =============== Item was changed: ----- Method: SmalltalkImage>>openSourceFiles (in category 'sources, changes log') ----- openSourceFiles self imageName = LastImageName ifFalse: ["Reset the author initials to blank when the image gets moved" LastImageName := self imageName. + Utilities authorInitials: '']. - Utilities setAuthorInitials: '']. FileDirectory openSources: self sourcesName andChanges: self changesName forImage: LastImageName. SourceFileArray install!

4 4

Jump to page: