Squeak-dev December 2021

squeak-dev@lists.squeakfoundation.org

30 participants
391 discussions

The Trunk: Morphic-ct.1624.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.1624.mcz ==================== Summary ==================== Name: Morphic-ct.1624 Author: ct Time: 5 February 2020, 10:01:38.455675 am UUID: 232459ff-c526-a546-b734-e6b8c6366657 Ancestors: Morphic-cmm.1618 Fixes a bug when undoing dismissal of a SelectionMorph. In the past, this only restored the SelectionMorph itself but not its items. Please note this solution is not optimal because it abuses #intoWorld:. However, I don't see any unwanted side effects at the moment ... Maybe we would like to introduce an extra hook for this in #reintroduceIntoWorld:? =============== Diff against Morphic-cmm.1618 =============== Item was added: + ----- Method: SelectionMorph>>intoWorld: (in category 'initialization') ----- + intoWorld: aWorld + + selectedItems ifNotEmpty: [ + "Restore selected items for #reintroduceIntoWorld:" + selectedItems do: [:morph | + aWorld reintroduceIntoWorld: morph]. + ^ self delete]. + super intoWorld: aWorld.!

1 0

The Inbox: Tools-ct.937.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.937.mcz ==================== Summary ==================== Name: Tools-ct.937 Author: ct Time: 29 January 2020, 6:26:57.711894 pm UUID: 34af35bc-83e2-9b40-9aa3-8f6af607ac6e Ancestors: Tools-mt.929 Fixes a styling issue in the Workspace that missstyled class variables from Object as invalid (that is DependentsFields). This is a bug because you can access DependentsFields indeed. There is a subtle but important difference between the classOrMetaclass nil and the classOrMetaclass Object: The former does not respect any state for styling, but the latter respects class variables from Object (as well as, hypothetically, ProtoObject). Please note that it would be even more accurate to specify nil class instead of Object here, but I don't know whether we really want to emphasize the nuances of UndefinedObject. It feels rather like an implementation detail for me, at least in this context. (Just imagine UndefinedObject had a UniqueInstance class variable - would we really to access it from any Workspace?) Open for opinions. =============== Diff against Tools-mt.929 =============== Item was changed: ----- Method: Workspace>>aboutToStyle: (in category 'code pane') ----- aboutToStyle: aStyler self shouldStyle ifFalse: [ ^false ]. + aStyler + parseAMethod: false; + classOrMetaClass: Object; - aStyler - classOrMetaClass: nil; workspace: self. ^true!

4 3

The Trunk: Tools-mt.1080.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1080.mcz ==================== Summary ==================== Name: Tools-mt.1080 Author: mt Time: 6 December 2021, 5:27:16.648211 pm UUID: 8a35bfc8-a273-554d-85a9-27d79f60b98f Ancestors: Tools-mt.1079 Drop the property protocol from Workspace again since this looks like a "premature abstraction" or wrong use of the "variable extension" pattern, given its currently known scenarios. Instead, use regular instance variables. See discussion here: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-November/217129… =============== Diff against Tools-mt.1079 =============== Item was changed: + (PackageInfo named: 'Tools') preamble: '(Workspace instVarNames includes: #windowTitle) + ifFalse: [Workspace addInstVarName: #windowTitle]. + (Workspace instVarNames includes: #fileDirectory) + ifFalse: [Workspace addInstVarName: #fileDirectory]. + (Workspace instVarNames includes: #fileLineEndConvention) + ifFalse: [Workspace addInstVarName: #fileLineEndConvention]. + + Workspace allInstancesDo: [:workspace | + workspace instVarNamed: #windowTitle + put: (workspace valueOfProperty: #windowTitle). + workspace instVarNamed: #fileDirectory + put: (workspace valueOfProperty: #fileDirectory). + workspace instVarNamed: #fileLineEndConvention + put: (workspace valueOfProperty: #fileLineConversion)]. + '! - (PackageInfo named: 'Tools') preamble: 'Project current isMorphic ifTrue: [ - | windows | - windows := SystemWindow - windowsIn: Project current world - satisfying: [:window | window visible and: [window model isKindOf: Inspector] ]. - Smalltalk globals - at: #ObjectsUnderInspection - put: (windows collect: [:ea | ea model object]). - windows do: [:window | [window delete] valueSupplyingAnswer: true]].'! Item was changed: ----- Method: FileList>>viewContentsInWorkspace (in category 'own services') ----- viewContentsInWorkspace "View the contents of my selected file in a new workspace." + | fileContents workspace lineEndConvention | - | fileContents workspace lineConversion | fileContents := self directory readOnlyFileNamed: self fileName do: [:fileStream | fileStream setConverterForCode; wantsLineEndConversion: true. + lineEndConvention := fileStream detectLineEndConvention. - lineConversion := fileStream detectLineEndConvention. fileStream contents]. workspace := (Project uiManager edit: fileContents label: nil shouldStyle: Workspace shouldStyle) model. "Remember certain information to allow edits in the same file." workspace windowTitle: (self directory localNameFor: self fileName); fileDirectory: self directory; + fileLineEndConvention: lineEndConvention; - setProperty: #fileLineConversion toValue: lineConversion; saveContentsInFileOnAccept. ! Item was changed: StringHolder subclass: #Workspace + instanceVariableNames: 'bindings acceptDroppedMorphs acceptAction mustDeclareVariables shouldStyle environment windowTitle fileDirectory fileLineEndConvention' - instanceVariableNames: 'bindings acceptDroppedMorphs acceptAction mustDeclareVariables shouldStyle environment' classVariableNames: 'DeclareVariablesAutomatically EmbedTranscript FileOutFilePath FileOutOnAccept LookupPools ShouldStyle' poolDictionaries: '' category: 'Tools-Base'! !Workspace commentStamp: 'fbs 6/2/2012 20:46' prior: 0! A Workspace is a text area plus a lot of support for executable code. It is a great place to execute top-level commands to compute something useful, and it is a great place to develop bits of a program before those bits get put into class methods. To open a new workspace, execute: Workspace open A workspace can have its own variables, called "workspace variables", to hold intermediate results. For example, if you type into a workspace "x := 5" and do-it, then later you could type in "y := x * 2" and y would become 10. Additionally, in Morphic, a workspace can gain access to morphs that are on the screen. If acceptDroppedMorphs is turned on, then whenever a morph is dropped on the workspace, a variable will be created which references that morph. This functionality is toggled with the window-wide menu of a workspace. The instance variables of this class are: bindings - holds the workspace variables for this workspace acceptDroppedMorphs - whether dropped morphs should create new variables! Item was changed: ----- Method: Workspace>>fileDirectory (in category 'accessing') ----- fileDirectory "Answer the current directory for save-contents requests." + ^ fileDirectory ifNil: [FileDirectory default]! - ^ (self valueOfProperty: #fileDirectory) ifNil: [FileDirectory default]! Item was changed: ----- Method: Workspace>>fileDirectory: (in category 'accessing') ----- fileDirectory: aDirectory "Do not save the default directory so that the image and its surrounding files can be moved across the disk." + fileDirectory := aDirectory = FileDirectory default ifFalse: [aDirectory].! - aDirectory = FileDirectory default - ifTrue: [self removeProperty: #fileDirectory] - ifFalse: [self setProperty: #fileDirectory toValue: aDirectory].! Item was added: + ----- Method: Workspace>>fileLineEndConvention (in category 'accessing') ----- + fileLineEndConvention + + ^ fileLineEndConvention! Item was added: + ----- Method: Workspace>>fileLineEndConvention: (in category 'accessing') ----- + fileLineEndConvention: aSymbol + "#cr, #lf, #crlf -- 'nil' means Squeak's default" + + fileLineEndConvention := aSymbol.! Item was removed: - ----- Method: Workspace>>hasProperty: (in category 'binding - properties') ----- - hasProperty: aSymbol - - | propertyValue | - propertyValue := self valueOfProperty: aSymbol. - propertyValue ifNil: [^ false]. - propertyValue == false ifTrue: [^ false]. - ^ true! Item was changed: ----- Method: Workspace>>initialize (in category 'initialize-release') ----- initialize super initialize. + self resetBindings. - bindings := Dictionary new. acceptDroppedMorphs := false. mustDeclareVariables := self class declareVariablesAutomatically not. environment := Environment current! Item was removed: - ----- Method: Workspace>>removeProperty: (in category 'binding - properties') ----- - removeProperty: aSymbol - - bindings removeKey: ('_', aSymbol) asSymbol ifAbsent: [].! Item was changed: ----- Method: Workspace>>resetBindings (in category 'binding') ----- resetBindings - "Remove all bindings that are not prefixed with an $_. See #setProperty:toValue:." + bindings := Dictionary new.! - bindings keysAndValuesRemove: [:key :value | key first ~= $_]! Item was changed: ----- Method: Workspace>>saveContents:onFileNamed:accessMode: (in category 'user edits') ----- saveContents: stringContents onFileNamed: fileName accessMode: accessMode "Overwritten to set conversion rule of line-end character. See FileList >> #viewContentsInWorkspace." ^ self saveContents: stringContents onFileNamed: fileName accessMode: accessMode workBlock: [:fileStream | fileStream + lineEndConvention: self fileLineEndConvention; - lineEndConvention: (self valueOfProperty: #fileLineConversion); "nil is fine here..." nextPutAll: stringContents]! Item was removed: - ----- Method: Workspace>>setProperty:toValue: (in category 'binding - properties') ----- - setProperty: aSymbol toValue: anObject - - anObject ifNil: [^ self removeProperty: aSymbol]. - bindings at: ('_', aSymbol) asSymbol put: anObject.! Item was added: + ----- Method: Workspace>>setWindowTitle: (in category 'initialize-release') ----- + setWindowTitle: aString + "Normalize window title to not expose file extension in regular workspaces. Do not tell the UI to avoid endless recursion; see #windowTitle: and #windowReqNewLabel:." + + | normalizedTitle | + normalizedTitle := ((aString includesSubstring: 'Workspace') and: [aString endsWithAnyOf: #('.text' '.txt')]) + ifTrue: [aString copyFrom: 1 to: (aString lastIndexOf: $.) - 1] + ifFalse: [aString]. + + windowTitle := normalizedTitle.! Item was removed: - ----- Method: Workspace>>valueOfProperty: (in category 'binding - properties') ----- - valueOfProperty: aSymbol - - ^ self valueOfProperty: aSymbol ifAbsent: nil! Item was removed: - ----- Method: Workspace>>valueOfProperty:ifAbsent: (in category 'binding - properties') ----- - valueOfProperty: aSymbol ifAbsent: aBlock - - ^ bindings at: ('_', aSymbol) asSymbol ifAbsent: aBlock! Item was changed: ----- Method: Workspace>>windowReqNewLabel: (in category 'user edits') ----- windowReqNewLabel: newLabel "The user has edited the window label. Remember for a later save-to-file request. See #defaultFileNameForSave." + self setWindowTitle: newLabel. - self setProperty: #windowTitle toValue: newLabel. ^ true! Item was changed: ----- Method: Workspace>>windowTitle (in category 'accessing') ----- windowTitle + ^ windowTitle ifNil: ['Workspace']! - ^ (self valueOfProperty: #windowTitle) ifNil: ['Workspace']! Item was changed: ----- Method: Workspace>>windowTitle: (in category 'accessing') ----- windowTitle: aString - "Normalize window title to not expose file extension in regular workspaces." + self setWindowTitle: aString. - | normalizedTitle | - normalizedTitle := ((aString includesSubstring: 'Workspace') and: [aString endsWithAnyOf: #('.text' '.txt')]) - ifTrue: [aString copyFrom: 1 to: (aString lastIndexOf: $.) - 1] - ifFalse: [aString]. - - self setProperty: #windowTitle toValue: normalizedTitle. self changed: #windowTitle.! Item was changed: + (PackageInfo named: 'Tools') postscript: 'Workspace allInstances do: [:workspace | + (workspace instVarNamed: #bindings) + removeKey: #''_fileDirectory'' ifAbsent: nil; + removeKey: #''_windowTitle'' ifAbsent: nil; + removeKey: #''_fileLineConversion'' ifAbsent: nil].'! - (PackageInfo named: 'Tools') postscript: 'ChangeSorter allSubInstancesDo: [:sorter | - (sorter instVarNamed: ''contentsAreStyleable'') ifNil: [ - sorter instVarNamed: ''contentsAreStyleable'' put: true]]. - - "Convert existing properties from Morphic windows to the model. For MVC compatibility." - Workspace allInstancesDo: [:workspace | - workspace containingWindow ifNotNil: [:window | - (window valueOfProperty: #myDir) ifNotNil: [:directory | - workspace setProperty: #fileDirectory toValue: directory]. - (window valueOfProperty: #lineConversion) ifNotNil: [:symbol | - workspace setProperty: #fileLineConversion toValue: symbol]. - workspace setProperty: #windowTitle toValue: window label]. - (workspace acceptAction notNil and: [workspace acceptAction home selector = #open]) - ifTrue: [workspace appendContentsToFileOnAccept]].'!

1 0

The Trunk: Kernel-mt.1433.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1433.mcz ==================== Summary ==================== Name: Kernel-mt.1433 Author: mt Time: 6 December 2021, 5:17:32.639211 pm UUID: ffcbed5c-2a51-4342-a8f0-3ce8f9639dd9 Ancestors: Kernel-mt.1432 Hmpf. I forgot to commit this along with Tools-mt.1079. Let's see how this goes now... =============== Diff against Kernel-mt.1432 =============== Item was removed: - ----- Method: Model>>cleanFileNameForSave: (in category 'user interface - file out') ----- - cleanFileNameForSave: aString - "Removes selected decoration (i.e., leader+trailer) of aString. This decoration usually comes from window titles and the desire to reuse those titles as a file name. - NOTE THAT if only the decoration's leader matches, any existing file extension will be removed. - NOTE THAT if no decoration matches, the '.text' extension is appended if there is none. - SEE #defaultFileNameForSave." - - | cleanFileName | - self flag: #discuss. "mt: Rename 'save' to 'fileOut'?" - cleanFileName := aString. - - #( " 'leader' 'trailer' " - 'Decompressed contents of: ' '.gz' - "Add more here..." - ) groupsDo: [:leader :trailer | - self flag: #discuss. "mt: Maybe extract this feature into String and Text? See #withoutLeading* and #withoutTrailing*." - (cleanFileName beginsWith: leader) ifTrue: [ - cleanFileName := cleanFileName allButFirst: leader size. - (cleanFileName endsWith: trailer) - ifTrue: [cleanFileName := cleanFileName allButLast: trailer size] - ifFalse: [ - | lastIndex | - lastIndex := cleanFileName lastIndexOf: $. ifAbsent: [0]. - lastIndex > 1 ifTrue: [ - cleanFileName := cleanFileName copyFrom: 1 to: lastIndex - 1]] ]]. - - (cleanFileName = aString and: [(cleanFileName includes: $.) not]) - ifTrue: [cleanFileName := cleanFileName, '.text']. - - ^ cleanFileName! Item was removed: - ----- Method: Model>>defaultFileNameForSave (in category 'user interface - file out') ----- - defaultFileNameForSave - "Answer a label that should be used as a file name when saving the receivers textual contents to disk. Note that the answer can also be a relative or absolute file path." - - self flag: #discuss. "mt: Rename 'save' to 'fileOut'?" - ^ self containingWindow - ifNil: ['Untitled'] - ifNotNil: [:window | window label]! Item was removed: - ----- Method: Model>>saveContents: (in category 'user interface - file out') ----- - saveContents: stringContents - "Interactive. See #saveContents:accessMode:." - - ^ self - saveContents: stringContents - accessMode: #create! Item was removed: - ----- Method: Model>>saveContents:accessMode: (in category 'user interface - file out') ----- - saveContents: stringContents accessMode: accessMode - "Interactive callback from TextEditor. Ask the user for a file name/path, suggesting a (cleaned-up) default name to accept. Answers whether the save request was successful." - - ^ (Project uiManager - saveFilenameRequest: 'Save text contents in file...' - initialAnswer: self suggestedFileNameForSave) - ifNil: [false] ifNotNil: [:answer | answer ifEmpty: [false] - ifNotEmpty: [:fileName | - self - saveContents: stringContents - onFileNamed: fileName - accessMode: accessMode]].! Item was removed: - ----- Method: Model>>saveContents:onFileNamed:accessMode: (in category 'user interface - file out') ----- - saveContents: stringContents onFileNamed: fileName accessMode: accessMode - - ^ self - saveContents: stringContents - onFileNamed: fileName - accessMode: accessMode - workBlock: [:fileStream | fileStream nextPutAll: stringContents]! Item was removed: - ----- Method: Model>>saveContents:onFileNamed:accessMode:workBlock: (in category 'user interface - file out') ----- - saveContents: stringContents onFileNamed: fileName accessMode: accessMode workBlock: workBlock - "Save stringContents on fileName. Answers whether the save request was successful. On success, fileName will exist, including any new directories in the relative/absolute path. - - accessMode - #create ... Prompt the user if file exists. - #update ... Replace all contents if file exists. - #append ... Append new contents if file exists." - - (FileDirectory default on: fileName) containingDirectory assureExistence. - accessMode caseOf: { - [#create] -> [FileStream newFileNamed: fileName do: workBlock]. - [#update] -> [FileStream forceNewFileNamed: fileName do: workBlock]. - [#append] -> [FileStream fileNamed: fileName do: [:s | s setToEnd. workBlock value: s]] } - otherwise: [ - self error: 'Unknown file access mode: ', accessMode printString. - ^ false]. - - Transcript showln: ('{1} contents saved (via {2}) to: {3}' format: { self class. accessMode printString. fileName }). - ^ true! Item was removed: - ----- Method: Model>>suggestedFileNameForSave (in category 'user interface - file out') ----- - suggestedFileNameForSave - - ^ self cleanFileNameForSave: self defaultFileNameForSave!

1 0

The Trunk: Monticello-mt.758.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.758.mcz ==================== Summary ==================== Name: Monticello-mt.758 Author: mt Time: 6 December 2021, 1:39:03.225534 pm UUID: 49466f4b-ae12-5143-b411-a1d8774bf6bd Ancestors: Monticello-mt.757 Fixes high-dpi scaling issues in Monticello tools. =============== Diff against Monticello-mt.757 =============== Item was changed: ----- Method: MCSaveVersionDialog>>widgetSpecs (in category 'ui') ----- widgetSpecs ^ #( + ((listMorph:selection:menu:keystroke: list selection methodListMenu: methodListKey:from:) (0 0 0.5 0.6) (0 0 0 defaultAnnotationPaneHeightNegated) ) - ((listMorph:selection:menu:keystroke: list selection methodListMenu: methodListKey:from:) (0 0 0.5 0.6) (0 0 0 -47) ) ((inputMorph: versionName) (0.5 0 1 0) (0 0 0 defaultInputFieldHeight)) + ((textMorph: logMessage) (0.5 0 1 0.6) (0 defaultInputFieldHeight 0 defaultAnnotationPaneHeightNegated)) + ((buttonRow) (0.5 0.6 1 0.6) (0 defaultAnnotationPaneHeightNegated 0 0)) + ((textMorph: annotations) (0 0.6 0.5 0.6) (0 defaultAnnotationPaneHeightNegated 0 0)) - ((textMorph: logMessage) (0.5 0 1 0.6) (0 defaultInputFieldHeight 0 -47)) - ((buttonRow) (0.5 0.6 1 0.6) (0 -47 0 0)) - ((textMorph: annotations) (0 0.6 0.5 0.6) (0 -47 0 0)) ((textMorph: text) (0 0.6 1 1) (0 0 0 0)) )! Item was added: + ----- Method: MCTool>>defaultAnnotationPaneHeightNegated (in category 'morphic ui') ----- + defaultAnnotationPaneHeightNegated + + ^ self defaultAnnotationPaneHeight negated! Item was added: + ----- Method: MCTool>>defaultButtonPaneHeightNegated (in category 'morphic ui') ----- + defaultButtonPaneHeightNegated + + ^ self defaultButtonPaneHeight negated! Item was added: + ----- Method: MCTool>>initialExtent (in category 'morphic ui') ----- + initialExtent + + ^ self defaultExtent! Item was changed: ----- Method: MCTool>>show (in category 'morphic ui') ----- show modalProcess := nil. Smalltalk at: #ToolBuilder ifPresent: [:tb | tb open: self. ^ self]. + ^self window openInWorld; yourself! - ^self window openInWorldExtent: self defaultExtent; yourself! Item was changed: ----- Method: MCTool>>showLabelled: (in category 'morphic ui') ----- showLabelled: labelString modalProcess := nil. self label: labelString. ^(self window) + openInWorld; - openInWorldExtent: self defaultExtent; yourself! Item was changed: ----- Method: MCTool>>showModally (in category 'morphic ui') ----- showModally modalProcess := Processor activeProcess. + self window openInWorld. - self window openInWorldExtent: self defaultExtent. ToolBuilder default runModal: self window. morph := nil. ^ modalValue!

1 0

The Trunk: Morphic-mt.1813.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1813.mcz ==================== Summary ==================== Name: Morphic-mt.1813 Author: mt Time: 6 December 2021, 1:37:16.179534 pm UUID: 04262cef-f643-394a-8a18-13e1adb11d89 Ancestors: Morphic-mt.1812 Complements Graphics-mt.451 and ToolBuilder-Morphic-mt.282. Fixes invisible resize grips in request-text-input dialogs. =============== Diff against Morphic-mt.1812 =============== Item was changed: ----- Method: DialogWindow>>initialExtent (in category 'initialization') ----- initialExtent + "Scale here because dialogs -- unlike SystemWindow -- will not use the RealEstateAgent to open (i.e., #openInWorld:)." + ^ ((200@150) * RealEstateAgent scaleFactor) truncated! - ^ 200@150! Item was changed: ----- Method: FillInTheBlankMorph>>setPasswordQuery:initialAnswer:answerHeight:acceptOnCR: (in category 'initialization') ----- setPasswordQuery: queryString initialAnswer: initialAnswer answerHeight: answerHeight acceptOnCR: acceptBoolean self setQuery: queryString initialAnswer: initialAnswer answerHeight: answerHeight acceptOnCR: acceptBoolean. + textPane font: StrikeFont passwordFont.! - textPane font: (StrikeFont passwordFontSize: 12).! Item was changed: ----- Method: FillInTheBlankMorph>>setQuery:initialAnswer:answerExtent:acceptOnCR: (in category 'initialization') ----- setQuery: queryString initialAnswer: initialAnswer answerExtent: answerExtent acceptOnCR: acceptBoolean | text | result := initialAnswer. done := false. self paneMorph removeAllMorphs. self title: 'Input Requested' translated. self message: queryString. text := self createTextPaneAcceptOnCR: acceptBoolean. self paneMorph addMorphBack: text. self paneMorph wantsPaneSplitters: true; + addCornerGrips; + layoutInset: ProportionalSplitterMorph gripThickness; + cellGap: ProportionalSplitterMorph gripThickness. - addCornerGrips. self paneMorph grips do: [:ea | ea showHandle: true]. + + self paneMorph extent: ((initialAnswer asText asMorph extent + (self paneMorph layoutInset * 2) asPoint + ((20@10) * RealEstateAgent scaleFactor) truncated max: answerExtent) min: ((500@500) * RealEstateAgent scaleFactor) truncated). - - self paneMorph extent: ((initialAnswer asText asMorph extent + (20@10) max: answerExtent) min: 500@500). self setDefaultParameters.!

1 0

The Trunk: ToolBuilder-Morphic-mt.282.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.282.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.282 Author: mt Time: 6 December 2021, 1:35:46.372534 pm UUID: e5cb2e77-4066-1347-a5fa-89169700258b Ancestors: ToolBuilder-Morphic-ct.281 Again, fixes some high-dpi scaling issues in dialog windows. Note that we cannot do that in the tool builder because models might already answer scaled content sizes such as when using the default font metrics already in #initialExtent. See ListChooser >> #initialExtent as an example. Unfortunately, we cannot re-use dialog models in regular (non-dialog / system) windows and vice versa. Luckily, there is no such case at the moment. Also implement #isMorphicModel in pluggable dialogs to have a richer debug (halo) menu, i.e., "explore model" etc. =============== Diff against ToolBuilder-Morphic-ct.281 =============== Item was changed: ----- Method: FileAbstractSelectionDialog>>initialExtent (in category 'toolbuilder') ----- initialExtent + ^ (super initialExtent * (0.8 @ 0.7) * RealEstateAgent scaleFactor) truncated! - ^ super initialExtent * (0.8 @ 0.7)! Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableDialog: (in category 'widgets optional') ----- buildPluggableDialog: aSpec | widget | widget := self dialogClass new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties. The pane morph holds the special contents." widget paneMorph wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). self setLayoutHintsFor: widget paneMorph spec: aSpec. widget paneMorph layoutInset: (aSpec padding ifNil: [ProportionalSplitterMorph gripThickness]). widget paneMorph cellGap: (aSpec spacing ifNil: [ProportionalSplitterMorph gripThickness]). widget morphicLayerNumber: widget class dialogLayer. widget paneMorph wantsPaneSplitters ifTrue: [ widget paneMorph addCornerGrips"addEdgeGrips". widget paneMorph grips do: [:ea | ea showHandle: true]]. "Now create the children." panes := OrderedCollection new. aSpec children isSymbol ifTrue: [ widget getChildrenSelector: aSpec children. widget update: aSpec children] ifFalse: [ self buildAll: aSpec children in: widget paneMorph]. "Now create the buttons." aSpec buttons isSymbol ifTrue: [ widget getButtonsSelector: aSpec buttons. widget update: aSpec buttons] ifFalse: [ self buildAll: aSpec buttons in: widget buttonRowMorph. widget updateButtonProperties]. aSpec title ifNotNil: [:label | label isSymbol ifTrue:[widget getTitleSelector: label; update: label] ifFalse:[widget title: label]]. aSpec message ifNotNil: [:label | label isSymbol ifTrue:[widget getMessageSelector: label; update: label] ifFalse:[widget message: label]]. "Interaction behavior." aSpec autoCancel ifNotNil: [:b | widget autoCancel: b]. aSpec exclusive ifNotNil: [:b | widget exclusive: b]. widget closeDialogSelector: aSpec closeAction. self buildHelpFor: widget spec: aSpec. "Everything is shrink-wrapped around the pane morph." + widget paneMorph extent: (aSpec extent ifNil:[widget initialExtent]) + + (widget paneMorph layoutInset * 2) asPoint. - widget paneMorph extent: ((aSpec extent ifNil:[widget initialExtent]) - + (widget paneMorph layoutInset * 2) asPoint * RealEstateAgent scaleFactor) truncated. ^ widget! Item was changed: ----- Method: PluggableDialogWindow>>initialExtent (in category 'initialization') ----- initialExtent + "Avoid screen-scaling to let the model determine the best initial extent, which might already be based on visible contents such as texts rendered in the default font." + - ^ model initialExtent! Item was added: + ----- Method: PluggableDialogWindow>>isMorphicModel (in category 'testing') ----- + isMorphicModel + "I am a MorphicModel because I am a Morph and I offer a #model. Now, my debug menu shows more entries." + + self flag: #discuss. "mt: Maybe subclass from MorphicModel like SystemWindow?" + ^ true!

1 0

The Trunk: ST80-mt.272.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.272.mcz ==================== Summary ==================== Name: ST80-mt.272 Author: mt Time: 6 December 2021, 1:28:22.705534 pm UUID: 2a7c8725-10c6-3c48-86b5-f968c04e6399 Ancestors: ST80-mt.271 Complements Graphics-mt.451 =============== Diff against ST80-mt.271 =============== Item was changed: ----- Method: FillInTheBlankView class>>requestPassword:message:centerAt:answerHeight: (in category 'instance creation') ----- requestPassword: aFillInTheBlank message: queryString centerAt: aPoint answerHeight: answerHeight "Answer an instance of me on aFillInTheBlank asking the question queryString. Allow the reply to be multiple lines, and make the user input view the given height." | messageView answerView topView myPar pwdFont myArray myStyle | aFillInTheBlank acceptOnCR: true. messageView := DisplayTextView new model: queryString asDisplayText; borderWidthLeft: 2 right: 2 top: 2 bottom: 0; controller: NoController new. messageView window: (0@0 extent: (messageView window extent max: 200@30)); centered. answerView := self new model: aFillInTheBlank; window: (0@0 extent: (messageView window width@answerHeight)); borderWidth: 2. " now answerView to use the password font" myPar := answerView displayContents. + pwdFont := StrikeFont passwordFont. - pwdFont := (StrikeFont passwordFontSize: 12). myArray := Array new: 1. myArray at: 1 put: pwdFont. myStyle := TextStyle fontArray: myArray. myPar setWithText: (myPar text) style: myStyle. topView := View new model: aFillInTheBlank. topView controller: ModalController new. topView addSubView: messageView. topView addSubView: answerView below: messageView. topView align: topView viewport center with: aPoint. topView window: (0 @ 0 extent: (messageView window width) @ (messageView window height + answerView window height)). topView translateBy: (topView displayBox amountToTranslateWithin: Display boundingBox). ^ topView !

1 0

The Trunk: Graphics-mt.451.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.451.mcz ==================== Summary ==================== Name: Graphics-mt.451 Author: mt Time: 6 December 2021, 1:26:15.957534 pm UUID: 53f52e72-395b-c142-9f38-5560565a14c6 Ancestors: Graphics-mt.450 Fixes high-dpi scaling issues with password fonts. =============== Diff against Graphics-mt.450 =============== Item was added: + ----- Method: FixedFaceFont>>fontPointSize: (in category 'accessing') ----- + fontPointSize: aNumber + self baseFont: (StrikeFont familyName: baseFont familyName pointSize: aNumber) copy! Item was changed: ----- Method: FixedFaceFont>>initialize (in category 'initialize-release') ----- initialize "This used to be the default textstyle, but it needs to be a StrikeFont and not a TTCFont and sometimes the default textstyle is a TTCFont. So, we use a typical StrikeFont as the default fallback font." + baseFont := TextStyle defaultFont. - baseFont := StrikeFont defaultSized: 12. self passwordFont! Item was added: + ----- Method: StrikeFont class>>passwordFont (in category 'instance creation') ----- + passwordFont + + ^ self passwordFontPointSize: TextStyle defaultFont pointSize! Item was added: + ----- Method: StrikeFont class>>passwordFontPointSize: (in category 'instance creation') ----- + passwordFontPointSize: pointSize + + ^ FixedFaceFont new passwordFont fontPointSize: pointSize!

1 0

The Inbox: MorphicExtras-ct.303.mcz
by commits＠source.squeak.org 04 Dec '21

04 Dec '21

A new version of MorphicExtras was added to project The Inbox: http://source.squeak.org/inbox/MorphicExtras-ct.303.mcz ==================== Summary ==================== Name: MorphicExtras-ct.303 Author: ct Time: 4 December 2021, 3:37:46.516791 pm UUID: d6d2ef8c-59cf-944e-8fc4-d70d81cd5f1b Ancestors: MorphicExtras-mt.300 Fix typo. =============== Diff against MorphicExtras-mt.300 =============== Item was changed: Object subclass: #TextOnCurveContainer instanceVariableNames: 'baseline inset textDirection textSegments' classVariableNames: '' poolDictionaries: '' category: 'MorphicExtras-Text Support'! + !TextOnCurveContainer commentStamp: 'ct 12/2/2021 21:52' prior: 0! + I am not really a container in the sense of TextContainer. However, I get stored in the same field of a textMorph. My baseline specifies the vertical displacement of the character baselines from the curve center (0 means on center, 5 would mean, eg, the character baselines are 5 pixels above the curve center). This is essential enduring information. I also cache temporary layout information, including the locations, angles and bounding boxes of each of the characters as displayed.! - !TextOnCurveContainer commentStamp: '<historical>' prior: 0! - I am not really a container in the sense of TextContainer. However, I get stored in the same field of a textMorph. My baseline specifies the vertical displacement of the character baselines from the curve center (0 means on center, 5 would mean, eg, the character baselines are 5 pixels above the curve center). This is ssential enduring information. I also cache temporary layout information, including the locations, angles and bounding boxes of each of the characters as displayed.!

1 0

← Newer
1
...
31
32
33
34
35
36
37
...
40
Older →

Jump to page: