Squeak-dev April 2021

squeak-dev@lists.squeakfoundation.org

33 participants
393 discussions

The Trunk: KernelTests-nice.399.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.399.mcz ==================== Summary ==================== Name: KernelTests-nice.399 Author: nice Time: 12 April 2021, 10:34:15.635162 pm UUID: 9d4c795e-d8db-465d-b5f9-f07e88072ee3 Ancestors: KernelTests-nice.398 Generalize the clean-up made in KernelTests-jar.397, and move it to tearDown. This way, clean-up should also happen in case of failure. =============== Diff against KernelTests-nice.398 =============== Item was changed: ClassTestCase subclass: #ProcessTest + instanceVariableNames: 'semaphore' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'KernelTests-Processes'! !ProcessTest commentStamp: 'ul 8/16/2011 11:35' prior: 0! I hold test cases for generic Process-related behaviour.! Item was added: + ----- Method: ProcessTest>>setUp (in category 'running') ----- + setUp + semaphore := Semaphore new! Item was changed: ----- Method: ProcessTest>>tearDown (in category 'running') ----- tearDown + Processor activeProcess environmentRemoveKey: #processTests ifAbsent: []. + + "Release all processes still waiting at the semaphore or in the active priority queue." + Processor yield. + [semaphore isEmpty] whileFalse: [semaphore signal]! - Processor activeProcess environmentRemoveKey: #processTests ifAbsent: []! Item was changed: ----- Method: ProcessTest>>testAtomicSuspend (in category 'tests') ----- testAtomicSuspend "Test atomic suspend of foreign processes" + | list p | + p := [semaphore wait] fork. - | list p sema | - sema := Semaphore new. - p := [sema wait] fork. Processor yield. list := p suspendPrimitivelyOrFail. + self assert: list == semaphore. - self assert: list == sema. ! Item was changed: ----- Method: ProcessTest>>testProcessStateTests (in category 'tests') ----- testProcessStateTests - | semaphore | self assert: Processor activeProcess isActiveProcess. self deny: Processor activeProcess isBlocked. self assert: Processor activeProcess isRunnable. self deny: Processor activeProcess isSuspended. self deny: Processor activeProcess isTerminated. - semaphore := Semaphore new. - "These processes are runnable but haven't got to the wait yet because the active process is running." self deny: ([semaphore wait] forkAt: Processor activePriority) isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) isBlocked. self assert: ([semaphore wait] forkAt: Processor activePriority) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority) isTerminated. self deny: ([semaphore wait] forkAt: Processor activePriority) suspendingList == semaphore. "These processes do get to run because, being higher priority they preempt the active process until they wait on the semaphore." self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isActiveProcess. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isTerminated. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) suspendingList == semaphore. "These processes should be suspended, not terminated." self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isRunnable. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isSuspended. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be terminated, not suspended." self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isRunnable. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isSuspended. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be suspended." self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isActiveProcess. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isBlocked. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isRunnable. self assert: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isSuspended. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isTerminated. "These processes should be terminated." self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isSuspended. + self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated.! - self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated. - - "Clean up: release all processes still waiting at the semaphore or in the active priority queue." - Processor yield. - [semaphore isEmpty] whileFalse: [semaphore signal] - !

1 0

The Trunk: KernelTests-nice.398.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.398.mcz ==================== Summary ==================== Name: KernelTests-nice.398 Author: nice Time: 12 April 2021, 10:18:38.252683 pm UUID: ac7054ff-ef3d-4941-b690-66706b8a028c Ancestors: KernelTests-eem.396, KernelTests-ct.377, KernelTests-jar.397, KernelTests-jar.395 A merge commit: KernelTests-eem.396: Rename MethodContextTest to ContextTest KernelTests-ct.377: Tests #readFrom: and #readCarefullyFrom: on Object. KernelTests-jar.397: Clean up: release all processes still waiting at the semaphore or in the active priority queue. ProcessTest>>#testProcessStateTests doesn't terminate processes it opened. KernelTests-jar.395: Tests unwinding of nested ensure =============== Diff against KernelTests-eem.396 =============== Item was added: + ----- Method: ObjectTest>>testReadCarefullyFrom (in category 'tests') ----- + testReadCarefullyFrom + + self should: [Object readCarefullyFrom: nil] raise: Error. + self should: [Object readCarefullyFrom: Object new] raise: Error. + self assert: [(Object readCarefullyFrom: 'Object new') isKindOf: Object]. + self + should: [self + should: [Object newSubclass readCarefullyFrom: 'self assert: Object isNil'] + raise: AssertionFailure. "environment must be installed"] + raise: Error. "because we return nil" + self should: [(UndefinedObject readCarefullyFrom: 'Object new')] raise: Error. + self should: [Object readCarefullyFrom: 'Object new:'] raise: Error.! Item was added: + ----- Method: ObjectTest>>testReadFrom (in category 'tests') ----- + testReadFrom + + self should: [Object readFrom: nil] raise: Error. + self should: [Object readFrom: Object new] raise: Error. + self assert: [(Object readFrom: 'Object new') isKindOf: Object]. + self + should: [self + should: [Object newSubclass readFrom: 'self assert: Object isNil'] + raise: AssertionFailure. "environment must be installed"] + raise: Error. "because we return nil" + self should: [(UndefinedObject readFrom: 'Object new')] raise: Error. + self should: [Object readFrom: 'Object new:'] raise: SyntaxErrorNotification.! Item was added: + ----- Method: ProcessTest>>testNestedUnwind (in category 'tests') ----- + testNestedUnwind + "Test all nested unwind blocks are correctly unwound; all unwind blocks halfway through their execution should be completed or at least attempted to complete, not only the innermost one" + + | p x1 x2 x3 | + x1 := x2 := x3 := false. + p := + [ + [ + [ ] ensure: [ "halfway through completion when suspended" + [ ] ensure: [ "halfway through completion when suspended" + Processor activeProcess suspend. + x1 := true]. + x2 := true] + ] ensure: [ "not started yet when suspended" + x3 := true] + ] fork. + Processor yield. + p terminate. + + self assert: x1 & x2 & x3! Item was changed: ----- Method: ProcessTest>>testProcessStateTests (in category 'tests') ----- testProcessStateTests | semaphore | self assert: Processor activeProcess isActiveProcess. self deny: Processor activeProcess isBlocked. self assert: Processor activeProcess isRunnable. self deny: Processor activeProcess isSuspended. self deny: Processor activeProcess isTerminated. semaphore := Semaphore new. "These processes are runnable but haven't got to the wait yet because the active process is running." self deny: ([semaphore wait] forkAt: Processor activePriority) isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) isBlocked. self assert: ([semaphore wait] forkAt: Processor activePriority) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority) isTerminated. self deny: ([semaphore wait] forkAt: Processor activePriority) suspendingList == semaphore. + "These processes do get to run because, being higher priority they preempt the active process until they wait on the semaphore." - "These processes do get to run because, being higher priority they preempt the active process until yhey wait on the semaphore." self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isActiveProcess. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isTerminated. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) suspendingList == semaphore. "These processes should be suspended, not terminated." self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isRunnable. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isSuspended. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be terminated, not suspended." self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isRunnable. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isSuspended. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be suspended." self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isActiveProcess. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isBlocked. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isRunnable. self assert: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isSuspended. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isTerminated. "These processes should be terminated." self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isSuspended. + self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated. + + "Clean up: release all processes still waiting at the semaphore or in the active priority queue." + Processor yield. + [semaphore isEmpty] whileFalse: [semaphore signal] + ! - self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated!

1 0

The Inbox: Monticello-ct.740.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-ct.740.mcz ==================== Summary ==================== Name: Monticello-ct.740 Author: ct Time: 12 April 2021, 10:18:26.02269 pm UUID: c0c2562b-e801-ef4c-8628-3d352c513e0a Ancestors: Monticello-mt.736 Introduces MCPackageNotFound exception and usees it in MCRepository versions lookup. I would like to catch this error in [1, 2, 3]. [1] https://github.com/LinqLover/TelegramSmalltalkBot/blob/03be8437dfd9b9e98715… [2] https://github.com/LinqLover/TelegramBot/blob/e2d248eff9e24ca9a0423585b18d0… [3] https://github.com/LinqLover/SimulationStudio/blob/743d48fdc10a70d572b1070b… =============== Diff against Monticello-mt.736 =============== Item was added: + Error subclass: #MCPackageNotFound + instanceVariableNames: 'repository packageName' + classVariableNames: '' + poolDictionaries: '' + category: 'Monticello-Repositories'! Item was added: + ----- Method: MCPackageNotFound class>>signalForRepository:packageName: (in category 'signaling') ----- + signalForRepository: aRepository packageName: aString + + ^ self new + repository: aRepository packageName: aString; + signal! Item was added: + ----- Method: MCPackageNotFound>>messageText (in category 'printing') ----- + messageText + + ^ messageText ifNil: ['{1} not found in {2}' translated format: {self packageName. self repository}]! Item was added: + ----- Method: MCPackageNotFound>>packageName (in category 'accessing') ----- + packageName + + ^ packageName! Item was added: + ----- Method: MCPackageNotFound>>repository (in category 'accessing') ----- + repository + + ^ repository! Item was added: + ----- Method: MCPackageNotFound>>repository:packageName: (in category 'accessing') ----- + repository: aRepository packageName: aString + + repository := aRepository. + packageName := aString.! Item was changed: ----- Method: MCRepository>>highestNumberedVersionNameForPackageNamed: (in category 'versions') ----- highestNumberedVersionNameForPackageNamed: aString ^ (self versionNamesForPackageNamed: aString) + ifEmpty: [MCPackageNotFound signalForRepository: self packageName: aString] - ifEmpty: [ self error: aString , ' not found in ' , self asString ] ifNotEmptyDo: [ : versionNames | versionNames detectMax: [ : each | each versionNumber ] ]!

1 0

The Trunk: KernelTests-jar.395.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-jar.395.mcz ==================== Summary ==================== Name: KernelTests-jar.395 Author: jar Time: 31 March 2021, 11:14:30.909212 pm UUID: b63793d5-9635-c942-a9c5-132e788a8eda Ancestors: KernelTests-mt.394 complementing Kernel-jar.1384 (The Inbox) =============== Diff against KernelTests-mt.394 =============== Item was added: + ----- Method: ProcessTest>>testNestedUnwind (in category 'tests') ----- + testNestedUnwind + "Test all nested unwind blocks are correctly unwound; all unwind blocks halfway through their execution should be completed or at least attempted to complete, not only the innermost one" + + | p x1 x2 x3 | + x1 := x2 := x3 := false. + p := + [ + [ + [ ] ensure: [ "halfway through completion when suspended" + [ ] ensure: [ "halfway through completion when suspended" + Processor activeProcess suspend. + x1 := true]. + x2 := true] + ] ensure: [ "not started yet when suspended" + x3 := true] + ] fork. + Processor yield. + p terminate. + + self assert: x1 & x2 & x3!

1 0

The Trunk: KernelTests-jar.397.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-jar.397.mcz ==================== Summary ==================== Name: KernelTests-jar.397 Author: jar Time: 12 April 2021, 9:43:54.742464 am UUID: 6cf87c25-8484-a144-aa35-761de4aa60c1 Ancestors: KernelTests-codefrau.395 Clean up: release all processes still waiting at the semaphore or in the active priority queue. ProcessTest>>#testProcessStateTests doesn't terminate processes it opened. =============== Diff against KernelTests-codefrau.395 =============== Item was changed: ----- Method: ProcessTest>>testProcessStateTests (in category 'tests') ----- testProcessStateTests | semaphore | self assert: Processor activeProcess isActiveProcess. self deny: Processor activeProcess isBlocked. self assert: Processor activeProcess isRunnable. self deny: Processor activeProcess isSuspended. self deny: Processor activeProcess isTerminated. semaphore := Semaphore new. "These processes are runnable but haven't got to the wait yet because the active process is running." self deny: ([semaphore wait] forkAt: Processor activePriority) isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) isBlocked. self assert: ([semaphore wait] forkAt: Processor activePriority) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority) isTerminated. self deny: ([semaphore wait] forkAt: Processor activePriority) suspendingList == semaphore. + "These processes do get to run because, being higher priority they preempt the active process until they wait on the semaphore." - "These processes do get to run because, being higher priority they preempt the active process until yhey wait on the semaphore." self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isActiveProcess. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isTerminated. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) suspendingList == semaphore. "These processes should be suspended, not terminated." self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isRunnable. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isSuspended. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be terminated, not suspended." self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isRunnable. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isSuspended. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be suspended." self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isActiveProcess. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isBlocked. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isRunnable. self assert: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isSuspended. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isTerminated. "These processes should be terminated." self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isSuspended. + self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated. + + "Clean up: release all processes still waiting at the semaphore or in the active priority queue." + Processor yield. + [semaphore isEmpty] whileFalse: [semaphore signal] + ! - self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated!

1 0

The Inbox: Collections-ct.934.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.934.mcz ==================== Summary ==================== Name: Collections-ct.934 Author: ct Time: 12 April 2021, 10:11:41.51069 pm UUID: 84f5a3d9-3316-fd46-b89b-2fb0d2b625ef Ancestors: Collections-nice.933 Improves multilingual support for errors in collections. =============== Diff against Collections-nice.933 =============== Item was changed: ----- Method: Collection>>errorDifferentSize (in category 'private') ----- errorDifferentSize + ^ self error: 'Other collection must be the same size' translated! - self error: 'otherCollection must be the same size'! Item was changed: ----- Method: Collection>>errorEmptyCollection (in category 'private') ----- errorEmptyCollection + ^ self error: 'This collection is empty' translated! - self error: 'this collection is empty'! Item was changed: ----- Method: Collection>>errorNoMatch (in category 'private') ----- errorNoMatch + ^ self error: 'Collection sizes do not match' translated! - self error: 'collection sizes do not match'! Item was added: + ----- Method: Collection>>name (in category 'printing') ----- + name + + ^ String streamContents: [:stream | + self printNameOn: stream]! Item was changed: ----- Method: Dictionary>>errorValueNotFound (in category 'private') ----- errorValueNotFound + ^ self error: 'Value not found' translated! - self error: 'value not found'! Item was changed: ----- Method: HashedCollection>>errorNoFreeSpace (in category 'private') ----- errorNoFreeSpace + ^ self error: 'There is no free space in this collection!!' translated! - self error: 'There is no free space in this collection!!'! Item was changed: ----- Method: KeyNotFound>>messageText (in category 'accessing') ----- messageText + + ^ messageText ifNil: ['Key not found: {1}' translated format: {self key}]! - "Return a textual description of the exception." - ^messageText ifNil:['Key not found: ', key]! Item was changed: ----- Method: NotFound>>messageText (in category 'accessing') ----- messageText + + ^ messageText ifNil: ['Object is not in the collection.' translated]! - "Return a textual description of the exception." - ^messageText ifNil:['Object is not in the collection.']! Item was changed: ----- Method: OrderedCollection>>errorNoSuchElement (in category 'private') ----- errorNoSuchElement + ^ self error: ('Attempt to index a non-existent element in {1}' translated format: {self name})! - self error: (String streamContents: [ :stream | - stream nextPutAll: 'attempt to index a non-existent element in '. - self printNameOn: stream ])! Item was changed: ----- Method: OrderedCollection>>errorNotEnoughElements (in category 'private') ----- errorNotEnoughElements + ^ self error: ('Attempt to remove more elements than possible from {1}' translated format: {self name})! - self error: (String streamContents: [ :stream | - stream nextPutAll: 'attempt to remove more elements than possible from '. - self printNameOn: stream ])! Item was changed: ----- Method: SequenceableCollection>>errorFirstObject: (in category 'private') ----- errorFirstObject: anObject + + ^ self error: 'Specified object is first object' translated! - self error: 'specified object is first object'! Item was changed: ----- Method: SequenceableCollection>>errorLastObject: (in category 'private') ----- errorLastObject: anObject + + ^ self error: 'Specified object is last object' translated! - self error: 'specified object is last object'! Item was changed: ----- Method: SequenceableCollection>>errorOutOfBounds (in category 'private') ----- errorOutOfBounds + ^ self error: 'Indices are out of bounds' translated! - self error: 'indices are out of bounds'!

1 0

#testProcessStateTests leaves unterminated processes behind
by Jaromir Matas 12 Apr '21

12 Apr '21

ProcessTest>>#testProcessStateTests doesn't terminate processes it opened and leaves lots of runnable and blocked processes behind (almost gave me a heart attack when tested my #terminate fix). Are they supposed to get GC'd somehow? I sent a simple cleanup suggestion to the Inbox. http://forum.world.st/The-Inbox-KernelTests-jar-397-mcz-td5128422.html + "Clean up: release all processes still waiting at the semaphore or in the active priority queue." + Processor yield. + [semaphore isEmpty] whileFalse: [semaphore signal] ----- ^[^ Jaromir -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

1 0

The Trunk: KernelTests-ct.377.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.377.mcz ==================== Summary ==================== Name: KernelTests-ct.377 Author: ct Time: 19 February 2020, 12:18:45.853795 pm UUID: f0095798-52b3-bb4c-8b8b-5c6a1dbfe113 Ancestors: KernelTests-nice.373 Tests #readFrom: and #readCarefullyFrom: on Object. Regressions will be addressed in another commit. =============== Diff against KernelTests-nice.373 =============== Item was added: + ----- Method: ObjectTest>>testReadCarefullyFrom (in category 'tests') ----- + testReadCarefullyFrom + + self should: [Object readCarefullyFrom: nil] raise: Error. + self should: [Object readCarefullyFrom: Object new] raise: Error. + self assert: [(Object readCarefullyFrom: 'Object new') isKindOf: Object]. + self + should: [self + should: [Object newSubclass readCarefullyFrom: 'self assert: Object isNil'] + raise: AssertionFailure. "environment must be installed"] + raise: Error. "because we return nil" + self should: [(UndefinedObject readCarefullyFrom: 'Object new')] raise: Error. + self should: [Object readCarefullyFrom: 'Object new:'] raise: Error.! Item was added: + ----- Method: ObjectTest>>testReadFrom (in category 'tests') ----- + testReadFrom + + self should: [Object readFrom: nil] raise: Error. + self should: [Object readFrom: Object new] raise: Error. + self assert: [(Object readFrom: 'Object new') isKindOf: Object]. + self + should: [self + should: [Object newSubclass readFrom: 'self assert: Object isNil'] + raise: AssertionFailure. "environment must be installed"] + raise: Error. "because we return nil" + self should: [(UndefinedObject readFrom: 'Object new')] raise: Error. + self should: [Object readFrom: 'Object new:'] raise: SyntaxErrorNotification.!

1 0

The Trunk: KernelTests-eem.396.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-eem.396.mcz ==================== Summary ==================== Name: KernelTests-eem.396 Author: eem Time: 12 April 2021, 11:30:53.654392 am UUID: 642cd275-3ce5-4cfb-a34f-1bb29d140e94 Ancestors: KernelTests-codefrau.395 Rename MethodContextTest to ContextTest =============== Diff against KernelTests-codefrau.395 =============== Item was added: + TestCase subclass: #ContextTest + instanceVariableNames: 'aCompiledMethod aReceiver aSender aContext' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Methods'! + + !ContextTest commentStamp: 'ct 1/27/2020 13:03' prior: 0! + I am an SUnit Test of Context. See also BlockClosureTest. + See pages 430-437 of A. Goldberg and D. Robson's Smalltalk-80 The Language (aka the purple book), which deal with Contexts. My fixtures are from their example. To see how blocks are implemented in this version of Squeak see http://www.mirandabanda.org/cogblog/2008/06/07/closures-part-i/ and http://www.mirandabanda.org/cogblog/2008/07/22/closures-part-ii-the-bytecod…. (The Squeak V3 byte codes are not quite the same as Smalltalk-80, and the SistaV1 byetcodes are quite different.) + My fixtures are: + aReceiver - just some arbitrary object, "Rectangle origin: 100@100 corner: 200@200" + aSender - just some arbitrary object, thisContext + aCompiledMethod - just some arbitrary method, "Rectangle rightCenter". + aContext - just some arbitray context ... + + ! Item was added: + ----- Method: ContextTest>>privRestartTest (in category 'private') ----- + privRestartTest + "This tests may loop endlessly if incorrect, so call it from another method testing it does not time out" + |a firstTimeThrough | + firstTimeThrough := true. + a := 10. + + self assert: 30 equals: [|b| + self assert: 10 = a . + self assert: nil == b. + b := a + 20. + firstTimeThrough ifTrue: [ + firstTimeThrough := false. + thisContext restart.]. + b] value + ! Item was added: + ----- Method: ContextTest>>setUp (in category 'running') ----- + setUp + super setUp. + aCompiledMethod := Rectangle methodDict at: #rightCenter. + aReceiver := 100@100 corner: 200@200. + aSender := thisContext. + aContext := Context sender: aSender receiver: aReceiver method: aCompiledMethod arguments: #(). ! Item was added: + ----- Method: ContextTest>>testActivateReturnValue (in category 'tests') ----- + testActivateReturnValue + self assert: (aSender activateReturn: aContext value: #()) isContext. + self assert: ((aSender activateReturn: aContext value: #()) receiver = aContext).! Item was added: + ----- Method: ContextTest>>testCopyStack (in category 'tests') ----- + testCopyStack + self assert: aContext copyStack printString = aContext printString.! Item was added: + ----- Method: ContextTest>>testCopyTo (in category 'tests') ----- + testCopyTo + + | context depth targetSender | + context := thisContext. + depth := 1. + targetSender := context. + [ (targetSender := targetSender sender) isNil ] whileFalse: [ + | original copy | + original := context. + copy := context copyTo: targetSender. + 1 to: depth do: [ :index | + index = 1 ifFalse: [ + "Since we're copying thisContext, the pc and stackPtr may be different for the current frame." + self + assert: original pc equals: copy pc; + assert: original stackPtr equals: copy stackPtr ]. + self + deny: original == copy; + assert: original method equals: copy method; + assert: original closure equals: copy closure; + assert: original receiver equals: copy receiver. + original := original sender. + copy := copy sender ]. + self + assert: copy isNil; + assert: original == targetSender. + depth := depth + 1 ]! Item was added: + ----- Method: ContextTest>>testFindContextSuchThat (in category 'tests') ----- + testFindContextSuchThat + self assert: (aContext findContextSuchThat: [:each| true]) printString = aContext printString. + self assert: (aContext hasContext: aContext). ! Item was added: + ----- Method: ContextTest>>testMethodContext (in category 'tests') ----- + testMethodContext + self assert: aContext home notNil. + self assert: aContext receiver notNil. + self assert: aContext method isCompiledMethod.! Item was added: + ----- Method: ContextTest>>testMethodIsBottomContext (in category 'tests') ----- + testMethodIsBottomContext + self assert: aContext bottomContext = aSender. + self assert: aContext secondFromBottom = aContext.! Item was added: + ----- Method: ContextTest>>testPrimitive100 (in category 'tests') ----- + testPrimitive100 + + { + {#isNil. {}. Object}. "valid 0-arg message" + {#=. {true}. UndefinedObject}. "valid unary message" + {#ifNil:ifNotNil:. {[2]. [:x | x]}. Object}. "valid binary message" + {}. "missing selector" + {#isNil}. "missing arguments" + {#isNil. 'not an array'}. "invalid arguments" + {#isNil. {}}. "missing lookupClass" + {#isNil. {'excess arg'}. Object}. "too many arguments" + {#=. {}. UndefinedObject}. "missing argument" + {#isNil. {}. Boolean}. "lookupClass not in inheritance chain" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 100 withArgs: args]) + equals: (nil tryPrimitive: 100 withArgs: args)].! Item was added: + ----- Method: ContextTest>>testPrimitive83 (in category 'tests') ----- + testPrimitive83 + + { + {#isNil}. "valid 0-arg message" + {#=. true}. "valid unary message" + {#ifNil:ifNotNil:. [2]. [:x | x]}. "valid binary message" + {}. "missing selector" + {#isNil. 'excess arg'}. "too many arguments" + {#=}. "missing argument" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 83 withArgs: args]) + equals: (nil tryPrimitive: 83 withArgs: args)].! Item was added: + ----- Method: ContextTest>>testPrimitive84 (in category 'tests') ----- + testPrimitive84 + + { + {#isNil. {}}. "valid 0-arg message" + {#=. {true}}. "valid unary message" + {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" + {}. "missing selector" + {#isNil}. "missing arguments" + {#isNil. 'not an array'}. "invalid arguments" + {#isNil. {'excess arg'}}. "too many arguments" + {#=. {}}. "missing argument" + } do: [:args | + self + assert: (Context runSimulated: [nil tryPrimitive: 84 withArgs: args]) + equals: (nil tryPrimitive: 84 withArgs: args)].! Item was added: + ----- Method: ContextTest>>testRestart (in category 'tests') ----- + testRestart + self should: [self privRestartTest] notTakeMoreThan: 0.1 second! Item was added: + ----- Method: ContextTest>>testReturn (in category 'tests') ----- + testReturn + "Why am I overriding setUp? Because sender must be thisContext, i.e, testReturn, not setUp." + aContext := Context sender: thisContext receiver: aReceiver method: aCompiledMethod arguments: #(). + self assert: (aContext return: 5) = 5! Item was added: + ----- Method: ContextTest>>testSetUp (in category 'tests') ----- + testSetUp + "Note: In addition to verifying that the setUp worked the way it was expected to, testSetUp is used to illustrate the meaning of the simple access methods, methods that are not normally otherwise 'tested'" + self assert: aContext isContext. + self deny: aContext isExecutingBlock. + self deny: aContext isClosure. + self deny: aContext isDead. + "self assert: aMethodContext home = aReceiver." + "self assert: aMethodContext blockHome = aReceiver." + self assert: aContext receiver = aReceiver. + self assert: aContext method isCompiledMethod. + self assert: aContext method = aCompiledMethod. + self assert: aContext methodNode selector = #rightCenter. + self assert: (aContext methodNodeFormattedAndDecorated: true) selector = #rightCenter. + self assert: aContext client printString = 'ContextTest>>#testSetUp'. + ! Item was removed: - TestCase subclass: #MethodContextTest - instanceVariableNames: 'aCompiledMethod aReceiver aMethodContext aSender' - classVariableNames: '' - poolDictionaries: '' - category: 'KernelTests-Methods'! - - !MethodContextTest commentStamp: 'eem 3/30/2017 17:42' prior: 0! - I am an SUnit Test of Context. See also BlockClosureTest. - See pages 430-437 of A. Goldberg and D. Robson's Smalltalk-80 The Language (aka the purple book), which deal with Contexts. My fixtures are from their example. To see how blocks are implemented in this version of Squeak see http://www.mirandabanda.org/cogblog/2008/06/07/closures-part-i/ and http://www.mirandabanda.org/cogblog/2008/07/22/closures-part-ii-the-bytecod…. (The Squeak V3 byte codes are not quite the same as Smalltalk-80, and the SistaV1 byetcodes are quite different.) - My fixtures are: - aReceiver - just some arbitrary object, "Rectangle origin: 100@100 corner: 200@200" - aSender - just some arbitrary object, thisContext - aCompiledMethod - just some arbitrary method, "Rectangle rightCenter". - aMethodContext - just some arbitray context ... - - ! Item was removed: - ----- Method: MethodContextTest>>privRestartTest (in category 'private') ----- - privRestartTest - "This tests may loop endlessly if incorrect, so call it from another method testing it does not time out" - |a firstTimeThrough | - firstTimeThrough := true. - a := 10. - - self assert: 30 equals: [|b| - self assert: 10 = a . - self assert: nil == b. - b := a + 20. - firstTimeThrough ifTrue: [ - firstTimeThrough := false. - thisContext restart.]. - b] value - ! Item was removed: - ----- Method: MethodContextTest>>setUp (in category 'running') ----- - setUp - super setUp. - aCompiledMethod := Rectangle methodDict at: #rightCenter. - aReceiver := 100@100 corner: 200@200. - aSender := thisContext. - aMethodContext := Context sender: aSender receiver: aReceiver method: aCompiledMethod arguments: #(). ! Item was removed: - ----- Method: MethodContextTest>>testActivateReturnValue (in category 'tests') ----- - testActivateReturnValue - self assert: (aSender activateReturn: aMethodContext value: #()) isContext. - self assert: ((aSender activateReturn: aMethodContext value: #()) receiver = aMethodContext).! Item was removed: - ----- Method: MethodContextTest>>testCopyStack (in category 'tests') ----- - testCopyStack - self assert: aMethodContext copyStack printString = aMethodContext printString.! Item was removed: - ----- Method: MethodContextTest>>testCopyTo (in category 'tests') ----- - testCopyTo - - | context depth targetSender | - context := thisContext. - depth := 1. - targetSender := context. - [ (targetSender := targetSender sender) isNil ] whileFalse: [ - | original copy | - original := context. - copy := context copyTo: targetSender. - 1 to: depth do: [ :index | - index = 1 ifFalse: [ - "Since we're copying thisContext, the pc and stackPtr may be different for the current frame." - self - assert: original pc equals: copy pc; - assert: original stackPtr equals: copy stackPtr ]. - self - deny: original == copy; - assert: original method equals: copy method; - assert: original closure equals: copy closure; - assert: original receiver equals: copy receiver. - original := original sender. - copy := copy sender ]. - self - assert: copy isNil; - assert: original == targetSender. - depth := depth + 1 ]! Item was removed: - ----- Method: MethodContextTest>>testFindContextSuchThat (in category 'tests') ----- - testFindContextSuchThat - self assert: (aMethodContext findContextSuchThat: [:each| true]) printString = aMethodContext printString. - self assert: (aMethodContext hasContext: aMethodContext). ! Item was removed: - ----- Method: MethodContextTest>>testMethodContext (in category 'tests') ----- - testMethodContext - self assert: aMethodContext home notNil. - self assert: aMethodContext receiver notNil. - self assert: aMethodContext method isCompiledMethod.! Item was removed: - ----- Method: MethodContextTest>>testMethodIsBottomContext (in category 'tests') ----- - testMethodIsBottomContext - self assert: aMethodContext bottomContext = aSender. - self assert: aMethodContext secondFromBottom = aMethodContext.! Item was removed: - ----- Method: MethodContextTest>>testRestart (in category 'tests') ----- - testRestart - self should: [self privRestartTest] notTakeMoreThan: 0.1 second! Item was removed: - ----- Method: MethodContextTest>>testReturn (in category 'tests') ----- - testReturn - "Why am I overriding setUp? Because sender must be thisContext, i.e, testReturn, not setUp." - aMethodContext := Context sender: thisContext receiver: aReceiver method: aCompiledMethod arguments: #(). - self assert: (aMethodContext return: 5) = 5! Item was removed: - ----- Method: MethodContextTest>>testSetUp (in category 'tests') ----- - testSetUp - "Note: In addition to verifying that the setUp worked the way it was expected to, testSetUp is used to illustrate the meaning of the simple access methods, methods that are not normally otherwise 'tested'" - self assert: aMethodContext isContext. - self deny: aMethodContext isExecutingBlock. - self deny: aMethodContext isClosure. - self deny: aMethodContext isDead. - "self assert: aMethodContext home = aReceiver." - "self assert: aMethodContext blockHome = aReceiver." - self assert: aMethodContext receiver = aReceiver. - self assert: aMethodContext method isCompiledMethod. - self assert: aMethodContext method = aCompiledMethod. - self assert: aMethodContext methodNode selector = #rightCenter. - self assert: (aMethodContext methodNodeFormattedAndDecorated: true) selector = #rightCenter. - self assert: aMethodContext client printString = 'MethodContextTest>>#testSetUp'. - !

2 1

The Trunk: Tools-eem.1036.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.1036.mcz ==================== Summary ==================== Name: Tools-eem.1036 Author: eem Time: 12 April 2021, 11:36:27.582761 am UUID: 6f49f7a4-a29b-48eb-94d4-ad3be6cf607b Ancestors: Tools-eem.1035 Fix some shadowed variable warning(s). =============== Diff against Tools-eem.1035 =============== Item was changed: ----- Method: ContextVariablesInspector>>fieldStackTop (in category 'fields') ----- fieldStackTop ^ (self newFieldForType: #stackTop key: #stackTop) name: self stackTopTranslated; emphasizeName; + valueGetter: [:ctxt | ctxt top]; - valueGetter: [:context | context top]; valueGetterExpression: 'ThisContext top'; yourself!

1 0

← Newer
1
...
33
34
35
36
37
38
39
40
Older →

Jump to page: