Squeak-dev April 2021

squeak-dev@lists.squeakfoundation.org

33 participants
393 discussions

Please try out | Cross-platform mapping for virtual key codes :-)
by Marcel Taeumel 15 May '21

15 May '21

Hi all! Please find attached a changeset that adds mapping tables for virtual keys (or scan codes) for macOS, X11, and Windows. You can find them in EventSensor class >> #virtualKeysOn* You can try out if they work through the KeyboardExerciser. Please take a look at the balloon text (i.e. tool tip) to better understand the data. There is also a new preference: [x] Simplify Virtual-key codes ... because of Windows who dares to couple codes to the input language (e.g. US vs. DE), which Squeak knows nothing about. macOS is better in this regard. :-) Biggest mess is on Linux/X11. For key-down/up events, the Linux VM delivers actual character codes instead of scan codes, which makes a basic mapping to physical keys almost impossible. See EventSensor class >> #virtualKeysOnX11. We MUST fix that! Please. Somebody. Can I haz scan codes? ^__^ *** *** The good news: KeyboardEvent >> #key (and UserInputEvent >> #modifiers) now gives you cross-platform stable information about physical keys to be used in keyboard handlers. Yes, for both key-stroke and key-down/up events. Or at least, that is the plan. That's why it would be great if you could help testing! :-) Why key-stroke events too? Aren't they for typing text only? 1. Almost all keyboard shortcuts in current Squeak are based on key-stroke events. 2. Using the #keyCharacter is tricky because SHIFT changes lower-case to upper-case, which makes "anEvent shiftPressed" hard to understand. 3. CTRL combinations might not do the expected thing. How would you handle CTRL+C? The #keyCharacter could arrive as $c or Character enter. See the preference "Map non-printable characters to printable characters. Now, #key will always answer $C in such a case. Regardless of that preference. Can't we just use #keyCharacter in key-down/up events? No. Those are undefined. Never do that. key-down/up events carry virtual-key codes in their #keyValue. We might want to change #keyCharacter to answer "nil" for those events. *** Q: What is a "physical key" or "physical modifier"? A: The label that can be presented to the user so that he or she feels at home when using Squeak. Thus, looks platform-specific. Q: What is a "virtual key" or "virtual modifier"? A: The information to be processed in your application's key handlers. Thus, looks platform-independent. If you have still no clue how to talk to keyboard events, please read the commentary in KeyboardEvent >> #checkCommandKey. *** Happy testing! :-) And thank you all in advance! Best, Marcel P.S.: You might want to disable the preference "synthesize mouse-wheel events from keyboard-events" to get CTRL+ArrowUp and CTRL+ArrowDown ;-)

3 6

The Trunk: Tools-mt.1029.mcz
by commits＠source.squeak.org 14 May '21

14 May '21

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1029.mcz ==================== Summary ==================== Name: Tools-mt.1029 Author: mt Time: 4 March 2021, 3:38:36.350661 pm UUID: bef0c471-6ff1-774d-860e-8958e1aa508b Ancestors: Tools-mt.1028 Enable source-code dragging through a browser's message list to be dropped into the world to open a compact code editor. Complements Tools-mt.1028, ToolBuilder-Kernel-mt.139, ToolBuilder-Morphic-mt.274, and Morphic-mt.1733. =============== Diff against Tools-mt.1028 =============== Item was changed: ----- Method: Browser>>buildMessageListWith: (in category 'toolbuilder') ----- buildMessageListWith: builder | listSpec | listSpec := builder pluggableListSpec new. listSpec model: self; list: #messageList; getIndex: #messageListIndex; setIndex: #messageListIndex:; icon: #messageIconAt:; helpItem: #messageHelpAt:; menu: #messageListMenu:shifted:; keyPress: #messageListKey:from:. + SystemBrowser browseWithDragNDrop ifTrue: [ + listSpec + dragItem: #dragFromMessageList:; + dragType: #dragTypeForMessageListAt:]. - SystemBrowser browseWithDragNDrop - ifTrue:[listSpec dragItem: #dragFromMessageList:]. ^listSpec ! Item was added: + ----- Method: Browser>>dragTypeForMessageListAt: (in category 'drag and drop') ----- + dragTypeForMessageListAt: index + + ^ #sourceCode!

9 23

Bug in Process>>#terminate | Returning from unwind contexts
by Thiede, Christoph 12 May '21

12 May '21

Hi all, besides my proposed solution approach for the never-returning sends to Context>>#runUntilErrorReturnFrom: [1], I recently stumbled upon another problem with context manipulation connected to #runUntilErrorReturnFrom:. But I think the cause is a different one and this one brings up a more general design discussion. Let me explain: The bug itself is pretty simple to reproduce: 1. Do it: [self error] ensure: [^2] 2. Abandon the Error debugger 3. Do it: self error Expected behavior: A second error debugger is shown Actual behavior: An unwind error (Unwind error during termination) is shown! Here's an explanation: If you inspect your UI process after step 2, you will see that two guard contexts (BlockClosure>>on:do: and BlockClosure>>ensure:) are installed right before [] in BlockClosure>>newProcess on the bottom of the sender stack. These contexts have been created by #runUntilErrorOrReturnFrom: as part of the context popping-down performed by Process>>#terminate when abandoning the debugger. Normally, they would have been removed again after unwinding all contexts from the process (and the UI process would have been terminated and been replaced by a new one, see #spawnNewProcessIfThisIsUI:). But because our "ensure: [^2]" has stopped the unwinding, #runUntilErrorOrReturnFrom: and senders are still alive and waiting for the unwinding to complete while the UI process is continuing its everyday world cycles. When the next error is raised at any time later, the UnhandledError guard gets invoked and the signaler context is returned back from Process>>#popTo:, and Process>>#terminate complains that the unwinding has not been successful. So far about the problem, here are some thoughts and questions: 1. Should it be a legal operation at all to return from an unwind context? (I think it should, because a) it works fine unless Process>>#terminate gets involved, and b) it is a powerful instrument for certain control flows that need to ignore all exceptions.) (1.1 If you think we should criminalize this operation, should we make efforts to exclude this behavior in #aboutToReturn:through: and other places? I fear this could become quite complex ...) 2. I'm attaching a small changeset to fix this issue by decriminalizing unwind errors and continuing the execution (with the new error) instead of showing an unwind error. It's a small patch of three lines that works surprisingly well for my use case, but I'm not sure whether there could be any other justified reasons for showing an unwind error. Do you know some other relevant reasons for unwinding errors? 3. Also, the solution approach begs a new question to me: Should the #terminate send indeed freeze for potentially hours of image time or millions of bytecodes, or are we required to find another way for this? I hope for the first because I really can't imagine an elegant alternative at the moment. Looking forward to your thoughts! :-) CC'ing Jaromir because you're working on the same method at the moment. Afaik you are only reworking the definition of #isTerminated, but probably you can share some interesting insights on this issue, too. :-) Best, Christoph (PS: This message, as my previous one, has become quite long, I know this. General suggestions for reasonable shortening of my texts will be appreciated, I'm always trying to waste as little as possible of your time ... :-)) [1] http://forum.world.st/BUG-REGRESSION-while-debugging-Generator-nextPut-tp51… <http://www.hpi.de/>

5 18

Another bug in Process>>#terminate in unwinding contexts ?
by Jaromir Matas 12 May '21

12 May '21

Hi, if you examine the following example you'll notice only the innermost unwind context currently under evaluation will get completed during termination. But the unwind contexts may be nested so I guess we should attempt completing the outermost context rather than the innermost only. | p | p := [ [ ] ensure: [ [ ] ensure: [Processor activeProcess suspend. Transcript show: 'x1']. Transcript show: 'x2'] ] fork. Processor yield. p terminate Expected output: x1 x2 Real output: x1 (`Processor activeProcess suspend` models a situation a process gets suspended and then for whatever reason terminated) This is the current implementation within #teminate: "If terminating a process halfways through an unwind, try to complete that unwind block first." (suspendedContext findNextUnwindContextUpTo: nil) ifNotNil: [:outer| (suspendedContext findContextSuchThat:[:c| c closure == (outer tempAt: 1)]) ifNotNil: [:inner| "This is an unwind block currently under evaluation" suspendedContext runUntilErrorOrReturnFrom: inner]]. I'm proposing this modification: "If terminating a process halfways through an unwind, try to complete that unwind block first." ctxt := suspendedContext. [ctxt := ctxt findNextUnwindContextUpTo: nil. ctxt ~~ nil] whileTrue: [outerMost := ctxt]. outerMost ifNotNil: ["This is the bottom-most unwind context currently under evaluation; now let's find the currently context executing its argument block (tempAt: 1)" (suspendedContext findContextSuchThat: [:c | c closure == (outerMost tempAt: 1)]) ifNotNil: [:inner | suspendedContext runUntilErrorOrReturnFrom: inner]]. Changeset: Process-terminate_modify_outerMost.st <http://forum.world.st/file/t372955/Process-terminate_modify_outerMost.st> Other bugs in terminate (and related): [1] http://forum.world.st/Bug-in-Process-gt-gt-terminate-Returning-from-unwind-… [2] http://forum.world.st/The-Inbox-Kernel-jar-1376-mcz-td5127335.html#a5127372 [3] http://forum.world.st/Refactoring-terminate-to-get-rid-of-cannot-return-err… (The last is a part of my effort to refactor termination to at least deal with the current bugs) ----- ^[^ Jaromir -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

1 2

The Trunk: Kernel-nice.1394.mcz
by commits＠source.squeak.org 03 May '21

03 May '21

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1394.mcz ==================== Summary ==================== Name: Kernel-nice.1394 Author: nice Time: 26 April 2021, 1:50:12.861556 am UUID: 3a981b94-0213-44f3-8263-838dda062f8a Ancestors: Kernel-bp.1393 Revise exception handling so as to - inactivate inner handler blocks when the exception is signalled in an outer handler - except when the inner handler has been explicitely rearmed (see rearmHandlerDuring:) Implementation notes: add a marker <primitive: 199> to handleSignal:, so as to detect the case when an exception is signalled within the execution of a handler block. This induces a subtle difference: - findNextHandlerContext might now return a handleSignal: context, - while nextHandlerContext will only return a on:do: context (or nil). The new workhorse for finding the proper handler is now #nextHandlerContextForSignal: It finds and answers the (handler) context that will handle the exception, but if it finds a handleSignal: during the scan, it will restrict the search to rearmed handlers, until it reaches the handler of prior exception, at which step it continues to search normally. Due to the scanning of inner blocks, we still need a marker for blocking re-entrancy (handlerActive temp in on:do:), but also a marker for rearmed blocks (handlerRearmed in on:do:). This can't be the same marker: an example is testHandlerReentrancy: when the rearmed inner handler pass the exception to its outer handler, the outer handler must still be inactive if it raised the Exception. Borrow resumeEvaluating: to Cuis and use it in resignalAs: Use many small methods in order to make the intention more explicit than with those mysterious tempAt: tempAt:put: =============== Diff against Kernel-bp.1393 =============== Item was changed: ----- Method: BlockClosure>>on:do: (in category 'exceptions') ----- on: exceptionOrExceptionSet do: handlerAction "Evaluate the receiver in the scope of an exception handler." + | handlerActive handlerRearmed | - | handlerActive | <primitive: 199> "just a marker, fail and execute the following" handlerActive := true. + handlerRearmed := false. ^ self value! Item was changed: ----- Method: Context>>canHandleSignal: (in category 'private-exceptions') ----- canHandleSignal: exception "Sent to handler (on:do:) contexts only. If my exception class (first arg) handles exception then return true, otherwise forward this message to the next handler context. If none left, return false (see nil>>canHandleSignal:)" + ^ (self willHandleSignal: exception) - ^ (((self tempAt: 1) handles: exception) and: [self tempAt: 3]) or: [self nextHandlerContext canHandleSignal: exception]. ! Item was added: + ----- Method: Context>>deactivateHandler (in category 'private-exceptions') ----- + deactivateHandler + "Private - sent to exception handler context only (on:do:)" + + stackp >= 3 ifTrue: [self tempAt: 3 put: false] "this is temporary handlerActive in #on:do:"! Item was added: + ----- Method: Context>>desarmHandler (in category 'private-exceptions') ----- + desarmHandler + "Private - sent to exception handler context only (on:do:)" + + stackp >= 4 ifTrue: [self tempAt: 4 put: false] "this is temporary handlerRearmed in #on:do:"! Item was added: + ----- Method: Context>>findNextHandlerContext (in category 'private-exceptions') ----- + findNextHandlerContext + "find next context marked with <primitive: 199>. + This can be either a handler context (on:do:), + or a handling context (handleSignal:)" + + ^ self sender findNextHandlerContextStarting! Item was added: + ----- Method: Context>>fireHandlerActionForSignal: (in category 'private-exceptions') ----- + fireHandlerActionForSignal: exception + "Sent to handler (on:do:) contexts only. + Perform the second argument, which is the handler action" + + ^(self tempAt: 2) cull: exception! Item was changed: ----- Method: Context>>handleSignal: (in category 'private-exceptions') ----- handleSignal: exception + "Sent to handler (on:do:) contexts only. + Execute the handler action block" - "Sent to handler (on:do:) contexts only. If my exception class (first arg) handles exception - and the handler is active then execute my handle block (second arg), otherwise forward - this message to the next handler context. If none left, execute exception's defaultAction - (see nil>>handleSignal:)." + | val | + <primitive: 199> "just a marker, fail and execute the following" - | handlerActive val | - "If the context has been returned from the handlerActive temp var may not be accessible." - handlerActive := stackp >= 3 and: [(self tempAt: 3) == true]. - (((self tempAt: 1) handles: exception) and: [handlerActive]) ifFalse: - [stackp >= 3 ifTrue: [self tempAt: 3 put: false]. - ^self nextHandlerContext handleSignal: exception]. - exception privHandlerContext: self contextTag. + self deactivateHandler. "Prevent re-entering the action block, unless it is explicitely rearmed" + val := [self fireHandlerActionForSignal: exception] ensure: [self reactivateHandler]. + self return: val "return from self if not otherwise directed in handle block"! - self tempAt: 3 put: false. "disable self while executing handle block" - val := [(self tempAt: 2) cull: exception] - ifCurtailed: [self tempAt: 3 put: true]. - self return: val "return from self if not otherwise directed in handle block" - ! Item was added: + ----- Method: Context>>isHandlerActive (in category 'private-exceptions') ----- + isHandlerActive + "Private - sent to exception handler context only (on:do:)" + + ^stackp >= 3 and: [(self tempAt: 3) == true] "this is temporary handlerActive in #on:do:"! Item was added: + ----- Method: Context>>isHandlerRearmed (in category 'private-exceptions') ----- + isHandlerRearmed + "Private - sent to exception handler context only (on:do:)" + + ^stackp >= 4 and: [(self tempAt: 4) == true] "this is temporary handlerRearmed in #on:do:"! Item was changed: ----- Method: Context>>nextHandlerContext (in category 'private-exceptions') ----- nextHandlerContext + "Answer the next handler context (on:do:) in the call chain. + Answer nil if none found" + + | handler | + handler := self findNextHandlerContext. + [handler ifNil: [^nil]. + handler selector == #handleSignal:] + whileTrue: [handler := handler findNextHandlerContext]. + ^handler! - - ^ self sender findNextHandlerContextStarting! Item was added: + ----- Method: Context>>nextHandlerContextForSignal: (in category 'private-exceptions') ----- + nextHandlerContextForSignal: exception + "Answer the handler context (on:do:) for this exception + Answer nil if none found" + + | handler priorHandler | + handler := self. + [(handler := handler findNextHandlerContext) ifNil: [^nil]. + handler selector == #handleSignal:] + whileFalse: [(handler willHandleSignal: exception) ifTrue: [^handler]]. + + "exception has been signalled in the scope of another signal handler (while #handleSignal:) + Check for a rearmed inner handler. If none, jump to outer handler context." + priorHandler := (handler tempAt: 1) "the exception argument to handleSignal:" + privHandlerContext. + + [(handler := handler nextHandlerContext) ifNil: [^nil]. + (handler isHandlerRearmed and: [handler willHandleSignal: exception]) ifTrue: [^handler]. + handler == priorHandler] whileFalse. + + ^priorHandler nextHandlerContextForSignal: exception! Item was added: + ----- Method: Context>>reactivateHandler (in category 'private-exceptions') ----- + reactivateHandler + "Private - sent to exception handler context only (on:do:)" + + stackp >= 3 ifTrue: [self tempAt: 3 put: true] "this is temporary handlerActive in #on:do:"! Item was changed: ----- Method: Context>>reactivateHandlers (in category 'private-exceptions') ----- reactivateHandlers + "Private - exception handling + do nothing, this method is only here for smooth transition. + It shall be removed at next update map." - "Private - sent to exception handler context only (on:do:). - Reactivate all the handlers into the chain" + ^self! - self tempAt: 3 put: true. "this is temporary handlerActive in #on:do:" - self nextHandlerContext reactivateHandlers! Item was added: + ----- Method: Context>>rearmHandler (in category 'private-exceptions') ----- + rearmHandler + "Private - sent to exception handler context only (on:do:)" + + self reactivateHandler. + stackp >= 4 ifTrue: [self tempAt: 4 put: true] "this is temporary handlerRearmed in #on:do:"! Item was changed: ----- Method: Context>>rearmHandlerDuring: (in category 'private-exceptions') ----- rearmHandlerDuring: aBlock "Sent to handler (on:do:) contexts only. Makes me re-entrant for the duration of aBlock. Only works in a closure-enabled image" + ^ [self rearmHandler. aBlock value] + ensure: [self desarmHandler]! - ^ [self tempAt: 3 put: true. aBlock value] - ensure: [self tempAt: 3 put: false]! Item was added: + ----- Method: Context>>rearmHandlersWhich:upTo: (in category 'private-exceptions') ----- + rearmHandlersWhich: selectBlock upTo: aHandlerContext + "Private - sent to exception handler context only (on:do:). + Rearm the inner handlers into the chain, up to, but not including, aHandlerContext, that satisfy the selectBlock predicate" + + self == aHandlerContext ifTrue: [^self]. + (selectBlock value: self) ifTrue: [self rearmHandler]. + self nextHandlerContext rearmHandlersWhich: selectBlock upTo: aHandlerContext! Item was changed: ----- Method: Context>>resume: (in category 'controlling') ----- resume: value "Unwind thisContext to self and resume with value as result of last send. Execute unwind blocks when unwinding. ASSUMES self is a sender of thisContext" + ^self resumeEvaluating: [value] - | ctxt unwindBlock | - self isDead ifTrue: [self cannotReturn: value to: self]. - ctxt := thisContext. - [ ctxt := ctxt findNextUnwindContextUpTo: self. - ctxt isNil - ] whileFalse: [ - (ctxt tempAt: 2) ifNil:[ - ctxt tempAt: 2 put: true. - unwindBlock := ctxt tempAt: 1. - thisContext terminateTo: ctxt. - unwindBlock value]. - ]. - thisContext terminateTo: self. - ^ value ! Item was added: + ----- Method: Context>>resumeEvaluating: (in category 'controlling') ----- + resumeEvaluating: aBlock + "Unwind thisContext to self and resume with value as result of last send. + Execute unwind blocks when unwinding. + ASSUMES self is a sender of thisContext" + + | ctxt unwindBlock | + self isDead ifTrue: [self cannotReturn: aBlock value to: self]. + ctxt := thisContext. + [ ctxt := ctxt findNextUnwindContextUpTo: self. + ctxt isNil + ] whileFalse: [ + (ctxt tempAt: 2) ifNil:[ + ctxt tempAt: 2 put: true. + unwindBlock := ctxt tempAt: 1. + thisContext terminateTo: ctxt. + unwindBlock value]. + ]. + thisContext terminateTo: self. + ^ aBlock value + ! Item was added: + ----- Method: Context>>returnEvaluating: (in category 'controlling') ----- + returnEvaluating: aBlock + "Unwind thisContext to self and return aBlock value to self's sender. + Execute any unwind blocks while unwinding. + ASSUMES self is a sender of thisContext" + + sender ifNil: [self cannotReturn: aBlock value to: sender]. + sender resumeEvaluating: aBlock! Item was added: + ----- Method: Context>>willHandleSignal: (in category 'private-exceptions') ----- + willHandleSignal: exception + "Sent to handler (on:do:) contexts only." + + ^self isHandlerActive and: [(self tempAt: 1) handles: exception] + ! Item was changed: ----- Method: Exception>>pass (in category 'handling') ----- pass "Yield control to the enclosing exception action for the receiver." + (handlerContext nextHandlerContextForSignal: self) handleSignal: self! - handlerContext nextHandlerContext handleSignal: self! Item was added: + ----- Method: Exception>>privHandlerContext (in category 'priv handling') ----- + privHandlerContext + ^handlerContext! Item was changed: ----- Method: Exception>>reactivateHandlers (in category 'priv handling') ----- reactivateHandlers + "Private - exception handling + do nothing, this method is only here for smooth transition. + It shall be removed at next update map." + + ^self! - "reactivate all the exception handlers in the context chain" - self canSearchForSignalerContext - ifTrue: [signalContext nextHandlerContext reactivateHandlers]! Item was changed: ----- Method: Exception>>resignalAs: (in category 'handling') ----- resignalAs: replacementException "Signal an alternative exception in place of the receiver." + self resumeEvaluating: [replacementException signal]! - self reactivateHandlers. - self resumeUnchecked: replacementException signal! Item was changed: ----- Method: Exception>>resume: (in category 'handling') ----- resume: resumptionValue "Return resumptionValue as the value of the signal message." self isResumable ifFalse: [IllegalResumeAttempt signal]. - self reactivateHandlers. self resumeUnchecked: resumptionValue! Item was added: + ----- Method: Exception>>resumeEvaluating: (in category 'handling') ----- + resumeEvaluating: aBlock + "Return result of evaluating aBlock as the value of #signal, unless this was called after an #outer message, then return resumptionValue as the value of #outer. + The block is only evaluated after unwinding the stack." + + | ctxt | + outerContext ifNil: [ + signalContext returnEvaluating: aBlock + ] ifNotNil: [ + ctxt := outerContext. + outerContext := ctxt tempAt: 1. "prevOuterContext in #outer" + ctxt returnEvaluating: aBlock + ]. + ! Item was changed: ----- Method: Exception>>signal (in category 'signaling') ----- signal "Ask ContextHandlers in the sender chain to handle this signal. The default is to execute and return my defaultAction." signalContext := thisContext contextTag. + ^(thisContext nextHandlerContextForSignal: self) handleSignal: self! - ^ thisContext nextHandlerContext handleSignal: self! Item was changed: ----- Method: UndefinedObject>>handleSignal: (in category 'bottom context') ----- handleSignal: exception + "When no more handler (on:do:) context left in sender chain this gets called. Return from signal with default action." - "When no more handler (on:do:) context left in sender chain this gets called. Return from signal with default action. - Before doing that, reactivate the handlers so that they can catch eventual secondary exceptions raised by defaultAction." + ^ exception resumeUnchecked: exception defaultAction! - ^ exception reactivateHandlers; resumeUnchecked: exception defaultAction! Item was removed: - ----- Method: UndefinedObject>>reactivateHandlers (in category 'bottom context') ----- - reactivateHandlers - "nothing to do for bottom context" - - ^ self! Item was added: + ----- Method: UndefinedObject>>rearmHandlersWhich:upTo: (in category 'bottom context') ----- + rearmHandlersWhich: selectBlock upTo: aHandlerContext + + ^ self!

3 5

The Trunk: Morphic-eem.1719.mcz
by commits＠source.squeak.org 03 May '21

03 May '21

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1719.mcz ==================== Summary ==================== Name: Morphic-eem.1719 Author: eem Time: 3 February 2021, 6:38:11.11355 pm UUID: ffb981b1-7c53-4fbe-b6f4-4c8f27c79f5a Ancestors: Morphic-mt.1718 Make SearchBar>>#smartSearch:in: search existing browsers for a class name being searched for, bringing the first such browser to the front and selecting the class. This allows one to find classes in browsers either when one has very many, or when one is using multi-window browsers containing many many classes. =============== Diff against Morphic-mt.1718 =============== Item was added: + ----- Method: Browser>>displayClass: (in category '*Morphic-Menus-DockingBar-accessing') ----- + displayClass: aClass + "Assuming the receiver has answered true to isDisplayingClass:, come to the front and select the given class." + | index | + index := self multiWindowIndexForClassName: aClass. + index ~= 0 ifTrue: + [multiWindowState selectWindowIndex: index]. + self selectClass: aClass! Item was added: + ----- Method: Browser>>isDisplayingClass: (in category '*Morphic-Menus-DockingBar-accessing') ----- + isDisplayingClass: aClass + | className | + className := aClass name. + (self multiWindowIndexForClassName: className) ~= 0 ifTrue: [^true]. + ^selectedClassName = className! Item was added: + ----- Method: Browser>>multiWindowIndexForClassName: (in category '*Morphic-Menus-DockingBar-accessing') ----- + multiWindowIndexForClassName: className + "Answer the index of a browser displaying className in multiWindowState, if any. + Otherwise answer zero." + multiWindowState ifNil: [^0]. + multiWindowState models withIndexDo: + [:browser :index| + browser selectedClassName = className ifTrue: [^index]]. + ^0! Item was changed: ----- Method: SearchBar>>smartSearch:in: (in category 'searching') ----- smartSearch: text in: morph "Take the user input and perform an appropriate search" | input newContents | self removeResultsWidget. input := text asString ifEmpty:[^self]. self class useSmartSearch ifFalse: [^ ToolSet default browseMessageNames: input]. + (Symbol findInterned: input) ifNotNil: + [:symbol| input := symbol]. "If it is a global or a full class name, browse that class." + (Smalltalk bindingOf: input) ifNotNil: + [:assoc| | class | + class := (assoc value isBehavior ifTrue:[assoc value] ifFalse:[assoc value class]) theNonMetaClass. + Project current world submorphs do: + [:windowMorph| + (windowMorph isSystemWindow + and: [(windowMorph model isKindOf: Browser) + and: [windowMorph model isDisplayingClass: class]]) ifTrue: + [windowMorph beKeyWindow. + ^windowMorph model displayClass: class]]. + ^ToolSet browse: class selector: nil]. - (Smalltalk bindingOf: input) ifNotNil:[:assoc| | global | - global := assoc value. - ^ToolSet browse: (global isBehavior ifTrue:[global] ifFalse:[global class]) selector: nil]. "If it is a symbol and there are implementors of it, browse those implementors." Symbol hasInterned: input ifTrue: [:selector | (SystemNavigation new allImplementorsOf: selector) ifNotEmpty:[:list| ^SystemNavigation new browseMessageList: list name: 'Implementors of ' , input]]. "If it starts uppercase, browse classes if any. Otherwise, just search for messages." + input first isUppercase ifTrue: + [(UIManager default classFromPattern: input withCaption: '') + ifNotNil:[:aClass| ^ToolSet browse: aClass selector: nil]. + newContents := input, ' -- not found.'. + self searchTerm: newContents. + self selection: (input size+1 to: newContents size). + self currentHand newKeyboardFocus: morph textMorph. + ^ self]. + + "Default to browse message names..." + ToolSet default browseMessageNames: input! - input first isUppercase - ifTrue: [ - (UIManager default classFromPattern: input withCaption: '') - ifNotNil:[:aClass| ^ToolSet browse: aClass selector: nil] - ifNil: [ - newContents := input, ' -- not found.'. - self searchTerm: newContents. - self selection: (input size+1 to: newContents size). - self currentHand newKeyboardFocus: morph textMorph. - ^ self]] - ifFalse: [ - ToolSet default browseMessageNames: input].!

4 7

The Inbox: Collections-ul.933.mcz
by commits＠source.squeak.org 03 May '21

03 May '21

Levente Uzonyi uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-ul.933.mcz ==================== Summary ==================== Name: Collections-ul.933 Author: ul Time: 31 March 2021, 2:17:52.141067 am UUID: b290ad2c-2ed0-4d46-b2fe-12545bf5f31c Ancestors: Collections-ul.932 - use #ofSize: instead of #new: in SequenceableCollection class >> new:streamContents:, so that it creates a stream on a non-empty collection even if the receiver is OrderedCollection. =============== Diff against Collections-ul.932 =============== Item was changed: ----- Method: SequenceableCollection class>>new:streamContents: (in category 'stream creation') ----- new: newSize streamContents: blockWithArg | stream originalContents | + stream := WriteStream on: (self ofSize: newSize). - stream := WriteStream on: (self new: newSize). blockWithArg value: stream. originalContents := stream originalContents. + ^originalContents size = stream position + ifTrue: [ originalContents ] + ifFalse: [ stream contents ]! - originalContents size = stream position - ifTrue: [ ^originalContents ] - ifFalse: [ ^stream contents ]!

4 3

Wrote a little about OnScreenKeyboardMorph
by Tony Garnock-Jones 02 May '21

02 May '21

Hi all, I finally blogged about OnScreenKeyboardMorph: https://eighty-twenty.org/2021/04/20/on-screen-keyboard-morph Cheers, Tony

10 16

The Trunk: Tests-nice.458.mcz
by commits＠source.squeak.org 02 May '21

02 May '21

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.458.mcz ==================== Summary ==================== Name: Tests-nice.458 Author: nice Time: 28 April 2021, 6:11:51.033213 pm UUID: 13fec56a-805e-754e-bd02-8cbaa015e102 Ancestors: Tests-jr.457 Document the fact that becomeForward: does NOT forward identityHash of receiver anymore (since Collections-eem.885 April 2020) See #elementsForwardIdentityTo: vs #elementsForwardIdentityAndHashTo: See also http://forum.world.st/How-to-become-immediate-objects-td5114931.html =============== Diff against Tests-jr.457 =============== Item was changed: ----- Method: BecomeTest>>testBecomeForward (in category 'tests') ----- testBecomeForward "Test the forward become." | a b c d | a := 'ab' copy. b := 'cd' copy. + c := Array with: a. - c := a. d := b. a becomeForward: b. self assert: a = 'cd'; assert: b = 'cd'; + assert: a == b; + assert: c first == b; + assert: d == b. - assert: c = 'cd'; - assert: d = 'cd'. - ! Item was added: + ----- Method: BecomeTest>>testBecomeForwardCopyIdentityHash (in category 'tests') ----- + testBecomeForwardCopyIdentityHash + "Check that + 1. the argument to becomeForward: is modified to have the receiver's identity hash. + 2. the receiver's identity hash is unchanged." + + | a b ha | + + a := 'ab' copy. + b := 'cd' copy. + ha := a identityHash. + + a becomeForward: b copyHash: true. + + self + assert: a identityHash = ha; + assert: b identityHash = ha. + + ! Item was changed: ----- Method: BecomeTest>>testBecomeForwardDontCopyIdentityHash (in category 'tests') ----- testBecomeForwardDontCopyIdentityHash "Check that 1. the argument to becomeForward: is NOT modified to have the receiver's identity hash. + 2. the receiver's identity hash is changed." - 2. the receiver's identity hash is unchanged." | a b hb | a := 'ab' copy. b := 'cd' copy. hb := b identityHash. a becomeForward: b copyHash: false. self assert: a identityHash = hb; assert: b identityHash = hb. ! Item was changed: ----- Method: BecomeTest>>testBecomeForwardIdentityHash (in category 'tests') ----- testBecomeForwardIdentityHash + "Document that the receiver hash is changed, but the argument hash is unchanged. + (a becomeForward: b) has thus same effect as (a becomeForward: b copyHash: false)" - "Check that - 1. the argument to becomeForward: is modified to have the receiver's identity hash. - 2. the receiver's identity hash is unchanged." + | a b hb | - | a b ha | a := 'ab' copy. b := 'cd' copy. + hb := b identityHash. - ha := a identityHash. a becomeForward: b. self + assert: a identityHash = hb; + assert: b identityHash = hb. - assert: a identityHash = ha; - assert: b identityHash = ha. !

5 8

The Inbox: Kernel-nice.1391.mcz
by commits＠source.squeak.org 02 May '21

02 May '21

Nicolas Cellier uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-nice.1391.mcz ==================== Summary ==================== Name: Kernel-nice.1391 Author: nice Time: 23 April 2021, 10:58:48.925778 am UUID: bde1d6d3-e3ba-48ad-b432-3ac5a1531880 Ancestors: Kernel-nice.1390 Remove the questionable ifCurtailed: block that did reactivate the handler in handleSignal:, and make the handling symetric, whether the handlerAction explicitily use exception return or not. Document the mysterious tempAt:/tempAt:put: intention by using proper method names as requested by Marcel. The slowdown shall be marginal, and system understanding should be improved. Provide messages to selectively reactivate some handler contexts. For gurus: handle with care! =============== Diff against Kernel-nice.1390 =============== Item was changed: ----- Method: Context>>canHandleSignal: (in category 'private-exceptions') ----- canHandleSignal: exception "Sent to handler (on:do:) contexts only. If my exception class (first arg) handles exception then return true, otherwise forward this message to the next handler context. If none left, return false (see nil>>canHandleSignal:)" + ^ (self willHandleSignal: exception) - ^ (((self tempAt: 1) handles: exception) and: [self tempAt: 3]) or: [self nextHandlerContext canHandleSignal: exception]. ! Item was added: + ----- Method: Context>>deactivateHandler (in category 'private-exceptions') ----- + deactivateHandler + "Private - sent to exception handler context only (on:do:)" + + stackp >= 3 ifTrue: [self tempAt: 3 put: false] "this is temporary handlerActive in #on:do:"! Item was added: + ----- Method: Context>>fireHandlerActionWith: (in category 'private-exceptions') ----- + fireHandlerActionWith: exception + "Sent to handler (on:do:) contexts only. + Perform the second argument, which is the handler action" + + ^(self tempAt: 2) cull: exception! Item was changed: ----- Method: Context>>handleSignal: (in category 'private-exceptions') ----- handleSignal: exception "Sent to handler (on:do:) contexts only. If my exception class (first arg) handles exception and the handler is active then execute my handle block (second arg), otherwise forward this message to the next handler context. If none left, execute exception's defaultAction (see nil>>handleSignal:)." + | val | + (self willHandleSignal: exception) ifFalse: + [self deactivateHandler. - | handlerActive val | - "If the context has been returned from the handlerActive temp var may not be accessible." - handlerActive := stackp >= 3 and: [(self tempAt: 3) == true]. - (((self tempAt: 1) handles: exception) and: [handlerActive]) ifFalse: - [stackp >= 3 ifTrue: [self tempAt: 3 put: false]. ^self nextHandlerContext handleSignal: exception]. exception privHandlerContext: self contextTag. + self deactivateHandler. "disable self while executing handle block" + val := self fireHandlerActionWith: exception. - self tempAt: 3 put: false. "disable self while executing handle block" - val := [(self tempAt: 2) cull: exception] - ifCurtailed: [self tempAt: 3 put: true]. self return: val "return from self if not otherwise directed in handle block" ! Item was added: + ----- Method: Context>>isHandlerActive (in category 'private-exceptions') ----- + isHandlerActive + "Private - sent to exception handler context only (on:do:)" + + ^stackp >= 3 and: [(self tempAt: 3) == true] "this is temporary handlerActive in #on:do:"! Item was added: + ----- Method: Context>>reactivateHandler (in category 'private-exceptions') ----- + reactivateHandler + "Private - sent to exception handler context only (on:do:)" + + stackp >= 3 ifTrue: [self tempAt: 3 put: true] "this is temporary handlerActive in #on:do:"! Item was changed: ----- Method: Context>>reactivateHandlers (in category 'private-exceptions') ----- reactivateHandlers "Private - sent to exception handler context only (on:do:). Reactivate all the handlers into the chain" + self reactivateHandler. - self tempAt: 3 put: true. "this is temporary handlerActive in #on:do:" self nextHandlerContext reactivateHandlers! Item was added: + ----- Method: Context>>reactivateHandlersUpTo: (in category 'private-exceptions') ----- + reactivateHandlersUpTo: aHandlerContext + "Private - sent to exception handler context only (on:do:). + Reactivate the inner handlers into the chain, up to, but not including, aHandlerContext" + + self == aHandlerContext ifTrue: [^self]. + self reactivateHandler. + self nextHandlerContext reactivateHandlersUpTo: aHandlerContext! Item was added: + ----- Method: Context>>reactivateHandlersWhich:upTo: (in category 'private-exceptions') ----- + reactivateHandlersWhich: selectBlock upTo: aHandlerContext + "Private - sent to exception handler context only (on:do:). + Reactivate the inner handlers into the chain, up to, but not including, aHandlerContext, that satisfy the selectBlock predicate" + + self == aHandlerContext ifTrue: [^self]. + (selectBlock value: self) ifTrue: [self reactivateHandler]. + self nextHandlerContext reactivateHandlersWhich: selectBlock upTo: aHandlerContext! Item was changed: ----- Method: Context>>rearmHandlerDuring: (in category 'private-exceptions') ----- rearmHandlerDuring: aBlock "Sent to handler (on:do:) contexts only. Makes me re-entrant for the duration of aBlock. Only works in a closure-enabled image" + ^ [self reactivateHandler. aBlock value] + ensure: [self deactivateHandler]! - ^ [self tempAt: 3 put: true. aBlock value] - ensure: [self tempAt: 3 put: false]! Item was added: + ----- Method: Context>>willHandleSignal: (in category 'private-exceptions') ----- + willHandleSignal: exception + "Sent to handler (on:do:) contexts only." + + ^self isHandlerActive and: [(self tempAt: 1) handles: exception] + ! Item was added: + ----- Method: Exception>>reactivateHandlersUpTo: (in category 'priv handling') ----- + reactivateHandlersUpTo: aHandlerContext + "reactivate all the exception handlers in the context chain" + self canSearchForSignalerContext + ifTrue: [signalContext nextHandlerContext reactivateHandlersUpTo: aHandlerContext]! Item was added: + ----- Method: UndefinedObject>>reactivateHandlersUpTo: (in category 'bottom context') ----- + reactivateHandlersUpTo: aHandlerContext + + ^ self! Item was added: + ----- Method: UndefinedObject>>reactivateHandlersWhich:upTo: (in category 'bottom context') ----- + reactivateHandlersWhich: selectBlock upTo: aHandlerContext + + ^ self!

3 4

← Newer
1
...
6
7
8
9
10
11
12
...
40
Older →

Jump to page: