Squeak-dev May 2021

squeak-dev@lists.squeakfoundation.org

32 participants
344 discussions

The Inbox: Tools-ct.962.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.962.mcz ==================== Summary ==================== Name: Tools-ct.962 Author: ct Time: 20 March 2020, 6:58:18.856237 pm UUID: c4cbd7b0-ddf5-3b4b-93ed-55e5b2c80465 Ancestors: Tools-mt.955 Makes variable bindings in Workspace more comfortable: - Ask for a useful variable name when dropping something into a workspace - Validate variable name before creating inaccessible bindings - Do not propose invalid names at all (for example, dropped class were given an invalid name in the past) - Ask before removing variable bindings. This also increases responsiveness of the UI. - Improves multilingual support =============== Diff against Tools-mt.955 =============== Item was changed: ----- Method: Workspace>>acceptDroppingMorph:event:inMorph: (in category 'drag and drop') ----- acceptDroppingMorph: dropee event: evt inMorph: targetMorph + "Return the dropee to its old position, and add a reference to it at the cursor point." + - "Return the dropee to its old position, and add a reference to it at the - cursor point." | bindingName externalName reference | (dropee isKindOf: TransferMorph) ifTrue: [reference := dropee passenger. externalName := dropee passenger className] ifFalse: [reference := dropee. externalName := dropee externalName]. externalName := externalName isOctetString + ifTrue: [externalName] + ifFalse: ['a' , externalName]. + + bindingName := Project uiManager + request: 'Please enter a name for the dropped object:' translated + initialAnswer: (externalName withFirstCharacterDownshifted , reference identityHash printString) asLegalSelector. + bindingName isEmptyOrNil ifTrue: [^ false]. + bindingName := Parser new parseSelector: bindingName. + bindingName ifNil: [ + self inform: 'Invalid selector.' translated. + ^ false]. + - ifTrue: [externalName] - ifFalse: ['a' , externalName]. - bindingName := externalName withFirstCharacterDownshifted , reference identityHash printString. - targetMorph correctSelectionWithString: bindingName , ' '. (self bindingOf: bindingName) value: reference. + targetMorph correctSelectionWithString: bindingName , ' '. (dropee isKindOf: TransferMorph) ifFalse: [dropee rejectDropMorphEvent: evt]. + ^ true "success"! - ^ true"success"! Item was changed: ----- Method: Workspace>>addModelItemsToWindowMenu: (in category 'menu commands') ----- addModelItemsToWindowMenu: aMenu aMenu addLine. aMenu + add: 'save contents to file...' translated - add: 'save contents to file...' target: self action: #saveContentsInFile. aMenu + add: 'inspect variables' translated - add: 'inspect variables' target: self action: #inspectBindings. aMenu + add: 'reset variables' translated - add: 'reset variables' target: self + action: #resetBindings. - action: #initializeBindings. aMenu addUpdating: #mustDeclareVariableWording target: self action: #toggleVariableDeclarationMode. aMenu addUpdating: #acceptDroppedMorphsWording target: self action: #toggleDroppingMorphForReference. + self addToggleStylingMenuItemTo: aMenu.! - self addToggleStylingMenuItemTo: aMenu. - ! Item was added: + ----- Method: Workspace>>resetBindings (in category 'menu commands') ----- + resetBindings + + (self bindings notEmpty ==> [self confirm: ('Are you sure you would like to remove {1} variables?' translated format: {self bindings size})]) + ifFalse: [^ self]. + self initializeBindings.!

5 7

The Inbox: System-ct.1156.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1156.mcz ==================== Summary ==================== Name: System-ct.1156 Author: ct Time: 5 May 2020, 5:41:10.96399 pm UUID: 2ce2496e-92e9-f744-9a58-d9e9320adfab Ancestors: System-mt.1155 Fixes double prompt for handling a dropped file when the first dialog was cancelled. Cleans up duplication between ExternalDropHandler >> #lookupServiceBasedHandler: and DefaultExternalDropHandler by deprecating the first one. Maybe we can also remove this method? =============== Diff against System-mt.1155 =============== Item was changed: ----- Method: DefaultExternalDropHandler>>chooseServiceFrom: (in category 'private') ----- chooseServiceFrom: aCollection + "private - choose a service from aCollection asking the user if needed" + ^ aCollection size = 1 - "private - choose a service from aCollection asking the user if needed" - ^aCollection size = 1 ifTrue: [aCollection anyOne] + ifFalse: [UIManager default + chooseFrom: (aCollection collect: [:each | each label]) - ifFalse:[UIManager default - chooseFrom: (aCollection collect:[:each| each label]) values: aCollection title: 'You dropped a file. Please choose a service:' translated withCRs].! Item was changed: ----- Method: DefaultExternalDropHandler>>handle:in:dropEvent: (in category 'event handling') ----- handle: dropStream in: pasteUp dropEvent: anEvent "the file was just droped, let's do our job" | fileName services chosen | fileName := dropStream name. services := self servicesForFileNamed: fileName. + - "no service, default behavior" + services ifEmpty: [ + ^ UIManager default edit: dropStream contentsOfEntireFile]. + - services isEmpty - ifTrue: [^UIManager default edit: dropStream contentsOfEntireFile]. - chosen := self chooseServiceFrom: services. + chosen ifNotNil: [chosen performServiceFor: dropStream].! - chosen ifNotNil:[chosen performServiceFor: dropStream]! Item was changed: ----- Method: DefaultExternalDropHandler>>servicesForFileNamed: (in category 'private') ----- servicesForFileNamed: aString + "private - answer a collection of file-services for the file named aString" + + ^ (FileServices itemsForFile: aString) + copyWithoutAll: self unwantedSelectors! - "private - answer a collection of file-services for the file named - aString" - | allServices | - allServices := FileServices itemsForFile: aString. - ^ allServices - reject: [:svc | self unwantedSelectors includes: svc selector]! Item was changed: ----- Method: ExternalDropHandler class>>defaultHandler (in category 'accessing') ----- defaultHandler + + ^ DefaultHandler ifNil: [ + DefaultHandler := ExternalDropHandler + type: nil + extension: nil + action: #edit]! - DefaultHandler ifNil: [DefaultHandler := ExternalDropHandler type: nil extension: nil action: [:dropStream | dropStream edit]]. - ^DefaultHandler! Item was changed: ----- Method: ExternalDropHandler class>>lookupExternalDropHandler: (in category 'accessing') ----- lookupExternalDropHandler: stream | types extension serviceHandler | types := stream mimeTypes. types ifNotNil: [ + self registeredHandlers + detect: [:handler | handler matchesTypes: types] + ifFound: [:handler | ^ handler]]. - self registeredHandlers do: [:handler | - (handler matchesTypes: types) - ifTrue: [^handler]]]. extension := FileDirectory extensionFor: stream name. + self registeredHandlers + detect: [:handler | handler matchesExtension: extension] + ifFound: [:handler | ^ handler]. + + ^ serviceHandler ifNil: [self defaultHandler]! - self registeredHandlers do: [:handler | - (handler matchesExtension: extension) - ifTrue: [^handler]]. - serviceHandler := self lookupServiceBasedHandler: stream. - ^serviceHandler - ifNil: [self defaultHandler]! Item was changed: ----- Method: ExternalDropHandler class>>lookupServiceBasedHandler: (in category 'accessing') ----- lookupServiceBasedHandler: dropStream + - "The file was just dropped; let's do our job" | fileName services theOne | + self deprecated: 'ct: Use DefaultExternalDropHandler'. fileName := dropStream name. - services := (FileServices itemsForFile: fileName) reject: [:svc | self unwantedSelectors includes: svc selector]. + - "no service, default behavior" + services ifEmpty: [^ nil]. + - services isEmpty - ifTrue: [^nil]. - theOne := self chooseServiceFrom: services. + ^ theOne ifNotNil: [ + ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]! - ^theOne - ifNotNil: [ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]!

3 3

The Inbox: ShoutCore-ct.69.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.69.mcz ==================== Summary ==================== Name: ShoutCore-ct.69 Author: ct Time: 14 August 2019, 10:43:04.7164 pm UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8 Ancestors: ShoutCore-ul.68 Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements Thanks Jakob for the report! =============== Diff against ShoutCore-ul.68 =============== Item was changed: ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') ----- parseBlockArguments currentTokenFirst == $: ifFalse: [ ^self ]. [ currentTokenFirst == $: ] whileTrue: [ self scanPast: #blockArgColon; parseArgument: #blockPatternArg ]. + ((self parseVerticalBarForTemporaries: #blockArgsBar) and: [ + currentTokenFirst ~= $] ]) + ifFalse: [ + self fail ": Missing block args bar" ]! - (self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [ - self fail ": Missing block args bar" ]!

12 25

The Inbox: Tools-ct.937.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.937.mcz ==================== Summary ==================== Name: Tools-ct.937 Author: ct Time: 29 January 2020, 6:26:57.711894 pm UUID: 34af35bc-83e2-9b40-9aa3-8f6af607ac6e Ancestors: Tools-mt.929 Fixes a styling issue in the Workspace that missstyled class variables from Object as invalid (that is DependentsFields). This is a bug because you can access DependentsFields indeed. There is a subtle but important difference between the classOrMetaclass nil and the classOrMetaclass Object: The former does not respect any state for styling, but the latter respects class variables from Object (as well as, hypothetically, ProtoObject). Please note that it would be even more accurate to specify nil class instead of Object here, but I don't know whether we really want to emphasize the nuances of UndefinedObject. It feels rather like an implementation detail for me, at least in this context. (Just imagine UndefinedObject had a UniqueInstance class variable - would we really to access it from any Workspace?) Open for opinions. =============== Diff against Tools-mt.929 =============== Item was changed: ----- Method: Workspace>>aboutToStyle: (in category 'code pane') ----- aboutToStyle: aStyler self shouldStyle ifFalse: [ ^false ]. + aStyler + parseAMethod: false; + classOrMetaClass: Object; - aStyler - classOrMetaClass: nil; workspace: self. ^true!

4 3

The Inbox: KernelTests-jar.407.mcz
by commits＠source.squeak.org 29 Nov '21

29 Nov '21

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.407.mcz ==================== Summary ==================== Name: KernelTests-jar.407 Author: jar Time: 31 May 2021, 11:19:58.858017 pm UUID: 8bb4554a-971d-ea49-9396-6a0c1625fb5b Ancestors: KernelTests-nice.404 Add a test #testTerminateInEnsure presented by Martin McClure at 2019 Smalltalk conference. Test unwind when a process gets terminated inside the #ensure unwind block. Complement latest #terminate in the Inbox. Supersede KernelTests-jar.405 - fix underscores from Cuis =============== Diff against KernelTests-nice.404 =============== Item was added: + ----- Method: ProcessTest>>testTerminateInEnsure (in category 'tests') ----- + testTerminateInEnsure + "As shown in + Martin McClure's 'Threads, Critical Sections, and Termination' (Smalltalks 2019 conference) + https://youtu.be/AvM5YrjK9AE + at 23:17 + self new testTerminateInEnsure + " + | process count random delay | + random := Random new. + 10 timesRepeat: [ + process := [ + count := 0. + [] ensure: [ + 10 timesRepeat: [ + count := count + 1. + 1000000 timesRepeat: [12 factorial]]. + count := count + 1] + ] forkAt: Processor activeProcess priority - 1. + delay := (random next * 100) asInteger + 10. "avoid 0-ms delay" + (Delay forMilliseconds: delay) wait. + self assert: process isTerminated not. + process terminate. + process priority: Processor activeProcess priority + 1. + self + assert: process isTerminated; + assert: count equals: 11 ]!

2 1

Merge Request: #caseOf:otherwise: with arguments
by Thiede, Christoph 28 Nov '21

28 Nov '21

This changeset makes it possible to accept an argument in the otherwise block of a #caseOf:otherwise: call. Diff of the #caseOf:otherwise: implementation: caseOf: aBlockAssociationCollection otherwise: aBlock "The elements of aBlockAssociationCollection are associations between blocks. Answer the evaluated value of the first association in aBlockAssociationCollection whose evaluated key equals the receiver. If no match is found, answer the result of evaluating aBlock." aBlockAssociationCollection associationsDo: [:assoc | (assoc key value = self) ifTrue: [^assoc value value]]. - ^ aBlock value + ^ aBlock cull: self "| z | z := {[#a]->[1+1]. ['b' asSymbol]->[2+2]. [#c]->[3+3]}. #b caseOf: z otherwise: [0]" "| z | z := {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]}. #b caseOf: z otherwise: [0]" "The following are compiled in-line:" "#b caseOf: {[#a]->[1+1]. ['b' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [0]" "#b caseOf: {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [0]" + "#b caseOf: {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [:x | x halt]" Furthermore, the changeset includes a necessary modification of MessageNode >> #transformCase: so that the otherwise argument can be compiled in-line. Last but not least, I wrote some tests for #caseOf:[otherwise:]. Please review! (In a later change, it would be possible to allow arguments for the association key blocks as well. But I love short feedback loops, so let's assess this one first :-)) Best, Christoph

4 9

The Inbox: ShoutTests-ct.34.mcz
by commits＠source.squeak.org 25 Nov '21

25 Nov '21

A new version of ShoutTests was added to project The Inbox: http://source.squeak.org/inbox/ShoutTests-ct.34.mcz ==================== Summary ==================== Name: ShoutTests-ct.34 Author: ct Time: 7 April 2021, 5:20:15.847598 pm UUID: a7f39f26-a6fb-f44e-aabb-931714b56ed8 Ancestors: ShoutTests-mt.33 Document a present bug that occurs when styling a method that contains multiple unary selectors after a cascade. =============== Diff against ShoutTests-mt.33 =============== Item was added: + ----- Method: SHParserST80Test>>testChainAfterCascade (in category 'tests') ----- + testChainAfterCascade + + | types s | + s := 'x 1 positive; negative not'. + + types := self tokenTypesIn: s. + + self + assert: #(patternUnary number unary cascadeSeparator unary excessCode) + equals: types.!

3 2

The Trunk: Tools-mt.1056.mcz
by commits＠source.squeak.org 22 Nov '21

22 Nov '21

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1056.mcz ==================== Summary ==================== Name: Tools-mt.1056 Author: mt Time: 18 May 2021, 1:58:25.950287 pm UUID: f32e4e04-6f83-d641-ba5a-0de0c535aa73 Ancestors: Tools-mt.1055 Tweak #embedTranscript to only apply when opening a regular workspace via class-side #open. Note that the workspace model is re-used for other purposes such as string edit. See UIManager. Adds new preference to file-out workspace contents on accept. Thanks to Jaromir for the idea! Preference is enabled by default since there was noe default accept-action in workspaces yet. =============== Diff against Tools-mt.1055 =============== Item was changed: StringHolder subclass: #Workspace instanceVariableNames: 'bindings acceptDroppedMorphs acceptAction mustDeclareVariables shouldStyle environment' + classVariableNames: 'DeclareVariablesAutomatically EmbedTranscript FileOutFilePath FileOutOnAccept LookupPools ShouldStyle' - classVariableNames: 'DeclareVariablesAutomatically EmbedTranscript LookupPools ShouldStyle' poolDictionaries: '' category: 'Tools-Base'! !Workspace commentStamp: 'fbs 6/2/2012 20:46' prior: 0! A Workspace is a text area plus a lot of support for executable code. It is a great place to execute top-level commands to compute something useful, and it is a great place to develop bits of a program before those bits get put into class methods. To open a new workspace, execute: Workspace open A workspace can have its own variables, called "workspace variables", to hold intermediate results. For example, if you type into a workspace "x := 5" and do-it, then later you could type in "y := x * 2" and y would become 10. Additionally, in Morphic, a workspace can gain access to morphs that are on the screen. If acceptDroppedMorphs is turned on, then whenever a morph is dropped on the workspace, a variable will be created which references that morph. This functionality is toggled with the window-wide menu of a workspace. The instance variables of this class are: bindings - holds the workspace variables for this workspace acceptDroppedMorphs - whether dropped morphs should create new variables! Item was changed: ----- Method: Workspace class>>embedTranscript (in category 'preferences') ----- embedTranscript <preference: 'Embed a Transcript in Workspace' + categoryList: #('browsing' 'tools') - category: 'browsing' description: 'If true, new workspaces will open with an embedded Transcript.' type: #Boolean> ^ EmbedTranscript ifNil: [ false ]! Item was added: + ----- Method: Workspace class>>fileOut: (in category 'support') ----- + fileOut: contents + "Write the given contents into the workspace file-out file path." + + | filePath | + filePath := self fileOutFilePath. + (FileDirectory default on: filePath) containingDirectory assureExistence. + FileStream + fileNamed: filePath + do: [:stream | + stream + setToEnd; + nextPutAll: '"----ACCEPT----'; + nextPutAll: DateAndTime now asString; + nextPutAll: '"'; + cr; nextPutAll: contents; cr]. + Transcript showln: 'Workspace contents successfully appended to: ', filePath printString.! Item was added: + ----- Method: Workspace class>>fileOutFilePath (in category 'preferences') ----- + fileOutFilePath + <preference: 'File-out file path for workspace' + categoryList: #('browsing' 'tools') + description: 'Set the file-out location for #fileOutOnAccept in workspaces.' + type: #String> + ^ FileOutFilePath ifNil: [ 'workspace.st' ]! Item was added: + ----- Method: Workspace class>>fileOutFilePath: (in category 'preferences') ----- + fileOutFilePath: aString + + FileOutFilePath := aString.! Item was added: + ----- Method: Workspace class>>fileOutOnAccept (in category 'preferences') ----- + fileOutOnAccept + <preference: 'File-out workspace contents on accept' + categoryList: #('browsing' 'tools') + description: 'If true, accepting contents in a workspace will append them to a known location in the file system. See #fileOutFilePath.' + type: #Boolean> + ^ FileOutOnAccept ifNil: [ true ]! Item was added: + ----- Method: Workspace class>>fileOutOnAccept: (in category 'preferences') ----- + fileOutOnAccept: aBoolean + + FileOutOnAccept := aBoolean.! Item was added: + ----- Method: Workspace class>>open (in category 'instance creation') ----- + open + + | workspace | + workspace := self new. + self fileOutOnAccept ifTrue: [ + workspace acceptAction: [:string | self fileOut: string]]. + ^ self embedTranscript + ifTrue: [workspace buildAndOpenWorkspaceTranscript] + ifFalse: [workspace buildAndOpen]! Item was added: + ----- Method: Workspace>>buildAndOpen (in category 'toolbuilder') ----- + buildAndOpen + + ToolBuilder default open: self. + ^ self! Item was added: + ----- Method: Workspace>>buildAndOpenWorkspaceTranscript (in category 'toolbuilder') ----- + buildAndOpenWorkspaceTranscript + + | windowSpec builder | + builder := ToolBuilder default. + windowSpec := self buildWindowWith: builder specs: { + (0.0 @ 0.0 corner: 1.0 @ 0.6) -> [self buildCodePaneWith: builder]. + (0.0 @ 0.6 corner: 1.0 @ 1.0) -> [self buildTranscriptWith: builder]. + }. + builder open: windowSpec. + ^ self! Item was removed: - ----- Method: Workspace>>buildWith: (in category 'toolbuilder') ----- - buildWith: builder - - ^ self class embedTranscript - ifTrue: [self buildWorkspaceTranscriptWith: builder] - ifFalse: [super buildWith: builder]! Item was removed: - ----- Method: Workspace>>buildWorkspaceTranscriptWith: (in category 'toolbuilder') ----- - buildWorkspaceTranscriptWith: builder - - | windowSpec | - windowSpec := self buildWindowWith: builder specs: { - (0.0 @ 0.0 corner: 1.0 @ 0.6) -> [self buildCodePaneWith: builder]. - (0.0 @ 0.6 corner: 1.0 @ 1.0) -> [self buildTranscriptWith: builder]. - }. - ^builder build: windowSpec!

2 1

stepping over non local return in a protected block
by Nicolas Cellier 20 Nov '21

20 Nov '21

When debugging things like this: [^2] ensure: [Transcript cr; show: 'done']. if we step into the protected block [^2], then step over ^2, we incorrectly get a BlockCannotReturn. In deeper stacks, I saw some weirder behaviour (when debugging test03EventHandler I put a halt into m on: #mouseDown send: #value: to:[:evt| self halt. evt redButtonPressed ifTrue:[m color: Color red]. evt yellowButtonPressed ifTrue:[m color: Color yellow]. evt blueButtonPressed ifTrue:[m color: Color blue]]. and stepped over such a [^...] ensure: - result is very hard to understand/trace) I'm pretty sure this has been thoroughly investigated and discussed during the last year or so (I remember of some infinite debugger thread and some hard work of Christoph). After the integration of many fixes in exception handling, process termination, unwinding, and simulation machinery, thanks to Jaromir, Marcel, Christoph, ... (apologies to whoever I forgot), maybe it's time to revisit this problem. Christoph, if you still have brain cells unburnt by this problem ;)

7 18

Merge Request: removeClass.cs
by Thiede, Christoph 18 Nov '21

18 Nov '21

This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove as we know it from #removeMessage. [cid:21b5558d-d73d-4d2c-bcc4-eeb40f7dee49] Please merge or give me feedback for improvements. :-) Best, Christoph

2 9

← Newer
1
...
4
5
6
7
8
9
10
...
35
Older →

Jump to page: