Squeak-dev August 2021

squeak-dev@lists.squeakfoundation.org

18 participants
222 discussions

The Inbox: ShoutTests-ct.34.mcz
by commits＠source.squeak.org 25 Nov '21

25 Nov '21

A new version of ShoutTests was added to project The Inbox: http://source.squeak.org/inbox/ShoutTests-ct.34.mcz ==================== Summary ==================== Name: ShoutTests-ct.34 Author: ct Time: 7 April 2021, 5:20:15.847598 pm UUID: a7f39f26-a6fb-f44e-aabb-931714b56ed8 Ancestors: ShoutTests-mt.33 Document a present bug that occurs when styling a method that contains multiple unary selectors after a cascade. =============== Diff against ShoutTests-mt.33 =============== Item was added: + ----- Method: SHParserST80Test>>testChainAfterCascade (in category 'tests') ----- + testChainAfterCascade + + | types s | + s := 'x 1 positive; negative not'. + + types := self tokenTypesIn: s. + + self + assert: #(patternUnary number unary cascadeSeparator unary excessCode) + equals: types.!

3 2

The Trunk: Tools-mt.1056.mcz
by commits＠source.squeak.org 22 Nov '21

22 Nov '21

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1056.mcz ==================== Summary ==================== Name: Tools-mt.1056 Author: mt Time: 18 May 2021, 1:58:25.950287 pm UUID: f32e4e04-6f83-d641-ba5a-0de0c535aa73 Ancestors: Tools-mt.1055 Tweak #embedTranscript to only apply when opening a regular workspace via class-side #open. Note that the workspace model is re-used for other purposes such as string edit. See UIManager. Adds new preference to file-out workspace contents on accept. Thanks to Jaromir for the idea! Preference is enabled by default since there was noe default accept-action in workspaces yet. =============== Diff against Tools-mt.1055 =============== Item was changed: StringHolder subclass: #Workspace instanceVariableNames: 'bindings acceptDroppedMorphs acceptAction mustDeclareVariables shouldStyle environment' + classVariableNames: 'DeclareVariablesAutomatically EmbedTranscript FileOutFilePath FileOutOnAccept LookupPools ShouldStyle' - classVariableNames: 'DeclareVariablesAutomatically EmbedTranscript LookupPools ShouldStyle' poolDictionaries: '' category: 'Tools-Base'! !Workspace commentStamp: 'fbs 6/2/2012 20:46' prior: 0! A Workspace is a text area plus a lot of support for executable code. It is a great place to execute top-level commands to compute something useful, and it is a great place to develop bits of a program before those bits get put into class methods. To open a new workspace, execute: Workspace open A workspace can have its own variables, called "workspace variables", to hold intermediate results. For example, if you type into a workspace "x := 5" and do-it, then later you could type in "y := x * 2" and y would become 10. Additionally, in Morphic, a workspace can gain access to morphs that are on the screen. If acceptDroppedMorphs is turned on, then whenever a morph is dropped on the workspace, a variable will be created which references that morph. This functionality is toggled with the window-wide menu of a workspace. The instance variables of this class are: bindings - holds the workspace variables for this workspace acceptDroppedMorphs - whether dropped morphs should create new variables! Item was changed: ----- Method: Workspace class>>embedTranscript (in category 'preferences') ----- embedTranscript <preference: 'Embed a Transcript in Workspace' + categoryList: #('browsing' 'tools') - category: 'browsing' description: 'If true, new workspaces will open with an embedded Transcript.' type: #Boolean> ^ EmbedTranscript ifNil: [ false ]! Item was added: + ----- Method: Workspace class>>fileOut: (in category 'support') ----- + fileOut: contents + "Write the given contents into the workspace file-out file path." + + | filePath | + filePath := self fileOutFilePath. + (FileDirectory default on: filePath) containingDirectory assureExistence. + FileStream + fileNamed: filePath + do: [:stream | + stream + setToEnd; + nextPutAll: '"----ACCEPT----'; + nextPutAll: DateAndTime now asString; + nextPutAll: '"'; + cr; nextPutAll: contents; cr]. + Transcript showln: 'Workspace contents successfully appended to: ', filePath printString.! Item was added: + ----- Method: Workspace class>>fileOutFilePath (in category 'preferences') ----- + fileOutFilePath + <preference: 'File-out file path for workspace' + categoryList: #('browsing' 'tools') + description: 'Set the file-out location for #fileOutOnAccept in workspaces.' + type: #String> + ^ FileOutFilePath ifNil: [ 'workspace.st' ]! Item was added: + ----- Method: Workspace class>>fileOutFilePath: (in category 'preferences') ----- + fileOutFilePath: aString + + FileOutFilePath := aString.! Item was added: + ----- Method: Workspace class>>fileOutOnAccept (in category 'preferences') ----- + fileOutOnAccept + <preference: 'File-out workspace contents on accept' + categoryList: #('browsing' 'tools') + description: 'If true, accepting contents in a workspace will append them to a known location in the file system. See #fileOutFilePath.' + type: #Boolean> + ^ FileOutOnAccept ifNil: [ true ]! Item was added: + ----- Method: Workspace class>>fileOutOnAccept: (in category 'preferences') ----- + fileOutOnAccept: aBoolean + + FileOutOnAccept := aBoolean.! Item was added: + ----- Method: Workspace class>>open (in category 'instance creation') ----- + open + + | workspace | + workspace := self new. + self fileOutOnAccept ifTrue: [ + workspace acceptAction: [:string | self fileOut: string]]. + ^ self embedTranscript + ifTrue: [workspace buildAndOpenWorkspaceTranscript] + ifFalse: [workspace buildAndOpen]! Item was added: + ----- Method: Workspace>>buildAndOpen (in category 'toolbuilder') ----- + buildAndOpen + + ToolBuilder default open: self. + ^ self! Item was added: + ----- Method: Workspace>>buildAndOpenWorkspaceTranscript (in category 'toolbuilder') ----- + buildAndOpenWorkspaceTranscript + + | windowSpec builder | + builder := ToolBuilder default. + windowSpec := self buildWindowWith: builder specs: { + (0.0 @ 0.0 corner: 1.0 @ 0.6) -> [self buildCodePaneWith: builder]. + (0.0 @ 0.6 corner: 1.0 @ 1.0) -> [self buildTranscriptWith: builder]. + }. + builder open: windowSpec. + ^ self! Item was removed: - ----- Method: Workspace>>buildWith: (in category 'toolbuilder') ----- - buildWith: builder - - ^ self class embedTranscript - ifTrue: [self buildWorkspaceTranscriptWith: builder] - ifFalse: [super buildWith: builder]! Item was removed: - ----- Method: Workspace>>buildWorkspaceTranscriptWith: (in category 'toolbuilder') ----- - buildWorkspaceTranscriptWith: builder - - | windowSpec | - windowSpec := self buildWindowWith: builder specs: { - (0.0 @ 0.0 corner: 1.0 @ 0.6) -> [self buildCodePaneWith: builder]. - (0.0 @ 0.6 corner: 1.0 @ 1.0) -> [self buildTranscriptWith: builder]. - }. - ^builder build: windowSpec!

2 1

stepping over non local return in a protected block
by Nicolas Cellier 20 Nov '21

20 Nov '21

When debugging things like this: [^2] ensure: [Transcript cr; show: 'done']. if we step into the protected block [^2], then step over ^2, we incorrectly get a BlockCannotReturn. In deeper stacks, I saw some weirder behaviour (when debugging test03EventHandler I put a halt into m on: #mouseDown send: #value: to:[:evt| self halt. evt redButtonPressed ifTrue:[m color: Color red]. evt yellowButtonPressed ifTrue:[m color: Color yellow]. evt blueButtonPressed ifTrue:[m color: Color blue]]. and stepped over such a [^...] ensure: - result is very hard to understand/trace) I'm pretty sure this has been thoroughly investigated and discussed during the last year or so (I remember of some infinite debugger thread and some hard work of Christoph). After the integration of many fixes in exception handling, process termination, unwinding, and simulation machinery, thanks to Jaromir, Marcel, Christoph, ... (apologies to whoever I forgot), maybe it's time to revisit this problem. Christoph, if you still have brain cells unburnt by this problem ;)

7 18

Merge Request: removeClass.cs
by Thiede, Christoph 18 Nov '21

18 Nov '21

This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove as we know it from #removeMessage. [cid:21b5558d-d73d-4d2c-bcc4-eeb40f7dee49] Please merge or give me feedback for improvements. :-) Best, Christoph

2 9

The Inbox: Kernel-jar.1414.mcz
by commits＠source.squeak.org 17 Nov '21

17 Nov '21

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-jar.1414.mcz ==================== Summary ==================== Name: Kernel-jar.1414 Author: jar Time: 31 May 2021, 11:39:35.749017 pm UUID: f300b29f-3257-e049-b139-8c05240cb97f Ancestors: Kernel-jar.1413 finalize #terminate: solution: - integrate Christoph's solution of BlockCannotReturn's infinite recursion problem - solve a situation when a process gets terminated in the middle of unwinding another process - supersede and replace Kernel-jar.1412 and Kernel-jar.1411 - complemented by: KernelTests-jar.406, KernelTests-jar.407, Tests-jar.466, ToolsTests-jar.105 Please remove Kernel-jar.1412, Kernel-jar.1411, KernelTests-jar.405, Tests-jar.465 from the Inbox. Summary and discussion about the bugs and changes in #terminate: http://forum.world.st/Solving-multiple-termination-bugs-summary-amp-proposa… =============== Diff against Kernel-jar.1413 =============== Item was changed: ----- Method: Context>>cannotReturn: (in category 'private-exceptions') ----- cannotReturn: result + closureOrNil ifNotNil: [ + | resumptionValue | + resumptionValue := self cannotReturn: result to: self home sender. + ProceedBlockCannotReturn new signal: 'This block has ended, continue with sender?'. + self pc > self endPC ifTrue: [ + "This block has ended, continue with sender" + thisContext privSender: self sender]. + ^ resumptionValue]. - closureOrNil ifNotNil: [^ self cannotReturn: result to: self home sender]. Processor debugWithTitle: 'Computation has been terminated!!' translated full: false.! Item was added: + ----- Method: Context>>runUnwindUntilErrorOrReturnFrom: (in category 'private') ----- + runUnwindUntilErrorOrReturnFrom: aSender + "ASSUMES aSender is a sender of self. Execute self's stack until aSender returns or an unhandled exception is raised. Return a pair containing the new top context and a possibly nil exception. The exception is not nil if it was raised before aSender returned and it was not handled. The exception is returned rather than openning the debugger, giving the caller the choice of how to handle it." + "Self is run by jumping directly to it (the active process abandons thisContext and executes self). However, before jumping to self we insert an ensure block under aSender that jumps back to thisContext when evaluated. We also insert an exception handler under aSender that jumps back to thisContext when an unhandled exception is raised. In either case, the inserted ensure and exception handler are removed once control jumps back to thisContext." + + | error ctxt here topContext | + here := thisContext. + + "Insert ensure and exception handler contexts under aSender" + error := nil. + ctxt := aSender insertSender: (Context + contextOn: UnhandledError do: [:ex | + error ifNil: [ + error := ex exception. + topContext := thisContext. + here jump. + ex signalerContext restart "re-signal the error when jumped back"] + ifNotNil: [ex pass] + ]). + ctxt := ctxt insertSender: (Context + contextEnsure: [error ifNil: [ + topContext := thisContext. + here jump] + ]). + self jump. "Control jumps to self" + + "Control resumes here once above ensure block or exception handler is executed" + ^ error ifNil: [ + "No error was raised, return the sender of the above ensure context (see Note 1)" + {ctxt sender. nil} + + ] ifNotNil: [ + "Error was raised, remove inserted above contexts then return signaler context" + aSender terminateTo: ctxt sender. "remove above ensure and handler contexts" + {topContext. error} + ] + + "Note 1: It doesn't matter 'ctxt sender' is not a proper top context because #terminate will use it only as a starting point in the search for the next unwind context and computation will never return here. Removing the inserted ensure context (i.e. ctxt) by stepping until popped (as in #runUntilErrorOrReturnFrom:) when executing non-local returns is not applicable here and would fail testTerminationDuringNestedUnwindWithReturn1 through 4."! Item was added: + Warning subclass: #ProceedBlockCannotReturn + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Kernel-Exceptions'! Item was added: + ----- Method: Process>>complete:to: (in category 'private') ----- + complete: topContext to: aContext + "Run topContext on behalf of self on topContext's stack until aContext is popped or an unhandled + error is raised. Return self's new top context. Note: topContext must be a stack top context. + This method is meant to be called primarily by Process>>#terminate." + + | pair top error | + pair := Processor activeProcess + evaluate: [topContext runUnwindUntilErrorOrReturnFrom: aContext] + onBehalfOf: self. + top := pair first. + error := pair second. + "If an error was detected jump back to the debugged process and re-signal the error; + some errors may require a special care - see notes below." + error ifNotNil: [ + error class == ProceedBlockCannotReturn ifTrue: [^top]. "do not jump back" + error class == MessageNotUnderstood ifTrue: [error initialize]. "reset reachedDefaultHandler" + top jump]. + ^top + + "Note 1: To prevent an infinite recursion of the MessageNotUnderstood error, reset reachedDefaultHandler before jumping back; this will prevent #doesNotUnderstand: from resending the unknown message. + Note 2; To prevent returning from the BlockCannotReturn error, do not jump back when ProceedBlockCannotReturn warning has been raised."! Item was changed: ----- Method: Process>>terminate (in category 'changing process state') ----- terminate "Stop the process that the receiver represents forever. Unwind to execute pending ensure:/ifCurtailed: blocks before terminating. If the process is in the middle of a critical: critical section, release it properly." + | oldList top ctxt outerMost newTop unwindBlock | + "If terminating the active process, suspend it first and terminate it as a suspended process." - | ctxt unwindBlock oldList outerMost | self isActiveProcess ifTrue: [ - "If terminating the active process, suspend it first and terminate it as a suspended process." [self terminate] fork. ^self suspend]. + [] ensure: ["Execute termination as an unwind block to ensure it completes even if terminated; + see testTerminateInTerminate." + "Always suspend the process first so it doesn't accidentally get woken up. + N.B. If oldList is a LinkedList then the process is runnable. If it is a Semaphore/Mutex et al + then the process is blocked, and if it is nil then the process is already suspended." + oldList := self suspend. + suspendedContext ifNil: [^self]. "self is already terminated" + "Release any method marked with the <criticalSection> pragma. + The argument is whether the process is runnable." + self releaseCriticalSection: (oldList isNil or: [oldList class == LinkedList]). - "Always suspend the process first so it doesn't accidentally get woken up. - N.B. If oldList is a LinkedList then the process is runnable. If it is a Semaphore/Mutex et al - then the process is blocked, and if it is nil then the process is already suspended." - oldList := self suspend. - suspendedContext ifNotNil: - ["Release any method marked with the <criticalSection> pragma. - The argument is whether the process is runnable." - self releaseCriticalSection: (oldList isNil or: [oldList class == LinkedList]). + top := suspendedContext. + suspendedContext := nil. "disable this process while running its stack in active process below" "If terminating a process halfways through an unwind, try to complete that unwind block first; + if there are multiple such nested unwind blocks, try to complete the outer-most one; nested + unwind blocks will be completed in the process (see testTerminationDuringUnwind, testNestedUnwind). + Note: Halfway-through blocks have already set the complete variable (tempAt: 2) in their defining + #ensure:/#ifCurtailed contexts from nil to true; we'll search for the bottom-most one. + Note: #findNextUnwindContextUpTo: starts searching from the receiver's sender but the receiver + itself may be an unwind context (see testTerminateEnsureAsTopContext)." + ctxt := top. + ctxt isUnwindContext ifFalse: [ctxt := ctxt findNextUnwindContextUpTo: nil]. + [ctxt isNil] whileFalse: [ + (ctxt tempAt:2) ifNotNil: [ + outerMost := ctxt]. + ctxt := ctxt findNextUnwindContextUpTo: nil]. + outerMost ifNotNil: [newTop := self complete: top to: outerMost]. - if there are multiple such nested unwind blocks, try to complete the outer-most one; the inner - blocks will be completed in the process." - ctxt := suspendedContext. - [(ctxt := ctxt findNextUnwindContextUpTo: nil) isNil] whileFalse: - "Contexts under evaluation have already set their complete (tempAt: 2) to true." - [(ctxt tempAt:2) ifNotNil: [outerMost := ctxt]]. - outerMost ifNotNil: [ - "This is the outer-most unwind context currently under evaluation; - let's find an inner context executing outerMost's argument block (tempAt: 1)" - (suspendedContext findContextSuchThat: [:ctx | - ctx closure == (outerMost tempAt: 1)]) ifNotNil: [:inner | - "Let's finish the unfinished unwind context only (i.e. up to inner) and return here" - suspendedContext runUntilErrorOrReturnFrom: inner. - "Update the receiver's suspendedContext (the previous step reset its sender to nil); - return, if the execution stack reached its bottom (e.g. in case of non-local returns)." - (suspendedContext := outerMost sender) ifNil: [^self]]]. + "By now no halfway-through unwind blocks are on the stack. Create a new top context for each + pending unwind block (tempAt: 1) and execute it on the unwind block's stack. + Note: using #value instead of #complete:to: would lead to incorrect evaluation of non-local returns. + Note: newTop sender points to the former outerMost sender, i.e. the next unexplored context." + ctxt := newTop ifNil: [top] ifNotNil: [newTop sender]. - "Now all unwind blocks caught halfway through have been completed; - let's execute the ones still pending. Note: #findNextUnwindContextUpTo: starts - searching from the receiver's sender but the receiver itself may be an unwind context." - ctxt := suspendedContext. ctxt isUnwindContext ifFalse: [ctxt := ctxt findNextUnwindContextUpTo: nil]. [ctxt isNil] whileFalse: [ (ctxt tempAt: 2) ifNil: [ ctxt tempAt: 2 put: true. unwindBlock := ctxt tempAt: 1. + top := unwindBlock asContextWithSender: ctxt. + self complete: top to: top]. + ctxt := ctxt findNextUnwindContextUpTo: nil] + ]! - "Create a context for the unwind block and execute it on the unwind block's stack. - Note: using #value instead of #runUntilErrorOrReturnFrom: would lead to executing - the unwind on the wrong stack preventing the correct execution of non-local returns." - suspendedContext := unwindBlock asContextWithSender: ctxt. - suspendedContext runUntilErrorOrReturnFrom: suspendedContext]. - ctxt := ctxt findNextUnwindContextUpTo: nil]. - - "Reset the context's pc and sender to nil for the benefit of isTerminated." - suspendedContext terminate]!

3 2

The Trunk: Kernel-mt.1391.mcz
by commits＠source.squeak.org 17 Nov '21

17 Nov '21

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1391.mcz ==================== Summary ==================== Name: Kernel-mt.1391 Author: mt Time: 25 April 2021, 8:25:06.787934 am UUID: 9ab61f3b-e0c8-c545-82fd-49bf4a28fbf4 Ancestors: Kernel-nice.1390 Changes keystroke mappings for better cross-platform compatibility. See http://forum.world.st/Please-try-it-out-Fixing-the-input-mapping-for-keystr… =============== Diff against Kernel-nice.1390 =============== Item was changed: Object subclass: #EventSensor instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue inputSemaphore lastEventPoll hasInputSemaphore lastEventTime' + classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptWatcherProcess KeyDecodePreferences KeyDecodeTable' - classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptWatcherProcess KeyDecodeTable' poolDictionaries: 'EventSensorConstants' category: 'Kernel-Processes'! !EventSensor commentStamp: 'mt 12/13/2019 14:38' prior: 0! An EventSensor is an interface to the user input devices. There is at least one instance of EventSensor named Sensor in the system. EventSensor is a replacement for the earlier InputSensor implementation based on a set of (optional) event primitives. An EventSensor updates its state when events are received so that all state based users of Sensor (e.g., Sensor keyboard, Sensor leftShiftDown, Sensor mouseButtons) will work exactly as before, by moving the current VM mechanisms into EventSensor itself. An optional input semaphore is part of the new design. For platforms that support true asynchronous event notification, the semaphore will be signaled to indicate pending events. On platforms that do not support asynchronous notifications about events, the UI will have to poll EventSensor periodically to read events from the VM. Instance variables: mouseButtons <Integer> - mouse button state as replacement for primMouseButtons mousePosition <Point> - mouse position as replacement for primMousePt keyboardBuffer <SharedQueue> - keyboard input buffer interruptKey <Integer> - currently defined interrupt key interruptSemaphore <Semaphore> - the semaphore signaled when the interruptKey is detected eventQueue <SharedQueue> - an optional event queue for event driven applications inputSemaphore <Semaphore>- the semaphore signaled by the VM if asynchronous event notification is supported lastEventPoll <Integer> - the last millisecondClockValue at which we called fetchMoreEvents hasInputSemaphore <Boolean> - true if my inputSemaphore has actually been signaled at least once. Class variables: ButtonDecodeTable <ByteArray> - maps mouse buttons as reported by the VM to ones reported in the events. KeyDecodeTable <Dictionary<SmallInteger->SmallInteger>> - maps some keys and their modifiers to other keys (used for instance to map Ctrl-X to Alt-X) InterruptSemaphore <Semaphore> - signalled by the the VM and/or the event loop upon receiving an interrupt keystroke. InterruptWatcherProcess <Process> - waits on the InterruptSemaphore and then responds as appropriate. EventPollPeriod <Integer> - the number of milliseconds to wait between polling for more events in the userInterruptHandler. EventTicklerProcess <Process> - the process that makes sure that events are polled for often enough (at least every EventPollPeriod milliseconds). Event format: The current event format is very simple. Each event is recorded into an 8 element array. All events must provide some SmallInteger ID (the first field in the event buffer) and a time stamp (the second field in the event buffer), so that the difference between the time stamp of an event and the current time can be reported. Currently, the following events are defined: Null event ============= The Null event is returned when the ST side asks for more events but no more events are available. Structure: [1] - event type 0 [2-8] - unused Mouse event structure ========================== Mouse events are generated when mouse input is detected. [1] - event type 1 [2] - time stamp [3] - mouse x position [4] - mouse y position [5] - button state; bitfield with the following entries: 1 - 2r001 yellow (e.g., right) button 2 - 2r010 blue (e.g., middle) button 4 - 2r100 red (e.g., left) button [all other bits are currently undefined] [6] - modifier keys; bitfield with the following entries: 1 - shift key 2 - ctrl key 4 - (Mac specific) option key 8 - Cmd/Alt key [all other bits are currently undefined] [7] - reserved. [8] - host window id. Keyboard events ==================== Keyboard events are generated when keyboard input is detected. [1] - event type 2 [2] - time stamp [3] - character code (Ascii) For now the character code is in Mac Roman encoding. See #macToSqueak. For key press/release (see [4]), character codes are normalized. [4] - press state; integer with the following meaning 0 - character (aka. key stroke or key still pressed) 1 - key press (aka. key down) 2 - key release (aka. key up) [5] - modifier keys (same as in mouse events) For key press/release (see [4]), modifier keys are still accessible. [6] - character code (Unicode UTF32) Manual decoding via KeyboardInputInterpreter possible. For key press/release (see [4]), character codes are normalized. [7] - reserved. [8] - host window id. Mouse-wheel event structure ========================== Mouse-wheel events are generated when mouse-wheel input is detected. [1] - event type 7 [2] - time stamp [3] - horizontal scroll delta [4] - vertical scroll delta [5] - button state (same as in mouse events) [6] - modifier keys (same as in mouse events) [7] - reserved. [8] - host window id. ! Item was removed: - ----- Method: EventSensor class>>defaultCrossPlatformKeys (in category 'class initialization') ----- - defaultCrossPlatformKeys - "Answer a list of key letters that are used for common editing operations - on different platforms." - ^{ $c . $x . $v . $a . $s . $f . $g . $z } - ! Item was removed: - ----- Method: EventSensor class>>duplicateAllControlAndAltKeysChanged (in category 'preference change notification') ----- - duplicateAllControlAndAltKeysChanged - "The Preference for duplicateAllControlAndAltKeys has changed; reset the other two." - "At some point the various exclusive CtrlAlt-key prefs should become a radio button set, then these methods wouldn't be needed." - (Preferences - valueOfFlag: #swapControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting swapControlAndAltKeys preference'. - (Preferences preferenceAt: #swapControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was changed: ----- Method: EventSensor class>>duplicateControlAndAltKeys: (in category 'public') ----- duplicateControlAndAltKeys: aBoolean "EventSensor duplicateControlAndAltKeys: true" + self flag: #deprecated. + self + mapControlKeysToCommandKeys: aBoolean; + mapAltKeysToOptionKeys: false.! - Preferences setPreference: #duplicateControlAndAltKeys toValue: aBoolean. - self installKeyDecodeTable - ! Item was removed: - ----- Method: EventSensor class>>duplicateControlAndAltKeysChanged (in category 'preference change notification') ----- - duplicateControlAndAltKeysChanged - "The Preference for duplicateControlAndAltKeys has changed; reset the other two." - (Preferences - valueOfFlag: #swapControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting swapControlAndAltKeys preference'. - (Preferences preferenceAt: #swapControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateAllControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateAllControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateAllControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was added: + ----- Method: EventSensor class>>fixControlCharacters (in category 'key decode table') ----- + fixControlCharacters + "Assure that all keyboard events that arrive with the CONTROL modifier actually have control characters set." + + 64 "$@" to: 95 "$_"do: [:upper | + KeyDecodeTable + at: { upper . 2 bitOr: 1 "ctrl+shift" } + put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }]. + 96 "$`" to: 126 "$~" do: [:lower | "Ignore 127" + KeyDecodeTable + at: { lower . 2 "ctrl" } + put: { lower bitAnd: 16r9F . 2 "ctrl" }]. + + self flag: #linuxOnly. "mt: For Linux VMs as of version 201911282316, no control characters will be sent from the VM. Avoid check for #platformName because the extra mapping will not affect others anyway." + self flag: #windowsOnly. "mt: CTRL+m would not arrive as CTRL+CR, which is rather inconsistent."! Item was changed: ----- Method: EventSensor class>>initialize (in category 'class initialization') ----- initialize + - Smalltalk addToStartUpList: self before: ProcessorScheduler. Smalltalk addToShutDownList: self. + KeyDecodePreferences := Dictionary new. + self installKeyDecodeTable. + self installMouseDecodeTable.! - self installMouseDecodeTable. - self install. - - ! Item was removed: - ----- Method: EventSensor class>>installDuplicateKeyEntryFor: (in category 'key decode table') ----- - installDuplicateKeyEntryFor: aPrintableCharacter - "Updates the key-decode table, which maps between pairs of {character code . modifier code}. - See the class comment for more information. - The purpose of this change is to let ctrl+key act like cmd+key (Mac) or alt+key (linux/windows). - It is especially usefull on windows VM where default feel is to use ctrl as shortcut (ctrl+C = copy, etc...). - Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert control characters to printable characters in this mapping table." - - | upper lower | - upper := aPrintableCharacter asUppercase asInteger. - lower := aPrintableCharacter asLowercase asInteger. - - KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. - KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl + shift" } put: { upper . 8 bitOr: 1 "cmd/alt + shift" }.! Item was changed: ----- Method: EventSensor class>>installKeyDecodeTable (in category 'class initialization') ----- installKeyDecodeTable "Create a decode table that swaps or duplicates some keys if the respective preference is set." KeyDecodeTable := Dictionary new. + self mapControlKeysToCommandKeys + ifTrue: [self installMappingToCommandKeys] + ifFalse: [self mapControlCharactersToPrintableCharacters + ifTrue: [self installMappingToPrintableCharacters] + ifFalse: [self fixControlCharacters "mt: Due to platform-specific VM behavior."]]. - Preferences swapControlAndAltKeys - ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: - [ :c | self installSwappedKeyEntryFor: c ] ]. - Preferences duplicateAllControlAndAltKeys - ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: - [ :c | self installDuplicateKeyEntryFor: c ] ]. + self mapAltKeysToOptionKeys + ifTrue: [self installMappingToOptionKeys].! - self flag: #toDeprecate. "mt: This mapping should be deprecated in the future." - Preferences duplicateControlAndAltKeys - ifTrue: [ self defaultCrossPlatformKeys do: - [ :c | self installDuplicateKeyEntryFor: c ] ]. - ! Item was added: + ----- Method: EventSensor class>>installMappingToCommandKeys (in category 'key decode table') ----- + installMappingToCommandKeys + "Maps all keyboard events that arrive with the CONTROL modifier to also have the COMMAND modifier set. This mapping also considers the preference #mapControlCharactersToPrintableCharacters." + + | controlMask | + 0 "NUL" to: 27 "ESC" do: [:control | + controlMask := self mapControlCharactersToPrintableCharacters + ifTrue: [16r60] ifFalse: [0]. + KeyDecodeTable + at: { control . 2r0010 "ctrl" } + put: { control bitOr: controlMask . 2r1010 "cmd+ctrl" }. + controlMask := self mapControlCharactersToPrintableCharacters + ifTrue: [16r40] ifFalse: [0]. + KeyDecodeTable + at: { control . 2r0011 "ctrl+shift" } + put: { control bitOr: controlMask . 2r1011 "cmd+ctrl+shift" }]. + + 28 "arrow keys" to: 126 "$~" do: [:arrowAndPrintable | + KeyDecodeTable + at: { arrowAndPrintable . 2r0010 "ctrl" } + put: { arrowAndPrintable . 2r1010 "cmd+ctrl" }. + KeyDecodeTable + at: { arrowAndPrintable . 2r0011 "ctrl + shift" } + put: { arrowAndPrintable . 2r1011 "cmd + shift" }].! Item was added: + ----- Method: EventSensor class>>installMappingToOptionKeys (in category 'key decode table') ----- + installMappingToOptionKeys + "Maps all keyboard events that arrive with the COMMAND modifier to also have the OPTION modifier set. See preference #mapAltKeysToOptionKeys." + + self flag: #windowsOnly. "mt: In Windows VMs version 202104182333, pressing the (physical) ALT key arrives as CMD modifier in the image. Should this ever change, this mapping MUST be adapted, too." + self flag: #linuxOnly. "mt: See #windowsOnly." + self flag: #macOSOnly. "mt: This mapping should be ignored to not overshadow events that have the actual OPTION modifier set." + + CharacterSet ascii do: [:character | + KeyDecodeTable + at: { character asInteger . 2r1000 "cmd" } + put: { character asInteger . 2r1100 "cmd+opt" }. + KeyDecodeTable + at: { character asInteger . 2r1001 "cmd + shift" } + put: { character asInteger . 2r1101 "cmd + opt + shift" }].! Item was added: + ----- Method: EventSensor class>>installMappingToPrintableCharacters (in category 'key decode table') ----- + installMappingToPrintableCharacters + "Only applies when the CONTROL modifier is present!! Control characters that can directly be triggered -- such as CR, ENTER, BS, DEL, POS1, END -- will not be mapped." + + self flag: #windowsOnly. "mt: The CONTROL modifier might directly change the control character. Examples: CTRL+CR(13) arrives as CTRL+LF(10), CTRL+BS(8) arrives as CTRL+DEL(127). If you have no other means to input LF(10) or DEL(127), you might have to disable this mapping to printable characters." + + 0 "NUL" to: 27 "ESC" do: [:control | + KeyDecodeTable + at: { control . 2r0010 "ctrl" } + put: { control bitOr: 16r60 "+96" . 2 "ctrl" }. + KeyDecodeTable + at: { control . 2r0011 "ctrl+shift" } + put: { control bitOr: 16r40 "+64" . 2r0011 "ctrl+shift" }].! Item was removed: - ----- Method: EventSensor class>>installSwappedKeyEntryFor: (in category 'key decode table') ----- - installSwappedKeyEntryFor: aPrintableCharacter - "Updates the key-decode table, which maps between pairs of {character code . modifier code}. See the class comment for more information. - Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert printable characters to control characters in this mapping table." - - | upper lower | - upper := aPrintableCharacter asUppercase asInteger. - lower := aPrintableCharacter asLowercase asInteger. - - KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. - KeyDecodeTable at: { lower . 8 "cmd/alt" } put: { lower bitAnd: 16r9F . 2 "ctrl" }. - KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" } put: { upper . 8 bitOr: 1 "cmd/alt+shift" }. - KeyDecodeTable at: { upper . 8 bitOr: 1 "cmd/alt+shift" } put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }.! Item was added: + ----- Method: EventSensor class>>mapAltKeysToOptionKeys (in category 'preferences') ----- + mapAltKeysToOptionKeys + <preference: 'Map ALT keys to OPTION keys' + categoryList: #(keyboard events input) + description: 'On platforms other than macOS, keystrokes involving the (physical) ALT modifier typically arrive as COMMAND modifier. If you now also map CONTROL keys to COMMAND keys, you disable potential input. If you enable this preference, you preserve the possibility of reacting to two different modifiers -- CMD and OPT -- in your code, on all platforms. (This preference replaces older duplicate/swap preferences.)' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapAltKeysToOptionKeys + ifAbsent: [false]! Item was added: + ----- Method: EventSensor class>>mapAltKeysToOptionKeys: (in category 'preferences') ----- + mapAltKeysToOptionKeys: aBooleanOrNil + + aBooleanOrNil = self mapAltKeysToOptionKeys + ifTrue: [^ self]. + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapAltKeysToOptionKeys] + ifNotNil: [ + KeyDecodePreferences + at: #mapAltKeysToOptionKeys + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was added: + ----- Method: EventSensor class>>mapControlCharactersToPrintableCharacters (in category 'preferences') ----- + mapControlCharactersToPrintableCharacters + <preference: 'Map ASCII control characters to printable characters' + categoryList: #(keyboard events input) + description: 'Keystrokes involving the (physical) CONTROL modifier typically have characters codes from 00 to 31 when pressing the physical keys labeled A to Z (or actually ASCII 64 to 95). This means that, for example in CTRL+C, client code cannot check for "anEvent controlKeyPressed and: [anEvent keyCharacter = $C]" but has to resort to "anEvent controlKeyPressed and: [keyCharacter = 3]." If you enable this preference all control characters will be mapped to printable characters.' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapControlCharactersToPrintableCharacters + ifAbsent: [true]! Item was added: + ----- Method: EventSensor class>>mapControlCharactersToPrintableCharacters: (in category 'preferences') ----- + mapControlCharactersToPrintableCharacters: aBooleanOrNil + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapControlCharactersToPrintableCharacters] + ifNotNil: [ + KeyDecodePreferences + at: #mapControlCharactersToPrintableCharacters + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was added: + ----- Method: EventSensor class>>mapControlKeysToCommandKeys (in category 'preferences') ----- + mapControlKeysToCommandKeys + <preference: 'Map CONTROL keys to COMMAND keys' + categoryList: #(keyboard events input) + description: 'On platforms other than macOS, users use the CONTROL modifier for many common shortcuts around text editing such as CTRL+C and CTRL+V for copy and paste. For the sake of cross-platform compatibility, however, many tools in this system will check for CMD+C and CMD+V instead. Note that on Linux and Windows platforms, keystrokes involving the (physical) ALT modifier typically arrive as COMMAND modifier. Thus, enable this preference if you still want to use CONTROL key instead of the ALT key for such shortcuts. (This preference replaces older duplicate/swap preferences.)' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapControlKeysToCommandKeys + ifAbsent: [true]! Item was added: + ----- Method: EventSensor class>>mapControlKeysToCommandKeys: (in category 'preferences') ----- + mapControlKeysToCommandKeys: aBooleanOrNil + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapControlKeysToCommandKeys] + ifNotNil: [ + KeyDecodePreferences + at: #mapControlKeysToCommandKeys + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was changed: ----- Method: EventSensor class>>startUp (in category 'system startup') ----- startUp + Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + + self default startUp.! - self installMouseDecodeTable. - self installKeyDecodeTable. - self default startUp! Item was changed: ----- Method: EventSensor class>>swapControlAndAltKeys: (in category 'public') ----- swapControlAndAltKeys: aBoolean - "EventSensor swapControlAndAltKeys: true" + self deprecated: 'You cannnot swap CONTROL and ALT modifiers anymore. Please use other key-mapping preferences to fit your needs.'.! - Preferences setPreference: #swapControlAndAltKeys toValue: aBoolean. - self installKeyDecodeTable! Item was removed: - ----- Method: EventSensor class>>swapControlAndAltKeysChanged (in category 'preference change notification') ----- - swapControlAndAltKeysChanged - "The Preference for swapControlAndAltKeys has changed; reset the other two." - (Preferences - valueOfFlag: #duplicateControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateAllControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateAllControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateAllControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was changed: ----- Method: EventSensor>>anyModifierKeyPressed (in category 'modifier keys') ----- anyModifierKeyPressed + "ignore, however, the shift keys 'cause that's not REALLY a modifier key" - "ignore, however, the shift keys 'cause that's not REALLY a command key" + ^ self peekButtons anyMask: (2r1110 "cmd | opt | ctrl" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: 16r70 "cmd | opt | ctrl"! Item was changed: ----- Method: EventSensor>>commandKeyPressed (in category 'modifier keys') ----- commandKeyPressed "Answer whether the command key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r1000 "cmd" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: (1 bitShift: MouseEvent numButtons + 3)! Item was changed: ----- Method: EventSensor>>controlKeyPressed (in category 'modifier keys') ----- controlKeyPressed "Answer whether the control key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r0010 "ctrl" bitShift: MouseEvent numButtons)! - ^self peekButtons anyMask: (1 bitShift: MouseEvent numButtons + 1)! Item was added: + ----- Method: EventSensor>>optionKeyPressed (in category 'modifier keys') ----- + optionKeyPressed + "Answer whether the option key on the Macintosh keyboard is being held down. Macintosh specific. Clients are discouraged from calling this directly, since it circumvents bert's attempt to eradicate option-key checks" + + ^ self peekButtons anyMask: (2r0100 "opt" bitShift: MouseEvent numButtons)! Item was changed: ----- Method: EventSensor>>processEvent: (in category 'private-I/O') ----- processEvent: evt "Process a single event. This method is run at high priority." | type buttons window | type := evt at: 1. lastEventTime := evt at: 2. "Only process main window events, forward others to host window proxies" window := evt at: 8. (window isNil or: [window isZero]) ifTrue: [window := 1. evt at: 8 put: window]. window = 1 ifFalse: [ ^Smalltalk at: #HostWindowProxy ifPresent: [:w | w processEvent: evt]]. "Tackle mouse events and mouse wheel events first" (type = EventTypeMouse or: [type = EventTypeMouseWheel]) ifTrue: [buttons := (ButtonDecodeTable at: (evt at: 5) + 1). evt at: 5 put: (Smalltalk platformName = 'Mac OS' ifTrue: [ buttons ] ifFalse: [ self mapButtons: buttons modifiers: (evt at: 6) ]). self queueEvent: evt. type = EventTypeMouseWheel ifTrue: [^ self processMouseWheelEvent: evt]. type = EventTypeMouse ifTrue: [^ self processMouseEvent: evt]]. "Store the event in the queue if there's any" type = EventTypeKeyboard ifTrue: [ "Check if the event is a user interrupt" ((evt at: 4) = EventKeyChar and: [((evt at: 3) bitOr: (((evt at: 5) bitAnd: 8) bitShift: 8)) = interruptKey]) ifTrue: ["interrupt key is meta - not reported as event" ^ interruptSemaphore signal]. + "Decode keys for characters (e.g., map ctrl -> cmd)." - "Decode keys for characters (i.e., duplicate or swap, ctrl <-> alt/cmd)." (evt at: 4) = EventKeyChar ifTrue: [ | unicode ascii | "Copy lookup key first in case of key swap." unicode := {evt at: 6. evt at: 5}. ascii := {evt at: 3. evt at: 5}. KeyDecodeTable "Unicode character first" at: unicode ifPresent: [:a | evt at: 6 put: a first; at: 5 put: a second]. KeyDecodeTable "ASCII character second" at: ascii ifPresent: [:a | evt at: 3 put: a first; at: 5 put: a second]]. self queueEvent: evt. self processKeyboardEvent: evt . ^self ]. "Handle all events other than Keyboard or Mouse." self queueEvent: evt. ! Item was changed: ----- Method: EventSensor>>rawMacOptionKeyPressed (in category 'modifier keys') ----- rawMacOptionKeyPressed "Answer whether the option key on the Macintosh keyboard is being held down. Macintosh specific. Clients are discouraged from calling this directly, since it circumvents bert's attempt to eradicate option-key checks" + self deprecated: 'Use #optionKeyPressed instead.'. + ^ self optionKeyPressed! - ^ self peekButtons anyMask: 32! Item was changed: ----- Method: EventSensor>>shiftPressed (in category 'modifier keys') ----- shiftPressed "Answer whether the shift key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r0001 "shift" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: (1 bitShift: MouseEvent numButtons)! Item was changed: + (PackageInfo named: 'Kernel') postscript: 'EventSensor initialize. + EventSensor startUp.'! - (PackageInfo named: 'Kernel') postscript: '"recompile all methods containing blocks with the wrong outerCode" - (self systemNavigation allMethodsSelect: [:m| m literals anySatisfy: [:l| l isCompiledCode and: [l isCompiledBlock and: [l outerCode ~~ m]]]]) do: - [:mr| mr actualClass recompile: mr selector]'!

4 4

The Inbox: KernelTests-jar.406.mcz
by commits＠source.squeak.org 15 Nov '21

15 Nov '21

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.406.mcz ==================== Summary ==================== Name: KernelTests-jar.406 Author: jar Time: 24 May 2021, 11:02:39.394885 pm UUID: 08657090-5a49-f84b-904f-8a37f5f2ec75 Ancestors: KernelTests-jar.405 Test a situation when a process terminating another process is terminated in the middle of the unwind. make sure both processes are unwound correctly. =============== Diff against KernelTests-jar.405 =============== Item was added: + ----- Method: ProcessTest>>testTerminateInTerminate (in category 'tests') ----- + testTerminateInTerminate + "Terminating a terminator process should unwind both the terminator and its terminatee process" + + | terminator terminatee unwound | + unwound := false. + terminatee := [[Processor activeProcess suspend] ensure: [unwound := true]] fork. + Processor yield. + terminator := [terminatee terminate] newProcess. + self assert: terminatee isSuspended. + self assert: terminator isSuspended. + terminator runUntil: [:ctx | ctx selectorToSendOrSelf = #suspend]. "first #suspend in #terminate" + self assert: terminator isSuspended. + terminator terminate. + self assert: terminator isTerminated. + self assert: unwound!

5 6

BUG/REGRESSION while debugging Generator >> #nextPut:
by Thiede, Christoph 15 Nov '21

15 Nov '21

Hi all, I discovered a bug when stepping over a call to Generator >> #nextPut:. !! Save your image before trying the following !! Generator on: [:stream | stream nextPut: #foo] [cid:95952b5e-98f1-4447-bd09-29d396961281] 1. Due to multiprocessing implementation of the Generator, pressing over will hang up the current process forever, because the generator is never queried. 2. If I press cmd-dot, I get an infinite number of debugger windows that show Context >> #cannotReturn:. This will probably damage your image. The first is annoying for newcomers, but I see this behavior is reasonable and without the effect of the second, it wouldn't be a big problem. The second, however, looks like a bigger issue to me. Actually, I think the most serious aspect is that in Squeak 5.1, the same procedure does not crash your image, but you are forwarded to the emergency debugger and can terminate the process: [cid:c8eee8c3-d2de-49c0-b5d4-33bd340d6c98] [cid:6044ecf2-91ab-4f6e-b863-b980586868e9] Also, this is not the first scenario in the last time where I got an infinite debugger chain. See [BUG(s)] in Context control (#jump, #runUntilErrorOrReturnFrom:)<http://forum.world.st/BUG-s-in-Context-control-jump-runUntilErrorOrReturnFr…> for a similar issue. And there were even more situations which I could not yet reproduce exactly. I'm afraid that the recent changes to the debuggers might have weakened its ability to detect recursive errors. Can someone else tell about these problems? I suppose we ignore a large number of recursive errors as in MorphicDebugger >> #openOn:context:label:contents:fullView:, the uiBlock is often triggered as a separate UI message which will be executed after the recursion flag has been cleared by the base class. Would be great if someone could have a look at it or share more information :) Best, Christoph

8 25

The Trunk: Kernel-eem.1366.mcz
by commits＠source.squeak.org 02 Nov '21

02 Nov '21

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1366.mcz ==================== Summary ==================== Name: Kernel-eem.1366 Author: eem Time: 26 January 2021, 4:27:57.204259 pm UUID: 3a706d32-c2d6-416f-82c1-bbf735650385 Ancestors: Kernel-eem.1365 Slightly faster implementation of Context>>#isPrimFailToken:. Improve the comments in Context>>#isHandlerContext/#isUnwindContext. Nuke an obsolete method. =============== Diff against Kernel-eem.1365 =============== Item was changed: ----- Method: Context>>isHandlerContext (in category 'private-exceptions') ----- isHandlerContext + "Answer if the receiver is for a method that is marked as an exception handler. + BlockClosure>>#on:do: uses this primitive to identify itself to the VM + as an exception handler method, which the VM uses in primitive 197 + Context>>#findNextHandlerContextStarting, primitiveFindHandlerContext, + to accelerate the search for exception handlers." - "is this context for method that is marked?" ^method primitive = 199! Item was changed: ----- Method: Context>>isPrimFailToken: (in category 'private') ----- isPrimFailToken: anObject + ^(self objectClass: anObject) isArray - ^(self objectClass: anObject) == Array and: [anObject size = 2 + and: [(anObject at: 1) == PrimitiveFailToken]]! - and: [anObject first == PrimitiveFailToken]]! Item was changed: ----- Method: Context>>isUnwindContext (in category 'private-exceptions') ----- isUnwindContext + "Answer if the receiver is for a method that is marked as a non-local return/exception unwind protect. + BlockClosure>>#ensure: and BlockClosure>>#ifCurtailed: use this primitive to identify + themseves to the VM as unwind protect methods. The VM uses this in primitive 195 + Context>>#findNextUnwindContextUpTo:, primitiveFindNextUnwindContext, to + accelerate the search for unwind protects." - "is this context for method that is marked?" ^method primitive = 198! Item was removed: - ----- Method: Context>>tryPrimitiveFor:receiver:args: (in category 'private') ----- - tryPrimitiveFor: method receiver: receiver args: arguments - "If this method has a primitive index, then run the primitive and return its result. - Otherwise (and also if the primitive fails) return PrimitiveFailToken, - as an indication that the method should be activated and run as bytecodes." - | primIndex | - (primIndex := method primitive) = 0 ifTrue: [^{PrimitiveFailToken. nil}]. - ^ self doPrimitive: primIndex method: method receiver: receiver args: arguments!

7 21

Many questions about sounds :-)
by Thiede, Christoph 01 Nov '21

01 Nov '21

Hi all! As I'm currently developing a small project that uses sounds in Squeak, I have collected a number of questions about the Sound package and am hoping to find some answers here. Even if you are able to answer one or two questions only, I will appreciate your help! :-) 1. What is the difference between QueueSound and SequentialSound? Roughly speaking, they both appear to do the same. AbstractSound >> #, uses SequentialSound whereas QueueSound might be thread-safe. Is there any reason why the two are not unioned into a single class? 2. Why could my coffeeCupClink be broken? It's already the second image in which I, after playing around a bit with sounds, managed to break that sound by accident. In both affected images, Beeper beep just does not beep any more. However, all other SampledSounds still sound fine. SampledSound initialize and VM restart didn't help. I even tried to find out what's going wrong with the help of comparative debugging of #play, but I did not discover any meaningful difference ... 3. SoundService/SoundPlayer/SoundSystem are not thread-safe, are they? 4. Why does it take so much time to start the SoundPlayer? I could reproduce this in two images using: [[PluckedSound default play] timeProfile] fork. In both cases, the image was busy for ~150ms. If another sound is already playing, #play is fast. According to the TimeProfileBrowser, #newProcess eats up all the time (see attachment), but can this really be true? Can you reproduce this on your machines or could this be a Windows-specific thing? 5. Is there any built-in way for loudness normalization (as opposed to "normal" volume)? 6. Can you recommend any further resources in Squeak for other sound concepts such as ring modulation, sawtooth/triangle/square waves, or also other musical instruments? For example, there are flutes and oboes, but I did not find a piano sound. Would it be possible to build one as a combination of FMSounds or are these instruments more sophisticated to program? Thanks in advance and have a happy weekend! Best, Christoph

5 12

← Newer
1
...
5
6
7
8
9
10
11
...
23
Older →

Jump to page: