Squeak-dev January 2022

squeak-dev@lists.squeakfoundation.org

33 participants
362 discussions

Proposal: "Move window to project" menu for PluggableSystemWindow
by David O'Toole 02 Feb '22

02 Feb '22

Good afternoon. I don't really mind that much having to do something like: pluggableSystemWindow1319167 openInWorld: ((Project named: 'Miscellaneous') world) But it would be nice if there was a "Send window to project" menu that could do this. Are there any big issues that would make this more difficult than it seems? I'd also like to know whether or not there is any general objection to the idea of having such a menu. Let me know your thoughts! If there is no objection, I could add it to my task list and discover the proper way to add it.

6 8

The Inbox: EToys-ct.461.mcz
by commits＠source.squeak.org 02 Feb '22

02 Feb '22

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.461.mcz ==================== Summary ==================== Name: EToys-ct.461 Author: ct Time: 31 January 2022, 9:21:55.1383 pm UUID: 9acb64f1-d86b-de49-9632-f6ebfd49fcae Ancestors: EToys-mt.460 Proposal: Do not play sounds while initializing the players tool. Opening a fresh image and selecting the Scripting category should not make a sound. Running MorphicUIManagerTest>>#testShowAllBinParts should not make a sound. I think this acoustic feedback is unnecessary, also given the fact that the invigorate button is currently not displayed anywhere in the UI. =============== Diff against EToys-mt.460 =============== Item was changed: ----- Method: AllPlayersTool>>reinvigorate (in category 'reinvigoration') ----- reinvigorate "Referesh the contents of the receiver" (submorphs copyFrom: 3 to: submorphs size) do: [:m | m delete]. self currentWorld doOneCycleNow. + self currentWorld presenter reinvigoratePlayersTool: self.! - self playSoundNamed: 'scritch'. - (Delay forMilliseconds: 700) wait. - self currentWorld presenter reinvigoratePlayersTool: self. - self playSoundNamed: 'scratch'.!

2 1

Review Request: DoItFirstAfterStartup.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 31 Jan '22

31 Jan '22

Hi Dave, hi all, please take a short look at this changeset that I would like to merge into the Trunk in order to fix the DoItTest for Windows. Currently, some of them fail because DoItFirst tries to re-open the source files. =============== Summary =============== Change Set: DoItFirstAfterStartup Date: 10 January 2022 Author: Christoph Thiede This changeset fixes the DoItFirst tests on Windows by making sure that no attempt is made to re-open the source fiels while the image has already been started up. This is achieved by extracting FileDirectory startUpDefaultDirectory from FileDirectory startUp and only sending the latter from DoItFirst >> #parse:. =============== Diff =============== DoItFirst>>parse: {evaluating} · ct 1/10/2022 22:37 (changed) parse: argumentList "Iterate over the argument list, creating actions blocks. Register each action block in the actions dictionary, and collect a list of the actions blocks to be evaluated now. If any action blocks will require files or directory initialization, send the appropriate startUp messages. Answer the list of action blocks to be evaluated." | args listOfBlocks needsFiles needsDirectory | needsFiles := needsDirectory := false. args := argumentList readStream. listOfBlocks := OrderedCollection new. [ args atEnd ] whileFalse: [ | key | (key := self keyFor: args next) caseOf: { [ #help ] -> [ self addFirst: [ self help ] to: listOfBlocks at: key. needsFiles := true] . [ #debug ] -> [ self addWithoutEvaluation: [ self debug ] at: key] . [ #doit ] -> [ | list | list := self nextTokensFrom: args. self add:[ self doIt: list ] to: listOfBlocks at: key. needsFiles := true] . [ #evaluate ] -> [ | arg | arg := args next. self add:[ self evaluateOption: arg ] to: listOfBlocks at: key. needsFiles := true] . [ #file ] -> [ | arg | arg := args next. self add:[ self evaluateFileContents: arg ] to: listOfBlocks at: key. needsFiles := true] . [ #filein ] -> [ | list | list := self nextTokensFrom: args. self add:[ self fileIn: list ] to: listOfBlocks at: key. needsFiles := needsDirectory := true] . [ #cwd ] -> [ | arg | arg := args next. self addFirst:[ self cwd: arg ] to: listOfBlocks at: key. needsFiles := needsDirectory := true] . } otherwise: [] ]. needsFiles ifTrue: [ FileStream startUp: true. "initialize stdout and stderr" ]. - needsDirectory ifTrue: [ FileDirectory startUp "set default directory" ]. + needsDirectory ifTrue: [ FileDirectory startUpDefaultDirectory ]. ^ listOfBlocks. FileDirectory class>>startUp {name utilities} · ct 1/10/2022 22:37 (changed) startUp - "Establish the platform-specific FileDirectory subclass. Do any platform-specific startup." - self setDefaultDirectoryClass. - self setDefaultDirectory: (self dirPathFor: Smalltalk imageName). - - Preferences startInUntrustedDirectory - ifTrue:[ "The SecurityManager may override the default directory to prevent unwanted write access etc." - self setDefaultDirectory: SecurityManager default untrustedUserDirectory. - "Make sure we have a place to go to" - DefaultDirectory assureExistence]. + self startUpDefaultDirectory. Smalltalk openSourceFiles. - (Smalltalk classNamed: #DoItFirst) ifNotNil: [ :doit | doit perform: #reevaluateCwd ]. FileDirectory class>>startUpDefaultDirectory {name utilities} · ct 1/10/2022 22:37 + startUpDefaultDirectory + "Establish the platform-specific FileDirectory subclass. Do any platform-specific startup." + + self setDefaultDirectoryClass. + self setDefaultDirectory: (self dirPathFor: Smalltalk imageName). + + Preferences startInUntrustedDirectory + ifTrue:[ "The SecurityManager may override the default directory to prevent unwanted write access etc." + self setDefaultDirectory: SecurityManager default untrustedUserDirectory. + "Make sure we have a place to go to" + DefaultDirectory assureExistence]. + + (Smalltalk classNamed: #DoItFirst) ifNotNil: [ :doit | doit perform: #reevaluateCwd ]. Best, Christoph --- Sent from Squeak Inbox Talk ["DoItFirstAfterStartup.1.cs"]

3 6

The Trunk: Chronology-Core-ct.75.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-ct.75.mcz ==================== Summary ==================== Name: Chronology-Core-ct.75 Author: ct Time: 31 January 2022, 8:48:00.118214 pm UUID: ed9132ca-ceb9-5143-9865-3f89d80f1e60 Ancestors: Chronology-Core-ct.74 Recategorizes uncategorized method. =============== Diff against Chronology-Core-ct.74 =============== Item was changed: + ----- Method: Duration>>adaptToCollection:andSend: (in category 'converting') ----- - ----- Method: Duration>>adaptToCollection:andSend: (in category 'as yet unclassified') ----- adaptToCollection: rcvr andSend: selector "If I am involved in arithmetic with a Collection, return a Collection of the results of each element combined with me in that expression." ^ rcvr collect: [:element | element perform: selector with: self]!

1 0

The Trunk: Chronology-Tests-ct.30.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-ct.30.mcz ==================== Summary ==================== Name: Chronology-Tests-ct.30 Author: ct Time: 31 January 2022, 8:47:27.716214 pm UUID: 4dca07ab-c329-c54b-b9b2-d66e677524d2 Ancestors: Chronology-Tests-ct.29 Complements Chronology-Tests-ct.29, sorry for the noise ... =============== Diff against Chronology-Tests-ct.29 =============== Item was changed: ----- Method: WeekTest>>testNameOfDay (in category 'Tests') ----- testNameOfDay | days | days := #(#Sunday #Monday #Tuesday #Wednesday #Thursday #Friday #Saturday). days withIndexDo: [:item :index | self assert: (Week nameOfDay: index) = item]. + self shouldRaiseError: [Week nameOfDay: 0]. + self shouldRaiseError: [Week nameOfDay: 8]. + self shouldRaiseError: [Week nameOfDay: #Sunday].! - self should: [Week nameOfDay: 0] raise: TestResult error. - self should: [Week nameOfDay: 8] raise: TestResult error. - self should: [Week nameOfDay: #Sunday] raise: TestResult error.!

1 0

The Trunk: VersionNumberTests-ct.5.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of VersionNumberTests to project The Trunk: http://source.squeak.org/trunk/VersionNumberTests-ct.5.mcz ==================== Summary ==================== Name: VersionNumberTests-ct.5 Author: ct Time: 31 January 2022, 8:45:40.499214 pm UUID: af22c47a-3ca5-e340-8598-026eb9f9c6d5 Ancestors: VersionNumberTests-fbs.4 Complements SUnit-ct.130 (deprecation of TestResult error) and SUnit-ct.138 (new convenience #shouldRaiseError:). =============== Diff against VersionNumberTests-fbs.4 =============== Item was changed: ----- Method: VersionNumberTest>>testAsVersion (in category 'Tests') ----- testAsVersion "note: a version number string '3 2 1' will only consider the first number as a version, ignoring the trailing '2 1'. Whether it is a desired feature or not should be determined." | numbers | numbers := { '' -> #(). '1 '-> #(1). '1.2' -> #(1 2). '3.4.5' -> #(3 4 5). '6.7.890' -> #(6 7 890). '9 8' -> #(9). '98 7 6' -> #(98). '54.3 2 1' -> #(54 3) }. numbers do: [:item | | version | version := (item key) asVersion. self assert: (VersionNumber = version class). self assert: ((item value) = version numbers). ]. self assert: 9999999999999999999 equals: '9999999999999999999' asVersion numbers first. + self shouldRaiseError: ['-1' asVersion]. + self shouldRaiseError: [' 1' asVersion]. "notice leading space!!" + self shouldRaiseError: ['version' asVersion]. + self shouldRaiseError: ['1.2.10.20.-1.4' asVersion]. + self shouldRaiseError: ['1.2.10.20.R4' asVersion].! - self should: ['-1' asVersion] raise: TestResult error. - self should: [' 1' asVersion] raise: TestResult error. "notice leading space!!" - self should: ['version' asVersion] raise: TestResult error. - self should: ['1.2.10.20.-1.4' asVersion] raise: TestResult error. - self should: ['1.2.10.20.R4' asVersion] raise: TestResult error.! Item was changed: ----- Method: VersionNumberTest>>testFromCollection (in category 'Tests') ----- testFromCollection | numbers | numbers := #(#(1) #(1 2) #(3 4 5) #(6 7 890)). numbers do: [:item | | version | version := VersionNumber fromCollection: item. self assert: (VersionNumber = version class). self assert: (item = version numbers). ]. self assert: #() equals: (VersionNumber fromCollection: #()) numbers. self assert: #(9999999999999999999) equals: (VersionNumber fromCollection: #(9999999999999999999)) numbers. + self shouldRaiseError: [VersionNumber fromCollection: #(0)]. + self shouldRaiseError: [VersionNumber fromCollection: #(-1)]. + self shouldRaiseError: [VersionNumber fromCollection: #(1 2 10 20 -1 4)]. + self shouldRaiseError: [VersionNumber fromCollection: #(1 2 10 20 '1' 4)]. + self shouldRaiseError: [VersionNumber fromCollection: #('version')].! - self should: [VersionNumber fromCollection: #(0)] raise: TestResult error. - self should: [VersionNumber fromCollection: #(-1)] raise: TestResult error. - self should: [VersionNumber fromCollection: #(1 2 10 20 -1 4)] raise: TestResult error. - self should: [VersionNumber fromCollection: #(1 2 10 20 '1' 4)] raise: TestResult error. - self should: [VersionNumber fromCollection: #('version')] raise: TestResult error. - ! Item was changed: ----- Method: VersionNumberTest>>testFromString (in category 'Tests') ----- testFromString "note: a version number string '3 2 1' will only consider the first number as a version, ignoring the trailing '2 1'. Whether it is a desired feature or not should be determined." | numbers | numbers := { '' -> #(). '1 '-> #(1). '1.2' -> #(1 2). '3.4.5' -> #(3 4 5). '6.7.890' -> #(6 7 890). '9 8' -> #(9). '98 7 6' -> #(98). '54.3 2 1' -> #(54 3) }. numbers do: [:item | | version | version := VersionNumber fromString: (item key). self assert: (VersionNumber = version class). self assert: ((item value) = version numbers). ]. self assert: #(9999999999999999999) equals: (VersionNumber fromString: '9999999999999999999') numbers. + self shouldRaiseError: [VersionNumber fromString: '-1']. + self shouldRaiseError: [VersionNumber fromString: ' 1']. "notice leading space!!" + self shouldRaiseError: [VersionNumber fromString: 'version']. + self shouldRaiseError: [VersionNumber fromString: '1.2.10.20.-1.4']. + self shouldRaiseError: [VersionNumber fromString: '1.2.10.20.R4'].! - self should: [VersionNumber fromString: '-1'] raise: TestResult error. - self should: [VersionNumber fromString: ' 1'] raise: TestResult error. "notice leading space!!" - self should: [VersionNumber fromString: 'version'] raise: TestResult error. - self should: [VersionNumber fromString: '1.2.10.20.-1.4'] raise: TestResult error. - self should: [VersionNumber fromString: '1.2.10.20.R4'] raise: TestResult error. - ! Item was changed: ----- Method: VersionNumberTest>>testInitializeNumbers (in category 'Tests') ----- testInitializeNumbers | numbers | numbers := #(#(1) #(1 2) #(3 4 5) #(6 7 890)). numbers do: [:item | | version | version := VersionNumber new initializeNumbers: item. self assert: (VersionNumber = version class). self assert: (item = version numbers). ]. self assert: #() equals: (VersionNumber new initializeNumbers: #()) numbers. self assert: #(9999999999999999999) equals: (VersionNumber new initializeNumbers: #(9999999999999999999)) numbers. + self shouldRaiseError: [VersionNumber new initializeNumbers: #(0)]. + self shouldRaiseError: [VersionNumber new initializeNumbers: #(-1)]. + self shouldRaiseError: [VersionNumber new initializeNumbers: #(1 2 10 20 -1 4)]. + self shouldRaiseError: [VersionNumber new initializeNumbers: #(1 2 10 20 '1' 4)]. + self shouldRaiseError: [VersionNumber new initializeNumbers: #('version')].! - self should: [VersionNumber new initializeNumbers: #(0)] raise: TestResult error. - self should: [VersionNumber new initializeNumbers: #(-1)] raise: TestResult error. - self should: [VersionNumber new initializeNumbers: #(1 2 10 20 -1 4)] raise: TestResult error. - self should: [VersionNumber new initializeNumbers: #(1 2 10 20 '1' 4)] raise: TestResult error. - self should: [VersionNumber new initializeNumbers: #('version')] raise: TestResult error. - !

1 0

The Trunk: Tests-ct.477.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ct.477.mcz ==================== Summary ==================== Name: Tests-ct.477 Author: ct Time: 31 January 2022, 8:42:26.054214 pm UUID: 1a7f2a13-c7f1-794d-a76a-6b107e74f42a Ancestors: Tests-ct.476 Complements SUnit-ct.130 (deprecation of TestResult error) and SUnit-ct.138 (new convenience #shouldRaiseError:). =============== Diff against Tests-ct.476 =============== Item was changed: ----- Method: PrimCallControllerAbstractTest>>testChangeFailedCallFailing (in category 'tests') ----- testChangeFailedCallFailing pcc preserveStatusOfFailedCalls. + self shouldRaiseError: [pcc enableCallIn: self failedCallRef]. + self shouldRaiseError: [pcc disableCallIn: self failedCallRef].! - self - should: [pcc enableCallIn: self failedCallRef] - raise: TestResult error. - self - should: [pcc disableCallIn: self failedCallRef] - raise: TestResult error! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testDisableCallsIntoModule (in category 'tests') ----- testDisableCallsIntoModule "wrong module" + self shouldRaiseError: [pcc disableCallsIntoModule: 'totallyRandom4711']. - self - should: [pcc disableCallsIntoModule: 'totallyRandom4711'] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "disabling" pcc disableCallsIntoModule: self exampleModuleName. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "not enabled!!" + self shouldRaiseError: [pcc disableCallsIntoModule: self exampleModuleName]. - self - should: [pcc disableCallsIntoModule: self exampleModuleName] - raise: TestResult error. "enabling" self methodRefsToExampleModule do: [:ref | pcc enableCallIn: ref]. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not enabled!!" + self shouldRaiseError: [pcc disableCallsIntoModule: self failModuleName]. - self - should: [pcc disableCallsIntoModule: self failModuleName] - raise: TestResult error. pcc changeStatusOfFailedCalls. pcc disableCallsIntoModule: self failModuleName. self assert: (pcc existsDisabledCallIn: self failedCallRef). "postcondition" + pcc enableCallIn: self failedCallRef.! - pcc enableCallIn: self failedCallRef - ! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testDisableCallsIntoModuleForClasses (in category 'tests') ----- testDisableCallsIntoModuleForClasses "wrong module" + self shouldRaiseError: [pcc disableCallsIntoModule: 'totallyRandom4711' forClasses: {self class}]. - self - should: [pcc disableCallsIntoModule: 'totallyRandom4711' forClasses: {self class}] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "disabling" pcc disableCallsIntoModule: self exampleModuleName forClasses: {self class}. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "not enabled!!" + self shouldRaiseError: [pcc disableCallsIntoModule: self exampleModuleName forClasses: {self class}]. - self - should: [pcc disableCallsIntoModule: self exampleModuleName forClasses: {self class}] - raise: TestResult error. "enabling" self methodRefsToExampleModule do: [:ref | pcc enableCallIn: ref]. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not enabled!!" + self shouldRaiseError: [pcc disableCallsIntoModule: self failModuleName forClasses: {self class}]. - self - should: [pcc disableCallsIntoModule: self failModuleName forClasses: {self class}] - raise: TestResult error. pcc changeStatusOfFailedCalls. pcc disableCallsIntoModule: self failModuleName forClasses: {self class}. self assert: (pcc existsDisabledCallIn: self failedCallRef). "postcondition" + pcc enableCallIn: self failedCallRef.! - pcc enableCallIn: self failedCallRef - ! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testEnableCallsIntoModule (in category 'tests') ----- testEnableCallsIntoModule self avoidSlowTest ifTrue: [^ self]. "wrong module" + self shouldRaiseError: [pcc enableCallsIntoModule: 'totallyRandom4711']. - self - should: [pcc enableCallsIntoModule: 'totallyRandom4711'] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [pcc enableCallsIntoModule: self exampleModuleName]. - self - should: [pcc enableCallsIntoModule: self exampleModuleName] - raise: TestResult error. "disabling" self methodRefsToExampleModule do: [:ref | pcc disableCallIn: ref]. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "enabling" "now this should work" pcc enableCallsIntoModule: self exampleModuleName. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [pcc enableCallsIntoModule: self failModuleName]. - self - should: [pcc enableCallsIntoModule: self failModuleName] - raise: TestResult error. pcc changeStatusOfFailedCalls. pcc enableCallsIntoModule: self failModuleName. + self assert: (pcc existsEnabledCallIn: self failedCallRef).! - self assert: (pcc existsEnabledCallIn: self failedCallRef) - ! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testEnableCallsIntoModuleForClasses (in category 'tests') ----- testEnableCallsIntoModuleForClasses "wrong module" + self shouldRaiseError: [pcc enableCallsIntoModule: 'totallyRandom4711' forClasses: {self class}]. - self - should: [pcc enableCallsIntoModule: 'totallyRandom4711' forClasses: {self class}] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [pcc enableCallsIntoModule: self exampleModuleName forClasses: {self class}]. - self - should: [pcc enableCallsIntoModule: self exampleModuleName forClasses: {self class}] - raise: TestResult error. "disabling" self methodRefsToExampleModule do: [:ref | pcc disableCallIn: ref]. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "enabling" "now this should work" pcc enableCallsIntoModule: self exampleModuleName forClasses: {self class}. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [pcc enableCallsIntoModule: self failModuleName forClasses: {self class}]. - self - should: [pcc enableCallsIntoModule: self failModuleName forClasses: {self class}] - raise: TestResult error. pcc changeStatusOfFailedCalls. pcc enableCallsIntoModule: self failModuleName forClasses: {self class}. + self assert: (pcc existsEnabledCallIn: self failedCallRef).! - self assert: (pcc existsEnabledCallIn: self failedCallRef) - ! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testEnableDisableCallIn (in category 'tests') ----- testEnableDisableCallIn | refs | refs := self methodRefsToExampleModule. "wrong call" + self shouldRaiseError: [pcc disableCallIn: self wrongCallRef]. - self - should: [pcc disableCallIn: self wrongCallRef] - raise: TestResult error. "wrong class" + self shouldRaiseError: [pcc disableCallIn: self wrongClassRef]. - self - should: [pcc disableCallIn: self wrongClassRef] - raise: TestResult error. "wrong call" + self shouldRaiseError: [pcc enableCallIn: self wrongCallRef]. - self - should: [pcc enableCallIn: self wrongCallRef] - raise: TestResult error. "wrong class" + self shouldRaiseError: [pcc enableCallIn: self wrongClassRef]. - self - should: [pcc enableCallIn: self wrongClassRef] - raise: TestResult error. "no external call" + self shouldRaiseError: [pcc enableCallIn: self noExternalCallRef]. - self - should: [pcc enableCallIn: self noExternalCallRef] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [refs + do: [:ref1 | pcc enableCallIn: ref1]]. - self - should: [refs - do: [:ref1 | pcc enableCallIn: ref1]] - raise: TestResult error. "disabling" refs do: [:ref2 | pcc disableCallIn: ref2]. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "not enabled!!" + self shouldRaiseError: [refs + do: [:ref3 | pcc disableCallIn: ref3]]. - self - should: [refs - do: [:ref3 | pcc disableCallIn: ref3]] - raise: TestResult error. "enabling" "now this should work" refs do: [:ref4 | pcc enableCallIn: ref4]. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "try caches" pcc disableEnabled. "all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. pcc enableDisabled. "all enabled" + self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule.! - self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testEnableDisableCallInCompiledMethod (in category 'tests') ----- testEnableDisableCallInCompiledMethod "Note: >>compiledMethodsToExampleModule has to be called frequently, since the CMs are changing with a successful compile!!" "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [self compiledMethodsToExampleModule + do: [:cm1 | pcc enableCallInCompiledMethod: cm1]]. - self - should: [self compiledMethodsToExampleModule - do: [:cm1 | pcc enableCallInCompiledMethod: cm1]] - raise: TestResult error. "disabling" self compiledMethodsToExampleModule do: [:cm2 | pcc disableCallInCompiledMethod: cm2]. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "not enabled!!" + self shouldRaiseError: [self compiledMethodsToExampleModule + do: [:cm3 | pcc disableCallInCompiledMethod: cm3]]. - self - should: [self compiledMethodsToExampleModule - do: [:cm3 | pcc disableCallInCompiledMethod: cm3]] - raise: TestResult error. "enabling" "now this should work" self compiledMethodsToExampleModule do: [:cm4 | pcc enableCallInCompiledMethod: cm4]. self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "try caches" pcc disableEnabled. "all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. pcc enableDisabled. "all enabled" + self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule.! - self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testEnableDisableCallInMethodClass (in category 'tests') ----- testEnableDisableCallInMethodClass | sels | sels := self methodSelectorsToExampleModule. "wrong call" + self shouldRaiseError: [pcc disableCallInMethod: #nonExistingCall class: self class]. - self - should: [pcc disableCallInMethod: #nonExistingCall class: self class] - raise: TestResult error. "wrong class" + self shouldRaiseError: [pcc disableCallInMethod: sels first class: Integer]. - self - should: [pcc disableCallInMethod: sels first class: Integer] - raise: TestResult error. "wrong call" + self shouldRaiseError: [pcc enableCallInMethod: #nonExistingCall class: self class]. - self - should: [pcc enableCallInMethod: #nonExistingCall class: self class] - raise: TestResult error. "wrong class" + self shouldRaiseError: [pcc enableCallInMethod: sels first class: Integer]. + self shouldRaiseError: [pcc enableCallInMethod: self noExternalCallSelector class: self class]. - self - should: [pcc enableCallInMethod: sels first class: Integer] - raise: TestResult error. - self - should: [pcc enableCallInMethod: self noExternalCallSelector class: self class] - raise: TestResult error. "precondition: all enabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "not disabled!!" + self shouldRaiseError: [sels + do: [:sel1 | pcc enableCallInMethod: sel1 class: self class]]. - self - should: [sels - do: [:sel1 | pcc enableCallInMethod: sel1 class: self class]] - raise: TestResult error. "disabling" sels do: [:sel2 | pcc disableCallInMethod: sel2 class: self class]. "now all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. "not enabled!!" + self shouldRaiseError: [sels + do: [:sel3 | pcc disableCallInMethod: sel3 class: self class]]. - self - should: [sels - do: [:sel3 | pcc disableCallInMethod: sel3 class: self class]] - raise: TestResult error. "enabling" "now this should work" sels do: [:sel4 | pcc enableCallInMethod: sel4 class: self class]. "all enabled now" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule. "try caches" pcc disableEnabled. "all disabled" self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = 0. pcc enableDisabled. "all enabled" + self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule.! - self assert: (pcc methodsWithEnabledCallIntoModule: self exampleModuleName forClass: self class) size = self numOfCallsExampleModule! Item was changed: ----- Method: PrimCallControllerAbstractTest>>testSwitchPrimCallOffOn (in category 'tests') ----- testSwitchPrimCallOffOn | res | pcc disableCallInMethod: self realExternalCallOrPrimitiveFailedSelector class: self class. + self shouldRaiseError: [self perform: self realExternalCallOrPrimitiveFailedSelector]. - self - should: [self perform: self realExternalCallOrPrimitiveFailedSelector] - raise: TestResult error. pcc enableCallInMethod: self realExternalCallOrPrimitiveFailedSelector class: self class. res := self perform: self realExternalCallOrPrimitiveFailedSelector. + self assert: res isString.! - self assert: res isString!

1 0

The Trunk: KernelTests-ct.419.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.419.mcz ==================== Summary ==================== Name: KernelTests-ct.419 Author: ct Time: 31 January 2022, 8:40:22.220214 pm UUID: 9b3e7455-e83b-764c-86b1-943931b15e33 Ancestors: KernelTests-ct.418 Complements SUnit-ct.130 (deprecation of TestResult error) and SUnit-ct.138 (new convenience #shouldRaiseError:). =============== Diff against KernelTests-ct.418 =============== Item was changed: ----- Method: BooleanTest>>testBooleanNew (in category 'tests') ----- testBooleanNew + self shouldRaiseError: [Boolean new]. + self shouldRaiseError: [True new]. + self shouldRaiseError: [False new].! - self should: [Boolean new] raise: TestResult error. - self should: [True new] raise: TestResult error. - self should: [False new] raise: TestResult error. ! Item was changed: ----- Method: BooleanTest>>testNew (in category 'tests') ----- testNew + self shouldRaiseError: [Boolean new].! - self should: [Boolean new] raise: TestResult error. ! Item was changed: ----- Method: FalseTest>>testNew (in category 'tests') ----- testNew + self shouldRaiseError: [False new].! - self should: [False new] raise: TestResult error. ! Item was changed: ----- Method: IntegerTest>>testNew (in category 'tests - instance creation') ----- testNew + self shouldRaiseError: [Integer new].! - self should: [Integer new] raise: TestResult error. ! Item was changed: ----- Method: SmallIntegerTest>>testBasicNew (in category 'tests - Class Methods') ----- testBasicNew + self shouldRaiseError: [SmallInteger basicNew].! - self should: [SmallInteger basicNew] raise: TestResult error. ! Item was changed: ----- Method: SmallIntegerTest>>testNew (in category 'tests - Class Methods') ----- testNew + self shouldRaiseError: [SmallInteger new].! - self should: [SmallInteger new] raise: TestResult error. !

1 0

The Trunk: CollectionsTests-ct.369.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ct.369.mcz ==================== Summary ==================== Name: CollectionsTests-ct.369 Author: ct Time: 31 January 2022, 8:39:18.874214 pm UUID: fba67563-daba-a34c-b997-51f8bf8c153d Ancestors: CollectionsTests-ct.368 Complements SUnit-ct.130 (deprecation of TestResult error) and SUnit-ct.138 (new convenience #shouldRaiseError:). =============== Diff against CollectionsTests-ct.368 =============== Item was changed: ----- Method: SetTest>>testIllegal (in category 'tests - original tests') ----- testIllegal + self shouldRaiseError: [empty at: 5]. + self shouldRaiseError: [empty at: 5 put: #abc].! - self - should: [empty at: 5] raise: TestResult error. - self - should: [empty at: 5 put: #abc] raise: TestResult error. - !

1 0

The Trunk: Chronology-Tests-ct.29.mcz
by commits＠source.squeak.org 31 Jan '22

31 Jan '22

Christoph Thiede uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-ct.29.mcz ==================== Summary ==================== Name: Chronology-Tests-ct.29 Author: ct Time: 31 January 2022, 8:38:49.347214 pm UUID: daa1b1f9-290a-6d40-8a6d-60e77610a83a Ancestors: Chronology-Tests-bp.28 Complements SUnit-ct.130 (deprecation of TestResult error) and SUnit-ct.138 (new convenience #shouldRaiseError:). =============== Diff against Chronology-Tests-bp.28 =============== Item was changed: ----- Method: MonthTest>>testIndexOfMonth (in category 'Tests') ----- testIndexOfMonth | m | m := #(#January #February #March #April #May #June #July #August #September #October #November #December). m withIndexDo: [:item :index | self assert: (Month indexOfMonth: item) = index]. + self shouldRaiseError: [Month indexOfMonth: 1]. + self shouldRaiseError: [Month indexOfMonth: #'1']. + self shouldRaiseError: [Month indexOfMonth: #Marsh]. "notice the misspell!!" + self shouldRaiseError: [Month indexOfMonth: #UnexistingMonth].! - self should: [Month indexOfMonth: 1] raise: TestResult error. - self should: [Month indexOfMonth: #'1'] raise: TestResult error. - self should: [Month indexOfMonth: #Marsh] raise: TestResult error. "notice the misspell!!" - self should: [Month indexOfMonth: #UnexistingMonth] raise: TestResult error.! Item was changed: ----- Method: MonthTest>>testNameOfMonth (in category 'Tests') ----- testNameOfMonth | m | m := #(#January #February #March #April #May #June #July #August #September #October #November #December). m withIndexDo: [:item :index | self assert: (Month nameOfMonth: index) = item]. + self shouldRaiseError: [Month nameOfMonth: 0]. + self shouldRaiseError: [Month nameOfMonth: 13]. + self shouldRaiseError: [Month nameOfMonth: #January].! - self should: [Month nameOfMonth: 0] raise: TestResult error. - self should: [Month nameOfMonth: 13] raise: TestResult error. - self should: [Month nameOfMonth: #January] raise: TestResult error.!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
37
Older →

Jump to page: