Squeak-dev September 2022

squeak-dev@lists.squeakfoundation.org

29 participants
157 discussions

The Inbox: Monticello-ct.785.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-ct.785.mcz ==================== Summary ==================== Name: Monticello-ct.785 Author: ct Time: 8 September 2022, 3:19:07.385836 pm UUID: 9c69102f-1dd8-294a-acde-d8a3052b4e82 Ancestors: Monticello-mt.782 Proposal: When loading/saving a HTTP repository with insufficient authorization (no credentials/wrong password), allow the user to re-authenticate through a dialog window instead of displaying an unhandled NetworkError (401). Also adds support for nil as username/password. Details: Slightly refactor #webClientDo: and senders. Only create authorization header if any credentials have been specified, which avoids two useless re-attempts for each insufficiently authorized requests. Handle WebAuthRequired exceptions by asking for the credentials again. Slightly improves multilingual support. =============== Diff against Monticello-mt.782 =============== Item was added: + ----- Method: MCHttpRepository>>authorizeRequest:forClient: (in category 'private') ----- + authorizeRequest: aWebRequest forClient: aWebClient + + (aWebClient username isNil and: [aWebClient password isNil]) ifFalse: [ + aWebRequest headerAt: 'Authorization' put: 'Basic ', + ((aWebClient username ifNil: ['']), ':', (aWebClient password ifNil: [''])) base64Encoded].! Item was changed: ----- Method: MCHttpRepository>>httpGet:arguments: (in category 'private') ----- httpGet: url arguments: arguments | urlString | urlString := arguments ifNil: [ url ] ifNotNil: [ | queryString | queryString := WebUtils encodeUrlEncodedForm: arguments. (url includes: $?) ifTrue: [ url, '&', queryString ] ifFalse: [ url, '?', queryString ] ]. urlString := self class rewriteUrl: urlString forDownload: true. + ^self webClientDo: [ :client :requestBlock | + client httpGet: urlString do: requestBlock ]! - ^self webClientDo: [ :client | - client - username: self user; - password: self password; - httpGet: urlString do: [ :request | - request - headerAt: 'Authorization' put: 'Basic ', (self user, ':', self password) base64Encoded; - headerAt: 'Connection' put: 'Keep-Alive'; - headerAt: 'Accept' put: '*/*' ] ]! Item was changed: ----- Method: MCHttpRepository>>password (in category 'accessing') ----- password self userAndPasswordFromSettingsDo: [:usr :pwd | ^pwd]. + self user isEmptyOrNil ifTrue: [^password]. - self user isEmpty ifTrue: [^password ifNil: ['']]. password isEmptyOrNil ifTrue: [ + self requestUserAndPassword]. - | answer | - "Give the user a chance to change the login" - answer := UIManager default request: 'User name for ', String cr, location - initialAnswer: self user. - answer isEmpty - ifTrue: [^password] - ifFalse: [self user: answer]. - - password := UIManager default requestPassword: 'Password for "', self user, '" at ', String cr, location. - ]. ^ password! Item was added: + ----- Method: MCHttpRepository>>requestUserAndPassword (in category 'accessing') ----- + requestUserAndPassword + "Give the user a chance to change the login" + + | answer | + answer := Project uiManager + request: ('User name for\{1}' withCRs translated format: {location}) + initialAnswer: (self user ifNil: ['']). + answer isEmpty + ifTrue: [^ false] + ifFalse: [self user: answer]. + + password := Project uiManager + requestPassword: ('Password for "{1}" at\{2}' withCRs translated format: {self user. location}). + ^ true! Item was changed: ----- Method: MCHttpRepository>>user (in category 'accessing') ----- + user - user self userAndPasswordFromSettingsDo: [:usr :pwd | ^usr]. "not in settings" + ^user! - ^user ifNil: ['']! Item was changed: ----- Method: MCHttpRepository>>webClientDo: (in category 'private') ----- webClientDo: aBlock | client attemptsLeft response result | self class useSharedWebClientInstance ifTrue: [ "Acquire webClient by atomically storing it in the client variable and setting its value to nil." client := webClient. webClient := nil ]. client ifNil: [ client := WebClient new ] ifNotNil: [ "Attempt to avoid an error by recreating the underlying stream." client isConnected ifFalse: [ client close ] ]. attemptsLeft := 3. response := nil. [ response isNil and: [ attemptsLeft > 0 ] ] whileTrue: [ + client + username: self user; + password: self password. + response := [ aBlock value: client value: [:request | + self authorizeRequest: request forClient: client. + request + headerAt: 'Connection' put: 'Keep-Alive'; + headerAt: 'Accept' put: '*/*' ] ] + on: WebAuthRequired do: [ :ex | + self requestUserAndPassword ifTrue: [ + ex client + username: self user; + password: self password. + self authorizeRequest: ex request forClient: ex client. + ex resume: true ]. + ex pass ] + on: NetworkError do: [ :error | - response := [ aBlock value: client ] - on: NetworkError - do: [ :error | attemptsLeft = 0 ifTrue: [ error pass ]. (3 - attemptsLeft) seconds asDelay wait. attemptsLeft := attemptsLeft - 1. nil "The response" ] ]. result := (response code between: 200 and: 299) ifFalse: [ response content. "Make sure content is read." nil ] ifTrue: [ (RWBinaryOrTextStream with: ( response contentWithProgress: [ :total :amount | HTTPProgress new total: total; amount: amount; signal ])) reset ]. self class useSharedWebClientInstance ifTrue: [ "Save the WebClient instance for reuse, but only if there is no client cached." webClient ifNil: [ webClient := client ] ifNotNil: [ client close ] ] ifFalse: [ client close ]. (response code = 404 "Not Found" or: [response code = 410 "Gone"]) ifTrue: [ "Need to distinguish between lookup errors and connection errors. Lookup errors will be handled by some senders following the EAFP principle. See #versionNamed:." (NotFound object: response url) signal ]. result ifNil: [ NetworkError signal: 'Could not access ', location ]. ^result! Item was changed: ----- Method: MCHttpRepository>>writeStreamForFileNamed:replace:do: (in category 'private') ----- writeStreamForFileNamed: aString replace: ignoreBoolean do: aBlock | stream urlString | stream := RWBinaryOrTextStream on: String new. aBlock value: stream. urlString := self urlForFileNamed: aString. urlString := self class rewriteUrl: urlString forDownload: false. + ^self displayProgress: ('Uploading {1}' translated format: {aString}) during: [ + self webClientDo: [ :client :requestBlock | + client httpPut: urlString + content: stream contents + type: nil + do: requestBlock ] ]! - ^self displayProgress: 'Uploading ', aString during: [ - self webClientDo: [ :client | - client - username: self user; - password: self password; - httpPut: urlString - content: stream contents - type: nil - do: [ :request | - request - headerAt: 'Authorization' put: 'Basic ', (self user, ':', self password) base64Encoded; - headerAt: 'Connection' put: 'Keep-Alive'; - headerAt: 'Accept' put: '*/*' ] ] ]!

1 0

The Inbox: Tools-ct.1172.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1172.mcz ==================== Summary ==================== Name: Tools-ct.1172 Author: ct Time: 8 September 2022, 3:03:50.094836 pm UUID: f2edc96d-df9a-6b49-9180-ba09b4bd2466 Ancestors: Tools-ct.1171 Proposal: In hierarchy browsers without a system category list, adds the "browse package" submenu to the class list menu. Also improves multilingual support. =============== Diff against Tools-ct.1171 =============== Item was changed: ----- Method: Browser>>classListMenu: (in category 'class functions') ----- classListMenu: aMenu "Conveniently fit for backward compatibility with old browers stored in image segments" <classListMenuShifted: false> + aMenu addTranslatedList: #( - aMenu addList: #( - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' spawnHierarchy) ('browse protocol (p)' browseFullProtocol) + ('browse documentation' browseAllCommentsForClass)). + + (self hasSystemCategoryList not and: [Smalltalk isMorphic] and: [self selectedPackage notNil]) ifTrue: [ + aMenu + add: ('browse package ''{1}''' translated format: {self selectedPackage name}) + subMenu: (self packageMenu: ((Smalltalk isMorphic + ifTrue: [MenuMorph new defaultTarget: self; yourself] + ifFalse: [CustomMenu new]) + yourself)) + target: self + selector: #yourself + argumentList: #()]. + + aMenu addTranslatedList: #( - ('browse documentation' browseAllCommentsForClass) - ('printOut' printOutClass) ('fileOut' fileOutClass) - ('show hierarchy' hierarchy) ('show definition' editClass) ('show comment' editComment) - ('references... (r)' browseVariableReferences) ('assignments... (a)' browseVariableAssignments) ('class refs (N)' browseClassRefs) - ('rename class ...' renameClass) ('copy class' copyClass) ('remove class (x)' removeClass) - ('find method...' findMethod)). + ^ aMenu! - ^ aMenu - ! Item was added: + ----- Method: Browser>>hasSystemCategoryList (in category 'multi-window support') ----- + hasSystemCategoryList + + ^ self dependents anySatisfy: [:dependent | + (dependent respondsTo: #getListSelector) and: + [dependent getListSelector = #systemCategoryList]]!

1 0

The Trunk: Tools-ct.1171.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1171.mcz ==================== Summary ==================== Name: Tools-ct.1171 Author: ct Time: 8 September 2022, 1:21:03.169836 pm UUID: bcbd0daa-2082-5348-99c8-db2db487ea89 Ancestors: Tools-mt.1170 Minor updates to package pane browser: * When selecting a different package, update the class list properly (instead of relying on model steps which are not even available in MVC). * Remove misleading reorganize/alphabetize from the package list menu - they are already contained in the system category menu. * Improve multilingual support. =============== Diff against Tools-mt.1170 =============== Item was changed: ----- Method: PackagePaneBrowser>>mainPackageMenu: (in category 'package list') ----- mainPackageMenu: aMenu "Answer a Menu of operations on class packages to be displayed when the operate menu button is pressed." <packageListMenu> + ^aMenu addTranslatedList: #( - ^aMenu addList: #( ('find class... (f)' findClass) ('back... (b)' recent) - ('browse extensions' browsePackageExtensions) ('browse dependencies' browsePackageDependencies) ('browse inverted dependencies' browsePackageDependenciesInverted) - - - ('reorganize' editSystemCategories) - ('alphabetize' alphabetizeSystemCategories) - ('update' updatePackages)); yourself.! Item was changed: ----- Method: PackagePaneBrowser>>packageListIndex: (in category 'package list') ----- packageListIndex: anInteger "Set anInteger to be the index of the current package selection." packageListIndex := anInteger. anInteger = 0 ifFalse: [package := self packageList at: packageListIndex]. selectedMessageCategoryName := nil. self selectSystemCategory: nil. selectedMessageName := nil. selectedClassName := nil. self setClassOrganizer. self changed: #packageSelectionChanged. self changed: #packageListIndex. "update my selection" self changed: #systemCategoryList. "update the category list" self selectSystemCategory: nil. "update category list selection" + self changed: #classList. "update the class list" + self selectClass: nil. "update category list selection"! - !

1 0

source.squeak.org has been upgraded
by Chris Muller 08 Sep '22

08 Sep '22

Hi all, I'm pleased to report that source.squeak.org is feeling like Superman compared to yesterday. It's finally running on the correct vm, and with a major performance bug in the app finally found and fixed earlier today. On top of all that, it's even on new hardware, thanks to Levente. So, 'revisions' is back, hopefully for good, with good performance for all use-cases. I went through everything including some trunk commits tonight, and the snappy performance was a pleasure. I hope it holds up this well as y'all start to use it simultaneously. I think it will..! - Chris

2 1

The Trunk: System-cmm.1369.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.1369.mcz ==================== Summary ==================== Name: System-cmm.1369 Author: cmm Time: 8 September 2022, 12:10:18.750061 am UUID: a8c13c20-b18b-4b8a-a5a1-e2ddcbd0a856 Ancestors: System-cmm.1368 Handle ProvideAnswerNotification's during headless operation the same as an Error (print and exit). =============== Diff against System-cmm.1368 =============== Item was changed: ----- Method: SmalltalkImage>>run: (in category 'command line') ----- run: aBlock [ [ self patchSystem. (aBlock numArgs = 1 and: [ self arguments size > 1 ]) ifTrue: [ "Allow a large, variable number of arguments to be passed as an Array to aBlock." aBlock value: self arguments ] ifFalse: [ aBlock valueWithEnoughArguments: self arguments ] ] - on: ProgressInitiationException - do: - [ : pie | "Don't want to log this notification." - pie defaultAction ] ] - on: Notification , Warning - do: - [ : noti | FileStream stdout - nextPutAll: DateAndTime now asString ; - space ; - nextPutAll: noti description ; - cr. - noti resume ] on: SyntaxErrorNotification do: [ : err | FileStream stdout nextPutAll: err errorCode ; cr; flush. self isHeadless ifTrue: [ self snapshot: false andQuit: true ] ifFalse: [ err pass ] ] + on: Error , ProvideAnswerNotification - on: Error do: [ : err | err printVerboseOn: FileStream stderr. FileStream stderr flush. self isHeadless ifTrue: [ self snapshot: false andQuit: true ] + ifFalse: [ err pass ] ] + on: ProgressInitiationException + do: + [ : pie | "Don't want to log this Notification." + pie defaultAction ] ] + on: Notification , Warning + do: + [ : noti | FileStream stdout + nextPutAll: DateAndTime now asString ; + space ; + nextPutAll: noti description ; + cr. + noti resume ] + ! - ifFalse: [ err pass ] ]!

1 0

The Trunk: Files-cmm.196.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

Chris Muller uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-cmm.196.mcz ==================== Summary ==================== Name: Files-cmm.196 Author: cmm Time: 7 September 2022, 11:50:10.459154 pm UUID: b951789a-e601-41bc-98ba-e4fb60d5ad4b Ancestors: Files-eem.195 When running Squeak headless, don't let it get hung up in its startup sequence due to a missing .sources file. =============== Diff against Files-eem.195 =============== Item was changed: ----- Method: FileDirectory class>>startUp (in category 'system start up') ----- startUp - self startUpDefaultDirectory. + [ Smalltalk openSourceFiles ] + on: ProvideAnswerNotification + do: + [ : noti | Smalltalk isHeadless + ifTrue: [ "Cannot warn terminal, stdout isn't initialized because FileStream class>>#startUp: hasn't been called yet." + "FileStream stdout nextPutAll: noti messageText." + "Since we're headless anyway, source likely won't matter. Continue." + noti resume: true ] + ifFalse: [ noti pass ] ]! - Smalltalk openSourceFiles.!

1 0

The Trunk: System-cmm.1368.mcz
by commits＠source.squeak.org 08 Sep '22

08 Sep '22

Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.1368.mcz ==================== Summary ==================== Name: System-cmm.1368 Author: cmm Time: 7 September 2022, 11:44:24.530988 pm UUID: 1e9cce91-389c-4e8f-9fb2-05714f748ca4 Ancestors: System-ct.1367 When Squeak is run headless with a syntax error in the startup document, report it to the terminal and exit rather than leave the process hung with no output clues. =============== Diff against System-ct.1367 =============== Item was changed: ----- Method: CodeLoader>>installSourceFile: (in category 'installing') ----- installSourceFile: aStream "Install the previously loaded source file" | contents trusted | aStream ifNil:[^self error:'No content to install']. trusted := SecurityManager default positionToSecureContentsOf: aStream. trusted ifFalse:[(SecurityManager default enterRestrictedMode) ifFalse:[ aStream close. ^ self error:'Insecure content encountered']]. contents := self allButShebangLine: aStream upToEnd unzipped asString. (aStream respondsTo: #close) ifTrue:[aStream close]. + ^[contents readStream fileIn] + on: SyntaxErrorNotification + do: [ : err | Smalltalk isHeadless + ifTrue: + [FileStream stdout nextPutAll: err errorCode; cr; flush. + Smalltalk snapshot: false andQuit: true ] + ifFalse: [err pass] ]! - ^contents readStream fileIn!

1 0

The Inbox: Morphic-cmm.2024.mcz
by commits＠source.squeak.org 07 Sep '22

07 Sep '22

Chris Muller uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-cmm.2024.mcz ==================== Summary ==================== Name: Morphic-cmm.2024 Author: cmm Time: 7 September 2022, 3:46:32.202167 pm UUID: 0aaef174-20a7-4ffc-b7ce-95de8239c04b Ancestors: Morphic-mt.2023 Commit test. Please ignore. =============== Diff against Morphic-mt.2023 =============== Item was added: + ----- Method: Morph class>>test (in category 'testing') ----- + test!

1 0

Squeak issue tracking Github
by Jörg Belger 07 Sep '22

07 Sep '22

Hello, Can anybody tell me what the right Github repository is to make an issue for the Squeak image? I know it was posted here on this mailing list in past, but I do not find it again and I do not see it on the website. I have a virtual machine issue, but Eliot told me that this is an image problem, that a low-space condition is not reported and my expression is not interrupted. I would like to create a Github issue and not reporting things here. Jörg

3 3

The Trunk: Chronology-Tests-dtl.31.mcz
by commits＠source.squeak.org 06 Sep '22

06 Sep '22

David T. Lewis uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-dtl.31.mcz ==================== Summary ==================== Name: Chronology-Tests-dtl.31 Author: dtl Time: 19 May 2022, 12:04:32.792923 pm UUID: ed1a302a-660e-4fc1-bdf7-6afb9b82fc90 Ancestors: Chronology-Tests-ct.30 Test updates to support Chronology-Core-dtl.80. Change DateAndTime>>offset: to be compliant with the ANSI draft spec. The offset: method should answer an instance equivalent to the receiver, where equivalent means having the same UTC time. =============== Diff against Chronology-Tests-ct.30 =============== Item was changed: ----- Method: DateAndTimeEpochTest>>testOffset (in category 'tests') ----- testOffset self assert: aDateAndTime offset = '0:00:00:00' asDuration. + self assert: (aDateAndTime asLocalAt: '0:12:00:00') = '1901-01-01T00:00:00+12:00' asDateAndTime! - self assert: (aDateAndTime offset: '0:12:00:00') = '1901-01-01T00:00:00+12:00' asDateAndTime! Item was added: + ----- Method: DateAndTimeLeapTest>>testAsLocalAt (in category 'testing') ----- + testAsLocalAt + self assert: aDateAndTime offset = '0:02:00:00' asDuration. + self assert: (aDateAndTime asLocalAt: '0:12:00:00') = '2004-02-29T13:33:00+12:00' asDateAndTime! Item was changed: ----- Method: DateAndTimeLeapTest>>testAsTimeStamp (in category 'testing') ----- testAsTimeStamp + self assert: aDateAndTime asTimeStamp = ((TimeStamp readFrom: '2-29-2004 1:33 pm' readStream) asLocalAt: 2 hours). - self assert: aDateAndTime asTimeStamp = ((TimeStamp readFrom: '2-29-2004 1:33 pm' readStream) offset: 2 hours). ! Item was changed: ----- Method: DateAndTimeLeapTest>>testOffset (in category 'testing') ----- testOffset self assert: aDateAndTime offset = '0:02:00:00' asDuration. + self assert: (aDateAndTime offset: '0:12:00:00') = '2004-02-29T23:33:00+12:00' asDateAndTime! - self assert: (aDateAndTime offset: '0:12:00:00') = '2004-02-29T13:33:00+12:00' asDateAndTime! Item was changed: ----- Method: DateAndTimeLeapTest>>testYearDayHourMinuteSecond (in category 'testing') ----- testYearDayHourMinuteSecond + self assert: aDateAndTime = ((DateAndTime year: 2004 day: 60 hour: 13 minute: 33 second: 0) asLocalAt: 2 hours). - self assert: aDateAndTime = ((DateAndTime year: 2004 day: 60 hour: 13 minute: 33 second: 0) offset: 2 hours). ! Item was changed: ----- Method: DateAndTimeLeapTest>>testYearMonthDayHourMinuteSecond (in category 'testing') ----- testYearMonthDayHourMinuteSecond + self assert: aDateAndTime = ((DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0) asLocalAt: 2 hours). - self assert: aDateAndTime = ((DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0) offset: 2 hours). ! Item was changed: ----- Method: DateTest>>testMakeUTC (in category 'testing') ----- testMakeUTC "Equal dates should compare equal regardless of which TimeZone they are created in." | priorTz priorPreference march31stLocal march31stOcean | priorTz := DateAndTime localTimeZone. priorPreference := DateAndTime automaticTimezone. [DateAndTime localTimeZone: (TimeZone offset: 9 hours name: 'Early Test Countries' abbreviation: 'Test Ocean Early'). march31stLocal := Date year: 2016 month: 3 day: 31. + march31stLocal start: (march31stLocal start asLocalAt: DateAndTime localTimeZone offset). - march31stLocal start: (march31stLocal start offset: DateAndTime localTimeZone offset). DateAndTime localTimeZone: (TimeZone offset: -9 hours name: 'Late Test Countries' abbreviation: 'Test Ocean Late'). march31stOcean := Date year: 2016 month: 3 day: 31. + march31stOcean start: (march31stOcean start asLocalAt: DateAndTime localTimeZone offset).] - march31stOcean start: (march31stOcean start offset: DateAndTime localTimeZone offset).] ensure: [DateAndTime localTimeZone: priorTz. DateAndTime automaticTimezone: priorPreference]. self deny: march31stLocal = march31stOcean; assert: march31stOcean > march31stLocal. self assert: march31stLocal makeUTC = march31stOcean makeUTC; deny: march31stOcean makeUTC > march31stLocal makeUTC; deny: march31stOcean makeUTC < march31stLocal makeUTC.! Item was changed: ----- Method: YearTest>>testCurrent (in category 'Tests') ----- testCurrent self assert: Year current start = ((DateAndTime year: DateAndTime now year month: 1 + day: 1) asLocalAt: Year defaultOffset)! - day: 1) offset: Year defaultOffset)!

1 0

Jump to page: