Squeak-dev September 2022

squeak-dev@lists.squeakfoundation.org

29 participants
157 discussions

The Trunk: Morphic-ct.2045.mcz
by commits＠source.squeak.org 20 Sep '22

20 Sep '22

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2045.mcz ==================== Summary ==================== Name: Morphic-ct.2045 Author: ct Time: 20 September 2022, 6:57:11.442179 pm UUID: 6377fe4c-8683-8042-8430-904dd1403b2a Ancestors: Morphic-ct.2043 Fixes bindings access during accept-it in PluggableTextMorph. Analogously to #correctFrom:to:with:, the morph which presents itself as the requestor to the model needs to forward this request to the original requestor, its editor. Note that print-it et al. were not affected because they pass the editor itself to the model or the compiler, resp. =============== Diff against Morphic-ct.2043 =============== Item was added: + ----- Method: PluggableTextMorph>>bindingOf: (in category 'binding') ----- + bindingOf: aString + + ^ textMorph editor bindingOf: aString!

1 0

The Trunk: Tools-mt.1087.mcz
by commits＠source.squeak.org 20 Sep '22

20 Sep '22

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1087.mcz ==================== Summary ==================== Name: Tools-mt.1087 Author: mt Time: 15 December 2021, 4:52:00.953892 pm UUID: 627887b0-5064-ab43-b7ac-60b329a8b606 Ancestors: Tools-mt.1086 Tweak BlockClosureInspector to show all the closured stuff including temps from the outer context and inst-vars from the current receiver. Adds some caching to make it faster. Support cache invalidation only for changing the #receiver field. Not sure whether it makes sense to support changing the outerContext as well... =============== Diff against Tools-mt.1086 =============== Item was changed: Inspector subclass: #BlockClosureInspector + instanceVariableNames: 'debuggerMap tempVarNames instVarNames' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Tools-Inspector'! Item was added: + ----- Method: BlockClosureInspector>>debuggerMap (in category 'private') ----- + debuggerMap + + ^ debuggerMap ifNil: [debuggerMap := self object method debuggerMap]! Item was changed: ----- Method: BlockClosureInspector>>hasBindingOf: (in category 'user interface - styling') ----- hasBindingOf: aString self object method literalsDo: [:literal | (literal isVariableBinding and: [literal key = aString]) ifTrue: [^ true]]. + + (self tempVarNames includes: aString) ifTrue: [^ true]. + (self instVarNames includes: aString) ifTrue: [^ true]. + + ^ false! - ^ self object outerContext tempNames includes: aString! Item was added: + ----- Method: BlockClosureInspector>>instVarNames (in category 'private') ----- + instVarNames + + ^ instVarNames ifNil: [instVarNames := (self object receiver perform: #class "avoid inlining; support proxies") allInstVarNames]! Item was added: + ----- Method: BlockClosureInspector>>replaceSelectionValue: (in category 'selection') ----- + replaceSelectionValue: anObject + + | success | + (success := super replaceSelectionValue: anObject) ifTrue: [ + self selectedField key = #receiver + ifTrue: [instVarNames := nil]]. + ^ success! Item was changed: ----- Method: BlockClosureInspector>>streamBindingsOn: (in category 'fields - streaming') ----- streamBindingsOn: aStream + | compiledCode instNames tempNames | - | compiledCode tempNames | self flag: #decompile. "mt: Use #to: and #do: instead of #to:do: to avoid inlining to preserve bindings in enumeration block for later decompilation. See InspectorField." + + (1 to: (instNames := self instVarNames) size) do: [:index | + aStream nextPut: ((self newFieldForType: #instVar key: index) + name: ('[[[{1}]]]' format: {instNames at: index}); + valueGetter: [:closure | closure receiver instVarAt: index]; + valueSetter: [:closure :value | closure receiver instVarAt: index put: value]; + yourself)]. + + tempNames := self tempVarNames. + "No need to show closured bindings from outerContext. The important temps are already covered in the indexed fields below." + (1 to: tempNames size - self object basicSize) do: [:index | + aStream nextPut: ((self newFieldForType: #tempVar key: index) + name: ('[[{1}]]' format: {tempNames at: index}); + valueGetter: [:closure | closure outerContext tempAt: index]; + valueSetter: [:closure :value | closure outerContext tempAt: index put: value]; + yourself)]. + (1 to: (compiledCode := self object method) numLiterals) do: [:index | | literal | literal := compiledCode literalAt: index. literal isVariableBinding ifTrue: [ aStream nextPut: ((self newFieldForType: #tempVar key: index) name: ('[{1}]' format: {literal key}); valueGetter: [:closure | (closure method literalAt: index) value]; valueSetter: [:closure :value | (closure method literalAt: index) value: value]; yourself)]]. + - - tempNames := self object outerContext tempNames. - "No need to show closured bindings from outerContext. The important temps are already covered in the indexed fields below." - "(1 to: tempNames size - self object basicSize) do: [:index | - aStream nextPut: ((self newFieldForType: #tempVar key: index) - name: ('[{1}]' format: {tempNames at: index}); - valueGetter: [:closure | closure outerContext tempAt: index]; - valueSetter: [:closure :value | closure outerContext tempAt: index put: value]; - yourself)]." - (1 to: self object basicSize) do: [:index | aStream nextPut: ((self newFieldForType: #tempVar key: index) name: ('[{1}]' format: {tempNames at: index + tempNames size - self object basicSize}); valueGetter: [:closure | closure basicAt: index]; valueSetter: [:closure :value | closure basicAt: index put: value]; yourself)]. "See commentary in #doItReceiver. No need to expose the closured 'self' here because there is already the #receiver instVar. fieldReceiver ^ (self newFieldForType: #tempVar key: #receiver) name: '[self]'; valueGetter: [:obj | obj receiver]; valueSetter: [:obj :value | obj receiver: value]; yourself "! Item was added: + ----- Method: BlockClosureInspector>>tempVarNames (in category 'private') ----- + tempVarNames + + ^ tempVarNames ifNil: [tempVarNames := self debuggerMap tempNamesForContext: self object outerContext]!

2 2

The Trunk: MorphicTests-eem.90.mcz
by commits＠source.squeak.org 19 Sep '22

19 Sep '22

Eliot Miranda uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-eem.90.mcz ==================== Summary ==================== Name: MorphicTests-eem.90 Author: eem Time: 18 September 2022, 4:24:10.461842 pm UUID: 603fd351-0103-4c6a-abe7-56bc521b0092 Ancestors: MorphicTests-ct.89 Fix WorldStateTest>>testActiveVariablesRenamed gioen that none of ActiveWorld ActiveHand ActiveEvent are classes any more. =============== Diff against MorphicTests-ct.89 =============== Item was changed: ----- Method: WorldStateTest>>testActiveVariablesRenamed (in category 'tests') ----- testActiveVariablesRenamed "Document the desire to rename Active(World|Hand|Event)Variable to Active(World|Hand|Event) after the Squeak 6.0 release." #(ActiveWorld ActiveHand ActiveEvent) do: [:className | (SystemVersion current majorVersionNumber >= 6 and: [SystemVersion current minorVersionNumber >= 1]) + ifTrue: [(Smalltalk classNamed: className) ifNotNil: + [:class| self assert: (class includesBehavior: DynamicVariable)]] - ifTrue: [self assert: ((Smalltalk classNamed: className) includesBehavior: DynamicVariable)] ifFalse: [self deny: (Smalltalk at: className) isBehavior] ].!

1 0

Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox: Compiler-ct.480.mcz]
by Thiede, Christoph 15 Sep '22

15 Sep '22

Maybe a masked error of some access error/cache miss to the old version? Just speculating, the Squeaksource admins might know more ... ________________________________ Von: Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im Auftrag von karl ramberg <karlramberg(a)gmail.com> Gesendet: Dienstag, 13. September 2022 18:25:22 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] Duffing broken for Inbox [was: The Inbox: Compiler-ct.480.mcz] I have seen the same issue for Etoys in the inbox. Diff is wrong and all classes are added to a commit. Best, Karl On Tue, Sep 13, 2022 at 4:34 PM Eliot Miranda <eliot.miranda(a)gmail.com<mailto:eliot.miranda@gmail.com>> wrote: The below shows that code diffing is broken for Inbox. Instead of showing the difference in the commit the below appears to list the entire Compiler package starting with AssignmentNode. _,,,^..^,,,_ (phone)

4 6

The Inbox: Compiler-eem.479.mcz
by commits＠source.squeak.org 15 Sep '22

15 Sep '22

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-eem.479.mcz ==================== Summary ==================== Name: Compiler-eem.479 Author: eem Time: 5 July 2022, 4:06:16.298061 pm UUID: 61d1f08e-6212-45d1-b07a-8d4d39ce7c2f Ancestors: Compiler-eem.478 Add BytecodeEncoder class>>isReturnSelfFromMethodAt:in: and Sista & V3 implementations so that CompiledCode>>hasMethodReturn can be implemented correctly. =============== Diff against Compiler-eem.478 =============== Item was added: + ----- Method: BytecodeEncoder class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + self subclassResponsibility! Item was added: + ----- Method: EncoderForSistaV1 class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + ^(method at: pc) = 88! Item was added: + ----- Method: EncoderForV3 class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + ^(method at: pc) = 120!

1 0

The Trunk: Graphics-mt.520.mcz
by commits＠source.squeak.org 15 Sep '22

15 Sep '22

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.520.mcz ==================== Summary ==================== Name: Graphics-mt.520 Author: mt Time: 8 June 2022, 2:50:00.935335 pm UUID: 8fb5feb3-71e4-1240-8c76-b10b119a18e2 Ancestors: Graphics-mt.519 Fixes a rounding issue with fractional points in integer rectangles. =============== Diff against Graphics-mt.519 =============== Item was changed: ----- Method: Rectangle>>pointAtFraction: (in category 'rectangle functions') ----- pointAtFraction: relativePoint + "For values between 0.0 and 1.0, answers a point that lies within the receiver. + This method is a more general form of #center (meaning 0.5(a)0.5), #topLeft + (meaning 0.0(a)0.0), #bottomCenter (meaning 0.5(a)1.0), etc. + NOTE THAT for proportions that equal 1.0, the resulting point will NOT lie + within the receiver, i.e., #containsPoint: will answer false." + - | result | result := self origin + (self extent * relativePoint). ^ self isIntegerRectangle + ifTrue: [result floor] - ifTrue: [result rounded] ifFalse: [result]!

2 1

Difference between Tools and Apps menu?
by Jaromir Matas 15 Sep '22

15 Sep '22

Hi All, another quick question: What is the difference between Tools and Apps menu? Version 4 introduced Tools menu, version 5 added Apps menu. I can't figure out what the difference is other than Apps are "More Tools". But then why would some entries be in both? So it's probably not it... Or is it about frequency, importance? And then there's "Preferences" in Tools and the same tool named "Preference Browser" in Apps which is also confusing. Thanks for any advice :) -- Jaromír Matas mail(a)jaromir.net

5 5

Installer inbox cleanup
by Tim Johnson 15 Sep '22

15 Sep '22

Hi, Can someone please delete my inbox contribution, Installer-Core-tcj-440.mcz from August 2020? It is superseded by Installer-Core-lrnp.447.mcz which is (I believe) the same intention but better executed. Thanks, Tim

2 1

The Inbox: Morphic-ct.2044.mcz
by commits＠source.squeak.org 14 Sep '22

14 Sep '22

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2044.mcz ==================== Summary ==================== Name: Morphic-ct.2044 Author: ct Time: 14 September 2022, 7:49:27.697879 pm UUID: 8df3aeb1-91fa-6943-835c-d24a1b16caad Ancestors: Morphic-ct.2043 Proposal: Avoids trickling/incomplete selections in PluggableListMorphOfMany by remembering the previous dragged index and updating all items since there in #mouseMove:. Especially helpful for low performance systems. =============== Diff against Morphic-ct.2043 =============== Item was changed: PluggableListMorph subclass: #AlternatePluggableListMorphOfMany instanceVariableNames: 'getSelectionListSelector setSelectionListSelector' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'! + !AlternatePluggableListMorphOfMany commentStamp: 'ct 9/14/2022 19:45' prior: 0! + This is a multi-select list that is more conventional in its behavior than PluggableListMorphOfMany. It utilizes a shift+click mechanism for selecting ranges, and control+click for toggling individual selections.! - !AlternatePluggableListMorphOfMany commentStamp: 'cmm 3/2/2010 14:39' prior: 0! - This is a multi-select list that is more conventional in its behavior than PluggableListMorphOfMany. It utilizes a shift+click mechanism for selecting ranges, and control+click for toggling individual selections. This list also allows fast mouse swipes without missing any message selections.! Item was changed: PluggableListMorph subclass: #PluggableListMorphOfMany + instanceVariableNames: 'dragOnOrOff getSelectionListSelector setSelectionListSelector lastDraggedIndex' - instanceVariableNames: 'dragOnOrOff getSelectionListSelector setSelectionListSelector' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'! !PluggableListMorphOfMany commentStamp: 'hpt 4/5/2004 11:21' prior: 0! A variant of its superclass that allows multiple items to be selected simultaneously. There is still a distinguished element which is selected, but each other element in the list may be flagged on or off. ! Item was changed: ----- Method: PluggableListMorphOfMany>>mouseDown: (in category 'event handling') ----- mouseDown: event | row index | event yellowButtonPressed ifTrue: [^ self yellowButtonActivity: event shiftPressed]. row := self rowAtLocation: event position. row = 0 ifTrue: [^super mouseDown: event]. index := self modelIndexFor: row. model okToChange ifFalse: [^ self]. "No change if model is locked" self changeModelSelection: index. "Set meaning for subsequent dragging of selection" self listSelectionAt: index + put: (dragOnOrOff := (self listSelectionAt: index) not). + lastDraggedIndex := index.! - put: (dragOnOrOff := (self listSelectionAt: index) not) - ! Item was changed: ----- Method: PluggableListMorphOfMany>>mouseMove: (in category 'event handling') ----- mouseMove: event "The mouse has moved, as characterized by the event provided. Adjust the scrollbar, and alter the selection as appropriate" + | row index direction originIndex | - | row index | event position y < self top ifTrue: [scrollBar scrollUp: 1. row := self rowAtLocation: scroller topLeft + (1 @ 1)] ifFalse: [row := event position y > self bottom ifTrue: [scrollBar scrollDown: 1. self rowAtLocation: scroller bottomLeft + (1 @ -1)] ifFalse: [ self rowAtLocation: event position]]. row = 0 ifTrue: [^super mouseDown: event]. index := self modelIndexFor: row. model okToChange ifFalse: [^self]. "No change if model is locked" dragOnOrOff ifNil: [ "Was not set at mouse down, which means the mouse must have gone down in an area where there was no list item" dragOnOrOff := (self listSelectionAt: index) not]. + - self changeModelSelection: index. + + "Update selections. To avoid trickling/incomplete selections for fast mouse swipes, update all selections from the previous index." + originIndex := (lastDraggedIndex ifNil: [index]). + direction := 1 sign: index - originIndex. + ((originIndex + direction) to: index - direction by: direction) do: [:eachIndex | + self listSelectionAt: eachIndex put: dragOnOrOff]. + self listSelectionAt: index put: dragOnOrOff. + lastDraggedIndex := index.! - self listSelectionAt: index put: dragOnOrOff.! Item was changed: ----- Method: PluggableListMorphOfMany>>mouseUp: (in category 'event handling') ----- mouseUp: event dragOnOrOff := nil. "So improperly started drags will have not effect" + lastDraggedIndex := nil. event hand newKeyboardFocus: self. hasFocus := true. Cursor normal show.!

1 0

Review Request: fix-directedSuperSend-frameSize.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 14 Sep '22

14 Sep '22

This was a funny one! Please review. :-) Best, Christoph =============== Summary =============== Change Set: fix-directedSuperSend-frameSize Date: 14 September 2022 Author: Christoph Thiede Fixes omission fault in encoder that caused an insufficient frame size for compiled blocks with a directed super send. While the Cog VM was able to execute these methods anyway (probably performing invalid mem accesses?), the debugger aka image simulator failed to do so. =============== Diff =============== CompilerTest>>testDirectedSuperSendStackSize {tests - syntax} · ct 9/14/2022 16:35 + testDirectedSuperSendStackSize + + {13. CompiledCode smallFrameSize. + 14. CompiledCode fullFrameSize} + pairsDo: [:numTemps :expectedBlockFrame | + | temps compiledMethod methodNode compiledBlock | + temps := (Character alphabet first: numTemps) asArray. + methodNode := Compiler new + compile: 'griffle + |' , (temps joinSeparatedBy: $ ) , '| + ' , (temps withIndexCollect: [:t :i | '' , t , ':=' , i , '. ']) join , ' + [' , (temps joinSeparatedBy: $+) , '. + super someDirectedSend: a] value.' + in: nil class + environment: nil environment + notifying: nil + ifFail: [^ self fail]. + compiledMethod := methodNode generateWithTempNames. + + self + assert: compiledMethod equals: compiledMethod codeLiterals first; + assert: 2 equals: compiledMethod codeLiterals size. + self assert: CompiledCode fullFrameSize equals: compiledMethod frameSize. + compiledBlock := compiledMethod codeLiterals second. + self + assert: compiledBlock isCompiledBlock; + assert: expectedBlockFrame equals: compiledBlock frameSize]. SelectorNode>>emitCode:args:encoder:super: {code generation} · ct 9/14/2022 16:19 (changed) emitCode: stack args: nArgs encoder: encoder super: supered code < Send ifTrue: [self internalEncodingError]. - stack pop: nArgs. supered ifTrue: [(encoder supportsFullBlocks and: [encoder generatingFullBlock]) ifTrue: - [encoder genPushLiteral: (encoder sharableLitIndex: encoder classEncoding). + [stack push: 1. "superclass" + encoder genPushLiteral: (encoder sharableLitIndex: encoder classEncoding). + stack pop: 1 "superclass". + stack pop: nArgs. encoder genSendDirectedSuper: index numArgs: nArgs] - ifFalse: [encoder genSendSuper: index numArgs: nArgs]] + ifFalse: + [stack pop: nArgs. + encoder genSendSuper: index numArgs: nArgs]] ifFalse: - [encoder genSend: index numArgs: nArgs] + [stack pop: nArgs. + encoder genSend: index numArgs: nArgs] ["fix-directedSuperSend-frameSize.1.cs"] --- Sent from Squeak Inbox Talk ["fix-directedSuperSend-frameSize.1.cs"]

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
16
Older →

Jump to page: