Squeak-dev December 2023

squeak-dev@lists.squeakfoundation.org

26 participants
124 discussions

The Trunk: Morphic-ct.2140.mcz
by commits＠source.squeak.org 01 Dec '23

01 Dec '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2140.mcz ==================== Summary ==================== Name: Morphic-ct.2140 Author: ct Time: 13 November 2023, 8:01:39.216583 pm UUID: 4cbb521d-2842-aa44-8dd3-b174ff5bb437 Ancestors: Morphic-ct.2139 Proposal: Makes characters of strings explorable in object explorers. This seems an artificial limitation and I have used and appreciated this feature in the past for various string debugging tasks over the last few months. I don't see any reason for this limitation. Is it about performance? If yes, the same problem exists for other types of collections as well, and we should address that separately. In my own experience, this wasn't an issue, though. =============== Diff against Morphic-ct.2139 =============== Item was removed: - ----- Method: String>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- - hasContentsInExplorer - - ^false!

1 0

The Trunk: Morphic-ct.2144.mcz
by commits＠source.squeak.org 01 Dec '23

01 Dec '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2144.mcz ==================== Summary ==================== Name: Morphic-ct.2144 Author: ct Time: 1 December 2023, 8:43:36.740752 pm UUID: b04a7aac-3188-d241-9929-43a5d49a2ce5 Ancestors: Morphic-dtl.2142, Morphic-ct.2140 Revises explorerContents for Collections: * Merges Morphic-ct.2140: Makes characters of strings explorable in object explorers. * Moves up #hasContentsInExplorer to Collection (#isEmpty is always faster or equal to actual #explorerContents) and handles edge cases in non-enumerable CharacterSets. Thanks to Marcel and Jakob for the discussion! =============== Diff against Morphic-dtl.2142 =============== Item was added: + ----- Method: CharacterSetComplement>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + "#notEmpty is not implemented by ourselves!! Do not break the explorer but display a clear error." + + ^ true! Item was added: + ----- Method: Collection>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + + ^self notEmpty! Item was removed: - ----- Method: Dictionary>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- - hasContentsInExplorer - - ^self isEmpty not! Item was added: + ----- Method: LazyCharacterSet>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + "#notEmpty is not implemented by ourselves!! Do not break the explorer but display a clear error." + + ^ true! Item was removed: - ----- Method: OrderedCollection>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- - hasContentsInExplorer - - ^self isEmpty not! Item was removed: - ----- Method: Set>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- - hasContentsInExplorer - - ^self notEmpty! Item was removed: - ----- Method: String>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- - hasContentsInExplorer - - ^false!

1 0

Squeak 6.0: Tests-mt.495.mcz
by commits＠source.squeak.org 01 Dec '23

01 Dec '23

Marcel Taeumel uploaded a new version of Tests to project Squeak 6.0: http://source.squeak.org/squeak60/Tests-mt.495.mcz ==================== Summary ==================== Name: Tests-mt.495 Author: mt Time: 1 December 2023, 11:12:35.678953 am UUID: 5c7c1ce8-aae7-4131-a6a4-05f2e338c3e0 Ancestors: Tests-mt.494 Revise previous fix with the solution used in Trunk. =============== Diff against Tests-mt.494 =============== Item was removed: - ----- Method: SoundTest>>fileName (in category 'support') ----- - fileName - - ^ 'tempPluck.wav'! Item was removed: - ----- Method: SoundTest>>setUp (in category 'running') ----- - setUp - - super setUp. - self deny: [FileDirectory default fileExists: self fileName].! Item was removed: - ----- Method: SoundTest>>tearDown (in category 'running') ----- - tearDown - - FileDirectory default - deleteFileNamed: self fileName - ifAbsent: [Transcript showln: 'File not found!! Did the test run correctly?']. - super tearDown.! Item was changed: ----- Method: SoundTest>>testStoreSamples (in category 'tests') ----- testStoreSamples | sound fileName arrayBytes fileBytes | sound := PluckedSound default. + fileName := 'tempPluck.wav'. + - fileName := self fileName. - "Write to file" fileBytes := [ sound storeWAVOnFileNamed: fileName. FileStream oldFileNamed: fileName do: [:stream | stream binary contents]] ensure: [ + FileDirectory default deleteFileNamed: fileName]. - FileDirectory deleteFilePath: fileName]. "Write to array" arrayBytes := ByteArray streamContents: [:stream | sound storeWAVSamplesOn: stream]. "Compare" self assert: fileBytes equals: arrayBytes.!

1 0

Squeak 6.0: Tests-mt.494.mcz
by commits＠source.squeak.org 01 Dec '23

01 Dec '23

Marcel Taeumel uploaded a new version of Tests to project Squeak 6.0: http://source.squeak.org/squeak60/Tests-mt.494.mcz ==================== Summary ==================== Name: Tests-mt.494 Author: mt Time: 1 December 2023, 11:08:24.361725 am UUID: f432c820-38e6-42f3-aa03-a9915d7c4962 Ancestors: Tests-mt.493 Make sound test more robust. It failed on a system where tempPluck.wav did exist already from an older test run but since we got a padding issue fixed, that old file was not correct anymore. Tests must clean up all their temp resources. =============== Diff against Tests-mt.493 =============== Item was added: + ----- Method: SoundTest>>fileName (in category 'support') ----- + fileName + + ^ 'tempPluck.wav'! Item was added: + ----- Method: SoundTest>>setUp (in category 'running') ----- + setUp + + super setUp. + self deny: [FileDirectory default fileExists: self fileName].! Item was added: + ----- Method: SoundTest>>tearDown (in category 'running') ----- + tearDown + + FileDirectory default + deleteFileNamed: self fileName + ifAbsent: [Transcript showln: 'File not found!! Did the test run correctly?']. + super tearDown.! Item was changed: ----- Method: SoundTest>>testStoreSamples (in category 'tests') ----- testStoreSamples | sound fileName arrayBytes fileBytes | sound := PluckedSound default. + fileName := self fileName. + - fileName := 'tempPluck.wav'. - "Write to file" fileBytes := [ sound storeWAVOnFileNamed: fileName. FileStream oldFileNamed: fileName do: [:stream | stream binary contents]] ensure: [ FileDirectory deleteFilePath: fileName]. "Write to array" arrayBytes := ByteArray streamContents: [:stream | sound storeWAVSamplesOn: stream]. "Compare" self assert: fileBytes equals: arrayBytes.!

1 0