Chris Cunningham uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cbc.296.mcz
==================== Summary ====================
Name: CollectionsTests-cbc.296 Author: cbc Time: 28 October 2018, 5:12:30.875512 pm UUID: 12a1d6bf-85c7-8d40-aa1c-022556c1cb18 Ancestors: CollectionsTests-topa.295
Test for #hash and #= bugs. In anticipation of fixing these.
=============== Diff against CollectionsTests-topa.295 ===============
Item was added: + ----- Method: IntervalTest>>testHashBug3380 (in category 'tests') ----- + testHashBug3380 + "Array and Interval equate, but their hashes didn't. Test that this is fixed. + It is about mantis bug http://bugs.squeak.org/view.php?id=6455" + | interval array | + interval := (1 to: 3). + array:= #(1 2 3). + self assert: interval equals: array. + self assert: interval hash equals: array hash.!
Item was added: + ----- Method: IntervalTest>>testHashEqualIfIntervalEqual (in category 'tests') ----- + testHashEqualIfIntervalEqual + | interval1 interval2 | + interval1 := 0 to: 1. + interval2 := 0 to: 5/3. "Taken from an actual issue in an image" + self assert: interval1 equals: interval2. + self assert: interval1 hash equals: interval2 hash.!
I seem to have failed. I was attempting to save a different version with just the second method - but somehow the earlier version was saved instead (definitely user failure, not tool failure). Would an admin like to delete this right now, or would you prefer I update to the corrected version (removing #testHashBug3380)?
On Thu, Nov 15, 2018 at 9:48 PM commits@source.squeak.org wrote:
Chris Cunningham uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cbc.296.mcz
==================== Summary ====================
Name: CollectionsTests-cbc.296 Author: cbc Time: 28 October 2018, 5:12:30.875512 pm UUID: 12a1d6bf-85c7-8d40-aa1c-022556c1cb18 Ancestors: CollectionsTests-topa.295
Test for #hash and #= bugs. In anticipation of fixing these.
=============== Diff against CollectionsTests-topa.295 ===============
Item was added:
- ----- Method: IntervalTest>>testHashBug3380 (in category 'tests') -----
- testHashBug3380
"Array and Interval equate, but their hashes didn't. Test that
this is fixed.
It is about mantis bug http://bugs.squeak.org/view.php?id=6455"
| interval array |
interval := (1 to: 3).
array:= #(1 2 3).
self assert: interval equals: array.
self assert: interval hash equals: array hash.!
Item was added:
- ----- Method: IntervalTest>>testHashEqualIfIntervalEqual (in category
'tests') -----
- testHashEqualIfIntervalEqual
| interval1 interval2 |
interval1 := 0 to: 1.
interval2 := 0 to: 5/3. "Taken from an actual issue in an image"
self assert: interval1 equals: interval2.
self assert: interval1 hash equals: interval2 hash.!
squeak-dev@lists.squeakfoundation.org