A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-lrnp.1144.mcz
==================== Summary ====================
Name: Tools-lrnp.1144 Author: lrnp Time: 28 March 2022, 2:14:18.999919 pm UUID: 93cebbab-cdc7-4e8d-97c7-f8e7a099c4da Ancestors: Tools-mt.1143
remove unneeded method in PackagePaneBrowser
Browser>>selectedSystemCategory is defined to return nil when nothing is selected, so remove the test in PackagePaneBrowser's version. Removing the test lets us remove the other method entirely.
PackagePaneBrowser>>hasSystemCategorySelected was only needed to avoid infinite recursion.
=============== Diff against Tools-mt.1143 ===============
Item was removed: - ----- Method: PackagePaneBrowser>>hasSystemCategorySelected (in category 'system category list') ----- - hasSystemCategorySelected - ^ super selectedSystemCategory notNil.!
Item was changed: ----- Method: PackagePaneBrowser>>selectedSystemCategory (in category 'system category list') ----- selectedSystemCategory "Answer the name of the selected system category or nil."
- self hasSystemCategorySelected - ifFalse: [^nil]. packageListIndex = 0 ifTrue: [^ super selectedSystemCategory ]. ^ self package , '-' , super selectedSystemCategory!
Hi Lauren --
-1
Now we get "Chronology-nil" as #selectedSystemCategory when one selects the "Chronology" package but no category. The old answer was "nil" instead of "Chronology-nil".
Best, Marcel Am 28.03.2022 22:14:30 schrieb commits@source.squeak.org commits@source.squeak.org: A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-lrnp.1144.mcz
==================== Summary ====================
Name: Tools-lrnp.1144 Author: lrnp Time: 28 March 2022, 2:14:18.999919 pm UUID: 93cebbab-cdc7-4e8d-97c7-f8e7a099c4da Ancestors: Tools-mt.1143
remove unneeded method in PackagePaneBrowser
Browser>>selectedSystemCategory is defined to return nil when nothing is selected, so remove the test in PackagePaneBrowser's version. Removing the test lets us remove the other method entirely.
PackagePaneBrowser>>hasSystemCategorySelected was only needed to avoid infinite recursion.
=============== Diff against Tools-mt.1143 ===============
Item was removed: - ----- Method: PackagePaneBrowser>>hasSystemCategorySelected (in category 'system category list') ----- - hasSystemCategorySelected - ^ super selectedSystemCategory notNil.!
Item was changed: ----- Method: PackagePaneBrowser>>selectedSystemCategory (in category 'system category list') ----- selectedSystemCategory "Answer the name of the selected system category or nil."
- self hasSystemCategorySelected - ifFalse: [^nil]. packageListIndex = 0 ifTrue: [^ super selectedSystemCategory ]. ^ self package , '-' , super selectedSystemCategory!
squeak-dev@lists.squeakfoundation.org