Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts. - With Tim's permission, removed LargePositiveInteger>>#asByteArray.
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup') ----- startUp: resuming
+ resuming ifTrue: + [ Smalltalk platformName ~= Smalltalk previousPlatformName + ifTrue: + [Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + self installVirtualKeyTable] ]. - resuming ifTrue: [ - Smalltalk platformName = 'Mac OS' - ifTrue: [ - self mapAltKeysToOptionKeys: false. - self mapControlKeysToCommandKeys: false] - ifFalse: [ - self mapAltKeysToOptionKeys: true. - self mapControlKeysToCommandKeys: true]. - self installVirtualKeyTable ].
+ self default startUp! - self default startUp.!
Item was removed: - ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') ----- - asByteArray - - ^self as: ByteArray!
Hi Chris --
It is still good practice to preserve the indentation style if you just add a single extra check to existing code. Now we have a mixed style in this method. :-)
Best, Marcel
Am 26.03.2024 01:39:19 schrieb commits@source.squeak.org commits@source.squeak.org:
Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts. - With Tim's permission, removed LargePositiveInteger>>#asByteArray.
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup') ----- startUp: resuming
+ resuming ifTrue: + [ Smalltalk platformName ~= Smalltalk previousPlatformName + ifTrue: + [Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + self installVirtualKeyTable] ]. - resuming ifTrue: [ - Smalltalk platformName = 'Mac OS' - ifTrue: [ - self mapAltKeysToOptionKeys: false. - self mapControlKeysToCommandKeys: false] - ifFalse: [ - self mapAltKeysToOptionKeys: true. - self mapControlKeysToCommandKeys: true]. - self installVirtualKeyTable ].
+ self default startUp! - self default startUp.!
Item was removed: - ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') ----- - asByteArray - - ^self as: ByteArray!
On 2024-03-26T09:17:42+00:00, marcel.taeumel@hpi.de wrote:
Hi Chris --
It is still good practice to preserve the indentation style if you just add a single extra check to existing code. Now we have a mixed style in this method. :-)
+1. :-)
Best, Marcel
Am 26.03.2024 01:39:19 schrieb commits(a)source.squeak.org <commits(a)source.squeak.org>:
Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts.
- With Tim's permission, removed LargePositiveInteger>>#asByteArray.
Should we preserve this at least in a deprecated package?
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup') ----- startUp: resuming
- resuming ifTrue:
- [ Smalltalk platformName ~= Smalltalk previousPlatformName
- ifTrue:
- [Smalltalk platformName = 'Mac OS'
- ifTrue: [
- self mapAltKeysToOptionKeys: false.
- self mapControlKeysToCommandKeys: false]
- ifFalse: [
- self mapAltKeysToOptionKeys: true.
- self mapControlKeysToCommandKeys: true].
- self installVirtualKeyTable] ].
- resuming ifTrue: [
- Smalltalk platformName = 'Mac OS'
- ifTrue: [
- self mapAltKeysToOptionKeys: false.
- self mapControlKeysToCommandKeys: false]
- ifFalse: [
- self mapAltKeysToOptionKeys: true.
- self mapControlKeysToCommandKeys: true].
- self installVirtualKeyTable ].
- self default startUp!
- self default startUp.!
Item was removed:
- ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') -----
- asByteArray
- ^self as: ByteArray!
Best, Christoph
--- Sent from Squeak Inbox Talk
On 2024-05-04, at 9:55 AM, christoph.thiede@student.hpi.uni-potsdam.de wrote:
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts.
- With Tim's permission, removed LargePositiveInteger>>#asByteArray.
Should we preserve this at least in a deprecated package?
I'd say no; it was a mistake I made that should be buried deep to protect my Mighty Reputation
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: BIK: Buggered if I Know
Yes, you're right. That's strange because I do agree with that. Sorry about that. Since I took it to two levels, I had to know your style with closing brackets (same line, or separate lines?), and I may have gotten side-tracked before getting that figured out, came back and ended up leaving the method formatted poorly. My bad.
On Sat, May 4, 2024 at 11:56 AM christoph.thiede@student.hpi.uni-potsdam.de wrote:
On 2024-03-26T09:17:42+00:00, marcel.taeumel@hpi.de wrote:
Hi Chris --
It is still good practice to preserve the indentation style if you just
add a single extra check to existing code. Now we have a mixed style in this method. :-)
+1. :-)
Best, Marcel
Am 26.03.2024 01:39:19 schrieb commits(a)source.squeak.org <commits(a)
source.squeak.org>:
Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image
restarts.
- With Tim's permission, removed LargePositiveInteger>>#asByteArray.
Should we preserve this at least in a deprecated package?
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup')
startUp: resuming
- resuming ifTrue:
- [ Smalltalk platformName ~= Smalltalk previousPlatformName
- ifTrue:
- [Smalltalk platformName = 'Mac OS'
- ifTrue: [
- self mapAltKeysToOptionKeys: false.
- self mapControlKeysToCommandKeys: false]
- ifFalse: [
- self mapAltKeysToOptionKeys: true.
- self mapControlKeysToCommandKeys: true].
- self installVirtualKeyTable] ].
- resuming ifTrue: [
- Smalltalk platformName = 'Mac OS'
- ifTrue: [
- self mapAltKeysToOptionKeys: false.
- self mapControlKeysToCommandKeys: false]
- ifFalse: [
- self mapAltKeysToOptionKeys: true.
- self mapControlKeysToCommandKeys: true].
- self installVirtualKeyTable ].
- self default startUp!
- self default startUp.!
Item was removed:
- ----- Method: LargePositiveInteger>>asByteArray (in category
'converting') -----
- asByteArray
- ^self as: ByteArray!
Best, Christoph
Sent from Squeak Inbox Talk
squeak-dev@lists.squeakfoundation.org
-
Chris Muller -
christoph.thiede＠student.hpi.uni-potsdam.de -
commits＠source.squeak.org -
Taeumel, Marcel -
Tim Rowledge