Hi Ned, just looked this over, it looks good except for one thing - I wonder if the #perform:orSendTo: mechanism is the best place for putting the code for switching filters on and off, especially since this is implemented in a few methods already.
Is there an MVC specific reason not to use #toggleFilterState:?
Daniel Vainsencher
Ned Konz ned@bike-nomad.com wrote:
--Boundary_(ID_YFIQDZtVuxAkp5rt3XSHKg) Content-type: TEXT/PLAIN Content-transfer-encoding: 7BIT
from preamble:
"Change Set: SMLoaderMVC-nk Date: 26 October 2002 Author: Ned Konz
This makes the SMLoader work with MVC as well as Morphic. "
SMLoader allSubInstancesDo: [ :ea | (ea isKindOf: SystemWindow) ifTrue: [ ea delete ]].!
--Boundary_(ID_YFIQDZtVuxAkp5rt3XSHKg) Content-type: application/octet-stream; NAME=SMLoaderMVC-nk.cs.gz Content-transfer-encoding: base64 Content-disposition: attachment; filename=SMLoaderMVC-nk.cs.gz
H4sIAAAAAAAAANVY33PbNhJ+Zmb4P6ztB9k3qWrZsXPhzc1c6pxncrGbTOVLptNRMhAJSahI gAVBq+rkj79vAVKiZMVxr+5DXyQCWCz217dYbO/SmoKGv9RSzE/7J2QmNBjQf+p8SSfHxyf0 Uy6crBzVZYaPhA6evTg7GZHRdHJOb1NnxtIGSuFokDx7kQxeUFn09uL9i5nQU0lD6ZIoGl5f GZFJe/3+4hs9j18xsyiKtpjEL2s3M5ZXvpcZvTH6tzi+mamKCjGXFbkZ+DWcaGHsnBbKzQhM Y1HRQuY54f/a2HKm0n68H8crapHnw3r8WldO6FRWr0xCP1EiBX2mQ/yq6o3S2dtJQsNl5WTx ASOzOCI1ubG1ZFoQZTKXTtJo1N+L42uDIVX1OM1FVcEy7VFxpJpT3gurxDiX34tCgqJXeTNf i5JKkc7FVFZXCrbtDl7rTP5KOFrnYPZKWQnz2CVNVO6gRS+O/HHbnDFfGpO/UqlTRmOxnU1h 6CkYYDS8/iYICOfEeyvDFBImz6pLmJ16OUSoegTxixJDPafB8bcn5996Dw9Ok5O/Y7PIsksv TnVjrqWuExL8R3H0uZFzuCzGJqeZzEv6HEeVzCftSinTKo6ijO2fhLmX1ool/IDpaGP/J+oS VDI1OuszlWe8uepmyobFYQFfO5HP4dQmFHg6WrnSS+unogi6/JdDW+kpXFjNzCKoNnSWpxoq J+wUYUysSDOFT+8a7HJmOs1lu48ju2Vup3UhtWPHJnQYBOWITTbsdNQP9MGKY0hvjL6Rvzr4 5EogJhCPiTfmqFHkUuQVa3LYsSwpneZ1xo7fYN7Isqk9QW/4NzOkjaMePd2w5URZhKXwsQS5 e1ZW0l2uqRrOwFr4Gq3OaAXrHHIf46+wHY326MuxOq0VjWuVZ3DUfSF7ipAdA2JTa2qdXZjc AKIfveUyORF17r7bXP3Dh54EnHg65KaLgEEVEM4oYZgxMA79R/JPepfX0ykDmineK7kgLZF9 YFc2VBN2uQ+jg3TFDiK9C7kjbgNSwuJa5RinPv0Ot2YLj9fwPZdIddbMpZ9AEH7kEx5D+xcd 7RsJ3wktWfXSFaw5/3X15nBnvX0kdXQG9rDCWhvtAKXKz4k0laVr9YgiK0UWNPWB1U6vlO1H +wdNll2R0X6QIjfpnHXH95+kenD7k7XfnzSO//RFvz/pWIEavzcKcMpvGHadfnD3FtmOgLsk iWcSzLRaDSm9Exwb+97IZTJBzZD0sfdxAmaQnA1WVgsJ+/dCxm/7C2MGJjjZMsHDcROU/2sj 5zQ5PYcBUsjjJKAT6i9W3JnSA6ORYgWUtrJZTTQE/huWavd9ItzJOhM2C5VdizIquIAL5uqv ycfGQoMPKuNbeoCF/VyMUeiBBRVKD9VvkhyKUQ0BrOR6ebzEZ55Ly2bZEvJTQPCuhNC/Qw3L L7zauBqP6V90THAgPJfQGQ+fHx915MTdinqWP5Nt0/TXZd+XBNnE144N/7csd0525gc1nTku re/K2fXZbltx/G8Sflm0wTGP8fsVQwVHy9zstF27EcWJLw0ZZixFdclpjw4OtzPx7vRCR5u8 rjiMfBlOLUVTjjOG2jB/DCCdrYEUUskaTDAcY4P/Pm28dBgR/bCwiQuegQk9Jxi846JdmXoT PsdcfE4szMSu6p95Z6XGamkZW955/fOjB5zSBc59Z2yc0Jz4u05gR3/tgP75lhL4bY9obp+D wtSV/DcSr/XXjA7Xr5Y3VuhK+WSLBYdXEHbt2nslxa18+N4/GKxHazb3xymIHqFKenaMEDWl 1G1kftz9aFu/voPDdkT1ETGf1/qDsXn2D1qa2nrSUdx9j9D6HuF35vpu6LJtb50ObpHxVVEX nPUTOvXpBTp0gR1SS0VZp6GAH750reFbgUYd8s40i92PsfoYkOeqs5R2YmzhkeufpmTsENFz A8kMOif2xr9iubjcH7YkC/RLfq4RFunMINSISzsSVPiX6BJfCEXbp9cwktCEh2CJN/hTbsRo Yk7NoaQc94SKpc8aTI535VPi4OUlZ7oSPKUSjOoCsbr0LR1mJDPlPPi8BAv4d+bXvCQspdK3 KLuy/j7XnSEcGnEq1rBV+ohL2nXceLo7lhkFojY6uOQJj9G/9dBpcumsw4+2mDXvWX7aHq4s nZpyGRB3Rq4jDVWInPWLlkbUicn2Yf3gQ3+QhbmVu899/vBzqxoGoQeGS/sI70So70Btxin8 s0Ro1dqvqYmS2X217vMG/hyKFx58vr7iKYTccNUmCwd6l+97OzAFRvyC8mNf8a8TyRaUHk/Q t8jLYiXXw8RmQAiaqlusFqLsB7nXejDP9Z6mFbGl3Oa5f56qaJM8g6qhrvJNEG7UYQ8uC9w3 qIJf6mrBbVT6sElDZvwzwgdYRQM4kzgLQY1EwBifSCvRBkUbNvq4vc0LFaKzeeZq3FDc1M18 L663bc4ejS0Xkp4FbracBz+i5Wu49Eclkzcrh/4fuvulok5nV0wqgSruoV3LqsKlhhNeAjLA hpecO38VtJvU6CFnuCetGtd4A7LnuMjH7URlPc5VipwlboXK+aZt/EeVmbgFFO/3vFtWXrEe sMN1qxAVSFvKAGfCJWVeV8nePTt89u8UJ/fRhnusiY976LiYCJ2ueP+dQcc3tQqPwvhtE8jX K9ytePjbCqr9D75xHL4wGAAA
--Boundary_(ID_YFIQDZtVuxAkp5rt3XSHKg)--
On Wednesday 30 October 2002 11:50 pm, danielv@netvision.net.il wrote:
Hi Ned, just looked this over, it looks good except for one thing - I wonder if the #perform:orSendTo: mechanism is the best place for putting the code for switching filters on and off, especially since this is implemented in a few methods already.
Is there an MVC specific reason not to use #toggleFilterState:?
Yes, you can't pass arguments to a menu item in MVC, AFAICT (you're limited to a single selector). So I ended up encoding the set/reset along with the specific filter, and unpacking them in perform:orSendTo:.
squeak-dev@lists.squeakfoundation.org