On 2013-03-24, at 05:33, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-tpr.205.mcz
==================== Summary ====================
Name: Graphics-tpr.205 Author: tpr Time: 23 March 2013, 10:32:54.898 pm UUID: a16cf25b-36b7-4a5e-b3e9-3786b5f7c92d Ancestors: Graphics-tpr.204
A somewhat involved pile of changes that I'm not 10% sure my use of MC has correctly caught; revert this if you find bugs! For example, MC claims that AbstractFont is very different but visual inspection says not.
Guess you need look more closely, and learn to trust MC that it is, in fact, going to do what it claims to ;)
Item was removed:
- ----- Method: AbstractFont>>displayStrikeoutOn:from:to: (in category 'displaying') -----
- displayStrikeoutOn: aDisplayContext from: baselineStartPoint to: baselineEndPoint
- "display the strikeout if appropriate for the receiver"!
It's not okay to push stuff to trunk if you notice that it has more changes than you intend it to have.
In this case, essential text display routines get deleted from other users' systems when updating. Not cool.
I guess what happened is that the Freetype package still takes over these methods, without declaring them as overrides. This removes them from the Graphics package.
I moved your version to the inbox for now to spare others of their images freezing on update.
- Bert -
On 25-03-2013, at 6:42 AM, Bert Freudenberg bert@freudenbergs.de wrote:
I moved your version to the inbox for now to spare others of their images freezing on update.
Better yet, let's delete it so I can start again. I see that whatever you did got it out of the trunk repository, but what was it you did? I'm not currently seeing anything that looks like a delate in either the repository browser nor the MC browser.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Useful random insult:- He's not a complete idiot -- some parts are missing.
On 2013-03-25, at 17:25, tim Rowledge tim@rowledge.org wrote:
On 25-03-2013, at 6:42 AM, Bert Freudenberg bert@freudenbergs.de wrote:
I moved your version to the inbox for now to spare others of their images freezing on update.
Better yet, let's delete it so I can start again. I see that whatever you did got it out of the trunk repository, but what was it you did? I'm not currently seeing anything that looks like a delate in either the repository browser nor the MC browser.
For deleting/moving you need to log into the web interface.
Typically we just move stuff to the "Treated Inbox" repo, rather than deleting it.
- Bert -
Starting from a fresh image from the Jenkins server that claimed to be completely clean and up to date, making the changes to get rid of the obsolete 'BitBlt current' idiom for everything visible, I have now committed about half-a-dozen packages that seem to be correct.
I also committed a VMMaker change to a) move BitBltSImulation under SmartSyntaxPlugin b) move the pixel-peeker primitive into BitBltSimulation c) update the comment a bit to include some combination rules added about ten years ago
A VM built from this passes the BitBltTests in TestRunner and appears to run everything normally.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: SD: Self Destruct
On 26 March 2013 00:27, tim Rowledge tim@rowledge.org wrote:
Starting from a fresh image from the Jenkins server that claimed to be completely clean and up to date
That's going to be the best we have, for the moment. Mainly because * we never have a green build, * Squeak has very limited command line support ** you need to feed it a chunk-formatted startup script, or a script with no !s in it ** exceptions mean debuggers pop up, rather than dumping stack traces to stdout
But otherwise, if the resulting image is _not_ completely clean & up to date, it's my fault, and please yell at me. Preferably in the form of a nice bug report :)
frank
, making the changes to get rid of the obsolete 'BitBlt current' idiom for everything visible, I have now committed about half-a-dozen packages that seem to be correct.
I also committed a VMMaker change to a) move BitBltSImulation under SmartSyntaxPlugin b) move the pixel-peeker primitive into BitBltSimulation c) update the comment a bit to include some combination rules added about ten years ago
A VM built from this passes the BitBltTests in TestRunner and appears to run everything normally.
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: SD: Self Destruct
On 2013-03-26, at 07:49, Frank Shearar frank.shearar@gmail.com wrote:
** exceptions mean debuggers pop up, rather than dumping stack traces to stdout
Guess the build server should temporarily use a non-interactive ToolSet?
The Etoys image has a similar thing - see attached fileout (curious, the method dates seem to imply this should be in Trunk, too).
- Bert -
On 26 March 2013 15:26, Bert Freudenberg bert@freudenbergs.de wrote:
On 2013-03-26, at 07:49, Frank Shearar frank.shearar@gmail.com wrote:
** exceptions mean debuggers pop up, rather than dumping stack traces to stdout
Guess the build server should temporarily use a non-interactive ToolSet?
Yes, exactly.
The Etoys image has a similar thing - see attached fileout (curious, the method dates seem to imply this should be in Trunk, too).
Yes, that's a good idea (using UnhandledError's defaultAction to either pop up a Debugger or dump a stack trace. Trunk defers the handling to ToolSet, so if we had a HeadlessToolSet we could swap that in.
I'll add that to the list :)
frank
- Bert -
On Mon, Mar 25, 2013 at 11:49 PM, Frank Shearar frank.shearar@gmail.comwrote:
On 26 March 2013 00:27, tim Rowledge tim@rowledge.org wrote:
Starting from a fresh image from the Jenkins server that claimed to be
completely clean and up to date
That's going to be the best we have, for the moment. Mainly because
- we never have a green build,
- Squeak has very limited command line support
we should steal Camillo's command-line code for Pharo. Very nice. curses, coloured text, a repl loop.
** you need to feed it a chunk-formatted startup script, or a script with no !s in it ** exceptions mean debuggers pop up, rather than dumping stack traces to stdout
But otherwise, if the resulting image is _not_ completely clean & up to date, it's my fault, and please yell at me. Preferably in the form of a nice bug report :)
frank
, making the changes to get rid of the obsolete 'BitBlt current' idiom
for everything visible, I have now committed about half-a-dozen packages that seem to be correct.
I also committed a VMMaker change to a) move BitBltSImulation under SmartSyntaxPlugin b) move the pixel-peeker primitive into BitBltSimulation c) update the comment a bit to include some combination rules added
about ten years ago
A VM built from this passes the BitBltTests in TestRunner and appears to
run everything normally.
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: SD: Self Destruct
On 26 March 2013 16:57, Eliot Miranda eliot.miranda@gmail.com wrote:
On Mon, Mar 25, 2013 at 11:49 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 March 2013 00:27, tim Rowledge tim@rowledge.org wrote:
Starting from a fresh image from the Jenkins server that claimed to be completely clean and up to date
That's going to be the best we have, for the moment. Mainly because
- we never have a green build,
- Squeak has very limited command line support
we should steal Camillo's command-line code for Pharo. Very nice. curses, coloured text, a repl loop.
That is the plan! I just need to get around to actually doing it!
Maybe we can even contribute back, by making a CursesToolBuilder. (And ideally beating Pharo to extending Spec to support curses.)
frank
** you need to feed it a chunk-formatted startup script, or a script with no !s in it ** exceptions mean debuggers pop up, rather than dumping stack traces to stdout
But otherwise, if the resulting image is _not_ completely clean & up to date, it's my fault, and please yell at me. Preferably in the form of a nice bug report :)
frank
, making the changes to get rid of the obsolete 'BitBlt current' idiom for everything visible, I have now committed about half-a-dozen packages that seem to be correct.
I also committed a VMMaker change to a) move BitBltSImulation under SmartSyntaxPlugin b) move the pixel-peeker primitive into BitBltSimulation c) update the comment a bit to include some combination rules added about ten years ago
A VM built from this passes the BitBltTests in TestRunner and appears to run everything normally.
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: SD: Self Destruct
-- best, Eliot
squeak-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
Eliot Miranda -
Frank Shearar -
tim Rowledge