A new version of PreferenceBrowser was added to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.150.mcz
==================== Summary ====================
Name: PreferenceBrowser-ct.150 Author: ct Time: 20 May 2022, 6:48:44.518499 pm UUID: 3d8cf55a-3022-9643-8df9-fd41f5577848 Ancestors: PreferenceBrowser-mt.149
Proposal: Also search the category list of preferences via the search field. I was so confused that some 'halo' preferences did not appear in the search results.
=============== Diff against PreferenceBrowser-mt.149 ===============
Item was changed: ----- Method: PreferenceBrowser>>searchPreferencesFor: (in category 'preferences search') ----- searchPreferencesFor: pattern | result | result := pattern asString asLowercase withBlanksTrimmed. result ifEmpty: [^self]. searchResults := self allPreferences select: [:aPreference | ((aPreference name includesSubstring: result caseSensitive: false) or: [aPreference helpString includesSubstring: result caseSensitive: false]) + or: [aPreference codeString includesSubstring: result caseSensitive: false] + or: [aPreference categoryList anySatisfy: [:category | + category includesSubstring: result caseSensitive: false]] ]. - or: [aPreference codeString includesSubstring: result caseSensitive: false] ]. self updateSearchResultsLabel. self selectSearchResultsCategory. self lastExecutedSearch: pattern. !
I would only do such a thing if we are able to indicate the matches in the result list. Maybe we should even list the categories there in the expanded preference view?
Best, Marcel Am 20.05.2022 18:48:54 schrieb commits@source.squeak.org commits@source.squeak.org: A new version of PreferenceBrowser was added to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.150.mcz
==================== Summary ====================
Name: PreferenceBrowser-ct.150 Author: ct Time: 20 May 2022, 6:48:44.518499 pm UUID: 3d8cf55a-3022-9643-8df9-fd41f5577848 Ancestors: PreferenceBrowser-mt.149
Proposal: Also search the category list of preferences via the search field. I was so confused that some 'halo' preferences did not appear in the search results.
=============== Diff against PreferenceBrowser-mt.149 ===============
Item was changed: ----- Method: PreferenceBrowser>>searchPreferencesFor: (in category 'preferences search') ----- searchPreferencesFor: pattern | result | result := pattern asString asLowercase withBlanksTrimmed. result ifEmpty: [^self]. searchResults := self allPreferences select: [:aPreference | ((aPreference name includesSubstring: result caseSensitive: false) or: [aPreference helpString includesSubstring: result caseSensitive: false]) + or: [aPreference codeString includesSubstring: result caseSensitive: false] + or: [aPreference categoryList anySatisfy: [:category | + category includesSubstring: result caseSensitive: false]] ]. - or: [aPreference codeString includesSubstring: result caseSensitive: false] ]. self updateSearchResultsLabel. self selectSearchResultsCategory. self lastExecutedSearch: pattern. !
squeak-dev@lists.squeakfoundation.org