On Mon, Oct 22, 2012 at 12:42 AM, commits@source.squeak.org wrote:
Tweak #numArgs, so that Strings respect the #allowUnderscoreSelectors preference, but Symbols don't.
I think this batch of changes means we can turn #allowUnderscoreSelectors on by default.
Looking through the senders of #numArgs, I noticed that many of them were messages to a selector. In those cases, the selector might contain underscores, even though the preference disallows them, so I made Symbol>>numArgs behave differently than String>>numArgs.
Unless somebody objects, I'll move these to the trunk soonish.
I'm a bit lost about which methods will get into the Trunk, since every package has two versions with different content. For example Collections-cwp.491 extracts String class >> #initializeTokenish from #initialize, while Collections-cwp.492 don't. Also both versions containting changes to Scanner class >> #prefAllowUnderscoreSelectors: send String class >> #initialize instead of #initializeTokenish.
Another thing is that the support for initial and final keywords is gone long ago, only #numArgs has traces of it, which should be removed.
Levente
On Mon, 22 Oct 2012, Colin Putney wrote:
On Mon, Oct 22, 2012 at 12:42 AM, commits@source.squeak.org wrote:
Tweak #numArgs, so that Strings respect the #allowUnderscoreSelectors preference, but Symbols don't.
I think this batch of changes means we can turn #allowUnderscoreSelectors on by default.
Looking through the senders of #numArgs, I noticed that many of them were messages to a selector. In those cases, the selector might contain underscores, even though the preference disallows them, so I made Symbol>>numArgs behave differently than String>>numArgs.
Unless somebody objects, I'll move these to the trunk soonish.
On Mon, Oct 22, 2012 at 8:56 AM, Levente Uzonyi leves@elte.hu wrote:
I'm a bit lost about which methods will get into the Trunk, since every package has two versions with different content. For example Collections-cwp.491 extracts String class >> #initializeTokenish from #initialize, while Collections-cwp.492 don't. Also both versions containting changes to Scanner class >> #prefAllowUnderscoreSelectors: send String class
#initialize instead of #initializeTokenish.
Yeah, sorry about that. I committed to the inbox, then realized that I was working from an outdated image. I've moved those first commits to inbox-treated. The versions that are still in the inbox are the ones that would be moved to the trunk.
Another thing is that the support for initial and final keywords is gone long ago, only #numArgs has traces of it, which should be removed.
Ok. I didn't really understand that stuff, so I left it alone. I'll do another version.
Colin
squeak-dev@lists.squeakfoundation.org