"Change Set: LinkHighlightClipFix-nk Date: 8 March 2004 Author: Ned Konz
Text links whose bounds extend past the visible bounds of their TextMorphs were not clipping their highlight boundaries when clicked.
This CS fixes that problem. "
code looks good and passes this test:
Get the halos of the TextMorphForEditView inside 'Welcome to...' window up. In the menu unmark 'text wrap to bounds'. Now click on the link 'http://minnow.cc ...' that gets "cut off" at the right border. With this fix only the visible part of the link will be highlighted.
This is already approved, but I have a side comment: If I try to follow Alexander's steps below in a fresh 5878 image (regardless of whether Ned's fix is loaded) on Mac OS X, I get a hopelessly locked up image. Well, more accurately, the Squeak VM memory usage starts ballooning and I can't seem to cmd-. out of it. (After pressing cmd-. for a while, a pre-debug window may come up, but memory keeps going up and the Squeak UI is still mostly unresponsive.) Probably an infinite loop in the window display code or similar.
- Doug
--------------------------------- Subject: [FIX] LinkHighlightClipFix-nk ( [er][sm][et] looks good and does what it says ) Author: Alexander@Lazarevic.de Date Posted: 22 April 2004 Archive ID: 22037 Comments: code looks good and passes this test:
Get the halos of the TextMorphForEditView inside 'Welcome to...' window up. In the menu unmark 'text wrap to bounds'. Now click on the link 'http://minnow.cc ...' that gets "cut off" at the right border. With this fix only the visible part of the link will be highlighted.
The procedure I described to test the fix still works for me. BUT if I shrink the window in addition and click on the link http://www.squeak.org, that is then only partially seen, memory usage goes straight through the roof as you described it.
The reason for the lockup lies in Utilities class>>awaitMouseUpIn:whileMouseDownDo:whileMouseDownInsideDo:ifSucceed: at the line
darkForm _ lightForm deepCopy reverse.
Because of wrong box calculations the form has dimensions (54@326 corner: 10000029@340). The wrong box calculation seems to be caused by a method in TextLine
rightMargin "This has to get fixed -- store during composition" ^ self right
This is as close as I can get to the root of the problem (in reasonable time :). Maybe someone who is more at home in this area could find an appropriate fix?
Alex
-----Ursprüngliche Nachricht----- Von: squeak-dev-bounces@lists.squeakfoundation.org [mailto:squeak-dev-bounces@lists.squeakfoundation.org] Im Auftrag von dway@mailcan.com Gesendet: Dienstag, 27. April 2004 06:39 An: squeak-dev@lists.squeakfoundation.org Betreff: [FIX] LinkHighlightClipFix-nk
This is already approved, but I have a side comment: If I try to follow Alexander's steps below in a fresh 5878 image (regardless of whether Ned's fix is loaded) on Mac OS X, I get a hopelessly locked up image. Well, more accurately, the Squeak VM memory usage starts ballooning and I can't seem to cmd-. out of it. (After pressing cmd-. for a while, a pre-debug window may come up, but memory keeps going up and the Squeak UI is still mostly unresponsive.) Probably an infinite loop in the window display code or similar.
- Doug
--------------------------------- Subject: [FIX] LinkHighlightClipFix-nk ( [er][sm][et] looks good and does what it says ) Author: Alexander@Lazarevic.de Date Posted: 22 April 2004 Archive ID: 22037 Comments: code looks good and passes this test:
Get the halos of the TextMorphForEditView inside 'Welcome to...' window up. In the menu unmark 'text wrap to bounds'. Now click on the link 'http://minnow.cc ...' that gets "cut off" at the right border. With this fix only the visible part of the link will be highlighted.
squeak-dev@lists.squeakfoundation.org
-
Alexander Lazarevic -
Alexander＠Lazarevic.de
-
dway＠mailcan.com -
ned＠squeakland.org