=============== Summary ===============
Change Set: mcAddAnythingToChangeSet Date: 18 May 2023 Author: Christoph Thiede
Makes 'add (all) to current change set' in Monticello code tools capable of class and script definitions.
=============== Diff ===============
ChangeSet>>noteRemovalOf: {class changes} · ct 5/18/2023 22:25 (changed) noteRemovalOf: class "The class is about to be removed from the system. Adjust the receiver to reflect that fact."
- class wantsChangeSetLogging ifFalse: [^ self]. + | c ccname | + class isString + ifTrue: [c := self environment classNamed: class. ccname := class , ' class'] + ifFalse: [c := class. ccname := class class name]. + (c notNil and: [c wantsChangeSetLogging not]) ifTrue: [^ self]. (self changeRecorderFor: class) - noteChangeType: #remove fromClass: class. - changeRecords removeKey: class class name ifAbsent: []. + noteChangeType: #remove fromClass: c. + changeRecords removeKey: ccname ifAbsent: [].
MCAddition>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet
MCClassDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 22:21 + addRemovalToChangeSet: aChangeSet + + aChangeSet noteRemovalOf: self className.
MCClassDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:45 + addToChangeSet: aChangeSet + + aChangeSet addClass: self actualClass.
MCDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:34 + addRemovalToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCMethodDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:44 + addRemovalToChangeSet: aChangeSet + + aChangeSet removeSelector: self selector class: self actualClass priorMethod: nil lastMethodInfo: nil.
MCMethodDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:42 + addToChangeSet: aChangeSet + + aChangeSet adoptSelector: self selector forClass: self actualClass.
MCModification>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet
MCOperationsBrowser>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:06 (changed) adoptMessageInCurrentChangeset
- selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - - items select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (selection ifNotNil: [{selection}] ifNil: [items]) + do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations.
MCOperationsBrowser>>methodListMenu: {menus} · ct 5/18/2023 22:15 (changed) methodListMenu: aMenu selection ifNil: [items ifNotEmpty: [ aMenu addList: #( ('add all to current change set' adoptMessageInCurrentChangeset))]] ifNotNil: [aMenu addList: #( ('install' installSelection) ('revert (x)' revertSelection) ('browse origin' browseSelectionOrigin) -)]. self unchangedMethods ifNotEmpty: [aMenu addList: #( ('revert unchanged methods...' revertUnchangedMethods) ('filter out unchanged methods...' filterOutUnchangedMethods) -)]. super methodListMenu: aMenu. + self selectedMessageName ifNil: + [aMenu addList: #( + ('add to current change set' adoptMessageInCurrentChangeset))]. ^ aMenu
MCPatchOperation>>addToChangeSet: {applying} · ct 5/18/2023 21:32 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCPatchOperation>>applyTo: {applying} · ct 5/18/2023 21:30 + applyTo: anObject + + ^ self subclassResponsibility
MCPostscriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:05 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('"{1}"{2}.' withCRs format: {self packageName. self script}).
MCPreambleDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:07 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePreambleExists; + preamble: aChangeSet preamble , ('\"{1}"{2}.' withCRs format: {self packageName. self script}).
MCRemoval>>addToChangeSet: {applying} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self definition addRemovalToChangeSet: aChangeSet
MCRemoval>>applyTo: {applying} · ab 5/24/2003 16:11 (changed and recategorized) applyTo: anObject anObject removeDefinition: definition
MCSaveVersionDialog>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:00 (changed) adoptMessageInCurrentChangeset
selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - (items copyWithoutAll: ignore) select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (items copyWithoutAll: ignore) do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations.
MCScriptDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:58 + addRemovalToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: ''
MCScriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:58 + addToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: self script
MCScriptDefinition>>addToChangeSet:script: {installing} · ct 5/18/2023 22:04 + addToChangeSet: aChangeSet script: aString + + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('<n><n>(PackageInfo named: <1p>) <2s>: <3p>.' expandMacrosWithArguments: {self packageName. self scriptSelector. aString}).
--- Sent from Squeak Inbox Talk ["mcAddAnythingToChangeSet.1.cs"]
Minor update. Makes sure to include the comment of class definitions.
On 2023-05-18T22:32:19+02:00, christoph.thiede@student.hpi.uni-potsdam.de wrote:
=============== Summary ===============
Change Set: mcAddAnythingToChangeSet Date: 18 May 2023 Author: Christoph Thiede
Makes 'add (all) to current change set' in Monticello code tools capable of class and script definitions.
=============== Diff ===============
ChangeSet>>noteRemovalOf: {class changes} · ct 5/18/2023 22:25 (changed) noteRemovalOf: class "The class is about to be removed from the system. Adjust the receiver to reflect that fact."
- class wantsChangeSetLogging ifFalse: [^ self].
- | c ccname |
- class isString
- ifTrue: [c := self environment classNamed: class. ccname := class , ' class']
- ifFalse: [c := class. ccname := class class name].
- (c notNil and: [c wantsChangeSetLogging not]) ifTrue: [^ self].
(self changeRecorderFor: class)
- noteChangeType: #remove fromClass: class.
- changeRecords removeKey: class class name ifAbsent: [].
- noteChangeType: #remove fromClass: c.
- changeRecords removeKey: ccname ifAbsent: [].
MCAddition>>addToChangeSet: {applying} · ct 5/18/2023 21:33
- addToChangeSet: aChangeSet
- ^ self definition addToChangeSet: aChangeSet
MCClassDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 22:21
- addRemovalToChangeSet: aChangeSet
- aChangeSet noteRemovalOf: self className.
MCClassDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:45
- addToChangeSet: aChangeSet
- aChangeSet addClass: self actualClass.
MCDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:34
- addRemovalToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:34
- addToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCMethodDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:44
- addRemovalToChangeSet: aChangeSet
- aChangeSet removeSelector: self selector class: self actualClass priorMethod: nil lastMethodInfo: nil.
MCMethodDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:42
- addToChangeSet: aChangeSet
- aChangeSet adoptSelector: self selector forClass: self actualClass.
MCModification>>addToChangeSet: {applying} · ct 5/18/2023 21:33
- addToChangeSet: aChangeSet
- ^ self definition addToChangeSet: aChangeSet
MCOperationsBrowser>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:06 (changed) adoptMessageInCurrentChangeset
- selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
- items select: [:each | each definition isMethodDefinition] thenDo: [:item |
- self forItem: item setClassAndSelectorIn: [:class :selector |
- ((item isAddition or: [item isModification]) and: [class includesSelector: selector])
- ifTrue: [ChangeSet current adoptSelector: selector forClass: class].
- item isRemoval
- ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]].
- (selection ifNotNil: [{selection}] ifNil: [items])
- do: [:item | item addToChangeSet: ChangeSet current].
self changed: #annotations.
MCOperationsBrowser>>methodListMenu: {menus} · ct 5/18/2023 22:15 (changed) methodListMenu: aMenu selection ifNil: [items ifNotEmpty: [ aMenu addList: #( ('add all to current change set' adoptMessageInCurrentChangeset))]] ifNotNil: [aMenu addList: #( ('install' installSelection) ('revert (x)' revertSelection) ('browse origin' browseSelectionOrigin) -)]. self unchangedMethods ifNotEmpty: [aMenu addList: #( ('revert unchanged methods...' revertUnchangedMethods) ('filter out unchanged methods...' filterOutUnchangedMethods) -)]. super methodListMenu: aMenu.
- self selectedMessageName ifNil:
- [aMenu addList: #(
- ('add to current change set' adoptMessageInCurrentChangeset))].
^ aMenu
MCPatchOperation>>addToChangeSet: {applying} · ct 5/18/2023 21:32
- addToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCPatchOperation>>applyTo: {applying} · ct 5/18/2023 21:30
- applyTo: anObject
- ^ self subclassResponsibility
MCPostscriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:05
- addToChangeSet: aChangeSet
- super addToChangeSet: aChangeSet.
- aChangeSet
- assurePostscriptExists;
- postscript: aChangeSet postscript , ('"{1}"{2}.' withCRs format: {self packageName. self script}).
MCPreambleDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:07
- addToChangeSet: aChangeSet
- super addToChangeSet: aChangeSet.
- aChangeSet
- assurePreambleExists;
- preamble: aChangeSet preamble , ('\"{1}"{2}.' withCRs format: {self packageName. self script}).
MCRemoval>>addToChangeSet: {applying} · ct 5/18/2023 21:34
- addToChangeSet: aChangeSet
- ^ self definition addRemovalToChangeSet: aChangeSet
MCRemoval>>applyTo: {applying} · ab 5/24/2003 16:11 (changed and recategorized) applyTo: anObject anObject removeDefinition: definition
MCSaveVersionDialog>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:00 (changed) adoptMessageInCurrentChangeset
selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
- (items copyWithoutAll: ignore) select: [:each | each definition isMethodDefinition] thenDo: [:item |
- self forItem: item setClassAndSelectorIn: [:class :selector |
- ((item isAddition or: [item isModification]) and: [class includesSelector: selector])
- ifTrue: [ChangeSet current adoptSelector: selector forClass: class].
- item isRemoval
- ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]].
- (items copyWithoutAll: ignore) do: [:item | item addToChangeSet: ChangeSet current].
self changed: #annotations.
MCScriptDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:58
- addRemovalToChangeSet: aChangeSet
- ^ self addToChangeSet: aChangeSet script: ''
MCScriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:58
- addToChangeSet: aChangeSet
- ^ self addToChangeSet: aChangeSet script: self script
MCScriptDefinition>>addToChangeSet:script: {installing} · ct 5/18/2023 22:04
- addToChangeSet: aChangeSet script: aString
- aChangeSet
- assurePostscriptExists;
- postscript: aChangeSet postscript , ('<n><n>(PackageInfo named: <1p>) <2s>: <3p>.' expandMacrosWithArguments: {self packageName. self scriptSelector. aString}).
Sent from Squeak Inbox Talk ["mcAddAnythingToChangeSet.1.cs"]
["mcAddAnythingToChangeSet.2.cs"]
Hi Christoph --
I wonder about the correct protocol (or message category). This seems to be a tool integration between Monticello and System-Changes. So, at least the new messages should have something with "changes" or "change set support" in their category name. We cannot use extensions here bc. "System" must not depend on "Monticello" being present.
In general, this is a handy integration because the MC patch browsers are very informative and help filling a new change set if one had forgotten to open one before starting a task. Especially for cross-package tasks.
Best, Marcel Am 18.05.2023 22:32:40 schrieb christoph.thiede@student.hpi.uni-potsdam.de christoph.thiede@student.hpi.uni-potsdam.de: =============== Summary ===============
Change Set: mcAddAnythingToChangeSet Date: 18 May 2023 Author: Christoph Thiede
Makes 'add (all) to current change set' in Monticello code tools capable of class and script definitions.
=============== Diff ===============
ChangeSet>>noteRemovalOf: {class changes} · ct 5/18/2023 22:25 (changed) noteRemovalOf: class "The class is about to be removed from the system. Adjust the receiver to reflect that fact."
- class wantsChangeSetLogging ifFalse: [^ self]. + | c ccname | + class isString + ifTrue: [c := self environment classNamed: class. ccname := class , ' class'] + ifFalse: [c := class. ccname := class class name]. + (c notNil and: [c wantsChangeSetLogging not]) ifTrue: [^ self]. (self changeRecorderFor: class) - noteChangeType: #remove fromClass: class. - changeRecords removeKey: class class name ifAbsent: []. + noteChangeType: #remove fromClass: c. + changeRecords removeKey: ccname ifAbsent: [].
MCAddition>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet
MCClassDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 22:21 + addRemovalToChangeSet: aChangeSet + + aChangeSet noteRemovalOf: self className.
MCClassDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:45 + addToChangeSet: aChangeSet + + aChangeSet addClass: self actualClass.
MCDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:34 + addRemovalToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCMethodDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:44 + addRemovalToChangeSet: aChangeSet + + aChangeSet removeSelector: self selector class: self actualClass priorMethod: nil lastMethodInfo: nil.
MCMethodDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:42 + addToChangeSet: aChangeSet + + aChangeSet adoptSelector: self selector forClass: self actualClass.
MCModification>>addToChangeSet: {applying} · ct 5/18/2023 21:33 + addToChangeSet: aChangeSet + + ^ self definition addToChangeSet: aChangeSet
MCOperationsBrowser>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:06 (changed) adoptMessageInCurrentChangeset
- selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - - items select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (selection ifNotNil: [{selection}] ifNil: [items]) + do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations.
MCOperationsBrowser>>methodListMenu: {menus} · ct 5/18/2023 22:15 (changed) methodListMenu: aMenu selection ifNil: [items ifNotEmpty: [ aMenu addList: #( ('add all to current change set' adoptMessageInCurrentChangeset))]] ifNotNil: [aMenu addList: #( ('install' installSelection) ('revert (x)' revertSelection) ('browse origin' browseSelectionOrigin) -)]. self unchangedMethods ifNotEmpty: [aMenu addList: #( ('revert unchanged methods...' revertUnchangedMethods) ('filter out unchanged methods...' filterOutUnchangedMethods) -)]. super methodListMenu: aMenu. + self selectedMessageName ifNil: + [aMenu addList: #( + ('add to current change set' adoptMessageInCurrentChangeset))]. ^ aMenu
MCPatchOperation>>addToChangeSet: {applying} · ct 5/18/2023 21:32 + addToChangeSet: aChangeSet + + ^ self subclassResponsibility
MCPatchOperation>>applyTo: {applying} · ct 5/18/2023 21:30 + applyTo: anObject + + ^ self subclassResponsibility
MCPostscriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:05 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('"{1}"{2}.' withCRs format: {self packageName. self script}).
MCPreambleDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:07 + addToChangeSet: aChangeSet + + super addToChangeSet: aChangeSet. + aChangeSet + assurePreambleExists; + preamble: aChangeSet preamble , ('\"{1}"{2}.' withCRs format: {self packageName. self script}).
MCRemoval>>addToChangeSet: {applying} · ct 5/18/2023 21:34 + addToChangeSet: aChangeSet + + ^ self definition addRemovalToChangeSet: aChangeSet
MCRemoval>>applyTo: {applying} · ab 5/24/2003 16:11 (changed and recategorized) applyTo: anObject anObject removeDefinition: definition
MCSaveVersionDialog>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:00 (changed) adoptMessageInCurrentChangeset
selection ifNotNil: [^ super adoptMessageInCurrentChangeset]. - (items copyWithoutAll: ignore) select: [:each | each definition isMethodDefinition] thenDo: [:item | - self forItem: item setClassAndSelectorIn: [:class :selector | - ((item isAddition or: [item isModification]) and: [class includesSelector: selector]) - ifTrue: [ChangeSet current adoptSelector: selector forClass: class]. - item isRemoval - ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]]. + (items copyWithoutAll: ignore) do: [:item | item addToChangeSet: ChangeSet current]. self changed: #annotations.
MCScriptDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:58 + addRemovalToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: ''
MCScriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:58 + addToChangeSet: aChangeSet + + ^ self addToChangeSet: aChangeSet script: self script
MCScriptDefinition>>addToChangeSet:script: {installing} · ct 5/18/2023 22:04 + addToChangeSet: aChangeSet script: aString + + aChangeSet + assurePostscriptExists; + postscript: aChangeSet postscript , ('<n><n>(PackageInfo named: <1p>) <2s>: <3p>.' expandMacrosWithArguments: {self packageName. self scriptSelector. aString}).
--- Sent from Squeak Inbox Talk [https://github.com/hpi-swa-lab/squeak-inbox-talk] ["mcAddAnythingToChangeSet.1.cs"]
Thank you for the feedback! Revised and merged via Monticello-ct.789/System-ct.1414.
In general, this is a handy integration because the MC patch browsers are very informative and help filling a new change set if one had forgotten to open one before starting a task. Especially for cross-package tasks.
Not only if you have forgotten ... I use to regularly work in a large monolithical change set and then walk through the different package changes to review my changes and organize them in coherent change sets. Always keeping in mind what change set I'm currently editing feels distracting. On the other hand, I might keep myself in the flow of dancing between a thousand screws for the price of cleaning up my mess afterward ... ^^
Best, Christoph
--- Sent from Squeak Inbox Talk
On 2023-05-22T15:49:47+02:00, marcel.taeumel@hpi.de wrote:
Hi Christoph --
I wonder about the correct protocol (or message category). This seems to be a tool integration between Monticello and System-Changes. So, at least the new messages should have something with "changes" or "change set support" in their category name. We cannot use extensions here bc. "System" must not depend on "Monticello" being present.
In general, this is a handy integration because the MC patch browsers are very informative and help filling a new change set if one had forgotten to open one before starting a task. Especially for cross-package tasks.
Best, Marcel Am 18.05.2023 22:32:40 schrieb christoph.thiede(a)student.hpi.uni-potsdam.de <christoph.thiede(a)student.hpi.uni-potsdam.de>: =============== Summary ===============
Change Set: mcAddAnythingToChangeSet Date: 18 May 2023 Author: Christoph Thiede
Makes 'add (all) to current change set' in Monticello code tools capable of class and script definitions.
=============== Diff ===============
ChangeSet>>noteRemovalOf: {class changes} · ct 5/18/2023 22:25 (changed) noteRemovalOf: class "The class is about to be removed from the system. Adjust the receiver to reflect that fact."
- class wantsChangeSetLogging ifFalse: [^ self].
- | c ccname |
- class isString
- ifTrue: [c := self environment classNamed: class. ccname := class , ' class']
- ifFalse: [c := class. ccname := class class name].
- (c notNil and: [c wantsChangeSetLogging not]) ifTrue: [^ self].
(self changeRecorderFor: class)
- noteChangeType: #remove fromClass: class.
- changeRecords removeKey: class class name ifAbsent: [].
- noteChangeType: #remove fromClass: c.
- changeRecords removeKey: ccname ifAbsent: [].
MCAddition>>addToChangeSet: {applying} · ct 5/18/2023 21:33
- addToChangeSet: aChangeSet
- ^ self definition addToChangeSet: aChangeSet
MCClassDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 22:21
- addRemovalToChangeSet: aChangeSet
- aChangeSet noteRemovalOf: self className.
MCClassDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:45
- addToChangeSet: aChangeSet
- aChangeSet addClass: self actualClass.
MCDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:34
- addRemovalToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:34
- addToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCMethodDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:44
- addRemovalToChangeSet: aChangeSet
- aChangeSet removeSelector: self selector class: self actualClass priorMethod: nil lastMethodInfo: nil.
MCMethodDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:42
- addToChangeSet: aChangeSet
- aChangeSet adoptSelector: self selector forClass: self actualClass.
MCModification>>addToChangeSet: {applying} · ct 5/18/2023 21:33
- addToChangeSet: aChangeSet
- ^ self definition addToChangeSet: aChangeSet
MCOperationsBrowser>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:06 (changed) adoptMessageInCurrentChangeset
- selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
- items select: [:each | each definition isMethodDefinition] thenDo: [:item |
- self forItem: item setClassAndSelectorIn: [:class :selector |
- ((item isAddition or: [item isModification]) and: [class includesSelector: selector])
- ifTrue: [ChangeSet current adoptSelector: selector forClass: class].
- item isRemoval
- ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]].
- (selection ifNotNil: [{selection}] ifNil: [items])
- do: [:item | item addToChangeSet: ChangeSet current].
self changed: #annotations.
MCOperationsBrowser>>methodListMenu: {menus} · ct 5/18/2023 22:15 (changed) methodListMenu: aMenu selection ifNil: [items ifNotEmpty: [ aMenu addList: #( ('add all to current change set' adoptMessageInCurrentChangeset))]] ifNotNil: [aMenu addList: #( ('install' installSelection) ('revert (x)' revertSelection) ('browse origin' browseSelectionOrigin) -)]. self unchangedMethods ifNotEmpty: [aMenu addList: #( ('revert unchanged methods...' revertUnchangedMethods) ('filter out unchanged methods...' filterOutUnchangedMethods) -)]. super methodListMenu: aMenu.
- self selectedMessageName ifNil:
- [aMenu addList: #(
- ('add to current change set' adoptMessageInCurrentChangeset))].
^ aMenu
MCPatchOperation>>addToChangeSet: {applying} · ct 5/18/2023 21:32
- addToChangeSet: aChangeSet
- ^ self subclassResponsibility
MCPatchOperation>>applyTo: {applying} · ct 5/18/2023 21:30
- applyTo: anObject
- ^ self subclassResponsibility
MCPostscriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:05
- addToChangeSet: aChangeSet
- super addToChangeSet: aChangeSet.
- aChangeSet
- assurePostscriptExists;
- postscript: aChangeSet postscript , ('"{1}"{2}.' withCRs format: {self packageName. self script}).
MCPreambleDefinition>>addToChangeSet: {installing} · ct 5/18/2023 22:07
- addToChangeSet: aChangeSet
- super addToChangeSet: aChangeSet.
- aChangeSet
- assurePreambleExists;
- preamble: aChangeSet preamble , ('\"{1}"{2}.' withCRs format: {self packageName. self script}).
MCRemoval>>addToChangeSet: {applying} · ct 5/18/2023 21:34
- addToChangeSet: aChangeSet
- ^ self definition addRemovalToChangeSet: aChangeSet
MCRemoval>>applyTo: {applying} · ab 5/24/2003 16:11 (changed and recategorized) applyTo: anObject anObject removeDefinition: definition
MCSaveVersionDialog>>adoptMessageInCurrentChangeset {menus} · ct 5/18/2023 22:00 (changed) adoptMessageInCurrentChangeset
selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
- (items copyWithoutAll: ignore) select: [:each | each definition isMethodDefinition] thenDo: [:item |
- self forItem: item setClassAndSelectorIn: [:class :selector |
- ((item isAddition or: [item isModification]) and: [class includesSelector: selector])
- ifTrue: [ChangeSet current adoptSelector: selector forClass: class].
- item isRemoval
- ifTrue: [ChangeSet current removeSelector: selector class: class priorMethod: nil lastMethodInfo: nil]]].
- (items copyWithoutAll: ignore) do: [:item | item addToChangeSet: ChangeSet current].
self changed: #annotations.
MCScriptDefinition>>addRemovalToChangeSet: {installing} · ct 5/18/2023 21:58
- addRemovalToChangeSet: aChangeSet
- ^ self addToChangeSet: aChangeSet script: ''
MCScriptDefinition>>addToChangeSet: {installing} · ct 5/18/2023 21:58
- addToChangeSet: aChangeSet
- ^ self addToChangeSet: aChangeSet script: self script
MCScriptDefinition>>addToChangeSet:script: {installing} · ct 5/18/2023 22:04
- addToChangeSet: aChangeSet script: aString
- aChangeSet
- assurePostscriptExists;
- postscript: aChangeSet postscript , ('<n><n>(PackageInfo named: <1p>) <2s>: <3p>.' expandMacrosWithArguments: {self packageName. self scriptSelector. aString}).
Sent from Squeak Inbox Talk [https://github.com/hpi-swa-lab/squeak-inbox-talk] ["mcAddAnythingToChangeSet.1.cs"]
squeak-dev@lists.squeakfoundation.org