In a ChangeSorter it is now quite tricky to add and edit a preamble. It's a bit difficult to be sure but so far as I can establish you have to make sure that no class in the class list is selected in order to be able to see any preamble text.
In 5.3 it seems that selecting a changeset is enough to clear any class selection so that we see the preamble; this is how my muscle memory recalls it. In a 20892 image this does not work the same at all. It appears to be a change in selecting a default - ie the the first class in the list of classes - that makes the difference. This manages to clash quite badly with the menu option to add or edit the preamble, making it seem like the preamble stuff is completely broken. It isn't - it's just not very well.
I *think* it must be ChangeSorter>>#showChangeSet: that has changed here; Marcel, what was your intent for that change?
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Borrow money from pessimists--they don't expect it back.
"Re: ChangeSorter preamble eating seems to break broken" ?? Damn You Auto CockUp!
-->> ChangeSorter preamble editing seems to be broken
On 2021-12-29, at 3:41 PM, tim Rowledge tim@rowledge.org wrote:
In a ChangeSorter it is now quite tricky to add and edit a preamble. It's a bit difficult to be sure but so far as I can establish you have to make sure that no class in the class list is selected in order to be able to see any preamble text.
In 5.3 it seems that selecting a changeset is enough to clear any class selection so that we see the preamble; this is how my muscle memory recalls it. In a 20892 image this does not work the same at all. It appears to be a change in selecting a default - ie the the first class in the list of classes - that makes the difference. This manages to clash quite badly with the menu option to add or edit the preamble, making it seem like the preamble stuff is completely broken. It isn't - it's just not very well.
I *think* it must be ChangeSorter>>#showChangeSet: that has changed here; Marcel, what was your intent for that change?
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Borrow money from pessimists--they don't expect it back.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim A conclusion is the place where you got tired of thinking.
Hi Tim --
Marcel, what was your intent for that change?
It was gone by accident. I wanted to minimize the interaction/clicks when working/managing change sets.
Could we spawn an extra window just like with "postscripts"? (Yellow-click on change set, edit/add potsscript, new window appears)
Best, Marcel Am 30.12.2021 05:20:25 schrieb tim Rowledge tim@rowledge.org: "Re: ChangeSorter preamble eating seems to break broken" ?? Damn You Auto CockUp!
-->> ChangeSorter preamble editing seems to be broken
On 2021-12-29, at 3:41 PM, tim Rowledge wrote:
In a ChangeSorter it is now quite tricky to add and edit a preamble. It's a bit difficult to be sure but so far as I can establish you have to make sure that no class in the class list is selected in order to be able to see any preamble text.
In 5.3 it seems that selecting a changeset is enough to clear any class selection so that we see the preamble; this is how my muscle memory recalls it. In a 20892 image this does not work the same at all. It appears to be a change in selecting a default - ie the the first class in the list of classes - that makes the difference. This manages to clash quite badly with the menu option to add or edit the preamble, making it seem like the preamble stuff is completely broken. It isn't - it's just not very well.
I *think* it must be ChangeSorter>>#showChangeSet: that has changed here; Marcel, what was your intent for that change?
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Borrow money from pessimists--they don't expect it back.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim A conclusion is the place where you got tired of thinking.
On 2021-12-30, at 1:05 AM, Marcel Taeumel marcel.taeumel@hpi.de wrote:
Hi Tim --
Marcel, what was your intent for that change?
It was gone by accident. I wanted to minimize the interaction/clicks when working/managing change sets.
Ah, right. I can see why you might want that.
Could we spawn an extra window just like with "postscripts"? (Yellow-click on change set, edit/add potsscript, new window appears)
Well oddly enough, the (unused) ChangeSorter>>#editPreamble method purports to do just that. In ChangeSorter>>#unshiftedChangeSetMenu: it looks as if at one point the expectation was to send it but #addPreamble got used instead. No idea why.
However, it looks like it it really easy to solve this. The problem is that ChangeSorter>>#addPreamble has been using the massive hammer of `self showChangeSet: myChangeSet` since 1999 when al that is required is ` self changed: #messageList. self setContents. self contentsChanged`
Try this -
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Strange OpCodes: STOP: No Op
Hi Tim --
Hopefully fixed in Tools-mt.1099 (Trunk).
Best, Marcel Am 30.12.2021 21:50:01 schrieb tim Rowledge tim@rowledge.org:
On 2021-12-30, at 1:05 AM, Marcel Taeumel marcel.taeumel@hpi.de wrote:
Hi Tim --
Marcel, what was your intent for that change?
It was gone by accident. I wanted to minimize the interaction/clicks when working/managing change sets.
Ah, right. I can see why you might want that.
Could we spawn an extra window just like with "postscripts"? (Yellow-click on change set, edit/add potsscript, new window appears)
Well oddly enough, the (unused) ChangeSorter>>#editPreamble method purports to do just that. In ChangeSorter>>#unshiftedChangeSetMenu: it looks as if at one point the expectation was to send it but #addPreamble got used instead. No idea why.
However, it looks like it it really easy to solve this. The problem is that ChangeSorter>>#addPreamble has been using the massive hammer of `self showChangeSet: myChangeSet` since 1999 when al that is required is ` self changed: #messageList. self setContents. self contentsChanged`
Try this -
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim [http://www.rowledge.org/tim] Strange OpCodes: STOP: No Op
On 2021-12-31, at 1:04 AM, Marcel Taeumel marcel.taeumel@hpi.de wrote:
Hopefully fixed in Tools-mt.1099 (Trunk).
Yes, but... that makes it the same as the MC preambles etc, and whilst consistency is good there is the point that now both are rather ugly.
But that is something we can fix later. At least the pop-up window ought to appear close to the click-point, and with the same colour theme as the originating window to help make it clear what is expected.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Vidistine nuper imagines moventes bonas? = Seen any good movies lately?
squeak-dev@lists.squeakfoundation.org
-
Marcel Taeumel -
tim Rowledge