A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:
(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] "{a MCWorkingCopy(EToys)}"
Best, http://www.hpi.de/ Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 5. April 2020 21:13 Uhr An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
Btw: Do you think that this script could be a useful CI test?
modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph ________________________________ Von: Thiede, Christoph Gesendet: Sonntag, 5. April 2020 21:38:21 An: squeak-dev@lists.squeakfoundation.org Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz
FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:
(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] "{a MCWorkingCopy(EToys)}"
Best, http://www.hpi.de/ Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 5. April 2020 21:13 Uhr An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
Am 07.04.2020 13:27:58 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de: Btw: Do you think that this script could be a useful CI test?
modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph Von: Thiede, Christoph Gesendet: Sonntag, 5. April 2020 21:38:21 An: squeak-dev@lists.squeakfoundation.org Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:
(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] "{a MCWorkingCopy(EToys)}"
Best, [http://www.hpi.de/] Christoph
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 5. April 2020 21:13 Uhr An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz [http://source.squeak.org/inbox/EToys-ct.389.mcz]
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
Wow, I have reinvented the wheel ... Thanks for the tip!
However, does anyone press this button manually? Wouldn't it be helpful if we had an automatic test for it?
testNoChangesInWorkingCopies modifiedPackages := MCWorkingCopy allManagers select: [:w | w checkModified; modified] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph ________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Taeumel, Marcel Gesendet: Dienstag, 7. April 2020 13:50:30 An: gettimothy via Squeak-dev Betreff: Re: [squeak-dev] The Inbox: EToys-ct.389.mcz
[cid:12637bb7-26c8-4ad1-aaa0-1fe3409d9899]
Am 07.04.2020 13:27:58 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
Btw: Do you think that this script could be a useful CI test?
modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph ________________________________ Von: Thiede, Christoph Gesendet: Sonntag, 5. April 2020 21:38:21 An: squeak-dev@lists.squeakfoundation.org Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz
FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:
(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] "{a MCWorkingCopy(EToys)}"
Best, http://www.hpi.de/ Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 5. April 2020 21:13 Uhr An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz
A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
ReleaseBuilder class >> #checkForDirtyPackages Am 07.04.2020 14:08:29 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de: Wow, I have reinvented the wheel ... Thanks for the tip!
However, does anyone press this button manually? Wouldn't it be helpful if we had an automatic test for it?
testNoChangesInWorkingCopies modifiedPackages := MCWorkingCopy allManagers
select: [:w | w checkModified; modified] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Taeumel, Marcel Gesendet: Dienstag, 7. April 2020 13:50:30 An: gettimothy via Squeak-dev Betreff: Re: [squeak-dev] The Inbox: EToys-ct.389.mcz
Am 07.04.2020 13:27:58 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de: Btw: Do you think that this script could be a useful CI test?
modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] thenCollect: [:w | w package]. self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).
Best, Christoph Von: Thiede, Christoph Gesendet: Sonntag, 5. April 2020 21:38:21 An: squeak-dev@lists.squeakfoundation.org Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:
(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w | | packageSnapshot parentSnapshot patch | parentSnapshot := w parentSnapshot. patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot. patch isEmpty not] "{a MCWorkingCopy(EToys)}"
Best, [http://www.hpi.de/] Christoph
Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Sonntag, 5. April 2020 21:13 Uhr An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.389.mcz [http://source.squeak.org/inbox/EToys-ct.389.mcz]
==================== Summary ====================
Name: EToys-ct.389 Author: xyz Time: 5 April 2020, 9:12:49.970061 pm UUID: 843215f1-865c-2e4b-8c42-484a3f382840 Ancestors: EToys-eem.388
Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!
=============== Diff against EToys-eem.388 ===============
Item was removed: - ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') ----- - select - "Ignore selection redraw requests."!
Item was removed: - ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') ----- - selectionInterval: anInterval - "Make my selection span the indicated interval. If the interval extends outside the range of characters of the current text, force it within." - - | mySize | - mySize := paragraph text string size. - self selectFrom: (anInterval start min: mySize) - to: (anInterval stop min: mySize)!
On Sun, Apr 05, 2020 at 07:13:05PM +0000, commits@source.squeak.org wrote:
Name: EToys-ct.389 Author: xyz
xyz ?
Whoops, sorry! ^^ I use to enter these user initials in images that I use for a short test only, not for production. I would not have expected that this information will be saved into each Monticello version ...
Best,
Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von David T. Lewis lewis@mail.msen.com Gesendet: Sonntag, 5. April 2020 21:55:27 An: squeak-dev@lists.squeakfoundation.org Betreff: Re: [squeak-dev] The Inbox: EToys-ct.389.mcz
On Sun, Apr 05, 2020 at 07:13:05PM +0000, commits@source.squeak.org wrote:
Name: EToys-ct.389 Author: xyz
xyz ?
squeak-dev@lists.squeakfoundation.org